Re: linux-next: Fixes tag needs some work in the iommu tree

[Dafna Hirschfeld]

On 15.04.21 23:51, Stephen Rothwell wrote:

Hi all,

In commit

   af5247b169a0 ("iommu/mediatek: Always enable the clk on resume")

Fixes tag

   Fixes: commit c0b57581b73b ("iommu/mediatek: Add power-domain operation")

has these problem(s):

   - leading word 'commit' unexpected



Hi, I'll send v2,

Thanks,
Dafna

linux-next: Fixes tag needs some work in the iommu tree

[Stephen Rothwell]

Hi all,

In commit

  af5247b169a0 ("iommu/mediatek: Always enable the clk on resume")

Fixes tag

  Fixes: commit c0b57581b73b ("iommu/mediatek: Add power-domain operation")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell


pgpG5YnhRgXwK.pgp
Description: OpenPGP digital signature

linux-next: Fixes tag needs some work in the iommu tree

[Stephen Rothwell]

Hi all,

In commit

  9a295ff0ffc9 ("iommu/amd: Print extended features in one line to fix 
divergent log levels")

Fixes tag

  Fixes: 3928aa3f57 ("iommu/amd: Detect and enable guest vAPIC support")

has these problem(s):

  - SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell


pgpZzdMgbx76t.pgp
Description: OpenPGP digital signature

Re: linux-next: Fixes tag needs some work in the iommu tree

[Joerg Roedel]

On Wed, May 20, 2020 at 04:36:31AM +1000, Stephen Rothwell wrote:
> Maybe you meant
> 
> Fixes: b0d1f8741b81 ("iommu/vt-d: Add nested translation helper function")
> Fixes: 56722a4398a3 ("iommu/vt-d: Add bind guest PASID support")

Updated, thanks.

linux-next: Fixes tag needs some work in the iommu tree

[Stephen Rothwell]

Hi all,

In commit

  ef0865631ae3 ("iommu/vt-d: Fix pointer cast warnings on 32 bit")

Fixes tag

  Fixes: d64d47f4f5678 ("iommu/vt-d: Add nested translation helper function")

has these problem(s):

  - Target SHA1 does not exist

Fixes tag

  Fixes: a3bea1a35c083 ("iommu/vt-d: Add bind guest PASID support")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: b0d1f8741b81 ("iommu/vt-d: Add nested translation helper function")
Fixes: 56722a4398a3 ("iommu/vt-d: Add bind guest PASID support")

-- 
Cheers,
Stephen Rothwell


pgp5kq9t9ToOV.pgp
Description: OpenPGP digital signature

linux-next: Fixes tag needs some work in the iommu tree

[Stephen Rothwell]

Hi all,

In commit

  7893b59b1e2d ("iommu/vt-d: Remove global page flush support")

Fixes tag

  Fixes: 1c4f88b7f1f9 ("iommu/vt-d: Shared virtual address in scalable

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

In commit

  b9475b3471f8 ("iommu/mediatek: Fix VLD_PA_RNG register backup when suspend")

Fixes tag

  Fixes: 30e2fccf9512 ("iommu/mediatek: Enlarge the validate PA range

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

In commit

  76ce65464fcd ("iommu/mediatek: Fix iova_to_phys PA start for 4GB mode")

Fixes tag

  Fixes: 30e2fccf9512 ("iommu/mediatek: Enlarge the validate PA range

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell


pgpbmTzqgdeK9.pgp
Description: OpenPGP digital signature