linux-next: Fixes tag needs some work in the sound-asoc tree
Hi all, In commit a4856e15e58b ("ASoC: rsnd: check all BUSIF status when error") Fixes tag Fixes: commit 66c705d07d784 ("SoC: rsnd: add interrupt support for SSI BUSIF buffer") has these problem(s): - leading word 'commit' unexpected -- Cheers, Stephen Rothwell pgphHFEJb4NiG.pgp Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the sound-asoc tree
Hi all, In commit e5448d7ec656 ("ASoC: tlv320adcx140: Fix various style errors and warnings") Fixes tag Fixes: 689c7655b50 ("ASoC: tlv320adcx140: Add the tlv320adcx140 codec driver family") has these problem(s): - SHA1 should be at least 12 digits long Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11 or later) just making sure it is not set (or set to "auto"). Just a hint for the future. -- Cheers, Stephen Rothwell pgpFuAgURq01q.pgp Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the sound-asoc tree
Hi Stephen, On 15/10/2019 14.30, Stephen Rothwell wrote: > Hi all, > > In commit > > a35716a95655 ("ASoC: pcm3168a: Fix serial mode dependent format support") > > Fixes tag > > Fixes: ("ASoC: pcm3168a: Use fixup instead of constraint for channels and > formats") > > has these problem(s): > > - No SHA1 recognised > > Did you mean > > Fixes: cfc28ac124c4 ("ASoC: pcm3168a: Use fixup instead of constraint for > channels and formats") Not again, I have left out the SHA1 to look it up in linux-next which I failed to do. - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
linux-next: Fixes tag needs some work in the sound-asoc tree
Hi all, In commit a35716a95655 ("ASoC: pcm3168a: Fix serial mode dependent format support") Fixes tag Fixes: ("ASoC: pcm3168a: Use fixup instead of constraint for channels and formats") has these problem(s): - No SHA1 recognised Did you mean Fixes: cfc28ac124c4 ("ASoC: pcm3168a: Use fixup instead of constraint for channels and formats") -- Cheers, Stephen Rothwell pgpO0wDffqGJg.pgp Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the sound-asoc tree
Hi all, These actually relate to the sound-asoc-fixes tree. On Wed, 21 Aug 2019 07:04:52 +1000 Stephen Rothwell wrote: > > Hi all, > > In commit > > 0f6fc97501b7 ("ASoC: mchp-i2s-mcc: Wait for RX/TX RDY only if controller is > running") > > Fixes tag > > Fixes: 7e0cdf545a55 ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel > Controller") > > has these problem(s): > > - Target SHA1 does not exist > > Did you mean > > Fixes: b87d37d0231f ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel > Controller") > > In commit > > 988b59467b2b ("ASoC: mchp-i2s-mcc: Fix unprepare of GCLK") > > Fixes tag > > Fixes: 7e0cdf545a55 ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel > Controller") > > has these problem(s): > > - Target SHA1 does not exist > > Did you mean > > Fixes: b87d37d0231f ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel > Controller") -- Cheers, Stephen Rothwell pgpEjdqmZs0CV.pgp Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the sound-asoc tree
Hi all, In commit c9cff337eab3 ("ASoC: mchp-i2s-mcc: Fix simultaneous capture and playback in master mode") Fixes tag Fixes: 7e0cdf545a55 ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel Controller") has these problem(s): - Target SHA1 does not exist Did you mean Fixes: b87d37d0231f ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel Controller") -- Cheers, Stephen Rothwell pgpdcGoONufXN.pgp Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the sound-asoc tree
Hi all, In commit 0f6fc97501b7 ("ASoC: mchp-i2s-mcc: Wait for RX/TX RDY only if controller is running") Fixes tag Fixes: 7e0cdf545a55 ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel Controller") has these problem(s): - Target SHA1 does not exist Did you mean Fixes: b87d37d0231f ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel Controller") In commit 988b59467b2b ("ASoC: mchp-i2s-mcc: Fix unprepare of GCLK") Fixes tag Fixes: 7e0cdf545a55 ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel Controller") has these problem(s): - Target SHA1 does not exist Did you mean Fixes: b87d37d0231f ("ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel Controller") -- Cheers, Stephen Rothwell pgppbUawPq0Bm.pgp Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the sound-asoc tree
Hi all, In commit bed7f1469f08 ("ASoC: cs4349: Use PM ops 'cs4349_runtime_pm'") Fixes tag Fixes: e40da86 ("ASoC: cs4349: Add support for Cirrus Logic CS4349") has these problem(s): - SHA1 should be at least 12 digits long Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11 or later) just making sure it is not set (or set to "auto"). -- Cheers, Stephen Rothwell pgpIh_3Q4zGKm.pgp Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the sound-asoc tree
Hi all, In commit 9b4275c415ac ("ASoC: cs4349: Use PM ops 'cs4349_runtime_pm'") Fixes tag Fixes: e40da86 ("ASoC: cs4349: Add support for Cirrus Logic CS4349") has these problem(s): - SHA1 should be at least 12 digits long Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11 or later) just making sure it is not set (or set to "auto"). -- Cheers, Stephen Rothwell pgpVHETOFiGlW.pgp Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the sound-asoc tree
Mark, On 26/07/2019 15.11, Mark Brown wrote: > On Fri, Jul 26, 2019 at 09:04:37AM +0300, Peter Ujfalusi wrote: > >> Mark: can you either drop the patch and I'll send a new one with fixed >> SHA1 or can you fix the commit message in place? > > Both of which involve rebasing :( Against my better judgement I > rebased. thank you and sorry again... - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Re: linux-next: Fixes tag needs some work in the sound-asoc tree
On Fri, Jul 26, 2019 at 09:04:37AM +0300, Peter Ujfalusi wrote: > Mark: can you either drop the patch and I'll send a new one with fixed > SHA1 or can you fix the commit message in place? Both of which involve rebasing :( Against my better judgement I rebased. signature.asc Description: PGP signature
Re: linux-next: Fixes tag needs some work in the sound-asoc tree
Stephen, On 26/07/2019 0.27, Stephen Rothwell wrote: > Hi all, > > In commit > > 9fcf9139a2fd ("ASoC: ti: davinci-mcasp: Fix clk PDIR handling for i2s > master mode") > > Fixes tag > > Fixes: 2302be4126f52 ("ASoC: davinci-mcasp: Update PDIR (pin direction) > register handling") > > has these problem(s): > > - Target SHA1 does not exist > > Did you mean > > Fixes: ca3d9433349e ("ASoC: davinci-mcasp: Update PDIR (pin direction) > register handling") Indeed this is the correct SHA1, looks like the 2302be4126f52 is on TI's 4.19-LTS branch and it got into the commit message because I have validated first on that before moving on to linux-next. Mark: can you either drop the patch and I'll send a new one with fixed SHA1 or can you fix the commit message in place? Sorry. - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
linux-next: Fixes tag needs some work in the sound-asoc tree
Hi all, In commit 9fcf9139a2fd ("ASoC: ti: davinci-mcasp: Fix clk PDIR handling for i2s master mode") Fixes tag Fixes: 2302be4126f52 ("ASoC: davinci-mcasp: Update PDIR (pin direction) register handling") has these problem(s): - Target SHA1 does not exist Did you mean Fixes: ca3d9433349e ("ASoC: davinci-mcasp: Update PDIR (pin direction) register handling") -- Cheers, Stephen Rothwell pgpaMWeG5Jh3g.pgp Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the sound-asoc tree
On Thu, Jul 11, 2019 at 12:13 AM Stephen Rothwell wrote: > In commit > > 6cd249cfad68 ("ASoC: max98357a: use mdelay for sdmode-delay") > > Fixes tag > > Fixes: cec5b01f8f1c ("ASoC: max98357a: avoid speaker pop when playback > > has these problem(s): > > - Subject has leading but no trailing parentheses > - Subject has leading but no trailing quotes > > Please do not split Fixes tags over more than one line. Also, don't > include blank lines among the tags. I am sorry for this fault. Mark, do you need me to resend the patch to fix the commit message?
linux-next: Fixes tag needs some work in the sound-asoc tree
Hi all, In commit 52db6685932e ("ASoC: simple_card_utils.h: care NULL dai at asoc_simple_debug_dai()") Fixes tag Fixes: commit 0580dde59438 ("ASoC: simple-card-utils: add asoc_simple_debug_info()") has these problem(s): - leading word 'commit' unexpected In commit 6cd249cfad68 ("ASoC: max98357a: use mdelay for sdmode-delay") Fixes tag Fixes: cec5b01f8f1c ("ASoC: max98357a: avoid speaker pop when playback has these problem(s): - Subject has leading but no trailing parentheses - Subject has leading but no trailing quotes Please do not split Fixes tags over more than one line. Also, don't include blank lines among the tags. -- Cheers, Stephen Rothwell pgpT17eFAWqhE.pgp Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the sound-asoc tree
Hi all, In commit 8a90efd15ef6 ("ASoC: vc4: vc4_htmi: consider CPU-Platform possibility") Fixes tag Fixes: commit 6c6de1c9e2bf2 ("ASoC: vc4: vc4_hdmi: don't select unnecessary Platform") has these problem(s): - leading word 'commit' unexpected This as also the case for the whole follogin series of commits :-( -- Cheers, Stephen Rothwell pgpeKT23h6d0f.pgp Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the sound-asoc tree
Hi all, In commit e3303268f9cf ("ASoC: soc-core: don't use soc_find_component() at snd_soc_find_dai()") Fixes tag Fixes: commit b9f2e25c599bb ("ASoC: soc-core: use soc_find_component() at snd_soc_find_dai()") has these problem(s): - leading word 'commit' unexpected -- Cheers, Stephen Rothwell pgpAupxevIeAH.pgp Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the sound-asoc tree
Hi all, In commit 970c43d17835 ("ASoC: SOF: Intel: hda: use the defined ppcap functions") Fixes tag Fixes: 8a300c8fb17 ("ASoC: SOF: Intel: Add HDA controller for Intel DSP") has these problem(s): - SHA1 should be at least 12 digits long Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11 or later) just making sure it is not set (or set to "auto"). -- Cheers, Stephen Rothwell pgprAGMbiglzn.pgp Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the sound-asoc tree
Hi all, In commit e355d3de196f ("ASoC: Mediatek: MT8183: fix compile error") Fixes tag Fixes: 1628fc3f4771 ("ASoC: Mediatek: MT8183: add memory interface data align") has these problem(s): - Subject does not match target commit subject Just use git log -1 --format='Fixes: %h ("%s")' -- Cheers, Stephen Rothwell pgpl2odfsymtp.pgp Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the sound-asoc tree
Hi all, In commit ad6eecbfc01c ("ASoC: cs42xx8: Add regcache mask dirty") Fixes tag Fixes: 0c516b4ff85c ("ASoC: cs42xx8: Add codec driver has these problem(s): - Subject has leading but no trailing parentheses - Subject has leading but no trailing quotes Please do not split Fixes tags over more than one line. -- Cheers, Stephen Rothwell pgppzVJTshkNd.pgp Description: OpenPGP digital signature
RE: linux-next: Fixes tag needs some work in the sound-asoc tree
Hi Do I need to resend the patch? Best regards Wang shengjiu > > In commit > > b06c58c2a1ee ("ASoC: fsl_asrc: Fix the issue about unsupported rate") > > Fixes tag > > Fixes: fff6e03c7b65 ("ASoC: fsl_asrc: add support for 8-30kHz > > has these problem(s): > > - Subject has leading but no trailing parentheses > - Subject has leading but no trailing quotes > > Please do not split fixes tags over more that one line. > > -- > Cheers, > Stephen Rothwell
linux-next: Fixes tag needs some work in the sound-asoc tree
Hi all, In commit b06c58c2a1ee ("ASoC: fsl_asrc: Fix the issue about unsupported rate") Fixes tag Fixes: fff6e03c7b65 ("ASoC: fsl_asrc: add support for 8-30kHz has these problem(s): - Subject has leading but no trailing parentheses - Subject has leading but no trailing quotes Please do not split fixes tags over more that one line. -- Cheers, Stephen Rothwell pgpyoI4hzud8q.pgp Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the sound-asoc tree
Hi all, In commit 825b22e5961a ("ASoC: rsnd: src: fix compiler warnings") Fixes tag Fixes: linux-next commit 7674bec4fc09 ("ASoC: rsnd: update BSDSR/BSDISR handling") has these problem(s): - 'linux-next commit' was unexpected. -- Cheers, Stephen Rothwell pgpOFco1dc8zK.pgp Description: OpenPGP digital signature
Re: linux-next: Fixes tag needs some work in the sound-asoc tree
On 3/17/19 02:28, Stephen Rothwell wrote: > In commit > > 2b13bee38849 ("ASoC: samsung: odroid: Fix clock configuration for 44100 > sample rate") > > Fixes tag > > Fixes: fbeec965b8d1c ("ASoC: samsung: odroid: Fix 32000 sample rate > handling") > > has these problem(s): > > - Target SHA1 does not exist > > Did you mean: > > 1d22c337dc8f ("ASoC: samsung: odroid: Fix 32000 sample rate handling" Yes, I unfortunately used erroneously hash from this -stable commit: commit fbeec965b8d1ca4005f2b63f70fd6ed54a147027 Author: Sylwester Nawrocki Date: Wed Mar 14 17:41:13 2018 +0100 ASoC: samsung: odroid: Fix 32000 sample rate handling [ Upstream commit 1d22c337dc8f3a25638f7262e7bcb5729a34d140 ] In case of sample rates lower than 44100 currently there is too low MCLK frequency set for the CODEC. Playback fails with following errors: $ speaker-test -c2 -t sine -f 1500 -l2 -r 32000 Sine wave rate is 1500.Hz Rate set to 32000Hz (requested 32000Hz) Buffer size range from 128 to 131072 Period size range from 64 to 65536 Using max buffer size 131072 Periods = 4 Unable to set hw params for playback: Invalid argument Setting of hwparams failed: Invalid argument [ 497.883700] max98090 1-0010: Invalid master clock frequency To fix this the I2S root clock's frequency is increased, depending on sampling rate. Signed-off-by: Sylwester Nawrocki Acked-by: Krzysztof Kozlowski Signed-off-by: Mark Brown Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman -- Thanks, Sylwester
linux-next: Fixes tag needs some work in the sound-asoc tree
Hi all, In commit 399706df420e ("ASoC: rsnd: src: fix compiler warnings") Fixes tag Fixes: linux-next commit 7674bec4fc09 ("ASoC: rsnd: update BSDSR/BSDISR handling") has these problem(s): - 'linux-next commit' was unexpected. In commit ba164a49f8f7 ("ASoC: rsnd: src: Avoid a potential deadlock") Fixes tag Fixes: linux-next commit 7674bec4fc09 ("ASoC: rsnd: update BSDSR/BSDISR handling") has these problem(s): - 'linux-next commit' was unexpected. Just use: got log --format='Fixes: %h ("%s")' to generate the Fixes tags. -- Cheers, Stephen Rothwell pgpeSfVohzy2L.pgp Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the sound-asoc tree
Hi all, In commit 2b13bee38849 ("ASoC: samsung: odroid: Fix clock configuration for 44100 sample rate") Fixes tag Fixes: fbeec965b8d1c ("ASoC: samsung: odroid: Fix 32000 sample rate handling") has these problem(s): - Target SHA1 does not exist Did you mean: 1d22c337dc8f ("ASoC: samsung: odroid: Fix 32000 sample rate handling" -- Cheers, Stephen Rothwell pgp1qqRHBQlte.pgp Description: OpenPGP digital signature
linux-next: Fixes tag needs some work in the sound-asoc tree
Hi all, In commit 720734a0b66f ("ASoC: soc-core: use for_each_link_codecs() for dai_link codecs V2") Fixes tag Fixes: 50acc7e49 ("ASoC: core: Fix multi-CODEC setups") has these problem(s): - Target SHA1 does not exist Maybe commit 3f6a125230d8bfcbfe0c06ff0b8eaccbc727acd7? Fixes tag Fixes: 10dff9b0d ("ASoC: soc-core: use for_each_link_codecs() for dai_link codecs") has these problem(s): - SHA1 should be at least 12 digits long In commit 141474c6ac7f ("ASoC: Fixup build error for mt6358") Fixes tag Fixes: commit 6a8d4198ca8 ("ASoC: mediatek: mt6358: add codec driver") has these problem(s): - leading word 'commit' unexpected - SHA1 should be at least 12 digits long -- Cheers, Stephen Rothwell pgp9mhN0q1kQL.pgp Description: OpenPGP digital signature