Re: linux-next: Signed-off-by missing for commit in the device-mapper tree
On Wed, Nov 18 2020 at 3:47pm -0500,
Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> a1e4865b4dda ("dm writecache: remove BUG() and fail gracefully instead")
>
> is missing a Signed-off-by from its author.
Thanks, because I went in a different direction on the code changes I
adjusted author via rebase in my local branch to be me.. but when I
pushed it, it reverted back to being Randy as author on the remote
branch. Turns out the rebase needed to be --continue'd.
Anyway, it should be all set now.
Thanks,
Mike
linux-next: Signed-off-by missing for commit in the device-mapper tree
Hi all,
Commit
a1e4865b4dda ("dm writecache: remove BUG() and fail gracefully instead")
is missing a Signed-off-by from its author.
--
Cheers,
Stephen Rothwell
pgpT399BzR727.pgp
Description: OpenPGP digital signature
linux-next: Signed-off-by missing for commit in the device-mapper tree
Hi all,
Commit
d569b5efedfd ("dm flakey: Properly corrupt multi-page bios.")
is missing a Signed-off-by from its author.
--
Cheers,
Stephen Rothwell
pgpwh3Rpn5zR_.pgp
Description: OpenPGP digital signature
linux-next: Signed-off-by missing for commit in the device-mapper tree
Hi all,
Commit
d2412caad3e3 ("blk-mq: introduce BLK_STS_DEV_RESOURCE")
is missing a Signed-off-by from its committer.
--
Cheers,
Stephen Rothwell
Re: 4.16 genirq change prevents HP servers from booting [was: Re: linux-next: Signed-off-by missing for commit in the device-mapper tree]
On Mon, Jan 15, 2018 at 10:25:01AM -0500, Mike Snitzer wrote:
> On Mon, Jan 15 2018 at 8:27am -0500,
> Stephen Rothwell wrote:
>
> > Hi all,
> >
> > Commit
> >
> > 34e1467da673 ("Revert "genirq/affinity: assign vectors to all possible
> > CPUs"")
> >
> > is missing a Signed-off-by from its author and committer.
> >
> > Reverts are commits as well.
>
> Right, I'm aware. I staged the tree that made some HP servers finally
> work with the latest linux-block 4.16 changes. Without thinking about
> the broader implications. Anyway, I'll drop the revert from
> linux-dm.git's 'for-next'.
>
> Because I'm confident others will hunt down the irq issues.
>
> I think Ming was looking to grab the queue mapping info and CPU related
> info from the affected server.
Hi Mike,
I have cooked a fix today, please see the following link:
https://marc.info/?l=linux-kernel&m=151601867018444&w=2
This issue is clear, and has been described in above link and the
patch. If no objection, I will prepare a formal version.
--
Ming
4.16 genirq change prevents HP servers from booting [was: Re: linux-next: Signed-off-by missing for commit in the device-mapper tree]
On Mon, Jan 15 2018 at 8:27am -0500,
Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> 34e1467da673 ("Revert "genirq/affinity: assign vectors to all possible
> CPUs"")
>
> is missing a Signed-off-by from its author and committer.
>
> Reverts are commits as well.
Right, I'm aware. I staged the tree that made some HP servers finally
work with the latest linux-block 4.16 changes. Without thinking about
the broader implications. Anyway, I'll drop the revert from
linux-dm.git's 'for-next'.
Because I'm confident others will hunt down the irq issues.
I think Ming was looking to grab the queue mapping info and CPU related
info from the affected server.
> Though I do note it actually has a reasonable commit message, thanks.
Semi-reasonable. Lacks detail. The issue is that over the weekend
Laurence found linux-block.git commit 84676c1f21e8ff54befe98 prevents
some HP servers from booting. They'd hang when trying to initialize
their HPSA controller's devices, e.g.:
[ 246.751050] INFO: task systemd-udevd:411 blocked for more than 120
seconds.
[ 246.791852] Tainted: G I 4.15.0-rc4.block.dm.4.16+ #1
[ 246.830650] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables
this message.
[ 246.874637] systemd-udevd D0 411408 0x8004
[ 246.904934] Call Trace:
[ 246.918191] ? __schedule+0x28d/0x870
[ 246.937643] ? _cond_resched+0x15/0x30
[ 246.958222] schedule+0x32/0x80
[ 246.975424] async_synchronize_cookie_domain+0x8b/0x140
[ 247.004452] ? remove_wait_queue+0x60/0x60
[ 247.027335] do_init_module+0xbe/0x219
[ 247.048022] load_module+0x21d6/0x2910
[ 247.069436] ? m_show+0x1c0/0x1c0
[ 247.087999] SYSC_finit_module+0x94/0xe0
[ 247.110392] entry_SYSCALL_64_fastpath+0x1a/0x7d
[ 247.136669] RIP: 0033:0x7f84049287f9
[ 247.156112] RSP: 002b:7ffd13199ab8 EFLAGS: 0246 ORIG_RAX:
0139
[ 247.196883] RAX: ffda RBX: 55b712b59e80 RCX:
7f84049287f9
[ 247.237989] RDX: RSI: 7f8405245099 RDI:
0008
[ 247.279105] RBP: 7f8404bf2760 R08: R09:
55b712b45760
[ 247.320005] R10: 0008 R11: 0246 R12:
0020
[ 247.360625] R13: 7f8404bf2818 R14: 0050 R15:
7f8404bf27b8
[ 247.401062] INFO: task scsi_eh_0:471 blocked for more than 120 seconds.
[ 247.438161] Tainted: G I 4.15.0-rc4.block.dm.4.16+ #1
[ 247.476640] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables
this message.
[ 247.520700] scsi_eh_0 D0 471 2 0x8000
[ 247.551339] Call Trace:
[ 247.564360] ? __schedule+0x28d/0x870
[ 247.584720] schedule+0x32/0x80
[ 247.601294] hpsa_eh_device_reset_handler+0x68c/0x700 [hpsa]
[ 247.633358] ? remove_wait_queue+0x60/0x60
[ 247.656345] scsi_try_bus_device_reset+0x27/0x40
[ 247.682424] scsi_eh_ready_devs+0x53f/0xe20
[ 247.706467] ? __pm_runtime_resume+0x55/0x70
[ 247.730327] scsi_error_handler+0x434/0x5e0
[ 247.754387] ? __schedule+0x295/0x870
[ 247.775420] kthread+0xf5/0x130
[ 247.793461] ? scsi_eh_get_sense+0x240/0x240
[ 247.818008] ? kthread_associate_blkcg+0x90/0x90
[ 247.844759] ret_from_fork+0x1f/0x30
[ 247.865440] INFO: task scsi_id:488 blocked for more than 120 seconds.
[ 247.901112] Tainted: G I 4.15.0-rc4.block.dm.4.16+ #1
[ 247.938743] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables
this message.
[ 247.981092] scsi_id D0 488 1 0x0004
[ 248.010535] Call Trace:
[ 248.023567] ? __schedule+0x28d/0x870
[ 248.044236] ? __switch_to+0x1f5/0x460
[ 248.065776] schedule+0x32/0x80
[ 248.084238] schedule_timeout+0x1d4/0x2f0
[ 248.106184] wait_for_completion+0x123/0x190
[ 248.130759] ? wake_up_q+0x70/0x70
[ 248.150295] flush_work+0x119/0x1a0
[ 248.169238] ? wake_up_worker+0x30/0x30
[ 248.189670] __cancel_work_timer+0x103/0x190
[ 248.213751] ? kobj_lookup+0x10b/0x160
[ 248.235441] disk_block_events+0x6f/0x90
[ 248.257820] __blkdev_get+0x6a/0x480
[ 248.278770] ? bd_acquire+0xd0/0xd0
[ 248.298438] blkdev_get+0x1a5/0x300
[ 248.316587] ? bd_acquire+0xd0/0xd0
[ 248.334814] do_dentry_open+0x202/0x320
[ 248.354372] ? security_inode_permission+0x3c/0x50
[ 248.378818] path_openat+0x537/0x12c0
[ 248.397386] ? vm_insert_page+0x1e0/0x1f0
[ 248.417664] ? vvar_fault+0x75/0x140
[ 248.435811] do_filp_open+0x91/0x100
[ 248.454061] do_sys_open+0x126/0x210
[ 248.472462] entry_SYSCALL_64_fastpath+0x1a/0x7d
[ 248.495438] RIP: 0033:0x7f39e60e1e90
[ 248.513136] RSP: 002b:7ffc4c906ba8 EFLAGS: 0246 ORIG_RAX:
0002
[ 248.550726] RAX: ffda RBX: 5624aead3010 RCX:
7f39e60e1e90
[ 248.586207] RDX: 7f39e60cc0c4 RSI: 00080800 RDI:
7ffc4c906ed0
[ 248.622411] RBP: 7ffc4c906b60 R08: 7f39e60cc140 R09:
7f39e60cc140
[ 248.658704] R10: 001f R11: 0246 R12:
7ffc4c906ed0
[ 248.695771] R13:
linux-next: Signed-off-by missing for commit in the device-mapper tree
Hi all,
Commit
34e1467da673 ("Revert "genirq/affinity: assign vectors to all possible CPUs"")
is missing a Signed-off-by from its author and committer.
Reverts are commits as well.
Though I do note it actually has a reasonable commit message, thanks.
--
Cheers,
Stephen Rothwell
