linux-next: Signed-off-by missing for commit in the gfs2 tree
Hi all,
Commit
d2097641ed78 ("gfs2: Fix invalid block size message")
is missing a Signed-off-by from its committer.
--
Cheers,
Stephen Rothwell
pgpeiVw2fSrXm.pgp
Description: OpenPGP digital signature
linux-next: Signed-off-by missing for commit in the gfs2 tree
Hi all,
Commits
c2af4bc4f3a0 ("gfs2: make recovery workqueue operate on a gfs2 mount point,
not journal")
c8e56050f64f ("gfs2: make gfs2_log_write_page static")
are missing a Signed-off-by from their committer.
--
Cheers,
Stephen Rothwell
pgpM3grGqI18s.pgp
Description: OpenPGP digital signature
linux-next: Signed-off-by missing for commit in the gfs2 tree
Hi all,
Commit
955584707816 ("gfs2: Fix comments to glock_hash_walk")
is missing a Signed-off-by from its committer.
--
Cheers,
Stephen Rothwell
pgpod69Vj66aU.pgp
Description: OpenPGP digital signature
linux-next: Signed-off-by missing for commit in the gfs2 tree
Hi all,
Commit
aa4796e18397 ("gfs2: Fix bad comment for trans_drain")
is missing a Signed-off-by from its committer.
One of the traps of rebasing ...
--
Cheers,
Stephen Rothwell
pgpSMvmBFRMD7.pgp
Description: OpenPGP digital signature
linux-next: Signed-off-by missing for commit in the gfs2 tree
Hi all,
Commit
b15a7defc994 ("gfs2: convert to use DEFINE_SEQ_ATTRIBUTE macro")
is missing a Signed-off-by from its committer.
--
Cheers,
Stephen Rothwell
pgpGwlWDaxL8Y.pgp
Description: OpenPGP digital signature
linux-next: Signed-off-by missing for commit in the gfs2 tree
Hi all,
Commit
de80f184535d ("gfs2: Don't ignore inode write errors during inode_go_sync")
is missing a Signed-off-by from its committer.
--
Cheers,
Stephen Rothwell
pgpM48Iz8Zv2p.pgp
Description: OpenPGP digital signature
linux-next: Signed-off-by missing for commit in the gfs2 tree
Hi all,
Commit
467c82b82836 ("gfs2: clean_journal improperly set sd_log_flush_head")
is missing a Signed-off-by from its committer.
--
Cheers,
Stephen Rothwell
pgpwP3yg72ZZv.pgp
Description: OpenPGP digital signature
Re: linux-next: Signed-off-by missing for commit in the gfs2 tree
On Tue, Dec 11, 2018 at 09:47:43PM +0100, Andreas Grünbacher wrote:
> > Now, after the rebase:
> >
> > Commits
> >
> > 187e4dad3f55 ("gfs2: Remove vestigial bd_ops")
> >
> > is missing a Signed-off-by from its committer.
>
> Yep, I've not asked for a way to get the server to reject or warn
> about such pushes without a reason.
We don't run checks on push that involve iterating through commits,
because most of the pushes we receive are merges and rejecting on a
commit somewhere deep in an octopus merge would just result in angry
maintainers.
Best,
-K
Re: linux-next: Signed-off-by missing for commit in the gfs2 tree
Hi Andreas,
On Tue, 11 Dec 2018 21:47:43 +0100 Andreas Grünbacher
wrote:
>
> Yep, I've not asked for a way to get the server to reject or warn
> about such pushes without a reason.
Sure, but also here's the script I run (which could be run before
pushing) ...
--
#!/bin/bash
if [ "$#" -lt 1 ]; then
printf "Usage: %s \n", "$0" 1>&2
exit 1
fi
commits=$(git rev-list --no-merges "$@")
if [ -z "$commits" ]; then
printf "No commits\n"
exit 0
fi
author_missing=
committer_missing=
print_commits()
{
local t="$1"
shift
s=
is='is'
its='its'
[ "$#" -gt 1 ] && {
s='s'
is='are'
its='their'
}
printf "Commit%s\n\n" "$s"
git log --no-walk --pretty='format: %h ("%s")' "$@"
printf "\n%s missing a Signed-off-by from %s %s%s.\n" "$is" "$its" "$t"
"$s"
printf "\n"
}
for c in $commits; do
ae=$(git log -1 --format='<%ae>%n<%aE>%n %an %n %aN ' "$c" | sort -u)
ce=$(git log -1 --format='<%ce>%n<%cE>%n %cn %n %cN ' "$c" | sort -u)
msg=$(git log -1 --format='%b' "$c")
sob=$(echo "$msg" | sed -En 's/^\s*Signed-off-by:?\s*/ /ip')
am=false
cm=false
grep -i -F -q "$ae" <<<"$sob" ||
am=true
grep -i -F -q "$ce" <<<"$sob" ||
cm=true
"$am" && author_missing+=" $c"
"$cm" && committer_missing+=" $c"
done
if [ "$author_missing" ]; then
print_commits "author" $author_missing
fi
if [ "$committer_missing" ]; then
print_commits "committer" $committer_missing
fi
--
--
Cheers,
Stephen Rothwell
pgpJsac_s6Z9e.pgp
Description: OpenPGP digital signature
Re: linux-next: Signed-off-by missing for commit in the gfs2 tree
Hi,
Am Di., 11. Dez. 2018 um 21:40 Uhr schrieb Stephen Rothwell
:
> Hi all,
>
> On Wed, 12 Dec 2018 07:24:02 +1100 Stephen Rothwell
> wrote:
> >
> > Commit
> >
> > ec702fa79702 ("gfs2: Dump nrpages for inodes and their glocks")
> >
> > is missing a Signed-off-by from its committer.
>
> Now, after the rebase:
>
> Commits
>
> 187e4dad3f55 ("gfs2: Remove vestigial bd_ops")
>
> is missing a Signed-off-by from its committer.
Yep, I've not asked for a way to get the server to reject or warn
about such pushes without a reason.
Thanks,
Andreas
Re: linux-next: Signed-off-by missing for commit in the gfs2 tree
Hi all,
On Wed, 12 Dec 2018 07:24:02 +1100 Stephen Rothwell
wrote:
>
> Commit
>
> ec702fa79702 ("gfs2: Dump nrpages for inodes and their glocks")
>
> is missing a Signed-off-by from its committer.
Now, after the rebase:
Commits
187e4dad3f55 ("gfs2: Remove vestigial bd_ops")
is missing a Signed-off-by from its committer.
--
Cheers,
Stephen Rothwell
pgpzPql1SC7CA.pgp
Description: OpenPGP digital signature
linux-next: Signed-off-by missing for commit in the gfs2 tree
Hi all,
Commit
ec702fa79702 ("gfs2: Dump nrpages for inodes and their glocks")
is missing a Signed-off-by from its committer.
--
Cheers,
Stephen Rothwell
pgp0N5psEY0Zl.pgp
Description: OpenPGP digital signature
linux-next: Signed-off-by missing for commit in the gfs2 tree
Hi all,
Commits
25b76c531970 ("gfs2: add a helper function to get_log_header that can be used
elsewhere")
14e81158a6d6 ("gfs2: add more timing info to journal recovery process")
are missing a Signed-off-by from their committer.
--
Cheers,
Stephen Rothwell
pgpXuDY3_gFZl.pgp
Description: OpenPGP digital signature
linux-next: Signed-off-by missing for commit in the gfs2 tree
Hi all,
Commits
25b76c531970 ("gfs2: add a helper function to get_log_header that can be used
elsewhere")
14e81158a6d6 ("gfs2: add more timing info to journal recovery process")
are missing a Signed-off-by from their committer.
--
Cheers,
Stephen Rothwell
pgpXuDY3_gFZl.pgp
Description: OpenPGP digital signature
Re: linux-next: Signed-off-by missing for commit in the gfs2 tree
- Original Message -
> Hi all,
>
> Commit
>
> b7f5a2cd27b7 ("GFS2: Flush the GFS2 delete workqueue before stopping the
> kernel threads")
>
> is missing a Signed-off-by from its committer.
>
> --
> Cheers,
> Stephen Rothwell
Fixed now. Sorry about that.
Regards,
Bob Peterson
Re: linux-next: Signed-off-by missing for commit in the gfs2 tree
- Original Message -
> Hi all,
>
> Commit
>
> b7f5a2cd27b7 ("GFS2: Flush the GFS2 delete workqueue before stopping the
> kernel threads")
>
> is missing a Signed-off-by from its committer.
>
> --
> Cheers,
> Stephen Rothwell
Fixed now. Sorry about that.
Regards,
Bob Peterson
linux-next: Signed-off-by missing for commit in the gfs2 tree
Hi all,
Commit
b7f5a2cd27b7 ("GFS2: Flush the GFS2 delete workqueue before stopping the
kernel threads")
is missing a Signed-off-by from its committer.
--
Cheers,
Stephen Rothwell
pgpWJTEY8o_ie.pgp
Description: OpenPGP digital signature
linux-next: Signed-off-by missing for commit in the gfs2 tree
Hi all,
Commit
b7f5a2cd27b7 ("GFS2: Flush the GFS2 delete workqueue before stopping the
kernel threads")
is missing a Signed-off-by from its committer.
--
Cheers,
Stephen Rothwell
pgpWJTEY8o_ie.pgp
Description: OpenPGP digital signature
Re: linux-next: Signed-off-by missing for commit in the gfs2 tree
Hi Andreas,
On Wed, 25 Jul 2018 00:23:22 +0200 Andreas Grünbacher
wrote:
>
> 2018-07-25 0:01 GMT+02:00 Stephen Rothwell :
> > Hi all,
> >
> > Commit
> >
> > b6fbc2f6a686 ("GFS2: Fix recovery issues for spectators")
> >
> > is missing a Signed-off-by from its committer. It was rebased.
>
> thanks, I've fixed it now but this is getting rather annoying -- and
> it must happen to others as well. Do you happen to have git hooks that
> prevent this from happening?
No, but I don't rebase stuff (that matters) ;-) I think that someone
did write a hook, but can't remember who, sorry.
What I have is a script that I run over each new set of commits I fetch
that checks these things.
--
Cheers,
Stephen Rothwell
pgphnbCUZluZ8.pgp
Description: OpenPGP digital signature
Re: linux-next: Signed-off-by missing for commit in the gfs2 tree
Hi Andreas,
On Wed, 25 Jul 2018 00:23:22 +0200 Andreas Grünbacher
wrote:
>
> 2018-07-25 0:01 GMT+02:00 Stephen Rothwell :
> > Hi all,
> >
> > Commit
> >
> > b6fbc2f6a686 ("GFS2: Fix recovery issues for spectators")
> >
> > is missing a Signed-off-by from its committer. It was rebased.
>
> thanks, I've fixed it now but this is getting rather annoying -- and
> it must happen to others as well. Do you happen to have git hooks that
> prevent this from happening?
No, but I don't rebase stuff (that matters) ;-) I think that someone
did write a hook, but can't remember who, sorry.
What I have is a script that I run over each new set of commits I fetch
that checks these things.
--
Cheers,
Stephen Rothwell
pgphnbCUZluZ8.pgp
Description: OpenPGP digital signature
Re: linux-next: Signed-off-by missing for commit in the gfs2 tree
Hi Stephen,
2018-07-25 0:01 GMT+02:00 Stephen Rothwell :
> Hi all,
>
> Commit
>
> b6fbc2f6a686 ("GFS2: Fix recovery issues for spectators")
>
> is missing a Signed-off-by from its committer. It was rebased.
thanks, I've fixed it now but this is getting rather annoying -- and
it must happen to others as well. Do you happen to have git hooks that
prevent this from happening?
Thanks,
Andreas
Re: linux-next: Signed-off-by missing for commit in the gfs2 tree
Hi Stephen,
2018-07-25 0:01 GMT+02:00 Stephen Rothwell :
> Hi all,
>
> Commit
>
> b6fbc2f6a686 ("GFS2: Fix recovery issues for spectators")
>
> is missing a Signed-off-by from its committer. It was rebased.
thanks, I've fixed it now but this is getting rather annoying -- and
it must happen to others as well. Do you happen to have git hooks that
prevent this from happening?
Thanks,
Andreas
linux-next: Signed-off-by missing for commit in the gfs2 tree
Hi all,
Commit
b6fbc2f6a686 ("GFS2: Fix recovery issues for spectators")
is missing a Signed-off-by from its committer. It was rebased.
--
Cheers,
Stephen Rothwell
pgpT7fPZVLrkY.pgp
Description: OpenPGP digital signature
linux-next: Signed-off-by missing for commit in the gfs2 tree
Hi all,
Commit
b6fbc2f6a686 ("GFS2: Fix recovery issues for spectators")
is missing a Signed-off-by from its committer. It was rebased.
--
Cheers,
Stephen Rothwell
pgpT7fPZVLrkY.pgp
Description: OpenPGP digital signature
Re: linux-next: Signed-off-by missing for commit in the gfs2 tree
- Original Message -
|
|
| On 16/01/18 20:51, Stephen Rothwell wrote:
| > Hi all,
| >
| > Commit
| >
| >7d2040199855 ("gfs2: Add gfs2_blk2rgrpd comment and fix incorrect use")
| >
| > is missing a Signed-off-by from its author.
| >
| Bob, can you add that?
|
| Steve.
This should be fixed now.
Bob
Re: linux-next: Signed-off-by missing for commit in the gfs2 tree
- Original Message -
|
|
| On 16/01/18 20:51, Stephen Rothwell wrote:
| > Hi all,
| >
| > Commit
| >
| >7d2040199855 ("gfs2: Add gfs2_blk2rgrpd comment and fix incorrect use")
| >
| > is missing a Signed-off-by from its author.
| >
| Bob, can you add that?
|
| Steve.
This should be fixed now.
Bob
Re: linux-next: Signed-off-by missing for commit in the gfs2 tree
On 16/01/18 20:51, Stephen Rothwell wrote:
Hi all,
Commit
7d2040199855 ("gfs2: Add gfs2_blk2rgrpd comment and fix incorrect use")
is missing a Signed-off-by from its author.
Bob, can you add that?
Steve.
Re: linux-next: Signed-off-by missing for commit in the gfs2 tree
On 16/01/18 20:51, Stephen Rothwell wrote:
Hi all,
Commit
7d2040199855 ("gfs2: Add gfs2_blk2rgrpd comment and fix incorrect use")
is missing a Signed-off-by from its author.
Bob, can you add that?
Steve.
linux-next: Signed-off-by missing for commit in the gfs2 tree
Hi all,
Commit
7d2040199855 ("gfs2: Add gfs2_blk2rgrpd comment and fix incorrect use")
is missing a Signed-off-by from its author.
--
Cheers,
Stephen Rothwell
linux-next: Signed-off-by missing for commit in the gfs2 tree
Hi all,
Commit
7d2040199855 ("gfs2: Add gfs2_blk2rgrpd comment and fix incorrect use")
is missing a Signed-off-by from its author.
--
Cheers,
Stephen Rothwell
