linux-next: build failure after merge of the cgroup tree
Hi Tejun,
After merging the cgroup tree, today's linux-next build (x86_64
allmodconfig) failed like this:
mm/vmscan.c: In function 'sane_reclaim':
mm/vmscan.c:178:2: error: implicit declaration of function 'cgroup_on_dfl'
[-Werror=implicit-function-declaration]
if (cgroup_on_dfl(memcg->css.cgroup))
^
Caused by commit
d5028f9f7d8d ("vmscan: fix sane_reclaim helper for legacy memcg")
from Linus' tree interacting with commit
9e10a130d9b6 ("cgroup: replace cgroup_on_dfl() tests in controllers with
cgroup_subsys_on_dfl()")
from the cgroup tree.
We new this was coming, so I have applied the following merge fix patch from
Andrew's tree and can carry it as necessary:
From: Michal Hocko
Subject: vmscan build fix
Signed-off-by: Andrew Morton
---
mm/vmscan.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN mm/vmscan.c~vmscan-build-fix mm/vmscan.c
--- a/mm/vmscan.c~vmscan-build-fix
+++ a/mm/vmscan.c
@@ -175,7 +175,7 @@ static bool sane_reclaim(struct scan_con
if (!memcg)
return true;
#ifdef CONFIG_CGROUP_WRITEBACK
- if (cgroup_on_dfl(memcg->css.cgroup))
+ if (cgroup_subsys_on_dfl(memory_cgrp_subsys))
return true;
#endif
return false;
_
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
linux-next: build failure after merge of the cgroup tree
Hi Tejun,
After merging the cgroup tree, today's linux-next build (x86_64
allmodconfig) failed like this:
mm/vmscan.c: In function 'sane_reclaim':
mm/vmscan.c:178:2: error: implicit declaration of function 'cgroup_on_dfl'
[-Werror=implicit-function-declaration]
if (cgroup_on_dfl(memcg->css.cgroup))
^
Caused by commit
d5028f9f7d8d ("vmscan: fix sane_reclaim helper for legacy memcg")
from Linus' tree interacting with commit
9e10a130d9b6 ("cgroup: replace cgroup_on_dfl() tests in controllers with
cgroup_subsys_on_dfl()")
from the cgroup tree.
We new this was coming, so I have applied the following merge fix patch from
Andrew's tree and can carry it as necessary:
From: Michal Hocko
Subject: vmscan build fix
Signed-off-by: Andrew Morton
---
mm/vmscan.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN mm/vmscan.c~vmscan-build-fix mm/vmscan.c
--- a/mm/vmscan.c~vmscan-build-fix
+++ a/mm/vmscan.c
@@ -175,7 +175,7 @@ static bool sane_reclaim(struct scan_con
if (!memcg)
return true;
#ifdef CONFIG_CGROUP_WRITEBACK
- if (cgroup_on_dfl(memcg->css.cgroup))
+ if (cgroup_subsys_on_dfl(memory_cgrp_subsys))
return true;
#endif
return false;
_
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the cgroup tree
On Wed, Feb 26, 2014 at 05:46:55PM +1100, Stephen Rothwell wrote:
> Hi Tejun,
>
> After merging the cgroup tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> kernel/cgroup.c: In function 'cgroup_mount':
> kernel/cgroup.c:1572:2: error: too few arguments to function 'kernfs_mount'
> dentry = kernfs_mount(fs_type, flags, root->kf_root);
> ^
>
> Caused by commit 2bd59d48ebfb ("cgroup: convert to kernfs") interacting
> with commit fed95bab8d29 ("sysfs: fix namespace refcnt leak") from the
> driver-core.current tree.
>
> I added the following merge fix patch, but it may not be completely
> correct, please check.
Yes, that should be fine for now. I'll soon pull in Greg's tree into
cgroup and apply Li's refcnt fix to cgroup too.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the cgroup tree
On Wed, Feb 26, 2014 at 05:46:55PM +1100, Stephen Rothwell wrote: Hi Tejun, After merging the cgroup tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: kernel/cgroup.c: In function 'cgroup_mount': kernel/cgroup.c:1572:2: error: too few arguments to function 'kernfs_mount' dentry = kernfs_mount(fs_type, flags, root-kf_root); ^ Caused by commit 2bd59d48ebfb (cgroup: convert to kernfs) interacting with commit fed95bab8d29 (sysfs: fix namespace refcnt leak) from the driver-core.current tree. I added the following merge fix patch, but it may not be completely correct, please check. Yes, that should be fine for now. I'll soon pull in Greg's tree into cgroup and apply Li's refcnt fix to cgroup too. Thanks. -- tejun -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
linux-next: build failure after merge of the cgroup tree
Hi Tejun,
After merging the cgroup tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
kernel/cgroup.c: In function 'cgroup_mount':
kernel/cgroup.c:1572:2: error: too few arguments to function 'kernfs_mount'
dentry = kernfs_mount(fs_type, flags, root->kf_root);
^
Caused by commit 2bd59d48ebfb ("cgroup: convert to kernfs") interacting
with commit fed95bab8d29 ("sysfs: fix namespace refcnt leak") from the
driver-core.current tree.
I added the following merge fix patch, but it may not be completely
correct, please check.
From: Stephen Rothwell
Date: Wed, 26 Feb 2014 17:41:51 +1100
Subject: [PATCH] cgroup: fix up for kernfs_mount API change
Signed-off-by: Stephen Rothwell
---
kernel/cgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 306ad0ed19ef..8f4ddbe23d58 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -1569,7 +1569,7 @@ out_unlock:
if (ret)
return ERR_PTR(ret);
- dentry = kernfs_mount(fs_type, flags, root->kf_root);
+ dentry = kernfs_mount(fs_type, flags, root->kf_root, NULL);
if (IS_ERR(dentry))
cgroup_put(>top_cgroup);
return dentry;
--
1.9.0
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpin_qLz1ciX.pgp
Description: PGP signature
linux-next: build failure after merge of the cgroup tree
Hi Tejun, After merging the cgroup tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: kernel/cgroup.c: In function 'cgroup_mount': kernel/cgroup.c:1572:2: error: too few arguments to function 'kernfs_mount' dentry = kernfs_mount(fs_type, flags, root-kf_root); ^ Caused by commit 2bd59d48ebfb (cgroup: convert to kernfs) interacting with commit fed95bab8d29 (sysfs: fix namespace refcnt leak) from the driver-core.current tree. I added the following merge fix patch, but it may not be completely correct, please check. From: Stephen Rothwell s...@canb.auug.org.au Date: Wed, 26 Feb 2014 17:41:51 +1100 Subject: [PATCH] cgroup: fix up for kernfs_mount API change Signed-off-by: Stephen Rothwell s...@canb.auug.org.au --- kernel/cgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/cgroup.c b/kernel/cgroup.c index 306ad0ed19ef..8f4ddbe23d58 100644 --- a/kernel/cgroup.c +++ b/kernel/cgroup.c @@ -1569,7 +1569,7 @@ out_unlock: if (ret) return ERR_PTR(ret); - dentry = kernfs_mount(fs_type, flags, root-kf_root); + dentry = kernfs_mount(fs_type, flags, root-kf_root, NULL); if (IS_ERR(dentry)) cgroup_put(root-top_cgroup); return dentry; -- 1.9.0 -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpin_qLz1ciX.pgp Description: PGP signature
Re: linux-next: build failure after merge of the cgroup tree
On Mon, 2013-04-29 at 15:55 -0700, Tejun Heo wrote: > Benjamin, can you please pick this up? > > Thanks a lot and sorry about the trouble. Done. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the cgroup tree
Hello, On Mon, Apr 29, 2013 at 02:04:33PM +1000, Stephen Rothwell wrote: > I have added the following merge fix patch for today (but it should be > applied to the powerpc tree ASAP). > > From: Stephen Rothwell > Date: Mon, 29 Apr 2013 14:01:44 +1000 > Subject: [PATCH] powerpc: numa.c: using kzalloc/kfree requires including > slab.h > > fixes these build errors: > > arch/powerpc/mm/numa.c: In function 'arch_update_cpu_topology': > arch/powerpc/mm/numa.c:1465:2: error: implicit declaration of function > 'kzalloc' [-Werror=implicit-function-declaration] > arch/powerpc/mm/numa.c:1465:10: error: assignment makes pointer from integer > without a cast [-Werror] > arch/powerpc/mm/numa.c:1497:2: error: implicit declaration of function > 'kfree' [-Werror=implicit-function-declaration] > > Signed-off-by: Stephen Rothwell Acked-by: Tejun Heo Benjamin, can you please pick this up? Thanks a lot and sorry about the trouble. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the cgroup tree
Hello, On Mon, Apr 29, 2013 at 02:04:33PM +1000, Stephen Rothwell wrote: I have added the following merge fix patch for today (but it should be applied to the powerpc tree ASAP). From: Stephen Rothwell s...@canb.auug.org.au Date: Mon, 29 Apr 2013 14:01:44 +1000 Subject: [PATCH] powerpc: numa.c: using kzalloc/kfree requires including slab.h fixes these build errors: arch/powerpc/mm/numa.c: In function 'arch_update_cpu_topology': arch/powerpc/mm/numa.c:1465:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration] arch/powerpc/mm/numa.c:1465:10: error: assignment makes pointer from integer without a cast [-Werror] arch/powerpc/mm/numa.c:1497:2: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration] Signed-off-by: Stephen Rothwell s...@canb.auug.org.au Acked-by: Tejun Heo t...@kernel.org Benjamin, can you please pick this up? Thanks a lot and sorry about the trouble. -- tejun -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the cgroup tree
On Mon, 2013-04-29 at 15:55 -0700, Tejun Heo wrote: Benjamin, can you please pick this up? Thanks a lot and sorry about the trouble. Done. Cheers, Ben. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
linux-next: build failure after merge of the cgroup tree
Hi Tejun,
After merging the cgroup tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
arch/powerpc/mm/numa.c: In function 'arch_update_cpu_topology':
arch/powerpc/mm/numa.c:1465:2: error: implicit declaration of function
'kzalloc' [-Werror=implicit-function-declaration]
arch/powerpc/mm/numa.c:1465:10: error: assignment makes pointer from integer
without a cast [-Werror]
arch/powerpc/mm/numa.c:1497:2: error: implicit declaration of function 'kfree'
[-Werror=implicit-function-declaration]
Caused by commit 30c05350c39d ("powerpc/pseries: Use stop machine to
update cpu maps") from the powerpc tree interacting with (probably)
commit ff794dea52ea ("cpuset: remove include of cgroup.h from cpuset.h")
from the cgroup tree. Removing includes from header files is fraught
with danger ...
The former should have added an include of linux/slab.h to
arch/powerpc/mm/numa.c.
I have added the following merge fix patch for today (but it should be
applied to the powerpc tree ASAP).
From: Stephen Rothwell
Date: Mon, 29 Apr 2013 14:01:44 +1000
Subject: [PATCH] powerpc: numa.c: using kzalloc/kfree requires including
slab.h
fixes these build errors:
arch/powerpc/mm/numa.c: In function 'arch_update_cpu_topology':
arch/powerpc/mm/numa.c:1465:2: error: implicit declaration of function
'kzalloc' [-Werror=implicit-function-declaration]
arch/powerpc/mm/numa.c:1465:10: error: assignment makes pointer from integer
without a cast [-Werror]
arch/powerpc/mm/numa.c:1497:2: error: implicit declaration of function 'kfree'
[-Werror=implicit-function-declaration]
Signed-off-by: Stephen Rothwell
---
arch/powerpc/mm/numa.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
index 2d13f90..490e39c 100644
--- a/arch/powerpc/mm/numa.c
+++ b/arch/powerpc/mm/numa.c
@@ -26,6 +26,7 @@
#include
#include
#include
+#include
#include
#include
#include
--
1.8.1
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpGoyOp37LYQ.pgp
Description: PGP signature
linux-next: build failure after merge of the cgroup tree
Hi Tejun, After merging the cgroup tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: arch/powerpc/mm/numa.c: In function 'arch_update_cpu_topology': arch/powerpc/mm/numa.c:1465:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration] arch/powerpc/mm/numa.c:1465:10: error: assignment makes pointer from integer without a cast [-Werror] arch/powerpc/mm/numa.c:1497:2: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration] Caused by commit 30c05350c39d (powerpc/pseries: Use stop machine to update cpu maps) from the powerpc tree interacting with (probably) commit ff794dea52ea (cpuset: remove include of cgroup.h from cpuset.h) from the cgroup tree. Removing includes from header files is fraught with danger ... The former should have added an include of linux/slab.h to arch/powerpc/mm/numa.c. I have added the following merge fix patch for today (but it should be applied to the powerpc tree ASAP). From: Stephen Rothwell s...@canb.auug.org.au Date: Mon, 29 Apr 2013 14:01:44 +1000 Subject: [PATCH] powerpc: numa.c: using kzalloc/kfree requires including slab.h fixes these build errors: arch/powerpc/mm/numa.c: In function 'arch_update_cpu_topology': arch/powerpc/mm/numa.c:1465:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration] arch/powerpc/mm/numa.c:1465:10: error: assignment makes pointer from integer without a cast [-Werror] arch/powerpc/mm/numa.c:1497:2: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration] Signed-off-by: Stephen Rothwell s...@canb.auug.org.au --- arch/powerpc/mm/numa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c index 2d13f90..490e39c 100644 --- a/arch/powerpc/mm/numa.c +++ b/arch/powerpc/mm/numa.c @@ -26,6 +26,7 @@ #include linux/proc_fs.h #include linux/seq_file.h #include linux/uaccess.h +#include linux/slab.h #include asm/sparsemem.h #include asm/prom.h #include asm/smp.h -- 1.8.1 -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpGoyOp37LYQ.pgp Description: PGP signature
Re: linux-next: build failure after merge of the cgroup tree
On Fri, Sep 14, 2012 at 8:34 PM, Tejun Heo wrote: > On Fri, Sep 14, 2012 at 08:32:28PM +0200, Sedat Dilek wrote: >> Did you pushed this to [1] already? > > Was still building. Pushed out now. > Pulled and works fine here! Thanks to you. - Sedat - P.S.: dmesg checks $ dmesg | egrep 'cgroup|systemd' [0.00] Initializing cgroup subsys cpuset [0.00] Initializing cgroup subsys cpu [0.00] Command line: BOOT_IMAGE=/boot/vmlinuz-3.6.0-rc5-next20120914-3-iniza-generic root=UUID=001AADA61AAD9964 loop=/ubuntu/disks/root.disk ro init=/lib/systemd/systemd [0.00] Kernel command line: BOOT_IMAGE=/boot/vmlinuz-3.6.0-rc5-next20120914-3-iniza-generic root=UUID=001AADA61AAD9964 loop=/ubuntu/disks/root.disk ro init=/lib/systemd/systemd [0.002082] Initializing cgroup subsys cpuacct [0.002087] Initializing cgroup subsys devices [0.002089] Initializing cgroup subsys freezer [0.002092] Initializing cgroup subsys blkio [0.002095] Initializing cgroup subsys perf_event > Thanks. > > -- > tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the cgroup tree
On Fri, Sep 14, 2012 at 8:34 PM, Tejun Heo t...@kernel.org wrote: On Fri, Sep 14, 2012 at 08:32:28PM +0200, Sedat Dilek wrote: Did you pushed this to [1] already? Was still building. Pushed out now. Pulled and works fine here! Thanks to you. - Sedat - P.S.: dmesg checks $ dmesg | egrep 'cgroup|systemd' [0.00] Initializing cgroup subsys cpuset [0.00] Initializing cgroup subsys cpu [0.00] Command line: BOOT_IMAGE=/boot/vmlinuz-3.6.0-rc5-next20120914-3-iniza-generic root=UUID=001AADA61AAD9964 loop=/ubuntu/disks/root.disk ro init=/lib/systemd/systemd [0.00] Kernel command line: BOOT_IMAGE=/boot/vmlinuz-3.6.0-rc5-next20120914-3-iniza-generic root=UUID=001AADA61AAD9964 loop=/ubuntu/disks/root.disk ro init=/lib/systemd/systemd [0.002082] Initializing cgroup subsys cpuacct [0.002087] Initializing cgroup subsys devices [0.002089] Initializing cgroup subsys freezer [0.002092] Initializing cgroup subsys blkio [0.002095] Initializing cgroup subsys perf_event Thanks. -- tejun -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the cgroup tree
On Fri, Sep 14, 2012 at 08:32:28PM +0200, Sedat Dilek wrote: > Did you pushed this to [1] already? Was still building. Pushed out now. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the cgroup tree
On Fri, Sep 14, 2012 at 7:00 PM, Tejun Heo wrote:
> Hello,
>
> On Fri, Sep 14, 2012 at 08:56:29AM +0200, Daniel Wagner wrote:
>> On 14.09.2012 05:17, Stephen Rothwell wrote:
>> >After merging the cgroup tree, today's linux-next build (powerpc
>> >ppc64_defconfig) failed like this:
>> >
>> >drivers/net/tun.c: In function 'tun_alloc_skb':
>> >drivers/net/tun.c:589:2: error: implicit declaration of function
>> >'sock_update_classid' [-Werror=implicit-function-declaration]
>> >
>> >Caused by commit 1f66c0a8833c ("cgroup: net_cls: Move sock_update_classid()
>> >declaration to cls_cgroup.h"). Grep is your friend ...
>
> My apologies. Forgot allmod build.
>
>> >I have used the cgroup tree from next-20120913 for today.
>>
>> Obviously, it is straight forward to fix this but I do not know what
>> is the preferred solution. Shall I spin an updated version of this
>> patch or add a patch on top of the series?
>
> I fixed the commit in tree.
>
> Thanks.
>
Did you pushed this to [1] already?
- Sedat -
[1]
http://git.kernel.org/?p=linux/kernel/git/tj/cgroup.git;a=shortlog;h=refs/heads/for-next
> --
> tejun
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the cgroup tree
Hello,
On Fri, Sep 14, 2012 at 08:56:29AM +0200, Daniel Wagner wrote:
> On 14.09.2012 05:17, Stephen Rothwell wrote:
> >After merging the cgroup tree, today's linux-next build (powerpc
> >ppc64_defconfig) failed like this:
> >
> >drivers/net/tun.c: In function 'tun_alloc_skb':
> >drivers/net/tun.c:589:2: error: implicit declaration of function
> >'sock_update_classid' [-Werror=implicit-function-declaration]
> >
> >Caused by commit 1f66c0a8833c ("cgroup: net_cls: Move sock_update_classid()
> >declaration to cls_cgroup.h"). Grep is your friend ...
My apologies. Forgot allmod build.
> >I have used the cgroup tree from next-20120913 for today.
>
> Obviously, it is straight forward to fix this but I do not know what
> is the preferred solution. Shall I spin an updated version of this
> patch or add a patch on top of the series?
I fixed the commit in tree.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the cgroup tree
Hi Stephen,
On 14.09.2012 05:17, Stephen Rothwell wrote:
Hi Tejun,
After merging the cgroup tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
drivers/net/tun.c: In function 'tun_alloc_skb':
drivers/net/tun.c:589:2: error: implicit declaration of function
'sock_update_classid' [-Werror=implicit-function-declaration]
Caused by commit 1f66c0a8833c ("cgroup: net_cls: Move sock_update_classid()
declaration to cls_cgroup.h"). Grep is your friend ...
Sorry about missing to update tun.c. I *swear* I used grep to search
for sock_update_classid() users. It is not the tool's fault when my
brain is not able to decode the things it wants to tell me.
I have used the cgroup tree from next-20120913 for today.
Obviously, it is straight forward to fix this but I do not know what is
the preferred solution. Shall I spin an updated version of this patch or
add a patch on top of the series?
sorry again,
daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the cgroup tree
Hi Stephen, On 14.09.2012 05:17, Stephen Rothwell wrote: Hi Tejun, After merging the cgroup tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: drivers/net/tun.c: In function 'tun_alloc_skb': drivers/net/tun.c:589:2: error: implicit declaration of function 'sock_update_classid' [-Werror=implicit-function-declaration] Caused by commit 1f66c0a8833c (cgroup: net_cls: Move sock_update_classid() declaration to cls_cgroup.h). Grep is your friend ... Sorry about missing to update tun.c. I *swear* I used grep to search for sock_update_classid() users. It is not the tool's fault when my brain is not able to decode the things it wants to tell me. I have used the cgroup tree from next-20120913 for today. Obviously, it is straight forward to fix this but I do not know what is the preferred solution. Shall I spin an updated version of this patch or add a patch on top of the series? sorry again, daniel -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the cgroup tree
Hello, On Fri, Sep 14, 2012 at 08:56:29AM +0200, Daniel Wagner wrote: On 14.09.2012 05:17, Stephen Rothwell wrote: After merging the cgroup tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: drivers/net/tun.c: In function 'tun_alloc_skb': drivers/net/tun.c:589:2: error: implicit declaration of function 'sock_update_classid' [-Werror=implicit-function-declaration] Caused by commit 1f66c0a8833c (cgroup: net_cls: Move sock_update_classid() declaration to cls_cgroup.h). Grep is your friend ... My apologies. Forgot allmod build. I have used the cgroup tree from next-20120913 for today. Obviously, it is straight forward to fix this but I do not know what is the preferred solution. Shall I spin an updated version of this patch or add a patch on top of the series? I fixed the commit in tree. Thanks. -- tejun -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the cgroup tree
On Fri, Sep 14, 2012 at 7:00 PM, Tejun Heo t...@kernel.org wrote: Hello, On Fri, Sep 14, 2012 at 08:56:29AM +0200, Daniel Wagner wrote: On 14.09.2012 05:17, Stephen Rothwell wrote: After merging the cgroup tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: drivers/net/tun.c: In function 'tun_alloc_skb': drivers/net/tun.c:589:2: error: implicit declaration of function 'sock_update_classid' [-Werror=implicit-function-declaration] Caused by commit 1f66c0a8833c (cgroup: net_cls: Move sock_update_classid() declaration to cls_cgroup.h). Grep is your friend ... My apologies. Forgot allmod build. I have used the cgroup tree from next-20120913 for today. Obviously, it is straight forward to fix this but I do not know what is the preferred solution. Shall I spin an updated version of this patch or add a patch on top of the series? I fixed the commit in tree. Thanks. Did you pushed this to [1] already? - Sedat - [1] http://git.kernel.org/?p=linux/kernel/git/tj/cgroup.git;a=shortlog;h=refs/heads/for-next -- tejun -- To unsubscribe from this list: send the line unsubscribe linux-next in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the cgroup tree
On Fri, Sep 14, 2012 at 08:32:28PM +0200, Sedat Dilek wrote: Did you pushed this to [1] already? Was still building. Pushed out now. Thanks. -- tejun -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
linux-next: build failure after merge of the cgroup tree
Hi Tejun,
After merging the cgroup tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
drivers/net/tun.c: In function 'tun_alloc_skb':
drivers/net/tun.c:589:2: error: implicit declaration of function
'sock_update_classid' [-Werror=implicit-function-declaration]
Caused by commit 1f66c0a8833c ("cgroup: net_cls: Move sock_update_classid()
declaration to cls_cgroup.h"). Grep is your friend ...
I have used the cgroup tree from next-20120913 for today.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpsqvNNIYupE.pgp
Description: PGP signature
linux-next: build failure after merge of the cgroup tree
Hi Tejun, After merging the cgroup tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: drivers/net/tun.c: In function 'tun_alloc_skb': drivers/net/tun.c:589:2: error: implicit declaration of function 'sock_update_classid' [-Werror=implicit-function-declaration] Caused by commit 1f66c0a8833c (cgroup: net_cls: Move sock_update_classid() declaration to cls_cgroup.h). Grep is your friend ... I have used the cgroup tree from next-20120913 for today. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpsqvNNIYupE.pgp Description: PGP signature
