Re: linux-next: build failure after merge of the origin tree

2020-07-30 Thread Stephen Rothwell
Hi all, On Fri, 31 Jul 2020 08:58:36 +1000 Stephen Rothwell wrote: > > After merging the origin tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > In file included from include/linux/random.h:14, > from arch/arm/kernel/signal.c:8: >

linux-next: build failure after merge of the origin tree

2020-07-30 Thread Stephen Rothwell
Hi all, After merging the origin tree, today's linux-next build (arm multi_v7_defconfig) failed like this: In file included from include/linux/random.h:14, from arch/arm/kernel/signal.c:8: arch/arm/include/asm/percpu.h: In function '__my_cpu_offset':

Re: linux-next: build failure after merge of the origin tree

2020-07-30 Thread Kees Cook
On Thu, Jul 30, 2020 at 11:24:44AM -0700, Linus Torvalds wrote: > On Wed, Jul 29, 2020 at 8:17 PM Kees Cook wrote: > > > > I'll look into this more tomorrow. (But yes, __latent_entropy is > > absolutely used for globals already, as you found, but this is the first > > percpu it was applied to...)

Re: linux-next: build failure after merge of the origin tree

2020-07-30 Thread Linus Torvalds
On Wed, Jul 29, 2020 at 8:17 PM Kees Cook wrote: > > I'll look into this more tomorrow. (But yes, __latent_entropy is > absolutely used for globals already, as you found, but this is the first > percpu it was applied to...) Note that it was always per-cpu. The only thing that changed was that

Re: linux-next: build failure after merge of the origin tree

2020-07-30 Thread Kees Cook
On Thu, Jul 30, 2020 at 08:14:07AM +0200, Willy Tarreau wrote: > On Thu, Jul 30, 2020 at 05:22:50AM +0200, Willy Tarreau wrote: > > On Wed, Jul 29, 2020 at 08:17:48PM -0700, Kees Cook wrote: > > > And just another heads-up, the patch[1] (which was never sent to a public > > > list) also breaks

Re: linux-next: build failure after merge of the origin tree

2020-07-30 Thread Will Deacon
On Thu, Jul 30, 2020 at 11:09:23AM +0100, Catalin Marinas wrote: > On Thu, Jul 30, 2020 at 10:59:09AM +0100, Marc Zyngier wrote: > > From 33d819f4efa0a4474b5dc2e4bcaef1b886ca30c3 Mon Sep 17 00:00:00 2001 > > From: Marc Zyngier > > Date: Thu, 30 Jul 2020 10:53:05 +0100 > > Subject: [PATCH] arm64:

Re: linux-next: build failure after merge of the origin tree

2020-07-30 Thread Marc Zyngier
On 2020-07-30 07:14, Willy Tarreau wrote: On Thu, Jul 30, 2020 at 05:22:50AM +0200, Willy Tarreau wrote: On Wed, Jul 29, 2020 at 08:17:48PM -0700, Kees Cook wrote: > And just another heads-up, the patch[1] (which was never sent to a public > list) also breaks arm64 (circular header needs?):

Re: linux-next: build failure after merge of the origin tree

2020-07-30 Thread Catalin Marinas
On Thu, Jul 30, 2020 at 10:59:09AM +0100, Marc Zyngier wrote: > From 33d819f4efa0a4474b5dc2e4bcaef1b886ca30c3 Mon Sep 17 00:00:00 2001 > From: Marc Zyngier > Date: Thu, 30 Jul 2020 10:53:05 +0100 > Subject: [PATCH] arm64: Drop unnecessary include from asm/smp.h > > asm/pointer_auth.h is not

Re: linux-next: build failure after merge of the origin tree

2020-07-30 Thread Willy Tarreau
On Thu, Jul 30, 2020 at 05:22:50AM +0200, Willy Tarreau wrote: > On Wed, Jul 29, 2020 at 08:17:48PM -0700, Kees Cook wrote: > > And just another heads-up, the patch[1] (which was never sent to a public > > list) also breaks arm64 (circular header needs?): > (...) > > Definitely, we've just got a

Re: linux-next: build failure after merge of the origin tree

2020-07-29 Thread Willy Tarreau
Hi Kees, On Wed, Jul 29, 2020 at 08:17:48PM -0700, Kees Cook wrote: > And just another heads-up, the patch[1] (which was never sent to a public > list) also breaks arm64 (circular header needs?): (...) Definitely, we've just got a report about this, I'll have a look once I'm at the office. I'd

Re: linux-next: build failure after merge of the origin tree

2020-07-29 Thread Kees Cook
On Wed, Jul 29, 2020 at 04:43:04PM -0700, Linus Torvalds wrote: > On Wed, Jul 29, 2020 at 4:08 PM Stephen Rothwell > wrote: > > > > include/linux/random.h:123:24: error: variable 'net_rand_state' with > > 'latent_entropy' attribute must not be local > > 123 | DECLARE_PER_CPU(struct rnd_state,

Re: linux-next: build failure after merge of the origin tree

2020-07-29 Thread Willy Tarreau
On Wed, Jul 29, 2020 at 07:12:58PM -0700, Linus Torvalds wrote: > On Wed, Jul 29, 2020 at 5:09 PM Linus Torvalds > wrote: > > > > Removing the __latent_entropy marker obviously fixes things. > > Ok, I did that for now. I spent a few minutes looking at the gcc > plugin in case I'd be hit by some

Re: linux-next: build failure after merge of the origin tree

2020-07-29 Thread Linus Torvalds
On Wed, Jul 29, 2020 at 5:09 PM Linus Torvalds wrote: > > Removing the __latent_entropy marker obviously fixes things. Ok, I did that for now. I spent a few minutes looking at the gcc plugin in case I'd be hit by some sudden stroke of genius, but that didn't happen, so let's avoid the issue

Re: linux-next: build failure after merge of the origin tree

2020-07-29 Thread Linus Torvalds
On Wed, Jul 29, 2020 at 4:43 PM Linus Torvalds wrote: > > Ok, this shows a limitation of my allmodconfig testing (and all my > normal builds) - no plugins. So that problem wasn't as obvious as it > should have been. Ok, that was easy to install and get the coverage, and now I see the error.

Re: linux-next: build failure after merge of the origin tree

2020-07-29 Thread Linus Torvalds
On Wed, Jul 29, 2020 at 4:08 PM Stephen Rothwell wrote: > > include/linux/random.h:123:24: error: variable 'net_rand_state' with > 'latent_entropy' attribute must not be local > 123 | DECLARE_PER_CPU(struct rnd_state, net_rand_state) __latent_entropy; Hmm. Ok, this shows a limitation of my

linux-next: build failure after merge of the origin tree

2020-07-29 Thread Stephen Rothwell
Hi all, After merging the origin tree, today's linux-next build (x86_64 allmodconfig) failed like this: In file included from include/asm-generic/percpu.h:7, from arch/x86/include/asm/percpu.h:556, from arch/x86/include/asm/preempt.h:6, from

Re: linux-next: build failure after merge of the origin tree

2020-06-05 Thread Jessica Yu
+++ Josh Poimboeuf [04/06/20 19:04 -0500]: On Fri, Jun 05, 2020 at 08:37:15AM +1000, Stephen Rothwell wrote: Hi all, After merging the origin tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: kernel/module.c: In function 'do_init_module': kernel/module.c:3593:2:

Re: linux-next: build failure after merge of the origin tree

2020-06-04 Thread Josh Poimboeuf
On Fri, Jun 05, 2020 at 08:37:15AM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the origin tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > kernel/module.c: In function 'do_init_module': > kernel/module.c:3593:2: error: implicit declaration of

linux-next: build failure after merge of the origin tree

2020-06-04 Thread Stephen Rothwell
Hi all, After merging the origin tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: kernel/module.c: In function 'do_init_module': kernel/module.c:3593:2: error: implicit declaration of function 'module_enable_ro'; did you mean 'module_enable_x'?

Re: linux-next: build failure after merge of the origin tree

2012-10-09 Thread Stephen Rothwell
Hi, On Wed, 10 Oct 2012 08:52:21 +0900 Yasuaki Ishimatsu wrote: > > 2012/10/10 8:45, Andrew Morton wrote: > > On Wed, 10 Oct 2012 10:21:50 +1100 Stephen Rothwell > > wrote: > > > >> Hi Linus, > >> > >> In Linus' tree, today's linux-next build (powerpc ppc64_defconfig) failed > >> like this: >

Re: linux-next: build failure after merge of the origin tree

2012-10-09 Thread Stephen Rothwell
Hi Andrew, On Tue, 9 Oct 2012 16:45:14 -0700 Andrew Morton wrote: > > On Wed, 10 Oct 2012 10:21:50 +1100 Stephen Rothwell > wrote: > > > I can't see what the point of the "pfn" variable is > > This: > > --- a/arch/powerpc/platforms/pseries/hotplug-memory.c~a > +++

Re: linux-next: build failure after merge of the origin tree

2012-10-09 Thread Yasuaki Ishimatsu
Hi Stephen, 2012/10/10 8:45, Andrew Morton wrote: On Wed, 10 Oct 2012 10:21:50 +1100 Stephen Rothwell wrote: Hi Linus, In Linus' tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: arch/powerpc/platforms/pseries/hotplug-memory.c: In function

Re: linux-next: build failure after merge of the origin tree

2012-10-09 Thread Andrew Morton
On Wed, 10 Oct 2012 10:21:50 +1100 Stephen Rothwell wrote: > Hi Linus, > > In Linus' tree, today's linux-next build (powerpc ppc64_defconfig) failed > like this: > > arch/powerpc/platforms/pseries/hotplug-memory.c: In function > 'pseries_remove_memblock': >

linux-next: build failure after merge of the origin tree

2012-10-09 Thread Stephen Rothwell
Hi Linus, In Linus' tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: arch/powerpc/platforms/pseries/hotplug-memory.c: In function 'pseries_remove_memblock': arch/powerpc/platforms/pseries/hotplug-memory.c:103:17: error: unused variable 'pfn' [-Werror=unused-variable]

linux-next: build failure after merge of the origin tree

2012-10-09 Thread Stephen Rothwell
Hi Linus, In Linus' tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: arch/powerpc/platforms/pseries/hotplug-memory.c: In function 'pseries_remove_memblock': arch/powerpc/platforms/pseries/hotplug-memory.c:103:17: error: unused variable 'pfn' [-Werror=unused-variable]

Re: linux-next: build failure after merge of the origin tree

2012-10-09 Thread Andrew Morton
On Wed, 10 Oct 2012 10:21:50 +1100 Stephen Rothwell s...@canb.auug.org.au wrote: Hi Linus, In Linus' tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: arch/powerpc/platforms/pseries/hotplug-memory.c: In function 'pseries_remove_memblock':

Re: linux-next: build failure after merge of the origin tree

2012-10-09 Thread Yasuaki Ishimatsu
Hi Stephen, 2012/10/10 8:45, Andrew Morton wrote: On Wed, 10 Oct 2012 10:21:50 +1100 Stephen Rothwell s...@canb.auug.org.au wrote: Hi Linus, In Linus' tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: arch/powerpc/platforms/pseries/hotplug-memory.c: In function

Re: linux-next: build failure after merge of the origin tree

2012-10-09 Thread Stephen Rothwell
Hi Andrew, On Tue, 9 Oct 2012 16:45:14 -0700 Andrew Morton a...@linux-foundation.org wrote: On Wed, 10 Oct 2012 10:21:50 +1100 Stephen Rothwell s...@canb.auug.org.au wrote: I can't see what the point of the pfn variable is This: ---

Re: linux-next: build failure after merge of the origin tree

2012-10-09 Thread Stephen Rothwell
Hi, On Wed, 10 Oct 2012 08:52:21 +0900 Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com wrote: 2012/10/10 8:45, Andrew Morton wrote: On Wed, 10 Oct 2012 10:21:50 +1100 Stephen Rothwell s...@canb.auug.org.au wrote: Hi Linus, In Linus' tree, today's linux-next build (powerpc