Re: linux-next: build warning after merge of the arm-soc tree
On 06/04/2021 02:45, Stephen Rothwell wrote:
> Hi all,
>
> After merging the arm-soc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/clk/socfpga/clk-gate.c: In function 'socfpga_clk_recalc_rate':
> drivers/clk/socfpga/clk-gate.c:102:7: warning: cast from pointer to integer
> of different size [-Wpointer-to-int-cast]
> 102 | if ((int) socfpgaclk->div_reg & SOCFPGA_GPIO_DB_CLK_OFFSET)
> | ^
>
> Exposed by commit
>
> cdb1e8b4f4c2 ("clk: socfpga: allow compile testing of Stratix 10 / Agilex
> clocks")
> 552418658acd ("clk: socfpga: use ARCH_INTEL_SOCFPGA also for 32-bit ARM
> SoCs (and compile test)")
>
Thanks Stephen. This is a result of compile testing and was already
fixed via clk tree. You should not have the warning after all the merges.
https://lore.kernel.org/lkml/20210314110709.32599-1-krzysztof.kozlow...@canonical.com/
Best regards,
Krzysztof
linux-next: build warning after merge of the arm-soc tree
Hi all,
After merging the arm-soc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/clk/socfpga/clk-gate.c: In function 'socfpga_clk_recalc_rate':
drivers/clk/socfpga/clk-gate.c:102:7: warning: cast from pointer to integer of
different size [-Wpointer-to-int-cast]
102 | if ((int) socfpgaclk->div_reg & SOCFPGA_GPIO_DB_CLK_OFFSET)
| ^
Exposed by commit
cdb1e8b4f4c2 ("clk: socfpga: allow compile testing of Stratix 10 / Agilex
clocks")
552418658acd ("clk: socfpga: use ARCH_INTEL_SOCFPGA also for 32-bit ARM SoCs
(and compile test)")
--
Cheers,
Stephen Rothwell
pgp2YWcgWen7d.pgp
Description: OpenPGP digital signature
linux-next: build warning after merge of the arm-soc tree
Hi all,
After merging the arm-soc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/usb/gadget/udc/lpc32xx_udc.c: In function 'udc_pop_fifo':
drivers/usb/gadget/udc/lpc32xx_udc.c:1156:11: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
switch (((u32) data) & 0x3) {
^
drivers/usb/gadget/udc/lpc32xx_udc.c: In function 'udc_stuff_fifo':
drivers/usb/gadget/udc/lpc32xx_udc.c:1257:11: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
switch (((u32) data) & 0x3) {
^
drivers/usb/gadget/udc/lpc32xx_udc.c: In function 'udc_handle_ep0_setup':
drivers/usb/gadget/udc/lpc32xx_udc.c:2230:3: warning: this statement may fall
through [-Wimplicit-fallthrough=]
switch (reqtype) {
^~
drivers/usb/gadget/udc/lpc32xx_udc.c:2269:2: note: here
case USB_REQ_SET_ADDRESS:
^~~~
Exposed by commit
50ad15282e7c ("usb: udc: lpc32xx: allow compile-testing")
--
Cheers,
Stephen Rothwell
pgpAddZ8sHAKk.pgp
Description: OpenPGP digital signature
linux-next: build warning after merge of the arm-soc tree
Hi all,
After merging the arm-soc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
In file included from include/linux/kernel.h:15,
from include/linux/list.h:9,
from include/linux/module.h:9,
from drivers/dma/iop-adma.c:13:
drivers/dma/iop-adma.c: In function '__iop_adma_slot_cleanup':
drivers/dma/iop-adma.c:118:12: warning: format '%x' expects argument of type
'unsigned int', but argument 6 has type 'dma_addr_t' {aka 'long long unsigned
int'} [-Wformat=]
pr_debug("\tcookie: %d slot: %d busy: %d "
^
include/linux/printk.h:288:21: note: in definition of macro 'pr_fmt'
#define pr_fmt(fmt) fmt
^~~
include/linux/dynamic_debug.h:143:2: note: in expansion of macro
'__dynamic_func_call'
__dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
^~~
include/linux/dynamic_debug.h:153:2: note: in expansion of macro
'_dynamic_func_call'
_dynamic_func_call(fmt, __dynamic_pr_debug, \
^~
include/linux/printk.h:336:2: note: in expansion of macro 'dynamic_pr_debug'
dynamic_pr_debug(fmt, ##__VA_ARGS__)
^~~~
drivers/dma/iop-adma.c:118:3: note: in expansion of macro 'pr_debug'
pr_debug("\tcookie: %d slot: %d busy: %d "
^~~~
drivers/dma/iop-adma.c:119:18: note: format string is defined here
"this_desc: %#x next_desc: %#llx ack: %d\n",
~~^
%#llx
Introduced (or exposed?) by commit
00c9755524fb ("dmaengine: iop-adma: use correct printk format strings")
--
Cheers,
Stephen Rothwell
pgpL8prUofAJq.pgp
Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the arm-soc tree
On Fri, May 3, 2019 at 2:49 AM Linus Walleij wrote: > > On Tue, Apr 30, 2019 at 12:28 AM Stephen Rothwell > wrote: > > > After merging the arm-soc tree, today's linux-next build > > (x86_64 allmodconfig) produced this warning: > > > > drivers/clocksource/timer-ixp4xx.c:78:20: warning: > > 'ixp4xx_read_sched_clock' defined but not used [-Wunused-function] > > static u64 notrace ixp4xx_read_sched_clock(void) > > ^~~ > > This is kind of normal for timer drivers, as the sched_clock() call is > #ifdef:ed > for CONFIG_ARM, it is not uniformly available on all archs. This appears > as a side effect of COMPILE_TEST which I think is fair to produce > things like this. Could you send a fixup patch to mark the function __maybe_unused or move it into the #ifdef? Arnd
Re: linux-next: build warning after merge of the arm-soc tree
On Tue, Apr 30, 2019 at 12:28 AM Stephen Rothwell wrote: > After merging the arm-soc tree, today's linux-next build > (x86_64 allmodconfig) produced this warning: > > drivers/clocksource/timer-ixp4xx.c:78:20: warning: 'ixp4xx_read_sched_clock' > defined but not used [-Wunused-function] > static u64 notrace ixp4xx_read_sched_clock(void) > ^~~ This is kind of normal for timer drivers, as the sched_clock() call is #ifdef:ed for CONFIG_ARM, it is not uniformly available on all archs. This appears as a side effect of COMPILE_TEST which I think is fair to produce things like this. Yours, Linus Walleij
linux-next: build warning after merge of the arm-soc tree
Hi all,
After merging the arm-soc tree, today's linux-next build
(x86_64 allmodconfig) produced this warning:
drivers/clocksource/timer-ixp4xx.c:78:20: warning: 'ixp4xx_read_sched_clock'
defined but not used [-Wunused-function]
static u64 notrace ixp4xx_read_sched_clock(void)
^~~
Introduced by commit
13e0b4059b98 ("clocksource/drivers/ixp4xx: Add driver")
--
Cheers,
Stephen Rothwell
pgp0MHNlfKJ_C.pgp
Description: OpenPGP digital signature
linux-next: build warning after merge of the arm-soc tree
Hi all,
After merging the arm-soc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/pinctrl/pinconf.c: In function 'pinconf_pins_show':
drivers/pinctrl/pinconf.c:299:28: warning: unused variable 'ops'
[-Wunused-variable]
const struct pinconf_ops *ops = pctldev->desc->confops;
^
drivers/pinctrl/pinconf.c: In function 'pinconf_groups_show':
drivers/pinctrl/pinconf.c:346:28: warning: unused variable 'ops'
[-Wunused-variable]
const struct pinconf_ops *ops = pctldev->desc->confops;
^
Introduced by commit c420619d5177 ("pinctrl: pinconf: remove checks on
ops->pin_config_get").
Sorry, that I did not notice this earlier.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpdwEz2g1Tw7.pgp
Description: PGP signature
