linux-next: build warning after merge of the gpio tree
Hi all,
After merging the gpio tree, today's linux-next build (htmldocs) produced
this warning:
Documentation/admin-guide/gpio/gpio-mockup.rst: WARNING: document isn't
included in any toctree
Introduced by commit
2fd1abe99e5f ("Documentation: gpio: add documentation for gpio-mockup")
--
Cheers,
Stephen Rothwell
pgpFrihq1JPs7.pgp
Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the gpio tree
On Thu, Jun 27, 2019 at 9:20 AM Stephen Rothwell wrote:
> After merging the gpio tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/gpio/gpio-amd-fch.c: In function 'amd_fch_gpio_probe':
> drivers/gpio/gpio-amd-fch.c:171:49: warning: passing argument 2 of
> 'devm_ioremap_resource' discards 'const' qualifier from pointer target type
> [-Wdiscarded-qualifiers]
> priv->base = devm_ioremap_resource(&pdev->dev, &amd_fch_gpio_iores);
> ^~~
> In file included from include/linux/platform_device.h:13,
> from drivers/gpio/gpio-amd-fch.c:15:
> include/linux/device.h:708:15: note: expected 'struct resource *' but
> argument is of type 'const struct resource *'
> void __iomem *devm_ioremap_resource(struct device *dev, struct resource
> *res);
>^
>
> Introduced by commit
>
> 9bb2e0452508 ("gpio: amd: Make resource struct const")
OK I dropped this commit until Enrico get some time to figure out
what's going wrong here.
Yours,
Linus Walleij
linux-next: build warning after merge of the gpio tree
Hi all,
After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/gpio/gpio-amd-fch.c: In function 'amd_fch_gpio_probe':
drivers/gpio/gpio-amd-fch.c:171:49: warning: passing argument 2 of
'devm_ioremap_resource' discards 'const' qualifier from pointer target type
[-Wdiscarded-qualifiers]
priv->base = devm_ioremap_resource(&pdev->dev, &amd_fch_gpio_iores);
^~~
In file included from include/linux/platform_device.h:13,
from drivers/gpio/gpio-amd-fch.c:15:
include/linux/device.h:708:15: note: expected 'struct resource *' but argument
is of type 'const struct resource *'
void __iomem *devm_ioremap_resource(struct device *dev, struct resource *res);
^
Introduced by commit
9bb2e0452508 ("gpio: amd: Make resource struct const")
--
Cheers,
Stephen Rothwell
pgpiLLH7f09vH.pgp
Description: OpenPGP digital signature
linux-next: build warning after merge of the gpio tree
Hi Linus,
After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/gpio/gpio-amd-fch.c: In function 'amd_fch_gpio_probe':
drivers/gpio/gpio-amd-fch.c:164:49: warning: passing argument 2 of
'devm_ioremap_resource' discards 'const' qualifier from pointer target type
[-Wdiscarded-qualifiers]
priv->base = devm_ioremap_resource(&pdev->dev, &amd_fch_gpio_iores);
^~~
In file included from include/linux/platform_device.h:14,
from drivers/gpio/gpio-amd-fch.c:15:
include/linux/device.h:709:15: note: expected 'struct resource *' but argument
is of type 'const struct resource *'
void __iomem *devm_ioremap_resource(struct device *dev, struct resource *res);
^
Introduced by commit
e09d168f13f0 ("gpio: AMD G-Series PCH gpio driver")
--
Cheers,
Stephen Rothwell
pgp7P076MTKpC.pgp
Description: OpenPGP digital signature
linux-next: build warning after merge of the gpio tree
Hi Linus,
After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/gpio/gpiolib-acpi.c: In function 'acpi_gpio_adr_space_handler':
drivers/gpio/gpiolib-acpi.c:911:8: warning: unused variable 'err'
[-Wunused-variable]
int err;
^~~
Introduced by commit
21abf103818a ("gpio: Pass a flag to gpiochip_request_own_desc()")
--
Cheers,
Stephen Rothwell
pgpku3TQLB4lw.pgp
Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the gpio tree
Hi Linus,
On Tue, Nov 06, 2018 at 12:15:02PM +1100, Stephen Rothwell wrote:
> After merging the gpio tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> drivers/gpio/gpiolib.c:1514:12: warning: 'devm_gpio_chip_match' defined but
> not used [-Wunused-function]
> static int devm_gpio_chip_match(struct device *dev, void *res, void *data)
> ^~~~
>
> Caused by commit
>
> 48207d7595d2 ("gpio: drop devm_gpiochip_remove()")
I noticed this, too, but didn't tell immediately because I thought I'd
have to resent this patch and then forgot as you applied yourself.
Sorry for that, the obvious resolution is to drop
devm_gpio_chip_match(). Feel free to squash that into 48207d7595d2. If
your branch is already stable I can provide a patch for that.
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
linux-next: build warning after merge of the gpio tree
Hi Linus,
After merging the gpio tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
drivers/gpio/gpiolib.c:1514:12: warning: 'devm_gpio_chip_match' defined but not
used [-Wunused-function]
static int devm_gpio_chip_match(struct device *dev, void *res, void *data)
^~~~
Caused by commit
48207d7595d2 ("gpio: drop devm_gpiochip_remove()")
--
Cheers,
Stephen Rothwell
pgpIxmvuA4rA8.pgp
Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the gpio tree
On Thu, Jan 11, 2018 at 5:06 AM, Stephen Rothwell wrote:
> Hi Linus,
>
> After merging the gpio tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> drivers/gpio/Kconfig:13:error: recursive dependency detected!
> drivers/gpio/Kconfig:13:symbol GPIOLIB is selected by STX104
> drivers/iio/adc/Kconfig:699:symbol STX104 depends on ISA_BUS_API
> arch/Kconfig:821: symbol ISA_BUS_API is selected by GPIO_WINBOND
> drivers/gpio/Kconfig:701: symbol GPIO_WINBOND depends on GPIOLIB
> For a resolution refer to Documentation/kbuild/kconfig-language.txt
> subsection "Kconfig recursive dependency limitations"
>
> Presumably introduced by commit
>
> a0d65009411c ("gpio: winbond: Add driver")
Thanks, Arnd already patched it up quickly!
Yours,
Linus Walleij
linux-next: build warning after merge of the gpio tree
Hi Linus,
After merging the gpio tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
drivers/gpio/Kconfig:13:error: recursive dependency detected!
drivers/gpio/Kconfig:13:symbol GPIOLIB is selected by STX104
drivers/iio/adc/Kconfig:699:symbol STX104 depends on ISA_BUS_API
arch/Kconfig:821: symbol ISA_BUS_API is selected by GPIO_WINBOND
drivers/gpio/Kconfig:701: symbol GPIO_WINBOND depends on GPIOLIB
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
Presumably introduced by commit
a0d65009411c ("gpio: winbond: Add driver")
--
Cheers,
Stephen Rothwell
linux-next: build warning after merge of the gpio tree
Hi Linus,
After merging the gpio tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
drivers/gpio/gpiolib.c: In function 'gpiochip_irqchip_init_valid_mask':
drivers/gpio/gpiolib.c:1474:6: warning: unused variable 'i' [-Wunused-variable]
int i;
^
Introduced by commit
923a654c186c ("gpiolib: Re-use bitmap_fill() instead of open coded loop")
--
Cheers,
Stephen Rothwell
linux-next: build warning after merge of the gpio tree
Hi Linus, After merging the gpio tree, today's linux-next build (x86_64 allmodconfig) produced this warning: drivers/gpio/gpiolib-acpi.c: In function 'acpi_gpiochip_add': drivers/gpio/gpiolib-acpi.c:925:9: warning: 'lflags' may be used uninitialized in this function [-Wmaybe-uninitialized] ret = gpiod_hog(desc, name, lflags, dflags); ^ drivers/gpio/gpiolib-acpi.c:912:16: note: 'lflags' was declared here unsigned int lflags, dflags; ^ drivers/gpio/gpiolib-acpi.c:925:7: warning: 'dflags' may be used uninitialized in this function [-Wmaybe-uninitialized] ret = gpiod_hog(desc, name, lflags, dflags); ^ drivers/gpio/gpiolib-acpi.c:912:24: note: 'dflags' was declared here unsigned int lflags, dflags; ^ These presumably have appeared since -Wmaybe-uninitialized has been reenabled in Linus Torvald's tree. -- Cheers, Stephen Rothwell
linux-next: build warning after merge of the gpio tree
Hi Linus,
After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
WARNING: modpost: missing MODULE_LICENSE() in drivers/gpio/gpio-aspeed.o
Introduced by commit
361b79119a4b ("gpio: Add Aspeed driver")
--
Cheers,
Stephen Rothwell
Re: linux-next: build warning after merge of the gpio tree
On Thu, Jun 16, 2016 at 6:32 AM, Stephen Rothwell wrote:
> After merging the gpio tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> In file included from drivers/gpio/gpiolib.c:25:0:
> drivers/gpio/gpiolib.c: In function 'lineevent_irq_thread':
> include/linux/kfifo.h:403:39: warning: 'ge.id' may be used uninitialized in
> this function [-Wmaybe-uninitialized]
> )[__kfifo->in & __tmp->kfifo.mask] = \
>^
> drivers/gpio/gpiolib.c:657:24: note: 'ge.id' was declared here
> struct gpioevent_data ge;
> ^
>
> Introduced by commit
>
> 61f922db7221 ("gpio: userspace ABI for reading GPIO line events")
>
> This is in the kfifo_put() call.
Thanks Stephen, Arnd has already helpfully made a patch to fix it :)
Yours,
Linus Walleij
linux-next: build warning after merge of the gpio tree
Hi Linus,
After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
In file included from drivers/gpio/gpiolib.c:25:0:
drivers/gpio/gpiolib.c: In function 'lineevent_irq_thread':
include/linux/kfifo.h:403:39: warning: 'ge.id' may be used uninitialized in
this function [-Wmaybe-uninitialized]
)[__kfifo->in & __tmp->kfifo.mask] = \
^
drivers/gpio/gpiolib.c:657:24: note: 'ge.id' was declared here
struct gpioevent_data ge;
^
Introduced by commit
61f922db7221 ("gpio: userspace ABI for reading GPIO line events")
This is in the kfifo_put() call.
--
Cheers,
Stephen Rothwell
Re: linux-next: build warning after merge of the gpio tree
On Fri, Mar 7, 2014 at 11:59 AM, Stephen Rothwell wrote:
> Hi Linus,
>
> After merging the gpio tree, today's (and yesterday's) linux-next build
> (x86_64 allmodconfig among others) produced this warning:
>
> kernel/irq/Kconfig:41:error: recursive dependency detected!
> kernel/irq/Kconfig:41: symbol GENERIC_IRQ_CHIP is selected by GPIO_DWAPB
> drivers/gpio/Kconfig:131: symbol GPIO_DWAPB depends on IRQ_DOMAIN
> kernel/irq/Kconfig:46: symbol IRQ_DOMAIN is selected by GENERIC_IRQ_CHIP
>
> Caused by commit 7779b3455697 ("gpio: add a driver for the Synopsys
> DesignWare APB GPIO block").
Thanks Stephen, I merged a patch from Alan Tull earlier today fixing this
problem.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
linux-next: build warning after merge of the gpio tree
Hi Linus,
After merging the gpio tree, today's (and yesterday's) linux-next build
(x86_64 allmodconfig among others) produced this warning:
kernel/irq/Kconfig:41:error: recursive dependency detected!
kernel/irq/Kconfig:41: symbol GENERIC_IRQ_CHIP is selected by GPIO_DWAPB
drivers/gpio/Kconfig:131: symbol GPIO_DWAPB depends on IRQ_DOMAIN
kernel/irq/Kconfig:46: symbol IRQ_DOMAIN is selected by GENERIC_IRQ_CHIP
Caused by commit 7779b3455697 ("gpio: add a driver for the Synopsys
DesignWare APB GPIO block").
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgp1buHswUsd9.pgp
Description: PGP signature
