linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (htmldocs)
produced this warning:

net/tipc/bearer.c:248: warning: Function parameter or member 'extack' not 
described in 'tipc_enable_bearer'

Introduced by commit

  b83e214b2e04 ("tipc: add extack messages for bearer/media failure")

-- 
Cheers,
Stephen Rothwell


pgpvL7jutqP0L.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

On Thu, 25 Mar 2021 17:23:50 +1100 Stephen Rothwell  
wrote:
>
> After merging the net-next tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Sphinx parallel build error:
> docutils.utils.SystemMessage: 
> /home/sfr/next/next/Documentation/networking/nf_flowtable.rst:176: (SEVERE/4) 
> Unexpected section title.
> 
> }
> ...
> 
> Introduced by commit
> 
>   143490cde566 ("docs: nf_flowtable: update documentation with enhancements")

This is actually a build error and fails the htmldocs build - well,
actually causes it to hang.

-- 
Cheers,
Stephen Rothwell


pgptFAoPiakXH.pgp
Description: OpenPGP digital signature

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (htmldocs)
produced this warning:

Sphinx parallel build error:
docutils.utils.SystemMessage: 
/home/sfr/next/next/Documentation/networking/nf_flowtable.rst:176: (SEVERE/4) 
Unexpected section title.

}
...

Introduced by commit

  143490cde566 ("docs: nf_flowtable: update documentation with enhancements")

-- 
Cheers,
Stephen Rothwell


pgpX14519hqBb.pgp
Description: OpenPGP digital signature

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (htmldocs)
produced this warning:

include/linux/netdevice.h:2191: warning: Function parameter or member 
'dev_refcnt' not described in 'net_device'

Introduced by commit

  919067cc845f ("net: add CONFIG_PCPU_DEV_REFCNT")

-- 
Cheers,
Stephen Rothwell


pgpM6J3hmGKoq.pgp
Description: OpenPGP digital signature

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (htmldocs)
produced this warning:

net/tipc/subscr.h:73: warning: Function parameter or member 's' not described 
in 'tipc_subscription'

Introduced by commit

  429189acac53 ("tipc: add host-endian copy of user subscription to struct 
tipc_subscription")

-- 
Cheers,
Stephen Rothwell


pgpfAwnqtfk1n.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the net-next tree

[Chen Yu]

Hi Stephen,
On Wed, Mar 17, 2021 at 06:56:05PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the net-next tree, today's linux-next build (sparc64
> defconfig) produced this warning:
> 
> drivers/net/ethernet/intel/e1000e/netdev.c:6926:12: warning: 
> 'e1000e_pm_prepare' defined but not used [-Wunused-function]
>  static int e1000e_pm_prepare(struct device *dev)
> ^
> 
> Introduced by commit
> 
>   ccf8b940e5fd ("e1000e: Leverage direct_complete to speed up s2ram")
> 
> CONFIG_PM_SLEEP is not set for this build.
>
Thanks for reporting. I think we need to add the '__maybe_unused' attribute as 
in case
CONFIG_PM_SLEEP is not set. Tony, it seems that the original v1 patch should 
eliminate
this warning, could you please help double check and apply that version?

thanks,
Chenyu
 
> -- 
> Cheers,
> Stephen Rothwell

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (sparc64
defconfig) produced this warning:

drivers/net/ethernet/intel/e1000e/netdev.c:6926:12: warning: 
'e1000e_pm_prepare' defined but not used [-Wunused-function]
 static int e1000e_pm_prepare(struct device *dev)
^

Introduced by commit

  ccf8b940e5fd ("e1000e: Leverage direct_complete to speed up s2ram")

CONFIG_PM_SLEEP is not set for this build.

-- 
Cheers,
Stephen Rothwell


pgpR3ppN3HjaS.pgp
Description: OpenPGP digital signature

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/networking/dsa/dsa.rst:468: WARNING: Unexpected indentation.
Documentation/networking/dsa/dsa.rst:477: WARNING: Block quote ends without a 
blank line; unexpected unindent.

Introduced by commit

  8411abbcad8e ("Documentation: networking: dsa: mention integration with 
devlink")

-- 
Cheers,
Stephen Rothwell


pgpRdNujH52qA.pgp
Description: OpenPGP digital signature

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/networking/switchdev.rst:482: WARNING: Unexpected indentation.

Introduced by commit

  0f22ad45f47c ("Documentation: networking: switchdev: clarify device driver 
behavior")

-- 
Cheers,
Stephen Rothwell


pgpgaMwhLMvsv.pgp
Description: OpenPGP digital signature

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/networking/device_drivers/ethernet/mellanox/mlx5.rst:16: WARNING: 
Unknown target name: "mlx5 port function".

Introduced by commit

  142d93d12dc1 ("net/mlx5: Add devlink subfunction port documentation")

-- 
Cheers,
Stephen Rothwell


pgpzLMlQ3f_wA.pgp
Description: OpenPGP digital signature

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, yesterday's linux-next build (htmldocs)
produced this warning:

Documentation/networking/filter.rst:1053: WARNING: Inline emphasis start-string 
without end-string.
Documentation/networking/filter.rst:1053: WARNING: Inline emphasis start-string 
without end-string.
Documentation/networking/filter.rst:1053: WARNING: Inline emphasis start-string 
without end-string.
Documentation/networking/filter.rst:1053: WARNING: Inline emphasis start-string 
without end-string.

Introduced by commit

  91c960b00566 ("bpf: Rename BPF_XADD and prepare to encode other atomics in 
.imm")

-- 
Cheers,
Stephen Rothwell


pgpQL_JSVrfWs.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the net-next tree

[Ioana Ciornei]

On Tue, Dec 15, 2020 at 07:01:25AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> On Thu, 26 Nov 2020 17:40:57 +1100 Stephen Rothwell  
> wrote:
> >
> > After merging the net-next tree, today's linux-next build (htmldocs)
> > produced this warning:
> > 
> > include/linux/phy.h:869: warning: Function parameter or member 
> > 'config_intr' not described in 'phy_driver'
> > 
> > Introduced by commit
> > 
> >   6527b938426f ("net: phy: remove the .did_interrupt() and .ack_interrupt() 
> > callback")
> 
> I am still getting this warning.

Hi,

Sorry for not responding in time, I know I verified this the first time
but somehow did not answer the email.

The .config_intr() is documented but it seems that it's not parsed
properly since the comment starts on the same line as the /**. A diff
like below seems to do the trick. I will send it out.

--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -743,7 +743,8 @@ struct phy_driver {
/** @read_status: Determines the negotiated speed and duplex */
int (*read_status)(struct phy_device *phydev);
 
-   /** @config_intr: Enables or disables interrupts.
+   /**
+* @config_intr: Enables or disables interrupts.
 * It should also clear any pending interrupts prior to enabling the
 * IRQs and after disabling them.
 */

Ioana

Re: linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

On Thu, 26 Nov 2020 17:40:57 +1100 Stephen Rothwell  
wrote:
>
> After merging the net-next tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> include/linux/phy.h:869: warning: Function parameter or member 'config_intr' 
> not described in 'phy_driver'
> 
> Introduced by commit
> 
>   6527b938426f ("net: phy: remove the .did_interrupt() and .ack_interrupt() 
> callback")

I am still getting this warning.
-- 
Cheers,
Stephen Rothwell


pgpnkkBl6MFPU.pgp
Description: OpenPGP digital signature

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (htmldocs)
produced this warning:

include/linux/phy.h:869: warning: Function parameter or member 'config_intr' 
not described in 'phy_driver'

Introduced by commit

  6527b938426f ("net: phy: remove the .did_interrupt() and .ack_interrupt() 
callback")

-- 
Cheers,
Stephen Rothwell


pgp8LOgSXUpS9.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the net-next tree

[Xie He]

On Tue, Nov 17, 2020 at 9:20 PM Stephen Rothwell  wrote:
>
> After merging the net-next tree, today's linux-next build (htmldocs)
> produced this warning:
>
> Documentation/networking/index.rst:6: WARNING: toctree contains reference to 
> nonexisting document 'networking/framerelay'
>
> Introduced by commit
>
>   f73659192b0b ("net: wan: Delete the DLCI / SDLA drivers")

Thanks for reporting! I submitted another patch to remove the
reference to the deleted document. Thanks!

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/networking/index.rst:6: WARNING: toctree contains reference to 
nonexisting document 'networking/framerelay'

Introduced by commit

  f73659192b0b ("net: wan: Delete the DLCI / SDLA drivers")

-- 
Cheers,
Stephen Rothwell


pgpQ2i4yAL7Qa.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the net-next tree

[Jakub Kicinski]

On Tue, 8 Sep 2020 13:00:00 +1000 Stephen Rothwell wrote:
> Hi all,
> 
> After merging the net-next tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> net/bridge/br_multicast.c: In function 'br_multicast_find_port':
> net/bridge/br_multicast.c:1818:21: warning: unused variable 'br' 
> [-Wunused-variable]
>  1818 |  struct net_bridge *br = mp->br;
>   | ^~
> 
> Introduced by commit
> 
>   0436862e417e ("net: bridge: mcast: support for IGMPv3/MLDv2 
> ALLOW_NEW_SOURCES report")
> 
> Maybe turning mlock_dereference into a static inline function would help.

Or perhaps provide a better definition of whatever is making the
reference disappear? RCU_LOCKDEP_WARN()?

Thanks for the report!

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

net/bridge/br_multicast.c: In function 'br_multicast_find_port':
net/bridge/br_multicast.c:1818:21: warning: unused variable 'br' 
[-Wunused-variable]
 1818 |  struct net_bridge *br = mp->br;
  | ^~

Introduced by commit

  0436862e417e ("net: bridge: mcast: support for IGMPv3/MLDv2 ALLOW_NEW_SOURCES 
report")

Maybe turning mlock_dereference into a static inline function would help.

-- 
Cheers,
Stephen Rothwell


pgpzzgVqLf76v.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the net-next tree

[Vaibhav Gupta]

On Tue, Jul 7, 2020 at 12:36 PM Stephen Rothwell  wrote:
>
> Hi all,
>
> After merging the net-next tree, today's linux-next build (sparc64
> defconfig) produced this warning:
>
> drivers/net/ethernet/sun/niu.c:9903:12: warning: 'niu_resume' defined but not 
> used [-Wunused-function]
>  static int niu_resume(struct device *dev_d)
> ^~
> drivers/net/ethernet/sun/niu.c:9876:12: warning: 'niu_suspend' defined but 
> not used [-Wunused-function]
>  static int niu_suspend(struct device *dev_d)
> ^~~
>
> Introduced by commit
>
>   b0db0cc2f695 ("sun/niu: use generic power management")
This warning should not have come as the earlier definition of.suspend() and
.resume(), they were not inside "#ifdef CONFIG_PM" container. Or any other
container. Hence I thought adding the "__maybe_unused" attribute to them
would be unnecessary.

I am sending a patch to do the same.

-- Vaibhav Gupta
>
> --
> Cheers,
> Stephen Rothwell

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (sparc64
defconfig) produced this warning:

drivers/net/ethernet/sun/niu.c:9903:12: warning: 'niu_resume' defined but not 
used [-Wunused-function]
 static int niu_resume(struct device *dev_d)
^~
drivers/net/ethernet/sun/niu.c:9876:12: warning: 'niu_suspend' defined but not 
used [-Wunused-function]
 static int niu_suspend(struct device *dev_d)
^~~

Introduced by commit

  b0db0cc2f695 ("sun/niu: use generic power management")

-- 
Cheers,
Stephen Rothwell


pgpyYYkzeiQXt.pgp
Description: OpenPGP digital signature

RE: linux-next: build warning after merge of the net-next tree

[Kirsher, Jeffrey T]

> -Original Message-
> From: Stephen Rothwell 
> Sent: Friday, June 12, 2020 18:16
> To: Kirsher, Jeffrey T 
> Cc: David Miller ; Networking
> ; Linux Next Mailing List  n...@vger.kernel.org>; Linux Kernel Mailing List  ker...@vger.kernel.org>; Lifshits, Vitaly 
> Subject: Re: linux-next: build warning after merge of the net-next tree
> 
> Hi all,
> 
> On Wed, 27 May 2020 01:15:09 + "Kirsher, Jeffrey T"
>  wrote:
> >
> > > -Original Message-
> > > From: Stephen Rothwell 
> > > Sent: Monday, May 25, 2020 05:40
> > > To: David Miller ; Networking
> > > 
> > > Cc: Linux Next Mailing List ; Linux
> > > Kernel Mailing List ; Lifshits, Vitaly
> > > ; Kirsher, Jeffrey T
> > > 
> > > Subject: linux-next: build warning after merge of the net-next tree
> > >
> > > Hi all,
> > >
> > > After merging the net-next tree, today's linux-next build (sparc64
> > > defconfig) produced this warning:
> > >
> > > drivers/net/ethernet/intel/e1000e/netdev.c:137:13: warning:
> 'e1000e_check_me'
> > > defined but not used [-Wunused-function]  static bool
> > > e1000e_check_me(u16
> > > device_id)
> > >  ^~~
> > >
> > > Introduced by commit
> > >
> > >   e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME
> > > systems")
> > >
> > > CONFIG_PM_SLEEP is not set for this build.
> > >
> > [Kirsher, Jeffrey T]
> >
> > Vitaly informed me that he has a fix that he will be sending me, I will make
> sure to expedite it.
> 
> I am still getting this warning.

I apologize, I have not seen a fix from Vitaly, that I am aware of.  I will 
make sure you have a patch before Monday.

Re: linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

On Wed, 27 May 2020 01:15:09 + "Kirsher, Jeffrey T" 
 wrote:
>
> > -Original Message-
> > From: Stephen Rothwell 
> > Sent: Monday, May 25, 2020 05:40
> > To: David Miller ; Networking
> > 
> > Cc: Linux Next Mailing List ; Linux Kernel 
> > Mailing
> > List ; Lifshits, Vitaly 
> > ;
> > Kirsher, Jeffrey T 
> > Subject: linux-next: build warning after merge of the net-next tree
> > 
> > Hi all,
> > 
> > After merging the net-next tree, today's linux-next build (sparc64
> > defconfig) produced this warning:
> > 
> > drivers/net/ethernet/intel/e1000e/netdev.c:137:13: warning: 
> > 'e1000e_check_me'
> > defined but not used [-Wunused-function]  static bool e1000e_check_me(u16
> > device_id)
> >  ^~~
> > 
> > Introduced by commit
> > 
> >   e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME systems")
> > 
> > CONFIG_PM_SLEEP is not set for this build.
> >   
> [Kirsher, Jeffrey T] 
> 
> Vitaly informed me that he has a fix that he will be sending me, I will make 
> sure to expedite it.

I am still getting this warning.

-- 
Cheers,
Stephen Rothwell


pgpso8fexP7Cs.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

On Tue, 2 Jun 2020 12:17:35 +1000 Stephen Rothwell  
wrote:
>
> Hi all,
> 
> After merging the net-next tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c:666:13: warning: 
> 'cxgb4_uld_in_use' defined but not used [-Wunused-function]
>   666 | static bool cxgb4_uld_in_use(struct adapter *adap)
>   | ^~~~
> 
> Introduced by commit
> 
>   a3ac249a1ab5 ("cxgb4/chcr: Enable ktls settings at run time")
> 
> CONFIG_CHELSIO_TLS_DEVICE is not set for this build.

I am still getting this warning.
-- 
Cheers,
Stephen Rothwell


pgpJoUd_SAu9d.pgp
Description: OpenPGP digital signature

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c:666:13: warning: 
'cxgb4_uld_in_use' defined but not used [-Wunused-function]
  666 | static bool cxgb4_uld_in_use(struct adapter *adap)
  | ^~~~

Introduced by commit

  a3ac249a1ab5 ("cxgb4/chcr: Enable ktls settings at run time")

CONFIG_CHELSIO_TLS_DEVICE is not set for this build.

-- 
Cheers,
Stephen Rothwell


pgpsV_StiMyp8.pgp
Description: OpenPGP digital signature

RE: linux-next: build warning after merge of the net-next tree

[Kirsher, Jeffrey T]

> -Original Message-
> From: Stephen Rothwell 
> Sent: Monday, May 25, 2020 05:40
> To: David Miller ; Networking
> 
> Cc: Linux Next Mailing List ; Linux Kernel Mailing
> List ; Lifshits, Vitaly 
> ;
> Kirsher, Jeffrey T 
> Subject: linux-next: build warning after merge of the net-next tree
> 
> Hi all,
> 
> After merging the net-next tree, today's linux-next build (sparc64
> defconfig) produced this warning:
> 
> drivers/net/ethernet/intel/e1000e/netdev.c:137:13: warning: 'e1000e_check_me'
> defined but not used [-Wunused-function]  static bool e1000e_check_me(u16
> device_id)
>  ^~~
> 
> Introduced by commit
> 
>   e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME systems")
> 
> CONFIG_PM_SLEEP is not set for this build.
> 
[Kirsher, Jeffrey T] 

Vitaly informed me that he has a fix that he will be sending me, I will make 
sure to expedite it.

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (sparc64
defconfig) produced this warning:

drivers/net/ethernet/intel/e1000e/netdev.c:137:13: warning: 'e1000e_check_me' 
defined but not used [-Wunused-function]
 static bool e1000e_check_me(u16 device_id)
 ^~~

Introduced by commit

  e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME systems")

CONFIG_PM_SLEEP is not set for this build.

-- 
Cheers,
Stephen Rothwell


pgpelGr_k_XkL.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the net-next tree

[David Howells]

Stephen Rothwell  wrote:

> diff --git a/net/rxrpc/peer_object.c b/net/rxrpc/peer_object.c
> index a7f1a2cdd198..452163eadb98 100644
> --- a/net/rxrpc/peer_object.c
> +++ b/net/rxrpc/peer_object.c
> @@ -231,7 +231,7 @@ struct rxrpc_peer *rxrpc_alloc_peer(struct rxrpc_local 
> *local, gfp_t gfp)
>   peer->cong_cwnd = 3;
>   else
>   peer->cong_cwnd = 4;
> - trace_rxrpc_peer(peer, rxrpc_peer_new, 1, here);
> + trace_rxrpc_peer(peer->debug_id, rxrpc_peer_new, 1, here);
>   }
>  
>   _leave(" = %p", peer);

Acked-by: David Howells 

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) produced this warning:


Introduced by commit

  033b2c7f0f26 ("rxrpc: Add missing "new peer" trace")

interacting with commit

  55f6c98e3674 ("rxrpc: Fix trace-after-put looking at the put peer record")

from the net tree.

I have applied the following merge fix patch.

From: Stephen Rothwell 
Date: Tue, 8 Oct 2019 09:37:50 +1100
Subject: [PATCH] rxrpc: fix up for "rxrpc: Fix trace-after-put looking at the
 put peer record"

interacting with commit

  033b2c7f0f26 ("rxrpc: Add missing "new peer" trace")

Signed-off-by: Stephen Rothwell 
---
 net/rxrpc/peer_object.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/rxrpc/peer_object.c b/net/rxrpc/peer_object.c
index a7f1a2cdd198..452163eadb98 100644
--- a/net/rxrpc/peer_object.c
+++ b/net/rxrpc/peer_object.c
@@ -231,7 +231,7 @@ struct rxrpc_peer *rxrpc_alloc_peer(struct rxrpc_local 
*local, gfp_t gfp)
peer->cong_cwnd = 3;
else
peer->cong_cwnd = 4;
-   trace_rxrpc_peer(peer, rxrpc_peer_new, 1, here);
+   trace_rxrpc_peer(peer->debug_id, rxrpc_peer_new, 1, here);
}
 
_leave(" = %p", peer);
-- 
2.23.0.rc1

-- 
Cheers,
Stephen Rothwell


pgp1zAXZdudHy.pgp
Description: OpenPGP digital signature

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from include/linux/bitmap.h:9,
 from include/linux/cpumask.h:12,
 from arch/x86/include/asm/cpumask.h:5,
 from arch/x86/include/asm/msr.h:11,
 from arch/x86/include/asm/processor.h:21,
 from arch/x86/include/asm/cpufeature.h:5,
 from arch/x86/include/asm/thread_info.h:53,
 from include/linux/thread_info.h:38,
 from arch/x86/include/asm/preempt.h:7,
 from include/linux/preempt.h:78,
 from include/linux/spinlock.h:51,
 from include/linux/seqlock.h:36,
 from include/linux/time.h:6,
 from include/linux/ktime.h:24,
 from include/linux/timer.h:6,
 from include/linux/netdevice.h:24,
 from include/linux/if_vlan.h:10,
 from drivers/net/ethernet/mellanox/mlx5/core/en.h:35,
 from 
drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c:5:
drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c: In function 
'mlx5e_ktls_tx_handle_ooo':
include/linux/string.h:400:9: warning: 'rec_seq' may be used uninitialized in 
this function [-Wmaybe-uninitialized]
  return __builtin_memcmp(p, q, size);
 ^~~~
drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c:240:8: note: 
'rec_seq' was declared here
  char *rec_seq;
^~~

Introduced by commit

  d2ead1f360e8 ("net/mlx5e: Add kTLS TX HW offload support")

-- 
Cheers,
Stephen Rothwell


pgpqJP7jQsjzq.pgp
Description: OpenPGP digital signature

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/net/ethernet/xilinx/ll_temac_main.c: In function 
'temac_set_multicast_list':
drivers/net/ethernet/xilinx/ll_temac_main.c:490:8: warning: 'i' may be used 
uninitialized in this function [-Wmaybe-uninitialized]
  while (i < MULTICAST_CAM_TABLE_NUM) {
^

Introduced by commit

  1b3fa5cf859b ("net: ll_temac: Cleanup multicast filter on change")

-- 
Cheers,
Stephen Rothwell


pgpNLWfeC5Aih.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the net-next tree

[Florian Fainelli]

On 2/21/19 5:06 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the net-next tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/net/ethernet/rocker/rocker_main.c: In function 'rocker_port_attr_set':
> drivers/net/ethernet/rocker/rocker_main.c:2083:9: warning: this statement may 
> fall through [-Wimplicit-fallthrough=]
>err = rocker_world_port_attr_pre_bridge_flags_set(rocker_port,
>  ^~~~
>   attr->u.brport_flags,
>   ~
>   trans);
>   ~~
> drivers/net/ethernet/rocker/rocker_main.c:2086:2: note: here
>   case SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS:
>   ^~~~
> 
> Introduced by commit
> 
>   93700458ff63 ("rocker: Check Handle PORT_PRE_BRIDGE_FLAGS")
> 
> I get this warning because I am building with -Wimplicit-fallthrough
> in attempt to catch new additions early.  The gcc warning can be turned
> off by adding a /* fall through */ comment at the point the fall through
> happens (assuming that the fall through is intentional).

There is a missing break, my rebase went wrong with that, I will send a
fix shortly for that.
-- 
Florian

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/net/ethernet/rocker/rocker_main.c: In function 'rocker_port_attr_set':
drivers/net/ethernet/rocker/rocker_main.c:2083:9: warning: this statement may 
fall through [-Wimplicit-fallthrough=]
   err = rocker_world_port_attr_pre_bridge_flags_set(rocker_port,
 ^~~~
  attr->u.brport_flags,
  ~
  trans);
  ~~
drivers/net/ethernet/rocker/rocker_main.c:2086:2: note: here
  case SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS:
  ^~~~

Introduced by commit

  93700458ff63 ("rocker: Check Handle PORT_PRE_BRIDGE_FLAGS")

I get this warning because I am building with -Wimplicit-fallthrough
in attempt to catch new additions early.  The gcc warning can be turned
off by adding a /* fall through */ comment at the point the fall through
happens (assuming that the fall through is intentional).

-- 
Cheers,
Stephen Rothwell


pgpfdM_78amdB.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the net-next tree

[Florian Fainelli]

Le 2/12/19 à 4:51 PM, Stephen Rothwell a écrit :
> Hi all,
> 
> After merging the net-next tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/staging/fsl-dpaa2/ethsw/ethsw.c: In function 'swdev_port_attr_get':
> drivers/staging/fsl-dpaa2/ethsw/ethsw.c:646:26: warning: unused variable 
> 'port_priv' [-Wunused-variable]
>   struct ethsw_port_priv *port_priv = netdev_priv(netdev);
>   ^
> 
> Introduced by commit
> 
>   1b8b589d9103 ("staging: fsl-dpaa2: ethsw: Remove getting PORT_BRIDGE_FLAGS")
> 

Also fixed with:

http://patchwork.ozlabs.org/project/netdev/list/?series=91603
-- 
Florian

Re: linux-next: build warning after merge of the net-next tree

[Florian Fainelli]

Le 2/12/19 à 4:49 PM, Stephen Rothwell a écrit :
> Hi all,
> 
> After merging the net-next tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c: In function 
> 'mlxsw_sp_port_attr_get':
> drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:438:19: warning: 
> unused variable 'mlxsw_sp' [-Wunused-variable]
>   struct mlxsw_sp *mlxsw_sp = mlxsw_sp_port->mlxsw_sp;
>^~~~
> 
> Introduced by commit
> 
>   1ecb195753a1 ("mlxsw: spectrum_switchdev: Remove getting PORT_BRIDGE_FLAGS")

Fixed with:

http://patchwork.ozlabs.org/project/netdev/list/?series=91603
-- 
Florian

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/staging/fsl-dpaa2/ethsw/ethsw.c: In function 'swdev_port_attr_get':
drivers/staging/fsl-dpaa2/ethsw/ethsw.c:646:26: warning: unused variable 
'port_priv' [-Wunused-variable]
  struct ethsw_port_priv *port_priv = netdev_priv(netdev);
  ^

Introduced by commit

  1b8b589d9103 ("staging: fsl-dpaa2: ethsw: Remove getting PORT_BRIDGE_FLAGS")

-- 
Cheers,
Stephen Rothwell


pgpScU63brjKB.pgp
Description: OpenPGP digital signature

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c: In function 
'mlxsw_sp_port_attr_get':
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:438:19: warning: 
unused variable 'mlxsw_sp' [-Wunused-variable]
  struct mlxsw_sp *mlxsw_sp = mlxsw_sp_port->mlxsw_sp;
   ^~~~

Introduced by commit

  1ecb195753a1 ("mlxsw: spectrum_switchdev: Remove getting PORT_BRIDGE_FLAGS")

-- 
Cheers,
Stephen Rothwell


pgptbhHRrI2C4.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi Dave,

On Sun, 03 Feb 2019 20:26:06 -0800 (PST) David Miller  
wrote:
>
> Thanks, I just pushed the following:
> 
> 
> [PATCH] net: Fix fall through warning in y2038 tstamp changes.
> 
> net/core/sock.c: In function 'sock_setsockopt':
> net/core/sock.c:914:3: warning: this statement may fall through 
> [-Wimplicit-fallthrough=]
>sock_set_flag(sk, SOCK_TSTAMP_NEW);
>^~
> net/core/sock.c:915:2: note: here
>   case SO_TIMESTAMPING_OLD:
>   ^~~~
> 
> Fixes: 9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW")
> Reported-by: Stephen Rothwell 
> Signed-off-by: David S. Miller 
> ---
>  net/core/sock.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/core/sock.c b/net/core/sock.c
> index a8904ae40713..71ded4d8025c 100644
> --- a/net/core/sock.c
> +++ b/net/core/sock.c
> @@ -912,6 +912,7 @@ int sock_setsockopt(struct socket *sock, int level, int 
> optname,
>  
>   case SO_TIMESTAMPING_NEW:
>   sock_set_flag(sk, SOCK_TSTAMP_NEW);
> + /* fall through */
>   case SO_TIMESTAMPING_OLD:
>   if (val & ~SOF_TIMESTAMPING_MASK) {
>   ret = -EINVAL;

Looks good, thanks.

-- 
Cheers,
Stephen Rothwell


pgp_naabTlZDH.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the net-next tree

[David Miller]

From: Stephen Rothwell 
Date: Mon, 4 Feb 2019 10:44:27 +1100

> After merging the net-next tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> net/core/sock.c: In function 'sock_setsockopt':
> net/core/sock.c:914:3: warning: this statement may fall through 
> [-Wimplicit-fallthrough=]
>sock_set_flag(sk, SOCK_TSTAMP_NEW);
>^~
> net/core/sock.c:915:2: note: here
>   case SO_TIMESTAMPING_OLD:
>   ^~~~
> 
> Introduced by commit
> 
>   9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW")

Thanks, I just pushed the following:


[PATCH] net: Fix fall through warning in y2038 tstamp changes.

net/core/sock.c: In function 'sock_setsockopt':
net/core/sock.c:914:3: warning: this statement may fall through 
[-Wimplicit-fallthrough=]
   sock_set_flag(sk, SOCK_TSTAMP_NEW);
   ^~
net/core/sock.c:915:2: note: here
  case SO_TIMESTAMPING_OLD:
  ^~~~

Fixes: 9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW")
Reported-by: Stephen Rothwell 
Signed-off-by: David S. Miller 
---
 net/core/sock.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/core/sock.c b/net/core/sock.c
index a8904ae40713..71ded4d8025c 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -912,6 +912,7 @@ int sock_setsockopt(struct socket *sock, int level, int 
optname,
 
case SO_TIMESTAMPING_NEW:
sock_set_flag(sk, SOCK_TSTAMP_NEW);
+   /* fall through */
case SO_TIMESTAMPING_OLD:
if (val & ~SOF_TIMESTAMPING_MASK) {
ret = -EINVAL;
-- 
2.20.1

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

net/core/sock.c: In function 'sock_setsockopt':
net/core/sock.c:914:3: warning: this statement may fall through 
[-Wimplicit-fallthrough=]
   sock_set_flag(sk, SOCK_TSTAMP_NEW);
   ^~
net/core/sock.c:915:2: note: here
  case SO_TIMESTAMPING_OLD:
  ^~~~

Introduced by commit

  9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW")

I get this warning because I am building with -Wimplicit-fallthrough
in attempt to catch new additions early.  The gcc warning can be turned
off by adding a /* fall through */ comment at the point the fall through
happens (assuming that the fall through is intentional).

-- 
Cheers,
Stephen Rothwell


pgpJETXRNn1Gx.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi Gustavo,

On Tue, 18 Dec 2018 21:07:06 -0600 "Gustavo A. R. Silva" 
 wrote:
>
> On 12/18/18 8:42 PM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > On Thu, 29 Nov 2018 11:24:28 +1100 Stephen Rothwell  
> > wrote:  
> >>
> >> After merging the net-next tree, today's linux-next build
> >> (x86_64_allmodconfig) produced this warning:
> >>
> >> drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c: In function 'run_xdp':
> >> drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:324:3: warning: this 
> >> statement may fall through [-Wimplicit-fallthrough=]
> >> bpf_warn_invalid_xdp_action(xdp_act);
> >> ^~~~
> >> drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:325:2: note: here
> >>case XDP_ABORTED:
> >>^~~~
> >> drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:326:3: warning: this 
> >> statement may fall through [-Wimplicit-fallthrough=]
> >> trace_xdp_exception(priv->net_dev, xdp_prog, xdp_act);
> >> ^
> >> drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:327:2: note: here
> >>case XDP_DROP:
> >>^~~~
> >>
> >> Introduced by commit
> >>
> >>7e273a8ebdd3 ("dpaa2-eth: Add basic XDP support")
> >>
> >> This due to my use of -Wimplicit-fallthrough.  This is new code.  The
> >> warning can be suppressed by adding a comment like /* fall through */
> >> at the appropriate places to indicate that the fallthrough is intended.  
> > 
> > I am still seeing these warnings.
> >   
> 
> That's weird. I don't see them anymore in next-20181218.
> 
> They were fixed by this commit: c1cb11bcbd09f5f027cbc7fadddab169714948df

My mistake (patter mismatch :-)), there are very similar warnings in
drivers/net/veth.c which are older.  Someone could fix those if they
wanted to :-)

drivers/net/veth.c: In function 'veth_xdp_rcv_one':
drivers/net/veth.c:542:4: warning: this statement may fall through 
[-Wimplicit-fallthrough=]
bpf_warn_invalid_xdp_action(act);
^~~~
drivers/net/veth.c:543:3: note: here
   case XDP_ABORTED:
   ^~~~
drivers/net/veth.c: In function 'veth_xdp_rcv_skb':
drivers/net/veth.c:663:3: warning: this statement may fall through 
[-Wimplicit-fallthrough=]
   bpf_warn_invalid_xdp_action(act);
   ^~~~
drivers/net/veth.c:664:2: note: here
  case XDP_ABORTED:
  ^~~~

-- 
Cheers,
Stephen Rothwell


pgpJJCOcNdCuM.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the net-next tree

[Gustavo A. R. Silva]

Hi Stephen,

On 12/18/18 8:42 PM, Stephen Rothwell wrote:

Hi all,

On Thu, 29 Nov 2018 11:24:28 +1100 Stephen Rothwell  
wrote:


After merging the net-next tree, today's linux-next build
(x86_64_allmodconfig) produced this warning:

drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c: In function 'run_xdp':
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:324:3: warning: this statement 
may fall through [-Wimplicit-fallthrough=]
bpf_warn_invalid_xdp_action(xdp_act);
^~~~
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:325:2: note: here
   case XDP_ABORTED:
   ^~~~
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:326:3: warning: this statement 
may fall through [-Wimplicit-fallthrough=]
trace_xdp_exception(priv->net_dev, xdp_prog, xdp_act);
^
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:327:2: note: here
   case XDP_DROP:
   ^~~~

Introduced by commit

   7e273a8ebdd3 ("dpaa2-eth: Add basic XDP support")

This due to my use of -Wimplicit-fallthrough.  This is new code.  The
warning can be suppressed by adding a comment like /* fall through */
at the appropriate places to indicate that the fallthrough is intended.


I am still seeing these warnings.



That's weird. I don't see them anymore in next-20181218.

They were fixed by this commit: c1cb11bcbd09f5f027cbc7fadddab169714948df

Thanks
--
Gustavo

Re: linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

On Thu, 29 Nov 2018 11:24:28 +1100 Stephen Rothwell  
wrote:
>
> After merging the net-next tree, today's linux-next build
> (x86_64_allmodconfig) produced this warning:
> 
> drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c: In function 'run_xdp':
> drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:324:3: warning: this 
> statement may fall through [-Wimplicit-fallthrough=]
>bpf_warn_invalid_xdp_action(xdp_act);
>^~~~
> drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:325:2: note: here
>   case XDP_ABORTED:
>   ^~~~
> drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:326:3: warning: this 
> statement may fall through [-Wimplicit-fallthrough=]
>trace_xdp_exception(priv->net_dev, xdp_prog, xdp_act);
>^
> drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:327:2: note: here
>   case XDP_DROP:
>   ^~~~
> 
> Introduced by commit
> 
>   7e273a8ebdd3 ("dpaa2-eth: Add basic XDP support")
> 
> This due to my use of -Wimplicit-fallthrough.  This is new code.  The
> warning can be suppressed by adding a comment like /* fall through */
> at the appropriate places to indicate that the fallthrough is intended.

I am still seeing these warnings.

-- 
Cheers,
Stephen Rothwell


pgpfLBKncmXD9.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the net-next tree

[Guenter Roeck]

On Fri, Jul 20, 2018 at 08:19:34AM +0900, Masahiro Yamada wrote:
> 2018-07-20 7:35 GMT+09:00 Guenter Roeck :
> > On Fri, Jul 20, 2018 at 08:09:06AM +1000, Stephen Rothwell wrote:
> >> Hi Guenter,
> >>
> >> On Thu, 19 Jul 2018 06:49:01 -0700 Guenter Roeck  
> >> wrote:
> >> >
> >> > On 07/18/2018 10:29 PM, Stephen Rothwell wrote:
> >> > >
> >> > > On Wed, 18 Jul 2018 20:52:56 -0700 Guenter Roeck  
> >> > > wrote:
> >> > >>
> >> > >> On 07/18/2018 07:04 PM, Stephen Rothwell wrote:
> >> > >>>
> >> > >>> After merging the net-next tree, today's linux-next build (x86_64
> >> > >>> allmodconfig) produced this warning:
> >> > >>>
> >> > >>> *
> >> > >>> * Restart config...
> >> > >>> *
> >> > >>> 
> >> > >>>
> >> > >>> This is output by my "make allmodconfig" and only started after 
> >> > >>> merging
> >> > >>> the net-next tree today.  It has continued for further merges/builds.
> >> > >>>
> >> > >>> I suspect commit
> >> > >>>
> >> > >>> 1323061a018a ("net: phy: sfp: Add HWMON support for module 
> >> > >>> sensors")
> >> > >>>
> >> > >>> which added an "imply" clause.
> >> > >>>
> >> > >> I thought "imply" was better than "depends on HWMON || HWMON=n", but 
> >> > >> maybe
> >> > >> not. Is that a caveat when using "imply", and does it mean that 
> >> > >> "imply"
> >> > >> should better not be used ?
> >> > >
> >> > > I don't know, sorry.  It was just my best guess from what I could see
> >> > > had changed.
> >> > >
> >> > > I wonder if it makes a difference that I am doing my "make
> >> > > allmodconfig" on top of a previous "make allmodconfig" and some symbols
> >> > > are marked as "NEW" (though they are not symbols related to the changes
> >> > > that happened during the net-next tree merge)?
> >> > >
> >> >
> >> > I tried to reproduce the problem, but I don't see the message.
> >> >
> >> > What I do see, though, is that "make allmodconfig" on a clean tree,
> >> > followed by "make menuconfig", results in configuration changes.
> >> > Specifically,
> >> >
> >> >  > CONFIG_ARC_EMAC_CORE=m
> >> >  > CONFIG_ARC_EMAC=m
> >> >  > CONFIG_EMAC_ROCKCHIP=m
> >> >
> >> > is removed by menuconfig, and a large number of "# ... is not set"
> >> > configuration lines are added. Weird and bad, since several of the
> >> > disabled configurations _should_ be enabled by "make allmodconfig",
> >> > and a large number of hwmon drivers are affected. Bisect does point
> >> > to "net: phy: sfp: Add HWMON support for module sensors", meaning
> >> > "imply hwmon" does have severe side effects and can not be used.
> >> >
> >> > I'll try to find a fix.
> >>
> >> OK, my mistake, the "make allmodconfig" works, the following "make"
> >> causes the config restart.  (I am actually doing cross builds and using
> >> an external object directory, in case that matters.)
> >>
> >> I removed the "imply HWMON" line added by the above commit and the
> >> problem went away.  Also, using "depends on HWMON || HWMON=n" instead
> >> of the imply fixes it.
> >
> > Yes, replacing imply with the dependency is what I did in the fixup patch.
> > Sorry, I should have copied you: 
> > https://patchwork.kernel.org/patch/10534925/
> >
> > It is a bit different - imply was supposed to enforce HWMON={y,n} if SFP=y,
> > and the depends line enforces SFP={n,m} if HWMON=m. I have no idea why
> > imply doesn't work, but I think I'll stay away from it in the future.
> >
> > Guenter
> 
> 
> Hmm, this could be a Kconfig bug.
> 
> I will take a look.
> 
> 
> BTW,
> 'depends on HWMON || HWMON=n' is pointless
> because it is always true.
> 

I disagree. Its purpose is to enforce SFP=m if HWMON=m while still
permitting HWMON=n.

Guenter

Re: linux-next: build warning after merge of the net-next tree

[Guenter Roeck]

On Fri, Jul 20, 2018 at 08:19:34AM +0900, Masahiro Yamada wrote:
> 2018-07-20 7:35 GMT+09:00 Guenter Roeck :
> > On Fri, Jul 20, 2018 at 08:09:06AM +1000, Stephen Rothwell wrote:
> >> Hi Guenter,
> >>
> >> On Thu, 19 Jul 2018 06:49:01 -0700 Guenter Roeck  
> >> wrote:
> >> >
> >> > On 07/18/2018 10:29 PM, Stephen Rothwell wrote:
> >> > >
> >> > > On Wed, 18 Jul 2018 20:52:56 -0700 Guenter Roeck  
> >> > > wrote:
> >> > >>
> >> > >> On 07/18/2018 07:04 PM, Stephen Rothwell wrote:
> >> > >>>
> >> > >>> After merging the net-next tree, today's linux-next build (x86_64
> >> > >>> allmodconfig) produced this warning:
> >> > >>>
> >> > >>> *
> >> > >>> * Restart config...
> >> > >>> *
> >> > >>> 
> >> > >>>
> >> > >>> This is output by my "make allmodconfig" and only started after 
> >> > >>> merging
> >> > >>> the net-next tree today.  It has continued for further merges/builds.
> >> > >>>
> >> > >>> I suspect commit
> >> > >>>
> >> > >>> 1323061a018a ("net: phy: sfp: Add HWMON support for module 
> >> > >>> sensors")
> >> > >>>
> >> > >>> which added an "imply" clause.
> >> > >>>
> >> > >> I thought "imply" was better than "depends on HWMON || HWMON=n", but 
> >> > >> maybe
> >> > >> not. Is that a caveat when using "imply", and does it mean that 
> >> > >> "imply"
> >> > >> should better not be used ?
> >> > >
> >> > > I don't know, sorry.  It was just my best guess from what I could see
> >> > > had changed.
> >> > >
> >> > > I wonder if it makes a difference that I am doing my "make
> >> > > allmodconfig" on top of a previous "make allmodconfig" and some symbols
> >> > > are marked as "NEW" (though they are not symbols related to the changes
> >> > > that happened during the net-next tree merge)?
> >> > >
> >> >
> >> > I tried to reproduce the problem, but I don't see the message.
> >> >
> >> > What I do see, though, is that "make allmodconfig" on a clean tree,
> >> > followed by "make menuconfig", results in configuration changes.
> >> > Specifically,
> >> >
> >> >  > CONFIG_ARC_EMAC_CORE=m
> >> >  > CONFIG_ARC_EMAC=m
> >> >  > CONFIG_EMAC_ROCKCHIP=m
> >> >
> >> > is removed by menuconfig, and a large number of "# ... is not set"
> >> > configuration lines are added. Weird and bad, since several of the
> >> > disabled configurations _should_ be enabled by "make allmodconfig",
> >> > and a large number of hwmon drivers are affected. Bisect does point
> >> > to "net: phy: sfp: Add HWMON support for module sensors", meaning
> >> > "imply hwmon" does have severe side effects and can not be used.
> >> >
> >> > I'll try to find a fix.
> >>
> >> OK, my mistake, the "make allmodconfig" works, the following "make"
> >> causes the config restart.  (I am actually doing cross builds and using
> >> an external object directory, in case that matters.)
> >>
> >> I removed the "imply HWMON" line added by the above commit and the
> >> problem went away.  Also, using "depends on HWMON || HWMON=n" instead
> >> of the imply fixes it.
> >
> > Yes, replacing imply with the dependency is what I did in the fixup patch.
> > Sorry, I should have copied you: 
> > https://patchwork.kernel.org/patch/10534925/
> >
> > It is a bit different - imply was supposed to enforce HWMON={y,n} if SFP=y,
> > and the depends line enforces SFP={n,m} if HWMON=m. I have no idea why
> > imply doesn't work, but I think I'll stay away from it in the future.
> >
> > Guenter
> 
> 
> Hmm, this could be a Kconfig bug.
> 
> I will take a look.
> 
> 
> BTW,
> 'depends on HWMON || HWMON=n' is pointless
> because it is always true.
> 

I disagree. Its purpose is to enforce SFP=m if HWMON=m while still
permitting HWMON=n.

Guenter

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

net/core/filter.c: In function 'sk_msg_convert_ctx_access':
net/core/filter.c:6450:6: warning: unused variable 'off' [-Wunused-variable]
  int off;
  ^~~

Introduced by commit

  303def35f64e ("bpf: allow sk_msg programs to read sock fields")

-- 
Cheers,
Stephen Rothwell


pgpjckujcMn2y.pgp
Description: OpenPGP digital signature

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

net/core/filter.c: In function 'sk_msg_convert_ctx_access':
net/core/filter.c:6450:6: warning: unused variable 'off' [-Wunused-variable]
  int off;
  ^~~

Introduced by commit

  303def35f64e ("bpf: allow sk_msg programs to read sock fields")

-- 
Cheers,
Stephen Rothwell


pgpjckujcMn2y.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the net-next tree

[Gustavo A. R. Silva]

On 03/13/2018 10:33 AM, David Miller wrote:

From: "Gustavo A. R. Silva" 
Date: Tue, 13 Mar 2018 06:46:24 -0500


Hi Stephen,

On 03/13/2018 01:11 AM, Stephen Rothwell wrote:

Hi all,
After merging the net-next tree, today's linux-next build (sparc
defconfig) produced this warning:
net/core/pktgen.c: In function 'pktgen_if_write':
net/core/pktgen.c:1710:1: warning: the frame size of 1048 bytes is
larger than 1024 bytes [-Wframe-larger-than=]
   }
   ^
Introduced by commit
35951393bbff ("pktgen: Remove VLA usage")



Thanks for the report.

David:

If this code is not going to be executed very often [1], then I think
it is safe to use dynamic memory allocation instead, as this is not
going to impact the performance.

What do you think?

[1] https://lkml.org/lkml/2018/3/9/630


Sure, that works.

It is only invoked when pktgen configuration changes are made.



OK. I'll send a new patch for this.

Thanks
--
Gustavo

Re: linux-next: build warning after merge of the net-next tree

[Gustavo A. R. Silva]

On 03/13/2018 10:33 AM, David Miller wrote:

From: "Gustavo A. R. Silva" 
Date: Tue, 13 Mar 2018 06:46:24 -0500


Hi Stephen,

On 03/13/2018 01:11 AM, Stephen Rothwell wrote:

Hi all,
After merging the net-next tree, today's linux-next build (sparc
defconfig) produced this warning:
net/core/pktgen.c: In function 'pktgen_if_write':
net/core/pktgen.c:1710:1: warning: the frame size of 1048 bytes is
larger than 1024 bytes [-Wframe-larger-than=]
   }
   ^
Introduced by commit
35951393bbff ("pktgen: Remove VLA usage")



Thanks for the report.

David:

If this code is not going to be executed very often [1], then I think
it is safe to use dynamic memory allocation instead, as this is not
going to impact the performance.

What do you think?

[1] https://lkml.org/lkml/2018/3/9/630


Sure, that works.

It is only invoked when pktgen configuration changes are made.



OK. I'll send a new patch for this.

Thanks
--
Gustavo

Re: linux-next: build warning after merge of the net-next tree

[David Miller]

From: "Gustavo A. R. Silva" 
Date: Tue, 13 Mar 2018 06:46:24 -0500

> Hi Stephen,
> 
> On 03/13/2018 01:11 AM, Stephen Rothwell wrote:
>> Hi all,
>> After merging the net-next tree, today's linux-next build (sparc
>> defconfig) produced this warning:
>> net/core/pktgen.c: In function 'pktgen_if_write':
>> net/core/pktgen.c:1710:1: warning: the frame size of 1048 bytes is
>> larger than 1024 bytes [-Wframe-larger-than=]
>>   }
>>   ^
>> Introduced by commit
>>35951393bbff ("pktgen: Remove VLA usage")
>> 
> 
> Thanks for the report.
> 
> David:
> 
> If this code is not going to be executed very often [1], then I think
> it is safe to use dynamic memory allocation instead, as this is not
> going to impact the performance.
> 
> What do you think?
> 
> [1] https://lkml.org/lkml/2018/3/9/630

Sure, that works.

It is only invoked when pktgen configuration changes are made.

Re: linux-next: build warning after merge of the net-next tree

[David Miller]

From: "Gustavo A. R. Silva" 
Date: Tue, 13 Mar 2018 06:46:24 -0500

> Hi Stephen,
> 
> On 03/13/2018 01:11 AM, Stephen Rothwell wrote:
>> Hi all,
>> After merging the net-next tree, today's linux-next build (sparc
>> defconfig) produced this warning:
>> net/core/pktgen.c: In function 'pktgen_if_write':
>> net/core/pktgen.c:1710:1: warning: the frame size of 1048 bytes is
>> larger than 1024 bytes [-Wframe-larger-than=]
>>   }
>>   ^
>> Introduced by commit
>>35951393bbff ("pktgen: Remove VLA usage")
>> 
> 
> Thanks for the report.
> 
> David:
> 
> If this code is not going to be executed very often [1], then I think
> it is safe to use dynamic memory allocation instead, as this is not
> going to impact the performance.
> 
> What do you think?
> 
> [1] https://lkml.org/lkml/2018/3/9/630

Sure, that works.

It is only invoked when pktgen configuration changes are made.

Re: linux-next: build warning after merge of the net-next tree

[Gustavo A. R. Silva]

Hi Stephen,

On 03/13/2018 01:11 AM, Stephen Rothwell wrote:

Hi all,

After merging the net-next tree, today's linux-next build (sparc
defconfig) produced this warning:

net/core/pktgen.c: In function 'pktgen_if_write':
net/core/pktgen.c:1710:1: warning: the frame size of 1048 bytes is larger than 
1024 bytes [-Wframe-larger-than=]
  }
  ^

Introduced by commit

   35951393bbff ("pktgen: Remove VLA usage")



Thanks for the report.

David:

If this code is not going to be executed very often [1], then I think it 
is safe to use dynamic memory allocation instead, as this is not going 
to impact the performance.


What do you think?

[1] https://lkml.org/lkml/2018/3/9/630

Thanks
--
Gustavo

Re: linux-next: build warning after merge of the net-next tree

[Gustavo A. R. Silva]

Hi Stephen,

On 03/13/2018 01:11 AM, Stephen Rothwell wrote:

Hi all,

After merging the net-next tree, today's linux-next build (sparc
defconfig) produced this warning:

net/core/pktgen.c: In function 'pktgen_if_write':
net/core/pktgen.c:1710:1: warning: the frame size of 1048 bytes is larger than 
1024 bytes [-Wframe-larger-than=]
  }
  ^

Introduced by commit

   35951393bbff ("pktgen: Remove VLA usage")



Thanks for the report.

David:

If this code is not going to be executed very often [1], then I think it 
is safe to use dynamic memory allocation instead, as this is not going 
to impact the performance.


What do you think?

[1] https://lkml.org/lkml/2018/3/9/630

Thanks
--
Gustavo

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (sparc
defconfig) produced this warning:

net/core/pktgen.c: In function 'pktgen_if_write':
net/core/pktgen.c:1710:1: warning: the frame size of 1048 bytes is larger than 
1024 bytes [-Wframe-larger-than=]
 }
 ^

Introduced by commit

  35951393bbff ("pktgen: Remove VLA usage")

-- 
Cheers,
Stephen Rothwell


pgpRJNRE8mofB.pgp
Description: OpenPGP digital signature

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (sparc
defconfig) produced this warning:

net/core/pktgen.c: In function 'pktgen_if_write':
net/core/pktgen.c:1710:1: warning: the frame size of 1048 bytes is larger than 
1024 bytes [-Wframe-larger-than=]
 }
 ^

Introduced by commit

  35951393bbff ("pktgen: Remove VLA usage")

-- 
Cheers,
Stephen Rothwell


pgpRJNRE8mofB.pgp
Description: OpenPGP digital signature

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

net/sched/cls_api.c: In function 'tc_dump_tfilter':
net/sched/cls_api.c:1362:8: warning: 'parent' may be used uninitialized in this 
function [-Wmaybe-uninitialized]
   if (!tcf_chain_dump(chain, q, parent, skb, cb,
^
 index_start, ))
 

Probably introduced by commit

  7960d1daf278 ("net: sched: use block index as a handle instead of qdisc when 
block is shared")

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

net/sched/cls_api.c: In function 'tc_dump_tfilter':
net/sched/cls_api.c:1362:8: warning: 'parent' may be used uninitialized in this 
function [-Wmaybe-uninitialized]
   if (!tcf_chain_dump(chain, q, parent, skb, cb,
^
 index_start, ))
 

Probably introduced by commit

  7960d1daf278 ("net: sched: use block index as a handle instead of qdisc when 
block is shared")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the net-next tree

[David Miller]

From: Stephen Rothwell 
Date: Mon, 4 Dec 2017 11:02:49 +1100

> After merging the net-next tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> drivers/net/phy/broadcom.c:391:12: warning: 'bcm5482_read_status' defined but 
> not used [-Wunused-function]
>  static int bcm5482_read_status(struct phy_device *phydev)
> ^
> drivers/net/phy/broadcom.c:411:12: warning: 'bcm5481_config_aneg' defined but 
> not used [-Wunused-function]
>  static int bcm5481_config_aneg(struct phy_device *phydev)
> ^
> 
> Introduced by commit
> 
>   80274abafc60 ("net: phy: remove generic settings for callbacks config_aneg 
> and read_status from drivers")

This shoudl be resolved now, thanks for the report.

Re: linux-next: build warning after merge of the net-next tree

[David Miller]

From: Stephen Rothwell 
Date: Mon, 4 Dec 2017 11:02:49 +1100

> After merging the net-next tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> drivers/net/phy/broadcom.c:391:12: warning: 'bcm5482_read_status' defined but 
> not used [-Wunused-function]
>  static int bcm5482_read_status(struct phy_device *phydev)
> ^
> drivers/net/phy/broadcom.c:411:12: warning: 'bcm5481_config_aneg' defined but 
> not used [-Wunused-function]
>  static int bcm5481_config_aneg(struct phy_device *phydev)
> ^
> 
> Introduced by commit
> 
>   80274abafc60 ("net: phy: remove generic settings for callbacks config_aneg 
> and read_status from drivers")

This shoudl be resolved now, thanks for the report.

Re: linux-next: build warning after merge of the net-next tree

[Heiner Kallweit]

Am 04.12.2017 um 01:02 schrieb Stephen Rothwell:
> Hi all,
> 
> After merging the net-next tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> drivers/net/phy/broadcom.c:391:12: warning: 'bcm5482_read_status' defined but 
> not used [-Wunused-function]
>  static int bcm5482_read_status(struct phy_device *phydev)
> ^
> drivers/net/phy/broadcom.c:411:12: warning: 'bcm5481_config_aneg' defined but 
> not used [-Wunused-function]
>  static int bcm5481_config_aneg(struct phy_device *phydev)
> ^
> 
> Introduced by commit
> 
>   80274abafc60 ("net: phy: remove generic settings for callbacks config_aneg 
> and read_status from drivers")
> 
This issue has been addressed addressed already, see this patch:
https://marc.info/?l=linux-netdev=151220825402398=2

Rgds, Heiner

Re: linux-next: build warning after merge of the net-next tree

[Heiner Kallweit]

Am 04.12.2017 um 01:02 schrieb Stephen Rothwell:
> Hi all,
> 
> After merging the net-next tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> drivers/net/phy/broadcom.c:391:12: warning: 'bcm5482_read_status' defined but 
> not used [-Wunused-function]
>  static int bcm5482_read_status(struct phy_device *phydev)
> ^
> drivers/net/phy/broadcom.c:411:12: warning: 'bcm5481_config_aneg' defined but 
> not used [-Wunused-function]
>  static int bcm5481_config_aneg(struct phy_device *phydev)
> ^
> 
> Introduced by commit
> 
>   80274abafc60 ("net: phy: remove generic settings for callbacks config_aneg 
> and read_status from drivers")
> 
This issue has been addressed addressed already, see this patch:
https://marc.info/?l=linux-netdev=151220825402398=2

Rgds, Heiner

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/net/phy/broadcom.c:391:12: warning: 'bcm5482_read_status' defined but 
not used [-Wunused-function]
 static int bcm5482_read_status(struct phy_device *phydev)
^
drivers/net/phy/broadcom.c:411:12: warning: 'bcm5481_config_aneg' defined but 
not used [-Wunused-function]
 static int bcm5481_config_aneg(struct phy_device *phydev)
^

Introduced by commit

  80274abafc60 ("net: phy: remove generic settings for callbacks config_aneg 
and read_status from drivers")

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/net/phy/broadcom.c:391:12: warning: 'bcm5482_read_status' defined but 
not used [-Wunused-function]
 static int bcm5482_read_status(struct phy_device *phydev)
^
drivers/net/phy/broadcom.c:411:12: warning: 'bcm5481_config_aneg' defined but 
not used [-Wunused-function]
 static int bcm5481_config_aneg(struct phy_device *phydev)
^

Introduced by commit

  80274abafc60 ("net: phy: remove generic settings for callbacks config_aneg 
and read_status from drivers")

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

In file included from drivers/net/ethernet/ibm/ibmvnic.c:52:0:
drivers/net/ethernet/ibm/ibmvnic.c: In function 'ibmvnic_open':
include/linux/dma-mapping.h:571:2: warning: 'dma_addr' may be used 
uninitialized in this function [-Wmaybe-uninitialized]
  debug_dma_mapping_error(dev, dma_addr);
  ^
drivers/net/ethernet/ibm/ibmvnic.c:852:13: note: 'dma_addr' was declared here
  dma_addr_t dma_addr;
 ^

Introduced by commit

  4e6759be28e4 ("ibmvnic: Feature implementation of Vital Product Data (VPD) 
for the ibmvnic driver")

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

In file included from drivers/net/ethernet/ibm/ibmvnic.c:52:0:
drivers/net/ethernet/ibm/ibmvnic.c: In function 'ibmvnic_open':
include/linux/dma-mapping.h:571:2: warning: 'dma_addr' may be used 
uninitialized in this function [-Wmaybe-uninitialized]
  debug_dma_mapping_error(dev, dma_addr);
  ^
drivers/net/ethernet/ibm/ibmvnic.c:852:13: note: 'dma_addr' was declared here
  dma_addr_t dma_addr;
 ^

Introduced by commit

  4e6759be28e4 ("ibmvnic: Feature implementation of Vital Product Data (VPD) 
for the ibmvnic driver")

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

In file included from include/linux/byteorder/big_endian.h:4:0,
 from arch/powerpc/include/uapi/asm/byteorder.h:13,
 from include/asm-generic/bitops/le.h:5,
 from arch/powerpc/include/asm/bitops.h:279,
 from include/linux/bitops.h:36,
 from include/linux/kernel.h:10,
 from include/linux/skbuff.h:17,
 from include/linux/if_ether.h:23,
 from include/linux/etherdevice.h:25,
 from drivers/net/ethernet/intel/i40e/i40e_main.c:27:
drivers/net/ethernet/intel/i40e/i40e_main.c: In function 
'i40e_sync_vsi_filters':
include/uapi/linux/byteorder/big_endian.h:34:26: warning: large integer 
implicitly truncated to unsigned type [-Woverflow]
 #define __cpu_to_le16(x) ((__force __le16)__swab16((x)))
  ^
include/linux/byteorder/generic.h:89:21: note: in expansion of macro 
'__cpu_to_le16'
 #define cpu_to_le16 __cpu_to_le16
 ^
drivers/net/ethernet/intel/i40e/i40e_main.c:2200:5: note: in expansion of macro 
'cpu_to_le16'
 cpu_to_le16((u16)I40E_AQC_MM_ERR_NO_RES);
 ^

Introduced by commit

  ac9e23901441 ("i40e: refactor i40e_update_filter_state to avoid passing 
aq_err")

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

In file included from include/linux/byteorder/big_endian.h:4:0,
 from arch/powerpc/include/uapi/asm/byteorder.h:13,
 from include/asm-generic/bitops/le.h:5,
 from arch/powerpc/include/asm/bitops.h:279,
 from include/linux/bitops.h:36,
 from include/linux/kernel.h:10,
 from include/linux/skbuff.h:17,
 from include/linux/if_ether.h:23,
 from include/linux/etherdevice.h:25,
 from drivers/net/ethernet/intel/i40e/i40e_main.c:27:
drivers/net/ethernet/intel/i40e/i40e_main.c: In function 
'i40e_sync_vsi_filters':
include/uapi/linux/byteorder/big_endian.h:34:26: warning: large integer 
implicitly truncated to unsigned type [-Woverflow]
 #define __cpu_to_le16(x) ((__force __le16)__swab16((x)))
  ^
include/linux/byteorder/generic.h:89:21: note: in expansion of macro 
'__cpu_to_le16'
 #define cpu_to_le16 __cpu_to_le16
 ^
drivers/net/ethernet/intel/i40e/i40e_main.c:2200:5: note: in expansion of macro 
'cpu_to_le16'
 cpu_to_le16((u16)I40E_AQC_MM_ERR_NO_RES);
 ^

Introduced by commit

  ac9e23901441 ("i40e: refactor i40e_update_filter_state to avoid passing 
aq_err")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the net-next tree

[Martin KaFai Lau]

On Wed, Nov 16, 2016 at 11:36:47AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the net-next tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> kernel/bpf/bpf_lru_list.c: In function 
> '__bpf_lru_list_rotate_inactive.isra.3':
> kernel/bpf/bpf_lru_list.c:201:28: warning: 'next' may be used uninitialized 
> in this function [-Wmaybe-uninitialized]
>   l->next_inactive_rotation = next;
> ^
>
> Introduced by commit
>
>   3a08c2fd7634 ("bpf: LRU List")
>
> I can't tell if this is a false positive or not.
A false positive.

A patch has been posted: https://patchwork.ozlabs.org/patch/695202/

Thanks for the report.
--Martin

Re: linux-next: build warning after merge of the net-next tree

[Martin KaFai Lau]

On Wed, Nov 16, 2016 at 11:36:47AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the net-next tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> kernel/bpf/bpf_lru_list.c: In function 
> '__bpf_lru_list_rotate_inactive.isra.3':
> kernel/bpf/bpf_lru_list.c:201:28: warning: 'next' may be used uninitialized 
> in this function [-Wmaybe-uninitialized]
>   l->next_inactive_rotation = next;
> ^
>
> Introduced by commit
>
>   3a08c2fd7634 ("bpf: LRU List")
>
> I can't tell if this is a false positive or not.
A false positive.

A patch has been posted: https://patchwork.ozlabs.org/patch/695202/

Thanks for the report.
--Martin

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

kernel/bpf/bpf_lru_list.c: In function '__bpf_lru_list_rotate_inactive.isra.3':
kernel/bpf/bpf_lru_list.c:201:28: warning: 'next' may be used uninitialized in 
this function [-Wmaybe-uninitialized]
  l->next_inactive_rotation = next;
^

Introduced by commit

  3a08c2fd7634 ("bpf: LRU List")

I can't tell if this is a false positive or not.

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

kernel/bpf/bpf_lru_list.c: In function '__bpf_lru_list_rotate_inactive.isra.3':
kernel/bpf/bpf_lru_list.c:201:28: warning: 'next' may be used uninitialized in 
this function [-Wmaybe-uninitialized]
  l->next_inactive_rotation = next;
^

Introduced by commit

  3a08c2fd7634 ("bpf: LRU List")

I can't tell if this is a false positive or not.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the net-next tree

[Iyappan Subramanian]

On Tue, Jul 26, 2016 at 11:35 PM, Stephen Rothwell  
wrote:
> Hi David,
>
> On Tue, 26 Jul 2016 23:19:59 -0700 (PDT) David Miller  
> wrote:
>>
>> Fixed thusly:
>>
>> 
>> From 36232012344b8db67052432742deaf17f82e70e6 Mon Sep 17 00:00:00 2001
>> From: "David S. Miller" 
>> Date: Tue, 26 Jul 2016 23:19:29 -0700
>> Subject: [PATCH] xgene: Fix build warning with ACPI disabled.
>>
>> drivers/net/ethernet/apm/xgene/xgene_enet_hw.c: In function 
>> 'xgene_enet_phy_connect':
>> drivers/net/ethernet/apm/xgene/xgene_enet_hw.c:759:22: warning: unused 
>> variable 'adev' [-Wunused-variable]
>>
>> Fixes: 8089a96f601b ("drivers: net: xgene: Add backward compatibility")
>> Reported-by: Stephen Rothwell 
>> Signed-off-by: David S. Miller 
>> ---
>>  drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c 
>> b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c
>> index 8a2a221..7714b7d 100644
>> --- a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c
>> +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c
>> @@ -756,7 +756,6 @@ int xgene_enet_phy_connect(struct net_device *ndev)
>>   struct device_node *np;
>>   struct phy_device *phy_dev;
>>   struct device *dev = >pdev->dev;
>> - struct acpi_device *adev;
>>   int i;
>>
>>   if (dev->of_node) {
>> @@ -781,7 +780,7 @@ int xgene_enet_phy_connect(struct net_device *ndev)
>>   pdata->phy_dev = phy_dev;
>>   } else {
>>  #ifdef CONFIG_ACPI
>> - adev = acpi_phy_find_device(dev);
>> + struct acpi_device *adev = acpi_phy_find_device(dev);
>>   if (adev)
>>   pdata->phy_dev =  adev->driver_data;
>
> Looks good to me, thanks.

Thanks David, for the quick fix.

>
> --
> Cheers,
> Stephen Rothwell

Re: linux-next: build warning after merge of the net-next tree

[Iyappan Subramanian]

On Tue, Jul 26, 2016 at 11:35 PM, Stephen Rothwell  
wrote:
> Hi David,
>
> On Tue, 26 Jul 2016 23:19:59 -0700 (PDT) David Miller  
> wrote:
>>
>> Fixed thusly:
>>
>> 
>> From 36232012344b8db67052432742deaf17f82e70e6 Mon Sep 17 00:00:00 2001
>> From: "David S. Miller" 
>> Date: Tue, 26 Jul 2016 23:19:29 -0700
>> Subject: [PATCH] xgene: Fix build warning with ACPI disabled.
>>
>> drivers/net/ethernet/apm/xgene/xgene_enet_hw.c: In function 
>> 'xgene_enet_phy_connect':
>> drivers/net/ethernet/apm/xgene/xgene_enet_hw.c:759:22: warning: unused 
>> variable 'adev' [-Wunused-variable]
>>
>> Fixes: 8089a96f601b ("drivers: net: xgene: Add backward compatibility")
>> Reported-by: Stephen Rothwell 
>> Signed-off-by: David S. Miller 
>> ---
>>  drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c 
>> b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c
>> index 8a2a221..7714b7d 100644
>> --- a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c
>> +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c
>> @@ -756,7 +756,6 @@ int xgene_enet_phy_connect(struct net_device *ndev)
>>   struct device_node *np;
>>   struct phy_device *phy_dev;
>>   struct device *dev = >pdev->dev;
>> - struct acpi_device *adev;
>>   int i;
>>
>>   if (dev->of_node) {
>> @@ -781,7 +780,7 @@ int xgene_enet_phy_connect(struct net_device *ndev)
>>   pdata->phy_dev = phy_dev;
>>   } else {
>>  #ifdef CONFIG_ACPI
>> - adev = acpi_phy_find_device(dev);
>> + struct acpi_device *adev = acpi_phy_find_device(dev);
>>   if (adev)
>>   pdata->phy_dev =  adev->driver_data;
>
> Looks good to me, thanks.

Thanks David, for the quick fix.

>
> --
> Cheers,
> Stephen Rothwell

Re: linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi David,

On Tue, 26 Jul 2016 23:19:59 -0700 (PDT) David Miller  
wrote:
>
> Fixed thusly:
> 
> 
> From 36232012344b8db67052432742deaf17f82e70e6 Mon Sep 17 00:00:00 2001
> From: "David S. Miller" 
> Date: Tue, 26 Jul 2016 23:19:29 -0700
> Subject: [PATCH] xgene: Fix build warning with ACPI disabled.
> 
> drivers/net/ethernet/apm/xgene/xgene_enet_hw.c: In function 
> 'xgene_enet_phy_connect':
> drivers/net/ethernet/apm/xgene/xgene_enet_hw.c:759:22: warning: unused 
> variable 'adev' [-Wunused-variable]
> 
> Fixes: 8089a96f601b ("drivers: net: xgene: Add backward compatibility")
> Reported-by: Stephen Rothwell 
> Signed-off-by: David S. Miller 
> ---
>  drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c 
> b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c
> index 8a2a221..7714b7d 100644
> --- a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c
> +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c
> @@ -756,7 +756,6 @@ int xgene_enet_phy_connect(struct net_device *ndev)
>   struct device_node *np;
>   struct phy_device *phy_dev;
>   struct device *dev = >pdev->dev;
> - struct acpi_device *adev;
>   int i;
>  
>   if (dev->of_node) {
> @@ -781,7 +780,7 @@ int xgene_enet_phy_connect(struct net_device *ndev)
>   pdata->phy_dev = phy_dev;
>   } else {
>  #ifdef CONFIG_ACPI
> - adev = acpi_phy_find_device(dev);
> + struct acpi_device *adev = acpi_phy_find_device(dev);
>   if (adev)
>   pdata->phy_dev =  adev->driver_data;

Looks good to me, thanks.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi David,

On Tue, 26 Jul 2016 23:19:59 -0700 (PDT) David Miller  
wrote:
>
> Fixed thusly:
> 
> 
> From 36232012344b8db67052432742deaf17f82e70e6 Mon Sep 17 00:00:00 2001
> From: "David S. Miller" 
> Date: Tue, 26 Jul 2016 23:19:29 -0700
> Subject: [PATCH] xgene: Fix build warning with ACPI disabled.
> 
> drivers/net/ethernet/apm/xgene/xgene_enet_hw.c: In function 
> 'xgene_enet_phy_connect':
> drivers/net/ethernet/apm/xgene/xgene_enet_hw.c:759:22: warning: unused 
> variable 'adev' [-Wunused-variable]
> 
> Fixes: 8089a96f601b ("drivers: net: xgene: Add backward compatibility")
> Reported-by: Stephen Rothwell 
> Signed-off-by: David S. Miller 
> ---
>  drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c 
> b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c
> index 8a2a221..7714b7d 100644
> --- a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c
> +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c
> @@ -756,7 +756,6 @@ int xgene_enet_phy_connect(struct net_device *ndev)
>   struct device_node *np;
>   struct phy_device *phy_dev;
>   struct device *dev = >pdev->dev;
> - struct acpi_device *adev;
>   int i;
>  
>   if (dev->of_node) {
> @@ -781,7 +780,7 @@ int xgene_enet_phy_connect(struct net_device *ndev)
>   pdata->phy_dev = phy_dev;
>   } else {
>  #ifdef CONFIG_ACPI
> - adev = acpi_phy_find_device(dev);
> + struct acpi_device *adev = acpi_phy_find_device(dev);
>   if (adev)
>   pdata->phy_dev =  adev->driver_data;

Looks good to me, thanks.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the net-next tree

[David Miller]

From: Stephen Rothwell 
Date: Wed, 27 Jul 2016 16:15:33 +1000

> Hi all,
> 
> After merging the net-next tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
> 
> drivers/net/ethernet/apm/xgene/xgene_enet_hw.c: In function 
> 'xgene_enet_phy_connect':
> drivers/net/ethernet/apm/xgene/xgene_enet_hw.c:759:22: warning: unused 
> variable 'adev' [-Wunused-variable]
>   struct acpi_device *adev;
>   ^
> 
> Introduced by commit
> 
>   8089a96f601b ("drivers: net: xgene: Add backward compatibility")
> (CONFIG_ACPI si not set for tis build)

Fixed thusly:


>From 36232012344b8db67052432742deaf17f82e70e6 Mon Sep 17 00:00:00 2001
From: "David S. Miller" 
Date: Tue, 26 Jul 2016 23:19:29 -0700
Subject: [PATCH] xgene: Fix build warning with ACPI disabled.

drivers/net/ethernet/apm/xgene/xgene_enet_hw.c: In function 
'xgene_enet_phy_connect':
drivers/net/ethernet/apm/xgene/xgene_enet_hw.c:759:22: warning: unused variable 
'adev' [-Wunused-variable]

Fixes: 8089a96f601b ("drivers: net: xgene: Add backward compatibility")
Reported-by: Stephen Rothwell 
Signed-off-by: David S. Miller 
---
 drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c 
b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c
index 8a2a221..7714b7d 100644
--- a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c
+++ b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c
@@ -756,7 +756,6 @@ int xgene_enet_phy_connect(struct net_device *ndev)
struct device_node *np;
struct phy_device *phy_dev;
struct device *dev = >pdev->dev;
-   struct acpi_device *adev;
int i;
 
if (dev->of_node) {
@@ -781,7 +780,7 @@ int xgene_enet_phy_connect(struct net_device *ndev)
pdata->phy_dev = phy_dev;
} else {
 #ifdef CONFIG_ACPI
-   adev = acpi_phy_find_device(dev);
+   struct acpi_device *adev = acpi_phy_find_device(dev);
if (adev)
pdata->phy_dev =  adev->driver_data;
 
-- 
2.1.0

Re: linux-next: build warning after merge of the net-next tree

[David Miller]

From: Stephen Rothwell 
Date: Wed, 27 Jul 2016 16:15:33 +1000

> Hi all,
> 
> After merging the net-next tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
> 
> drivers/net/ethernet/apm/xgene/xgene_enet_hw.c: In function 
> 'xgene_enet_phy_connect':
> drivers/net/ethernet/apm/xgene/xgene_enet_hw.c:759:22: warning: unused 
> variable 'adev' [-Wunused-variable]
>   struct acpi_device *adev;
>   ^
> 
> Introduced by commit
> 
>   8089a96f601b ("drivers: net: xgene: Add backward compatibility")
> (CONFIG_ACPI si not set for tis build)

Fixed thusly:


>From 36232012344b8db67052432742deaf17f82e70e6 Mon Sep 17 00:00:00 2001
From: "David S. Miller" 
Date: Tue, 26 Jul 2016 23:19:29 -0700
Subject: [PATCH] xgene: Fix build warning with ACPI disabled.

drivers/net/ethernet/apm/xgene/xgene_enet_hw.c: In function 
'xgene_enet_phy_connect':
drivers/net/ethernet/apm/xgene/xgene_enet_hw.c:759:22: warning: unused variable 
'adev' [-Wunused-variable]

Fixes: 8089a96f601b ("drivers: net: xgene: Add backward compatibility")
Reported-by: Stephen Rothwell 
Signed-off-by: David S. Miller 
---
 drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c 
b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c
index 8a2a221..7714b7d 100644
--- a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c
+++ b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c
@@ -756,7 +756,6 @@ int xgene_enet_phy_connect(struct net_device *ndev)
struct device_node *np;
struct phy_device *phy_dev;
struct device *dev = >pdev->dev;
-   struct acpi_device *adev;
int i;
 
if (dev->of_node) {
@@ -781,7 +780,7 @@ int xgene_enet_phy_connect(struct net_device *ndev)
pdata->phy_dev = phy_dev;
} else {
 #ifdef CONFIG_ACPI
-   adev = acpi_phy_find_device(dev);
+   struct acpi_device *adev = acpi_phy_find_device(dev);
if (adev)
pdata->phy_dev =  adev->driver_data;
 
-- 
2.1.0

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

drivers/net/ethernet/apm/xgene/xgene_enet_hw.c: In function 
'xgene_enet_phy_connect':
drivers/net/ethernet/apm/xgene/xgene_enet_hw.c:759:22: warning: unused variable 
'adev' [-Wunused-variable]
  struct acpi_device *adev;
  ^

Introduced by commit

  8089a96f601b ("drivers: net: xgene: Add backward compatibility")
(CONFIG_ACPI si not set for tis build)

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

drivers/net/ethernet/apm/xgene/xgene_enet_hw.c: In function 
'xgene_enet_phy_connect':
drivers/net/ethernet/apm/xgene/xgene_enet_hw.c:759:22: warning: unused variable 
'adev' [-Wunused-variable]
  struct acpi_device *adev;
  ^

Introduced by commit

  8089a96f601b ("drivers: net: xgene: Add backward compatibility")
(CONFIG_ACPI si not set for tis build)

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the net-next tree

[Simon Horman]

On Mon, Jul 11, 2016 at 04:13:11PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the net-next tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning (CONFIG_MPLS is disabled):
> 
> net/ipv4/tunnel4.c: In function 'tunnel4_init':
> net/ipv4/tunnel4.c:223:1: warning: label 'err_mpls' defined but not used 
> [-Wunused-label]
>  err_mpls:
>  ^
> 
> and the powerpc ppc64_defconfig build produced this (CONFIG_IPV6 is disabled):
> 
> net/ipv4/tunnel4.c: In function 'tunnel4_init':
> net/ipv4/tunnel4.c:226:1: warning: label 'err_ipv6' defined but not used 
> [-Wunused-label]
>  err_ipv6:
>  ^
> 
> Introduced by commit
> 
>   8afe97e5d416 ("tunnels: support MPLS over IPv4 tunnels")

Thanks Stephen,

I have posted a fix for this.

"[PATCH net-next v2] tunnels: correct conditional build of MPLS and IPv6"

Re: linux-next: build warning after merge of the net-next tree

[Simon Horman]

On Mon, Jul 11, 2016 at 04:13:11PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the net-next tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning (CONFIG_MPLS is disabled):
> 
> net/ipv4/tunnel4.c: In function 'tunnel4_init':
> net/ipv4/tunnel4.c:223:1: warning: label 'err_mpls' defined but not used 
> [-Wunused-label]
>  err_mpls:
>  ^
> 
> and the powerpc ppc64_defconfig build produced this (CONFIG_IPV6 is disabled):
> 
> net/ipv4/tunnel4.c: In function 'tunnel4_init':
> net/ipv4/tunnel4.c:226:1: warning: label 'err_ipv6' defined but not used 
> [-Wunused-label]
>  err_ipv6:
>  ^
> 
> Introduced by commit
> 
>   8afe97e5d416 ("tunnels: support MPLS over IPv4 tunnels")

Thanks Stephen,

I have posted a fix for this.

"[PATCH net-next v2] tunnels: correct conditional build of MPLS and IPv6"

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning (CONFIG_MPLS is disabled):

net/ipv4/tunnel4.c: In function 'tunnel4_init':
net/ipv4/tunnel4.c:223:1: warning: label 'err_mpls' defined but not used 
[-Wunused-label]
 err_mpls:
 ^

and the powerpc ppc64_defconfig build produced this (CONFIG_IPV6 is disabled):

net/ipv4/tunnel4.c: In function 'tunnel4_init':
net/ipv4/tunnel4.c:226:1: warning: label 'err_ipv6' defined but not used 
[-Wunused-label]
 err_ipv6:
 ^

Introduced by commit

  8afe97e5d416 ("tunnels: support MPLS over IPv4 tunnels")

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning (CONFIG_MPLS is disabled):

net/ipv4/tunnel4.c: In function 'tunnel4_init':
net/ipv4/tunnel4.c:223:1: warning: label 'err_mpls' defined but not used 
[-Wunused-label]
 err_mpls:
 ^

and the powerpc ppc64_defconfig build produced this (CONFIG_IPV6 is disabled):

net/ipv4/tunnel4.c: In function 'tunnel4_init':
net/ipv4/tunnel4.c:226:1: warning: label 'err_ipv6' defined but not used 
[-Wunused-label]
 err_ipv6:
 ^

Introduced by commit

  8afe97e5d416 ("tunnels: support MPLS over IPv4 tunnels")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the net-next tree

[Jason Wang]

On 2016年07月04日 11:15, Stephen Rothwell wrote:

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/net/tun.c: In function 'tun_do_read.part.5':
/home/sfr/next/next/drivers/net/tun.c:1491:6: warning: 'err' may be used 
uninitialized in this function [-Wmaybe-uninitialized]
   int err;
   ^

Introduced by commit

   1576d9860599 ("tun: switch to use skb array for tx")

I can't easily see if this is a false positive.



Thanks for the reporting, will post a fix.

Re: linux-next: build warning after merge of the net-next tree

[Jason Wang]

On 2016年07月04日 11:15, Stephen Rothwell wrote:

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/net/tun.c: In function 'tun_do_read.part.5':
/home/sfr/next/next/drivers/net/tun.c:1491:6: warning: 'err' may be used 
uninitialized in this function [-Wmaybe-uninitialized]
   int err;
   ^

Introduced by commit

   1576d9860599 ("tun: switch to use skb array for tx")

I can't easily see if this is a false positive.



Thanks for the reporting, will post a fix.

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/net/tun.c: In function 'tun_do_read.part.5':
/home/sfr/next/next/drivers/net/tun.c:1491:6: warning: 'err' may be used 
uninitialized in this function [-Wmaybe-uninitialized]
  int err;
  ^

Introduced by commit

  1576d9860599 ("tun: switch to use skb array for tx")

I can't easily see if this is a false positive.

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/net/tun.c: In function 'tun_do_read.part.5':
/home/sfr/next/next/drivers/net/tun.c:1491:6: warning: 'err' may be used 
uninitialized in this function [-Wmaybe-uninitialized]
  int err;
  ^

Introduced by commit

  1576d9860599 ("tun: switch to use skb array for tx")

I can't easily see if this is a false positive.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the net-next tree

[Nikolay Borisov]

On 02/15/2016 04:09 AM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the net-next tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> net/ipv4/igmp.c: In function 'igmp_group_added':
> net/ipv4/igmp.c:1227:14: warning: unused variable 'net' [-Wunused-variable]
>   struct net *net = dev_net(in_dev->dev);
>   ^
> net/ipv4/igmp.c: In function 'ip_mc_inc_group':
> net/ipv4/igmp.c:1319:14: warning: unused variable 'net' [-Wunused-variable]
>   struct net *net = dev_net(in_dev->dev);
>   ^
> net/ipv4/igmp.c: In function 'ip_mc_init_dev':
> net/ipv4/igmp.c:1646:14: warning: unused variable 'net' [-Wunused-variable]
>   struct net *net = dev_net(in_dev->dev);
>   ^
> net/ipv4/igmp.c: In function 'ip_mc_up':
> net/ipv4/igmp.c:1665:14: warning: unused variable 'net' [-Wunused-variable]
>   struct net *net = dev_net(in_dev->dev);
>   ^
> 
> Introduced by commits
> 
>   87a8a2ae65b7 ("igmp: Namespaceify igmp_llm_reports sysctl knob")
>   165094afcee7 ("igmp: Namespacify igmp_qrv sysctl knob")
> 
> CONFIG_IP_MULTICAST is not set for this build.

Right, I have forgotten to add the ifdef guards for the respective
variables, will squeeze a patch in the next series on namespaceifying
various sysctls.

Thanks for testing!

Re: linux-next: build warning after merge of the net-next tree

[Nikolay Borisov]

On 02/15/2016 04:09 AM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the net-next tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> net/ipv4/igmp.c: In function 'igmp_group_added':
> net/ipv4/igmp.c:1227:14: warning: unused variable 'net' [-Wunused-variable]
>   struct net *net = dev_net(in_dev->dev);
>   ^
> net/ipv4/igmp.c: In function 'ip_mc_inc_group':
> net/ipv4/igmp.c:1319:14: warning: unused variable 'net' [-Wunused-variable]
>   struct net *net = dev_net(in_dev->dev);
>   ^
> net/ipv4/igmp.c: In function 'ip_mc_init_dev':
> net/ipv4/igmp.c:1646:14: warning: unused variable 'net' [-Wunused-variable]
>   struct net *net = dev_net(in_dev->dev);
>   ^
> net/ipv4/igmp.c: In function 'ip_mc_up':
> net/ipv4/igmp.c:1665:14: warning: unused variable 'net' [-Wunused-variable]
>   struct net *net = dev_net(in_dev->dev);
>   ^
> 
> Introduced by commits
> 
>   87a8a2ae65b7 ("igmp: Namespaceify igmp_llm_reports sysctl knob")
>   165094afcee7 ("igmp: Namespacify igmp_qrv sysctl knob")
> 
> CONFIG_IP_MULTICAST is not set for this build.

Right, I have forgotten to add the ifdef guards for the respective
variables, will squeeze a patch in the next series on namespaceifying
various sysctls.

Thanks for testing!

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

net/ipv4/igmp.c: In function 'igmp_group_added':
net/ipv4/igmp.c:1227:14: warning: unused variable 'net' [-Wunused-variable]
  struct net *net = dev_net(in_dev->dev);
  ^
net/ipv4/igmp.c: In function 'ip_mc_inc_group':
net/ipv4/igmp.c:1319:14: warning: unused variable 'net' [-Wunused-variable]
  struct net *net = dev_net(in_dev->dev);
  ^
net/ipv4/igmp.c: In function 'ip_mc_init_dev':
net/ipv4/igmp.c:1646:14: warning: unused variable 'net' [-Wunused-variable]
  struct net *net = dev_net(in_dev->dev);
  ^
net/ipv4/igmp.c: In function 'ip_mc_up':
net/ipv4/igmp.c:1665:14: warning: unused variable 'net' [-Wunused-variable]
  struct net *net = dev_net(in_dev->dev);
  ^

Introduced by commits

  87a8a2ae65b7 ("igmp: Namespaceify igmp_llm_reports sysctl knob")
  165094afcee7 ("igmp: Namespacify igmp_qrv sysctl knob")

CONFIG_IP_MULTICAST is not set for this build.

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

net/ipv4/igmp.c: In function 'igmp_group_added':
net/ipv4/igmp.c:1227:14: warning: unused variable 'net' [-Wunused-variable]
  struct net *net = dev_net(in_dev->dev);
  ^
net/ipv4/igmp.c: In function 'ip_mc_inc_group':
net/ipv4/igmp.c:1319:14: warning: unused variable 'net' [-Wunused-variable]
  struct net *net = dev_net(in_dev->dev);
  ^
net/ipv4/igmp.c: In function 'ip_mc_init_dev':
net/ipv4/igmp.c:1646:14: warning: unused variable 'net' [-Wunused-variable]
  struct net *net = dev_net(in_dev->dev);
  ^
net/ipv4/igmp.c: In function 'ip_mc_up':
net/ipv4/igmp.c:1665:14: warning: unused variable 'net' [-Wunused-variable]
  struct net *net = dev_net(in_dev->dev);
  ^

Introduced by commits

  87a8a2ae65b7 ("igmp: Namespaceify igmp_llm_reports sysctl knob")
  165094afcee7 ("igmp: Namespacify igmp_qrv sysctl knob")

CONFIG_IP_MULTICAST is not set for this build.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the net-next tree

[Cong Wang]

On Thu, May 15, 2014 at 10:43 AM, David Miller  wrote:
>
> I've just pushed out a fix for this, thanks everyone.

Thanks, David!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build warning after merge of the net-next tree

[David Miller]

From: Cong Wang 
Date: Thu, 15 May 2014 10:39:20 -0700

> On Wed, May 14, 2014 at 11:47 PM, Stephen Rothwell  
> wrote:
>> Hi all,
>>
>> After merging the net-next tree, today's linux-next build (powerpc
>> allnoconfig) produced this warning:
>>
>>
>> include/net/ip.h:211:5: warning: "CONFIG_SYSCTL" is not defined [-Wundef]
>>  #if CONFIG_SYSCTL
>>  ^
>>
>> Introduced by commit 122ff243f5f1 ("ipv4: make ip_local_reserved_ports
>> per netns").
> 
> 
> Oops, blame my fat fingers... Just s/#if/#ifdef/. ;)

I've just pushed out a fix for this, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build warning after merge of the net-next tree

[Cong Wang]

On Wed, May 14, 2014 at 11:47 PM, Stephen Rothwell  
wrote:
> Hi all,
>
> After merging the net-next tree, today's linux-next build (powerpc
> allnoconfig) produced this warning:
>
>
> include/net/ip.h:211:5: warning: "CONFIG_SYSCTL" is not defined [-Wundef]
>  #if CONFIG_SYSCTL
>  ^
>
> Introduced by commit 122ff243f5f1 ("ipv4: make ip_local_reserved_ports
> per netns").


Oops, blame my fat fingers... Just s/#if/#ifdef/. ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
allnoconfig) produced this warning:


include/net/ip.h:211:5: warning: "CONFIG_SYSCTL" is not defined [-Wundef]
 #if CONFIG_SYSCTL
 ^

Introduced by commit 122ff243f5f1 ("ipv4: make ip_local_reserved_ports
per netns").
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


signature.asc
Description: PGP signature

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
allnoconfig) produced this warning:


include/net/ip.h:211:5: warning: CONFIG_SYSCTL is not defined [-Wundef]
 #if CONFIG_SYSCTL
 ^

Introduced by commit 122ff243f5f1 (ipv4: make ip_local_reserved_ports
per netns).
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


signature.asc
Description: PGP signature

Re: linux-next: build warning after merge of the net-next tree

[Cong Wang]

On Wed, May 14, 2014 at 11:47 PM, Stephen Rothwell s...@canb.auug.org.au 
wrote:
 Hi all,

 After merging the net-next tree, today's linux-next build (powerpc
 allnoconfig) produced this warning:


 include/net/ip.h:211:5: warning: CONFIG_SYSCTL is not defined [-Wundef]
  #if CONFIG_SYSCTL
  ^

 Introduced by commit 122ff243f5f1 (ipv4: make ip_local_reserved_ports
 per netns).


Oops, blame my fat fingers... Just s/#if/#ifdef/. ;)
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build warning after merge of the net-next tree

[David Miller]

From: Cong Wang xiyou.wangc...@gmail.com
Date: Thu, 15 May 2014 10:39:20 -0700

 On Wed, May 14, 2014 at 11:47 PM, Stephen Rothwell s...@canb.auug.org.au 
 wrote:
 Hi all,

 After merging the net-next tree, today's linux-next build (powerpc
 allnoconfig) produced this warning:


 include/net/ip.h:211:5: warning: CONFIG_SYSCTL is not defined [-Wundef]
  #if CONFIG_SYSCTL
  ^

 Introduced by commit 122ff243f5f1 (ipv4: make ip_local_reserved_ports
 per netns).
 
 
 Oops, blame my fat fingers... Just s/#if/#ifdef/. ;)

I've just pushed out a fix for this, thanks everyone.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build warning after merge of the net-next tree

[Cong Wang]

On Thu, May 15, 2014 at 10:43 AM, David Miller da...@davemloft.net wrote:

 I've just pushed out a fix for this, thanks everyone.

Thanks, David!
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c: In function 
'qlcnic_send_filter':
drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c:349:3: warning: passing argument 
2 of 'ether_addr_equal' from incompatible pointer type [enabled by default]
   if (ether_addr_equal(tmp_fil->faddr, _addr) &&
   ^
In file included from include/linux/if_vlan.h:16:0,
 from drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c:9:
include/linux/etherdevice.h:244:20: note: expected 'const u8 *' but argument is 
of type 'u64 *'
 static inline bool ether_addr_equal(const u8 *addr1, const u8 *addr2)
^

Introduced by commit 6878f79a8b71 ("net: qlcnic: slight optimization of
addr compare").

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgp45wEIG9gDh.pgp
Description: PGP signature

linux-next: build warning after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c: In function 
'qlcnic_send_filter':
drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c:349:3: warning: passing argument 
2 of 'ether_addr_equal' from incompatible pointer type [enabled by default]
   if (ether_addr_equal(tmp_fil-faddr, src_addr) 
   ^
In file included from include/linux/if_vlan.h:16:0,
 from drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c:9:
include/linux/etherdevice.h:244:20: note: expected 'const u8 *' but argument is 
of type 'u64 *'
 static inline bool ether_addr_equal(const u8 *addr1, const u8 *addr2)
^

Introduced by commit 6878f79a8b71 (net: qlcnic: slight optimization of
addr compare).

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgp45wEIG9gDh.pgp
Description: PGP signature