linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

Hi all,

After merging the scsi-mkp tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/scsi/smartpqi/smartpqi_init.c: In function 
'pqi_build_raid_path_request':
drivers/scsi/smartpqi/smartpqi_init.c:478:14: warning: this statement may fall 
through [-Wimplicit-fallthrough=]
   cdb_length = 0;
   ~~~^~~
drivers/scsi/smartpqi/smartpqi_init.c:479:2: note: here
  case BMIC_IDENTIFY_CONTROLLER:
  ^~~~
drivers/scsi/smartpqi/smartpqi_init.c:487:14: warning: this statement may fall 
through [-Wimplicit-fallthrough=]
   cdb_length = 0;
   ~~~^~~
drivers/scsi/smartpqi/smartpqi_init.c:488:2: note: here
  case BMIC_WRITE_HOST_WELLNESS:
  ^~~~

Introduced by commit

  171c28653a2d ("scsi: smartpqi: turn off lun data caching for ptraid")

This due to my use of -Wimplicit-fallthrough for Kees Cook.  This is
new code.  The warning can be suppressed by adding a comment like

  /* fall through */

just above the following "case" or "default" to indicate that the
fallthrough is intended.

-- 
Cheers,
Stephen Rothwell


pgpK7vxmISiXD.pgp
Description: OpenPGP digital signature

linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

Hi all,

After merging the scsi-mkp tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

./usr/include/scsi/scsi_bsg_ufs.h:45: found __[us]{8,16,32,64} type without 
#include 

Introduced by commits

  a851b2bd3632 ("scsi: uapi: ufs: Make utp_upiu_req visible to user space")
  e77044c5a842 ("scsi: ufs-bsg: Add support for uic commands in 
ufs_bsg_request()")

-- 
Cheers,
Stephen Rothwell


pgpJbxIvcQKDS.pgp
Description: OpenPGP digital signature

linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

Hi all,

After merging the scsi-mkp tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

./usr/include/scsi/scsi_bsg_ufs.h:45: found __[us]{8,16,32,64} type without 
#include 

Introduced by commits

  a851b2bd3632 ("scsi: uapi: ufs: Make utp_upiu_req visible to user space")
  e77044c5a842 ("scsi: ufs-bsg: Add support for uic commands in 
ufs_bsg_request()")

-- 
Cheers,
Stephen Rothwell


pgpJbxIvcQKDS.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the scsi-mkp tree

[Hannes Reinecke]

On 07/12/2018 06:30 AM, Stephen Rothwell wrote:
> Hi all,
> 
> On Wed, 11 Jul 2018 14:17:37 +1000 Stephen Rothwell  
> wrote:
>>
>> After merging the scsi-mkp tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>>
>> In file included from include/linux/spinlock_types.h:18:0,
>>  from include/linux/spinlock.h:82,
>>  from drivers/scsi/libfc/fc_rport.c:61:
>> drivers/scsi/libfc/fc_rport.c: In function 'fc_rport_recv_req':
>> include/linux/lockdep.h:347:45: warning: 'rdata' may be used uninitialized 
>> in this function [-Wmaybe-uninitialized]
>>  #define lockdep_is_held(lock)  lock_is_held(&(lock)->dep_map)
>>  ^
>> drivers/scsi/libfc/fc_rport.c:1832:24: note: 'rdata' was declared here
>>   struct fc_rport_priv *rdata;
>> ^
>>
>> Introduced by commit
>>
>>   ee35624e1e4e ("scsi: libfc: Add lockdep annotations")
>>
>> It is actually complaining about function fc_rport_recv_plogi_req()
>> (presumably it is being inlined) and this looks like an actual bug :-(
> 
> This warning now appears after the merge of the scsi tree.
> 
I have send a new round of patches to the scsi mailing list (cf
'libfc/fcoe: disc_mutex fixes') which address this issue.

Cheers,

Hannes
-- 
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de   +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

Re: linux-next: build warning after merge of the scsi-mkp tree

[Hannes Reinecke]

On 07/12/2018 06:30 AM, Stephen Rothwell wrote:
> Hi all,
> 
> On Wed, 11 Jul 2018 14:17:37 +1000 Stephen Rothwell  
> wrote:
>>
>> After merging the scsi-mkp tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>>
>> In file included from include/linux/spinlock_types.h:18:0,
>>  from include/linux/spinlock.h:82,
>>  from drivers/scsi/libfc/fc_rport.c:61:
>> drivers/scsi/libfc/fc_rport.c: In function 'fc_rport_recv_req':
>> include/linux/lockdep.h:347:45: warning: 'rdata' may be used uninitialized 
>> in this function [-Wmaybe-uninitialized]
>>  #define lockdep_is_held(lock)  lock_is_held(&(lock)->dep_map)
>>  ^
>> drivers/scsi/libfc/fc_rport.c:1832:24: note: 'rdata' was declared here
>>   struct fc_rport_priv *rdata;
>> ^
>>
>> Introduced by commit
>>
>>   ee35624e1e4e ("scsi: libfc: Add lockdep annotations")
>>
>> It is actually complaining about function fc_rport_recv_plogi_req()
>> (presumably it is being inlined) and this looks like an actual bug :-(
> 
> This warning now appears after the merge of the scsi tree.
> 
I have send a new round of patches to the scsi mailing list (cf
'libfc/fcoe: disc_mutex fixes') which address this issue.

Cheers,

Hannes
-- 
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de   +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

Re: linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

Hi all,

On Wed, 11 Jul 2018 14:17:37 +1000 Stephen Rothwell  
wrote:
>
> After merging the scsi-mkp tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> In file included from include/linux/spinlock_types.h:18:0,
>  from include/linux/spinlock.h:82,
>  from drivers/scsi/libfc/fc_rport.c:61:
> drivers/scsi/libfc/fc_rport.c: In function 'fc_rport_recv_req':
> include/linux/lockdep.h:347:45: warning: 'rdata' may be used uninitialized in 
> this function [-Wmaybe-uninitialized]
>  #define lockdep_is_held(lock)  lock_is_held(&(lock)->dep_map)
>  ^
> drivers/scsi/libfc/fc_rport.c:1832:24: note: 'rdata' was declared here
>   struct fc_rport_priv *rdata;
> ^
> 
> Introduced by commit
> 
>   ee35624e1e4e ("scsi: libfc: Add lockdep annotations")
> 
> It is actually complaining about function fc_rport_recv_plogi_req()
> (presumably it is being inlined) and this looks like an actual bug :-(

This warning now appears after the merge of the scsi tree.

-- 
Cheers,
Stephen Rothwell


pgptnJcDfqT_d.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

Hi all,

On Wed, 11 Jul 2018 14:17:37 +1000 Stephen Rothwell  
wrote:
>
> After merging the scsi-mkp tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> In file included from include/linux/spinlock_types.h:18:0,
>  from include/linux/spinlock.h:82,
>  from drivers/scsi/libfc/fc_rport.c:61:
> drivers/scsi/libfc/fc_rport.c: In function 'fc_rport_recv_req':
> include/linux/lockdep.h:347:45: warning: 'rdata' may be used uninitialized in 
> this function [-Wmaybe-uninitialized]
>  #define lockdep_is_held(lock)  lock_is_held(&(lock)->dep_map)
>  ^
> drivers/scsi/libfc/fc_rport.c:1832:24: note: 'rdata' was declared here
>   struct fc_rport_priv *rdata;
> ^
> 
> Introduced by commit
> 
>   ee35624e1e4e ("scsi: libfc: Add lockdep annotations")
> 
> It is actually complaining about function fc_rport_recv_plogi_req()
> (presumably it is being inlined) and this looks like an actual bug :-(

This warning now appears after the merge of the scsi tree.

-- 
Cheers,
Stephen Rothwell


pgptnJcDfqT_d.pgp
Description: OpenPGP digital signature

linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

Hi all,

After merging the scsi-mkp tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from include/linux/spinlock_types.h:18:0,
 from include/linux/spinlock.h:82,
 from drivers/scsi/libfc/fc_rport.c:61:
drivers/scsi/libfc/fc_rport.c: In function 'fc_rport_recv_req':
include/linux/lockdep.h:347:45: warning: 'rdata' may be used uninitialized in 
this function [-Wmaybe-uninitialized]
 #define lockdep_is_held(lock)  lock_is_held(&(lock)->dep_map)
 ^
drivers/scsi/libfc/fc_rport.c:1832:24: note: 'rdata' was declared here
  struct fc_rport_priv *rdata;
^

Introduced by commit

  ee35624e1e4e ("scsi: libfc: Add lockdep annotations")

It is actually complaining about function fc_rport_recv_plogi_req()
(presumably it is being inlined) and this looks like an actual bug :-(



-- 
Cheers,
Stephen Rothwell


pgpWeGktHZXEd.pgp
Description: OpenPGP digital signature

linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

Hi all,

After merging the scsi-mkp tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from include/linux/spinlock_types.h:18:0,
 from include/linux/spinlock.h:82,
 from drivers/scsi/libfc/fc_rport.c:61:
drivers/scsi/libfc/fc_rport.c: In function 'fc_rport_recv_req':
include/linux/lockdep.h:347:45: warning: 'rdata' may be used uninitialized in 
this function [-Wmaybe-uninitialized]
 #define lockdep_is_held(lock)  lock_is_held(&(lock)->dep_map)
 ^
drivers/scsi/libfc/fc_rport.c:1832:24: note: 'rdata' was declared here
  struct fc_rport_priv *rdata;
^

Introduced by commit

  ee35624e1e4e ("scsi: libfc: Add lockdep annotations")

It is actually complaining about function fc_rport_recv_plogi_req()
(presumably it is being inlined) and this looks like an actual bug :-(



-- 
Cheers,
Stephen Rothwell


pgpWeGktHZXEd.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

Hi James,

On Tue, 26 Sep 2017 14:09:47 +1000 Stephen Rothwell  
wrote:
>
> After merging the scsi-mkp tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/scsi/hisi_sas/hisi_sas_main.c: In function 
> 'hisi_sas_controller_reset':
> drivers/scsi/hisi_sas/hisi_sas_main.c:1049:24: warning: unused variable 
> 'sas_ha' [-Wunused-variable]
>   struct sas_ha_struct *sas_ha = _hba->sha;
> ^
> 
> Introduced by commit
> 
>   042ebd293b86 ("scsi: libsas: kill useless ha_event and do some cleanup")

This warning now exists in the scsi tree.
-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

Hi James,

On Tue, 26 Sep 2017 14:09:47 +1000 Stephen Rothwell  
wrote:
>
> After merging the scsi-mkp tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/scsi/hisi_sas/hisi_sas_main.c: In function 
> 'hisi_sas_controller_reset':
> drivers/scsi/hisi_sas/hisi_sas_main.c:1049:24: warning: unused variable 
> 'sas_ha' [-Wunused-variable]
>   struct sas_ha_struct *sas_ha = _hba->sha;
> ^
> 
> Introduced by commit
> 
>   042ebd293b86 ("scsi: libsas: kill useless ha_event and do some cleanup")

This warning now exists in the scsi tree.
-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

Hi Martin,

After merging the scsi-mkp tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/scsi/hisi_sas/hisi_sas_main.c: In function 'hisi_sas_controller_reset':
drivers/scsi/hisi_sas/hisi_sas_main.c:1049:24: warning: unused variable 
'sas_ha' [-Wunused-variable]
  struct sas_ha_struct *sas_ha = _hba->sha;
^

Introduced by commit

  042ebd293b86 ("scsi: libsas: kill useless ha_event and do some cleanup")

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

Hi Martin,

After merging the scsi-mkp tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/scsi/hisi_sas/hisi_sas_main.c: In function 'hisi_sas_controller_reset':
drivers/scsi/hisi_sas/hisi_sas_main.c:1049:24: warning: unused variable 
'sas_ha' [-Wunused-variable]
  struct sas_ha_struct *sas_ha = _hba->sha;
^

Introduced by commit

  042ebd293b86 ("scsi: libsas: kill useless ha_event and do some cleanup")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

Hi all,

[Just adding Dick and James to the cc list]

On Thu, 24 Aug 2017 15:57:56 +1000 Stephen Rothwell  
wrote:
>
> After merging the scsi-mkp tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> drivers/scsi/lpfc/lpfc_nvmet.c:1457:1: warning: 
> 'lpfc_nvmet_replenish_context' defined but not used [-Wunused-function]
>  lpfc_nvmet_replenish_context(struct lpfc_hba *phba,
>  ^
> 
> Introduced by commit
> 
>   9a38e4f1c82f ("scsi: lpfc: Fix MRQ > 1 context list handling")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

Hi all,

[Just adding Dick and James to the cc list]

On Thu, 24 Aug 2017 15:57:56 +1000 Stephen Rothwell  
wrote:
>
> After merging the scsi-mkp tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> drivers/scsi/lpfc/lpfc_nvmet.c:1457:1: warning: 
> 'lpfc_nvmet_replenish_context' defined but not used [-Wunused-function]
>  lpfc_nvmet_replenish_context(struct lpfc_hba *phba,
>  ^
> 
> Introduced by commit
> 
>   9a38e4f1c82f ("scsi: lpfc: Fix MRQ > 1 context list handling")

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

Hi Martin,

After merging the scsi-mkp tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/lpfc/lpfc_nvmet.c:1457:1: warning: 'lpfc_nvmet_replenish_context' 
defined but not used [-Wunused-function]
 lpfc_nvmet_replenish_context(struct lpfc_hba *phba,
 ^

Introduced by commit

  9a38e4f1c82f ("scsi: lpfc: Fix MRQ > 1 context list handling")

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

Hi Martin,

After merging the scsi-mkp tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/lpfc/lpfc_nvmet.c:1457:1: warning: 'lpfc_nvmet_replenish_context' 
defined but not used [-Wunused-function]
 lpfc_nvmet_replenish_context(struct lpfc_hba *phba,
 ^

Introduced by commit

  9a38e4f1c82f ("scsi: lpfc: Fix MRQ > 1 context list handling")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the scsi-mkp tree

[Christoph Hellwig]

On Mon, Nov 14, 2016 at 04:16:24PM +1100, Stephen Rothwell wrote:
> Hi Martin,
> 
> After merging the scsi-mkp tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/scsi/hpsa.c: In function 'hpsa_free_irqs':
> drivers/scsi/hpsa.c:8223:40: warning: 'i' may be used uninitialized in this 
> function [-Wmaybe-uninitialized]
>free_irq(pci_irq_vector(h->pdev, 0), >q[i]);

The i here shold be h->intr_mode, I'll send a fix in a bit.

Re: linux-next: build warning after merge of the scsi-mkp tree

[Christoph Hellwig]

On Mon, Nov 14, 2016 at 04:16:24PM +1100, Stephen Rothwell wrote:
> Hi Martin,
> 
> After merging the scsi-mkp tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/scsi/hpsa.c: In function 'hpsa_free_irqs':
> drivers/scsi/hpsa.c:8223:40: warning: 'i' may be used uninitialized in this 
> function [-Wmaybe-uninitialized]
>free_irq(pci_irq_vector(h->pdev, 0), >q[i]);

The i here shold be h->intr_mode, I'll send a fix in a bit.

linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

Hi Martin,

After merging the scsi-mkp tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/scsi/hpsa.c: In function 'hpsa_free_irqs':
drivers/scsi/hpsa.c:8223:40: warning: 'i' may be used uninitialized in this 
function [-Wmaybe-uninitialized]
   free_irq(pci_irq_vector(h->pdev, 0), >q[i]);
^

Introduced by commit

  bc2bb1543e62 ("scsi: hpsa: use pci_alloc_irq_vectors and automatic irq 
affinity")

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the scsi-mkp tree

[Stephen Rothwell]

Hi Martin,

After merging the scsi-mkp tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/scsi/hpsa.c: In function 'hpsa_free_irqs':
drivers/scsi/hpsa.c:8223:40: warning: 'i' may be used uninitialized in this 
function [-Wmaybe-uninitialized]
   free_irq(pci_irq_vector(h->pdev, 0), >q[i]);
^

Introduced by commit

  bc2bb1543e62 ("scsi: hpsa: use pci_alloc_irq_vectors and automatic irq 
affinity")

-- 
Cheers,
Stephen Rothwell