Re: memory leak in nfs_get_client

2019-07-02 Thread Benjamin Coddington
On 2 Jul 2019, at 12:11, Eric Biggers wrote: On Tue, Jul 02, 2019 at 07:23:32AM -0400, Benjamin Coddington wrote: On 2 Jul 2019, at 2:31, Eric Biggers wrote: On Tue, Jun 11, 2019 at 12:23:12PM -0400, Benjamin Coddington wrote: Ugh.. Now that you can cancel the wait, you have to also handle

Re: memory leak in nfs_get_client

2019-07-02 Thread Eric Biggers
On Tue, Jul 02, 2019 at 07:23:32AM -0400, Benjamin Coddington wrote: > On 2 Jul 2019, at 2:31, Eric Biggers wrote: > > > On Tue, Jun 11, 2019 at 12:23:12PM -0400, Benjamin Coddington wrote: > > > Ugh.. Now that you can cancel the wait, you have to also handle if > > > "new" was > > > allocated.

Re: memory leak in nfs_get_client

2019-07-02 Thread Benjamin Coddington
On 2 Jul 2019, at 2:31, Eric Biggers wrote: On Tue, Jun 11, 2019 at 12:23:12PM -0400, Benjamin Coddington wrote: Ugh.. Now that you can cancel the wait, you have to also handle if "new" was allocated. I think this needs: diff --git a/fs/nfs/client.c b/fs/nfs/client.c index

Re: memory leak in nfs_get_client

2019-07-02 Thread Eric Biggers
On Tue, Jun 11, 2019 at 12:23:12PM -0400, Benjamin Coddington wrote: > Ugh.. Now that you can cancel the wait, you have to also handle if "new" was > allocated. I think this needs: > > diff --git a/fs/nfs/client.c b/fs/nfs/client.c > index d7e4f0848e28..4d90f5bf0b0a 100644 > ---

Re: memory leak in nfs_get_client

2019-06-11 Thread Benjamin Coddington
Ugh.. Now that you can cancel the wait, you have to also handle if "new" was allocated. I think this needs: diff --git a/fs/nfs/client.c b/fs/nfs/client.c index d7e4f0848e28..4d90f5bf0b0a 100644 --- a/fs/nfs/client.c +++ b/fs/nfs/client.c @@ -406,10 +406,10 @@ struct nfs_client

memory leak in nfs_get_client

2019-06-10 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:d1fdb6d8 Linux 5.2-rc4 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=117e0f71a0 kernel config: https://syzkaller.appspot.com/x/.config?x=cb38d33cd06d8d48 dashboard link: