Re: misuse of fget_raw() in perf_event_get()

2019-06-26 Thread Al Viro
On Mon, Apr 15, 2019 at 11:04:06AM +0200, Peter Zijlstra wrote: > On Sun, Apr 14, 2019 at 09:42:00PM -0700, Alexei Starovoitov wrote: > > On Sat, Apr 13, 2019 at 10:02:42PM +0100, Al Viro wrote: > > > What's the point of using fget_raw(), if you do > > > _not_ accept O_PATH descriptors? That

Re: misuse of fget_raw() in perf_event_get()

2019-04-15 Thread Peter Zijlstra
On Sun, Apr 14, 2019 at 09:42:00PM -0700, Alexei Starovoitov wrote: > On Sat, Apr 13, 2019 at 10:02:42PM +0100, Al Viro wrote: > > What's the point of using fget_raw(), if you do > > _not_ accept O_PATH descriptors? That should be fget()... > > I think you're talking about commit

Re: misuse of fget_raw() in perf_event_get()

2019-04-14 Thread Alexei Starovoitov
On Sat, Apr 13, 2019 at 10:02:42PM +0100, Al Viro wrote: > What's the point of using fget_raw(), if you do > _not_ accept O_PATH descriptors? That should be fget()... I think you're talking about commit e03e7ee34fdd ("perf/bpf: Convert perf_event_array to use struct file") I don't really

misuse of fget_raw() in perf_event_get()

2019-04-13 Thread Al Viro
What's the point of using fget_raw(), if you do _not_ accept O_PATH descriptors? That should be fget()...