Re: mmotm 2019-05-29-20-52 uploaded (mpls) +linux-next
On Fri, Jun 7, 2019 at 2:24 AM Matteo Croce wrote: > > On Wed, Jun 5, 2019 at 12:29 AM Randy Dunlap wrote: > > > > On 5/30/19 3:28 PM, Randy Dunlap wrote: > > > On 5/29/19 8:53 PM, a...@linux-foundation.org wrote: > > >> The mm-of-the-moment snapshot 2019-05-29-20-52 has been uploaded to > > >> > > >>http://www.ozlabs.org/~akpm/mmotm/ > > >> > > >> mmotm-readme.txt says > > >> > > >> README for mm-of-the-moment: > > >> > > >> http://www.ozlabs.org/~akpm/mmotm/ > > >> > > >> This is a snapshot of my -mm patch queue. Uploaded at random hopefully > > >> more than once a week. > > >> > > >> You will need quilt to apply these patches to the latest Linus release > > >> (5.x > > >> or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated > > >> in > > >> http://ozlabs.org/~akpm/mmotm/series > > >> > > >> The file broken-out.tar.gz contains two datestamp files: .DATE and > > >> .DATE--mm-dd-hh-mm-ss. Both contain the string -mm-dd-hh-mm-ss, > > >> followed by the base kernel version against which this patch series is to > > >> be applied. > > >> > > > > > > on i386 or x86_64: > > > > > > when CONFIG_PROC_SYSCTL is not set/enabled: > > > > > > ld: net/mpls/af_mpls.o: in function `mpls_platform_labels': > > > af_mpls.c:(.text+0x162a): undefined reference to `sysctl_vals' > > > ld: net/mpls/af_mpls.o:(.rodata+0x830): undefined reference to > > > `sysctl_vals' > > > ld: net/mpls/af_mpls.o:(.rodata+0x838): undefined reference to > > > `sysctl_vals' > > > ld: net/mpls/af_mpls.o:(.rodata+0x870): undefined reference to > > > `sysctl_vals' > > > > > > > Hi, > > This now happens in linux-next 20190604. > > > > > > -- > > ~Randy > > Hi, > I've just sent a patch to fix it. > > It seems that there is a lot of sysctl related code is built > regardless of the CONFIG_SYSCTL value, but produces a build error only > with my patch because I add a reference to sysctl_vals which is in > kernel/sysctl.c. > > And it seems also that the compiler is unable to optimize out the > unused code, which gets somehow in the final binary: > > $ grep PROC_SYSCTL .config > # CONFIG_PROC_SYSCTL is not set > $ readelf vmlinux -x .rodata |grep -A 2 platform_lab > 0x81b09180 2e630070 6c617466 6f726d5f 6c616265 .c.platform_labe > 0x81b09190 6c730069 705f7474 6c5f7072 6f706167 ls.ip_ttl_propag > 0x81b091a0 61746500 64656661 756c745f 74746c00 ate.default_ttl. > > If the purpose of disabling sysctl is to save space, probably this > code and definitions should all go under an #ifdef > > Regards, > -- > Matteo Croce > per aspera ad upstream A proper fix was just merged in davem/net.git commit c1a9d65954c68e13a6adc0225b0d38188fff68ca Author: Matteo Croce Date: Sat Jun 8 14:50:19 2019 +0200 mpls: fix af_mpls dependencies Regards, -- Matteo Croce per aspera ad upstream
Re: mmotm 2019-05-29-20-52 uploaded (mpls) +linux-next
On Wed, Jun 5, 2019 at 12:29 AM Randy Dunlap wrote: > > On 5/30/19 3:28 PM, Randy Dunlap wrote: > > On 5/29/19 8:53 PM, a...@linux-foundation.org wrote: > >> The mm-of-the-moment snapshot 2019-05-29-20-52 has been uploaded to > >> > >>http://www.ozlabs.org/~akpm/mmotm/ > >> > >> mmotm-readme.txt says > >> > >> README for mm-of-the-moment: > >> > >> http://www.ozlabs.org/~akpm/mmotm/ > >> > >> This is a snapshot of my -mm patch queue. Uploaded at random hopefully > >> more than once a week. > >> > >> You will need quilt to apply these patches to the latest Linus release (5.x > >> or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated in > >> http://ozlabs.org/~akpm/mmotm/series > >> > >> The file broken-out.tar.gz contains two datestamp files: .DATE and > >> .DATE--mm-dd-hh-mm-ss. Both contain the string -mm-dd-hh-mm-ss, > >> followed by the base kernel version against which this patch series is to > >> be applied. > >> > > > > on i386 or x86_64: > > > > when CONFIG_PROC_SYSCTL is not set/enabled: > > > > ld: net/mpls/af_mpls.o: in function `mpls_platform_labels': > > af_mpls.c:(.text+0x162a): undefined reference to `sysctl_vals' > > ld: net/mpls/af_mpls.o:(.rodata+0x830): undefined reference to `sysctl_vals' > > ld: net/mpls/af_mpls.o:(.rodata+0x838): undefined reference to `sysctl_vals' > > ld: net/mpls/af_mpls.o:(.rodata+0x870): undefined reference to `sysctl_vals' > > > > Hi, > This now happens in linux-next 20190604. > > > -- > ~Randy Hi, I've just sent a patch to fix it. It seems that there is a lot of sysctl related code is built regardless of the CONFIG_SYSCTL value, but produces a build error only with my patch because I add a reference to sysctl_vals which is in kernel/sysctl.c. And it seems also that the compiler is unable to optimize out the unused code, which gets somehow in the final binary: $ grep PROC_SYSCTL .config # CONFIG_PROC_SYSCTL is not set $ readelf vmlinux -x .rodata |grep -A 2 platform_lab 0x81b09180 2e630070 6c617466 6f726d5f 6c616265 .c.platform_labe 0x81b09190 6c730069 705f7474 6c5f7072 6f706167 ls.ip_ttl_propag 0x81b091a0 61746500 64656661 756c745f 74746c00 ate.default_ttl. If the purpose of disabling sysctl is to save space, probably this code and definitions should all go under an #ifdef Regards, -- Matteo Croce per aspera ad upstream
Re: mmotm 2019-05-29-20-52 uploaded (mpls) +linux-next
On 5/30/19 3:28 PM, Randy Dunlap wrote: > On 5/29/19 8:53 PM, a...@linux-foundation.org wrote: >> The mm-of-the-moment snapshot 2019-05-29-20-52 has been uploaded to >> >>http://www.ozlabs.org/~akpm/mmotm/ >> >> mmotm-readme.txt says >> >> README for mm-of-the-moment: >> >> http://www.ozlabs.org/~akpm/mmotm/ >> >> This is a snapshot of my -mm patch queue. Uploaded at random hopefully >> more than once a week. >> >> You will need quilt to apply these patches to the latest Linus release (5.x >> or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated in >> http://ozlabs.org/~akpm/mmotm/series >> >> The file broken-out.tar.gz contains two datestamp files: .DATE and >> .DATE--mm-dd-hh-mm-ss. Both contain the string -mm-dd-hh-mm-ss, >> followed by the base kernel version against which this patch series is to >> be applied. >> > > on i386 or x86_64: > > when CONFIG_PROC_SYSCTL is not set/enabled: > > ld: net/mpls/af_mpls.o: in function `mpls_platform_labels': > af_mpls.c:(.text+0x162a): undefined reference to `sysctl_vals' > ld: net/mpls/af_mpls.o:(.rodata+0x830): undefined reference to `sysctl_vals' > ld: net/mpls/af_mpls.o:(.rodata+0x838): undefined reference to `sysctl_vals' > ld: net/mpls/af_mpls.o:(.rodata+0x870): undefined reference to `sysctl_vals' > Hi, This now happens in linux-next 20190604. -- ~Randy
Re: mmotm 2019-05-29-20-52 uploaded
Hi all, On Wed, 29 May 2019 21:43:36 -0700 Luigi Semenzato wrote: > > My apologies but the patch > > mm-smaps-split-pss-into-components.patch > > has a bug (does not update private_clean and private_dirty). Please > do not include it. I will resubmit a corrected version. I have dropped that from linux-next today. P.S. in the future please trim your replies to relevant bits, thanks. -- Cheers, Stephen Rothwell pgp5bMJu1WWfW.pgp Description: OpenPGP digital signature
Re: mmotm 2019-05-29-20-52 uploaded
"Huang, Ying" writes: > Hi, Mike, > > Mike Kravetz writes: > >> On 5/29/19 8:53 PM, a...@linux-foundation.org wrote: >>> The mm-of-the-moment snapshot 2019-05-29-20-52 has been uploaded to >>> >>>http://www.ozlabs.org/~akpm/mmotm/ >>> >> >> With this kernel, I seem to get many messages such as: >> >> get_swap_device: Bad swap file entry 1401 >> >> It would seem to be related to commit 3e2c19f9bef7e >>> * mm-swap-fix-race-between-swapoff-and-some-swap-operations.patch > > Hi, Mike, > > Thanks for reporting! I find an issue in my patch and I can reproduce > your problem now. The reason is total_swapcache_pages() will call > get_swap_device() for invalid swap device. So we need to find a way to > silence the warning. I will post a fix ASAP. I have sent out a fix patch in another thread with title "[PATCH -mm] mm, swap: Fix bad swap file entry warning" Can you try it? Best Regards, Huang, Ying
Re: mmotm 2019-05-29-20-52 uploaded
Hi, Mike, Mike Kravetz writes: > On 5/29/19 8:53 PM, a...@linux-foundation.org wrote: >> The mm-of-the-moment snapshot 2019-05-29-20-52 has been uploaded to >> >>http://www.ozlabs.org/~akpm/mmotm/ >> > > With this kernel, I seem to get many messages such as: > > get_swap_device: Bad swap file entry 1401 > > It would seem to be related to commit 3e2c19f9bef7e >> * mm-swap-fix-race-between-swapoff-and-some-swap-operations.patch Hi, Mike, Thanks for reporting! I find an issue in my patch and I can reproduce your problem now. The reason is total_swapcache_pages() will call get_swap_device() for invalid swap device. So we need to find a way to silence the warning. I will post a fix ASAP. Best Regards, Huang, Ying
Re: mmotm 2019-05-29-20-52 uploaded (mpls)
On 5/29/19 8:53 PM, a...@linux-foundation.org wrote: > The mm-of-the-moment snapshot 2019-05-29-20-52 has been uploaded to > >http://www.ozlabs.org/~akpm/mmotm/ > > mmotm-readme.txt says > > README for mm-of-the-moment: > > http://www.ozlabs.org/~akpm/mmotm/ > > This is a snapshot of my -mm patch queue. Uploaded at random hopefully > more than once a week. > > You will need quilt to apply these patches to the latest Linus release (5.x > or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated in > http://ozlabs.org/~akpm/mmotm/series > > The file broken-out.tar.gz contains two datestamp files: .DATE and > .DATE--mm-dd-hh-mm-ss. Both contain the string -mm-dd-hh-mm-ss, > followed by the base kernel version against which this patch series is to > be applied. > on i386 or x86_64: when CONFIG_PROC_SYSCTL is not set/enabled: ld: net/mpls/af_mpls.o: in function `mpls_platform_labels': af_mpls.c:(.text+0x162a): undefined reference to `sysctl_vals' ld: net/mpls/af_mpls.o:(.rodata+0x830): undefined reference to `sysctl_vals' ld: net/mpls/af_mpls.o:(.rodata+0x838): undefined reference to `sysctl_vals' ld: net/mpls/af_mpls.o:(.rodata+0x870): undefined reference to `sysctl_vals' -- ~Randy
Re: mmotm 2019-05-29-20-52 uploaded
On 5/29/19 8:53 PM, a...@linux-foundation.org wrote: > The mm-of-the-moment snapshot 2019-05-29-20-52 has been uploaded to > >http://www.ozlabs.org/~akpm/mmotm/ > With this kernel, I seem to get many messages such as: get_swap_device: Bad swap file entry 1401 It would seem to be related to commit 3e2c19f9bef7e > * mm-swap-fix-race-between-swapoff-and-some-swap-operations.patch -- Mike Kravetz
Re: mmotm 2019-05-29-20-52 uploaded
My apologies but the patch mm-smaps-split-pss-into-components.patch has a bug (does not update private_clean and private_dirty). Please do not include it. I will resubmit a corrected version. Thanks. On Wed, May 29, 2019 at 8:53 PM wrote: > > The mm-of-the-moment snapshot 2019-05-29-20-52 has been uploaded to > >http://www.ozlabs.org/~akpm/mmotm/ > > mmotm-readme.txt says > > README for mm-of-the-moment: > > http://www.ozlabs.org/~akpm/mmotm/ > > This is a snapshot of my -mm patch queue. Uploaded at random hopefully > more than once a week. > > You will need quilt to apply these patches to the latest Linus release (5.x > or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated in > http://ozlabs.org/~akpm/mmotm/series > > The file broken-out.tar.gz contains two datestamp files: .DATE and > .DATE--mm-dd-hh-mm-ss. Both contain the string -mm-dd-hh-mm-ss, > followed by the base kernel version against which this patch series is to > be applied. > > This tree is partially included in linux-next. To see which patches are > included in linux-next, consult the `series' file. Only the patches > within the #NEXT_PATCHES_START/#NEXT_PATCHES_END markers are included in > linux-next. > > > A full copy of the full kernel tree with the linux-next and mmotm patches > already applied is available through git within an hour of the mmotm > release. Individual mmotm releases are tagged. The master branch always > points to the latest release, so it's constantly rebasing. > > http://git.cmpxchg.org/cgit.cgi/linux-mmotm.git/ > > > > The directory http://www.ozlabs.org/~akpm/mmots/ (mm-of-the-second) > contains daily snapshots of the -mm tree. It is updated more frequently > than mmotm, and is untested. > > A git copy of this tree is available at > > http://git.cmpxchg.org/cgit.cgi/linux-mmots.git/ > > and use of this tree is similar to > http://git.cmpxchg.org/cgit.cgi/linux-mmotm.git/, described above. > > > This mmotm tree contains the following patches against 5.2-rc2: > (patches marked "*" will be included in linux-next) > > origin.patch > * mm-fix-documentation-vm-hmmrst-sphinx-warnings.patch > * lib-sortc-fix-kernel-doc-notation-warnings.patch > * mm-vmallocc-fix-typo-in-comment.patch > * mm-slab-remove-obsoleted-config_debug_slab_leak.patch > * > arch-arm-boot-compressed-decompressc-fix-build-error-due-to-lz4-changes.patch > * mm-mmu_gather-remove-__tlb_reset_range-for-force-flush.patch > * > mm-mmu_gather-remove-__tlb_reset_range-for-force-flush-checkpatch-fixes.patch > * kernel-fork-make-max_threads-symbol-static.patch > * prctl_set_mm-refactor-checks-from-validate_prctl_map.patch > * prctl_set_mm-refactor-checks-from-validate_prctl_map-checkpatch-fixes.patch > * prctl_set_mm-downgrade-mmap_sem-to-read-lock.patch > * prctl_set_mm-downgrade-mmap_sem-to-read-lock-checkpatch-fixes.patch > * mm-consider-subtrees-in-memoryevents.patch > * memcg-make-it-work-on-sparse-non-0-node-systems.patch > * ocfs2-fix-error-path-kobject-memory-leak.patch > * mm-gup-continue-vm_fault_retry-processing-event-for-pre-faults.patch > * scripts-gdb-fix-invocation-when-config_common_clk-is-not-set.patch > * z3fold-fix-sheduling-while-atomic.patch > * kasan-initialize-tag-to-0xff-in-__kasan_kmalloc.patch > * spdxcheckpy-fix-directory-structures-v3.patch > * iommu-intel-fix-variable-iommu-set-but-not-used.patch > * signal-trace_signal_deliver-when-signal_group_exit.patch > * generic-radix-trees-fix-kerneldoc-comment.patch > * mm-compaction-make-sure-we-isolate-a-valid-pfn.patch > * convert-struct-pid-count-to-refcount_t.patch > * > mm-dev_pfn-exclude-memory_device_private-while-computing-virtual-address.patch > * fs-proc-allow-reporting-eip-esp-for-all-coredumping-threads.patch > * mm-mempolicy-fix-an-incorrect-rebind-node-in-mpol_rebind_nodemask.patch > * binfmt_flat-make-load_flat_shared_library-work.patch > * mm-fix-trying-to-reclaim-unevicable-lru-page.patch > * mm-memcontrol-dont-batch-updates-of-local-vm-stats-and-events.patch > * list_lru-fix-memory-leak-in-__memcg_init_list_lru_node.patch > * userfaultfd-selftest-fix-compiler-warning.patch > * scripts-decode_stacktracesh-prefix-addr2line-with-cross_compile.patch > * mm-mlockall-error-for-flag-mcl_onfault.patch > * mm-fix-recent_rotated-history.patch > * fs-ocfs2-fix-race-in-ocfs2_dentry_attach_lock.patch > * > scripts-decode_stacktrace-match-basepath-using-shell-prefix-operator-not-regex.patch > * scripts-decode_stacktrace-look-for-modules-with-kodebug-extension.patch > * scripts-decode_stacktrace-look-for-modules-with-kodebug-extension-v2.patch > * scripts-spellingtxt-drop-sepc-from-the-misspelling-list.patch > * scripts-spellingtxt-drop-sepc-from-the-misspelling-list-fix.patch > * scripts-spellingtxt-add-spelling-fix-for-prohibited.patch > * debugobjects-move-printk-out-of-db-lock-critical-sections.patch > * ocfs2-add-last-unlock-times-in-locking_state.patch > * ocfs2-add-locking-filter-debugfs-file.patch > *
mmotm 2019-05-29-20-52 uploaded
The mm-of-the-moment snapshot 2019-05-29-20-52 has been uploaded to http://www.ozlabs.org/~akpm/mmotm/ mmotm-readme.txt says README for mm-of-the-moment: http://www.ozlabs.org/~akpm/mmotm/ This is a snapshot of my -mm patch queue. Uploaded at random hopefully more than once a week. You will need quilt to apply these patches to the latest Linus release (5.x or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated in http://ozlabs.org/~akpm/mmotm/series The file broken-out.tar.gz contains two datestamp files: .DATE and .DATE--mm-dd-hh-mm-ss. Both contain the string -mm-dd-hh-mm-ss, followed by the base kernel version against which this patch series is to be applied. This tree is partially included in linux-next. To see which patches are included in linux-next, consult the `series' file. Only the patches within the #NEXT_PATCHES_START/#NEXT_PATCHES_END markers are included in linux-next. A full copy of the full kernel tree with the linux-next and mmotm patches already applied is available through git within an hour of the mmotm release. Individual mmotm releases are tagged. The master branch always points to the latest release, so it's constantly rebasing. http://git.cmpxchg.org/cgit.cgi/linux-mmotm.git/ The directory http://www.ozlabs.org/~akpm/mmots/ (mm-of-the-second) contains daily snapshots of the -mm tree. It is updated more frequently than mmotm, and is untested. A git copy of this tree is available at http://git.cmpxchg.org/cgit.cgi/linux-mmots.git/ and use of this tree is similar to http://git.cmpxchg.org/cgit.cgi/linux-mmotm.git/, described above. This mmotm tree contains the following patches against 5.2-rc2: (patches marked "*" will be included in linux-next) origin.patch * mm-fix-documentation-vm-hmmrst-sphinx-warnings.patch * lib-sortc-fix-kernel-doc-notation-warnings.patch * mm-vmallocc-fix-typo-in-comment.patch * mm-slab-remove-obsoleted-config_debug_slab_leak.patch * arch-arm-boot-compressed-decompressc-fix-build-error-due-to-lz4-changes.patch * mm-mmu_gather-remove-__tlb_reset_range-for-force-flush.patch * mm-mmu_gather-remove-__tlb_reset_range-for-force-flush-checkpatch-fixes.patch * kernel-fork-make-max_threads-symbol-static.patch * prctl_set_mm-refactor-checks-from-validate_prctl_map.patch * prctl_set_mm-refactor-checks-from-validate_prctl_map-checkpatch-fixes.patch * prctl_set_mm-downgrade-mmap_sem-to-read-lock.patch * prctl_set_mm-downgrade-mmap_sem-to-read-lock-checkpatch-fixes.patch * mm-consider-subtrees-in-memoryevents.patch * memcg-make-it-work-on-sparse-non-0-node-systems.patch * ocfs2-fix-error-path-kobject-memory-leak.patch * mm-gup-continue-vm_fault_retry-processing-event-for-pre-faults.patch * scripts-gdb-fix-invocation-when-config_common_clk-is-not-set.patch * z3fold-fix-sheduling-while-atomic.patch * kasan-initialize-tag-to-0xff-in-__kasan_kmalloc.patch * spdxcheckpy-fix-directory-structures-v3.patch * iommu-intel-fix-variable-iommu-set-but-not-used.patch * signal-trace_signal_deliver-when-signal_group_exit.patch * generic-radix-trees-fix-kerneldoc-comment.patch * mm-compaction-make-sure-we-isolate-a-valid-pfn.patch * convert-struct-pid-count-to-refcount_t.patch * mm-dev_pfn-exclude-memory_device_private-while-computing-virtual-address.patch * fs-proc-allow-reporting-eip-esp-for-all-coredumping-threads.patch * mm-mempolicy-fix-an-incorrect-rebind-node-in-mpol_rebind_nodemask.patch * binfmt_flat-make-load_flat_shared_library-work.patch * mm-fix-trying-to-reclaim-unevicable-lru-page.patch * mm-memcontrol-dont-batch-updates-of-local-vm-stats-and-events.patch * list_lru-fix-memory-leak-in-__memcg_init_list_lru_node.patch * userfaultfd-selftest-fix-compiler-warning.patch * scripts-decode_stacktracesh-prefix-addr2line-with-cross_compile.patch * mm-mlockall-error-for-flag-mcl_onfault.patch * mm-fix-recent_rotated-history.patch * fs-ocfs2-fix-race-in-ocfs2_dentry_attach_lock.patch * scripts-decode_stacktrace-match-basepath-using-shell-prefix-operator-not-regex.patch * scripts-decode_stacktrace-look-for-modules-with-kodebug-extension.patch * scripts-decode_stacktrace-look-for-modules-with-kodebug-extension-v2.patch * scripts-spellingtxt-drop-sepc-from-the-misspelling-list.patch * scripts-spellingtxt-drop-sepc-from-the-misspelling-list-fix.patch * scripts-spellingtxt-add-spelling-fix-for-prohibited.patch * debugobjects-move-printk-out-of-db-lock-critical-sections.patch * ocfs2-add-last-unlock-times-in-locking_state.patch * ocfs2-add-locking-filter-debugfs-file.patch * fs-ocfs-fix-spelling-mistake-hearbeating-heartbeat.patch * ocfs2-clear-zero-in-unaligned-direct-io.patch * ocfs2-clear-zero-in-unaligned-direct-io-checkpatch-fixes.patch * ocfs2-wait-for-recovering-done-after-direct-unlock-request.patch * ocfs2-checkpoint-appending-truncate-log-transaction-before-flushing.patch * ramfs-support-o_tmpfile.patch mm.patch * mm-slub-avoid-double-string-traverse-in-kmem_cache_flags.patch *
