[PATCH 4.19 06/41] mtd: nand: Fix memory allocation in nanddev_bbt_init()
4.19-stable review patch. If anyone has any objections, please let me know.
--
From: Frieder Schrempf
commit 40b412897ccb4b98b2cfb2a0aaabed58dd9e2086 upstream.
Fix the size of the buffer allocated to store the in-memory BBT.
This bug was previously hidden by a different bug, that was fixed in
commit d098093ba06e ("mtd: nand: Fix nanddev_neraseblocks()").
Fixes: 9c3736a3de21 ("mtd: nand: Add core infrastructure to deal with NAND
devices")
Cc:
Signed-off-by: Frieder Schrempf
Acked-by: Miquel Raynal
Signed-off-by: Boris Brezillon
Signed-off-by: Greg Kroah-Hartman
---
drivers/mtd/nand/bbt.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/mtd/nand/bbt.c
+++ b/drivers/mtd/nand/bbt.c
@@ -27,7 +27,8 @@ int nanddev_bbt_init(struct nand_device
unsigned int nwords = DIV_ROUND_UP(nblocks * bits_per_block,
BITS_PER_LONG);
- nand->bbt.cache = kzalloc(nwords, GFP_KERNEL);
+ nand->bbt.cache = kcalloc(nwords, sizeof(*nand->bbt.cache),
+ GFP_KERNEL);
if (!nand->bbt.cache)
return -ENOMEM;
Re: mtd: nand: Fix memory allocation in nanddev_bbt_init()
On Tue, 2018-11-27 at 07:44:52 UTC, Schrempf Frieder wrote:
> Fix the size of the buffer allocated to store the in-memory BBT.
> This bug was previously hidden by a different bug, that was fixed in
> d098093ba06e.
>
> Fixes: 9c3736a3de21 ("mtd: nand: Add core infrastructure to deal with NAND
> devices")
> Cc:
> Signed-off-by: Frieder Schrempf
> Acked-by: Miquel Raynal
Applied to http://git.infradead.org/linux-mtd.git master, thanks.
Boris
Re: [PATCH] mtd: nand: Fix memory allocation in nanddev_bbt_init()
On 28.11.18 16:28, Boris Brezillon wrote:
> On Wed, 28 Nov 2018 15:19:37 +
> Schrempf Frieder wrote:
>
>> On 28.11.18 16:02, Boris Brezillon wrote:
>>> On Wed, 28 Nov 2018 14:55:45 +
>>> Schrempf Frieder wrote:
>>>
Hi Boris,
On 28.11.18 15:41, Boris Brezillon wrote:
> On Tue, 27 Nov 2018 07:44:52 +
> Schrempf Frieder wrote:
>
>> Fix the size of the buffer allocated to store the in-memory BBT.
>> This bug was previously hidden by a different bug, that was fixed in
>> d098093ba06e.
>>
>> Fixes: 9c3736a3de21 ("mtd: nand: Add core infrastructure to deal with
>> NAND devices")
>> Cc:
>> Signed-off-by: Frieder Schrempf
>
> Looks like your From header does not match the SoB tag
> ('Frieder Schrempf' vs 'Schrempf Frieder') and checkpatch does not like
> that. I'll fix it when applying, but maybe you should fix
> your .gitconfig to make them match.
Actually the From header in my local patch is correct (
, Frieder Schrempf) as it comes from my git config. But since
our company was renamed and our mail servers were transferred, our
e-mails are sent with From= .
It seems like git send-email or patchwork or whatever uses the
information from the e-mail header instead of what is in the patch.
I will try to raise this issue with our IT department as this would be
best fixed on their side.
>>>
>>> There's another solution: make git send-email add a From header in the
>>> message body.
>>>
>>> git config --global sendemail.from "Schrempf Frieder
>>> "
>>
>> I don't get it. How would that change things? My From still wouldn't
>> match my SoB tags.
>
> When there's a From line in the message Body, git am will use this one
> instead of the one in the header section.
Ok, now I got it. I didn't know that git send-email adds the From tag in
the body if sendemail.from differs from the author, but that makes sense
indeed.
I just checked and with my old mail setup, the SMTP server was
respecting my sender address from the client (send-email, thunderbird).
The new setup uses DavMail Gateway to send via the companies Exchange
server and it just ignores my sender from the client and sends with the
reversed name as stored in the Exchange server.
I don't like sending mail with reversed names (people start calling me
by my last name), but using a different SMTP server would likely cause
trouble with some recipients using SPF for spam detection.
So I guess I have to convince our IT to change the names, if even
possible...
Oh, why do such small things always cause so much trouble?
Re: [PATCH] mtd: nand: Fix memory allocation in nanddev_bbt_init()
On Wed, 28 Nov 2018 15:19:37 +
Schrempf Frieder wrote:
> On 28.11.18 16:02, Boris Brezillon wrote:
> > On Wed, 28 Nov 2018 14:55:45 +
> > Schrempf Frieder wrote:
> >
> >> Hi Boris,
> >>
> >> On 28.11.18 15:41, Boris Brezillon wrote:
> >>> On Tue, 27 Nov 2018 07:44:52 +
> >>> Schrempf Frieder wrote:
> >>>
> Fix the size of the buffer allocated to store the in-memory BBT.
> This bug was previously hidden by a different bug, that was fixed in
> d098093ba06e.
>
> Fixes: 9c3736a3de21 ("mtd: nand: Add core infrastructure to deal with
> NAND devices")
> Cc:
> Signed-off-by: Frieder Schrempf
> >>>
> >>> Looks like your From header does not match the SoB tag
> >>> ('Frieder Schrempf' vs 'Schrempf Frieder') and checkpatch does not like
> >>> that. I'll fix it when applying, but maybe you should fix
> >>> your .gitconfig to make them match.
> >>
> >> Actually the From header in my local patch is correct (
> >> , Frieder Schrempf) as it comes from my git config. But since
> >> our company was renamed and our mail servers were transferred, our
> >> e-mails are sent with From= .
> >>
> >> It seems like git send-email or patchwork or whatever uses the
> >> information from the e-mail header instead of what is in the patch.
> >>
> >> I will try to raise this issue with our IT department as this would be
> >> best fixed on their side.
> >
> > There's another solution: make git send-email add a From header in the
> > message body.
> >
> > git config --global sendemail.from "Schrempf Frieder
> > "
>
> I don't get it. How would that change things? My From still wouldn't
> match my SoB tags.
When there's a From line in the message Body, git am will use this one
instead of the one in the header section.
Re: [PATCH] mtd: nand: Fix memory allocation in nanddev_bbt_init()
On 28.11.18 16:02, Boris Brezillon wrote:
> On Wed, 28 Nov 2018 14:55:45 +
> Schrempf Frieder wrote:
>
>> Hi Boris,
>>
>> On 28.11.18 15:41, Boris Brezillon wrote:
>>> On Tue, 27 Nov 2018 07:44:52 +
>>> Schrempf Frieder wrote:
>>>
Fix the size of the buffer allocated to store the in-memory BBT.
This bug was previously hidden by a different bug, that was fixed in
d098093ba06e.
Fixes: 9c3736a3de21 ("mtd: nand: Add core infrastructure to deal with NAND
devices")
Cc:
Signed-off-by: Frieder Schrempf
>>>
>>> Looks like your From header does not match the SoB tag
>>> ('Frieder Schrempf' vs 'Schrempf Frieder') and checkpatch does not like
>>> that. I'll fix it when applying, but maybe you should fix
>>> your .gitconfig to make them match.
>>
>> Actually the From header in my local patch is correct (
>> , Frieder Schrempf) as it comes from my git config. But since
>> our company was renamed and our mail servers were transferred, our
>> e-mails are sent with From= .
>>
>> It seems like git send-email or patchwork or whatever uses the
>> information from the e-mail header instead of what is in the patch.
>>
>> I will try to raise this issue with our IT department as this would be
>> best fixed on their side.
>
> There's another solution: make git send-email add a From header in the
> message body.
>
> git config --global sendemail.from "Schrempf Frieder
> "
I don't get it. How would that change things? My From still wouldn't
match my SoB tags.
Re: [PATCH] mtd: nand: Fix memory allocation in nanddev_bbt_init()
On Wed, 28 Nov 2018 14:55:45 +
Schrempf Frieder wrote:
> Hi Boris,
>
> On 28.11.18 15:41, Boris Brezillon wrote:
> > On Tue, 27 Nov 2018 07:44:52 +
> > Schrempf Frieder wrote:
> >
> >> Fix the size of the buffer allocated to store the in-memory BBT.
> >> This bug was previously hidden by a different bug, that was fixed in
> >> d098093ba06e.
> >>
> >> Fixes: 9c3736a3de21 ("mtd: nand: Add core infrastructure to deal with NAND
> >> devices")
> >> Cc:
> >> Signed-off-by: Frieder Schrempf
> >
> > Looks like your From header does not match the SoB tag
> > ('Frieder Schrempf' vs 'Schrempf Frieder') and checkpatch does not like
> > that. I'll fix it when applying, but maybe you should fix
> > your .gitconfig to make them match.
>
> Actually the From header in my local patch is correct (
> , Frieder Schrempf) as it comes from my git config. But since
> our company was renamed and our mail servers were transferred, our
> e-mails are sent with From= .
>
> It seems like git send-email or patchwork or whatever uses the
> information from the e-mail header instead of what is in the patch.
>
> I will try to raise this issue with our IT department as this would be
> best fixed on their side.
There's another solution: make git send-email add a From header in the
message body.
git config --global sendemail.from "Schrempf Frieder
"
Re: [PATCH] mtd: nand: Fix memory allocation in nanddev_bbt_init()
Hi Boris,
On 28.11.18 15:41, Boris Brezillon wrote:
> On Tue, 27 Nov 2018 07:44:52 +
> Schrempf Frieder wrote:
>
>> Fix the size of the buffer allocated to store the in-memory BBT.
>> This bug was previously hidden by a different bug, that was fixed in
>> d098093ba06e.
>>
>> Fixes: 9c3736a3de21 ("mtd: nand: Add core infrastructure to deal with NAND
>> devices")
>> Cc:
>> Signed-off-by: Frieder Schrempf
>
> Looks like your From header does not match the SoB tag
> ('Frieder Schrempf' vs 'Schrempf Frieder') and checkpatch does not like
> that. I'll fix it when applying, but maybe you should fix
> your .gitconfig to make them match.
Actually the From header in my local patch is correct (
, Frieder Schrempf) as it comes from my git config. But since
our company was renamed and our mail servers were transferred, our
e-mails are sent with From= .
It seems like git send-email or patchwork or whatever uses the
information from the e-mail header instead of what is in the patch.
I will try to raise this issue with our IT department as this would be
best fixed on their side.
Thanks,
Frieder
>
>> ---
>> drivers/mtd/nand/bbt.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/nand/bbt.c b/drivers/mtd/nand/bbt.c
>> index 56cde38..c12497f 100644
>> --- a/drivers/mtd/nand/bbt.c
>> +++ b/drivers/mtd/nand/bbt.c
>> @@ -27,7 +27,8 @@ int nanddev_bbt_init(struct nand_device *nand)
>> unsigned int nwords = DIV_ROUND_UP(nblocks * bits_per_block,
>> BITS_PER_LONG);
>>
>> -nand->bbt.cache = kzalloc(nwords, GFP_KERNEL);
>> +nand->bbt.cache = kzalloc(nwords * (BITS_PER_LONG / BITS_PER_BYTE),
>> + GFP_KERNEL);
>> if (!nand->bbt.cache)
>> return -ENOMEM;
>>
>
Re: [PATCH] mtd: nand: Fix memory allocation in nanddev_bbt_init()
On Tue, 27 Nov 2018 07:44:52 +
Schrempf Frieder wrote:
> Fix the size of the buffer allocated to store the in-memory BBT.
> This bug was previously hidden by a different bug, that was fixed in
> d098093ba06e.
>
> Fixes: 9c3736a3de21 ("mtd: nand: Add core infrastructure to deal with NAND
> devices")
> Cc:
> Signed-off-by: Frieder Schrempf
Looks like your From header does not match the SoB tag
('Frieder Schrempf' vs 'Schrempf Frieder') and checkpatch does not like
that. I'll fix it when applying, but maybe you should fix
your .gitconfig to make them match.
> ---
> drivers/mtd/nand/bbt.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/bbt.c b/drivers/mtd/nand/bbt.c
> index 56cde38..c12497f 100644
> --- a/drivers/mtd/nand/bbt.c
> +++ b/drivers/mtd/nand/bbt.c
> @@ -27,7 +27,8 @@ int nanddev_bbt_init(struct nand_device *nand)
> unsigned int nwords = DIV_ROUND_UP(nblocks * bits_per_block,
> BITS_PER_LONG);
>
> - nand->bbt.cache = kzalloc(nwords, GFP_KERNEL);
> + nand->bbt.cache = kzalloc(nwords * (BITS_PER_LONG / BITS_PER_BYTE),
> + GFP_KERNEL);
> if (!nand->bbt.cache)
> return -ENOMEM;
>
Re: [PATCH] mtd: nand: Fix memory allocation in nanddev_bbt_init()
Hello,
Schrempf Frieder wrote on Tue, 27 Nov
2018 08:30:24 +:
> On 27.11.18 09:22, Boris Brezillon wrote:
> > On Tue, 27 Nov 2018 07:44:52 +
> > Schrempf Frieder wrote:
> >
> >> Fix the size of the buffer allocated to store the in-memory BBT.
> >> This bug was previously hidden by a different bug, that was fixed in
> >> d098093ba06e.
> >
> > Oops :-/.
> >
> >>
> >> Fixes: 9c3736a3de21 ("mtd: nand: Add core infrastructure to deal with NAND
> >> devices")
> >> Cc:
> >> Signed-off-by: Frieder Schrempf
> >> ---
> >> drivers/mtd/nand/bbt.c | 3 ++-
> >> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/mtd/nand/bbt.c b/drivers/mtd/nand/bbt.c
> >> index 56cde38..c12497f 100644
> >> --- a/drivers/mtd/nand/bbt.c
> >> +++ b/drivers/mtd/nand/bbt.c
> >> @@ -27,7 +27,8 @@ int nanddev_bbt_init(struct nand_device *nand)
> >>unsigned int nwords = DIV_ROUND_UP(nblocks * bits_per_block,
> >> BITS_PER_LONG);
> >>
> >> - nand->bbt.cache = kzalloc(nwords, GFP_KERNEL);
> >> + nand->bbt.cache = kzalloc(nwords * (BITS_PER_LONG / BITS_PER_BYTE),
> >
> > I prefer
> >
> > * sizeof(*nand->bbt.cache)
> > If you're okay with this change, I'll fix it when applying (no need to
> > send a new version).
>
> Sure, that's ok.
I also prefer with the sizeof() operator. Thanks for fixing this!
Acked-by: Miquel Raynal
Thanks,
Miquèl
Re: [PATCH] mtd: nand: Fix memory allocation in nanddev_bbt_init()
On 27.11.18 09:22, Boris Brezillon wrote:
> On Tue, 27 Nov 2018 07:44:52 +
> Schrempf Frieder wrote:
>
>> Fix the size of the buffer allocated to store the in-memory BBT.
>> This bug was previously hidden by a different bug, that was fixed in
>> d098093ba06e.
>
> Oops :-/.
>
>>
>> Fixes: 9c3736a3de21 ("mtd: nand: Add core infrastructure to deal with NAND
>> devices")
>> Cc:
>> Signed-off-by: Frieder Schrempf
>> ---
>> drivers/mtd/nand/bbt.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/nand/bbt.c b/drivers/mtd/nand/bbt.c
>> index 56cde38..c12497f 100644
>> --- a/drivers/mtd/nand/bbt.c
>> +++ b/drivers/mtd/nand/bbt.c
>> @@ -27,7 +27,8 @@ int nanddev_bbt_init(struct nand_device *nand)
>> unsigned int nwords = DIV_ROUND_UP(nblocks * bits_per_block,
>> BITS_PER_LONG);
>>
>> -nand->bbt.cache = kzalloc(nwords, GFP_KERNEL);
>> +nand->bbt.cache = kzalloc(nwords * (BITS_PER_LONG / BITS_PER_BYTE),
>
> I prefer
>
>* sizeof(*nand->bbt.cache)
> If you're okay with this change, I'll fix it when applying (no need to
> send a new version).
Sure, that's ok.
Re: [PATCH] mtd: nand: Fix memory allocation in nanddev_bbt_init()
On Tue, 27 Nov 2018 07:44:52 +
Schrempf Frieder wrote:
> Fix the size of the buffer allocated to store the in-memory BBT.
> This bug was previously hidden by a different bug, that was fixed in
> d098093ba06e.
Oops :-/.
>
> Fixes: 9c3736a3de21 ("mtd: nand: Add core infrastructure to deal with NAND
> devices")
> Cc:
> Signed-off-by: Frieder Schrempf
> ---
> drivers/mtd/nand/bbt.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/bbt.c b/drivers/mtd/nand/bbt.c
> index 56cde38..c12497f 100644
> --- a/drivers/mtd/nand/bbt.c
> +++ b/drivers/mtd/nand/bbt.c
> @@ -27,7 +27,8 @@ int nanddev_bbt_init(struct nand_device *nand)
> unsigned int nwords = DIV_ROUND_UP(nblocks * bits_per_block,
> BITS_PER_LONG);
>
> - nand->bbt.cache = kzalloc(nwords, GFP_KERNEL);
> + nand->bbt.cache = kzalloc(nwords * (BITS_PER_LONG / BITS_PER_BYTE),
I prefer
* sizeof(*nand->bbt.cache)
If you're okay with this change, I'll fix it when applying (no need to
send a new version).
Thanks,
Boris
> + GFP_KERNEL);
> if (!nand->bbt.cache)
> return -ENOMEM;
>
[PATCH] mtd: nand: Fix memory allocation in nanddev_bbt_init()
Fix the size of the buffer allocated to store the in-memory BBT.
This bug was previously hidden by a different bug, that was fixed in
d098093ba06e.
Fixes: 9c3736a3de21 ("mtd: nand: Add core infrastructure to deal with NAND
devices")
Cc:
Signed-off-by: Frieder Schrempf
---
drivers/mtd/nand/bbt.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/bbt.c b/drivers/mtd/nand/bbt.c
index 56cde38..c12497f 100644
--- a/drivers/mtd/nand/bbt.c
+++ b/drivers/mtd/nand/bbt.c
@@ -27,7 +27,8 @@ int nanddev_bbt_init(struct nand_device *nand)
unsigned int nwords = DIV_ROUND_UP(nblocks * bits_per_block,
BITS_PER_LONG);
- nand->bbt.cache = kzalloc(nwords, GFP_KERNEL);
+ nand->bbt.cache = kzalloc(nwords * (BITS_PER_LONG / BITS_PER_BYTE),
+ GFP_KERNEL);
if (!nand->bbt.cache)
return -ENOMEM;
--
2.7.4
