Re: net: xfrm: Deletion of an unnecessary check before the function call "ipcomp_free_tfms"

2014-11-19 Thread David Miller
From: Dan Carpenter Date: Wed, 19 Nov 2014 13:10:03 +0300 > I have come to view you as a very clever troll. +1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: net: xfrm: Deletion of an unnecessary check before the function call "ipcomp_free_tfms"

2014-11-19 Thread Dan Carpenter
I have come to view you as a very clever troll. You will say infuriating things like "That is an interesting background information but the function implementation update suggestion is correct" and pretend to not see the bug for nine emails. Then you'll say something "Ha ha, I audited all the

Re: net: xfrm: Deletion of an unnecessary check before the function call "ipcomp_free_tfms"

2014-11-19 Thread Julia Lawall
On Wed, 19 Nov 2014, SF Markus Elfring wrote: > >> The ipcomp_free_tfms() function tests whether its argument is NULL and then > >> returns immediately. Thus the test around the call is not needed. > > > > It doesn't though... > > You are right that this function implementation does a bit more

Re: net: xfrm: Deletion of an unnecessary check before the function call "ipcomp_free_tfms"

2014-11-19 Thread SF Markus Elfring
>> The ipcomp_free_tfms() function tests whether its argument is NULL and then >> returns immediately. Thus the test around the call is not needed. > > It doesn't though... You are right that this function implementation does a bit more before returning because of a detected null pointer.

Re: [PATCH 1/1] net: xfrm: Deletion of an unnecessary check before the function call "ipcomp_free_tfms"

2014-11-19 Thread Dan Carpenter
On Tue, Nov 18, 2014 at 09:45:41PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 18 Nov 2014 21:41:26 +0100 > > The ipcomp_free_tfms() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > It doesn't

Re: [PATCH 1/1] net: xfrm: Deletion of an unnecessary check before the function call ipcomp_free_tfms

2014-11-19 Thread Dan Carpenter
On Tue, Nov 18, 2014 at 09:45:41PM +0100, SF Markus Elfring wrote: From: Markus Elfring elfr...@users.sourceforge.net Date: Tue, 18 Nov 2014 21:41:26 +0100 The ipcomp_free_tfms() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not

Re: net: xfrm: Deletion of an unnecessary check before the function call ipcomp_free_tfms

2014-11-19 Thread SF Markus Elfring
The ipcomp_free_tfms() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. It doesn't though... You are right that this function implementation does a bit more before returning because of a detected null pointer.

Re: net: xfrm: Deletion of an unnecessary check before the function call ipcomp_free_tfms

2014-11-19 Thread Julia Lawall
On Wed, 19 Nov 2014, SF Markus Elfring wrote: The ipcomp_free_tfms() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. It doesn't though... You are right that this function implementation does a bit more before

Re: net: xfrm: Deletion of an unnecessary check before the function call ipcomp_free_tfms

2014-11-19 Thread Dan Carpenter
I have come to view you as a very clever troll. You will say infuriating things like That is an interesting background information but the function implementation update suggestion is correct and pretend to not see the bug for nine emails. Then you'll say something Ha ha, I audited all the call

Re: net: xfrm: Deletion of an unnecessary check before the function call ipcomp_free_tfms

2014-11-19 Thread David Miller
From: Dan Carpenter dan.carpen...@oracle.com Date: Wed, 19 Nov 2014 13:10:03 +0300 I have come to view you as a very clever troll. +1 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH 1/1] net: xfrm: Deletion of an unnecessary check before the function call "ipcomp_free_tfms"

2014-11-18 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 18 Nov 2014 21:41:26 +0100 The ipcomp_free_tfms() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/1] net: xfrm: Deletion of an unnecessary check before the function call ipcomp_free_tfms

2014-11-18 Thread SF Markus Elfring
From: Markus Elfring elfr...@users.sourceforge.net Date: Tue, 18 Nov 2014 21:41:26 +0100 The ipcomp_free_tfms() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software.