Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
On Tue, 26 Feb 2008 19:16:11 +0100 Pavel Machek <[EMAIL PROTECTED]> wrote: > On Tue 2008-02-26 13:10:01, Dave Jones wrote: > > On Tue, Feb 26, 2008 at 06:59:54PM +0100, Pavel Machek wrote: > > > > > > if by 'custom' you mean the solution everyone agreed to work > > > > toward at the power management summit several years ago > > > > (hal/pm-utils) then, yes. > > > > > > I must have been on different summit... I believe it is bad to tie > > > s2ram to hal, because it makes testing on minimal system hard. > > > > > > Anyway, what is the "default" way to trigger s2ram for Andrew? Perhaps > > > Fedora already has his machine whitelisted... > > > > There is no s2ram. pm-suspend uses the white/black-lists in pm-utils. > > Remember that? The cross-distro package everyone agreed was a good idea > > so that every distro didn't have their own magic utility ? > > Well, we have cross-distro package, it is at suspend.sf.net , and it > can bring up video - which is kind of important. (It is single binary, > so it can be pagelocked -- which is important for s2disk). > > Plus it does not depend on HAL. Meanwhile, my computer continues to not work. First thing we need to do is to work out why it won't stay suspended? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
On Tue, Feb 26, 2008 at 07:16:11PM +0100, Pavel Machek wrote: > On Tue 2008-02-26 13:10:01, Dave Jones wrote: > > On Tue, Feb 26, 2008 at 06:59:54PM +0100, Pavel Machek wrote: > > > > > > if by 'custom' you mean the solution everyone agreed to work > > > > toward at the power management summit several years ago > > > > (hal/pm-utils) then, yes. > > > > > > I must have been on different summit... I believe it is bad to tie > > > s2ram to hal, because it makes testing on minimal system hard. > > > > > > Anyway, what is the "default" way to trigger s2ram for Andrew? Perhaps > > > Fedora already has his machine whitelisted... > > > > There is no s2ram. pm-suspend uses the white/black-lists in pm-utils. > > Remember that? The cross-distro package everyone agreed was a good idea > > so that every distro didn't have their own magic utility ? > > Well, we have cross-distro package, it is at suspend.sf.net , and it > can bring up video - which is kind of important. (It is single binary, > so it can be pagelocked -- which is important for s2disk). > > Plus it does not depend on HAL. Neither does pm-utils. Once again for the hard of thinking.. The mechanism belongs in pm-utils. HAL is just a fancy wrapper around that. Don't want/like hal? fine, a smaller wrapper around pm-suspend and friends is trivial (or even unnecessary if you're happy with running pm-suspend by hand) Dave -- http://www.codemonkey.org.uk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
On Tue 2008-02-26 13:10:01, Dave Jones wrote: > On Tue, Feb 26, 2008 at 06:59:54PM +0100, Pavel Machek wrote: > > > > if by 'custom' you mean the solution everyone agreed to work > > > toward at the power management summit several years ago > > > (hal/pm-utils) then, yes. > > > > I must have been on different summit... I believe it is bad to tie > > s2ram to hal, because it makes testing on minimal system hard. > > > > Anyway, what is the "default" way to trigger s2ram for Andrew? Perhaps > > Fedora already has his machine whitelisted... > > There is no s2ram. pm-suspend uses the white/black-lists in pm-utils. > Remember that? The cross-distro package everyone agreed was a good idea > so that every distro didn't have their own magic utility ? Well, we have cross-distro package, it is at suspend.sf.net , and it can bring up video - which is kind of important. (It is single binary, so it can be pagelocked -- which is important for s2disk). Plus it does not depend on HAL. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
On Tue, Feb 26, 2008 at 06:59:54PM +0100, Pavel Machek wrote: > > if by 'custom' you mean the solution everyone agreed to work > > toward at the power management summit several years ago > > (hal/pm-utils) then, yes. > > I must have been on different summit... I believe it is bad to tie > s2ram to hal, because it makes testing on minimal system hard. > > Anyway, what is the "default" way to trigger s2ram for Andrew? Perhaps > Fedora already has his machine whitelisted... There is no s2ram. pm-suspend uses the white/black-lists in pm-utils. Remember that? The cross-distro package everyone agreed was a good idea so that every distro didn't have their own magic utility ? sigh, I give up. Dave -- http://www.codemonkey.org.uk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
On Tue 2008-02-26 12:46:13, Dave Jones wrote: > On Tue, Feb 26, 2008 at 11:11:17AM +0100, Pavel Machek wrote: > > Hi! > > > > Andrew is trying to get s2ram to work on Fedora: > > > > > > > Please try s2ram, there's good chance it will just work. > > > > > > > > configure: error: Required libx86 was not found > > > > > > apt-get install libx86-dev? > > > > > > Alternatively, can you post dmidecode? Thinkpads usually work with > > > acpi_sleep=s3_bios,s3_mode ; and I can look up whitelist manually. > > > > ...unfortunately, it does not ship s2ram by default, and does not even > > carry its dependencies. > > > > Is there some custom mechanism to get suspend-to-ram to work on > > Fedora? > > if by 'custom' you mean the solution everyone agreed to work > toward at the power management summit several years ago > (hal/pm-utils) then, yes. I must have been on different summit... I believe it is bad to tie s2ram to hal, because it makes testing on minimal system hard. Anyway, what is the "default" way to trigger s2ram for Andrew? Perhaps Fedora already has his machine whitelisted... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
On Tue, Feb 26, 2008 at 11:11:17AM +0100, Pavel Machek wrote: > Hi! > > Andrew is trying to get s2ram to work on Fedora: > > > > > Please try s2ram, there's good chance it will just work. > > > > > > configure: error: Required libx86 was not found > > > > apt-get install libx86-dev? > > > > Alternatively, can you post dmidecode? Thinkpads usually work with > > acpi_sleep=s3_bios,s3_mode ; and I can look up whitelist manually. > > ...unfortunately, it does not ship s2ram by default, and does not even > carry its dependencies. > > Is there some custom mechanism to get suspend-to-ram to work on > Fedora? if by 'custom' you mean the solution everyone agreed to work toward at the power management summit several years ago (hal/pm-utils) then, yes. Dave -- http://www.codemonkey.org.uk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
Hi! Andrew is trying to get s2ram to work on Fedora: > > > Please try s2ram, there's good chance it will just work. > > > > configure: error: Required libx86 was not found > > apt-get install libx86-dev? > > Alternatively, can you post dmidecode? Thinkpads usually work with > acpi_sleep=s3_bios,s3_mode ; and I can look up whitelist manually. ...unfortunately, it does not ship s2ram by default, and does not even carry its dependencies. Is there some custom mechanism to get suspend-to-ram to work on Fedora? If not, would it be possible to start shipping s2ram from suspend.sf.net? (Unlike s2disk, this will not eat filesystems, I promise :-). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p
On Mon, Feb 25, 2008 at 11:46:11 -0800, Andrew Morton wrote: > On Mon, 25 Feb 2008 21:19:24 +0200 "Michael S. Tsirkin" <[EMAIL PROTECTED]> > wrote: > > > On my T61p, 2.6.25-rc2 seems to get acpi events from keypresses > > such as Fn-F4 and lid open/close, prints them in /var/log/acpid > > and reacts accordingly (my acpi scripts suspend on lid close and Fn-F4). > > You mean suspend-to-ram works correctly on your t61p? > > Mine suspends, then five seconds later magically resumes itself and the > screen is all black. I also have a T61p, on which STR works. I haven't tried 2.6.25, but it works with 2.6.24. Both using the suspend scripts included in Ubuntu 7.10, and with s2ram 0.8 (although I need to use --acpi_sleep 2 (s3_mode) as an option, instead of 1 (s3_bios), which is used by default on my model). But I'm using the NVidia module, so that most likely changes a lot of things. I'll see if I can find time tonight to test 2.6.25-rc3 + nv, and report back. -- Kind regards Klaus S. Madsen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p
On Mon, Feb 25, 2008 at 11:46:11 -0800, Andrew Morton wrote: On Mon, 25 Feb 2008 21:19:24 +0200 Michael S. Tsirkin [EMAIL PROTECTED] wrote: On my T61p, 2.6.25-rc2 seems to get acpi events from keypresses such as Fn-F4 and lid open/close, prints them in /var/log/acpid and reacts accordingly (my acpi scripts suspend on lid close and Fn-F4). You mean suspend-to-ram works correctly on your t61p? Mine suspends, then five seconds later magically resumes itself and the screen is all black. I also have a T61p, on which STR works. I haven't tried 2.6.25, but it works with 2.6.24. Both using the suspend scripts included in Ubuntu 7.10, and with s2ram 0.8 (although I need to use --acpi_sleep 2 (s3_mode) as an option, instead of 1 (s3_bios), which is used by default on my model). But I'm using the NVidia module, so that most likely changes a lot of things. I'll see if I can find time tonight to test 2.6.25-rc3 + nv, and report back. -- Kind regards Klaus S. Madsen -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
Hi! Andrew is trying to get s2ram to work on Fedora: Please try s2ram, there's good chance it will just work. configure: error: Required libx86 was not found apt-get install libx86-dev? Alternatively, can you post dmidecode? Thinkpads usually work with acpi_sleep=s3_bios,s3_mode ; and I can look up whitelist manually. ...unfortunately, it does not ship s2ram by default, and does not even carry its dependencies. Is there some custom mechanism to get suspend-to-ram to work on Fedora? If not, would it be possible to start shipping s2ram from suspend.sf.net? (Unlike s2disk, this will not eat filesystems, I promise :-). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
On Tue, Feb 26, 2008 at 11:11:17AM +0100, Pavel Machek wrote: Hi! Andrew is trying to get s2ram to work on Fedora: Please try s2ram, there's good chance it will just work. configure: error: Required libx86 was not found apt-get install libx86-dev? Alternatively, can you post dmidecode? Thinkpads usually work with acpi_sleep=s3_bios,s3_mode ; and I can look up whitelist manually. ...unfortunately, it does not ship s2ram by default, and does not even carry its dependencies. Is there some custom mechanism to get suspend-to-ram to work on Fedora? if by 'custom' you mean the solution everyone agreed to work toward at the power management summit several years ago (hal/pm-utils) then, yes. Dave -- http://www.codemonkey.org.uk -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
On Tue 2008-02-26 12:46:13, Dave Jones wrote: On Tue, Feb 26, 2008 at 11:11:17AM +0100, Pavel Machek wrote: Hi! Andrew is trying to get s2ram to work on Fedora: Please try s2ram, there's good chance it will just work. configure: error: Required libx86 was not found apt-get install libx86-dev? Alternatively, can you post dmidecode? Thinkpads usually work with acpi_sleep=s3_bios,s3_mode ; and I can look up whitelist manually. ...unfortunately, it does not ship s2ram by default, and does not even carry its dependencies. Is there some custom mechanism to get suspend-to-ram to work on Fedora? if by 'custom' you mean the solution everyone agreed to work toward at the power management summit several years ago (hal/pm-utils) then, yes. I must have been on different summit... I believe it is bad to tie s2ram to hal, because it makes testing on minimal system hard. Anyway, what is the default way to trigger s2ram for Andrew? Perhaps Fedora already has his machine whitelisted... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
On Tue 2008-02-26 13:10:01, Dave Jones wrote: On Tue, Feb 26, 2008 at 06:59:54PM +0100, Pavel Machek wrote: if by 'custom' you mean the solution everyone agreed to work toward at the power management summit several years ago (hal/pm-utils) then, yes. I must have been on different summit... I believe it is bad to tie s2ram to hal, because it makes testing on minimal system hard. Anyway, what is the default way to trigger s2ram for Andrew? Perhaps Fedora already has his machine whitelisted... There is no s2ram. pm-suspend uses the white/black-lists in pm-utils. Remember that? The cross-distro package everyone agreed was a good idea so that every distro didn't have their own magic utility ? Well, we have cross-distro package, it is at suspend.sf.net , and it can bring up video - which is kind of important. (It is single binary, so it can be pagelocked -- which is important for s2disk). Plus it does not depend on HAL. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
On Tue, Feb 26, 2008 at 06:59:54PM +0100, Pavel Machek wrote: if by 'custom' you mean the solution everyone agreed to work toward at the power management summit several years ago (hal/pm-utils) then, yes. I must have been on different summit... I believe it is bad to tie s2ram to hal, because it makes testing on minimal system hard. Anyway, what is the default way to trigger s2ram for Andrew? Perhaps Fedora already has his machine whitelisted... There is no s2ram. pm-suspend uses the white/black-lists in pm-utils. Remember that? The cross-distro package everyone agreed was a good idea so that every distro didn't have their own magic utility ? sigh, I give up. Dave -- http://www.codemonkey.org.uk -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
On Tue, Feb 26, 2008 at 07:16:11PM +0100, Pavel Machek wrote: On Tue 2008-02-26 13:10:01, Dave Jones wrote: On Tue, Feb 26, 2008 at 06:59:54PM +0100, Pavel Machek wrote: if by 'custom' you mean the solution everyone agreed to work toward at the power management summit several years ago (hal/pm-utils) then, yes. I must have been on different summit... I believe it is bad to tie s2ram to hal, because it makes testing on minimal system hard. Anyway, what is the default way to trigger s2ram for Andrew? Perhaps Fedora already has his machine whitelisted... There is no s2ram. pm-suspend uses the white/black-lists in pm-utils. Remember that? The cross-distro package everyone agreed was a good idea so that every distro didn't have their own magic utility ? Well, we have cross-distro package, it is at suspend.sf.net , and it can bring up video - which is kind of important. (It is single binary, so it can be pagelocked -- which is important for s2disk). Plus it does not depend on HAL. Neither does pm-utils. Once again for the hard of thinking.. The mechanism belongs in pm-utils. HAL is just a fancy wrapper around that. Don't want/like hal? fine, a smaller wrapper around pm-suspend and friends is trivial (or even unnecessary if you're happy with running pm-suspend by hand) Dave -- http://www.codemonkey.org.uk -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
On Tue, 26 Feb 2008 19:16:11 +0100 Pavel Machek [EMAIL PROTECTED] wrote: On Tue 2008-02-26 13:10:01, Dave Jones wrote: On Tue, Feb 26, 2008 at 06:59:54PM +0100, Pavel Machek wrote: if by 'custom' you mean the solution everyone agreed to work toward at the power management summit several years ago (hal/pm-utils) then, yes. I must have been on different summit... I believe it is bad to tie s2ram to hal, because it makes testing on minimal system hard. Anyway, what is the default way to trigger s2ram for Andrew? Perhaps Fedora already has his machine whitelisted... There is no s2ram. pm-suspend uses the white/black-lists in pm-utils. Remember that? The cross-distro package everyone agreed was a good idea so that every distro didn't have their own magic utility ? Well, we have cross-distro package, it is at suspend.sf.net , and it can bring up video - which is kind of important. (It is single binary, so it can be pagelocked -- which is important for s2disk). Plus it does not depend on HAL. Meanwhile, my computer continues to not work. First thing we need to do is to work out why it won't stay suspended? -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p - resume hang
On Tue, Feb 26, 2008 at 4:45 AM, Michael S. Tsirkin
<[EMAIL PROTECTED]> wrote:
On Mon, Feb 25, 2008 at 9:46 PM, Andrew Morton
<[EMAIL PROTECTED]> wrote:
> On Mon, 25 Feb 2008 21:19:24 +0200 "Michael S. Tsirkin"
<[EMAIL PROTECTED]> wrote:
> You mean suspend-to-ram works correctly on your t61p?
> Mine suspends, then five seconds later magically resumes itself and
the
> screen is all black.
Sorry, have not noticed what you were asking about.
Yes, rc2 seems to suspend/resume fine.
And after reverting
revert commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2.
commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2
Author: Pavel Machek <[EMAIL PROTECTED]>
Date: Thu Feb 21 13:56:55 2008 +0100
power_state: get rid of write-only variable in SATA
power_state is scheduled for removal, and libata uses it in write-only
mode. Remove it.
Signed-off-by: Pavel Machek <[EMAIL PROTECTED]>
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
I'm experiencing hang after resume from STR with the latest Linus's git
tree. Reverting the above patch solved the problem.
Thanks,
Jeff
Here's the patch for reference ...
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 4cf8662..9812bbf 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -6560,8 +6560,6 @@ int ata_host_suspend(struct ata_host *host, pm_message_t
mesg)
ata_lpm_enable(host);
rc = ata_host_request_pm(host, mesg, 0, ATA_EHI_QUIET, 1);
- if (rc == 0)
- host->dev->power.power_state = mesg;
return rc;
}
@@ -6580,7 +6578,6 @@ void ata_host_resume(struct ata_host *host)
{
ata_host_request_pm(host, PMSG_ON, ATA_EH_SOFTRESET,
ATA_EHI_NO_AUTOPSY | ATA_EHI_QUIET, 0);
- host->dev->power.power_state = PMSG_ON;
/* reenable link pm */
ata_lpm_disable(host);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p
On Tue, Feb 26, 2008 at 12:33 AM, Alexey Starikovskiy <[EMAIL PROTECTED]> wrote: > > Attached is the acpidump output run under 2.6.23-rc3 + with reverted > > 37f9b4c7c612fcbeb8fb6faddaef4ccdb5350145 > > (IOW - this is a working configuration). > Thanks, you've got round 10100 bug number. > > Please check if the following patch on top of Linus git tree helps. > > Regards, > Alex I did some light testing, but yes, this seems to help. With this patch applied on top of 2.6.25-rc3, I get keyboard acpi events again, so that I can suspend by clicking Fn+F4. -- MST -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
On Tue, Feb 26, 2008 at 12:53 AM, Andrew Morton <[EMAIL PROTECTED]> wrote: > > On Tue, 26 Feb 2008 00:48:12 +0200 "Michael S. Tsirkin" <[EMAIL PROTECTED]> > wrote: > > > On Tue, Feb 26, 2008 at 12:39 AM, Andrew Morton > > <[EMAIL PROTECTED]> wrote: > > > On Tue, 26 Feb 2008 00:36:54 +0200 "Michael S. Tsirkin" <[EMAIL > PROTECTED]> wrote: > > > > > > > > Hmm, mystery partly solved... as you guessed it, this piece of code > > > > > was not in my tree. > > > > > > > > > > (still, how can this cause autoresume after 5 seconds is a mystery > to > > > > > me). > > > > > > > > > > > > > > > > Pavel > > > > > > > > Maybe it doesn't. Andrew saw the autoresume on -rc[2,3] > > > > > > And earlier - I think 2.6.23 does it as well. > > > > But that one at least resumes fine, does it not? > > Nope, the resume-after-five-seconds and black-screen-after-resume have > always been there (I've only had the thing a few months). > > I thought the restoring of the screen after resume is handled by the X > server? I'm using the nv.o driver. Perhaps nvidia's driver handles it > right, dunno. > > Oh, I have the ATI thingy. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
Hi! > > > > Maybe it doesn't. Andrew saw the autoresume on -rc[2,3] > > > > > > And earlier - I think 2.6.23 does it as well. > > > > But that one at least resumes fine, does it not? > > Nope, the resume-after-five-seconds and black-screen-after-resume have > always been there (I've only had the thing a few months). > > I thought the restoring of the screen after resume is handled by the X > server? I'm using the nv.o driver. Perhaps nvidia's driver handles it > right, dunno. Aha, so you do not have s2ram from suspend.sf.net installed, do you? Restoring the screen is done by either a) kernel/bios (acpi_sleep=..., or better s2ram -f -a X ) b) vbetool c) X . s2ram should detect your machine, and automatically set acpi_sleep and/or perform vbetool magic. Please try s2ram, there's good chance it will just work. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
On Tue, 26 Feb 2008 00:48:12 +0200 "Michael S. Tsirkin" <[EMAIL PROTECTED]> wrote: > On Tue, Feb 26, 2008 at 12:39 AM, Andrew Morton > <[EMAIL PROTECTED]> wrote: > > On Tue, 26 Feb 2008 00:36:54 +0200 "Michael S. Tsirkin" <[EMAIL PROTECTED]> > > wrote: > > > > > > Hmm, mystery partly solved... as you guessed it, this piece of code > > > > was not in my tree. > > > > > > > > (still, how can this cause autoresume after 5 seconds is a mystery to > > > > me). > > > > > > > > > > > > Pavel > > > > > > Maybe it doesn't. Andrew saw the autoresume on -rc[2,3] > > > > And earlier - I think 2.6.23 does it as well. > > But that one at least resumes fine, does it not? Nope, the resume-after-five-seconds and black-screen-after-resume have always been there (I've only had the thing a few months). I thought the restoring of the screen after resume is handled by the X server? I'm using the nv.o driver. Perhaps nvidia's driver handles it right, dunno. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
On Tue, Feb 26, 2008 at 12:39 AM, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Tue, 26 Feb 2008 00:36:54 +0200 "Michael S. Tsirkin" <[EMAIL PROTECTED]> > wrote: > > > > Hmm, mystery partly solved... as you guessed it, this piece of code > > > was not in my tree. > > > > > > (still, how can this cause autoresume after 5 seconds is a mystery to > > > me). > > > > > > > > > Pavel > > > > Maybe it doesn't. Andrew saw the autoresume on -rc[2,3] > > And earlier - I think 2.6.23 does it as well. But that one at least resumes fine, does it not? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
On Tue, 26 Feb 2008 00:36:54 +0200 "Michael S. Tsirkin" <[EMAIL PROTECTED]> wrote: > > Hmm, mystery partly solved... as you guessed it, this piece of code > > was not in my tree. > > > > (still, how can this cause autoresume after 5 seconds is a mystery to > > me). > > > > > > Pavel > > Maybe it doesn't. Andrew saw the autoresume on -rc[2,3] And earlier - I think 2.6.23 does it as well. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
On Tue, Feb 26, 2008 at 12:20 AM, Pavel Machek <[EMAIL PROTECTED]> wrote:
>
> Hi!
>
> > > > > > commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2
> > > > > > Author: Pavel Machek <[EMAIL PROTECTED]>
> > > > > > Date: Thu Feb 21 13:56:55 2008 +0100
> > > > > >
> > > > > > power_state: get rid of write-only variable in SATA
> > > > >
> > > > > This is pretty unlikely to be it. Can you double check that this
> patch
> > > > > really breaks something?
> > > >
> > > > I did and it seems to: just reverting
> > > > 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 fixes resume for me.
> > > > 635adc28087ced0c843d2ecb6d4ae474d0e611cd which is
> > > > 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2~1
> > > > also resumes fine.
> > >
> > > Hmm, I guess that should teach me about "simple cleanups".
> > >
> > > Do you use any of:
> > >
> > > ata/sata_inic162x.c
> > > ata/sata_nv.c
> > > ata/sata_sil24.c
> > >
> > > by chance?
> >
> > I don't think so.
> > Here are the only 3 ata modules I have built:
> > drivers/ata/ahci.ko
> > drivers/ata/ata_piix.ko
> > drivers/ata/libata.ko
> >
> >
> > ahci.c seems to look at power_state.
> >
> > static int ahci_pci_device_resume(struct pci_dev *pdev)
> > {
> > struct ata_host *host = dev_get_drvdata(>dev);
> > int rc;
> >
> > rc = ata_pci_device_do_resume(pdev);
> > if (rc)
> > return rc;
> >
> > if (pdev->dev.power.power_state.event == PM_EVENT_SUSPEND) {
> > rc = ahci_reset_controller(host);
> > if (rc)
> > return rc;
> >
> > ahci_init_controller(host);
> > }
>
> > Right?
>
> Hmm, mystery partly solved... as you guessed it, this piece of code
> was not in my tree.
>
> (still, how can this cause autoresume after 5 seconds is a mystery to
> me).
>
>
> Pavel
Maybe it doesn't. Andrew saw the autoresume on -rc[2,3], I didn't.
For me, it causes resume to fail.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p
Michael S. Tsirkin wrote:
On Mon, Feb 25, 2008 at 10:50 PM, Alexey Starikovskiy
<[EMAIL PROTECTED]> wrote:
Michael S. Tsirkin wrote:
> Did you guys stop accepting reports by mail?
> I hope not.
It is easier to track bug information in bugzilla.
If you for some reason do not wish to create a bug report,
I can do it for you. You only need to provide acpidump.
Great.
>> and attach acpidump?
>
> I'll see if I can get acpidump output - in which state do you want it?
> Right after boot on the broken kernel?
acpidump output does not change over time, you could get it even with some
other kernel.
Attached is the acpidump output run under 2.6.23-rc3 + with reverted
37f9b4c7c612fcbeb8fb6faddaef4ccdb5350145
(IOW - this is a working configuration).
Thanks, you've got round 10100 bug number.
Please check if the following patch on top of Linus git tree helps.
Regards,
Alex
HTH,
MST
ACPI: EC: fix regression
From: Alexey Starikovskiy <[EMAIL PROTECTED]>
---
drivers/acpi/ec.c | 18 +++---
1 files changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index caf873c..d6f9956 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -129,7 +129,8 @@ static struct acpi_ec {
struct mutex lock;
wait_queue_head_t wait;
struct list_head list;
- u8 handlers_installed;
+ u8 handlers_installed:1;
+ u8 from_ecdt:1;
} *boot_ec, *first_ec;
/* --
@@ -772,16 +773,18 @@ static int acpi_ec_add(struct acpi_device *device)
/* Check for boot EC */
if (boot_ec) {
- if (boot_ec->handle == device->handle) {
- /* Pre-loaded EC from DSDT, just move pointer */
- ec = boot_ec;
- boot_ec = NULL;
- goto end;
- } else if (boot_ec->handle == ACPI_ROOT_OBJECT) {
+ if (boot_ec->from_ecdt &&
+ (boot_ec->handle == device->handle ||
+ boot_ec->handle == ACPI_ROOT_OBJECT)) {
/* ECDT-based EC, time to shut it down */
ec_remove_handlers(boot_ec);
kfree(boot_ec);
first_ec = boot_ec = NULL;
+ } else if (boot_ec->handle == device->handle) {
+ /* Pre-loaded EC from DSDT, just move pointer */
+ ec = boot_ec;
+ boot_ec = NULL;
+ goto end;
}
}
@@ -943,6 +946,7 @@ int __init acpi_ec_ecdt_probe(void)
boot_ec->command_addr = ecdt_ptr->control.address;
boot_ec->data_addr = ecdt_ptr->data.address;
boot_ec->gpe = ecdt_ptr->gpe;
+ boot_ec->from_ecdt = 1;
if (ACPI_FAILURE(acpi_get_handle(NULL, ecdt_ptr->id,
_ec->handle))) {
pr_info("Failed to locate handle for boot EC\n");
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
On Mon 2008-02-25 16:32:38, Jeff Garzik wrote: > Pavel Machek wrote: >>> commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 >>> Author: Pavel Machek <[EMAIL PROTECTED]> >>> Date: Thu Feb 21 13:56:55 2008 +0100 >>> >>> power_state: get rid of write-only variable in SATA >> >> This is pretty unlikely to be it. Can you double check that this patch >> really breaks something? > > Quote... > > After reverting 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 > on top of 2.6.25-rc3 the kernel again resumes from suspend to > ram. > > Seems pretty clear to me. Yep, that patch was crappy. I developed it on machine with SCSI powersave patches applied, and did not realize this code changed. Sorry. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
Hi!
> > > > > commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2
> > > > > Author: Pavel Machek <[EMAIL PROTECTED]>
> > > > > Date: Thu Feb 21 13:56:55 2008 +0100
> > > > >
> > > > > power_state: get rid of write-only variable in SATA
> > > >
> > > > This is pretty unlikely to be it. Can you double check that this patch
> > > > really breaks something?
> > >
> > > I did and it seems to: just reverting
> > > 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 fixes resume for me.
> > > 635adc28087ced0c843d2ecb6d4ae474d0e611cd which is
> > > 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2~1
> > > also resumes fine.
> >
> > Hmm, I guess that should teach me about "simple cleanups".
> >
> > Do you use any of:
> >
> > ata/sata_inic162x.c
> > ata/sata_nv.c
> > ata/sata_sil24.c
> >
> > by chance?
>
> I don't think so.
> Here are the only 3 ata modules I have built:
> drivers/ata/ahci.ko
> drivers/ata/ata_piix.ko
> drivers/ata/libata.ko
>
>
> ahci.c seems to look at power_state.
>
> static int ahci_pci_device_resume(struct pci_dev *pdev)
> {
> struct ata_host *host = dev_get_drvdata(>dev);
> int rc;
>
> rc = ata_pci_device_do_resume(pdev);
> if (rc)
> return rc;
>
> if (pdev->dev.power.power_state.event == PM_EVENT_SUSPEND) {
> rc = ahci_reset_controller(host);
> if (rc)
> return rc;
>
> ahci_init_controller(host);
> }
> Right?
Hmm, mystery partly solved... as you guessed it, this piece of code
was not in my tree.
(still, how can this cause autoresume after 5 seconds is a mystery to
me).
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
On Mon, Feb 25, 2008 at 11:50 PM, Pavel Machek <[EMAIL PROTECTED]> wrote:
> Hi!
>
>
> > > > commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2
> > > > Author: Pavel Machek <[EMAIL PROTECTED]>
> > > > Date: Thu Feb 21 13:56:55 2008 +0100
> > > >
> > > > power_state: get rid of write-only variable in SATA
> > >
> > > This is pretty unlikely to be it. Can you double check that this patch
> > > really breaks something?
> >
> > I did and it seems to: just reverting
> > 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 fixes resume for me.
> > 635adc28087ced0c843d2ecb6d4ae474d0e611cd which is
> > 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2~1
> > also resumes fine.
>
> Hmm, I guess that should teach me about "simple cleanups".
>
> Do you use any of:
>
> ata/sata_inic162x.c
> ata/sata_nv.c
> ata/sata_sil24.c
>
> by chance?
I don't think so.
Here are the only 3 ata modules I have built:
drivers/ata/ahci.ko
drivers/ata/ata_piix.ko
drivers/ata/libata.ko
ahci.c seems to look at power_state.
static int ahci_pci_device_resume(struct pci_dev *pdev)
{
struct ata_host *host = dev_get_drvdata(>dev);
int rc;
rc = ata_pci_device_do_resume(pdev);
if (rc)
return rc;
if (pdev->dev.power.power_state.event == PM_EVENT_SUSPEND) {
rc = ahci_reset_controller(host);
if (rc)
return rc;
ahci_init_controller(host);
}
ata_host_resume(host);
return 0;
}
Right?
> (Ok, the patch is very safe to revert, it was "cleanup", it fixes
> nothing).
>
>
> Pavel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
Hi! > > > commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 > > > Author: Pavel Machek <[EMAIL PROTECTED]> > > > Date: Thu Feb 21 13:56:55 2008 +0100 > > > > > > power_state: get rid of write-only variable in SATA > > > > This is pretty unlikely to be it. Can you double check that this patch > > really breaks something? > > I did and it seems to: just reverting > 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 fixes resume for me. > 635adc28087ced0c843d2ecb6d4ae474d0e611cd which is > 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2~1 > also resumes fine. Hmm, I guess that should teach me about "simple cleanups". Do you use any of: ata/sata_inic162x.c ata/sata_nv.c ata/sata_sil24.c by chance? (Ok, the patch is very safe to revert, it was "cleanup", it fixes nothing). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
Pavel Machek wrote: commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 Author: Pavel Machek <[EMAIL PROTECTED]> Date: Thu Feb 21 13:56:55 2008 +0100 power_state: get rid of write-only variable in SATA This is pretty unlikely to be it. Can you double check that this patch really breaks something? Quote... After reverting 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 on top of 2.6.25-rc3 the kernel again resumes from suspend to ram. Seems pretty clear to me. Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
On Mon, Feb 25, 2008 at 11:26 PM, Pavel Machek <[EMAIL PROTECTED]> wrote: > Hi! > > > > On Monday, 25 of February 2008, Michael S. Tsirkin wrote: > > > On Mon, Feb 25, 2008 at 9:46 PM, Andrew Morton > > > <[EMAIL PROTECTED]> wrote: > > > > On Mon, 25 Feb 2008 21:19:24 +0200 "Michael S. Tsirkin" <[EMAIL > PROTECTED]> wrote: > > > > > > > > > On my T61p, 2.6.25-rc2 seems to get acpi events from keypresses > > > > > such as Fn-F4 and lid open/close, prints them in /var/log/acpid > > > > > and reacts accordingly (my acpi scripts suspend on lid close and > Fn-F4). > > > > > > > > You mean suspend-to-ram works correctly on your t61p? > > > > > > > > Mine suspends, then five seconds later magically resumes itself and > the > > > > screen is all black. > > > > > > Sorry, have not noticed what you were asking about. > > > Yes, rc2 seems to suspend/resume fine. > > > > > > And after reverting > > > > > > revert commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2. > > > > commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 > > Author: Pavel Machek <[EMAIL PROTECTED]> > > Date: Thu Feb 21 13:56:55 2008 +0100 > > > > power_state: get rid of write-only variable in SATA > > This is pretty unlikely to be it. Can you double check that this patch > really breaks something? I did and it seems to: just reverting 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 fixes resume for me. 635adc28087ced0c843d2ecb6d4ae474d0e611cd which is 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2~1 also resumes fine. > > > > revert commit 208c70a45624400fafd7511b96bc426bf01f8f5e. > > > > commit 208c70a45624400fafd7511b96bc426bf01f8f5e > > Author: Alexey Starikovskiy <[EMAIL PROTECTED]> > > Date: Thu Feb 14 15:58:47 2008 -0500 > > > > ACPI: EC: Use proper handle for boot EC > > > > > r3 does, too. > > > > Please, _please_ always add commit subjects to your reports. Also, please > > include the names of the authors of the commits that turn out to break > things > > and send CCs to them. > > > > It won't hurt to send CCs to the people who signed those commits off, too. > > Hmm, as EC is the piece of hw that does the wakeups, yes, EC might be > responsible for autowaking. > Pavel As far as I can tell, nope, reverting 208c70a45624400fafd7511b96bc426bf01f8f5e fixes acpi keyboard/lid events but does fix resume from suspend to ram for me. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
Hi! > On Monday, 25 of February 2008, Michael S. Tsirkin wrote: > > On Mon, Feb 25, 2008 at 9:46 PM, Andrew Morton > > <[EMAIL PROTECTED]> wrote: > > > On Mon, 25 Feb 2008 21:19:24 +0200 "Michael S. Tsirkin" <[EMAIL > > > PROTECTED]> wrote: > > > > > > > On my T61p, 2.6.25-rc2 seems to get acpi events from keypresses > > > > such as Fn-F4 and lid open/close, prints them in /var/log/acpid > > > > and reacts accordingly (my acpi scripts suspend on lid close and > > > Fn-F4). > > > > > > You mean suspend-to-ram works correctly on your t61p? > > > > > > Mine suspends, then five seconds later magically resumes itself and the > > > screen is all black. > > > > Sorry, have not noticed what you were asking about. > > Yes, rc2 seems to suspend/resume fine. > > > > And after reverting > > > > revert commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2. > > commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 > Author: Pavel Machek <[EMAIL PROTECTED]> > Date: Thu Feb 21 13:56:55 2008 +0100 > > power_state: get rid of write-only variable in SATA This is pretty unlikely to be it. Can you double check that this patch really breaks something? > > revert commit 208c70a45624400fafd7511b96bc426bf01f8f5e. > > commit 208c70a45624400fafd7511b96bc426bf01f8f5e > Author: Alexey Starikovskiy <[EMAIL PROTECTED]> > Date: Thu Feb 14 15:58:47 2008 -0500 > > ACPI: EC: Use proper handle for boot EC > > > r3 does, too. > > Please, _please_ always add commit subjects to your reports. Also, please > include the names of the authors of the commits that turn out to break things > and send CCs to them. > > It won't hurt to send CCs to the people who signed those commits off, too. Hmm, as EC is the piece of hw that does the wakeups, yes, EC might be responsible for autowaking. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
On Monday, 25 of February 2008, Michael S. Tsirkin wrote: > On Mon, Feb 25, 2008 at 9:46 PM, Andrew Morton > <[EMAIL PROTECTED]> wrote: > > On Mon, 25 Feb 2008 21:19:24 +0200 "Michael S. Tsirkin" <[EMAIL PROTECTED]> > > wrote: > > > > > On my T61p, 2.6.25-rc2 seems to get acpi events from keypresses > > > such as Fn-F4 and lid open/close, prints them in /var/log/acpid > > > and reacts accordingly (my acpi scripts suspend on lid close and Fn-F4). > > > > You mean suspend-to-ram works correctly on your t61p? > > > > Mine suspends, then five seconds later magically resumes itself and the > > screen is all black. > > Sorry, have not noticed what you were asking about. > Yes, rc2 seems to suspend/resume fine. > > And after reverting > > revert commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2. commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 Author: Pavel Machek <[EMAIL PROTECTED]> Date: Thu Feb 21 13:56:55 2008 +0100 power_state: get rid of write-only variable in SATA > revert commit 208c70a45624400fafd7511b96bc426bf01f8f5e. commit 208c70a45624400fafd7511b96bc426bf01f8f5e Author: Alexey Starikovskiy <[EMAIL PROTECTED]> Date: Thu Feb 14 15:58:47 2008 -0500 ACPI: EC: Use proper handle for boot EC > r3 does, too. Please, _please_ always add commit subjects to your reports. Also, please include the names of the authors of the commits that turn out to break things and send CCs to them. It won't hurt to send CCs to the people who signed those commits off, too. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p
Michael S. Tsirkin wrote: Did you guys stop accepting reports by mail? I hope not. It is easier to track bug information in bugzilla. If you for some reason do not wish to create a bug report, I can do it for you. You only need to provide acpidump. and attach acpidump? I'll see if I can get acpidump output - in which state do you want it? Right after boot on the broken kernel? acpidump output does not change over time, you could get it even with some other kernel. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p
On Mon, Feb 25, 2008 at 9:46 PM, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Mon, 25 Feb 2008 21:19:24 +0200 "Michael S. Tsirkin" <[EMAIL PROTECTED]> > wrote: > > > On my T61p, 2.6.25-rc2 seems to get acpi events from keypresses > > such as Fn-F4 and lid open/close, prints them in /var/log/acpid > > and reacts accordingly (my acpi scripts suspend on lid close and Fn-F4). > > You mean suspend-to-ram works correctly on your t61p? > > Mine suspends, then five seconds later magically resumes itself and the > screen is all black. Sorry, have not noticed what you were asking about. Yes, rc2 seems to suspend/resume fine. And after reverting revert commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2. revert commit 208c70a45624400fafd7511b96bc426bf01f8f5e. r3 does, too. I just waited a couple of minutes after suspend to ram and it stays suspended. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p
On Mon, Feb 25, 2008 at 9:46 PM, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Mon, 25 Feb 2008 21:19:24 +0200 "Michael S. Tsirkin" <[EMAIL PROTECTED]> > wrote: > > > On my T61p, 2.6.25-rc2 seems to get acpi events from keypresses > > such as Fn-F4 and lid open/close, prints them in /var/log/acpid > > and reacts accordingly (my acpi scripts suspend on lid close and Fn-F4). > > You mean suspend-to-ram works correctly on your t61p? > > Mine suspends, then five seconds later magically resumes itself and the > screen is all black. > > I see the resume problems too, but they do not seem to be acpi-related (IOW, there are 2 issues). I just finished bisecting and intend to report shortly. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p
On Mon, Feb 25, 2008 at 9:42 PM, Alexey Starikovskiy <[EMAIL PROTECTED]> wrote: > Michael S. Tsirkin wrote: > > On my T61p, 2.6.25-rc2 seems to get acpi events from keypresses > > such as Fn-F4 and lid open/close, prints them in /var/log/acpid > > and reacts accordingly (my acpi scripts suspend on lid close and Fn-F4). > > > > This no longer happens in 2.6.25-rc3: I see nothing in /var/log/acpid > > after power on: > > [Mon Feb 25 20:47:28 2008] completed event "button/power PWRF 0080 > 0001" > > [Mon Feb 25 20:48:44 2008] starting up > > [Mon Feb 25 20:48:44 2008] 57 rules loaded > > [Mon Feb 25 20:48:48 2008] client connected from 5927[0:0] > > [Mon Feb 25 20:48:48 2008] 1 client rule loaded > > > > and pressing buttons or closing lid produces no output in > > /var/log/acpid and seems to have no effect. > > > > git bisect pointed at commit 208c70a45624400fafd7511b96bc426bf01f8f5e : > > ACPI: EC: Use proper handle for boot EC > > > > If I do git revert 208c70a45624400fafd7511b96bc426bf01f8f5e on top > > of 2.6.25-rc3, I start getting keyboard acpi events, again. > Could you please create a bug report Did you guys stop accepting reports by mail? I hope not. > and attach acpidump? I'll see if I can get acpidump output - in which state do you want it? Right after boot on the broken kernel? > Thanks, > Alex. > > > > > > > > Thanks, > > MST > > > > PS: I see a different problem on resume, it seems to be unrelated to ACPI > > and I will bisect and report separately. > > > > PPS: Pls Cc me directly, I am not on the list. > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p
On Mon, 25 Feb 2008 21:19:24 +0200 "Michael S. Tsirkin" <[EMAIL PROTECTED]> wrote: > On my T61p, 2.6.25-rc2 seems to get acpi events from keypresses > such as Fn-F4 and lid open/close, prints them in /var/log/acpid > and reacts accordingly (my acpi scripts suspend on lid close and Fn-F4). You mean suspend-to-ram works correctly on your t61p? Mine suspends, then five seconds later magically resumes itself and the screen is all black. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p
Michael S. Tsirkin wrote: On my T61p, 2.6.25-rc2 seems to get acpi events from keypresses such as Fn-F4 and lid open/close, prints them in /var/log/acpid and reacts accordingly (my acpi scripts suspend on lid close and Fn-F4). This no longer happens in 2.6.25-rc3: I see nothing in /var/log/acpid after power on: [Mon Feb 25 20:47:28 2008] completed event "button/power PWRF 0080 0001" [Mon Feb 25 20:48:44 2008] starting up [Mon Feb 25 20:48:44 2008] 57 rules loaded [Mon Feb 25 20:48:48 2008] client connected from 5927[0:0] [Mon Feb 25 20:48:48 2008] 1 client rule loaded and pressing buttons or closing lid produces no output in /var/log/acpid and seems to have no effect. git bisect pointed at commit 208c70a45624400fafd7511b96bc426bf01f8f5e : ACPI: EC: Use proper handle for boot EC If I do git revert 208c70a45624400fafd7511b96bc426bf01f8f5e on top of 2.6.25-rc3, I start getting keyboard acpi events, again. Could you please create a bug report and attach acpidump? Thanks, Alex. Thanks, MST PS: I see a different problem on resume, it seems to be unrelated to ACPI and I will bisect and report separately. PPS: Pls Cc me directly, I am not on the list. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p
On my T61p, 2.6.25-rc2 seems to get acpi events from keypresses such as Fn-F4 and lid open/close, prints them in /var/log/acpid and reacts accordingly (my acpi scripts suspend on lid close and Fn-F4). This no longer happens in 2.6.25-rc3: I see nothing in /var/log/acpid after power on: [Mon Feb 25 20:47:28 2008] completed event "button/power PWRF 0080 0001" [Mon Feb 25 20:48:44 2008] starting up [Mon Feb 25 20:48:44 2008] 57 rules loaded [Mon Feb 25 20:48:48 2008] client connected from 5927[0:0] [Mon Feb 25 20:48:48 2008] 1 client rule loaded and pressing buttons or closing lid produces no output in /var/log/acpid and seems to have no effect. git bisect pointed at commit 208c70a45624400fafd7511b96bc426bf01f8f5e : ACPI: EC: Use proper handle for boot EC If I do git revert 208c70a45624400fafd7511b96bc426bf01f8f5e on top of 2.6.25-rc3, I start getting keyboard acpi events, again. Thanks, MST PS: I see a different problem on resume, it seems to be unrelated to ACPI and I will bisect and report separately. PPS: Pls Cc me directly, I am not on the list. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p
Michael S. Tsirkin wrote: On my T61p, 2.6.25-rc2 seems to get acpi events from keypresses such as Fn-F4 and lid open/close, prints them in /var/log/acpid and reacts accordingly (my acpi scripts suspend on lid close and Fn-F4). This no longer happens in 2.6.25-rc3: I see nothing in /var/log/acpid after power on: [Mon Feb 25 20:47:28 2008] completed event button/power PWRF 0080 0001 [Mon Feb 25 20:48:44 2008] starting up [Mon Feb 25 20:48:44 2008] 57 rules loaded [Mon Feb 25 20:48:48 2008] client connected from 5927[0:0] [Mon Feb 25 20:48:48 2008] 1 client rule loaded and pressing buttons or closing lid produces no output in /var/log/acpid and seems to have no effect. git bisect pointed at commit 208c70a45624400fafd7511b96bc426bf01f8f5e : ACPI: EC: Use proper handle for boot EC If I do git revert 208c70a45624400fafd7511b96bc426bf01f8f5e on top of 2.6.25-rc3, I start getting keyboard acpi events, again. Could you please create a bug report and attach acpidump? Thanks, Alex. Thanks, MST PS: I see a different problem on resume, it seems to be unrelated to ACPI and I will bisect and report separately. PPS: Pls Cc me directly, I am not on the list. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p
On my T61p, 2.6.25-rc2 seems to get acpi events from keypresses such as Fn-F4 and lid open/close, prints them in /var/log/acpid and reacts accordingly (my acpi scripts suspend on lid close and Fn-F4). This no longer happens in 2.6.25-rc3: I see nothing in /var/log/acpid after power on: [Mon Feb 25 20:47:28 2008] completed event button/power PWRF 0080 0001 [Mon Feb 25 20:48:44 2008] starting up [Mon Feb 25 20:48:44 2008] 57 rules loaded [Mon Feb 25 20:48:48 2008] client connected from 5927[0:0] [Mon Feb 25 20:48:48 2008] 1 client rule loaded and pressing buttons or closing lid produces no output in /var/log/acpid and seems to have no effect. git bisect pointed at commit 208c70a45624400fafd7511b96bc426bf01f8f5e : ACPI: EC: Use proper handle for boot EC If I do git revert 208c70a45624400fafd7511b96bc426bf01f8f5e on top of 2.6.25-rc3, I start getting keyboard acpi events, again. Thanks, MST PS: I see a different problem on resume, it seems to be unrelated to ACPI and I will bisect and report separately. PPS: Pls Cc me directly, I am not on the list. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p
On Mon, 25 Feb 2008 21:19:24 +0200 Michael S. Tsirkin [EMAIL PROTECTED] wrote: On my T61p, 2.6.25-rc2 seems to get acpi events from keypresses such as Fn-F4 and lid open/close, prints them in /var/log/acpid and reacts accordingly (my acpi scripts suspend on lid close and Fn-F4). You mean suspend-to-ram works correctly on your t61p? Mine suspends, then five seconds later magically resumes itself and the screen is all black. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p
On Mon, Feb 25, 2008 at 9:42 PM, Alexey Starikovskiy [EMAIL PROTECTED] wrote: Michael S. Tsirkin wrote: On my T61p, 2.6.25-rc2 seems to get acpi events from keypresses such as Fn-F4 and lid open/close, prints them in /var/log/acpid and reacts accordingly (my acpi scripts suspend on lid close and Fn-F4). This no longer happens in 2.6.25-rc3: I see nothing in /var/log/acpid after power on: [Mon Feb 25 20:47:28 2008] completed event button/power PWRF 0080 0001 [Mon Feb 25 20:48:44 2008] starting up [Mon Feb 25 20:48:44 2008] 57 rules loaded [Mon Feb 25 20:48:48 2008] client connected from 5927[0:0] [Mon Feb 25 20:48:48 2008] 1 client rule loaded and pressing buttons or closing lid produces no output in /var/log/acpid and seems to have no effect. git bisect pointed at commit 208c70a45624400fafd7511b96bc426bf01f8f5e : ACPI: EC: Use proper handle for boot EC If I do git revert 208c70a45624400fafd7511b96bc426bf01f8f5e on top of 2.6.25-rc3, I start getting keyboard acpi events, again. Could you please create a bug report Did you guys stop accepting reports by mail? I hope not. and attach acpidump? I'll see if I can get acpidump output - in which state do you want it? Right after boot on the broken kernel? Thanks, Alex. Thanks, MST PS: I see a different problem on resume, it seems to be unrelated to ACPI and I will bisect and report separately. PPS: Pls Cc me directly, I am not on the list. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p
On Mon, Feb 25, 2008 at 9:46 PM, Andrew Morton [EMAIL PROTECTED] wrote: On Mon, 25 Feb 2008 21:19:24 +0200 Michael S. Tsirkin [EMAIL PROTECTED] wrote: On my T61p, 2.6.25-rc2 seems to get acpi events from keypresses such as Fn-F4 and lid open/close, prints them in /var/log/acpid and reacts accordingly (my acpi scripts suspend on lid close and Fn-F4). You mean suspend-to-ram works correctly on your t61p? Mine suspends, then five seconds later magically resumes itself and the screen is all black. I see the resume problems too, but they do not seem to be acpi-related (IOW, there are 2 issues). I just finished bisecting and intend to report shortly. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p
On Mon, Feb 25, 2008 at 9:46 PM, Andrew Morton [EMAIL PROTECTED] wrote: On Mon, 25 Feb 2008 21:19:24 +0200 Michael S. Tsirkin [EMAIL PROTECTED] wrote: On my T61p, 2.6.25-rc2 seems to get acpi events from keypresses such as Fn-F4 and lid open/close, prints them in /var/log/acpid and reacts accordingly (my acpi scripts suspend on lid close and Fn-F4). You mean suspend-to-ram works correctly on your t61p? Mine suspends, then five seconds later magically resumes itself and the screen is all black. Sorry, have not noticed what you were asking about. Yes, rc2 seems to suspend/resume fine. And after reverting revert commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2. revert commit 208c70a45624400fafd7511b96bc426bf01f8f5e. r3 does, too. I just waited a couple of minutes after suspend to ram and it stays suspended. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p
Michael S. Tsirkin wrote: Did you guys stop accepting reports by mail? I hope not. It is easier to track bug information in bugzilla. If you for some reason do not wish to create a bug report, I can do it for you. You only need to provide acpidump. and attach acpidump? I'll see if I can get acpidump output - in which state do you want it? Right after boot on the broken kernel? acpidump output does not change over time, you could get it even with some other kernel. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
On Monday, 25 of February 2008, Michael S. Tsirkin wrote: On Mon, Feb 25, 2008 at 9:46 PM, Andrew Morton [EMAIL PROTECTED] wrote: On Mon, 25 Feb 2008 21:19:24 +0200 Michael S. Tsirkin [EMAIL PROTECTED] wrote: On my T61p, 2.6.25-rc2 seems to get acpi events from keypresses such as Fn-F4 and lid open/close, prints them in /var/log/acpid and reacts accordingly (my acpi scripts suspend on lid close and Fn-F4). You mean suspend-to-ram works correctly on your t61p? Mine suspends, then five seconds later magically resumes itself and the screen is all black. Sorry, have not noticed what you were asking about. Yes, rc2 seems to suspend/resume fine. And after reverting revert commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2. commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 Author: Pavel Machek [EMAIL PROTECTED] Date: Thu Feb 21 13:56:55 2008 +0100 power_state: get rid of write-only variable in SATA revert commit 208c70a45624400fafd7511b96bc426bf01f8f5e. commit 208c70a45624400fafd7511b96bc426bf01f8f5e Author: Alexey Starikovskiy [EMAIL PROTECTED] Date: Thu Feb 14 15:58:47 2008 -0500 ACPI: EC: Use proper handle for boot EC r3 does, too. Please, _please_ always add commit subjects to your reports. Also, please include the names of the authors of the commits that turn out to break things and send CCs to them. It won't hurt to send CCs to the people who signed those commits off, too. Thanks, Rafael -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
Hi! On Monday, 25 of February 2008, Michael S. Tsirkin wrote: On Mon, Feb 25, 2008 at 9:46 PM, Andrew Morton [EMAIL PROTECTED] wrote: On Mon, 25 Feb 2008 21:19:24 +0200 Michael S. Tsirkin [EMAIL PROTECTED] wrote: On my T61p, 2.6.25-rc2 seems to get acpi events from keypresses such as Fn-F4 and lid open/close, prints them in /var/log/acpid and reacts accordingly (my acpi scripts suspend on lid close and Fn-F4). You mean suspend-to-ram works correctly on your t61p? Mine suspends, then five seconds later magically resumes itself and the screen is all black. Sorry, have not noticed what you were asking about. Yes, rc2 seems to suspend/resume fine. And after reverting revert commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2. commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 Author: Pavel Machek [EMAIL PROTECTED] Date: Thu Feb 21 13:56:55 2008 +0100 power_state: get rid of write-only variable in SATA This is pretty unlikely to be it. Can you double check that this patch really breaks something? revert commit 208c70a45624400fafd7511b96bc426bf01f8f5e. commit 208c70a45624400fafd7511b96bc426bf01f8f5e Author: Alexey Starikovskiy [EMAIL PROTECTED] Date: Thu Feb 14 15:58:47 2008 -0500 ACPI: EC: Use proper handle for boot EC r3 does, too. Please, _please_ always add commit subjects to your reports. Also, please include the names of the authors of the commits that turn out to break things and send CCs to them. It won't hurt to send CCs to the people who signed those commits off, too. Hmm, as EC is the piece of hw that does the wakeups, yes, EC might be responsible for autowaking. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
On Mon, Feb 25, 2008 at 11:26 PM, Pavel Machek [EMAIL PROTECTED] wrote: Hi! On Monday, 25 of February 2008, Michael S. Tsirkin wrote: On Mon, Feb 25, 2008 at 9:46 PM, Andrew Morton [EMAIL PROTECTED] wrote: On Mon, 25 Feb 2008 21:19:24 +0200 Michael S. Tsirkin [EMAIL PROTECTED] wrote: On my T61p, 2.6.25-rc2 seems to get acpi events from keypresses such as Fn-F4 and lid open/close, prints them in /var/log/acpid and reacts accordingly (my acpi scripts suspend on lid close and Fn-F4). You mean suspend-to-ram works correctly on your t61p? Mine suspends, then five seconds later magically resumes itself and the screen is all black. Sorry, have not noticed what you were asking about. Yes, rc2 seems to suspend/resume fine. And after reverting revert commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2. commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 Author: Pavel Machek [EMAIL PROTECTED] Date: Thu Feb 21 13:56:55 2008 +0100 power_state: get rid of write-only variable in SATA This is pretty unlikely to be it. Can you double check that this patch really breaks something? I did and it seems to: just reverting 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 fixes resume for me. 635adc28087ced0c843d2ecb6d4ae474d0e611cd which is 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2~1 also resumes fine. revert commit 208c70a45624400fafd7511b96bc426bf01f8f5e. commit 208c70a45624400fafd7511b96bc426bf01f8f5e Author: Alexey Starikovskiy [EMAIL PROTECTED] Date: Thu Feb 14 15:58:47 2008 -0500 ACPI: EC: Use proper handle for boot EC r3 does, too. Please, _please_ always add commit subjects to your reports. Also, please include the names of the authors of the commits that turn out to break things and send CCs to them. It won't hurt to send CCs to the people who signed those commits off, too. Hmm, as EC is the piece of hw that does the wakeups, yes, EC might be responsible for autowaking. Pavel As far as I can tell, nope, reverting 208c70a45624400fafd7511b96bc426bf01f8f5e fixes acpi keyboard/lid events but does fix resume from suspend to ram for me. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
Pavel Machek wrote: commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 Author: Pavel Machek [EMAIL PROTECTED] Date: Thu Feb 21 13:56:55 2008 +0100 power_state: get rid of write-only variable in SATA This is pretty unlikely to be it. Can you double check that this patch really breaks something? Quote... After reverting 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 on top of 2.6.25-rc3 the kernel again resumes from suspend to ram. Seems pretty clear to me. Jeff -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
Hi! commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 Author: Pavel Machek [EMAIL PROTECTED] Date: Thu Feb 21 13:56:55 2008 +0100 power_state: get rid of write-only variable in SATA This is pretty unlikely to be it. Can you double check that this patch really breaks something? I did and it seems to: just reverting 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 fixes resume for me. 635adc28087ced0c843d2ecb6d4ae474d0e611cd which is 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2~1 also resumes fine. Hmm, I guess that should teach me about simple cleanups. Do you use any of: ata/sata_inic162x.c ata/sata_nv.c ata/sata_sil24.c by chance? (Ok, the patch is very safe to revert, it was cleanup, it fixes nothing). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
On Mon, Feb 25, 2008 at 11:50 PM, Pavel Machek [EMAIL PROTECTED] wrote:
Hi!
commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2
Author: Pavel Machek [EMAIL PROTECTED]
Date: Thu Feb 21 13:56:55 2008 +0100
power_state: get rid of write-only variable in SATA
This is pretty unlikely to be it. Can you double check that this patch
really breaks something?
I did and it seems to: just reverting
559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 fixes resume for me.
635adc28087ced0c843d2ecb6d4ae474d0e611cd which is
559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2~1
also resumes fine.
Hmm, I guess that should teach me about simple cleanups.
Do you use any of:
ata/sata_inic162x.c
ata/sata_nv.c
ata/sata_sil24.c
by chance?
I don't think so.
Here are the only 3 ata modules I have built:
drivers/ata/ahci.ko
drivers/ata/ata_piix.ko
drivers/ata/libata.ko
ahci.c seems to look at power_state.
static int ahci_pci_device_resume(struct pci_dev *pdev)
{
struct ata_host *host = dev_get_drvdata(pdev-dev);
int rc;
rc = ata_pci_device_do_resume(pdev);
if (rc)
return rc;
if (pdev-dev.power.power_state.event == PM_EVENT_SUSPEND) {
rc = ahci_reset_controller(host);
if (rc)
return rc;
ahci_init_controller(host);
}
ata_host_resume(host);
return 0;
}
Right?
(Ok, the patch is very safe to revert, it was cleanup, it fixes
nothing).
Pavel
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
Hi!
commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2
Author: Pavel Machek [EMAIL PROTECTED]
Date: Thu Feb 21 13:56:55 2008 +0100
power_state: get rid of write-only variable in SATA
This is pretty unlikely to be it. Can you double check that this patch
really breaks something?
I did and it seems to: just reverting
559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 fixes resume for me.
635adc28087ced0c843d2ecb6d4ae474d0e611cd which is
559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2~1
also resumes fine.
Hmm, I guess that should teach me about simple cleanups.
Do you use any of:
ata/sata_inic162x.c
ata/sata_nv.c
ata/sata_sil24.c
by chance?
I don't think so.
Here are the only 3 ata modules I have built:
drivers/ata/ahci.ko
drivers/ata/ata_piix.ko
drivers/ata/libata.ko
ahci.c seems to look at power_state.
static int ahci_pci_device_resume(struct pci_dev *pdev)
{
struct ata_host *host = dev_get_drvdata(pdev-dev);
int rc;
rc = ata_pci_device_do_resume(pdev);
if (rc)
return rc;
if (pdev-dev.power.power_state.event == PM_EVENT_SUSPEND) {
rc = ahci_reset_controller(host);
if (rc)
return rc;
ahci_init_controller(host);
}
Right?
Hmm, mystery partly solved... as you guessed it, this piece of code
was not in my tree.
(still, how can this cause autoresume after 5 seconds is a mystery to
me).
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
On Mon 2008-02-25 16:32:38, Jeff Garzik wrote: Pavel Machek wrote: commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 Author: Pavel Machek [EMAIL PROTECTED] Date: Thu Feb 21 13:56:55 2008 +0100 power_state: get rid of write-only variable in SATA This is pretty unlikely to be it. Can you double check that this patch really breaks something? Quote... After reverting 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 on top of 2.6.25-rc3 the kernel again resumes from suspend to ram. Seems pretty clear to me. Yep, that patch was crappy. I developed it on machine with SCSI powersave patches applied, and did not realize this code changed. Sorry. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p
Michael S. Tsirkin wrote:
On Mon, Feb 25, 2008 at 10:50 PM, Alexey Starikovskiy
[EMAIL PROTECTED] wrote:
Michael S. Tsirkin wrote:
Did you guys stop accepting reports by mail?
I hope not.
It is easier to track bug information in bugzilla.
If you for some reason do not wish to create a bug report,
I can do it for you. You only need to provide acpidump.
Great.
and attach acpidump?
I'll see if I can get acpidump output - in which state do you want it?
Right after boot on the broken kernel?
acpidump output does not change over time, you could get it even with some
other kernel.
Attached is the acpidump output run under 2.6.23-rc3 + with reverted
37f9b4c7c612fcbeb8fb6faddaef4ccdb5350145
(IOW - this is a working configuration).
Thanks, you've got round 10100 bug number.
Please check if the following patch on top of Linus git tree helps.
Regards,
Alex
HTH,
MST
ACPI: EC: fix regression
From: Alexey Starikovskiy [EMAIL PROTECTED]
---
drivers/acpi/ec.c | 18 +++---
1 files changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index caf873c..d6f9956 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -129,7 +129,8 @@ static struct acpi_ec {
struct mutex lock;
wait_queue_head_t wait;
struct list_head list;
- u8 handlers_installed;
+ u8 handlers_installed:1;
+ u8 from_ecdt:1;
} *boot_ec, *first_ec;
/* --
@@ -772,16 +773,18 @@ static int acpi_ec_add(struct acpi_device *device)
/* Check for boot EC */
if (boot_ec) {
- if (boot_ec-handle == device-handle) {
- /* Pre-loaded EC from DSDT, just move pointer */
- ec = boot_ec;
- boot_ec = NULL;
- goto end;
- } else if (boot_ec-handle == ACPI_ROOT_OBJECT) {
+ if (boot_ec-from_ecdt
+ (boot_ec-handle == device-handle ||
+ boot_ec-handle == ACPI_ROOT_OBJECT)) {
/* ECDT-based EC, time to shut it down */
ec_remove_handlers(boot_ec);
kfree(boot_ec);
first_ec = boot_ec = NULL;
+ } else if (boot_ec-handle == device-handle) {
+ /* Pre-loaded EC from DSDT, just move pointer */
+ ec = boot_ec;
+ boot_ec = NULL;
+ goto end;
}
}
@@ -943,6 +946,7 @@ int __init acpi_ec_ecdt_probe(void)
boot_ec-command_addr = ecdt_ptr-control.address;
boot_ec-data_addr = ecdt_ptr-data.address;
boot_ec-gpe = ecdt_ptr-gpe;
+ boot_ec-from_ecdt = 1;
if (ACPI_FAILURE(acpi_get_handle(NULL, ecdt_ptr-id,
boot_ec-handle))) {
pr_info(Failed to locate handle for boot EC\n);
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
On Tue, Feb 26, 2008 at 12:20 AM, Pavel Machek [EMAIL PROTECTED] wrote:
Hi!
commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2
Author: Pavel Machek [EMAIL PROTECTED]
Date: Thu Feb 21 13:56:55 2008 +0100
power_state: get rid of write-only variable in SATA
This is pretty unlikely to be it. Can you double check that this
patch
really breaks something?
I did and it seems to: just reverting
559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 fixes resume for me.
635adc28087ced0c843d2ecb6d4ae474d0e611cd which is
559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2~1
also resumes fine.
Hmm, I guess that should teach me about simple cleanups.
Do you use any of:
ata/sata_inic162x.c
ata/sata_nv.c
ata/sata_sil24.c
by chance?
I don't think so.
Here are the only 3 ata modules I have built:
drivers/ata/ahci.ko
drivers/ata/ata_piix.ko
drivers/ata/libata.ko
ahci.c seems to look at power_state.
static int ahci_pci_device_resume(struct pci_dev *pdev)
{
struct ata_host *host = dev_get_drvdata(pdev-dev);
int rc;
rc = ata_pci_device_do_resume(pdev);
if (rc)
return rc;
if (pdev-dev.power.power_state.event == PM_EVENT_SUSPEND) {
rc = ahci_reset_controller(host);
if (rc)
return rc;
ahci_init_controller(host);
}
Right?
Hmm, mystery partly solved... as you guessed it, this piece of code
was not in my tree.
(still, how can this cause autoresume after 5 seconds is a mystery to
me).
Pavel
Maybe it doesn't. Andrew saw the autoresume on -rc[2,3], I didn't.
For me, it causes resume to fail.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
On Tue, 26 Feb 2008 00:36:54 +0200 Michael S. Tsirkin [EMAIL PROTECTED] wrote: Hmm, mystery partly solved... as you guessed it, this piece of code was not in my tree. (still, how can this cause autoresume after 5 seconds is a mystery to me). Pavel Maybe it doesn't. Andrew saw the autoresume on -rc[2,3] And earlier - I think 2.6.23 does it as well. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
On Tue, 26 Feb 2008 00:48:12 +0200 Michael S. Tsirkin [EMAIL PROTECTED] wrote: On Tue, Feb 26, 2008 at 12:39 AM, Andrew Morton [EMAIL PROTECTED] wrote: On Tue, 26 Feb 2008 00:36:54 +0200 Michael S. Tsirkin [EMAIL PROTECTED] wrote: Hmm, mystery partly solved... as you guessed it, this piece of code was not in my tree. (still, how can this cause autoresume after 5 seconds is a mystery to me). Pavel Maybe it doesn't. Andrew saw the autoresume on -rc[2,3] And earlier - I think 2.6.23 does it as well. But that one at least resumes fine, does it not? Nope, the resume-after-five-seconds and black-screen-after-resume have always been there (I've only had the thing a few months). I thought the restoring of the screen after resume is handled by the X server? I'm using the nv.o driver. Perhaps nvidia's driver handles it right, dunno. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
Hi! Maybe it doesn't. Andrew saw the autoresume on -rc[2,3] And earlier - I think 2.6.23 does it as well. But that one at least resumes fine, does it not? Nope, the resume-after-five-seconds and black-screen-after-resume have always been there (I've only had the thing a few months). I thought the restoring of the screen after resume is handled by the X server? I'm using the nv.o driver. Perhaps nvidia's driver handles it right, dunno. Aha, so you do not have s2ram from suspend.sf.net installed, do you? Restoring the screen is done by either a) kernel/bios (acpi_sleep=..., or better s2ram -f -a X ) b) vbetool c) X . s2ram should detect your machine, and automatically set acpi_sleep and/or perform vbetool magic. Please try s2ram, there's good chance it will just work. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
On Tue, Feb 26, 2008 at 12:53 AM, Andrew Morton [EMAIL PROTECTED] wrote: On Tue, 26 Feb 2008 00:48:12 +0200 Michael S. Tsirkin [EMAIL PROTECTED] wrote: On Tue, Feb 26, 2008 at 12:39 AM, Andrew Morton [EMAIL PROTECTED] wrote: On Tue, 26 Feb 2008 00:36:54 +0200 Michael S. Tsirkin [EMAIL PROTECTED] wrote: Hmm, mystery partly solved... as you guessed it, this piece of code was not in my tree. (still, how can this cause autoresume after 5 seconds is a mystery to me). Pavel Maybe it doesn't. Andrew saw the autoresume on -rc[2,3] And earlier - I think 2.6.23 does it as well. But that one at least resumes fine, does it not? Nope, the resume-after-five-seconds and black-screen-after-resume have always been there (I've only had the thing a few months). I thought the restoring of the screen after resume is handled by the X server? I'm using the nv.o driver. Perhaps nvidia's driver handles it right, dunno. Oh, I have the ATI thingy. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)
On Tue, Feb 26, 2008 at 12:39 AM, Andrew Morton [EMAIL PROTECTED] wrote: On Tue, 26 Feb 2008 00:36:54 +0200 Michael S. Tsirkin [EMAIL PROTECTED] wrote: Hmm, mystery partly solved... as you guessed it, this piece of code was not in my tree. (still, how can this cause autoresume after 5 seconds is a mystery to me). Pavel Maybe it doesn't. Andrew saw the autoresume on -rc[2,3] And earlier - I think 2.6.23 does it as well. But that one at least resumes fine, does it not? -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p
On Tue, Feb 26, 2008 at 12:33 AM, Alexey Starikovskiy [EMAIL PROTECTED] wrote: Attached is the acpidump output run under 2.6.23-rc3 + with reverted 37f9b4c7c612fcbeb8fb6faddaef4ccdb5350145 (IOW - this is a working configuration). Thanks, you've got round 10100 bug number. Please check if the following patch on top of Linus git tree helps. Regards, Alex I did some light testing, but yes, this seems to help. With this patch applied on top of 2.6.25-rc3, I get keyboard acpi events again, so that I can suspend by clicking Fn+F4. -- MST -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p - resume hang
On Tue, Feb 26, 2008 at 4:45 AM, Michael S. Tsirkin
[EMAIL PROTECTED] wrote:
On Mon, Feb 25, 2008 at 9:46 PM, Andrew Morton
[EMAIL PROTECTED] wrote:
On Mon, 25 Feb 2008 21:19:24 +0200 Michael S. Tsirkin
[EMAIL PROTECTED] wrote:
You mean suspend-to-ram works correctly on your t61p?
Mine suspends, then five seconds later magically resumes itself and
the
screen is all black.
Sorry, have not noticed what you were asking about.
Yes, rc2 seems to suspend/resume fine.
And after reverting
revert commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2.
commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2
Author: Pavel Machek [EMAIL PROTECTED]
Date: Thu Feb 21 13:56:55 2008 +0100
power_state: get rid of write-only variable in SATA
power_state is scheduled for removal, and libata uses it in write-only
mode. Remove it.
Signed-off-by: Pavel Machek [EMAIL PROTECTED]
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
I'm experiencing hang after resume from STR with the latest Linus's git
tree. Reverting the above patch solved the problem.
Thanks,
Jeff
Here's the patch for reference ...
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 4cf8662..9812bbf 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -6560,8 +6560,6 @@ int ata_host_suspend(struct ata_host *host, pm_message_t
mesg)
ata_lpm_enable(host);
rc = ata_host_request_pm(host, mesg, 0, ATA_EHI_QUIET, 1);
- if (rc == 0)
- host-dev-power.power_state = mesg;
return rc;
}
@@ -6580,7 +6578,6 @@ void ata_host_resume(struct ata_host *host)
{
ata_host_request_pm(host, PMSG_ON, ATA_EH_SOFTRESET,
ATA_EHI_NO_AUTOPSY | ATA_EHI_QUIET, 0);
- host-dev-power.power_state = PMSG_ON;
/* reenable link pm */
ata_lpm_disable(host);
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
