Re: perf, x86: Add last TSX PMU code for Haswell v3
On Tue, Oct 01, 2013 at 09:31:24AM +0200, Andi Kleen wrote: > Sorry I missed that. No change other than acks/rebase, > so the previous version should be fine. Thanks. Yeah, I didn't mail out and it hasn't landed it -tip yet. So you couldn't have known. > Outstanding TSX patches i have now (unless someone merged them): > > perf stat -T > > https://lkml.org/lkml/2013/8/21/667 > > Was acked by Arnaldo > > 64bit comparison fix without that the abort code reporting with > the abort code in the high 32bit doesn't work. > > https://lkml.org/lkml/2013/9/27/569 > > Acked by Namyoung. Both are tools patches; I'll see if I can get acme to pick them up; if not I'll pick them up. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: perf, x86: Add last TSX PMU code for Haswell v3
On Tue, Oct 01, 2013 at 09:22:03AM +0200, Peter Zijlstra wrote: > On Mon, Sep 30, 2013 at 02:58:57PM -0700, Andi Kleen wrote: > > [This has kernel and user parts. > > Both sides have been reviewed now, so hopefully it's good > > to merge.] > > [v2: Address Peter's feedback for the kernel parts] > > [v3: Rebased to current tip. Added Ack/Reviewed-by for user tools code] > > I merged your previous version yesterday; and did the rebase to current > tip as that was a trivial one; I added Jolsa's ack. > > Did I miss anything? Sorry I missed that. No change other than acks/rebase, so the previous version should be fine. Thanks. Outstanding TSX patches i have now (unless someone merged them): perf stat -T https://lkml.org/lkml/2013/8/21/667 Was acked by Arnaldo 64bit comparison fix without that the abort code reporting with the abort code in the high 32bit doesn't work. https://lkml.org/lkml/2013/9/27/569 Acked by Namyoung. If someone could take care of those that would be great. Thanks. -Andi -- a...@linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: perf, x86: Add last TSX PMU code for Haswell v3
On Mon, Sep 30, 2013 at 02:58:57PM -0700, Andi Kleen wrote: > [This has kernel and user parts. > Both sides have been reviewed now, so hopefully it's good > to merge.] > [v2: Address Peter's feedback for the kernel parts] > [v3: Rebased to current tip. Added Ack/Reviewed-by for user tools code] I merged your previous version yesterday; and did the rebase to current tip as that was a trivial one; I added Jolsa's ack. Did I miss anything? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: perf, x86: Add last TSX PMU code for Haswell v3
On Mon, Sep 30, 2013 at 02:58:57PM -0700, Andi Kleen wrote: [This has kernel and user parts. Both sides have been reviewed now, so hopefully it's good to merge.] [v2: Address Peter's feedback for the kernel parts] [v3: Rebased to current tip. Added Ack/Reviewed-by for user tools code] I merged your previous version yesterday; and did the rebase to current tip as that was a trivial one; I added Jolsa's ack. Did I miss anything? -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: perf, x86: Add last TSX PMU code for Haswell v3
On Tue, Oct 01, 2013 at 09:22:03AM +0200, Peter Zijlstra wrote: On Mon, Sep 30, 2013 at 02:58:57PM -0700, Andi Kleen wrote: [This has kernel and user parts. Both sides have been reviewed now, so hopefully it's good to merge.] [v2: Address Peter's feedback for the kernel parts] [v3: Rebased to current tip. Added Ack/Reviewed-by for user tools code] I merged your previous version yesterday; and did the rebase to current tip as that was a trivial one; I added Jolsa's ack. Did I miss anything? Sorry I missed that. No change other than acks/rebase, so the previous version should be fine. Thanks. Outstanding TSX patches i have now (unless someone merged them): perf stat -T https://lkml.org/lkml/2013/8/21/667 Was acked by Arnaldo 64bit comparison fix without that the abort code reporting with the abort code in the high 32bit doesn't work. https://lkml.org/lkml/2013/9/27/569 Acked by Namyoung. If someone could take care of those that would be great. Thanks. -Andi -- a...@linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: perf, x86: Add last TSX PMU code for Haswell v3
On Tue, Oct 01, 2013 at 09:31:24AM +0200, Andi Kleen wrote: Sorry I missed that. No change other than acks/rebase, so the previous version should be fine. Thanks. Yeah, I didn't mail out and it hasn't landed it -tip yet. So you couldn't have known. Outstanding TSX patches i have now (unless someone merged them): perf stat -T https://lkml.org/lkml/2013/8/21/667 Was acked by Arnaldo 64bit comparison fix without that the abort code reporting with the abort code in the high 32bit doesn't work. https://lkml.org/lkml/2013/9/27/569 Acked by Namyoung. Both are tools patches; I'll see if I can get acme to pick them up; if not I'll pick them up. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
perf, x86: Add last TSX PMU code for Haswell v3
[This has kernel and user parts. Both sides have been reviewed now, so hopefully it's good to merge.] [v2: Address Peter's feedback for the kernel parts] [v3: Rebased to current tip. Added Ack/Reviewed-by for user tools code] Note this also needs the separately posted 64bit comparison fix to correctly report abort codes. This is currently the last part of the TSX PMU code, just adding the left over bits: This adds some changes to the user interfaces. I'll send patches for the manpage separately. - Report the transaction abort flags to user space using a new field, and add the code to display them. This is used to classify abort types, also fairly important for tuning as it guides the tuning process, together with the abort weight that was added earleir. [3 patches, generic, x86, user tools] - Add support for reporting the two new TSX LBR flags: in_tx and abort_tx. The code to handle the LBRs was already added earlier, this just adds the code to report, filter and display them. - Add a workaround for a Haswell issue that it reports an extra LBR record for every abort. We just filter those out in the kernel. Open perf TSX issues left: - Revisit automatic enabling of precise for tx/el-abort - Need to fix the sort handling in the user tools to actually sort on other fields - The aggregated LBR display in the user tools is not very useful for transactions, need a way to report them in a histogram like backtraces. - May want some shortcut options for record --transaction --weight / report --sort symbol,transaction,weight -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
perf, x86: Add last TSX PMU code for Haswell v3
[This has kernel and user parts. Both sides have been reviewed now, so hopefully it's good to merge.] [v2: Address Peter's feedback for the kernel parts] [v3: Rebased to current tip. Added Ack/Reviewed-by for user tools code] Note this also needs the separately posted 64bit comparison fix to correctly report abort codes. This is currently the last part of the TSX PMU code, just adding the left over bits: This adds some changes to the user interfaces. I'll send patches for the manpage separately. - Report the transaction abort flags to user space using a new field, and add the code to display them. This is used to classify abort types, also fairly important for tuning as it guides the tuning process, together with the abort weight that was added earleir. [3 patches, generic, x86, user tools] - Add support for reporting the two new TSX LBR flags: in_tx and abort_tx. The code to handle the LBRs was already added earlier, this just adds the code to report, filter and display them. - Add a workaround for a Haswell issue that it reports an extra LBR record for every abort. We just filter those out in the kernel. Open perf TSX issues left: - Revisit automatic enabling of precise for tx/el-abort - Need to fix the sort handling in the user tools to actually sort on other fields - The aggregated LBR display in the user tools is not very useful for transactions, need a way to report them in a histogram like backtraces. - May want some shortcut options for record --transaction --weight / report --sort symbol,transaction,weight -Andi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
