Re: question about periodic clocks

2007-03-10 Thread Thomas Gleixner
On Fri, 2007-03-09 at 15:26 -0800, Jeremy Fitzhardinge wrote: How does the clock period get set on periodic timers? In my clock driver, I'm seeing a call to -set_mode(CLOCK_EVT_MODE_PERIODIC, evt), but then... nothing. I was expecting a call to set_next_event to set the timer period. Good

Re: question about periodic clocks

2007-03-10 Thread Jeremy Fitzhardinge
Thomas Gleixner wrote: Good point. I never thought about that and we set the period in the clock event device itself. You are right, the clockevents layer should hand over the period either with the set_mode call or seperately. Probably with the set_mode call, as it is needed exactly there and

Re: question about periodic clocks

2007-03-10 Thread Thomas Gleixner
On Sat, 2007-03-10 at 07:50 -0800, Jeremy Fitzhardinge wrote: Thomas Gleixner wrote: Good point. I never thought about that and we set the period in the clock event device itself. You are right, the clockevents layer should hand over the period either with the set_mode call or seperately.

Re: question about periodic clocks

2007-03-10 Thread Jeremy Fitzhardinge
Thomas Gleixner wrote: Uuurg. That's ugly. clockevents expect a per CPU timer especially for dynamic ticks. If you cannot provide a per cpu timer, then you probably need to use the broadcast trick. Ah, apologies, I'm wrong about this. I misread the Xen code; the timers are per-vcpu, but

question about periodic clocks

2007-03-09 Thread Jeremy Fitzhardinge
How does the clock period get set on periodic timers? In my clock driver, I'm seeing a call to -set_mode(CLOCK_EVT_MODE_PERIODIC, evt), but then... nothing. I was expecting a call to set_next_event to set the timer period. The calltrace is: #0 xen_new_set_mode (mode=CLOCK_EVT_MODE_PERIODIC,