Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

2017-04-23 Thread SF Markus Elfring
>> Its implementation of the check “ALLOC_WITH_MULTIPLY” considers only an other >> search pattern so far. >> >> * Do you find it worthwhile to add a prefix like “devm_” to the used >> regular expression? >> >> * Would like to improve any related scripts for the semantic patch language >>

Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

2017-04-23 Thread SF Markus Elfring
>> Its implementation of the check “ALLOC_WITH_MULTIPLY” considers only an other >> search pattern so far. >> >> * Do you find it worthwhile to add a prefix like “devm_” to the used >> regular expression? >> >> * Would like to improve any related scripts for the semantic patch language >>

Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

2017-04-23 Thread Tobias Jakobi
SF Markus Elfring wrote: >>> WARNING: Prefer devm_kcalloc over devm_kzalloc with multiply >> For example. Also I just noticed some previous comment by Krzysztof that >> pointed that out already. >> >> My suggestion: One sentence describing that the current situation is. > > Why do you find the

Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

2017-04-23 Thread Tobias Jakobi
SF Markus Elfring wrote: >>> WARNING: Prefer devm_kcalloc over devm_kzalloc with multiply >> For example. Also I just noticed some previous comment by Krzysztof that >> pointed that out already. >> >> My suggestion: One sentence describing that the current situation is. > > Why do you find the

Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

2017-04-23 Thread SF Markus Elfring
>> WARNING: Prefer devm_kcalloc over devm_kzalloc with multiply > For example. Also I just noticed some previous comment by Krzysztof that > pointed that out already. > > My suggestion: One sentence describing that the current situation is. Why do you find the sentence for the multiplication

Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

2017-04-23 Thread SF Markus Elfring
>> WARNING: Prefer devm_kcalloc over devm_kzalloc with multiply > For example. Also I just noticed some previous comment by Krzysztof that > pointed that out already. > > My suggestion: One sentence describing that the current situation is. Why do you find the sentence for the multiplication

Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

2017-04-23 Thread Tobias Jakobi
SF Markus Elfring wrote: >>> * A multiplication for the size determination of a memory allocation >>> indicated that an array data structure should be processed. >>> Thus use the corresponding function "devm_kcalloc". >> I have trouble parsing that sentences. This looks like the typical >>

Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

2017-04-23 Thread Tobias Jakobi
SF Markus Elfring wrote: >>> * A multiplication for the size determination of a memory allocation >>> indicated that an array data structure should be processed. >>> Thus use the corresponding function "devm_kcalloc". >> I have trouble parsing that sentences. This looks like the typical >>

Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

2017-04-23 Thread SF Markus Elfring
>> * A multiplication for the size determination of a memory allocation >> indicated that an array data structure should be processed. >> Thus use the corresponding function "devm_kcalloc". > I have trouble parsing that sentences. This looks like the typical > approach of native german

Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

2017-04-23 Thread SF Markus Elfring
>> * A multiplication for the size determination of a memory allocation >> indicated that an array data structure should be processed. >> Thus use the corresponding function "devm_kcalloc". > I have trouble parsing that sentences. This looks like the typical > approach of native german

Re: [PATCH 1/2] dmaengine: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

2017-04-23 Thread Tobias Jakobi
Hello Markus, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 22 Apr 2017 23:00:23 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the

Re: [PATCH 1/2] dmaengine: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

2017-04-23 Thread Tobias Jakobi
Hello Markus, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 22 Apr 2017 23:00:23 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "devm_kcalloc".

[PATCH 1/2] dmaengine: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

2017-04-22 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 22 Apr 2017 23:00:23 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "devm_kcalloc". * Replace the

[PATCH 1/2] dmaengine: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

2017-04-22 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 22 Apr 2017 23:00:23 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "devm_kcalloc". * Replace the specification of a data structure by