Re: scripts/basic/fixdep: Complete error handling in print_cmdline()

Dne 2.11.2016 v 19:30 Masahiro Yamada napsal(a): > 2016-11-03 2:38 GMT+09:00 SF Markus Elfring : > + if (printf("cmd_%s := %s\n\n", target, cmdline) < 10) { Rather than scatter fragile magic numbers, like 10, throughout the code, if you're

Re: scripts/basic/fixdep: Complete error handling in print_cmdline()

Dne 2.11.2016 v 19:30 Masahiro Yamada napsal(a): > 2016-11-03 2:38 GMT+09:00 SF Markus Elfring : > + if (printf("cmd_%s := %s\n\n", target, cmdline) < 10) { Rather than scatter fragile magic numbers, like 10, throughout the code, if you're hell-bent on checking for printf

Re: scripts/basic/fixdep: Complete error handling in print_cmdline()

2016-11-03 2:38 GMT+09:00 SF Markus Elfring : + if (printf("cmd_%s := %s\n\n", target, cmdline) < 10) { >>> >>> Rather than scatter fragile magic numbers, like 10, throughout the >>> code, if you're hell-bent on checking for printf errors you could >>>

Re: scripts/basic/fixdep: Complete error handling in print_cmdline()

2016-11-03 2:38 GMT+09:00 SF Markus Elfring : + if (printf("cmd_%s := %s\n\n", target, cmdline) < 10) { >>> >>> Rather than scatter fragile magic numbers, like 10, throughout the >>> code, if you're hell-bent on checking for printf errors you could >>> write a little wrapper function

Re: scripts/basic/fixdep: Complete error handling in print_cmdline()

>>> + if (printf("cmd_%s := %s\n\n", target, cmdline) < 10) { >> >> Rather than scatter fragile magic numbers, like 10, throughout the >> code, if you're hell-bent on checking for printf errors you could >> write a little wrapper function that hid the magic number and bundled >> up the errno

Re: scripts/basic/fixdep: Complete error handling in print_cmdline()

>>> + if (printf("cmd_%s := %s\n\n", target, cmdline) < 10) { >> >> Rather than scatter fragile magic numbers, like 10, throughout the >> code, if you're hell-bent on checking for printf errors you could >> write a little wrapper function that hid the magic number and bundled >> up the errno

Re: [PATCH 09/10] scripts/basic/fixdep: Complete error handling in print_cmdline()

2016-10-29 8:42 GMT+09:00 Jim Davis : > On Fri, Oct 28, 2016 at 1:40 AM, SF Markus Elfring > wrote: > >> + if (printf("cmd_%s := %s\n\n", target, cmdline) < 10) { > > Rather than scatter fragile magic numbers, like 10, throughout the >

Re: [PATCH 09/10] scripts/basic/fixdep: Complete error handling in print_cmdline()

2016-10-29 8:42 GMT+09:00 Jim Davis : > On Fri, Oct 28, 2016 at 1:40 AM, SF Markus Elfring > wrote: > >> + if (printf("cmd_%s := %s\n\n", target, cmdline) < 10) { > > Rather than scatter fragile magic numbers, like 10, throughout the > code, if you're hell-bent on checking for printf errors

Re: scripts/basic/fixdep: Complete error handling in print_cmdline()

> But what would you expect printf error checking to tell a user? I wonder that the error detection and corresponding exception handling was not corrected for the affected source files of build-time tools so far.

Re: scripts/basic/fixdep: Complete error handling in print_cmdline()

> But what would you expect printf error checking to tell a user? I wonder that the error detection and corresponding exception handling was not corrected for the affected source files of build-time tools so far.

Re: [PATCH 09/10] scripts/basic/fixdep: Complete error handling in print_cmdline()

On Fri, Oct 28, 2016 at 1:40 AM, SF Markus Elfring wrote: > + if (printf("cmd_%s := %s\n\n", target, cmdline) < 10) { Rather than scatter fragile magic numbers, like 10, throughout the code, if you're hell-bent on checking for printf errors you could write a

Re: [PATCH 09/10] scripts/basic/fixdep: Complete error handling in print_cmdline()

On Fri, Oct 28, 2016 at 1:40 AM, SF Markus Elfring wrote: > + if (printf("cmd_%s := %s\n\n", target, cmdline) < 10) { Rather than scatter fragile magic numbers, like 10, throughout the code, if you're hell-bent on checking for printf errors you could write a little wrapper function that

[PATCH 09/10] scripts/basic/fixdep: Complete error handling in print_cmdline()

From: Markus Elfring Date: Fri, 28 Oct 2016 09:29:59 +0200 A return value was not checked from a call of the function "printf". This issue was detected also by using the Coccinelle software. Add a bit of exception handling there. Signed-off-by: Markus Elfring

[PATCH 09/10] scripts/basic/fixdep: Complete error handling in print_cmdline()

From: Markus Elfring Date: Fri, 28 Oct 2016 09:29:59 +0200 A return value was not checked from a call of the function "printf". This issue was detected also by using the Coccinelle software. Add a bit of exception handling there. Signed-off-by: Markus Elfring --- scripts/basic/fixdep.c | 7