[PATCH V2 1/9] scsi: ufs: add support for query requests

2013-05-14 Thread Dolev Raviv
Add support for sending UFS query requests through tagged command queuing. This design allows queuing query requests in any open slot along with other SCSI commands. In this way there is no need to save a slot in the requests queue and decrease its size. A query request is posing to a SCSI

[PATCH V2 1/9] scsi: ufs: add support for query requests

2013-05-14 Thread Dolev Raviv
Add support for sending UFS query requests through tagged command queuing. This design allows queuing query requests in any open slot along with other SCSI commands. In this way there is no need to save a slot in the requests queue and decrease its size. A query request is posing to a SCSI

[PATCH V5] scsi: ufs: add support for query requests

2013-05-05 Thread Dolev Raviv
Add support for sending UFS query requests through tagged command queuing. This design allows queuing query requests in any open slot along with other SCSI commands. In this way there is no need to save a slot in the requests queue and decrease its size. A query request is posing to a SCSI

[PATCH V5] scsi: ufs: add support for query requests

2013-05-05 Thread Dolev Raviv
Add support for sending UFS query requests through tagged command queuing. This design allows queuing query requests in any open slot along with other SCSI commands. In this way there is no need to save a slot in the requests queue and decrease its size. A query request is posing to a SCSI

Re: [PATCH V4] scsi: ufs: add support for query requests

2013-05-02 Thread Santosh Y
> + > +/** > + * ufshcd_compose_upiu - form UFS Protocol Information Unit(UPIU) > + * @hba - UFS hba > + * @lrb - pointer to local reference block > + */ > +static int ufshcd_compose_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp) > +{ > + u32 upiu_flags; > + int ret = 0; > + > +

Re: [PATCH V4] scsi: ufs: add support for query requests

2013-05-02 Thread Santosh Y
+ +/** + * ufshcd_compose_upiu - form UFS Protocol Information Unit(UPIU) + * @hba - UFS hba + * @lrb - pointer to local reference block + */ +static int ufshcd_compose_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp) +{ + u32 upiu_flags; + int ret = 0; + + switch

[PATCH V4] scsi: ufs: add support for query requests

2013-05-01 Thread Dolev Raviv
Add support for sending UFS query requests through tagged command queuing. This design allows queuing query requests in any open slot along with other SCSI commands. In this way there is no need to save a slot in the requests queue and decrease its size. A query request is posing to a SCSI

[PATCH V4] scsi: ufs: add support for query requests

2013-05-01 Thread Dolev Raviv
Add support for sending UFS query requests through tagged command queuing. This design allows queuing query requests in any open slot along with other SCSI commands. In this way there is no need to save a slot in the requests queue and decrease its size. A query request is posing to a SCSI

[PATCH V3] scsi: ufs: add support for query requests

2013-04-25 Thread Dolev Raviv
Add support for sending UFS query requests through tagged command queuing. This design allows queuing query requests in any open slot along with other SCSI commands. In this way there is no need to save a slot in the requests queue and decrease its size. A query request is posing to a SCSI

[PATCH V3] scsi: ufs: add support for query requests

2013-04-25 Thread Dolev Raviv
Add support for sending UFS query requests through tagged command queuing. This design allows queuing query requests in any open slot along with other SCSI commands. In this way there is no need to save a slot in the requests queue and decrease its size. A query request is posing to a SCSI

Re: [PATCH V2] scsi: ufs: add support for query requests

2013-04-21 Thread Santosh Y
> + * ufshcd_compose_upiu - form UFS Protocol Information Unit(UPIU) > + * @hba - UFS hba > + * @lrb - pointer to local reference block > + */ > +static int ufshcd_compose_upiu(struct ufs_hba *hba, struct ufshcd_lrb > *lrbp) > +{ > + u32 upiu_flags; > + int ret = 0; > + > + if

Re: [PATCH V2] scsi: ufs: add support for query requests

2013-04-21 Thread Santosh Y
+ * ufshcd_compose_upiu - form UFS Protocol Information Unit(UPIU) + * @hba - UFS hba + * @lrb - pointer to local reference block + */ +static int ufshcd_compose_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp) +{ + u32 upiu_flags; + int ret = 0; + + if (!lrbp) { +

Re: [PATCH V2] scsi: ufs: add support for query requests

2013-04-18 Thread Dolev Raviv
Hi All, A minor bug was spotted, as shown blow. The fix will be submitted with the next version. > +static int ufshcd_compose_upiu(struct ufs_hba *hba, struct ufshcd_lrb > *lrbp) > +{ > + u32 upiu_flags; > + int ret = 0; > + > + if (!lrbp) { > + dev_err(hba->dev, "%s:

Re: [PATCH V2] scsi: ufs: add support for query requests

2013-04-18 Thread Dolev Raviv
Hi All, A minor bug was spotted, as shown blow. The fix will be submitted with the next version. +static int ufshcd_compose_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp) +{ + u32 upiu_flags; + int ret = 0; + + if (!lrbp) { + dev_err(hba-dev, %s: lrbp can not

[PATCH V2] scsi: ufs: add support for query requests

2013-04-15 Thread Dolev Raviv
Add support for sending UFS query requests through tagged command queuing. This design allows queuing query requests in any open slot along with other SCSI commands. In this way there is no need to save a slot in the requests queue and decrease its size. A query request is posing to a SCSI

Re: scsi: ufs: add support for query requests

2013-04-15 Thread Dolev Raviv
Santosh, thank you very much for your comments. Most where adopted, others where replied inline. Please note the comment on removing ufs_coe.c file. I will appreciated your opinion on that. > linux-...@vger.kernel.org is for UFS filesystem. > >> The API for submitting a query request is

Re: scsi: ufs: add support for query requests

2013-04-15 Thread Dolev Raviv
Santosh, thank you very much for your comments. Most where adopted, others where replied inline. Please note the comment on removing ufs_coe.c file. I will appreciated your opinion on that. linux-...@vger.kernel.org is for UFS filesystem. The API for submitting a query request is

[PATCH V2] scsi: ufs: add support for query requests

2013-04-15 Thread Dolev Raviv
Add support for sending UFS query requests through tagged command queuing. This design allows queuing query requests in any open slot along with other SCSI commands. In this way there is no need to save a slot in the requests queue and decrease its size. A query request is posing to a SCSI

Re: scsi: ufs: add support for query requests

2013-04-10 Thread Santosh Y
> > This can be done inside the following if condition i.e. if > (hba->query.descriptor != NULL). > and change the condition to if (!hba->query.descriptor). > I meant to write if (hba->query.descriptor)...:-) -- ~Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: scsi: ufs: add support for query requests

2013-04-10 Thread Santosh Y
linux-...@vger.kernel.org is for UFS filesystem. > The API for submitting a query request is ufs_query_request() in > ufs_core.c. This function is responsible for: This can be part of ufshcd.c which is actually the core file, no need to create a new core file for the function. > + > +#define

Re: scsi: ufs: add support for query requests

2013-04-10 Thread Santosh Y
linux-...@vger.kernel.org is for UFS filesystem. The API for submitting a query request is ufs_query_request() in ufs_core.c. This function is responsible for: This can be part of ufshcd.c which is actually the core file, no need to create a new core file for the function. + +#define

Re: scsi: ufs: add support for query requests

2013-04-10 Thread Santosh Y
This can be done inside the following if condition i.e. if (hba-query.descriptor != NULL). and change the condition to if (!hba-query.descriptor). I meant to write if (hba-query.descriptor)...:-) -- ~Santosh -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the

[PATCH] scsi: ufs: add support for query requests

2013-04-09 Thread Dolev Raviv
Add support for sending UFS query requests through tagged command queuing. This design allows queuing query requests in any open slot along with other SCSI commands. In this way there is no need to save a slot in the requests queue and decrease its size. A query request is posing to a SCSI

[PATCH] scsi: ufs: add support for query requests

2013-04-09 Thread Dolev Raviv
Add support for sending UFS query requests through tagged command queuing. This design allows queuing query requests in any open slot along with other SCSI commands. In this way there is no need to save a slot in the requests queue and decrease its size. A query request is posing to a SCSI