Re: sysfs_drop_dentry(): possible NULL dereference

2007-03-19 Thread Oliver Neukum
Am Montag, 19. März 2007 10:22 schrieb Adrian Bunk: > void sysfs_drop_dentry(struct sysfs_dirent * sd, struct dentry * parent) > { > struct dentry * dentry = sd->s_dentry; > + struct inode *inode; > > if (dentry) { > spin_lock(_lock); >

sysfs_drop_dentry(): possible NULL dereference

2007-03-19 Thread Adrian Bunk
The Coverity checker spotted the following incorrect part of commit 94bebf4d1b8e7719f0f3944c037a21cfd99a4af7: <-- snip --> ... void sysfs_drop_dentry(struct sysfs_dirent * sd, struct dentry * parent) { struct dentry * dentry = sd->s_dentry; + struct inode *inode; if

sysfs_drop_dentry(): possible NULL dereference

2007-03-19 Thread Adrian Bunk
The Coverity checker spotted the following incorrect part of commit 94bebf4d1b8e7719f0f3944c037a21cfd99a4af7: -- snip -- ... void sysfs_drop_dentry(struct sysfs_dirent * sd, struct dentry * parent) { struct dentry * dentry = sd-s_dentry; + struct inode *inode; if

Re: sysfs_drop_dentry(): possible NULL dereference

2007-03-19 Thread Oliver Neukum
Am Montag, 19. März 2007 10:22 schrieb Adrian Bunk: void sysfs_drop_dentry(struct sysfs_dirent * sd, struct dentry * parent) { struct dentry * dentry = sd-s_dentry; + struct inode *inode; if (dentry) { spin_lock(dcache_lock);