Re: upstream test error: BUG: using smp_processor_id() in preemptible code in ext4_mb_new_blocks

2020-06-13 Thread Greg KH
On Fri, Jun 12, 2020 at 10:20:35PM +0530, Ritesh Harjani wrote:
> > I am seeing this all over the place on Linus's tree right now:
> > 
> > [  +0.008563] BUG: using smp_processor_id() in preemptible [] code: 
> > systemd/1
> > [  +0.11] caller is ext4_mb_new_blocks+0x2ac/0xc10
> > [  +0.02] CPU: 31 PID: 1 Comm: systemd Not tainted 
> > 5.7.0-14371-g25ae6195a4c7 #66
> > [  +0.02] Hardware name: Micro-Star International Co., Ltd. 
> > MS-7C59/Creator TRX40 (MS-7C59), BIOS 1.50 05/13/2020
> > [  +0.01] Call Trace:
> > [  +0.08]  dump_stack+0x57/0x70
> > [  +0.04]  debug_smp_processor_id.cold+0x4e/0x53
> > [  +0.01]  ext4_mb_new_blocks+0x2ac/0xc10
> > [  +0.04]  ? ext4_find_extent+0x3e8/0x450
> > [  +0.02]  ext4_ext_map_blocks+0x9f6/0x1b10
> > [  +0.03]  ? ext4_mark_iloc_dirty+0x60f/0xa50
> > [  +0.03]  ? __ext4_journal_get_write_access+0x2d/0x70
> > [  +0.04]  ext4_map_blocks+0x119/0x5a0
> > [  +0.04]  ext4_getblk+0x66/0x1c0
> > [  +0.03]  ext4_bread+0x26/0xc0
> > [  +0.02]  ext4_append+0x49/0xe0
> > [  +0.02]  ext4_mkdir+0x233/0x450
> > [  +0.05]  vfs_mkdir+0x11d/0x1b0
> > [  +0.03]  do_mkdirat+0x92/0x130
> > [  +0.04]  do_syscall_64+0x43/0x80
> > [  +0.04]  entry_SYSCALL_64_after_hwframe+0x44/0xa9
> > [  +0.03] RIP: 0033:0x7fef3df7a72b
> > [  +0.01] Code: Bad RIP value.
> > [  +0.01] RSP: 002b:7ffdb4eba0c8 EFLAGS: 0246 ORIG_RAX: 
> > 0053
> > [  +0.03] RAX: ffda RBX: 0001 RCX: 
> > 7fef3df7a72b
> > [  +0.01] RDX:  RSI: 01c0 RDI: 
> > 563b11cf26e0
> > [  +0.01] RBP: 563b11cf2731 R08: 000d R09: 
> > 0002
> > [  +0.00] R10: 11175e4331068ed5 R11: 0246 R12: 
> > 563b11cf26e0
> > [  +0.02] R13: 7fef3e019c20 R14: 7ffdb4eba0f0 R15: 
> > 8421084210842109
> > 
> > Just a constant stream of them.
> > 
> > There's a few other fun:
> > 
> > [  +0.453222] BUG: unable to handle page fault for address: b59cc2719000
> > [  +0.04] #PF: supervisor write access in kernel mode
> > [  +0.01] #PF: error_code(0x000b) - reserved bit violation
> > 
> > messages at times, but I don't think that's an ext4 issue, but rather
> > something in the sound stack...
> > 
> > EXT4 developers, any hints/patches to try?
> > 
> 
> Below patch should fix the ext4 issue coming from ext4_mb_new_blocks().
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git/commit/?h=dev=811985365378df01386c3cfb7ff716e74ca376d5

Thanks, that should work, I'll try it out on Monday.

greg k-h


Re: upstream test error: BUG: using smp_processor_id() in preemptible code in ext4_mb_new_blocks

2020-06-12 Thread Ritesh Harjani

I am seeing this all over the place on Linus's tree right now:

[  +0.008563] BUG: using smp_processor_id() in preemptible [] code: 
systemd/1
[  +0.11] caller is ext4_mb_new_blocks+0x2ac/0xc10
[  +0.02] CPU: 31 PID: 1 Comm: systemd Not tainted 
5.7.0-14371-g25ae6195a4c7 #66
[  +0.02] Hardware name: Micro-Star International Co., Ltd. MS-7C59/Creator 
TRX40 (MS-7C59), BIOS 1.50 05/13/2020
[  +0.01] Call Trace:
[  +0.08]  dump_stack+0x57/0x70
[  +0.04]  debug_smp_processor_id.cold+0x4e/0x53
[  +0.01]  ext4_mb_new_blocks+0x2ac/0xc10
[  +0.04]  ? ext4_find_extent+0x3e8/0x450
[  +0.02]  ext4_ext_map_blocks+0x9f6/0x1b10
[  +0.03]  ? ext4_mark_iloc_dirty+0x60f/0xa50
[  +0.03]  ? __ext4_journal_get_write_access+0x2d/0x70
[  +0.04]  ext4_map_blocks+0x119/0x5a0
[  +0.04]  ext4_getblk+0x66/0x1c0
[  +0.03]  ext4_bread+0x26/0xc0
[  +0.02]  ext4_append+0x49/0xe0
[  +0.02]  ext4_mkdir+0x233/0x450
[  +0.05]  vfs_mkdir+0x11d/0x1b0
[  +0.03]  do_mkdirat+0x92/0x130
[  +0.04]  do_syscall_64+0x43/0x80
[  +0.04]  entry_SYSCALL_64_after_hwframe+0x44/0xa9
[  +0.03] RIP: 0033:0x7fef3df7a72b
[  +0.01] Code: Bad RIP value.
[  +0.01] RSP: 002b:7ffdb4eba0c8 EFLAGS: 0246 ORIG_RAX: 
0053
[  +0.03] RAX: ffda RBX: 0001 RCX: 7fef3df7a72b
[  +0.01] RDX:  RSI: 01c0 RDI: 563b11cf26e0
[  +0.01] RBP: 563b11cf2731 R08: 000d R09: 0002
[  +0.00] R10: 11175e4331068ed5 R11: 0246 R12: 563b11cf26e0
[  +0.02] R13: 7fef3e019c20 R14: 7ffdb4eba0f0 R15: 8421084210842109

Just a constant stream of them.

There's a few other fun:

[  +0.453222] BUG: unable to handle page fault for address: b59cc2719000
[  +0.04] #PF: supervisor write access in kernel mode
[  +0.01] #PF: error_code(0x000b) - reserved bit violation

messages at times, but I don't think that's an ext4 issue, but rather
something in the sound stack...

EXT4 developers, any hints/patches to try?



Below patch should fix the ext4 issue coming from ext4_mb_new_blocks().

https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git/commit/?h=dev=811985365378df01386c3cfb7ff716e74ca376d5

Not sure about the second one though.

-ritesh



Re: upstream test error: BUG: using smp_processor_id() in preemptible code in ext4_mb_new_blocks

2020-06-12 Thread Greg KH
On Tue, Jun 09, 2020 at 06:48:13PM -0700, syzbot wrote:
> Hello,
> 
> syzbot found the following crash on:
> 
> HEAD commit:5b14671b Merge tag 'fuse-update-5.8' of git://git.kernel.o..
> git tree:   upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=12a11ec110
> kernel config:  https://syzkaller.appspot.com/x/.config?x=d1ea633f7958e008
> dashboard link: https://syzkaller.appspot.com/bug?extid=0113b9be6667b5b50840
> compiler:   gcc (GCC) 9.0.0 20181231 (experimental)
> 
> IMPORTANT: if you fix the bug, please add the following tag to the commit:
> Reported-by: syzbot+0113b9be6667b5b50...@syzkaller.appspotmail.com
> 
> BUG: using smp_processor_id() in preemptible [] code: 
> systemd-rfkill/6740
> caller is ext4_mb_new_blocks+0xa77/0x3b30 fs/ext4/mballoc.c:4711
> CPU: 0 PID: 6740 Comm: systemd-rfkill Not tainted 5.7.0-syzkaller #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS 
> Google 01/01/2011
> Call Trace:
>  __dump_stack lib/dump_stack.c:77 [inline]
>  dump_stack+0x18f/0x20d lib/dump_stack.c:118
>  check_preemption_disabled lib/smp_processor_id.c:47 [inline]
>  debug_smp_processor_id.cold+0x88/0x9b lib/smp_processor_id.c:57
>  ext4_mb_new_blocks+0xa77/0x3b30 fs/ext4/mballoc.c:4711
>  ext4_ext_map_blocks+0x2044/0x3410 fs/ext4/extents.c:4244
>  ext4_map_blocks+0x4cb/0x1640 fs/ext4/inode.c:626
>  ext4_getblk+0xad/0x520 fs/ext4/inode.c:833
>  ext4_bread+0x7c/0x380 fs/ext4/inode.c:883
>  ext4_append+0x153/0x360 fs/ext4/namei.c:67
>  ext4_init_new_dir fs/ext4/namei.c:2757 [inline]
>  ext4_mkdir+0x5e0/0xdf0 fs/ext4/namei.c:2802
>  vfs_mkdir+0x419/0x690 fs/namei.c:3641
>  do_mkdirat+0x21e/0x280 fs/namei.c:3664
>  do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:295
>  entry_SYSCALL_64_after_hwframe+0x49/0xb3
> RIP: 0033:0x7f449ff49687
> Code: Bad RIP value.
> RSP: 002b:7ffdd3b9fe58 EFLAGS: 0246 ORIG_RAX: 0053
> RAX: ffda RBX: 5567752fd985 RCX: 7f449ff49687
> RDX: 7ffdd3b9fd20 RSI: 01ed RDI: 5567752fd985
> RBP: 7f449ff49680 R08: 0100 R09: 
> R10: 5567752fd980 R11: 0246 R12: 01ed
> R13: 7ffdd3b9ffe0 R14:  R15: 

I am seeing this all over the place on Linus's tree right now:

[  +0.008563] BUG: using smp_processor_id() in preemptible [] code: 
systemd/1
[  +0.11] caller is ext4_mb_new_blocks+0x2ac/0xc10
[  +0.02] CPU: 31 PID: 1 Comm: systemd Not tainted 
5.7.0-14371-g25ae6195a4c7 #66
[  +0.02] Hardware name: Micro-Star International Co., Ltd. MS-7C59/Creator 
TRX40 (MS-7C59), BIOS 1.50 05/13/2020
[  +0.01] Call Trace:
[  +0.08]  dump_stack+0x57/0x70
[  +0.04]  debug_smp_processor_id.cold+0x4e/0x53
[  +0.01]  ext4_mb_new_blocks+0x2ac/0xc10
[  +0.04]  ? ext4_find_extent+0x3e8/0x450
[  +0.02]  ext4_ext_map_blocks+0x9f6/0x1b10
[  +0.03]  ? ext4_mark_iloc_dirty+0x60f/0xa50
[  +0.03]  ? __ext4_journal_get_write_access+0x2d/0x70
[  +0.04]  ext4_map_blocks+0x119/0x5a0
[  +0.04]  ext4_getblk+0x66/0x1c0
[  +0.03]  ext4_bread+0x26/0xc0
[  +0.02]  ext4_append+0x49/0xe0
[  +0.02]  ext4_mkdir+0x233/0x450
[  +0.05]  vfs_mkdir+0x11d/0x1b0
[  +0.03]  do_mkdirat+0x92/0x130
[  +0.04]  do_syscall_64+0x43/0x80
[  +0.04]  entry_SYSCALL_64_after_hwframe+0x44/0xa9
[  +0.03] RIP: 0033:0x7fef3df7a72b
[  +0.01] Code: Bad RIP value.
[  +0.01] RSP: 002b:7ffdb4eba0c8 EFLAGS: 0246 ORIG_RAX: 
0053
[  +0.03] RAX: ffda RBX: 0001 RCX: 7fef3df7a72b
[  +0.01] RDX:  RSI: 01c0 RDI: 563b11cf26e0
[  +0.01] RBP: 563b11cf2731 R08: 000d R09: 0002
[  +0.00] R10: 11175e4331068ed5 R11: 0246 R12: 563b11cf26e0
[  +0.02] R13: 7fef3e019c20 R14: 7ffdb4eba0f0 R15: 8421084210842109

Just a constant stream of them.

There's a few other fun:

[  +0.453222] BUG: unable to handle page fault for address: b59cc2719000
[  +0.04] #PF: supervisor write access in kernel mode
[  +0.01] #PF: error_code(0x000b) - reserved bit violation

messages at times, but I don't think that's an ext4 issue, but rather
something in the sound stack...

EXT4 developers, any hints/patches to try?

thanks,

greg k-h


upstream test error: BUG: using smp_processor_id() in preemptible code in ext4_mb_new_blocks

2020-06-09 Thread syzbot
Hello,

syzbot found the following crash on:

HEAD commit:5b14671b Merge tag 'fuse-update-5.8' of git://git.kernel.o..
git tree:   upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=12a11ec110
kernel config:  https://syzkaller.appspot.com/x/.config?x=d1ea633f7958e008
dashboard link: https://syzkaller.appspot.com/bug?extid=0113b9be6667b5b50840
compiler:   gcc (GCC) 9.0.0 20181231 (experimental)

IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+0113b9be6667b5b50...@syzkaller.appspotmail.com

BUG: using smp_processor_id() in preemptible [] code: 
systemd-rfkill/6740
caller is ext4_mb_new_blocks+0xa77/0x3b30 fs/ext4/mballoc.c:4711
CPU: 0 PID: 6740 Comm: systemd-rfkill Not tainted 5.7.0-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 
01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x18f/0x20d lib/dump_stack.c:118
 check_preemption_disabled lib/smp_processor_id.c:47 [inline]
 debug_smp_processor_id.cold+0x88/0x9b lib/smp_processor_id.c:57
 ext4_mb_new_blocks+0xa77/0x3b30 fs/ext4/mballoc.c:4711
 ext4_ext_map_blocks+0x2044/0x3410 fs/ext4/extents.c:4244
 ext4_map_blocks+0x4cb/0x1640 fs/ext4/inode.c:626
 ext4_getblk+0xad/0x520 fs/ext4/inode.c:833
 ext4_bread+0x7c/0x380 fs/ext4/inode.c:883
 ext4_append+0x153/0x360 fs/ext4/namei.c:67
 ext4_init_new_dir fs/ext4/namei.c:2757 [inline]
 ext4_mkdir+0x5e0/0xdf0 fs/ext4/namei.c:2802
 vfs_mkdir+0x419/0x690 fs/namei.c:3641
 do_mkdirat+0x21e/0x280 fs/namei.c:3664
 do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:295
 entry_SYSCALL_64_after_hwframe+0x49/0xb3
RIP: 0033:0x7f449ff49687
Code: Bad RIP value.
RSP: 002b:7ffdd3b9fe58 EFLAGS: 0246 ORIG_RAX: 0053
RAX: ffda RBX: 5567752fd985 RCX: 7f449ff49687
RDX: 7ffdd3b9fd20 RSI: 01ed RDI: 5567752fd985
RBP: 7f449ff49680 R08: 0100 R09: 
R10: 5567752fd980 R11: 0246 R12: 01ed
R13: 7ffdd3b9ffe0 R14:  R15: 


---
This bug is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkal...@googlegroups.com.

syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.