Re: usbatm: printk_ratelimit() always called in the atm_rldbg()
On Sat, Oct 26, 2013 at 03:29:56PM +0200, Krzysztof Mazur wrote:
> Hi,
>
> commit 2d6401cf4ca3861692a4779745e0049cac769d10
> ("USB: usbatm: move the atm_dbg() call to use dynamic debug")
> changed the atm_rldbg() to:
>
> #define atm_rldbg(instance, format, arg...) \
> if (printk_ratelimit()) \
> atm_dbg(instance , format , ## arg)
>
> and now printk_ratelimit() is always called even when debugging is
> disabled and a lot of "callbacks suppressed" messages are printed
> by the printk_ratelimit():
>
> [...]
> usbatm_rx_process: 4977 callbacks suppressed
> usbatm_extract_one_cell: 2920 callbacks suppressed
> [...]
>
>
> I'm not sure how to fix that, maybe we need dynamic_pr_debug_ratelimit()?
How about just deleting the use of that macro entirely? Odds are it's
not really needed anymore, right?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
usbatm: printk_ratelimit() always called in the atm_rldbg()
Hi,
commit 2d6401cf4ca3861692a4779745e0049cac769d10
("USB: usbatm: move the atm_dbg() call to use dynamic debug")
changed the atm_rldbg() to:
#define atm_rldbg(instance, format, arg...) \
if (printk_ratelimit()) \
atm_dbg(instance , format , ## arg)
and now printk_ratelimit() is always called even when debugging is
disabled and a lot of "callbacks suppressed" messages are printed
by the printk_ratelimit():
[...]
usbatm_rx_process: 4977 callbacks suppressed
usbatm_extract_one_cell: 2920 callbacks suppressed
[...]
I'm not sure how to fix that, maybe we need dynamic_pr_debug_ratelimit()?
Krzysiek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
usbatm: printk_ratelimit() always called in the atm_rldbg()
Hi, commit 2d6401cf4ca3861692a4779745e0049cac769d10 (USB: usbatm: move the atm_dbg() call to use dynamic debug) changed the atm_rldbg() to: #define atm_rldbg(instance, format, arg...) \ if (printk_ratelimit()) \ atm_dbg(instance , format , ## arg) and now printk_ratelimit() is always called even when debugging is disabled and a lot of callbacks suppressed messages are printed by the printk_ratelimit(): [...] usbatm_rx_process: 4977 callbacks suppressed usbatm_extract_one_cell: 2920 callbacks suppressed [...] I'm not sure how to fix that, maybe we need dynamic_pr_debug_ratelimit()? Krzysiek -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: usbatm: printk_ratelimit() always called in the atm_rldbg()
On Sat, Oct 26, 2013 at 03:29:56PM +0200, Krzysztof Mazur wrote: Hi, commit 2d6401cf4ca3861692a4779745e0049cac769d10 (USB: usbatm: move the atm_dbg() call to use dynamic debug) changed the atm_rldbg() to: #define atm_rldbg(instance, format, arg...) \ if (printk_ratelimit()) \ atm_dbg(instance , format , ## arg) and now printk_ratelimit() is always called even when debugging is disabled and a lot of callbacks suppressed messages are printed by the printk_ratelimit(): [...] usbatm_rx_process: 4977 callbacks suppressed usbatm_extract_one_cell: 2920 callbacks suppressed [...] I'm not sure how to fix that, maybe we need dynamic_pr_debug_ratelimit()? How about just deleting the use of that macro entirely? Odds are it's not really needed anymore, right? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
