Re: x86 - clang / objtool status

2019-07-25 Thread Sedat Dilek
On Mon, Jul 22, 2019 at 5:40 PM Sedat Dilek wrote: > > On Fri, Jul 19, 2019 at 3:48 PM Sedat Dilek wrote: > > > > > First of all I find out that it is possible to download and apply the > > > series (here: v2) from patchwork (see [1]). > > > I highly appreciate to have this in Josh's Git [2]. >

Re: x86 - clang / objtool status

2019-07-24 Thread Nick Desaulniers
On Tue, Jul 23, 2019 at 7:43 PM Josh Poimboeuf wrote: > > On Thu, Jul 18, 2019 at 10:40:09PM +0200, Thomas Gleixner wrote: > > > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: > > .altinstr_replacement+0x86: redundant UACCESS disable > > Looking at this one, I think I agree

Re: x86 - clang / objtool status

2019-07-24 Thread Nick Desaulniers
On Thu, Jul 18, 2019 at 11:39 PM Thomas Gleixner wrote: > > On Thu, 18 Jul 2019, Nathan Chancellor wrote: > > > Hi Thomas, > > > > I can't comment on the objtool stuff as it is a bit outside of my area > > of expertise (probably going to be my next major learning project) but I > > can comment on

Re: x86 - clang / objtool status

2019-07-24 Thread Peter Zijlstra
On Tue, Jul 23, 2019 at 09:43:24PM -0500, Josh Poimboeuf wrote: > On Thu, Jul 18, 2019 at 10:40:09PM +0200, Thomas Gleixner wrote: > > > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: > > .altinstr_replacement+0x86: redundant UACCESS disable > > Looking at this one, I think

Re: x86 - clang / objtool status

2019-07-24 Thread Peter Zijlstra
On Wed, Jul 24, 2019 at 03:35:16PM +0200, Peter Zijlstra wrote: > On Wed, Jul 24, 2019 at 07:55:25AM -0500, Josh Poimboeuf wrote: > > b) why doesn't objtool detect the case I found? > > With GCC you mean? Yes, that is really really weird. > > Let me go stare at objdump output for this file

Re: x86 - clang / objtool status

2019-07-24 Thread Josh Poimboeuf
On Wed, Jul 24, 2019 at 03:35:16PM +0200, Peter Zijlstra wrote: > On Wed, Jul 24, 2019 at 07:55:25AM -0500, Josh Poimboeuf wrote: > > On Wed, Jul 24, 2019 at 09:47:32AM +0200, Peter Zijlstra wrote: > > > On Tue, Jul 23, 2019 at 09:43:24PM -0500, Josh Poimboeuf wrote: > > > > On Thu, Jul 18, 2019

Re: x86 - clang / objtool status

2019-07-24 Thread Peter Zijlstra
On Wed, Jul 24, 2019 at 07:55:25AM -0500, Josh Poimboeuf wrote: > On Wed, Jul 24, 2019 at 09:47:32AM +0200, Peter Zijlstra wrote: > > On Tue, Jul 23, 2019 at 09:43:24PM -0500, Josh Poimboeuf wrote: > > > On Thu, Jul 18, 2019 at 10:40:09PM +0200, Thomas Gleixner wrote: > > > > > > >

Re: x86 - clang / objtool status

2019-07-24 Thread Josh Poimboeuf
On Wed, Jul 24, 2019 at 09:47:32AM +0200, Peter Zijlstra wrote: > On Tue, Jul 23, 2019 at 09:43:24PM -0500, Josh Poimboeuf wrote: > > On Thu, Jul 18, 2019 at 10:40:09PM +0200, Thomas Gleixner wrote: > > > > > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: > > >

Re: x86 - clang / objtool status

2019-07-24 Thread Josh Poimboeuf
On Wed, Jul 24, 2019 at 09:47:32AM +0200, Peter Zijlstra wrote: > On Tue, Jul 23, 2019 at 09:43:24PM -0500, Josh Poimboeuf wrote: > > On Thu, Jul 18, 2019 at 10:40:09PM +0200, Thomas Gleixner wrote: > > > > > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: > > >

Re: x86 - clang / objtool status

2019-07-24 Thread Peter Zijlstra
On Tue, Jul 23, 2019 at 09:43:24PM -0500, Josh Poimboeuf wrote: > On Thu, Jul 18, 2019 at 10:40:09PM +0200, Thomas Gleixner wrote: > > > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: > > .altinstr_replacement+0x86: redundant UACCESS disable > > Looking at this one, I think

Re: x86 - clang / objtool status

2019-07-23 Thread Josh Poimboeuf
On Thu, Jul 18, 2019 at 10:40:09PM +0200, Thomas Gleixner wrote: > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: > .altinstr_replacement+0x86: redundant UACCESS disable Looking at this one, I think I agree with objtool. PeterZ, Linus, I know y'all discussed this code a

Re: x86 - clang / objtool status

2019-07-22 Thread Sedat Dilek
On Fri, Jul 19, 2019 at 3:48 PM Sedat Dilek wrote: > > > First of all I find out that it is possible to download and apply the > > series (here: v2) from patchwork (see [1]). > > I highly appreciate to have this in Josh's Git [2]. > > > > There it is. > > - sed@ - > > [1] >

Re: x86 - clang / objtool status

2019-07-19 Thread Sedat Dilek
> First of all I find out that it is possible to download and apply the > series (here: v2) from patchwork (see [1]). > I highly appreciate to have this in Josh's Git [2]. > There it is. - sed@ - [1]

Re: x86 - clang / objtool status

2019-07-19 Thread Nathan Chancellor
On Fri, Jul 19, 2019 at 08:39:00AM +0200, Thomas Gleixner wrote: > On Thu, 18 Jul 2019, Nathan Chancellor wrote: > > > Hi Thomas, > > > > I can't comment on the objtool stuff as it is a bit outside of my area > > of expertise (probably going to be my next major learning project) but I > > can

Re: x86 - clang / objtool status

2019-07-19 Thread Arnd Bergmann
On Fri, Jul 19, 2019 at 8:39 AM Thomas Gleixner wrote: > > On Thu, 18 Jul 2019, Nathan Chancellor wrote: > > > Hi Thomas, > > > > I can't comment on the objtool stuff as it is a bit outside of my area > > of expertise (probably going to be my next major learning project) but I > > can comment on

Re: x86 - clang / objtool status

2019-07-19 Thread Thomas Gleixner
On Thu, 18 Jul 2019, Nick Desaulniers wrote: > On Thu, Jul 18, 2019 at 1:40 PM Thomas Gleixner wrote: > > after picking up Josh's objtool updates I gave clang a test ride again. > > Thanks for testing and the reports; these are valuable and we > appreciate the help debugging them. > > > 2)

Re: x86 - clang / objtool status

2019-07-19 Thread Thomas Gleixner
On Thu, 18 Jul 2019, Nathan Chancellor wrote: > Hi Thomas, > > I can't comment on the objtool stuff as it is a bit outside of my area > of expertise (probably going to be my next major learning project) but I > can comment on the other errors. > > On Thu, Jul 18, 2019 at 10:40:09PM +0200,

Re: x86 - clang / objtool status

2019-07-18 Thread Nick Desaulniers
On Thu, Jul 18, 2019 at 1:40 PM Thomas Gleixner wrote: > after picking up Josh's objtool updates I gave clang a test ride again. Thanks for testing and the reports; these are valuable and we appreciate the help debugging them. > 2) debian distro config Is this checked into the tree, or where

Re: x86 - clang / objtool status

2019-07-18 Thread Nathan Chancellor
Hi Thomas, I can't comment on the objtool stuff as it is a bit outside of my area of expertise (probably going to be my next major learning project) but I can comment on the other errors. On Thu, Jul 18, 2019 at 10:40:09PM +0200, Thomas Gleixner wrote: > Build fails with: > > clang-10:

x86 - clang / objtool status

2019-07-18 Thread Thomas Gleixner
Folks, after picking up Josh's objtool updates I gave clang a test ride again. clan is built with https://github.com/ClangBuiltLinux/tc-build.git That's using the llvm master branch. top commit is: 0c99d19470b ("[OPENMP]Fix sharing of threadprivate variables with TLS support.") I merged