Re: zram: zsmalloc calls sleeping function from atomic context

2014-03-18 Thread Peter Zijlstra
On Mon, Mar 17, 2014 at 04:01:17PM -0700, Andrew Morton wrote: > btw, I note that vunmap() itself already has a might_sleep() in it, and > I can't work out why - I don't think it _does_ sleep. The changelog to > 34754b69a6f87aa6aa is, in toto: > > "x86: make vmap yell louder when it is used under

Re: zram: zsmalloc calls sleeping function from atomic context

2014-03-18 Thread David Vrabel
On 17/03/14 23:01, Andrew Morton wrote: > > OK, thanks. David, there's our atomic unmap and there are probably > others. Converting a previously-atomic utility function into one which > can sleep is going to be difficult. I think we should drop these patches. I think Fujitsu were doing somethi

Re: zram: zsmalloc calls sleeping function from atomic context

2014-03-17 Thread Andrew Morton
On Mon, 17 Mar 2014 17:43:58 +0300 Sergey Senozhatsky wrote: > Hello gents, > > I just noticed that starting from commit > > commit 3d693a5127e79e79da7c34dc0c776bc620697ce5 > Author: Andrew Morton > Date: Mon Mar 17 11:23:56 2014 +1100 > > mm-vmalloc-avoid-soft-lockup-warnings-when-vun

zram: zsmalloc calls sleeping function from atomic context

2014-03-17 Thread Sergey Senozhatsky
Hello gents, I just noticed that starting from commit commit 3d693a5127e79e79da7c34dc0c776bc620697ce5 Author: Andrew Morton Date: Mon Mar 17 11:23:56 2014 +1100 mm-vmalloc-avoid-soft-lockup-warnings-when-vunmaping-large-ranges-fix add a might_sleep() to catch atomic callers more