[PATCH] dev_dbg: check dev_dbg() arguments

2007-04-20 Thread Dan Williams
Duplicate what Zach Brown did for pr_debug in commit 8b2a1fd1b394c60eaa2587716102dd5e9b4e5990 Signed-off-by: Dan Williams [EMAIL PROTECTED] --- include/linux/device.h |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/include/linux/device.h b/include/linux/device.h

Re: 2.6.20.3 AMD64 oops in CFQ code

2007-03-22 Thread Dan Williams
On 3/22/07, Neil Brown [EMAIL PROTECTED] wrote: On Thursday March 22, [EMAIL PROTECTED] wrote: On Thu, Mar 22 2007, [EMAIL PROTECTED] wrote: 3 (I think) seperate instances of this, each involving raid5. Is your array degraded or fully operational? Ding! A drive fell out the other day,

Re: 2.6.20.3 AMD64 oops in CFQ code

2007-03-22 Thread Dan Williams
On 3/22/07, Dan Williams [EMAIL PROTECTED] wrote: On 3/22/07, Neil Brown [EMAIL PROTECTED] wrote: On Thursday March 22, [EMAIL PROTECTED] wrote: On Thu, Mar 22 2007, [EMAIL PROTECTED] wrote: 3 (I think) seperate instances of this, each involving raid5. Is your array degraded or fully

[PATCH 2.6.21-rc4 00/15] md raid5 acceleration and async_tx

2007-03-22 Thread Dan Williams
of 2.6.22 inclusion. Regards, Dan Dan Williams (15): dmaengine: add base support for the async_tx api ARM: Add drivers/dma to arch/arm/Kconfig dmaengine: add the async_tx api md: add raid5_run_ops and support routines md: use raid5_run_ops for stripe cache

[PATCH 2.6.21-rc4 01/15] dmaengine: add base support for the async_tx api

2007-03-22 Thread Dan Williams
with async_tx calls Signed-off-by: Dan Williams [EMAIL PROTECTED] --- drivers/dma/dmaengine.c | 194 ++- drivers/dma/ioatdma.c | 248 - drivers/dma/ioatdma.h |8 + include/linux/dmaengine.h | 237

[PATCH 2.6.21-rc4 02/15] ARM: Add drivers/dma to arch/arm/Kconfig

2007-03-22 Thread Dan Williams
Signed-off-by: Dan Williams [EMAIL PROTECTED] --- arch/arm/Kconfig |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index e7baca2..74077e3 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -997,6 +997,8 @@ source drivers/mmc

[PATCH 2.6.21-rc4 05/15] md: use raid5_run_ops for stripe cache operations

2007-03-22 Thread Dan Williams
to clear 'pending' and 'ack'. Signed-off-by: Dan Williams [EMAIL PROTECTED] --- drivers/md/raid5.c | 65 +--- 1 files changed, 56 insertions(+), 9 deletions(-) diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index b7185a1..0397e33 100644

[PATCH 2.6.21-rc4 06/15] md: move write operations to raid5_run_ops

2007-03-22 Thread Dan Williams
handle_stripe sets STRIPE_OP_PREXOR, STRIPE_OP_BIODRAIN, STRIPE_OP_POSTXOR to request a write to the stripe cache. raid5_run_ops is triggerred to run and executes the request outside the stripe lock. Signed-off-by: Dan Williams [EMAIL PROTECTED] --- drivers/md/raid5.c | 152

[PATCH 2.6.21-rc4 10/15] md: use async_tx and raid5_run_ops for raid5 expansion operations

2007-03-22 Thread Dan Williams
. The bulk copy operation to the new stripe is handled inline by async_tx. Signed-off-by: Dan Williams [EMAIL PROTECTED] --- drivers/md/raid5.c | 48 1 files changed, 36 insertions(+), 12 deletions(-) diff --git a/drivers/md/raid5.c b/drivers/md

[PATCH 2.6.21-rc4 11/15] md: move raid5 io requests to raid5_run_ops

2007-03-22 Thread Dan Williams
handle_stripe now only updates the state of stripes. All execution of operations is moved to raid5_run_ops. Signed-off-by: Dan Williams [EMAIL PROTECTED] --- drivers/md/raid5.c | 68 1 files changed, 10 insertions(+), 58 deletions(-) diff

[PATCH 2.6.21-rc4 12/15] md: remove raid5 compute_block and compute_parity5

2007-03-22 Thread Dan Williams
replaced by raid5_run_ops Signed-off-by: Dan Williams [EMAIL PROTECTED] --- drivers/md/raid5.c | 124 1 files changed, 0 insertions(+), 124 deletions(-) diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index 0be26c2..062df02 100644

[PATCH 2.6.21-rc4 15/15] iop3xx: Surface the iop3xx DMA and AAU units to the iop-adma driver

2007-03-22 Thread Dan Williams
boards * do not call platform register macros in driver code * remove switch() statements for compatible register offsets/layouts Signed-off-by: Dan Williams [EMAIL PROTECTED] --- arch/arm/mach-iop32x/glantank.c|2 arch/arm/mach-iop32x/iq31244.c |5 arch/arm/mach-iop32x

[PATCH 2.6.21-rc4 13/15] dmaengine: driver for the iop32x, iop33x, and iop13xx raid engines

2007-03-22 Thread Dan Williams
Signed-off-by: Dan Williams [EMAIL PROTECTED] --- drivers/dma/Kconfig |8 drivers/dma/Makefile|1 drivers/dma/iop-adma.c | 1469 +++ include/asm-arm/hardware/iop_adma.h | 121 +++ 4 files changed, 1599

[PATCH 2.6.21-rc4 14/15] iop13xx: Surface the iop13xx adma units to the iop-adma driver

2007-03-22 Thread Dan Williams
error fix from Kirill A. Shutemov * rebase for async_tx changes * add interrupt support * do not call platform register macros in driver code Signed-off-by: Dan Williams [EMAIL PROTECTED] --- arch/arm/mach-iop13xx/setup.c | 194 +++ include/asm-arm/arch-iop13xx/adma.h| 545

[PATCH 2.6.21-rc4 07/15] md: move raid5 compute block operations to raid5_run_ops

2007-03-22 Thread Dan Williams
. Signed-off-by: Dan Williams [EMAIL PROTECTED] --- drivers/md/raid5.c | 125 +++- 1 files changed, 93 insertions(+), 32 deletions(-) diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index 4d1adb5..9856742 100644 --- a/drivers/md/raid5.c +++ b

[PATCH 2.6.21-rc4 03/15] dmaengine: add the async_tx api

2007-03-22 Thread Dan Williams
* don't use inline in C files, Adrian Bunk * select the API when MD is enabled Signed-off-by: Dan Williams [EMAIL PROTECTED] --- drivers/Makefile |1 drivers/dma/Kconfig | 15 + drivers/dma/Makefile |1 drivers/dma/async_tx.c | 905

[PATCH 2.6.21-rc4 09/15] md: satisfy raid5 read requests via raid5_run_ops

2007-03-22 Thread Dan Williams
Use raid5_run_ops to carry out the memory copies for a raid5 read request. Signed-off-by: Dan Williams [EMAIL PROTECTED] --- drivers/md/raid5.c | 40 +++- 1 files changed, 15 insertions(+), 25 deletions(-) diff --git a/drivers/md/raid5.c b/drivers/md/raid5

[PATCH 2.6.21-rc4 04/15] md: add raid5_run_ops and support routines

2007-03-22 Thread Dan Williams
of ops_complete_postxor and ops_complete_write. * removed the workqueue * call bi_end_io for reads in ops_complete_biofill Signed-off-by: Dan Williams [EMAIL PROTECTED] --- drivers/md/raid5.c | 520 include/linux/raid/raid5.h | 63 + 2 files changed, 580

[PATCH 2.6.21-rc4 08/15] md: move raid5 parity checks to raid5_run_ops

2007-03-22 Thread Dan Williams
the same logic as compute block, with the caveat that the results of the compute block are immediately written back to the parity disk. To differentiate these operations the STRIPE_OP_MOD_REPAIR_PD flag is added. Signed-off-by: Dan Williams [EMAIL PROTECTED] --- drivers/md/raid5.c | 81

Re: RAID1 out of memory error, was Re: 2.6.21-rc5-mm4

2007-04-05 Thread Dan Williams
On 4/5/07, Andrew Morton [EMAIL PROTECTED] wrote: On Fri, 06 Apr 2007 02:33:03 +1000 Reuben Farrelly [EMAIL PROTECTED] wrote: Hi, On 3/04/2007 3:47 PM, Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc5/2.6.21-rc5-mm4/ - The oops in

Re: 2.6.20: stripe_cache_size goes boom with 32mb

2007-02-23 Thread Dan Williams
On 2/23/07, Justin Piszcz [EMAIL PROTECTED] wrote: I have 2GB On this machine. For me, 8192 seems to be the sweet spot, I will probably keep it at 8mb. Just a note stripe_cache_size = 8192 = 192MB with six disks. The calculation is: stripe_cache_size * num_disks * PAGE_SIZE =

Re: [RFC] div64_64 support

2007-02-26 Thread Dan Williams
On 2/26/07, Stephen Hemminger [EMAIL PROTECTED] wrote: Here is another way to handle the 64 bit divide case. It allows full 64 bit divide by adding the support routine GCC needs. snip I know ARM already went through the process of removing __udivdi3 support:

PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-02-28 Thread Dan Williams
I can reliably reproduce a null pointer dereference on 2.6.20 and 2.6.21-rc2. I will keep digging to find the kernel version where this last worked, but wanted to see if there were any immediate experiments I should try. The failure is caused by running tiobench on a MD raid6 array with 6 out of

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-03-01 Thread Dan Williams
On 3/1/07, Jens Axboe [EMAIL PROTECTED] wrote: On Thu, Mar 01 2007, Frank Seidel wrote: Am Mittwoch, 28. Februar 2007 19:02 schrieb Dan Williams: I can reliably reproduce a null pointer dereference on 2.6.20 and 2.6.21-rc2. I will keep digging to find the kernel version where this last

Re: [2.6.21 patch] unconditionally enable SYSFS_DEPRECATED

2007-03-06 Thread Dan Williams
On Mon, 2007-03-05 at 17:56 -0800, Greg KH wrote: On Mon, Mar 05, 2007 at 07:30:21PM -0600, Matt Mackall wrote: On Mon, Mar 05, 2007 at 04:07:22PM -0800, Greg KH wrote: On Tue, Mar 06, 2007 at 12:40:52AM +0100, Adrian Bunk wrote: On Mon, Mar 05, 2007 at 10:58:13AM -0800, Greg KH wrote:

Re: [patch 097/101] revert drivers/net/tulip/dmfe: support basic carrier detection

2007-03-07 Thread Dan Williams
On Wed, 2007-03-07 at 10:14 -0800, Stephen Hemminger wrote: On Wed, 07 Mar 2007 09:12:12 -0800 Greg KH [EMAIL PROTECTED] wrote: From: Andrew Morton [EMAIL PROTECTED] Revert 7628b0a8c01a02966d2228bdf741ddedb128e8f8. Thomas Bachler reports: Commit

[PATCH 2.6.21-rc5 0/3] iop13xx msi support and a couple msi cleanups

2007-03-30 Thread Dan Williams
Here is the latest revision of some patches that have been bouncing around linux-pci for a while. linux-kernel is copied to get a few more eyes on the ARCH_SUPPORTS_MSI change. To my knowledge these patches have not yet been queued into a maintainer tree. Dan Williams (2): msi: introduce

[PATCH 2.6.21-rc5 2/3] msi: fix ARM compile

2007-03-30 Thread Dan Williams
, from include/linux/mm.h:4, from drivers/pci/msi.c:10: include/linux/smp.h:85:1: warning: this is the location of the previous definition Tested on powerpc, i386, and x86_64. Signed-off-by: Dan Williams [EMAIL PROTECTED] Acked-by: Eric W. Biederman [EMAIL PROTECTED

[PATCH 2.6.21-rc5 3/3] iop13xx: msi support (rev6)

2007-03-30 Thread Dan Williams
and clear_bit [EMAIL PROTECTED]: review comments/suggestions] [EMAIL PROTECTED]: cleanups/forward port to 2.6-git] Signed-off-by: Daniel Wolstenholme [EMAIL PROTECTED] Signed-off-by: Dan Williams [EMAIL PROTECTED] Acked-by: Eric W. Biederman [EMAIL PROTECTED] --- arch/arm/mach-iop13xx/Makefile

[PATCH 2.6.21-rc5 1/3] msi: introduce ARCH_SUPPORTS_MSI Kconfig option (rev2)

2007-03-30 Thread Dan Williams
Allows architectures to advertise that they support MSI rather than listing each architecture as a PCI_MSI dependency. rev2: * update i386 and x86_64 as well Signed-off-by: Dan Williams [EMAIL PROTECTED] Acked-by: Eric W. Biederman [EMAIL PROTECTED] --- arch/arm/Kconfig |1 + arch/i386

Re: [PATCH v2] Add DMA engine driver for Freescale MPC85xx processors.

2008-01-09 Thread Dan Williams
On Tue, 2007-10-30 at 02:25 -0700, Zhang Wei wrote: The driver implements DMA engine API for Freescale MPC85xx DMA controller, which could be used by devices in the silicon. The driver supports the Basic mode of Freescale MPC85xx DMA controller. The MPC85xx processors supported include

Re: [PATCH v2] Add DMA engine driver for Freescale MPC85xx processors.

2008-01-10 Thread Dan Williams
On Jan 10, 2008 3:10 AM, Zhang Wei [EMAIL PROTECTED] wrote: I think your patch is good. What should I do next? Cheers! Wei. I do not think all the review comments have been addressed, for example my earlier comments about GFP_ATOMIC and spin_lock_irqsave [1]. We have two options to take

Re: [PATCH 5/5] Add DMA engine driver for Freescale MPC85xxprocessors.

2007-09-13 Thread Dan Williams
On 9/13/07, Zhang Wei-r63237 [EMAIL PROTECTED] wrote: Hi, +static void fsl_dma_set_src(dma_addr_t addr, + struct dma_async_tx_descriptor *tx, int index) +{ What is index supposed to mean? It's not used, or documented anywhere than I can see. I've

Re: [PATCH 5/5] Add DMA engine driver for Freescale MPC85xx processors.

2007-09-13 Thread Dan Williams
Hi, Dan, Does I have followed your new API? :-) [..] +static struct dma_chan *of_find_dma_chan_by_phandle(phandle phandle) +{ + struct device_node *np; + struct dma_chan *chan; + struct fsl_dma_device *fdev; + + np =

Re: [git patches] net driver fixes

2007-09-14 Thread Dan Williams
On Thu, 2007-09-13 at 01:30 -0400, Jeff Garzik wrote: Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/atl1/atl1_main.c | 19 +++

Re: [git patches] net driver fixes

2007-09-14 Thread Dan Williams
On Fri, 2007-09-14 at 14:17 -0400, Jeff Garzik wrote: Dan Williams wrote: WTF? why would the default be to _not_ propagate carrier state? Are there some mitigating circumstances that require this driver to not notify the stack of carrier on/off? Userspace stuff really should know about

Re: [git patches] net driver fixes

2007-09-14 Thread Dan Williams
On Fri, 2007-09-14 at 12:19 -0700, Jay Vosburgh wrote: Dan Williams [EMAIL PROTECTED] wrote: [...] I admit that I probably don't understand the system architecture of where ehea would be used, but would this cause /sys/class/net/ethX/carrier to be TRUE even if the device has no carrier

Re: [stable] [PATCH 000 of 2] md: Fixes for md in 2.6.23

2007-11-13 Thread Dan Williams
On Nov 13, 2007 5:23 PM, Greg KH [EMAIL PROTECTED] wrote: On Tue, Nov 13, 2007 at 04:22:14PM -0800, Greg KH wrote: On Mon, Oct 22, 2007 at 05:15:27PM +1000, NeilBrown wrote: It appears that a couple of bugs slipped in to md for 2.6.23. These two patches fix them and are appropriate for

Re: [stable] [PATCH 000 of 2] md: Fixes for md in 2.6.23

2007-11-13 Thread Dan Williams
void handle_stripe5(struct stripe_head *sh) raid5-fix-unending-write-sequence.patch is in -mm and I believe is waiting on an Acked-by from Neil? thanks, greg k-h Thanks, Dan raid5: fix clearing of biofill operations From: Dan Williams [EMAIL PROTECTED] ops_complete_biofill() runs outside

Re: libertas ub8xxx - bcdDevice 30.06 - firmware issues?

2007-11-19 Thread Dan Williams
On Fri, 2007-11-16 at 20:26 -0500, Luis R. Rodriguez wrote: I have a USB libertas 1286:2001 with bcdDevice 30.06 (from lsusb -v). I tried downloading the firmware from marvell: https://www.marvell.com/drivers/driverDisplay.do?dId=160pId=38 renaming and to usb8388.bin and putting it in

[PATCH 3/4] async_tx: replace 'int_en' with operation preparation flags

2007-12-21 Thread Dan Williams
Pass a full set of flags to drivers' per-operation 'prep' routines. Currently the only flag passed is DMA_PREP_INTERRUPT. The expectation is that arch-specific async_tx_find_channel() implementations can exploit this capability to find the best channel for an operation. Signed-off-by: Dan

[PATCH 1/4] async_tx: kill ASYNC_TX_ASSUME_COHERENT

2007-12-21 Thread Dan Williams
Remove the unused ASYNC_TX_ASSUME_COHERENT flag. Async_tx is meant to hide the difference between asynchronous hardware and synchronous software operations, this flag requires clients to understand cache coherency consequences of the async path. Signed-off-by: Dan Williams [EMAIL PROTECTED

[PATCH 4/4] async_tx: allow architecture specific async_tx_find_channel implementations

2007-12-21 Thread Dan Williams
The source and destination addresses are included to allow channel selection based on address alignment. Signed-off-by: Dan Williams [EMAIL PROTECTED] --- crypto/async_tx/async_memcpy.c |3 ++- crypto/async_tx/async_memset.c |3 ++- crypto/async_tx/async_tx.c |6 +++--- crypto

[PATCH 0/4] towards an async_tx update for 2.6.25

2007-12-21 Thread Dan Williams
that do not support channel switching This series is based on 2.6.24-rc6. Dan Williams (4): async_tx: kill ASYNC_TX_ASSUME_COHERENT async_tx: kill tx_set_src and tx_set_dest methods async_tx: replace 'int_en' with operation preparation flags async_tx: allow architecture

[PATCH 2/4] async_tx: kill tx_set_src and tx_set_dest methods

2007-12-21 Thread Dan Williams
that drivers be able to make descriptor resources available when the 'prep' routine is polled. Signed-off-by: Dan Williams [EMAIL PROTECTED] --- crypto/async_tx/async_memcpy.c | 27 - crypto/async_tx/async_memset.c | 20 +++--- crypto/async_tx/async_xor.c| 94

[PATCH] libertas: select WIRELESS_EXT

2007-11-30 Thread Dan Williams
Ensure that libertas selects WIRELESS_EXT, since selecting other stuff that should depend on WEXT, like IEEE80211, doesn't seem to drag that in for us. For 2.6.24 and later. Signed-off-by: Dan Williams [EMAIL PROTECTED] diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig

Re: [RFC 1/4] dmaengine: Add slave DMA interface

2007-12-03 Thread Dan Williams
Hi Haavard, Some (delayed) comments. On Nov 23, 2007 5:20 AM, Haavard Skinnemoen [EMAIL PROTECTED] wrote: Add a new struct dma_slave_descriptor which extends the standard dma_async_tx_descriptor with a few members that are needed for doing DMA from/to peripherals with hardware handshaking

Re: [PATCH 35/59] drivers/net/wireless: Add missing space

2007-11-20 Thread Dan Williams
))) { - lbs_deb_wext(invalid size %d for key of alg + lbs_deb_wext(invalid size %d for key of alg type %d\n, ext-key_len, alg); Acked-by: Dan Williams [EMAIL PROTECTED

[PATCH] dmaengine: Correct invalid assumptions in the Kconfig text

2007-11-23 Thread Dan Williams
aren't factors, and DMA exists so that peripherals can transfer data to/from memory while the CPU does other work. Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] Signed-off-by: David Brownell [EMAIL PROTECTED] Signed-off-by: Dan Williams [EMAIL PROTECTED] --- This corrects a 'regression

Re: [PATCH 2/2] iwlwifi: add power management support -v2

2007-11-26 Thread Dan Williams
On Mon, 2007-11-26 at 19:11 +0200, Tomas Winkler wrote: On Nov 26, 2007 6:18 PM, Miguel Botón [EMAIL PROTECTED] wrote: On Saturday 17 November 2007 07:15:05 Tomas Winkler wrote: Why power management shouldn't be enabled while in AC? The semantic of this ioctls is quite unclear. I

Re: [PATCH] md: Fix data corruption when a degraded raid5 array is reshaped.

2008-01-03 Thread Dan Williams
: [EMAIL PROTECTED] Cc: Dan Williams [EMAIL PROTECTED] Signed-off-by: Neil Brown [EMAIL PROTECTED] Acked-by: Dan Williams [EMAIL PROTECTED] -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH] md: Fix data corruption when a degraded raid5 array is reshaped.

2008-01-03 Thread Dan Williams
now is safer long-term. This bug exists in 2.6.23 and 2.6.24-rc Cc: [EMAIL PROTECTED] Cc: Dan Williams [EMAIL PROTECTED] Signed-off-by: Neil Brown [EMAIL PROTECTED] Acked-by: Dan Williams [EMAIL PROTECTED] On closer look the safer test is: !test_bit(STRIPE_OP_COMPUTE_BLK, sh

Re: [PATCH] DMA: Fix broken device refcounting

2007-10-26 Thread Dan Williams
up dma_device refcounting From: Dan Williams [EMAIL PROTECTED] Currently the code drops too many references on the parent device. Change the scheme to: + take a reference at registration: dma_async_device_register() + take a reference for each channel device registered: device_register(chan

Re: [PATCH] DMA: Correct invalid assumptions in the Kconfig text

2007-10-26 Thread Dan Williams
On 10/24/07, Haavard Skinnemoen [EMAIL PROTECTED] wrote: Otherwise, Acked-by: Dan Williams [EMAIL PROTECTED] Thanks. Are one of you going to pick it up as well? Yeah, I'll pick it up. I'll leave off the AVR addition to DMADEVICES because I assume it will come with the future patch

Re: [PATCH] DMA: Correct invalid assumptions in the Kconfig text

2007-10-26 Thread Dan Williams
On 10/25/07, Haavard Skinnemoen [EMAIL PROTECTED] wrote: On Wed, 24 Oct 2007 20:16:16 +0200 Haavard Skinnemoen [EMAIL PROTECTED] wrote: [handwaving about API extensions] Oh, and we definitely need a way to report errors. Looks like the existing drivers want this as well -- I couldn't help

Re: [PATCH] DMA: Correct invalid assumptions in the Kconfig text

2007-10-27 Thread Dan Williams
On 10/27/07, Haavard Skinnemoen [EMAIL PROTECTED] wrote: Yeah, it's a pretty serious bug if the DMA engine flags an error. But wouldn't it be better to BUG() in the context of the caller? That way, you won't necessarily bring down the whole system. I see your point... We could track the

Re: [PATCH] DMA: Fix broken device refcounting

2007-10-27 Thread Dan Williams
On Sat, 2007-10-27 at 06:49 -0700, Haavard Skinnemoen wrote: On Fri, 26 Oct 2007 09:36:17 -0700 Dan Williams [EMAIL PROTECTED] wrote: @@ -221,7 +220,6 @@ void dma_chan_cleanup(struct kref *kref) { struct dma_chan *chan = container_of(kref, struct dma_chan, refcount); chan

Re: [2.6.23.1] PCI device locking up the computer when its module loads

2007-10-29 Thread Dan Williams
On Mon, 2007-10-29 at 00:36 -0700, Andrew Morton wrote: On Mon, 22 Oct 2007 13:43:16 +0100 (BST) Chris Rankin [EMAIL PROTECTED] wrote: Hi, I have a Netgear MA301 PLX wireless networking adapter which wants to use the hostap_plx driver in Linux 2.6.23.1. This very same piece of

Re: Licensing of IS89C35 WLAN USB driver [was Re: rt73usb: support for wireless in Kohjinsha subnotebook]

2007-10-30 Thread Dan Williams
On Tue, 2007-10-30 at 12:22 +0100, Pavel Machek wrote: Hi! You are listed as author of IS89C35 802.11bg WLAN USB Driver. That driver has clear MODULE_LICENSE(GPL) tag, but not other notices. Is it safe to assume whole sources are to be distributed under GPLv2? (Or is it GPLv2 or later?)

Re: [GIT PULL] MMC updates

2007-10-17 Thread Dan Williams
+ drivers/net/wireless/libertas/defs.h|2 + drivers/net/wireless/libertas/if_sdio.c | 1072 +++ drivers/net/wireless/libertas/if_sdio.h | 45 ++ Libertas bits: Acked-by: Dan Williams [EMAIL PROTECTED] include/linux/mmc/sdio_ids.h|6 + 8 files

Re: rt73usb: support for wireless in Kohjinsha subnotebook

2007-10-22 Thread Dan Williams
On Mon, 2007-10-22 at 02:09 +0200, Pavel Machek wrote: Hi! This device is NOT a Ralink USB wifi adapter! Get the windows driver in this link and see for yourself. http://www.conitech.it/conitech/ita/risorse.asp?cod=CN402USB (ISSC W89C35 802.11bg WLAN USB Adapters (Native Wifi

Re: rt73usb: support for wireless in Kohjinsha subnotebook

2007-10-23 Thread Dan Williams
On Tue, 2007-10-23 at 00:00 +0200, Pavel Machek wrote: Hi! Yes, I'm quite sure. There's MODULE_LICENCE(GPL), IIRC. That doesn't say much, some manufacturers add that line to their driver just to prevent the module loader complaining about a non-GPL driver... There should be

Re: rt73usb: support for wireless in Kohjinsha subnotebook

2007-10-23 Thread Dan Williams
On Tue, 2007-10-23 at 13:07 -0400, Daniel Hazelton wrote: On Tuesday 23 October 2007 10:05:12 Dan Williams wrote: On Tue, 2007-10-23 at 00:00 +0200, Pavel Machek wrote: Hi! Yes, I'm quite sure. There's MODULE_LICENCE(GPL), IIRC. That doesn't say much, some manufacturers

Re: rt73usb: support for wireless in Kohjinsha subnotebook

2007-10-23 Thread Dan Williams
On Tue, 2007-10-23 at 15:41 -0400, Daniel Hazelton wrote: On Tuesday 23 October 2007 14:54:54 Dan Williams wrote: On Tue, 2007-10-23 at 13:07 -0400, Daniel Hazelton wrote: On Tuesday 23 October 2007 10:05:12 Dan Williams wrote: On Tue, 2007-10-23 at 00:00 +0200, Pavel Machek wrote

Re: [PATCH] DMA: Correct invalid assumptions in the Kconfig text

2007-10-24 Thread Dan Williams
of the framework needs to be clarified. Should this patch wait until the framework has been extended? Otherwise, Acked-by: Dan Williams [EMAIL PROTECTED] Haavard Regards, Dan - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: [RFC v3 5/7] dmaengine: Make DMA Engine menu visible for AVR32 users

2008-02-12 Thread Dan Williams
On Feb 12, 2008 3:13 PM, Haavard Skinnemoen [EMAIL PROTECTED] wrote: On Tue, 12 Feb 2008 14:43:30 -0600 Olof Johansson [EMAIL PROTECTED] wrote: - depends on (PCI X86) || ARCH_IOP32X || ARCH_IOP33X || ARCH_IOP13XX + depends on (PCI X86) || ARCH_IOP32X || ARCH_IOP33X || ARCH_IOP13XX

[PATCH 0/4] async_tx: fix dependency handling and related cleanups

2008-02-12 Thread Dan Williams
/ dma_async_tx_descriptor sheds two list_heads 2/ Locking is made sane in that dma drivers no longer need to directly touch dma_async_tx_descriptor.lock 3/ dma_device.device_dependency_added is no longer needed Testing shows that iop-adma now gets by without the 'watchdog' workaround. --- Dan

[PATCH 3/4] async_tx: kill -device_dependency_added

2008-02-12 Thread Dan Williams
DMA drivers no longer need to be notified of depdency submission events as async_tx_run_dependencies and async_tx_channel_switch will handle the scheduling and execution of dependent operations. Signed-off-by: Dan Williams [EMAIL PROTECTED] --- drivers/dma/dmaengine.c |1 - drivers/dma

[PATCH 1/4] async_tx: checkpatch says s/__FUNCTION__/__func__/g

2008-02-12 Thread Dan Williams
Signed-off-by: Dan Williams [EMAIL PROTECTED] --- crypto/async_tx/async_memcpy.c |6 +++--- crypto/async_tx/async_memset.c |6 +++--- crypto/async_tx/async_tx.c |6 +++--- crypto/async_tx/async_xor.c| 12 ++-- 4 files changed, 15 insertions(+), 15 deletions

[PATCH 4/4] iop-adma: remove the workaround for missed interrupts on iop3xx

2008-02-12 Thread Dan Williams
This workaround was covering the dependency submission bug in async_tx. Signed-off-by: Dan Williams [EMAIL PROTECTED] --- drivers/dma/iop-adma.c |5 - include/asm-arm/arch-iop13xx/adma.h|5 - include/asm-arm/hardware/iop3xx-adma.h |8 include/asm

[PATCH 2/4] async_tx: fix multiple dependency submission

2008-02-12 Thread Dan Williams
Shrink struct dma_async_tx_descriptor and introduce async_tx_channel_switch to properly inject a channel switch interrupt in the descriptor stream. This simplifies the locking model as drivers no longer need to handle dma_async_tx_descriptor.lock. Signed-off-by: Dan Williams [EMAIL PROTECTED

Re: [RFC v3 4/7] dmaengine: Add slave DMA interface

2008-02-12 Thread Dan Williams
On Feb 12, 2008 9:43 AM, Haavard Skinnemoen [EMAIL PROTECTED] wrote: [..] +enum dma_slave_direction { + DMA_SLAVE_TO_MEMORY, + DMA_SLAVE_FROM_MEMORY, +}; Just reuse enum dma_data_direction from the dma-mapping api. -- Dan -- To unsubscribe from this list: send the line

Re: [RFC v3 4/7] dmaengine: Add slave DMA interface

2008-02-13 Thread Dan Williams
On Feb 12, 2008 9:43 AM, Haavard Skinnemoen [EMAIL PROTECTED] wrote: [..] /** + * struct dma_slave_descriptor - extended DMA descriptor for slave DMA + * @async_tx: async transaction descriptor + * @client_node: for use by the client, for example when operating on + * scatterlists. + */

Re: [RFC v2 5/5] Atmel MCI: Driver for Atmel on-chip MMC controllers

2008-02-13 Thread Dan Williams
On Jan 29, 2008 11:10 AM, Haavard Skinnemoen [EMAIL PROTECTED] wrote: [..] +/* + * Returns a mask of flags to be set in the command register when the + * command to start the transfer is to be sent. + */ +static u32 atmci_prepare_data(struct mmc_host *mmc, struct mmc_data *data) [..] +

Re: [RFC v2 5/5] Atmel MCI: Driver for Atmel on-chip MMC controllers

2008-02-13 Thread Dan Williams
On Feb 13, 2008 2:06 PM, Haavard Skinnemoen [EMAIL PROTECTED] wrote: On Wed, 13 Feb 2008 12:11:58 -0700 Dan Williams [EMAIL PROTECTED] wrote: + desc = chan-device-device_prep_slave(chan, + sg_dma_address(sg), direction

Re: [PATCH][I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram_iovec

2008-02-13 Thread Dan Williams
On Feb 13, 2008 2:05 PM, Brice Goglin [EMAIL PROTECTED] wrote: [I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram_iovec No need to compute copy twice in the frags loop in dma_skb_copy_datagram_iovec(). Signed-off-by: Brice Goglin [EMAIL PROTECTED] Thanks, I'll push this along.

Re: [RFC v2 5/5] Atmel MCI: Driver for Atmel on-chip MMC controllers

2008-02-14 Thread Dan Williams
On Thu, Feb 14, 2008 at 1:36 AM, Haavard Skinnemoen [EMAIL PROTECTED] wrote: [..] 2/ Fall back to PIO for a few transfers Which means killing performance for large transfers. Not really an option. It's ok to use PIO for small and/or odd transfers like read 2 bytes from this SDIO

Re: dma engine drivers for 2.6.25?

2008-02-14 Thread Dan Williams
PROTECTED] Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Cc: Paul Mackerras [EMAIL PROTECTED] Cc: Kumar Gala [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] Signed-off-by: Dan Williams [EMAIL PROTECTED] --- MAINTAINERS |7 drivers/dma/Kconfig | 19 + drivers/dma/Makefile

Re: dma engine drivers for 2.6.25?

2008-02-14 Thread Dan Williams
On Thu, Feb 14, 2008 at 8:44 PM, Kumar Gala [EMAIL PROTECTED] wrote: On Feb 14, 2008, at 12:14 PM, Dan Williams wrote: On Wed, Feb 13, 2008 at 8:52 PM, Kumar Gala [EMAIL PROTECTED] wrote: Dan, What's going on with the dma engine drivers for 2.6.25? We had a Freescale dma

Re: [PATCH] add Marvell 88W8688 support to libertas_sdio

2012-11-06 Thread Dan Williams
to setup a working WiFi client mode connection on the GuruPlug: http://wiki.debian.org/libertas Signed-off-by: Harro Haan hrh...@gmail.com Acked-by: Dan Williams d...@redhat.com --- drivers/net/wireless/libertas/if_sdio.c | 39 1 file changed, 30 insertions

Re: [PATCH 00/20] DMA: DMA unmap fixes

2012-11-07 Thread Dan Williams
On Mon, Nov 5, 2012 at 2:00 AM, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: Hi, Currently DMA subsystem does DMA mapping in the core code and DMA unmapping is done by device drivers. This is counterintuitive, causes code duplication and subtle errors (some drivers like PL330

Re: [PATCH 13/20] async_tx: do DMA unmap in core for XOR operations

2012-11-07 Thread Dan Williams
[resend] On Mon, Nov 5, 2012 at 2:00 AM, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h index 440b609..0df69f1 100644 --- a/include/linux/dmaengine.h +++ b/include/linux/dmaengine.h @@ -392,6 +392,10 @@ void

Re: [RFC PATCH 1/3] dmaengine: add dma_get_channel_caps()

2012-10-23 Thread Dan Williams
On Thu, Oct 18, 2012 at 7:51 PM, Matt Porter mpor...@ti.com wrote: Add a dmaengine API to retrieve per channel capabilities. Currently, only channel ops and SG segment limitations are implemented caps. The API is optionally implemented by drivers and when unimplemented will return a NULL

Re: [PATCH] dmaengine/dmatest: terminate transfers only in case of errors

2012-11-09 Thread Dan Williams
On 11/9/12 7:26 AM, Viresh Kumar viresh.ku...@linaro.org wrote: From: Shiraz Hashim shiraz.has...@st.com dmatest erroneously terminated transfers in normal cases also leading to test failures for multiple threads over a channel. Fix this and terminate transfers only in case of errors.

Re: Strange crash on Dell R720xd

2012-10-16 Thread Dan Williams
On Tue, Oct 16, 2012 at 5:52 AM, Laurent CARON lca...@unix-scripts.info wrote: On Tue, Oct 16, 2012 at 02:48:25PM +0200, Borislav Petkov wrote: On Tue, Oct 16, 2012 at 11:26:01AM +0200, Laurent CARON wrote: On Tue, Oct 16, 2012 at 11:03:53AM +0200, Borislav Petkov wrote: That's:

[PATCH 2.6.23-rc7 0/3] async_tx and md-accel fixes for 2.6.23

2007-09-20 Thread Dan Williams
Fix a couple bugs and provide documentation for the async_tx api. Neil, please 'ack' patch #3. git://lost.foo-projects.org/~dwillia2/git/iop async-tx-fixes-for-linus Dan Williams (3): async_tx: usage documentation and developer notes async_tx: fix dma_wait_for_async_tx raid5

[PATCH 2.6.23-rc7 1/3] async_tx: usage documentation and developer notes

2007-09-20 Thread Dan Williams
Signed-off-by: Dan Williams [EMAIL PROTECTED] --- Documentation/crypto/async-tx-api.txt | 217 + 1 files changed, 217 insertions(+), 0 deletions(-) diff --git a/Documentation/crypto/async-tx-api.txt b/Documentation/crypto/async-tx-api.txt new file mode 100644

[PATCH 2.6.23-rc7 2/3] async_tx: fix dma_wait_for_async_tx

2007-09-20 Thread Dan Williams
Fix dma_wait_for_async_tx to not loop forever in the case where a dependency chain is longer than two entries. This condition will not happen with current in-kernel drivers, but fix it for future drivers. Found-by: Saeed Bishara [EMAIL PROTECTED] Signed-off-by: Dan Williams [EMAIL PROTECTED

[PATCH 2.6.23-rc7 3/3] raid5: fix ops_complete_biofill

2007-09-20 Thread Dan Williams
). ops_complete_biofill can run in tasklet context, so rather than upgrading all the stripe locks from spin_lock to spin_lock_bh this patch just moves read completion handling back into handle_stripe. Found-by: Yuri Tikhonov [EMAIL PROTECTED] Signed-off-by: Dan Williams [EMAIL PROTECTED] --- drivers/md/raid5.c

[GIT PULL] async-tx/md-accel fixes and documentation for 2.6.23

2007-09-24 Thread Dan Williams
Linus, please pull from: git://lost.foo-projects.org/~dwillia2/git/iop async-tx-fixes-for-linus to receive: Dan Williams (3): async_tx: usage documentation and developer notes (v2) async_tx: fix dma_wait_for_async_tx raid5: fix 2 bugs in ops_complete_biofill The raid5

Re: [PATCH] libertas link error due to gcc `smartness'

2007-10-08 Thread Dan Williams
this by explicitly calling strchr() instead. Also include linux/string.h, because this file calls lots of str*() routines. Signed-off-by: Geert Uytterhoeven [EMAIL PROTECTED] Acked-by: Dan Williams [EMAIL PROTECTED] --- Due to the lack of hardware, I could not test the functionality of this change

Re: [PATCH 5/5] Net: ath5k, kconfig changes

2007-08-31 Thread Dan Williams
On Fri, 2007-08-31 at 09:30 -0400, Jeff Garzik wrote: Dan Williams wrote: On Thu, 2007-08-30 at 08:36 -0400, John W. Linville wrote: On Thu, Aug 30, 2007 at 04:38:09AM +0300, Nick Kossifidis wrote: 2007/8/28, Christoph Hellwig [EMAIL PROTECTED]: Also this whole patch seems rather

Re: [PATCH 5/5] Add DMA engine driver for Freescale MPC85xx processors.

2007-09-09 Thread Dan Williams
On 9/7/07, Zhang Wei [EMAIL PROTECTED] wrote: The driver implements DMA engine API for Freescale MPC85xx DMA controller, which could be used for MEM--MEM, IO_ADDR--MEM and IO_ADDR--IO_ADDR data transfer. The driver supports the Basic mode of Freescale MPC85xx DMA controller. The MPC85xx

Re: [PATCH 5/5] Add DMA engine driver for Freescale MPC85xx processors.

2007-09-09 Thread Dan Williams
On 9/9/07, Timur Tabi [EMAIL PROTECTED] wrote: Dan Williams wrote: This routine implies that there is a piece of code somewhere that wants to select which channels it can use. A similar effect can be achieved by registering a dma_client with the dmaengine interface

[GIT PATCH 0/2] stripe-queue for 2.6.23 consideration

2007-07-22 Thread Dan Williams
insertions(+), 407 deletions(-) Dan Williams (2): raid5: add the stripe_queue object for tracking raid io requests (take2) raid5: use stripe_queues to prioritize the most deserving requests (take4) I initially considered them 2.6.24 material but after fixing the sync+io data corruption

[GIT PATCH 1/2] raid5: add the stripe_queue object for tracking raid io requests (take2)

2007-07-22 Thread Dan Williams
. Pre-patch throughput hovers at ~85MB/s for this dd command. Changes in take2: * leave the flags with the buffers, prevents a data corruption issue whereby stale buffer state flags are attached to newly initialized buffers Signed-off-by: Dan Williams [EMAIL PROTECTED] --- drivers/md/raid5.c

Re: __unsafe() usage

2007-07-23 Thread Dan Williams
unload, don't register an exit function. Signed-off-by: Rusty Russell [EMAIL PROTECTED] Acked-by: Dan Williams [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: 2.6.23-rc1: BUG_ON in kmap_atomic_prot()

2007-07-24 Thread Dan Williams
On 7/24/07, Jens Axboe [EMAIL PROTECTED] wrote: What about the new async crypto stuff? I've been looking, but is it guarenteed that async_memcpy() runs in process context with interrupts enabled always? If not, there's a km type bug there. Currently the only user is the MD raid456 driver, and

Re: 2.6.23-rc1: BUG_ON in kmap_atomic_prot()

2007-07-24 Thread Dan Williams
On 7/24/07, Andrew Morton [EMAIL PROTECTED] wrote: [...] What about the new async crypto stuff? I've been looking, but is it guarenteed that async_memcpy() runs in process context with interrupts enabled always? If not, there's a km type bug there. I think Shannon maintains that now. I am

Re: [PATCH 2/8] dm: Fix workqueue leak for raid5

2007-07-24 Thread Dan Williams
On 7/24/07, Dmitry Monakhov [EMAIL PROTECTED] wrote: Signed-off-by: Dmitry Monakhov [EMAIL PROTECTED] --- drivers/md/raid5.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index 0f30826..79dd2c7 100644 --- a/drivers/md/raid5.c

  1   2   3   4   5   6   7   8   9   10   >