Re: [PATCH v6 19/29] fpga: dfl: fme-mgr: add compat_id support

2018-06-13 Thread Moritz Fischer
On Tue, Jun 12, 2018 at 06:10:33PM +0800, Wu Hao wrote:
> This patch adds compat_id support to fme manager driver, it
> reads the ID from the hardware register. And it could be used
> for compatibility check before partial reconfiguration.
> 
> Signed-off-by: Wu Hao 
> Acked-by: Alan Tull 
Acked-by: Moritz Fischer 
> ---
> v6: add Acked-by from Alan.
> ---
>  drivers/fpga/dfl-fme-mgr.c | 15 +++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/drivers/fpga/dfl-fme-mgr.c b/drivers/fpga/dfl-fme-mgr.c
> index be0060a..691761f 100644
> --- a/drivers/fpga/dfl-fme-mgr.c
> +++ b/drivers/fpga/dfl-fme-mgr.c
> @@ -272,9 +272,17 @@ static u64 fme_mgr_status(struct fpga_manager *mgr)
>   .status = fme_mgr_status,
>  };
>  
> +static void fme_mgr_get_compat_id(void __iomem *fme_pr,
> +   struct fpga_compat_id *id)
> +{
> + id->id_l = readq(fme_pr + FME_PR_INTFC_ID_L);
> + id->id_h = readq(fme_pr + FME_PR_INTFC_ID_H);
> +}
> +
>  static int fme_mgr_probe(struct platform_device *pdev)
>  {
>   struct dfl_fme_mgr_pdata *pdata = dev_get_platdata(>dev);
> + struct fpga_compat_id *compat_id;
>   struct device *dev = >dev;
>   struct fme_mgr_priv *priv;
>   struct fpga_manager *mgr;
> @@ -295,11 +303,18 @@ static int fme_mgr_probe(struct platform_device *pdev)
>   return PTR_ERR(priv->ioaddr);
>   }
>  
> + compat_id = devm_kzalloc(dev, sizeof(*compat_id), GFP_KERNEL);
> + if (!compat_id)
> + return -ENOMEM;
> +
> + fme_mgr_get_compat_id(priv->ioaddr, compat_id);
> +
>   mgr = fpga_mgr_create(dev, "DFL FME FPGA Manager",
> _mgr_ops, priv);
>   if (!mgr)
>   return -ENOMEM;
>  
> + mgr->compat_id = compat_id;
>   platform_set_drvdata(pdev, mgr);
>  
>   ret = fpga_mgr_register(mgr);
> -- 
> 1.8.3.1
> 
Thanks,

Moritz


[PATCH v6 19/29] fpga: dfl: fme-mgr: add compat_id support

2018-06-12 Thread Wu Hao
This patch adds compat_id support to fme manager driver, it
reads the ID from the hardware register. And it could be used
for compatibility check before partial reconfiguration.

Signed-off-by: Wu Hao 
Acked-by: Alan Tull 
---
v6: add Acked-by from Alan.
---
 drivers/fpga/dfl-fme-mgr.c | 15 +++
 1 file changed, 15 insertions(+)

diff --git a/drivers/fpga/dfl-fme-mgr.c b/drivers/fpga/dfl-fme-mgr.c
index be0060a..691761f 100644
--- a/drivers/fpga/dfl-fme-mgr.c
+++ b/drivers/fpga/dfl-fme-mgr.c
@@ -272,9 +272,17 @@ static u64 fme_mgr_status(struct fpga_manager *mgr)
.status = fme_mgr_status,
 };
 
+static void fme_mgr_get_compat_id(void __iomem *fme_pr,
+ struct fpga_compat_id *id)
+{
+   id->id_l = readq(fme_pr + FME_PR_INTFC_ID_L);
+   id->id_h = readq(fme_pr + FME_PR_INTFC_ID_H);
+}
+
 static int fme_mgr_probe(struct platform_device *pdev)
 {
struct dfl_fme_mgr_pdata *pdata = dev_get_platdata(>dev);
+   struct fpga_compat_id *compat_id;
struct device *dev = >dev;
struct fme_mgr_priv *priv;
struct fpga_manager *mgr;
@@ -295,11 +303,18 @@ static int fme_mgr_probe(struct platform_device *pdev)
return PTR_ERR(priv->ioaddr);
}
 
+   compat_id = devm_kzalloc(dev, sizeof(*compat_id), GFP_KERNEL);
+   if (!compat_id)
+   return -ENOMEM;
+
+   fme_mgr_get_compat_id(priv->ioaddr, compat_id);
+
mgr = fpga_mgr_create(dev, "DFL FME FPGA Manager",
  _mgr_ops, priv);
if (!mgr)
return -ENOMEM;
 
+   mgr->compat_id = compat_id;
platform_set_drvdata(pdev, mgr);
 
ret = fpga_mgr_register(mgr);
-- 
1.8.3.1