Re: [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support

2017-08-10 Thread David.Wu
Hi Chen-Yu, 在 2017/8/10 10:40, Chen-Yu Tsai 写道: Hi David, On Wed, Aug 9, 2017 at 5:38 PM, David.Wu wrote: Hello Corentin, Chen-Yu 在 2017/8/9 16:45, Corentin Labbe 写道: On Thu, Aug 03, 2017 at 07:06:33PM +0800, Chen-Yu Tsai wrote: On Thu, Aug 3, 2017 at 1:38 AM,

Re: [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support

2017-08-09 Thread Chen-Yu Tsai
Hi David, On Wed, Aug 9, 2017 at 5:38 PM, David.Wu wrote: > Hello Corentin, Chen-Yu > > > 在 2017/8/9 16:45, Corentin Labbe 写道: >> >> On Thu, Aug 03, 2017 at 07:06:33PM +0800, Chen-Yu Tsai wrote: >>> >>> On Thu, Aug 3, 2017 at 1:38 AM, Florian Fainelli

Re: [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support

2017-08-09 Thread Florian Fainelli
On August 9, 2017 1:45:41 AM PDT, Corentin Labbe wrote: >On Thu, Aug 03, 2017 at 07:06:33PM +0800, Chen-Yu Tsai wrote: >> On Thu, Aug 3, 2017 at 1:38 AM, Florian Fainelli > wrote: >> > On 08/01/2017 11:21 PM, David Wu wrote: >> >> To make internal

Re: [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support

2017-08-09 Thread David.Wu
Hello Corentin, Chen-Yu 在 2017/8/9 16:45, Corentin Labbe 写道: On Thu, Aug 03, 2017 at 07:06:33PM +0800, Chen-Yu Tsai wrote: On Thu, Aug 3, 2017 at 1:38 AM, Florian Fainelli wrote: On 08/01/2017 11:21 PM, David Wu wrote: To make internal phy work, need to configure the

Re: [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support

2017-08-09 Thread Corentin Labbe
On Thu, Aug 03, 2017 at 07:06:33PM +0800, Chen-Yu Tsai wrote: > On Thu, Aug 3, 2017 at 1:38 AM, Florian Fainelli wrote: > > On 08/01/2017 11:21 PM, David Wu wrote: > >> To make internal phy work, need to configure the phy_clock, > >> phy cru_reset and related registers. > >>

Re: [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support

2017-08-03 Thread David.Wu
Hi Florian & ChenYu 在 2017/8/3 1:38, Florian Fainelli 写道: This is incorrect in two ways: - this is a property of the PHY, so it should be documented as such in Documentation/devicetree/bindings/net/phy.txt so other bindings can re-use it - if it was specific to your MAC you would expect a

Re: [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support

2017-08-03 Thread Chen-Yu Tsai
On Thu, Aug 3, 2017 at 1:38 AM, Florian Fainelli wrote: > On 08/01/2017 11:21 PM, David Wu wrote: >> To make internal phy work, need to configure the phy_clock, >> phy cru_reset and related registers. >> >> Signed-off-by: David Wu >> --- >>

Re: [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support

2017-08-02 Thread Florian Fainelli
On 08/01/2017 11:21 PM, David Wu wrote: > To make internal phy work, need to configure the phy_clock, > phy cru_reset and related registers. > > Signed-off-by: David Wu > --- > .../devicetree/bindings/net/rockchip-dwmac.txt | 6 +- >