Re: [PATCH v6 08/11] cpufreq/schedutil: take into account interrupt

2018-06-12 Thread Vincent Guittot
On 12 June 2018 at 11:20, Quentin Perret wrote: > On Tuesday 12 Jun 2018 at 11:16:56 (+0200), Vincent Guittot wrote: >> The time spent under interrupt can be significant but it is not reflected >> in the utilization of CPU when deciding to choose an OPP. Now that we have >> access to this metric,

Re: [PATCH v6 08/11] cpufreq/schedutil: take into account interrupt

2018-06-12 Thread Quentin Perret
On Tuesday 12 Jun 2018 at 11:16:56 (+0200), Vincent Guittot wrote: > The time spent under interrupt can be significant but it is not reflected > in the utilization of CPU when deciding to choose an OPP. Now that we have > access to this metric, schedutil can take it into account when selecting >

Re: [PATCH v6 08/11] cpufreq/schedutil: take into account interrupt

2018-06-12 Thread Vincent Guittot
On 12 June 2018 at 10:54, Dietmar Eggemann wrote: > On 06/08/2018 02:09 PM, Vincent Guittot wrote: > > [...] > >> @@ -182,21 +183,30 @@ static void sugov_get_util(struct sugov_cpu *sg_cpu) >> sg_cpu->util_dl = cpu_util_dl(rq); >> sg_cpu->bw_dl= cpu_bw_dl(rq); >>

Re: [PATCH v6 08/11] cpufreq/schedutil: take into account interrupt

2018-06-12 Thread Dietmar Eggemann
On 06/08/2018 02:09 PM, Vincent Guittot wrote: [...] @@ -182,21 +183,30 @@ static void sugov_get_util(struct sugov_cpu *sg_cpu) sg_cpu->util_dl = cpu_util_dl(rq); sg_cpu->bw_dl= cpu_bw_dl(rq); sg_cpu->util_rt = cpu_util_rt(rq); + sg_cpu->util_irq =