Re: [PATCH] Do not silently discard WRITE_SAME requests

2014-10-12 Thread Petr Vandrovec
On 10/11/2014 5:51 AM, Martin K. Petersen wrote: Petr == Petr Vandrovec p...@vmware.com writes: Petr After investigating, problem seems to be in a way completion Petr handler for WRITE_SAME handles EOPNOTSUPP error, causing Petr all-but-first WRITE_SAME request on the LVM device to be silently

[GIT PULL] platform-drivers-x86 for v3.18

2014-10-12 Thread Darren Hart
Hi Linus, The following have all spent at least a few days in linux-next, most for more than a week. These are mostly cleanups and error handling improvements with a few updates to extend existing support to newer hardware. Thanks, Darren Hart Intel Open Source Technology Center The following

[PATCH 1/1] Octeon: Staging Driver: Remove coding warnings

2014-10-12 Thread Akshay Sarode
Checkpatch coding warnings of 'Missing a blank line after declaration' Signed-off-by: Akshay Sarode akshaysarod...@gmail.com --- drivers/staging/octeon/ethernet-tx.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/staging/octeon/ethernet-tx.c

Re: [PATCH] net: wireless: brcm80211: brcmfmac: dhd_sdio.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-10-12 Thread Arend van Spriel
On 12-10-14 01:52, Rickard Strandqvist wrote: Replacing strncpy with strlcpy to avoid strings that lacks null terminate. And changed from using strncpy to strlcpy to simplify code. Looks good to me. Just two small process related remarks: - It is sufficient to prefix the patch with brcmfmac

Re: [PATCH] debugfs: add helper function to create device related seq_file

2014-10-12 Thread Arend van Spriel
On 11-10-14 22:17, Greg Kroah-Hartman wrote: On Sat, Oct 11, 2014 at 06:01:55PM +0200, Arend van Spriel wrote: This patch adds a helper function that simplifies adding a sequence file for device drivers. The calling device driver needs to provide a read function and a device pointer. The

[PATCH] kvm: drop unsupported capabilities, fix documentation

2014-10-12 Thread Michael S. Tsirkin
No kernel ever reported KVM_CAP_DEVICE_MSIX, KVM_CAP_DEVICE_MSI, KVM_CAP_DEVICE_ASSIGNMENT, KVM_CAP_DEVICE_DEASSIGNMENT. This makes the documentation wrong, and no application ever written to use these capabilities has a chance to work correctly. The only way to detect support is to try, and test

[PATCH v2] Staging: lustre: llite: fix some sparse warnings about userspace pointer

2014-10-12 Thread Anh Le
Add __user macro to the function declarations that accept userspace pointers as arguments. Signed-off-by: Anh Le anhlq2...@gmail.com --- v2: Fixed checkpatch's parenthesis alignment warnings, noted by Sudip Mukherjee sudipm.mukher...@gmail.com.

Re: [PATCH net-next RFC 1/3] virtio: support for urgent descriptors

2014-10-12 Thread Michael S. Tsirkin
On Sat, Oct 11, 2014 at 03:16:44PM +0800, Jason Wang wrote: Below should be useful for some experiments Jason is doing. I thought I'd send it out for early review/feedback. event idx feature allows us to defer interrupts until a specific # of descriptors were used. Sometimes it might be

Re: [RFC PATCH 3/3] i2c: show and change bus frequency via sysfs

2014-10-12 Thread Octavian Purdila
On Sat, Oct 11, 2014 at 11:14 PM, Mark Roszko mark.ros...@gmail.com wrote: This seems limiting to arches with peripherals that can support a range of frequencies rather than fixed numbers. Also it creates some portability quirkiness between platforms when all the i2c bus drivers have

Re: [PATCH] arm: Blacklist gcc 4.8.[012] and 4.9.0 with CONFIG_FRAME_POINTER

2014-10-12 Thread Mikael Pettersson
Peter Hurley writes: On 10/11/2014 12:33 PM, Mikael Pettersson wrote: Peter Hurley writes: On 10/10/2014 12:36 PM, Russell King - ARM Linux wrote: On Fri, Oct 10, 2014 at 12:26:14PM -0400, Peter Hurley wrote: gcc versions 4.8.[012] and 4.9.0 generates code that prematurely

[GIT PULL] parisc architecture patch for v3.18

2014-10-12 Thread Helge Deller
Hi Linus, please pull one patch for the parisc architecture for kernel 3.18 from git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git parisc-3.18-1 This patch intentionally breaks the ABI on PARISC Linux! It assigns new numbers to SIGSTKFLT, SIGXCPU, SIGXFSZ and SIGSYS so

[PATCH resend] kconfig: Fix compiler warning in menu.c

2014-10-12 Thread Hans de Goede
Hi, This one seems to have fallen through the cracks. Regards, Hans -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

[PATCH resend] kconfig: Fix compiler warning in menu.c

2014-10-12 Thread Hans de Goede
This fixes the following compiler warning: In file included from scripts/kconfig/zconf.tab.c:2537:0: scripts/kconfig/menu.c: In function ‘get_symbol_str’: scripts/kconfig/menu.c:590:18: warning: ‘jump’ may be used uninitialized in this function [-Wmaybe-uninitialized] jump-offset =

Re: [PATCH] char: hw_random: core.c: Changed from using strncpy to strlcpy

2014-10-12 Thread Rickard Strandqvist
Hi Oops, sorry. New patch on the way! Kind regards Rickard Strandqvist 2014-10-12 2:27 GMT+02:00 Mark D Rustad mrus...@gmail.com: On Oct 11, 2014, at 3:36 PM, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: Changed from using strncpy to strlcpy to simplify the code

[PATCH v2] char: hw_random: core.c: Changed from using strncat to strlcat

2014-10-12 Thread Rickard Strandqvist
Changed from using strncat to strlcat to simplify the code Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/char/hw_random/core.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/char/hw_random/core.c

Re: [PATCH] net: wireless: brcm80211: brcmfmac: dhd_sdio.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-10-12 Thread Rickard Strandqvist
2014-10-12 10:06 GMT+02:00 Arend van Spriel ar...@broadcom.com: On 12-10-14 01:52, Rickard Strandqvist wrote: Replacing strncpy with strlcpy to avoid strings that lacks null terminate. And changed from using strncpy to strlcpy to simplify code. Looks good to me. Just two small process related

[PATCH 3/3] um/os-Linux: Use char[] for syscall_stub declarations

2014-10-12 Thread Nicolas Iooss
When declaring __syscall_stub_start, use the same type in UML userspace code as in arch/um/include/asm/sections.h. While at it, also declare batch_syscall_stub as char[]. Signed-off-by: Nicolas Iooss nicolas.iooss_li...@m4x.org --- arch/um/os-Linux/skas/mem.c | 6 +++---

[PATCH 1/3] um: Create asm/sections.h

2014-10-12 Thread Nicolas Iooss
arch/um/kernel/dyn.lds.S and arch/um/kernel/uml.lds.S define some UML-specific symbols. These symbols are used in the kernel part of UML with extern declarations. Move these declarations to a new header, asm/sections.h, like other architectures do. Signed-off-by: Nicolas Iooss

[PATCH 2/3] um: Use char[] for linker script address declarations

2014-10-12 Thread Nicolas Iooss
The linker script defines some variables which are declared either with type char[] in include/asm-generic/sections.h or with a meaningless integer type in arch/um/include/asm/sections.h. Fix this inconsistency by declaring every variable char[]. Signed-off-by: Nicolas Iooss

Re: [3.16.1 BISECTED REGRESSION]: Simtec Entropy Key (cdc-acm) broken in 3.16

2014-10-12 Thread Paul Martin
On Sat, Oct 11, 2014 at 11:24:59PM +0100, Nix wrote: On 11 Oct 2014, Paul Martin spake thusly: Having been privy to the firmware of the eKey, it is very simplistic, with no implementation whatsoever of any flow control. That's what I thought. (Why would something that just provides data

[PATCH v2] brcmfmac: dhd_sdio.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-10-12 Thread Rickard Strandqvist
Now when I did the patch again I just want to ensure that this is not any other errors. Although strncpy use before was wrong, it did filled the remaining part of the string with null characters. This is not something that is needed? And a part that is not obvious right, so check. When

[PATCH v2] brcmfmac: dhd_sdio.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-10-12 Thread Rickard Strandqvist
Replacing strncpy with strlcpy to avoid strings that lacks null terminate. And changed from using strncat to strlcat to simplify code. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c | 25 ++-- 1

[PATCH v3 00/25] virtio: fix spec compliance issues

2014-10-12 Thread Michael S. Tsirkin
Rusty, please review this, and consider for this merge window. This fixes the following virtio spec compliance issues: 1. on restore, drivers use device before setting ACKNOWLEDGE and DRIVER bits 2. on probe, drivers aren't prepared to handle config interrupts arriving before probe returns 3.

[PATCH v3 01/25] virtio_pci: fix virtio spec compliance on restore

2014-10-12 Thread Michael S. Tsirkin
On restore, virtio pci does the following: + set features + init vqs etc - device can be used at this point! + set ACKNOWLEDGE,DRIVER and DRIVER_OK status bits This is in violation of the virtio spec, which requires the following order: - ACKNOWLEDGE - DRIVER - init vqs - DRIVER_OK This

[PATCH v3 07/25] virtio_net: drop config_enable

2014-10-12 Thread Michael S. Tsirkin
Now that virtio core ensures config changes don't arrive during probing, drop config_enable flag in virtio net. On removal, flush is now sufficient to guarantee that no change work is queued. This help simplify the driver, and will allow setting DRIVER_OK earlier without losing config change

[PATCH v3 09/25] virtio_net: minor cleanup

2014-10-12 Thread Michael S. Tsirkin
goto done; done: return; is ugly, it was put there to make diff review easier. replace by open-coded return. Signed-off-by: Michael S. Tsirkin m...@redhat.com Acked-by: Cornelia Huck cornelia.h...@de.ibm.com --- drivers/net/virtio_net.c | 6 ++ 1 file changed, 2

[PATCH v3 05/25] virtio_blk: drop config_enable

2014-10-12 Thread Michael S. Tsirkin
Now that virtio core ensures config changes don't arrive during probing, drop config_enable flag in virtio blk. On removal, flush is now sufficient to guarantee that no change work is queued. This help simplify the driver, and will allow setting DRIVER_OK earlier without losing config change

[PATCH v3 11/25] virtio_net: enable VQs early

2014-10-12 Thread Michael S. Tsirkin
virtio spec requires drivers to set DRIVER_OK before using VQs. This is set automatically after probe returns, virtio net violated this rule by using receive VQs within probe. To fix, call virtio_enable_vqs_early before using VQs. Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by:

[PATCH v3 14/25] 9p/trans_virtio: enable VQs early

2014-10-12 Thread Michael S. Tsirkin
virtio spec requires drivers to set DRIVER_OK before using VQs. This is set automatically after probe returns, but virtio 9p device adds self to channel list within probe, at which point VQ can be used in violation of the spec. To fix, call virtio_enable_vqs_early before using VQs.

[PATCH v3 17/25] virtio_blk: enable VQs early on restore

2014-10-12 Thread Michael S. Tsirkin
virtio spec requires drivers to set DRIVER_OK before using VQs. This is set automatically after restore returns, virtio block violated this rule on restore by restarting queues, which might in theory cause the VQ to be used directly within restore. To fix, call virtio_enable_vqs_early before

[PATCH v3 12/25] virtio_blk: enable VQs early

2014-10-12 Thread Michael S. Tsirkin
virtio spec requires drivers to set DRIVER_OK before using VQs. This is set automatically after probe returns, virtio block violated this rule by calling add_disk, which causes the VQ to be used directly within probe. To fix, call virtio_enable_vqs_early before using VQs. Signed-off-by: Michael

[PATCH v3 21/25] virito_scsi: use freezable WQ for events

2014-10-12 Thread Michael S. Tsirkin
From: Paolo Bonzini pbonz...@redhat.com Michael S. Tsirkin noticed a race condition: we reset device on freeze, but system WQ is still running so it might try adding bufs to a VQ meanwhile. To fix, switch to handling events from the freezable WQ. Reported-by: Michael S. Tsirkin m...@redhat.com

[PATCH v3 13/25] virtio_console: enable VQs early

2014-10-12 Thread Michael S. Tsirkin
virtio spec requires drivers to set DRIVER_OK before using VQs. This is set automatically after probe returns, virtio console violated this rule by adding inbufs, which causes the VQ to be used directly within probe. To fix, call virtio_enable_vqs_early before using VQs. Signed-off-by: Michael

[PATCH v3 16/25] virtio_scsi: move kick event out from virtscsi_init

2014-10-12 Thread Michael S. Tsirkin
We currently kick event within virtscsi_init, before host is fully initialized. This can in theory confuse guest if device consumes the buffers immediately. To fix, move virtscsi_kick_event_all out to scan/restore. Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

[PATCH v3 24/25] virtio_scsi: drop scan callback

2014-10-12 Thread Michael S. Tsirkin
Enable VQs early like we do for restore. This makes it possible to drop the scan callback, moving scanning into the probe function, and making code simpler. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/scsi/virtio_scsi.c | 23 +++ 1 file changed, 7

[PATCH v3 20/25] virtio_net: enable VQs early on restore

2014-10-12 Thread Michael S. Tsirkin
virtio spec requires drivers to set DRIVER_OK before using VQs. This is set automatically after restore returns, virtio net violated this rule by using receive VQs within restore. To fix, call virtio_enable_vqs_early before using VQs. Signed-off-by: Michael S. Tsirkin m...@redhat.com

[PATCH v3 23/25] virtio_balloon: enable VQs early on restore

2014-10-12 Thread Michael S. Tsirkin
virtio spec requires drivers to set DRIVER_OK before using VQs. This is set automatically after resume returns, virtio balloon violated this rule by adding bufs, which causes the VQ to be used directly within restore. To fix, call virtio_enable_vqs_early before using VQ. Signed-off-by: Michael

[PATCH v3 25/25] virtio-rng: refactor probe error handling

2014-10-12 Thread Michael S. Tsirkin
Code like vi-vq = NULL; kfree(vi) does not make sense. Clean it up, use goto error labels for cleanup. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/char/hw_random/virtio-rng.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git

[PATCH v3 19/25] virtio_console: enable VQs early on restore

2014-10-12 Thread Michael S. Tsirkin
virtio spec requires drivers to set DRIVER_OK before using VQs. This is set automatically after resume returns, virtio console violated this rule by adding inbufs, which causes the VQ to be used directly within restore. To fix, call virtio_enable_vqs_early before using VQs. Signed-off-by:

[PATCH v3 22/25] virtio_scsi: fix race on device removal

2014-10-12 Thread Michael S. Tsirkin
We cancel event work on device removal, but an interrupt could trigger immediately after this, and queue it again. To fix, set a flag. Loosely based on patch by Paolo Bonzini Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

[PATCH v3 15/25] virtio_net: fix use after free on allocation failure

2014-10-12 Thread Michael S. Tsirkin
In the extremely unlikely event that driver initialization fails after RX buffers are added, virtio net frees RX buffers while VQs are still active, potentially causing device to use a freed buffer. To fix, reset device first - same as we do on device removal. Signed-off-by: Michael S. Tsirkin

[PATCH] [mm]: vmscan: replace printk with pr_err

2014-10-12 Thread Pintu Kumar
This patch replaces printk(KERN_ERR..) with pr_err found under shrink_slab. Thus it also reduces one line extra because of formatting. Signed-off-by: Pintu Kumar pint...@samsung.com --- mm/vmscan.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c

[PATCH v3 18/25] virtio_scsi: enable VQs early on restore

2014-10-12 Thread Michael S. Tsirkin
virtio spec requires drivers to set DRIVER_OK before using VQs. This is set automatically after restore returns, virtio scsi violated this rule on restore by kicking event vq within restore. To fix, call virtio_enable_vqs_early before using event queue. Signed-off-by: Michael S. Tsirkin

[PATCH v2 net] x86: bpf_jit: fix two bugs in eBPF JIT compiler

2014-10-12 Thread Ortwin Glück
Fixes: 622582786c9e (net: filter: x86: internal BPF JIT) Hi, I confirm that this fixes my kernel panic when using nmap as root on 3.17. Ortwin -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH v3 10/25] virtio: add API to enable VQs early

2014-10-12 Thread Michael S. Tsirkin
virtio spec 0.9.X requires DRIVER_OK to be set before VQs are used, but some drivers use VQs before probe function returns. Since DRIVER_OK is set after probe, this violates the spec. Even though under virtio 1.0 transitional devices support this behaviour, we want to make it possible for those

[PATCH v3 08/25] virtio-net: drop config_mutex

2014-10-12 Thread Michael S. Tsirkin
config_mutex served two purposes: prevent multiple concurrent config change handlers, and synchronize access to config_enable flag. Since commit dbf2576e37da0fcc7aacbfbb9fd5d3de7888a3c1 workqueue: make all workqueues non-reentrant all workqueues are non-reentrant, and config_enable is now

[PATCH v3 02/25] virtio: unify config_changed handling

2014-10-12 Thread Michael S. Tsirkin
Replace duplicated code in all transports with a single wrapper in virtio.c. The only functional change is in virtio_mmio.c: if a buggy device sends us an interrupt before driver is set, we previously returned IRQ_NONE, now we return IRQ_HANDLED. As this must not happen in practice, this does

[PATCH v3 04/25] virtio: defer config changed notifications

2014-10-12 Thread Michael S. Tsirkin
Defer config changed notifications that arrive during probe/scan/freeze/restore. This will allow drivers to set DRIVER_OK earlier, without worrying about racing with config change interrupts. This change will also benefit old hypervisors (before 2009) that send interrupts without checking

[PATCH v3 06/25] virtio-blk: drop config_mutex

2014-10-12 Thread Michael S. Tsirkin
config_mutex served two purposes: prevent multiple concurrent config change handlers, and synchronize access to config_enable flag. Since commit dbf2576e37da0fcc7aacbfbb9fd5d3de7888a3c1 workqueue: make all workqueues non-reentrant all workqueues are non-reentrant, and config_enable is now

[PATCH v3 03/25] virtio-pci: move freeze/restore to virtio core

2014-10-12 Thread Michael S. Tsirkin
This is in preparation to extending config changed event handling in core. Wrapping these in an API also seems to make for a cleaner code. Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com --- include/linux/virtio.h | 6 +

[PATCH RESEND] drivers/block/mtip32xx: Fix incorrect warning

2014-10-12 Thread Daniel Cotton
Prevent mtip32xx block driver from showing a warning at load time (Error creating debugfs parent) when debugfs is not included in the kernel. If debugfs is included, show the error code. Fixes bug 55831 in the Bugzilla. Signed-off-by: Daniel Cotton danielcotton.patc...@gmail.com ---

[PATCH] arch/x86/kernel/rtc.c: Overzealous usage of 'const' keyword

2014-10-12 Thread Edward O'Callaghan
Please merge. -- __ Edward O'Callaghan, Director and Principal consultant. https://www.alterapraxis.com | eocallag...@alterapraxis.com Altera Praxis Pty Ltd, // Discretions in cybersecurity ACN 165 424 064. //

[PATCH 1/1] [mm]: vmalloc: replace printk with pr_warn

2014-10-12 Thread Pintu Kumar
This patch replaces printk(KERN_WARNING..) with pr_warn. Thus it also reduces one line extra because of formatting. Signed-off-by: Pintu Kumar pint...@samsung.com --- mm/vmalloc.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index

Re: [PATCH v4] i2c: rk3x: adjust the LOW divison based on characteristics of SCL

2014-10-12 Thread Max Schwarz
Hi Addy, sorry for the long delay, I finally had time to look at your work. On Thursday 09 October 2014 at 14:47:15, Addy Ke wrote: As show in I2C specification: - Standard-mode: the minimum HIGH period of the scl clock is 4.0us the minimum LOW period of the scl clock is

Re: [PATCH] PCI: add kernel parameter to override devid-driver mapping.

2014-10-12 Thread Marcel Apfelbaum
On Wed, 2014-10-01 at 12:48 -0600, Alex Williamson wrote: On Tue, 2014-09-30 at 19:38 +0300, Marcel Apfelbaum wrote: Scanning a lot of devices during boot requires a lot of time. On other scenarios there is a need to bind a driver to a specific slot. Binding devices to pci-stub driver

[PATCH] staging: comedi: drivers: comedi_bond.c: Changed from using strncat to strlcat

2014-10-12 Thread Rickard Strandqvist
Changed from using strncat to strlcat to simplify the code Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/staging/comedi/drivers/comedi_bond.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

Re: [PATCH 1/1] fat: remove redundant sys_tz declaration

2014-10-12 Thread OGAWA Hirofumi
Fabian Frederick f...@skynet.be writes: sys_tz is already declared extern struct in include/linux/time.h Cc: Andrew Morton a...@linux-foundation.org Cc: OGAWA Hirofumi hirof...@mail.parknet.co.jp Signed-off-by: Fabian Frederick f...@skynet.be --- fs/fat/misc.c | 2 -- 1 file changed, 2

Re: [PATCHv2 1/3] x86, ptdump: Add section for EFI runtime services

2014-10-12 Thread Mathias Krause
On Thu, Oct 09, 2014 at 12:26:19AM +0200, Borislav Petkov wrote: On Wed, Oct 08, 2014 at 11:58:20PM +0200, Mathias Krause wrote: Well, that is only partly correct. The call chain in efi_map_regions() [ - efi_map_region() - __map_region() - kernel_map_pages_in_pgd() - ...magic... ] does not

Re: [PATCH v1 2/4] ARM: keystone: pm: switch to use generic pm domains

2014-10-12 Thread Kevin Hilman
Hi Grygorii, On 9/29/14 7:38 AM, Grygorii Strashko wrote: This patch switches Keystone 2 PM code to use Generic PM domains instead of PM clock domains because of the lack of DT support for the last. Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com IMO, this approach is much better.

Re: [PATCH v1 2/4] ARM: keystone: pm: switch to use generic pm domains

2014-10-12 Thread Kevin Hilman
On 10/2/14 12:17 PM, Santosh Shilimkar wrote: On Monday 29 September 2014 10:38 AM, Grygorii Strashko wrote: This patch switches Keystone 2 PM code to use Generic PM domains instead of PM clock domains because of the lack of DT support for the last. Signed-off-by: Grygorii Strashko

Re: [PATCH RFC 1/5] sched,numa: build table of node hop distance

2014-10-12 Thread Peter Zijlstra
On Wed, Oct 08, 2014 at 03:37:26PM -0400, r...@redhat.com wrote: + sched_domains_numa_hops = kzalloc(sizeof(int) * nr_node_ids * nr_node_ids, GFP_KERNEL); + if (!sched_domains_numa_hops) + return; That's potentially a _BIG_ table (1M for a 512 node system). The

Re: [PATCH 3/4] mm: gup: use get_user_pages_fast and get_user_pages_unlocked

2014-10-12 Thread Andrea Arcangeli
On Thu, Oct 09, 2014 at 12:52:45PM +0200, Peter Zijlstra wrote: On Wed, Oct 01, 2014 at 10:56:36AM +0200, Andrea Arcangeli wrote: Just an optimization. Does it make sense to split the thing in two? One where you apply _unlocked and then one where you apply _fast? Yes but I already dropped

Re: [PATCH RFC 1/5] sched,numa: build table of node hop distance

2014-10-12 Thread Rik van Riel
On 10/12/2014 09:17 AM, Peter Zijlstra wrote: On Wed, Oct 08, 2014 at 03:37:26PM -0400, r...@redhat.com wrote: + sched_domains_numa_hops = kzalloc(sizeof(int) * nr_node_ids * nr_node_ids, GFP_KERNEL); + if (!sched_domains_numa_hops) + return; That's potentially a

Re: [GIT] Security subsystem upate for 3.18

2014-10-12 Thread Linus Torvalds
On Fri, Oct 10, 2014 at 4:23 AM, James Morris jmor...@namei.org wrote: One of these is from merging with your v3.16, and the other from a merge of the keys tree. That's about all I understand of it. Please don't do back-merges. What was the reason for that v3.16 merge? It only caused

Re: [RFC] drop owner assignment from platform_drivers

2014-10-12 Thread Greg KH
On Sun, Oct 12, 2014 at 07:51:46AM +0200, Wolfram Sang wrote: I missed the one code path you pointed out, and that should be fixed, but that doesn't mean that the original patch should be reverted, as it is the way we want things to be, let's just fix up the bug and move on. OK, that is

Re: [PATCH] Input: i8042 - disable active multiplexing by default

2014-10-12 Thread Pavel Machek
On Fri 2014-10-10 13:51:31, Dmitry Torokhov wrote: Active multiplexing is a nice feature as it allows several pointing devices (such as touchpad and external mouse) use their native protocols at the same time. Unfortunately many manufacturers do not implement the feature properly even though

Re: [PATCH] reset: socfpga: use arch_initcall for early initialization

2014-10-12 Thread Pavel Machek
Hi! From: Dinh Nguyen dingu...@opensource.altera.com There are certain drivers that are required to get loaded very early using arch_initcall. An example of such a driver is the SOCFPGA's FPGA bridge driver. This driver has to get loaded early because it needs to enable FPGA components

Re: Machine crashes right *after* ~successful resume

2014-10-12 Thread Pavel Machek
Hi! Rafael, including you on this since http://linuxconcloudopenna2013.sched.org/event/d708f47d07cd44b9669610778c024708#.VDRzTDS_EUF mentions you as the maintainer for Linux + power management. I hope this is still accurate. Since Linux 3.12 (Debian version 3.12.9-1~bpo70+1) and all the

Re: [PATCH RFC 2/5] sched,numa: classify the NUMA topology of a system

2014-10-12 Thread Peter Zijlstra
On Wed, Oct 08, 2014 at 03:37:27PM -0400, r...@redhat.com wrote: +static void init_numa_topology_type(void) +{ + int a, b, c, n; + + n = sched_domains_numa_levels; + + if (n = 1) + sched_numa_topology_type = NUMA_DIRECT; + + for_each_online_node(a) { +

Re: [GIT] Security subsystem upate for 3.18

2014-10-12 Thread Linus Torvalds
On Sun, Oct 12, 2014 at 10:12 AM, Linus Torvalds torva...@linux-foundation.org wrote: Give me a synopsis of what has changed and why I should pull. Side note: this is not just for me personally (so that I have a better overview of what is going on during the merge window), but also so that I

Persoenlichen Brief: /

2014-10-12 Thread Herr Juan Morato
Guten Tag, Ich bin Herr Juan Morato, der Auditor General von Unicaja Bank Madrid. Im Zuge meiner Abschlusspruefung, entdeckte ich eine schwimmende Fonds auf einem Konto, das 1990 bei der Cam Bank eroeffnet wurde, bevor der Besitz von Unicaja Gruppe gekauft wurde, ich bin der Abschlusspruefer

Re: [PATCH RFC 3/5] sched,numa: preparations for complex topology placement

2014-10-12 Thread Peter Zijlstra
On Wed, Oct 08, 2014 at 03:37:28PM -0400, r...@redhat.com wrote: From: Rik van Riel r...@redhat.com Preparatory patch for adding NUMA placement on systems with complex NUMA topology. Also fix a potential divide by zero in group_weight() Signed-off-by: Rik van Riel r...@redhat.com ---

CRASH during boot 3.16.3+

2014-10-12 Thread Udo van den Heuvel
Hello, 3.16.2 boots and works fine. Kernels 3.16.3 and newer crash very early during boot. (did not yet try 3.17) The problem: During the first few seconds of bootup the kernel gets into some sort of loop and rapidly prints loads of register-like things and then a load of rubbish. I did `make

Re: [PATCH] Route keyboard LEDs through the generic LEDs layer.

2014-10-12 Thread Pali Rohár
Hello, I would like to ask if something was changed and if this patch (in any way) is going to mainline kernel. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: [PATCH RFC 4/5] sched,numa: calculate node scores in complex NUMA topologies

2014-10-12 Thread Peter Zijlstra
On Wed, Oct 08, 2014 at 03:37:29PM -0400, r...@redhat.com wrote: From: Rik van Riel r...@redhat.com In order to do task placement on systems with complex NUMA topologies, it is necessary to count the faults on nodes nearby the node that is being examined for a potential move. In case of a

Re: [PATCH RFC 5/5] sched,numa: find the preferred nid with complex NUMA topology

2014-10-12 Thread Peter Zijlstra
On Wed, Oct 08, 2014 at 03:37:30PM -0400, r...@redhat.com wrote: +static int preferred_group_nid(struct task_struct *p, int nid) +{ + nodemask_t nodes; + int hops; + + /* Direct connections between all NUMA nodes. */ + if (sched_numa_topology_type == NUMA_DIRECT) +

Re: [GIT] Security subsystem upate for 3.18

2014-10-12 Thread Paul Moore
On Sunday, October 12, 2014 10:12:28 AM Linus Torvalds wrote: On Fri, Oct 10, 2014 at 4:23 AM, James Morris jmor...@namei.org wrote: One of these is from merging with your v3.16, and the other from a merge of the keys tree. That's about all I understand of it. Please don't do back-merges.

Re: Machine crashes right *after* ~successful resume

2014-10-12 Thread Wilmer van der Gaast
Hello, Many thanks for your response! On 12-10-14 15:30, Pavel Machek wrote: Has it ever worked ok? ...aha, in 3.10, ok. Correct. And I've tried a few more kernels now, compiled on my own. 3.17 still has this issue, 3.10 is completely fine all the way up to 3.10.57 (I've tested just under

Re: [GIT] Security subsystem upate for 3.18

2014-10-12 Thread Linus Torvalds
On Sun, Oct 12, 2014 at 11:04 AM, Paul Moore pmo...@redhat.com wrote: Nothing other than that a merge was done. To be honest I wasn't sure any additional comment was needed since it was a clean merge without any conflict; my process has only been to add commentary when there were conflicts

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-10-12 Thread Andev
Hello Bertrand, Does this need any user space support? Cos currently on a debian testing box(powerpc) enabling this options causes a boot hang while mounting the root file system. I install the kernel after creating a deb package by 'make deb-pkg'. Config attached. Thanks, On Tue, Aug 19, 2014

[PATCH] staging: lustre: lustre: ptlrpc: sec.c: Replacing strncat with strlcat to avoid overwrite size

2014-10-12 Thread Rickard Strandqvist
Changed from using strncat with strlcat to avoid overwrite the max size. Take the opportunity to change a snprint to strlcpy. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/staging/lustre/lustre/ptlrpc/sec.c |5 ++--- 1 file changed, 2 insertions(+), 3

Re: [GIT] Security subsystem upate for 3.18

2014-10-12 Thread Linus Torvalds
One more comment on this.. On Sun, Oct 12, 2014 at 11:50 AM, Linus Torvalds torva...@linux-foundation.org wrote: - you actively need infrastructure from newer versions, so you need to merge an upstream kernel for further development. Even this is often questionable, but it's one of the

[PATCH] kernel/groups.c: Code simplifications

2014-10-12 Thread Eric Biggers
Reduce nesting and simplify the control flow, remove redundant 'gidsetsize 0' check in sys_getgroups(), and inline groups_to_user(). This patch reduces the length of kernel/groups.c by 27 lines. Signed-off-by: Eric Biggers ebigge...@gmail.com --- kernel/groups.c | 69

Re: [U-Boot] [PATCH resend] kconfig: Fix compiler warning in menu.c

2014-10-12 Thread Jeroen Hofstee
Hello Hans, On 12-10-14 12:25, Hans de Goede wrote: Hi, This one seems to have fallen through the cracks. Regards, Hans (for U-boot) nope, you replace an innocent warning (_might_ be) with bad code, without any comment it is just because gcc failed to recognize it is fine. Nor did you

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-10-12 Thread Willy Tarreau
Hi, On Sun, Oct 12, 2014 at 11:50:59AM -0400, Andev wrote: Hello Bertrand, Does this need any user space support? Cos currently on a debian testing box(powerpc) enabling this options causes a boot hang while mounting the root file system. I suspect that your module-ini-tools/kmod are built

[PATCH] x86: Clean up stack access code in irq_32.c

2014-10-12 Thread Chuck Ebbert
Use C instead of asm for accessing the stack pointer. And define some macros to make the code easier to understand. Signed-off-by: Chuck Ebbert cebbert.l...@gmail.com diff --git a/arch/x86/include/asm/page_32_types.h b/arch/x86/include/asm/page_32_types.h index f48b17d..a8ca0cb 100644 ---

Re: [PATCH] dell-wmi: Fix access out of memory

2014-10-12 Thread Pali Rohár
On Tuesday 30 September 2014 01:16:23 Darren Hart wrote: On September 29, 2014 4:26:03 PM PDT, Rafael J. Wysocki r...@rjwysocki.net wrote: On Monday, September 29, 2014 02:30:29 PM Darren Hart wrote: On Mon, Sep 29, 2014 at 03:10:51PM +0200, Pali Rohár wrote: Without this patch driver

Re: [PATCH] x86: Clean up stack access code in irq_32.c

2014-10-12 Thread H. Peter Anvin
We changed this to asm because the C broke some compilers. Why are you changing it back? On October 12, 2014 9:43:53 AM PDT, Chuck Ebbert cebbert.l...@gmail.com wrote: Use C instead of asm for accessing the stack pointer. And define some macros to make the code easier to understand.

Re: [PATCH] x86: Clean up stack access code in irq_32.c

2014-10-12 Thread Chuck Ebbert
On Sun, 12 Oct 2014 09:47:53 -0700 H. Peter Anvin h...@zytor.com wrote: [replying to the list this time, sigh] We changed this to asm because the C broke some compilers. Why are you changing it back? The C broke some compilers because it was using a global register variable. This is a

[PATCH] Staging: wlan-ng: prism2 simple style modifications

2014-10-12 Thread Erich Cordoba Malibran
From: Erich Cordoba erich.cord...@yandex.com prism2fw.c prism2sta.c Fixed style warning reported by checkpatch.pl prism2mib.c Renamed function prism2mib_framenthreshold to meet style guidelines. Signed-off-by: Erich Cordoba Malibran erich.cord...@yandex.com ---

[PATCH] vfs: Deduplicate code shared by xattr system calls operating on paths

2014-10-12 Thread Eric Biggers
The following pairs of system calls dealing with extended attributes only differ in their behavior on whether the symbolic link is followed (when the named file is a symbolic link): - setxattr() and lsetxattr() - getxattr() and lgetxattr() - listxattr() and llistxattr() - removexattr() and

Re: [RFC] drop owner assignment from platform_drivers

2014-10-12 Thread Wolfram Sang
So, what is your opinion on the original cleanup series removing unnecessary '.owner = THIS_MODULE' lines in drivers? Helpful? Noise? Helpful, please do it. I can take it all through my driver-core tree if you want, that might make things easier for others. Thanks, that might make sense

Re: [PATCH] vfs: Deduplicate code shared by xattr system calls operating on paths

2014-10-12 Thread Christoph Hellwig
On Sun, Oct 12, 2014 at 11:59:58AM -0500, Eric Biggers wrote: The following pairs of system calls dealing with extended attributes only differ in their behavior on whether the symbolic link is followed (when the named file is a symbolic link): - setxattr() and lsetxattr() - getxattr() and

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-10-12 Thread Andev
On Sun, Oct 12, 2014 at 12:40 PM, Willy Tarreau w...@1wt.eu wrote: Hi, On Sun, Oct 12, 2014 at 11:50:59AM -0400, Andev wrote: Hello Bertrand, Does this need any user space support? Cos currently on a debian testing box(powerpc) enabling this options causes a boot hang while mounting the

Re: [RFC PATCH 3/3] i2c: show and change bus frequency via sysfs

2014-10-12 Thread Guenter Roeck
On Sun, Oct 12, 2014 at 12:32:56PM +0300, Octavian Purdila wrote: On Sat, Oct 11, 2014 at 11:14 PM, Mark Roszko mark.ros...@gmail.com wrote: This seems limiting to arches with peripherals that can support a range of frequencies rather than fixed numbers. Also it creates some portability

Diagnostic and Monitoring Workgroup Participation?

2014-10-12 Thread Dominique Toupin
Hi, The Linux Foundation Board of Directors has accepted the Diagnostic and Monitoring (DiaMon) Workgroup, we will start taking about it next Monday in Düsseldorf at the Tracing Summit 2014 co-located with LinuxCon Europe. The goal of DiaMon is to improve open-source user-space, hardware and

Re: [PATCH] x86: Clean up stack access code in irq_32.c

2014-10-12 Thread H. Peter Anvin
That's not a justification for change. Claiming no harm is nevessary but not sufficient. On October 12, 2014 9:53:32 AM PDT, Chuck Ebbert cebbert.l...@gmail.com wrote: On Sun, 12 Oct 2014 09:47:53 -0700 H. Peter Anvin h...@zytor.com wrote: [replying to the list this time, sigh] We changed

modprobe nf_reject_ipv4 gives rcu errors wrt: Unknown symbol

2014-10-12 Thread Toralf Förster
Hi, at a KVM running a x86 stable Gentoo Linux I do get with v3.17-7671-gd0ca475 n22kvmclone linux # modprobe nf_reject_ipv4 modprobe: ERROR: could not insert 'nf_reject_ipv4': Unknown symbol in module, or unknown parameter (see dmesg) n22kvmclone linux # tail -n 7 /var/log/messages Oct 12

Re: unaligned accesses in SLAB etc.

2014-10-12 Thread David Miller
From: David Miller da...@davemloft.net Date: Sat, 11 Oct 2014 22:15:10 -0400 (EDT) I'm getting tons of the following on sparc64: [603965.383447] Kernel unaligned access at TPC[546b58] free_block+0x98/0x1a0 [603965.396987] Kernel unaligned access at TPC[546b60] free_block+0xa0/0x1a0

reboot housekeeping, lack thereof, is messing with me

2014-10-12 Thread Gene Heskett
To whomever is in charge of the supposedly volatile LCK.. files in /var/lock: Its my understanding that these files should be volatile when they represent a USB usage, because a USB device can be unplugged instantly and at any time. The device nicely and dutifully disappears from an 'ls /dev'

  1   2   3   4   5   6   7   8   >