Re: [RESEND RFC PATCH 0/2] Expose the PIO_ISR register on SAMA5D3

2015-12-19 Thread Jonathan Cameron
On 17/12/15 23:19, Peter Rosin wrote: > Hi Linus, > >> On Mon, Dec 14, 2015 at 11:38 AM, Peter Rosin wrote: >> >> I think I atleast half-understand what you're trying to do. > > Good. It's really not that complicated, but I'm perhaps not describing > it very clearly... > >>>

Re: [PATCH v3] Staging: iio: accel: Fixed NULL comparison style

2015-12-19 Thread Jonathan Cameron
On 13/12/15 15:15, Bhaktipriya Shridhar wrote: > The variable u8 **rx_p, is a pointer-to-pointer and hence the check > should > be "if (!*rx_p)" and not "if (!rx_p)". > In the earlier version, checkpatch.pl gave the following check, which > was incorrect: > CHECK: Comparison to NULL could be

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

2015-12-19 Thread Julian Margetson
On 12/19/2015 1:05 PM, Måns Rullgård wrote: Andy Shevchenko writes: On Sat, Dec 19, 2015 at 5:40 PM, Måns Rullgård wrote: OK, I've found something. The dma setup errors are benign, caused by the driver calling dmaengine_prep_slave_sg() even for

Re: [PATCH V7 24/24] perf tools: adding coresight etm PMU record capabilities

2015-12-19 Thread Rabin Vincent
On Fri, Dec 18, 2015 at 01:59:20PM -0700, Mathieu Poirier wrote: > +struct auxtrace_record > +*auxtrace_record__init(struct perf_evlist *evlist, int *err) > +{ > + struct perf_pmu *cs_etm_pmu; > + struct perf_evsel *evsel; > + bool found_etm = false; > + > + cs_etm_pmu =

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

2015-12-19 Thread Julian Margetson
On 12/19/2015 1:19 PM, Måns Rullgård wrote: Julian Margetson writes: On 12/19/2015 1:05 PM, Måns Rullgård wrote: Andy Shevchenko writes: On Sat, Dec 19, 2015 at 5:40 PM, Måns Rullgård wrote: OK, I've found something. The dma

Re: [PATCH] mm, oom: initiallize all new zap_details fields before use

2015-12-19 Thread Kirill A. Shutemov
On Fri, Dec 18, 2015 at 08:04:51PM -0500, Sasha Levin wrote: > Commit "mm, oom: introduce oom reaper" forgot to initialize the two new fields > of struct zap_details in unmap_mapping_range(). This caused using stack > garbage > on the call to unmap_mapping_range_tree(). > > Signed-off-by: Sasha

[patch 4/5] futex: Remove pointless put_pi_state calls in requeue()

2015-12-19 Thread Thomas Gleixner
In the error handling cases we neither have pi_state nor a reference to it. Remove the pointless code. Signed-off-by: Thomas Gleixner --- kernel/futex.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) --- a/kernel/futex.c +++ b/kernel/futex.c @@ -1737,9

[patch 3/5] futex: Document pi_state refcounting in requeue code

2015-12-19 Thread Thomas Gleixner
Documentation of the pi_state refcounting in the requeue code is non existent. Add it. Signed-off-by: Thomas Gleixner --- kernel/futex.c | 36 +--- 1 file changed, 33 insertions(+), 3 deletions(-) --- a/kernel/futex.c +++ b/kernel/futex.c

[patch 5/5] futex: Cleanup the goto confusion in requeue_pi()

2015-12-19 Thread Thomas Gleixner
out_unlock: does not only drop the locks, it also drops the refcount on the pi_state. Really intuitive. Move the label after the put_pi_state() call and use 'break' in the error handling path of the requeue loop. Signed-off-by: Thomas Gleixner --- kernel/futex.c |5

[patch 1/5] futex: Drop refcount if requeue_pi() acquired the rtmutex

2015-12-19 Thread Thomas Gleixner
If the proxy lock in the requeue loop acquires the rtmutex for a waiter then it acquired also refcount on the pi_state related to the futex, but the waiter side does not drop the reference count. Add the missing free_pi_state() call. Signed-off-by: Thomas Gleixner Cc:

RE: [PATCH v9 0/7] PCI: hv: New paravirtual PCI front-end for Hyper-V VMs

2015-12-19 Thread Thomas Gleixner
On Sat, 19 Dec 2015, KY Srinivasan wrote: > > From: Thomas Gleixner [mailto:t...@linutronix.de] > > On Tue, 15 Dec 2015, KY Srinivasan wrote: > > > > > > Of these 7 patches, Greg has committed all of the VMBUS > > > related supporting patches (3 patches). Thomas, can you > > > take the IRQ related

[PATCH] nvmem: delete unneeded IS_ERR test

2015-12-19 Thread Julia Lawall
devm_kzalloc returns NULL rather than an ERR_PTR value. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression x,e; @@ * x = devm_kzalloc(...) ... when != x = e * IS_ERR(x) // Signed-off-by: Julia Lawall ---

Re: [PATCH] iio: add ad5761 DAC driver

2015-12-19 Thread Jonathan Cameron
On 16/12/15 13:27, Ricardo Ribalda Delgado wrote: > ad5761 is a 1-channel DAC with configurable output range. > The driver uses the regulator interface for its voltage ref. > > It shares its register layout with ad5761r, ad5721 and ad5721r. > > Differences: > ad5761* are 16 bit, ad5721* are 12

[RFC PATCH] can: sja1000: of: add per-compatible init hook

2015-12-19 Thread Damien Riegel
This commit adds the capability to allocate and init private data embedded in the sja1000_priv structure on a per-compatible basis. The device node is passed as a parameter of the init callback to allow parsing of custom device tree properties. Signed-off-by: Damien Riegel

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

2015-12-19 Thread Andy Shevchenko
On Sat, Dec 19, 2015 at 7:09 PM, Julian Margetson wrote: > Still can't get the patch applied . It might be faster if you just edit (remove 3 lines) directly in the file. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

2015-12-19 Thread Måns Rullgård
Julian Margetson writes: > On 12/19/2015 1:19 PM, Måns Rullgård wrote: >> Julian Margetson writes: >> >>> On 12/19/2015 1:05 PM, Måns Rullgård wrote: Andy Shevchenko writes: > On Sat, Dec 19, 2015 at 5:40 PM, Måns

[patch 0/5] futex: Plug a pi_state leak and clarify the refcounting

2015-12-19 Thread Thomas Gleixner
A recent patch claimed that there is a double free in the requeue_pi code, which is not the case. While analysing the issue I found the contrary, i.e. a leak. This series fixes the leak and clarifies the code so it's more clear how that refcounting on the pi state works. Thanks, tglx

[patch 2/5] futex: Rename free_pi_state() to put_pi_state()

2015-12-19 Thread Thomas Gleixner
free_pi_state() is confusing as it is in fact only freeing/caching the pi state when the last reference is gone. Rename it to put_pi_state() which reflects better what it is doing. Signed-off-by: Thomas Gleixner --- kernel/futex.c | 17 ++--- 1 file changed, 10

Re: [PATCH] USB-FHCI: Use a signed return type for fhci_create_ep()

2015-12-19 Thread Dan Carpenter
Just make it an int. The caller also casts it to u32... regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [PATCH] [media] gsc-m2m: Use an unsigned data type for a variable

2015-12-19 Thread Dan Carpenter
On Sat, Dec 19, 2015 at 04:23:11PM +0100, SF Markus Elfring wrote: > diff --git a/drivers/media/platform/exynos-gsc/gsc-m2m.c > b/drivers/media/platform/exynos-gsc/gsc-m2m.c > index d82e717..f2c091c 100644 > --- a/drivers/media/platform/exynos-gsc/gsc-m2m.c > +++

[PATCH v2] RDS: don't pretend to use cpu notifiers

2015-12-19 Thread Santosh Shilimkar
From: Sebastian Andrzej Siewior It looks like an attempt to use CPU notifier here which was never completed. Nobody tried to wire it up completely since 2k9. So I unwind this code and get rid of everything not required. Oh look! 19 lines were removed while code still does

Re: [PATCH] Input: xpad - use LED API when identifying wireless controllers

2015-12-19 Thread Clement Calmels
On Wed, 16 Dec 2015 14:44:08 -0800 Dmitry Torokhov wrote: > When lighting up the segment identifying wireless controller, Instead > of sending command directly to the controller, let's do it via LED > API (usinf led_set_brightness) so that LED object state is in sync >

[PATCH 2/9 v2] usb: host: max3421-hcd: use list_for_each_entry*

2015-12-19 Thread Geliang Tang
Use list_for_each_entry*() instead of list_for_each*() to simplify the code. Signed-off-by: Geliang Tang --- Changes in v2: - drop changes in max3421_select_and_start_urb(). --- drivers/usb/host/max3421-hcd.c | 16 +--- 1 file changed, 5 insertions(+), 11

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

2015-12-19 Thread Måns Rullgård
Julian Margetson writes: > On 12/19/2015 11:40 AM, Måns Rullgård wrote: >> OK, I've found something. The dma setup errors are benign, caused by >> the driver calling dmaengine_prep_slave_sg() even for non-dma >> operations. The real error is the lock recursion that's reported

Re: [PATCH v1 0/6] Support the rk3036 Kylin board

2015-12-19 Thread Heiko Stübner
Hi Caesar, Am Donnerstag, 17. Dezember 2015, 22:21:46 schrieb Caesar Wang: > Kylin-board is based on RK3036 SOCs, add the initiation > version for working. I've applied: - patch1 (please include the "rockchip:" part in dts subjects) - patch3 (dito) - patch4 (after merging in patch6 and dropping

Re: [PATCH v2] serial: 8250: add gpio support to exar

2015-12-19 Thread Sudip Mukherjee
On Sat, Dec 19, 2015 at 04:43:20PM +, One Thousand Gnomes wrote: > On Sat, 19 Dec 2015 20:53:57 +0530 > Sudip Mukherjee wrote: Hi Alan, > > > Exar XR17V352/354/358 chips have 16 multi-purpose inputs/outputs which > > can be controlled using gpio interface. > >

[PATCH] tty: vt: use memdup_user to reuse the code

2015-12-19 Thread Rahul Pathak
Fixing coccicheck warning which recommends to use memdup_user instead to reimplement its code, using memdup_user simplifies the code ./drivers/tty/vt/keyboard.c:1709:9-16: WARNING opportunity for memdup_user ./drivers/tty/vt/keyboard.c:1752:9-16: WARNING opportunity for memdup_user

Re: [PATCH v4 1/2] serial: rewrite pxa2xx-uart to use 8250_core

2015-12-19 Thread Sergei Ianovich
On Sat, 2015-12-19 at 14:26 +0100, Robert Jarzmik wrote: > Robert Jarzmik writes: > > > Sergei Ianovich writes: > > > > > pxa2xx-uart was a separate uart platform driver. It was declaring > > > the same device names and numbers as 8250 driver. As a

[PATCH] SCSI-lpfc: Use a signed return type for two functions

2015-12-19 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 19 Dec 2015 19:32:27 +0100 The return type "size_t" was used by the functions "lpfc_wwn_set" and "lpfc_oas_lun_state_set" despite of the aspect that they will eventually return a negative error code. Improve this implementation

Re: [PATCH] Staging: comedi: pcmcia: fixed a line with over 80 chars

2015-12-19 Thread Philippe Loctaux
Sorry I didn't read the doc correctly! -- Philippe Loctaux p...@philippeloctaux.com On Fri, Dec 18, 2015 at 03:00:42PM -0800, Greg KH wrote: > On Sun, Dec 13, 2015 at 05:40:34PM +0100, Philippe Loctaux wrote: > > This patch fixes the checkpatch.pl warning: > > > > WARNING: line over 80

[PATCH] USB-FHCI: Use a signed return type for fhci_create_ep()

2015-12-19 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 19 Dec 2015 21:10:20 +0100 The return type "u32" was used by the fhci_create_ep() function even though it will eventually return a negative error code. Improve this implementation detail by using the type "s32" instead. This issue

Re: [PATCH] ti-st: Use a signed return type for st_ll_sleep_state()

2015-12-19 Thread Dan Carpenter
It returns zero or negative error codes. The return value is never checked. Make it an int. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: net, ipv6: out of bounds access in secret_stable

2015-12-19 Thread Cong Wang
On Fri, Dec 18, 2015 at 5:13 PM, Sasha Levin wrote: > Hi Hannes, > > I've hit the following out of bounds access while fuzzing on the latest -next > kernel. > > This code was added in 3d1bec9932 ("ipv6: introduce secret_stable to > ipv6_devconf"). > > [ 459.553655] BUG:

Re: [PATCH V3] Fix INT1 Recursion with unregistered breakpoints

2015-12-19 Thread Jeff Merkey
On 12/19/15, Thomas Gleixner wrote: > On Mon, 14 Dec 2015, Jeff Merkey wrote: >> +/* >> +* check if we got an execute breakpoint >> +* from the dr7 register. if we did, set >> +* the resume flag to avoid int1 recursion. > >

Re: pinctrl-adi2: Use a signed return type for adi_gpio_irq_startup()

2015-12-19 Thread SF Markus Elfring
>>> This introduces a compile warning. >> >> How do you think about to show the exact message you get? > > I can't actually compile it myself. It seems that I can understand your feedback also a bit better since I received the information from a background process like "kbuild test robot". Will

Re: [PATCH v4 0/2] IIO version of INA2xx

2015-12-19 Thread Jonathan Cameron
On 18/12/15 17:23, Marc Titinger wrote: > v4: > * squash previous small fixes into one patch and catch up with fixes from >linux-iio git, 'testing' branch. > * fix endianness hint by the use of IIO_CPU, following Andrew's comment > * fix spacing issue. > * add separate ABI documentation

Re: [PATCH v2] serial: 8250: add gpio support to exar

2015-12-19 Thread One Thousand Gnomes
On Sat, 19 Dec 2015 20:53:57 +0530 Sudip Mukherjee wrote: > Exar XR17V352/354/358 chips have 16 multi-purpose inputs/outputs which > can be controlled using gpio interface. > Add support to use these pins and select GPIO_SYSFS also so that these > pins can be used

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

2015-12-19 Thread Måns Rullgård
Julian Margetson writes: > On 12/19/2015 1:05 PM, Måns Rullgård wrote: >> Andy Shevchenko writes: >> >>> On Sat, Dec 19, 2015 at 5:40 PM, Måns Rullgård wrote: >>> OK, I've found something. The dma setup errors are benign,

Re: [LKP] [lkp] [x86/irq] 4c24cee6b2: IP-Config: Auto-configuration of network failed

2015-12-19 Thread Thomas Gleixner
On Tue, 15 Dec 2015, Jiang Liu wrote: > Hi Boris and Ying, > Aha, found a possible regression. Could you please help to > apply the attached bugfix patch ontop of "cc22b9b83f6a x86/irq: > Enhance __assign_irq_vector() to rollback in case of failure"? > Hi Ying, I have push this patch to

Re: pinctrl-adi2: Use a signed return type for adi_gpio_irq_startup()

2015-12-19 Thread Dan Carpenter
On Sat, Dec 19, 2015 at 09:40:27PM +0100, SF Markus Elfring wrote: > > This introduces a compile warning. > > How do you think about to show the exact message you get? > I can't actually compile it myself. > > > These functions are supposed to return 1 if there is an IRQ pending. > > Change

Re: [PATCH] USB-FHCI: Use a signed return type for fhci_create_ep()

2015-12-19 Thread Sergei Shtylyov
Hello. On 12/19/2015 11:15 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Sat, 19 Dec 2015 21:10:20 +0100 The return type "u32" was used by the fhci_create_ep() function even though it will eventually return a negative error code. Improve this

Re: [PATCH] veth: don't modify ip-summed; doing so treats packets with bad checksums as good.

2015-12-19 Thread Cong Wang
On Sat, Dec 19, 2015 at 1:01 PM, Cong Wang wrote: > On Fri, Dec 18, 2015 at 11:42 AM, Vijay Pandurangan wrote: >> Evan and I have demonstrated this bug on Kubernetes as well, so it's >> not just a problem in Mesos. (See >>

Re: [PATCH] pinctrl-adi2: Use a signed return type for adi_gpio_irq_startup()

2015-12-19 Thread kbuild test robot
Hi Markus, [auto build test WARNING on pinctrl/for-next] [also build test WARNING on v4.4-rc5 next-20151218] url: https://github.com/0day-ci/linux/commits/SF-Markus-Elfring/pinctrl-adi2-Use-a-signed-return-type-for-adi_gpio_irq_startup/20151220-010253 base:

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

2015-12-19 Thread Andy Shevchenko
On Sat, Dec 19, 2015 at 5:40 PM, Måns Rullgård wrote: > OK, I've found something. The dma setup errors are benign, caused by > the driver calling dmaengine_prep_slave_sg() even for non-dma > operations. I suppose the following is a quick fix to avoid preparing descriptor for

Re: [PATCH] futex: Prevent pi_state from double freeing in case of error

2015-12-19 Thread Thomas Gleixner
On Fri, 18 Dec 2015, Davidlohr Bueso wrote: > On Fri, 18 Dec 2015, bhuvanesh_surach...@mentor.com wrote: > > > From: Bhuvanesh Surachari > > > > In case of error from rt_mutex_start_proxy_lock pi_state is freed > > twice in futex_requeue function. Hence removing

Re: [PATCH v5 4/7] dax: add support for fsync/sync

2015-12-19 Thread Dan Williams
On Fri, Dec 18, 2015 at 9:22 PM, Ross Zwisler wrote: > To properly handle fsync/msync in an efficient way DAX needs to track dirty > pages so it is able to flush them durably to media on demand. > > The tracking of dirty pages is done via the radix tree in struct >

Re: [PATCH V10 7/7] dma: qcom_hidma: add support for object hierarchy

2015-12-19 Thread Andy Shevchenko
On Thu, Dec 17, 2015 at 7:01 PM, Sinan Kaya wrote: > In order to create a relationship model between the channels and the > management object, we are adding support for object hierarchy to the > drivers. This patch simplifies the userspace application development. > We will

Re: [PATCH] pinctrl-adi2: Use a signed return type for adi_gpio_irq_startup()

2015-12-19 Thread Dan Carpenter
This introduces a compile warning. These functions are supposed to return 1 if there is an IRQ pending. Change the -EINVAL to 0. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

2015-12-19 Thread Julian Margetson
On 12/19/2015 3:07 PM, Måns Rullgård wrote: Julian Margetson writes: On 12/19/2015 1:19 PM, Måns Rullgård wrote: Julian Margetson writes: On 12/19/2015 1:05 PM, Måns Rullgård wrote: Andy Shevchenko writes: On Sat, Dec 19,

Re: [PATCH] SCSI-lpfc: Use a signed return type for two functions

2015-12-19 Thread Dan Carpenter
It returns zero or negative error codes. The callers expect int. The current code is harmless. It should return an int. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info

[PATCH v4 0/2] um: Protect memory mapped file

2015-12-19 Thread Mickaël Salaün
This series protect the memory mapped file. Changes since v3: * add Tristan Schmelcher's ack Changes since v2; addressed Tristan Schmelcher's comment: * remove the whole fchmod call [1/2] Changes since v1; addressed Richard Weinberger's comments: * add attacker model to the patch description

Re: [PATCH v2] x86/signal: Cleanup get_nr_restart_syscall

2015-12-19 Thread Andy Lutomirski
On Sat, Dec 19, 2015 at 6:43 AM, Dmitry V. Levin wrote: > Check for TS_COMPAT instead of TIF_IA32 to distinguish ia32 tasks > from 64-bit tasks. > Check for __X32_SYSCALL_BIT iff CONFIG_X86_X32_ABI is defined. LGTM. --Andy -- To unsubscribe from this list: send the line

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

2015-12-19 Thread Julian Margetson
On 12/19/2015 4:41 PM, Måns Rullgård wrote: Andy Shevchenko writes: On Sat, Dec 19, 2015 at 10:16 PM, Julian Margetson wrote: On 12/19/2015 3:07 PM, Måns Rullgård wrote: Julian Margetson writes: Total pages: 522752 [

Re: [PATCH] USB-FHCI: Use a signed return type for fhci_create_ep()

2015-12-19 Thread Dan Carpenter
On Sat, Dec 19, 2015 at 09:55:02PM +0100, SF Markus Elfring wrote: > > Just make it an int. > > Thanks for your suggestion. > > Will any more software developers prefer this data type > at some source code places? > Use s32 if the hardware spec specifies that you must. Otherwise prefer

Re: [PATCH] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2015-12-19 Thread Cong Wang
On Fri, Dec 18, 2015 at 11:34 AM, Vijay Pandurangan wrote: > Packets that arrive from real hardware devices have ip_summed == > CHECKSUM_UNNECESSARY if the hardware verified the checksums, or > CHECKSUM_NONE if the packet is bad or it was unable to verify it. The > current

Re: [PATCH] mm, oom: initiallize all new zap_details fields before use

2015-12-19 Thread Sasha Levin
On 12/19/2015 02:52 PM, Kirill A. Shutemov wrote: > On Fri, Dec 18, 2015 at 08:04:51PM -0500, Sasha Levin wrote: >> > Commit "mm, oom: introduce oom reaper" forgot to initialize the two new >> > fields >> > of struct zap_details in unmap_mapping_range(). This caused using stack >> > garbage >> >

Re: [PATCH 2/3] iio: mma8452: use enum for channel index

2015-12-19 Thread Jonathan Cameron
On 15/12/15 16:45, Martin Kepplinger wrote: > This gets rid of some magic numbers by adding an enum. > > Signed-off-by: Martin Kepplinger > Signed-off-by: Christoph Muellner Applied to the togreg branch of

Re: [PATCH 1/3] iio: mma8452: remove unused register description

2015-12-19 Thread Jonathan Cameron
On 15/12/15 16:44, Martin Kepplinger wrote: > Signed-off-by: Martin Kepplinger > Signed-off-by: Christoph Muellner Applied to the togreg branch of iio.git - initially pushed out as testing for the autobuilders to

[PATCH] pinctrl-adi2: Use a signed return type for adi_gpio_irq_startup()

2015-12-19 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 19 Dec 2015 17:55:39 +0100 The return type "unsigned int" was used by the adi_gpio_irq_startup() function despite of the aspect that it will eventually return a negative error code. Improve this implementation detail by deletion of

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

2015-12-19 Thread Måns Rullgård
Andy Shevchenko writes: > On Sat, Dec 19, 2015 at 5:40 PM, Måns Rullgård wrote: > >> OK, I've found something. The dma setup errors are benign, caused by >> the driver calling dmaengine_prep_slave_sg() even for non-dma >> operations. > > I suppose the

Re: [PATCH] iio: add ad5761 DAC driver

2015-12-19 Thread Peter Meerwald-Stadler
> ad5761 is a 1-channel DAC with configurable output range. > The driver uses the regulator interface for its voltage ref. some nitpicking below > It shares its register layout with ad5761r, ad5721 and ad5721r. > > Differences: > ad5761* are 16 bit, ad5721* are 12 bits. > ad57*1r have an

Re: [PATCH v4 1/2] serial: rewrite pxa2xx-uart to use 8250_core

2015-12-19 Thread Robert Jarzmik
Sergei Ianovich writes: > On Sat, 2015-12-19 at 14:26 +0100, Robert Jarzmik wrote: >> Robert Jarzmik writes: >> >> > Sergei Ianovich writes: >> > >> > > pxa2xx-uart was a separate uart platform driver. It was declaring >> > > the

Re: [PATCH] staging-slicoss: Use a signed return type for slic_card_locate()

2015-12-19 Thread Dan Carpenter
It returns zero or negative error codes. The callers expect int. It is harmless. It should just be int. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] USB-FHCI: Use a signed return type for fhci_create_ep()

2015-12-19 Thread SF Markus Elfring
> Just make it an int. Thanks for your suggestion. Will any more software developers prefer this data type at some source code places? > The caller also casts it to u32... Do you want to get rid of similar casts in affected functions? Regards, Markus -- To unsubscribe from this list: send

[PATCH] rsi: bool tests do not need comparison

2015-12-19 Thread Nicholas Mc Guire
This is an API consolidation only. Bool initializations should use true and false thus bool tests don't need an explicit comparison. Signed-off-by: Nicholas Mc Guire --- Found by coccinelle: scripts/coccinelle/misc/boolinit.cocci Patch was compile tested with:

[PATCH] rsi: consolidate kmalloc/memset 0 calls to kzalloc

2015-12-19 Thread Nicholas Mc Guire
This is an API consolidation only. The use of kmalloc + memset to 0 is equivalent to kzalloc. Signed-off-by: Nicholas Mc Guire --- Found by coccinelle script (relaxed version of scripts/coccinelle/api/alloc/kzalloc-simple.cocci) Patch was compile tested with: x86_64_defconfig

Re: [PATCH 3/3] iio: mma8452: add freefall detection for Freescale's accelerometers

2015-12-19 Thread Jonathan Cameron
On 15/12/15 16:45, Martin Kepplinger wrote: > This adds freefall event detection to the supported devices. It adds > the in_accel_x_mag_falling_en iio event attribute, which activates > freefall mode. > > In freefall mode, the current acceleration magnitude (AND combination > of all axis values)

[PATCH] IB/usnic: delete unneeded IS_ERR test

2015-12-19 Thread Julia Lawall
kzalloc doesn't return ERR_PTR, so there is no need to test for it. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression x,e; @@ * x = kzalloc(...) ... when != x = e * IS_ERR_OR_NULL(x) // Signed-off-by: Julia Lawall

Re: [PATCH] veth: don't modify ip-summed; doing so treats packets with bad checksums as good.

2015-12-19 Thread Cong Wang
On Fri, Dec 18, 2015 at 11:42 AM, Vijay Pandurangan wrote: > Evan and I have demonstrated this bug on Kubernetes as well, so it's > not just a problem in Mesos. (See > https://github.com/kubernetes/kubernetes/issues/18898) > Interesting... then this problem is much more serious

Re: [PATCH v5] serial: support for 16550A serial ports on LP-8x4x

2015-12-19 Thread Sergei Ianovich
On Tue, 2015-12-15 at 22:51 +0100, Arnd Bergmann wrote: > On Wednesday 16 December 2015 00:04:45 Sergei Ianovich wrote: > > +Examples (from pxa27x-lp8x4x.dts): > > + > > +   uart@9050 { > > By convention, the name should be 'serial', not 'uart'. > arch/arm/boot/dts/pxa2xx.dtsi uses

[GIT PULL REQUEST] md fixes for 4.4-rc

2015-12-19 Thread NeilBrown
The following changes since commit 9f9499ae8e6415cefc4fe0a96ad0e27864353c89: Linux 4.4-rc5 (2015-12-13 17:42:58 -0800) are available in the git repository at: git://neil.brown.name/md tags/md/4.4-rc5-fixes for you to fetch changes up to cb01c5496d2d9c0c862443561df16ff122db348f: Fix

[PATCH] regulator: wm8*: constify regulator_ops structures

2015-12-19 Thread Julia Lawall
The regulator_ops structures are never modified, so declare them as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/regulator/wm831x-dcdc.c |8 drivers/regulator/wm831x-isink.c |2 +-

Re: [PATCH V5 1/2] watchdog: Use static struct class watchdog_class in stead of pointer

2015-12-19 Thread Guenter Roeck
On 12/18/2015 08:22 PM, Pratyush Anand wrote: On 17/12/2015:06:56:27 AM, Guenter Roeck wrote: On 12/17/2015 04:23 AM, Pratyush Anand wrote: We need few sysfs attributes to know different status of a watchdog device. To do that, we need to associate .dev_groups with watchdog_class. So convert

[PATCH] ti-st: Use a signed return type for st_ll_sleep_state()

2015-12-19 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 19 Dec 2015 17:15:34 +0100 The return type "unsigned long" was used by the st_ll_sleep_state() function despite of the aspect that it will eventually return a negative error code. Improve this implementation detail by deletion of the

Re: [PATCH V7 04/24] coresight: moving PM runtime operations to core framework

2015-12-19 Thread Rabin Vincent
On Fri, Dec 18, 2015 at 01:59:00PM -0700, Mathieu Poirier wrote: > @@ -415,9 +418,13 @@ struct list_head *coresight_build_path(struct > coresight_device *csdev) > */ > void coresight_release_path(struct list_head *path) > { > + struct coresight_device *csdev; > struct coresight_node

Re: [PATCH V7 17/24] coresight: etb10: implementing AUX space API

2015-12-19 Thread Rabin Vincent
On Fri, Dec 18, 2015 at 01:59:13PM -0700, Mathieu Poirier wrote: > +static void etb_update_buffer(struct coresight_device *csdev, > + struct perf_output_handle *handle, > + void *sink_config) > +{ > + int i, cur; > + u32 *buf_ptr; ... >

RE: [PATCH v9 0/7] PCI: hv: New paravirtual PCI front-end for Hyper-V VMs

2015-12-19 Thread KY Srinivasan
> -Original Message- > From: Thomas Gleixner [mailto:t...@linutronix.de] > Sent: Saturday, December 19, 2015 3:27 AM > To: KY Srinivasan > Cc: Jake Oshins ; gre...@linuxfoundation.org; linux- > ker...@vger.kernel.org;

Re: [PATCH v3 7/8] clk: rockchip: fix usbphy-related clocks

2015-12-19 Thread Heiko Stübner
Hi Kishon, Am Dienstag, 15. Dezember 2015, 16:22:32 schrieb Kishon Vijay Abraham I: > On Friday 20 November 2015 02:52 AM, Heiko Stuebner wrote: > > The otgphy clocks really only drive the phy blocks. These in turn > > contain plls that then generate the 480m clocks the clock controller > > uses

Re: [PATCH V7 00/24] Coresight integration with perf

2015-12-19 Thread Rabin Vincent
On Fri, Dec 18, 2015 at 01:58:56PM -0700, Mathieu Poirier wrote: > This patchset aims to integrate configuration and control of > the Coresight tracers with the perf sub-system. > > The goal is to use PMUs to represent tracers and the auxiliary > buffer enhancement to collect processor traces.

Re: [PATCH] natsemi: add checks for dma mapping errors

2015-12-19 Thread David Miller
From: Alexey Khoroshilov Date: Sat, 19 Dec 2015 15:06:45 +0300 > On 19.12.2015 05:36, David Miller wrote: >> From: Alexey Khoroshilov >> Date: Sat, 19 Dec 2015 00:55:37 +0300 >> >>> @@ -2093,6 +2099,10 @@ static netdev_tx_t start_tx(struct sk_buff >

[PATCH v4 2/2] um: Use race-free temporary file creation

2015-12-19 Thread Mickaël Salaün
Open the memory mapped file with the O_TMPFILE flag when available. Signed-off-by: Mickaël Salaün Cc: Jeff Dike Cc: Richard Weinberger Acked-by: Tristan Schmelcher --- arch/um/os-Linux/mem.c | 11 +++ 1 file

[PATCH v4 1/2] um: Do not set unsecure permission for temporary file

2015-12-19 Thread Mickaël Salaün
Remove the insecure 0777 mode for temporary file to prohibit other users to change the executable mapped code. An attacker could gain access to the mapped file descriptor from the temporary file (before it is unlinked) in a read-only mode but it should not be accessible in write mode to avoid

[PATCH] staging-slicoss: Use a signed return type for slic_card_locate()

2015-12-19 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 19 Dec 2015 20:30:39 +0100 The return type "u32" was used by the slic_card_locate() function despite of the aspect that it will eventually return a negative error code. Improve this implementation detail by using the type "s32"

Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance

2015-12-19 Thread Eric W. Biederman
Peter Hurley writes: > On 12/11/2015 11:40 AM, Eric W. Biederman wrote: >> Forcing newinstance for every mount of the devpts filesystem actually >> requires the association between /dev/ptmx and the currently mounted >> instance of devpts at /dev/pts. Simply

[GIT PULL] USB driver fixes for 4.4-rc6

2015-12-19 Thread Greg KH
The following changes since commit 9f9499ae8e6415cefc4fe0a96ad0e27864353c89: Linux 4.4-rc5 (2015-12-13 17:42:58 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.4-rc6 for you to fetch changes up to

[GIT PULL] TTY/Serial fixes for 4.4-rc6

2015-12-19 Thread Greg KH
The following changes since commit 527e9316f8ec44bd53d90fb9f611fa752bb9: Linux 4.4-rc4 (2015-12-06 15:43:12 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/ tags/tty-4.4-rc6 for you to fetch changes up to

Re: [PATCH v5] Fix INT1 Recursion with unregistered breakpoints

2015-12-19 Thread Jeff Merkey
> /* > + * Check if we got an execute breakpoint, if so > + * set the resume flag to avoid int1 recursion. > + */ > + if ((dr7 & (DR_RW_MASK << ((i * DR_CONTROL_SIZE) + > + DR_CONTROL_SHIFT))) == DR_RW_EXECUTE) >

Re: [PATCH v2 2/2] mfd: arizona: Update binding docs for selecting mono/stereo outputs

2015-12-19 Thread Rob Herring
On Mon, Dec 14, 2015 at 10:19:12AM +, Charles Keepax wrote: > Update the device tree binding documentation to include the wlf,out-mono > property that is used to specify whether each output is a mono or stereo > output. > > Signed-off-by: Charles Keepax >

Re: [PATCH v5] rtc: support DS1302 RTC on ICP DAS LP-8x4x

2015-12-19 Thread Rob Herring
On Tue, Dec 15, 2015 at 08:45:23PM +0300, Sergei Ianovich wrote: Nothing in this is specific to ICP, so the subject should be updated. > Signed-off-by: Sergei Ianovich > CC: Alexandre Belloni > --- >v4..v5 >* drop THIS_MODULE from

Re: [patch 5/5] futex: Cleanup the goto confusion in requeue_pi()

2015-12-19 Thread Darren Hart
On Sun, Dec 20, 2015 at 06:40:07AM +0100, Mike Galbraith wrote: > On Sat, 2015-12-19 at 21:15 -0800, Darren Hart wrote: > > > As a follow-on, I think it might be worthwhile to create a symmetrical > > get_pi_state() to the put_pi_state(), rather than handling the atomic_inc > > directly. > >

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

2015-12-19 Thread Måns Rullgård
Julian Margetson writes: > On 12/18/2015 10:34 PM, Andy Shevchenko wrote: >> On Sat, Dec 19, 2015 at 1:16 AM, Måns Rullgård wrote: >>> Julian Margetson writes: >>> On 12/18/2015 6:33 PM, Måns Rullgård wrote: > Julian Margetson

[PATCH] regulator: lp8788: constify regulator_ops structures

2015-12-19 Thread Julia Lawall
The regulator_ops structures are never modified, so declare them as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/regulator/lp8788-buck.c |4 ++-- drivers/regulator/lp8788-ldo.c |4 ++-- 2 files changed, 4 insertions(+), 4

Re: [PATCH v2] natsemi: add checks for dma mapping errors

2015-12-19 Thread David Miller
From: Alexey Khoroshilov Date: Sat, 19 Dec 2015 15:13:49 +0300 > refill_rx() and start_tx() do not check if mapping dma memory succeed. > The patch adds the checks and failure handling. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by:

Re: [PATCH v4 1/2] serial: rewrite pxa2xx-uart to use 8250_core

2015-12-19 Thread Sergei Ianovich
On Sat, 2015-12-19 at 20:31 +0100, Robert Jarzmik wrote: > Sergei Ianovich writes: > Thanks for spotting this. This is caused by a change in the latest > > version of the patch (SERIAL_8250_PXA instead of SERIAL_PXA). This > > change could be reverted. > Actually I'm against the

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

2015-12-19 Thread Andy Shevchenko
On Sat, Dec 19, 2015 at 10:16 PM, Julian Margetson wrote: > On 12/19/2015 3:07 PM, Måns Rullgård wrote: >> Julian Margetson writes: >>> Total pages: 522752 >>> [0.00] Kernel command line: root=/dev/sda8 console=ttyS0,115200 >>> console=tty1

[tip:x86/urgent] x86/paravirt: Prevent rtc_cmos platform device init on PV guests

2015-12-19 Thread tip-bot for David Vrabel
Commit-ID: d8c98a1d1488747625ad6044d423406e17e99b7a Gitweb: http://git.kernel.org/tip/d8c98a1d1488747625ad6044d423406e17e99b7a Author: David Vrabel AuthorDate: Fri, 11 Dec 2015 09:07:53 -0500 Committer: Thomas Gleixner CommitDate: Sat, 19

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

2015-12-19 Thread Måns Rullgård
Andy Shevchenko writes: > On Sat, Dec 19, 2015 at 10:16 PM, Julian Margetson wrote: >> On 12/19/2015 3:07 PM, Måns Rullgård wrote: >>> Julian Margetson writes: > Total pages: 522752 [0.00] Kernel command line:

Re: pinctrl-adi2: Use a signed return type for adi_gpio_irq_startup()

2015-12-19 Thread SF Markus Elfring
> This introduces a compile warning. How do you think about to show the exact message you get? > These functions are supposed to return 1 if there is an IRQ pending. > Change the -EINVAL to 0. Is there any more source code clean-up needed around the comment "FIXME" in the affected function?

Re: [PATCH] serial: atmel: remove module device table

2015-12-19 Thread Paul Gortmaker
[[PATCH] serial: atmel: remove module device table] On 18/12/2015 (Fri 15:49) Arnd Bergmann wrote: > A recent patch removed most of the module-specific code from the atmel > serial driver, but left the MODULE_DEVICE_TABLE in place, so we can't > build it any more: > >

[PATCH v5] Fix INT1 Recursion with unregistered breakpoints

2015-12-19 Thread Jeff Merkey
Please consider the attached patch. SUMMARY This patch corrects a hard lockup failure of the system kernel if the operating system receives a breakpoint exception at a code execution address which was not registered with the operating system. The patch allows kernel debuggers, application

  1   2   3   4   5   >