Re: sched: tweak select_idle_sibling to look for idle threads

2016-05-08 Thread Yuyang Du
On Sun, May 08, 2016 at 10:08:55AM +0200, Mike Galbraith wrote: > > Maybe give the criteria a bit margin, not just wakees tend to equal > > llc_size, > > but the numbers are so wild to easily break the fragile condition, like: > > Seems lockless traversal and averages just lets multiple CPUs

Re: [PATCH 1/6] statx: Add a system call to make enhanced file info available

2016-05-08 Thread J. Bruce Fields
On Mon, May 09, 2016 at 11:45:43AM +1000, Dave Chinner wrote: > [ OT, but I'll reply anyway :P ] > > On Fri, May 06, 2016 at 02:29:23PM -0400, J. Bruce Fields wrote: > > On Thu, May 05, 2016 at 08:56:02AM +1000, Dave Chinner wrote: > > > In the latest XFS filesystem format, we randomise the

[PATCH] sched: fix the calculation of __sched_period in sched_slice()

2016-05-08 Thread Zhou Chengming
When we get the sched_slice of a sched_entity, we use cfs_rq->nr_running to calculate the whole __sched_period. But cfs_rq->nr_running is the number of sched_entity in that cfs_rq, rq->nr_running is the number of all the tasks that are not throttled. So we should use the rq->nr_running to

[PATCH 2/3] staging: dgnc: remove redundant condition check

2016-05-08 Thread Daeseok Youn
dgnc_board(brd) was already checked for NULL before calling neo_parse_isr(). And also port doesn't need to check. Signed-off-by: Daeseok Youn --- drivers/staging/dgnc/dgnc_neo.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_neo.c

[PATCH 3/3] staging: dgnc: Need to check for NULL of ch

2016-05-08 Thread Daeseok Youn
the "ch" from brd structure could be NULL, it need to check for NULL. Signed-off-by: Daeseok Youn --- drivers/staging/dgnc/dgnc_neo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c

[PATCH 1/3] staging: dgnc: fix 'line over 80 characters'

2016-05-08 Thread Daeseok Youn
fix checkpatch.pl warning about 'line over 80 characters'. Signed-off-by: Daeseok Youn --- drivers/staging/dgnc/dgnc_sysfs.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_sysfs.c

RE: [PATCH] debugobjects: insulate non-fixup logic related to static obj from fixup callbacks

2016-05-08 Thread Du, Changbin
> From: Thomas Gleixner [mailto:t...@linutronix.de] > On Sun, 8 May 2016, Du, Changbin wrote: > > > From: Thomas Gleixner [mailto:t...@linutronix.de] > > > > raw_spin_unlock_irqrestore(>lock, flags); > > > > /* > > > > -* Maybe the object is static.

Re: [PATCH] mmc: mmc: do not use CMD13 to get status after speed mode switch

2016-05-08 Thread Shawn Lin
+ linux-rockchip I just hacked my local branch to fix the issues found on rockchip platform. The reaseon is that mmc core fail to get status after switching from hs200 to hs. So I disabled sending status for it just like what Chaotian does here. But I didn't deeply dig out the root cause but I

Re: sched: tweak select_idle_sibling to look for idle threads

2016-05-08 Thread Mike Galbraith
On Mon, 2016-05-09 at 02:57 +0800, Yuyang Du wrote: > On Sun, May 08, 2016 at 10:08:55AM +0200, Mike Galbraith wrote: > > > Maybe give the criteria a bit margin, not just wakees tend to equal > > > llc_size, > > > but the numbers are so wild to easily break the fragile condition, like: > > > >

Re: [PATCH v4 1/2] soc: qcom: smd: Introduce compile stubs

2016-05-08 Thread David Miller
From: Bjorn Andersson Date: Fri, 6 May 2016 07:09:07 -0700 > Introduce compile stubs for the SMD API, allowing consumers to be > compile tested. > > Acked-by: Andy Gross > Signed-off-by: Bjorn Andersson Applied.

Re: [PATCH v4 2/2] net: Add Qualcomm IPC router

2016-05-08 Thread David Miller
From: Bjorn Andersson Date: Fri, 6 May 2016 07:09:08 -0700 > From: Courtney Cavin > > Add an implementation of Qualcomm's IPC router protocol, used to > communicate with service providing remote processors. > > Signed-off-by:

Re: [PATCH v2] net: arc/emac: Move arc_emac_tx_clean() into arc_emac_tx() and disable tx interrut

2016-05-08 Thread David Miller
From: Caesar Wang Date: Fri, 6 May 2016 20:19:16 +0800 > Doing tx_clean() inside poll() may scramble the tx ring buffer if > tx() is running. This will cause tx to stop working, which can be > reproduced by simultaneously downloading two large files at high speed. > >

Re: [PATCH 0/2] Quiet noisy LSM denial when accessing net sysctl

2016-05-08 Thread David Miller
From: Tyler Hicks Date: Fri, 6 May 2016 18:04:12 -0500 > This pair of patches does away with what I believe is a useless denial > audit message when a privileged process initially accesses a net sysctl. The LSM folks can apply this if they agree with you.

Re: [PATCH] tools: bpf_jit_disasm: check for klogctl failure

2016-05-08 Thread David Miller
From: Daniel Borkmann Date: Fri, 06 May 2016 00:46:56 +0200 > On 05/06/2016 12:39 AM, Colin King wrote: >> From: Colin Ian King >> >> klogctl can fail and return -ve len, so check for this and >> return NULL to avoid passing a (size_t)-1 to

[PATCH -tip] sched/wake_q: fix typo in wake_q_add

2016-05-08 Thread Davidlohr Bueso
... the comment clearly refers to wake_up_q, and not wake_up_list. Signed-off-by: Davidlohr Bueso --- kernel/sched/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index c82ca6eccfec..c59e4df38591 100644 ---

Re: [PATCH V2 2/2] irqchip/gicv3-its: Implement two-level(indirect) device table support

2016-05-08 Thread Shanker Donthineni
On 05/08/2016 09:14 PM, Shanker Donthineni wrote: > Since device IDs are extremely sparse, the single, a.k.a flat table is > not sufficient for the following two reasons. > > 1) According to ARM-GIC spec, ITS hw can access maximum of 256(pages)* >64K(pageszie) bytes. In the best case, it

Re: sched: tweak select_idle_sibling to look for idle threads

2016-05-08 Thread Yuyang Du
On Mon, May 09, 2016 at 05:45:40AM +0200, Mike Galbraith wrote: > On Mon, 2016-05-09 at 02:57 +0800, Yuyang Du wrote: > > On Sun, May 08, 2016 at 10:08:55AM +0200, Mike Galbraith wrote: > > > > Maybe give the criteria a bit margin, not just wakees tend to equal > > > > llc_size, > > > > but the

[PATCH] sched/rt/deadline: Don't push if task's scheduling class was changed

2016-05-08 Thread Xunlei Pang
We got a warning below: WARNING: CPU: 1 PID: 2468 at kernel/sched/core.c:1161 set_task_cpu+0x1af/0x1c0 CPU: 1 PID: 2468 Comm: bugon Not tainted 4.6.0-rc3+ #16 Hardware name: Intel Corporation Broadwell Client 0086 89618374 8800897a7d50 8133dc8c

Re: [RFC PATCH v2 07/10] efi: load SSTDs from EFI variables

2016-05-08 Thread Jon Masters
Hi Octavian, Apologies for missing this earlier, just catching up on this thread... On 04/19/2016 06:39 PM, Octavian Purdila wrote: > This patch allows SSDTs to be loaded from EFI variables. It works by > specifying the EFI variable name containing the SSDT to be loaded. All > variables with

Re: sched: tweak select_idle_sibling to look for idle threads

2016-05-08 Thread Yuyang Du
On Mon, May 09, 2016 at 05:52:51AM +0200, Mike Galbraith wrote: > On Mon, 2016-05-09 at 02:57 +0800, Yuyang Du wrote: > > > In addition, I would argue maybe beefing up idle balancing is a more > > productive way to spread load, as work-stealing just does what needs > > to be done. And seems it

Re: [PATCH] Use pid_t instead of int

2016-05-08 Thread René Nyffenegger
Somewhere else, pid_t is a typedef for an int. Rene On 09.05.2016 03:25, Andy Lutomirski wrote: > On Sun, May 8, 2016 at 12:38 PM, René Nyffenegger > wrote: >> Use pid_t instead of int in the declarations of sys_kill, sys_tgkill, >> sys_tkill and sys_rt_sigqueueinfo in

Re: [patch] qede: uninitialized variable in qede_start_xmit()

2016-05-08 Thread David Miller
From: Dan Carpenter Date: Thu, 5 May 2016 16:21:30 +0300 > "data_split" was never set to false. It's just uninitialized. > > Fixes: 2950219d87b0 ('qede: Add basic network device support') > Signed-off-by: Dan Carpenter Applied, thanks Dan.

Re: sched: tweak select_idle_sibling to look for idle threads

2016-05-08 Thread Mike Galbraith
On Mon, 2016-05-09 at 02:57 +0800, Yuyang Du wrote: > In addition, I would argue maybe beefing up idle balancing is a more > productive way to spread load, as work-stealing just does what needs > to be done. And seems it has been (sub-unconsciously) neglected in this > case, :) P.S. Nope, I'm

RE:Drawstring bags

2016-05-08 Thread Jack
Dear purchasing manager, We have rich experience in manufacturing and exporting all kinds of bags, We have our own production base with advanced machine equipment, and employ professional workforce of technicians and engineers. Our products range from tote bags, drawstring bags, luggage bags,

Re: [PATCH 1/2] kernel: Add noaudit variant of ns_capable()

2016-05-08 Thread Serge Hallyn
Quoting Tyler Hicks (tyhi...@canonical.com): > When checking the current cred for a capability in a specific user > namespace, it isn't always desirable to have the LSMs audit the check. > This patch adds a noaudit variant of ns_capable() for when those > situations arise. > > The common logic

Re: [PATCH 2/2] net: Use ns_capable_noaudit() when determining net sysctl permissions

2016-05-08 Thread Serge Hallyn
Quoting Tyler Hicks (tyhi...@canonical.com): > The capability check should not be audited since it is only being used > to determine the inode permissions. A failed check does not indicate a > violation of security policy but, when an LSM is enabled, a denial audit > message was being generated. >

[GIT] Networking

2016-05-08 Thread David Miller
1) Check klogctl failure correctly, from Colin Ian King. 2) Prevent OOM when under memory pressure in flowcache, from Steffen Klassert. 3) Fix info leak in llc and rtnetlink ifmap code, from Kangjie Lu. 4) Memory barrier and multicast handling fixes in bnxt_en, from Michael Chan. 5)

[PATCH -tip 0/4] locking/rwsem (xadd): Reader waiter optimizations

2016-05-08 Thread Davidlohr Bueso
Hi, This is a follow up series while reviewing Waiman's reader-owned state work[1]. While I have based it on -tip instead of that change, I can certainly rebase the series in some future iteration. Changes are mainly around reader-waiter optimizations, in no particular order. Has passed numerous

[PATCH 4/4] locking/rwsem: Rework zeroing reader waiter->task

2016-05-08 Thread Davidlohr Bueso
Readers that are awoken will expect a nil ->task indicating that a wakeup has occurred. There is a mismatch between the smp_mb() and its documentation, in that the serialization is done between reading the task and the nil store. Furthermore, in addition to having the overlapping of loads and

[PATCH 3/4] locking/rwsem: Enable lockless waiter wakeup(s)

2016-05-08 Thread Davidlohr Bueso
As wake_qs gain users, we can teach rwsems about them such that waiters can be awoken without the wait_lock. This is for both readers and writer, the former being the most ideal candidate as we can batch the wakeups shortening the critical region that much more -- ie writer task blocking a bunch

[PATCH 1/4] locking/rwsem: Avoid stale ->count for rwsem_down_write_failed()

2016-05-08 Thread Davidlohr Bueso
The field is obviously updated w.o the lock and needs a READ_ONCE while waiting for lock holder(s) to go away, just like we do with all other ->count accesses. Signed-off-by: Davidlohr Bueso --- kernel/locking/rwsem-xadd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] mm/zsmalloc: avoid unnecessary iteration in get_pages_per_zspage()

2016-05-08 Thread Minchan Kim
On Fri, May 06, 2016 at 06:33:42PM +0900, Sergey Senozhatsky wrote: > On (05/06/16 18:08), Sergey Senozhatsky wrote: > [..] > > and it's not 45 iterations that we are getting rid of, but around 31: > > not every class reaches it's ideal 100% ratio on the first iteration. > > so, no, sorry, I don't

[PATCH 2/4] locking/rwsem: Drop superfluous waiter refcount

2016-05-08 Thread Davidlohr Bueso
Read waiters are currently reference counted from the time it enters the slowpath until the lock is released and the waiter is awoken. This is fragile and superfluous considering everything occurs within down_read() without returning to the caller, and the very nature of the primitive does not

Re: [PATCH 4/4] x86/kasan: Instrument user memory access API

2016-05-08 Thread Dmitry Vyukov
On Fri, May 6, 2016 at 2:45 PM, Andrey Ryabinin wrote: > Exchange between user and kernel memory is coded in assembly language. > Which means that such accesses won't be spotted by KASAN as a compiler > instruments only C code. > Add explicit KASAN checks to user memory

RE: [Patch v3 5/8] firmware: qcom: scm: Convert to streaming DMA APIS

2016-05-08 Thread Sricharan
Hi, > This patch converts the Qualcomm SCM driver to use the streaming DMA > APIs for communication buffers. > > Signed-off-by: Andy Gross > --- Reviewed-by: sricha...@codeaurora.org Regards, Sricharan > drivers/firmware/qcom_scm-32.c | 152

Re: [PATCH] kdump: Fix gdb macros work work with newer and 64-bit kernels

2016-05-08 Thread Baoquan He
Hi Corey, I am trying to review this patch now, and these fixes contained are very great. Just several concerns are added in inline comment. By the way, did you run this in your side? Hi Vivek, Member variable was added into task_struct in below commit replacing pids[PIDTYPE_TGID], and from

Re: [PATCH 1/1] xen/gntdev: kmalloc structure gntdev_copy_batch

2016-05-08 Thread Juergen Gross
On 07/05/16 10:17, Heinrich Schuchardt wrote: > Commit a4cdb556cae0 ("xen/gntdev: add ioctl for grant copy") > leads to a warning > xen/gntdev.c: In function ‘gntdev_ioctl_grant_copy’: > xen/gntdev.c:949:1: warning: the frame size of 1248 bytes > is larger than 1024 bytes [-Wframe-larger-than=] >

Re: [PATCH 3/6] intel_sgx: driver for Intel Secure Guard eXtensions

2016-05-08 Thread Jarkko Sakkinen
On Fri, Apr 29, 2016 at 03:22:19PM -0700, Jethro Beekman wrote: > On 29-04-16 13:04, Jarkko Sakkinen wrote: > >>> Why would you want to do that? > >> > >> ... > > > > Do you see this as a performance issue or why do you think that this > > would hurt that much? > > I don't think it's a

Re: [PATCH v2 2/2] kasan: add kasan_double_free() test

2016-05-08 Thread Dmitry Vyukov
On Fri, May 6, 2016 at 1:50 PM, Kuthonuzo Luruo wrote: > This patch adds a new 'test_kasan' test for KASAN double-free error > detection when the same slab object is concurrently deallocated. > > Signed-off-by: Kuthonuzo Luruo > --- > Changes in

Re: [PATCH 1/4] locking/rwsem: Avoid stale ->count for rwsem_down_write_failed()

2016-05-08 Thread Peter Hurley
On 05/08/2016 09:56 PM, Davidlohr Bueso wrote: > The field is obviously updated w.o the lock and needs a READ_ONCE > while waiting for lock holder(s) to go away, just like we do with > all other ->count accesses. This isn't actually fixing a bug because it's passed through several full barriers

Re: [PATCH v7 8/9] clk: mediatek: Add config options for MT2701 subsystem clocks

2016-05-08 Thread James Liao
HI Stephen, On Fri, 2016-05-06 at 16:02 -0700, Stephen Boyd wrote: > On 04/14, James Liao wrote: > > MT2701 subsystem clocks are optional and should be enabled only if > > their subsystem drivers are ready to control these clocks. > > > > Signed-off-by: James Liao > >

Re: [PATCH 0/6] Intel Secure Guard Extensions

2016-05-08 Thread Jarkko Sakkinen
On Fri, May 06, 2016 at 01:54:14PM +0200, Thomas Gleixner wrote: > On Fri, 6 May 2016, Jarkko Sakkinen wrote: > > > On Tue, May 03, 2016 at 04:06:27AM -0500, Dr. Greg Wettstein wrote: > > > It would be helpful and instructive for anyone involved in this debate > > > to review the following URL

Re: [PATCH] compiler-gcc: require gcc 4.8 for powerpc __builtin_bswap16()

2016-05-08 Thread Sedat Dilek
On 5/9/16, Stephen Rothwell wrote: > Hi Josh, > > On Fri, 6 May 2016 09:22:25 -0500 Josh Poimboeuf > wrote: >> >> I've also seen no problems on powerpc with 4.4 and 4.8. I suspect it's >> specific to gcc 4.6. Stephen, can you confirm this patch fixes

Re: [PATCH v7 7/9] clk: mediatek: Enable critical clocks for MT2701

2016-05-08 Thread James Liao
Hi Stephen, On Fri, 2016-05-06 at 16:12 -0700, Stephen Boyd wrote: > On 04/14, James Liao wrote: > > Some system clocks should be turned on by default on MT2701. > > This patch enable these clocks when related clocks have > > been registered. > > > > Signed-off-by: James Liao

Re: [PATCH v2 1/2] mm, kasan: improve double-free detection

2016-05-08 Thread Dmitry Vyukov
On Sun, May 8, 2016 at 11:17 AM, Yury Norov wrote: > On Sat, May 07, 2016 at 03:15:59PM +, Luruo, Kuthonuzo wrote: >> Thank you for the review! >> >> > > + switch (alloc_data.state) { >> > > + case KASAN_STATE_QUARANTINE: >> > > + case KASAN_STATE_FREE: >> > > +

linux-next: Tree for May 9

2016-05-08 Thread Stephen Rothwell
Hi all, Changes since 20160506: Dropped tree: hsi (at the maintainer's request) The f2fs tree gained a conflict against the ext4 tree. The libata tree gained a build failure so I used the version from next-20160506 for today. The net-next tree gained conflicts against the wireless-drivers and

[PATCH v3] ksm: fix conflict between mmput and scan_get_next_rmap_item

2016-05-08 Thread Zhou Chengming
A concurrency issue about KSM in the function scan_get_next_rmap_item. task A (ksmd): |task B (the mm's task): | mm = slot->mm; | down_read(>mmap_sem); |

RE: [PATCH] debugobjects: insulate non-fixup logic related to static obj from fixup callbacks

2016-05-08 Thread Du, Changbin
> From: Thomas Gleixner [mailto:t...@linutronix.de] > Can you please fix your mail client. Every mail you send has: > > Cc: . > "Du, Changbin" , > Du > > And that stray 'Du' is just broken. > Yes, I should add "" around my name or fix the git-sendemail perl

Re: sched: tweak select_idle_sibling to look for idle threads

2016-05-08 Thread Mike Galbraith
On Sat, 2016-05-07 at 09:24 +0800, Yuyang Du wrote: > On Sun, May 01, 2016 at 11:20:25AM +0200, Mike Galbraith wrote: > > Playing with Chris' benchmark, seems the biggest problem is that we > > don't buddy up waker of many and it's wakees in a node.. ie the wake > > wide thing isn't necessarily

Re: [PATCH] target: need_to_release is always false, remove redundant check and kfree

2016-05-08 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH 1/6] statx: Add a system call to make enhanced file info available

2016-05-08 Thread Christoph Hellwig
> int ret = statx(int dfd, > const char *filename, > unsigned int flags, > unsigned int mask, > struct statx *buffer); Please move the flags and mask after the buffer, similar to how all the AT_ flags

Re: [PATCH 3/6] statx: Ext4: Return enhanced file attributes

2016-05-08 Thread Christoph Hellwig
On Fri, Apr 29, 2016 at 01:57:59PM +0100, David Howells wrote: > (3) FS_xxx_FL flags are returned as for ioctl(FS_IOC_GETFLAGS), setting > STATX_IOC_FLAGS. Doesn't look like it is. Which actually is a good thing given how much of a mess FS_IOC_GETFLAGS is.

Re: [PATCH 5/6] statx: Make windows attributes available for CIFS, NTFS and FAT to use

2016-05-08 Thread Christoph Hellwig
On Fri, Apr 29, 2016 at 01:58:14PM +0100, David Howells wrote: > Make windows attributes available for CIFS, NTFS and FAT to use in the > statx struct. The attribute flags map directly by value to those in the > CIFS PDU flags. Some of these bits can also be used by JFS, UFS and HPFS. Err, no

Re: [PATCH v5 3/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors

2016-05-08 Thread Christoph Hellwig
On Fri, May 06, 2016 at 03:53:09PM -0600, Vishal Verma wrote: > From: Matthew Wilcox > > dax_clear_sectors() cannot handle poisoned blocks. These must be > zeroed using the BIO interface instead. Convert ext2 and XFS to use > only sb_issue_zerout(). > >

Re: [PATCH v5 0/5] dax: handling media errors (clear-on-zero only)

2016-05-08 Thread Christoph Hellwig
This series looks fine to me: Reviewed-by: Christoph Hellwig

Re: [PATCH v3 1/5] block: Add vfs_msg() interface

2016-05-08 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH v3 2/5] block: Add bdev_supports_dax() for dax mount checks

2016-05-08 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH v3 5/5] xfs: Add alignment check for DAX mount

2016-05-08 Thread Christoph Hellwig
Looks fine for now. In the long run we'll need to check it for the RT subvolume as well, or prohibit DAX if there is an active RT subvolume. Reviewed-by: Christoph Hellwig

Re: [PATCH v3 4/5] ext2: Add alignment check for DAX mount

2016-05-08 Thread Christoph Hellwig
Not really for the patch, but given that we have the right people on CC: Do we really want to keep DAX support in ext2 in the long run? ext2 is missing a lot of the useful features for a modern FS, shouldn't we direct people to use ext4 (in non-journal mode if needed) if they want to use DAX?

Re: [PATCH v4 5/7] fs: prioritize and separate direct_io from dax_io

2016-05-08 Thread h...@infradead.org
On Thu, May 05, 2016 at 09:45:07PM +, Verma, Vishal L wrote: > I'm not sure I completely understand how this will work? Can you explain > a bit? Would we have to export rw_bytes up to layers above the pmem > driver? Where does get_user_pages come in? A DAX filesystem can directly use the

Re: [PATCH v4 5/7] fs: prioritize and separate direct_io from dax_io

2016-05-08 Thread h...@infradead.org
On Thu, May 05, 2016 at 09:39:14PM +, Verma, Vishal L wrote: > How is it any 'less direct'? All it does now is follow the blockdev > O_DIRECT path. There still isn't any page cache involved.. It's still more overhead than the play DAX I/O path.

Re: sound: deadlock involving snd_hrtimer_callback

2016-05-08 Thread Takashi Iwai
On Wed, 04 May 2016 10:34:33 +0200, Dmitry Vyukov wrote: > > On Mon, May 2, 2016 at 1:54 PM, Dmitry Vyukov wrote: > > On Sun, Apr 24, 2016 at 11:31 PM, Takashi Iwai wrote: > >> On Sun, 24 Apr 2016 19:09:48 +0200, > >> Dmitry Vyukov wrote: > >>> > >>> On Sun,

Re: [PATCH v6 10/11] x86/KASLR: Add physical address randomization >4G

2016-05-08 Thread Baoquan He
On 05/06/16 at 08:31am, Kees Cook wrote: > On Fri, May 6, 2016 at 1:27 AM, Baoquan He wrote: > > Hi Kees, > > > > On 05/05/16 at 03:13pm, Kees Cook wrote: > >> From: Baoquan He > >> > >> This patch exchanges the prior slots[] array for the new slot_areas[] > >>

Re: [PATCH v2 1/2] mm, kasan: improve double-free detection

2016-05-08 Thread Yury Norov
On Sat, May 07, 2016 at 03:15:59PM +, Luruo, Kuthonuzo wrote: > Thank you for the review! > > > > + switch (alloc_data.state) { > > > + case KASAN_STATE_QUARANTINE: > > > + case KASAN_STATE_FREE: > > > + kasan_report((unsigned long)object, 0, false, > > > +

[PATCH] clk: samsung: exynos5420: Remove useless check for return value of samsung_clk_init

2016-05-08 Thread Krzysztof Kozlowski
The samsung_clk_init() cannot return NULL. Either it returns allocated memory or it panics. Signed-off-by: Krzysztof Kozlowski --- drivers/clk/samsung/clk-exynos5420.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/clk/samsung/clk-exynos5420.c

Re: [PATCH v5 0/8] block: prepare for multipage bvecs

2016-05-08 Thread Christoph Hellwig
On Tue, May 03, 2016 at 09:03:58AM +0800, Ming Lei wrote: > Any possibility to make v5 into v4.7 so that we can move on about > multipage bvecs? > > BTW, even though not considering mp bvecs, this patchset is still a > good cleanup. Agreed. I'm fine with the series and it looks harmless enough

Re: [PATCH] infoleak fix1 in timer

2016-05-08 Thread Takashi Iwai
On Tue, 03 May 2016 22:44:07 +0200, Kangjie Lu wrote: > > The stack object “tread” has a total size of 32 bytes. Its field > “event” and “val” both contain 4 bytes padding. These 8 bytes > padding bytes are sent to user without being initialized. > > Signed-off-by: Kangjie Lu

Re: [patch] ALSA: isa/wavefront: prevent some out of bound writes

2016-05-08 Thread Takashi Iwai
On Wed, 04 May 2016 08:27:37 +0200, Dan Carpenter wrote: > > "header->number" can be up to USHRT_MAX and it comes from the ioctl so > it needs to be capped. > > Signed-off-by: Dan Carpenter Applied, thanks. Takashi > > diff --git

Re: [PATCH 0/6] Intel Secure Guard Extensions

2016-05-08 Thread Dr. Greg Wettstein
Hi, I hope the weekend is going well for everyone. On Fri, May 06, 2016 at 02:39:44PM +0300, Jarkko Sakkinen wrote: > On Tue, May 03, 2016 at 04:06:27AM -0500, Dr. Greg Wettstein wrote: > > It would be helpful and instructive for anyone involved in this debate > > to review the following URL

Re: Regression of v4.6-rc vs. v4.5 bisected: a98ee79317b4 "drm/i915/fbc: enable FBC by default on HSW and BDW"

2016-05-08 Thread Stefan Richter
On May 05 Zanoni, Paulo R wrote: > If you don't want to keep carrying a manual revert, you can just boot > with i915.enable_fbc=0 for now (or write a /etc/modprobe.d file). Also, > it would be good to know in case you still somehow see the machine > hangs even with FBC disabled. As expected,

Re: [PATCH] fix infoleak in fcntl

2016-05-08 Thread Christoph Hellwig
On Tue, May 03, 2016 at 04:34:09PM -0400, Kangjie Lu wrote: > The stack object ???si??? has a total size of 128 bytes; however, only > 16 bytes are initialized. The remaining uninitialized bytes are > sent to userland via send_signal. > > Signed-off-by: Kangjie Lu Looks fine,

Re: [PATCH 1/2] Staging: android: ion: fixes use of typedef

2016-05-08 Thread Thimo Braker
On 8-5-2016 4:46, Greg KH wrote: You just broke userspace :( [..] (hint, they have uapi in the path) I see I need to get used to some names ( now you say it, Uapi is quite logical ). Thanks for the feedback. Thimo B.

[PATCH 2/2] iommu/io-pgtable-arm: use __dma_sync_single_for_device()

2016-05-08 Thread Niklas Söderlund
The call to dma_sync_single_for_device() can be reached from dma_map_single(). If CONFIG_DMA_API_DEBUG is enabled this would result in a check that the mapping being synced is valid. Since the call to dma_map_single is not yet completed the mapping is not recorded in dma-debug and the check fails

[PATCH 1/2] dma-mapping: add __dma_sync_single_for_device()

2016-05-08 Thread Niklas Söderlund
Some users of the DMA mapping API calls dma_sync_single_for_device() from the dma_map_single() call path. This will cause false warning printouts if CONFIG_DMA_API_DEBUG are enabled. The reason for the warning are that debug_dma_sync_single_for_device() will be called before debug_dma_map_page()

[PATCH 0/2] Fix incorrect warning from dma-debug

2016-05-08 Thread Niklas Söderlund
Hi, While using CONFIG_DMA_API_DEBUG i came across this warning which I think is a false positive. As shown dma_sync_single_for_device() are called from the dma_map_single() call path. This triggers the warning since the dma-debug code have not yet been made aware of the mapping. I try to solve

Re: Regression of v4.6-rc vs. v4.5 bisected: a98ee79317b4 "drm/i915/fbc: enable FBC by default on HSW and BDW"

2016-05-08 Thread Stefan Richter
On May 08 Stefan Richter wrote: > On May 05 Zanoni, Paulo R wrote: > > If you don't want to keep carrying a manual revert, you can just boot > > with i915.enable_fbc=0 for now (or write a /etc/modprobe.d file). Also, > > it would be good to know in case you still somehow see the machine > > hangs

[PATCH v2 1/1] Staging: android: uapi: ion: Fixes indentation

2016-05-08 Thread Thimo Braker
Fixes the indentation before variable names. Signed-off-by: Thimo Braker --- drivers/staging/android/uapi/ion.h | 20 ++-- drivers/staging/android/uapi/ion_test.h | 10 +- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git

Re: usb: dwc2: regression on MyBook Live Duo / Canyonlands since 4.3.0-rc4

2016-05-08 Thread Christian Lamparter
On Sunday, May 08, 2016 08:40:55 PM Benjamin Herrenschmidt wrote: > On Sun, 2016-05-08 at 00:54 +0200, Christian Lamparter via Linuxppc-dev > wrote: > > I've been looking in getting the MyBook Live Duo's USB OTG port > > to function. The SoC is a APM82181. Which has a PowerPC 464 core > > and

Re: Regression of v4.6-rc vs. v4.5 bisected: a98ee79317b4 "drm/i915/fbc: enable FBC by default on HSW and BDW"

2016-05-08 Thread Stefan Richter
On May 06 Daniel Vetter wrote: > On Thu, May 05, 2016 at 10:45:31PM +0200, Stefan Richter wrote: [...] > > Subtest fbc-1p-primscrn-spr-indfb-fullscreen: FAIL (5.876s) > > This one failed in both runs. Can you please retest with just that using > > # kms_frontbuffer_tracking --run-subtest

Re: [PATCH 2/3] net/mlx5e: make VXLAN support conditional

2016-05-08 Thread Saeed Mahameed
On Fri, May 6, 2016 at 10:35 PM, David Miller wrote: > From: Arnd Bergmann > Date: Thu, 05 May 2016 20:09:19 +0200 > >> For reference, I've tried it out on the MLX4 driver, and it does >> seem nicer that way, see below. > > Is it possible to wind down this

[PATCH v4] ksm: fix conflict between mmput and scan_get_next_rmap_item

2016-05-08 Thread Zhou Chengming
A concurrency issue about KSM in the function scan_get_next_rmap_item. task A (ksmd): |task B (the mm's task): | mm = slot->mm; | down_read(>mmap_sem); |

Re: [PATCH v3] ksm: fix conflict between mmput and scan_get_next_rmap_item

2016-05-08 Thread zhouchengming
Please ignore this patch v3. I forgot to change the function unmerge_and_remove_all_rmap_items(). Patch v4 will be the final version, I think.. Sorry for my carelessness. Thanks! On 2016/5/8 14:56, Zhou Chengming wrote: A concurrency issue about KSM in the function scan_get_next_rmap_item.

Re: [PATCH V4 3/3] soc/tegra: pmc: Add support for IO pads power state and voltage

2016-05-08 Thread Jon Hunter
On 06/05/16 16:32, Laxman Dewangan wrote: > > On Friday 06 May 2016 08:07 PM, Jon Hunter wrote: >> On 06/05/16 11:45, Laxman Dewangan wrote: >> + >> +/* Last entry */ >> +TEGRA_IO_PAD_MAX, >> Nit should these be TEGRA_IO_PADS_xxx? > > Because this was name of single pad and hence I said

Re: [PATCH V2 13/14] dt-bindings: arm-gic: Add documentation for Tegra210 AGIC

2016-05-08 Thread Jon Hunter
Hi Geert, On 07/05/16 15:10, Geert Uytterhoeven wrote: > Hi Jon, > > On Fri, May 6, 2016 at 10:32 AM, Jon Hunter wrote: >>> The "nvidia,tegra210-agic" string can be taken as describing any >>> Tegra-210 specific integration quirks, though I agree that's also not >>>

Re: [PATCH 1/3] dt-bindings: bus: Add documentation for Tegra210 ACONNECT

2016-05-08 Thread Jon Hunter
On 05/05/16 17:48, Rob Herring wrote: > On Thu, May 5, 2016 at 9:39 AM, Jon Hunter wrote: >> >> On 03/05/16 19:22, Rob Herring wrote: >>> On Fri, Apr 29, 2016 at 02:53:45PM +0100, Jon Hunter wrote: Add binding documentation for the Tegra ACONNECT bus that is part of

[PATCH 1/2] checkpatch: Reduce number of `git log` calls with --git

2016-05-08 Thread Joe Perches
checkpatch currently calls git log multiple times to first get the sha1 values and again to get the subject for each individual sha1 commit. Always get the sha1 and subject at the same time instead. Store the subject in a sha1 hash to avoid the second git log exec. Signed-off-by: Joe Perches

[PATCH 2/2] checkpatch: Improve --git shortcut

2016-05-08 Thread Joe Perches
The --git shortcut can be confused by a tag with a dash like v4.4-rc1. Improve the test to verify the expression ends with a dash followed by a numeric value. Improve the git log result to verify the " " output as well. Signed-off-by: Joe Perches --- scripts/checkpatch.pl

Re: [PATCH] fix infoleak in fcntl

2016-05-08 Thread Richard Weinberger
On Tue, May 3, 2016 at 10:34 PM, Kangjie Lu wrote: > The stack object “si” has a total size of 128 bytes; however, only > 16 bytes are initialized. The remaining uninitialized bytes are > sent to userland via send_signal. How did you find all these leaks? Since you sent more

[PATCH v8 2/3] gpio: mmio: add DT support for memory-mapped GPIOs

2016-05-08 Thread Christian Lamparter
From: Álvaro Fernández Rojas This patch adds support for defining memory-mapped GPIOs which are compatible with the existing gpio-mmio interface. The generic library provides support for many memory-mapped GPIO controllers that are found in various on-board FPGA and ASIC

[PATCH v8 3/3] gpio: move clps711x, moxart, ts4800 and gpio-ge into gpio-mmio

2016-05-08 Thread Christian Lamparter
This patch integrates the GPIO drivers for the following boards, SoCs, etc. into gpio-mmio: - CLPS711X SoCs - MOXA ART SoC - TS-4800 FPGA DIO blocks and compatibles - GPIO controllers found on some GE Single Board Computers Cc: Alexander Shiyan Cc: Julien Grossholtz

[PATCH v8 1/3] gpio: dt-bindings: add wd,mbl-gpio bindings

2016-05-08 Thread Christian Lamparter
This patch adds the device tree bindings for the Western Digital's MyBook Live memory-mapped GPIO controllers. The gpios will be supported by gpio-mmio code of the GPIO generic library. Acked-by: Rob Herring Signed-off-by: Christian Lamparter ---

[PATCH v8 0/3] gpio: add DT support for memory-mapped GPIOs

2016-05-08 Thread Christian Lamparter
This patch series adds device tree support for generic memory-mapped GPIOs. The GPIO library already allows drivers and architecture support code to reuse generic code for managing a GPIO chip. Currently, a developer has to create a platform device "basic-mmio-gpio" and attach a bgpio_pdata

[PATCH] tmpfs: don't undo fallocate past its last page

2016-05-08 Thread Anthony Romano
When fallocate is interrupted it will undo a range that extends one byte past its range of allocated pages. This can corrupt an in-use page by zeroing out its first byte. Instead, undo using the inclusive byte range. Signed-off-by: Anthony Romano --- mm/shmem.c | 2 +-

Re: [patch V4] lib: GCD: Use binary GCD algorithm instead of Euclidean

2016-05-08 Thread Zhaoxiu Zeng
在 2016/5/7 16:41, George Spelvin 写道: > Nothing critical, but a bit of kibitzing. > (That is slang in the Yiddish language for a person > who offers annoying and unwanted advice.) > >> The binary GCD algorithm is based on the following facts: >> 1. If a and b are all evens, then gcd(a,b) = 2 *

Re: [PATCH v8 0/3] gpio: add DT support for memory-mapped GPIOs

2016-05-08 Thread Andy Shevchenko
On Sun, May 8, 2016 at 4:08 PM, Christian Lamparter wrote: > This patch series adds device tree support for generic memory-mapped GPIOs. > The GPIO library already allows drivers and architecture support code to > reuse generic code for managing a GPIO chip. Currently, a

Re: [PATCH V4 0/4] Code refine for Intel IOMMU

2016-05-08 Thread Wei Yang
Ping~ On Thu, Apr 14, 2016 at 02:55:06PM +, Wei Yang wrote: >These four patches try to refine the Intel IOMMU. > > >

[PATCH] md: make the code more readable in the for-loop

2016-05-08 Thread Tiezhu Yang
This patch modifies raid1.c, raid10.c and raid5.c to make the code more readable in the for-loop and also fixes the scripts/checkpatch.pl error: ERROR: trailing statements should be on next line. Signed-off-by: Tiezhu Yang --- drivers/md/raid1.c | 6 +++---

RE: [PATCH v2 1/2] net: nps_enet: Sync access to packet sent flag

2016-05-08 Thread Elad Kanfi
Hi Lino, > Please see sections "SMP BARRIER PAIRING" and "EXAMPLES OF MEMORY BARRIER > SEQUENCES" in > memory-barriers.txt for a description why smp barriers have to be paired and > a smp write barrier on CPU A without a read barrier on CPU B is _not_ > sufficient. > > Furthermore after having

[PATCH] Staging: wlan-ng: fix comments style

2016-05-08 Thread YU Bo
The patch fixed warning reported by checkpatch.pl: Block comments use a trailing */ on a separate line. Signed-off-by: YU Bo --- drivers/staging/wlan-ng/prism2mgmt.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] fix a kernel infoleak in x25 module

2016-05-08 Thread Kangjie Lu
Stack object "dte_facilities" is allocated in x25_rx_call_request(), which is supposed to be initialized in x25_negotiate_facilities. However, 5 fields (8 bytes in total) are not initialized. This object is then copied to userland via copy_to_user, thus infoleak occurs. Signed-off-by: Kangjie Lu

  1   2   3   4   5   >