Re: [PATCH] ore: fix spelling mistake: "Multples" -> "multiples"

2017-04-23 Thread Boaz Harrosh
On 04/22/2017 03:48 PM, Colin King wrote: > From: Colin Ian King > > trivial fix to spelling mistake in ORE_ERR message and make word all > lower case. > > Signed-off-by: Colin Ian King Thanks ACK-by: Boaz Harrosh >

Re: [PATCH 3/4] nfs: remove the objlayout driver

2017-04-23 Thread Boaz Harrosh
On 04/21/2017 05:00 PM, Trond Myklebust wrote: > Maintenance is not development. It’s about doing all the followup > _after_ the feature is declared to be developed. That’s been missing > for quite some time in the case of the OSD pNFS code, which is why > I’m not even bothering to consider

Re: [PATCH v2 1/9] staging: ccree: introduce CryptoCell HW driver

2017-04-23 Thread Gilad Ben-Yossef
Hi, [ Re sending with all recipients this time ... ] On Thu, Apr 20, 2017 at 5:01 PM, Greg Kroah-Hartman wrote: >> > Oh, I have to ask, do you really mean "any later version" here and >> > elsewhere? >> > >> > If so, then your MODULE_LICENSE() marking is wrong,

Re: [PATCH] mailbox: fix completion order for blocking requests

2017-04-23 Thread Jassi Brar
On Tue, Apr 11, 2017 at 6:15 PM, Alexey Klimov wrote: > On Thu, Apr 06, 2017 at 10:45:26PM +0530, Jassi Brar wrote: >> On 6 April 2017 at 22:28, Alexey Klimov wrote: >> > Hi Jassi/Sudeep, >> > >> > On Wed, Mar 29, 2017 at 07:01:09PM +0100, Sudeep

[PATCH 1/1] net: bcmgenet: fix incorrect return value checks

2017-04-23 Thread Pan Bian
From: Pan Bian Function platform_get_irq() will return a negative value on errors. However, in function bcmgenet_probe(), 0 is considered as a flag of error. This patch fixes the bug by checking whether the return value of platform_get_irq() is less than 0. Signed-off-by:

Re: [PATCH v2 3/3] powerpc/mm: Implement CONFIG_DEBUG_RODATA on PPC32

2017-04-23 Thread Michael Ellerman
christophe leroy writes: > Le 22/04/2017 à 08:08, Michael Ellerman a écrit : >> "Naveen N. Rao" writes: >>> Excerpts from Christophe Leroy's message of April 21, 2017 18:32: diff --git a/arch/powerpc/kernel/ftrace.c

trace-cmd bug fixes

2017-04-23 Thread Federico Vaga
This set of patches contains some fixes found while studying the trace-cmd code.

[PATCH 4/5] trace-cmd: fix argument parsing minor BUG

2017-04-23 Thread Federico Vaga
For some reason the list command does not use anymore `getopt()` to parse the arguments, instead it uses a custum implementation. During this change [5da0eff trace-cmd: Add regex for listing of events] the variable `optind` has been forgotten. To reproduce the problem try to use invalid

[PATCH 5/5] trace-cmd: BUG fix malloc() pointer validation

2017-04-23 Thread Federico Vaga
To reproduce the bug mkdir /sys/kernel/debug/tracing/instances/test ./trace-cmd show -B test -s -f Failed to allocate instance path snapshot Signed-off-by: Federico Vaga --- trace-cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/trace-cmd.c

Re: [PATCH 1/2] PCI: mediatek: Add Mediatek PCIe host controller support

2017-04-23 Thread kbuild test robot
-for-some-Mediatek-SoCs/20170423-163432 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 6.2.0 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O

[PATCH 2/5] plugin:python: check asprintf() errors

2017-04-23 Thread Federico Vaga
The code was validating the string but the man page for asprintf(3) says clearly: If memory allocation wasn't possible, or some other error occurs, these functions will return -1, and the contents of strp are undefined. So, we cannot really rely on the returned string pointer.

[PATCH 1/1] rtc: gemini: add return value validation

2017-04-23 Thread Pan Bian
From: Pan Bian Function devm_ioremap() will return a NULL pointer if it fails to remap IO address, and its return value should be validated before it is used. However, in function gemini_rtc_probe(), its return value is not checked. This may result in bad memory access bugs

[PATCH 1/1] drm/radeon: check return value of radeon_ring_lock

2017-04-23 Thread Pan Bian
From: Pan Bian Function radeon_ring_lock() returns an errno on failure, and its return value should be validated. However, in functions r420_cp_errata_init() and r420_cp_errata_fini(), its return value is not checked. This patch adds the checks. Signed-off-by: Pan Bian

Re: [PATCH v6 2/7] perf/x86/intel: Record branch type

2017-04-23 Thread Jiri Olsa
On Thu, Apr 20, 2017 at 08:07:50PM +0800, Jin Yao wrote: SNIP > > +#define X86_BR_TYPE_MAP_MAX 16 > + > +static int > +common_branch_type(int type) > +{ > + int i, mask; > + const int branch_map[X86_BR_TYPE_MAP_MAX] = { > + PERF_BR_CALL, /* X86_BR_CALL */ > +

[GIT PULL] UBI/UBIFS fixes for 4.11

2017-04-23 Thread Richard Weinberger
Linus, The following changes since commit 89970a04d70c6c9e5e4492fd4096c0b5630a478c: Merge branch 'for-rc' of git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux (2017-03-29 19:59:49 -0700) are available in the git repository at: git://git.infradead.org/linux-ubifs.git

[PATCH v3 13/15] staging: ccree: fix array_size.cocci warnings

2017-04-23 Thread Gilad Ben-Yossef
From: kbuild test robot drivers/staging/ccree/ssi_sysfs.c:319:34-35: WARNING: Use ARRAY_SIZE drivers/staging/ccree/ssi_sysfs.c:429:34-35: WARNING: Use ARRAY_SIZE Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element Semantic patch information: This makes an

[PATCH v3 10/15] staging: ccree: remove useless NULL test of field

2017-04-23 Thread Gilad Ben-Yossef
Remove kbuild test robot reported NULL check for a struct field address. Signed-off-by: Gilad Ben-Yossef Reported-by: kbuild test robot --- drivers/staging/ccree/ssi_buffer_mgr.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH v3 12/15] staging: ccree: fix semicolon.cocci warnings

2017-04-23 Thread Gilad Ben-Yossef
From: kbuild test robot drivers/staging/ccree/ssi_request_mgr.c:623:3-4: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Signed-off-by: Gilad Ben-Yossef Signed-off-by: Fengguang Wu

[PATCH v3 15/15] staging: ccree: fix ifnullfree.cocci warnings

2017-04-23 Thread Gilad Ben-Yossef
From: kbuild test robot drivers/staging/ccree/ssi_hash.c:317:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

[PATCH v3 11/15] staging: ccree: fix platform_no_drv_owner.cocci warnings

2017-04-23 Thread Gilad Ben-Yossef
From: kbuild test robot drivers/staging/ccree/ssi_driver.c:484:6-11: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by: Gilad

[PATCH v3 09/15] MAINTAINERS: add Gilad BY as ccree maintainer

2017-04-23 Thread Gilad Ben-Yossef
I work for Arm on maintaining the TrustZone CryptoCell driver. Signed-off-by: Gilad Ben-Yossef --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 676c139..f21caa1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3066,6

[PATCH v3 14/15] staging: ccree: fix ifnullfree.cocci warnings

2017-04-23 Thread Gilad Ben-Yossef
From: kbuild test robot drivers/staging/ccree/ssi_buffer_mgr.c:530:3-19: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

[PATCH 3/5] trace-cmd:read: BUG initialize input_files item to zero

2017-04-23 Thread Federico Vaga
On allocation the data structure was not initialized. Later on some attribute of this structure are used (e.g. tsoffset) assuming that the default value is zero, but it is not always true. Signed-off-by: Federico Vaga --- trace-read.c | 1 + 1 file changed, 1

[PATCH 1/5] plugin:python: fix compiler warning

2017-04-23 Thread Federico Vaga
The function `load_plugin` is passed, as argument, to `trace_util_load_plugins()` but the prototype was not exactly the same. Signed-off-by: Federico Vaga --- plugin_python.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/plugin_python.c

[GIT pull] ras fix for 4.11

2017-04-23 Thread Thomas Gleixner
Linus, please pull the latest ras-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git ras-urgent-for-linus The MCE atomic notifier callchain invokes callbacks which might sleep. Convert it to a blocking notifier and prevent calls from atomic context.

[PATCH 1/1] qlcnic: fix unchecked return value

2017-04-23 Thread Pan Bian
From: Pan Bian Function pci_find_ext_capability() may return 0, which is an invalid address. In function qlcnic_sriov_virtid_fn(), its return value is used without validation. This may result in invalid memory access bugs. This patch fixes the bug. Signed-off-by: Pan Bian

Re: [HMM 03/15] mm/unaddressable-memory: new type of ZONE_DEVICE for unaddressable memory

2017-04-23 Thread Dan Williams
On Sat, Apr 22, 2017 at 11:11 AM, Jerome Glisse wrote: > On Fri, Apr 21, 2017 at 10:30:01PM -0700, Dan Williams wrote: >> On Fri, Apr 21, 2017 at 8:30 PM, Jérôme Glisse wrote: > > [...] > >> > +/* >> > + * Specialize ZONE_DEVICE memory into multiple types

[PATCH 1/1] libertas: check return value of alloc_workqueue

2017-04-23 Thread Pan Bian
From: Pan Bian Function alloc_workqueue() will return a NULL pointer if there is no enough memory, and its return value should be validated before using. However, in function if_spi_probe(), its return value is not checked. This may result in a NULL dereference bug. This

[PATCH 1/1] drm/radeon: check return vlaue of radeon_fence_emit

2017-04-23 Thread Pan Bian
From: Pan Bian Function radeon_fence_emit() returns -ENOMEM if there is no enough memory. And in this case, function radeon_ring_unlock_undo() rather than function radeon_ring_unlock_commit() should be called. However, in function radeon_test_create_and_emit_fence(), the

[PATCH] staging: fbtft: fix character limit, trailing ; warning, etc.

2017-04-23 Thread Eric Curtin
checkpatch spits out a warning about the 80 character line limit. Split the parameters of these functions onto different lines. Put the ; with the macro caller instead. Lined up parameters as there was another CHECK warning about that. Signed-off-by: Eric Curtin ---

Re: [PATCH] hwmon: tmp103: use SIMPLE_DEV_PM_OPS helper macro

2017-04-23 Thread Guenter Roeck
Hi Rahul, On 04/23/2017 07:10 AM, Rahul Bedarkar wrote: Replace ifdefs with SIMPLE_DEV_PM_OPS helper macro. Signed-off-by: Rahul Bedarkar Thanks a lot for your patch. While I in general prefer code that avoids #ifdef, I have seen patches which do the opposite

Re: [PATCH v2 6/9] staging: ccree: add FIPS support

2017-04-23 Thread Gilad Ben-Yossef
Hi, Thank you for the review. On Thu, Apr 20, 2017 at 4:39 PM, Stephan Müller wrote: >> +/* The function verifies that tdes keys are not weak.*/ >> +static int ssi_fips_verify_3des_keys(const u8 *key, unsigned int keylen) >> +{ >> +#ifdef CCREE_FIPS_SUPPORT >> +

[PATCH] staging: android: ion: fix coding style issue

2017-04-23 Thread Adheer Chandravanshi
Use tab instead of spaces for indentation, as reported by checkpatch.pl Signed-off-by: Adheer Chandravanshi --- drivers/staging/android/ion/ion_cma_heap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] mm, vmscan: do not loop on too_many_isolated for ever

2017-04-23 Thread Tetsuo Handa
On 2017/03/10 20:44, Tetsuo Handa wrote: > Michal Hocko wrote: >> On Thu 09-03-17 13:05:40, Johannes Weiner wrote: >>> On Tue, Mar 07, 2017 at 02:52:36PM -0500, Rik van Riel wrote: It only does this to some extent. If reclaim made no progress, for example due to immediately bailing

[PATCH 1/1] iommu/amd: fix incorrect error handling

2017-04-23 Thread Pan Bian
From: Pan Bian In function amd_iommu_bind_pasid(), the control flow jumps to label out_free when pasid_state->mm and mm is NULL. And mmput(mm) is called. In function mmput(mm), mm is referenced without validation. This will result in a NULL dereference bug. This patch fixes

[PATCH v5 06/11] drm/sun4i: add support for Allwinner DE2 mixers

2017-04-23 Thread Icenowy Zheng
Allwinner have a new "Display Engine 2.0" in their new SoCs, which comes with mixers to do graphic processing and feed data to TCON, like the old backends and frontends. Add support for the mixer on Allwinner V3s SoC; it's the simplest one. Currently a lot of functions are still missing -- more

[PATCH v5 04/11] drm/sun4i: return only planes for layers created

2017-04-23 Thread Icenowy Zheng
As we are going to add support for the Allwinner DE2 Mixer in sun4i-drm driver, we will finally have two types of layers. Each layer is bound to a drm_plane that is CRTC-specific, so we create them when initializing CRTC (calling sun4i_layers_init, which will be generalized in next patch). The

Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

2017-04-23 Thread SF Markus Elfring
>> * A multiplication for the size determination of a memory allocation >> indicated that an array data structure should be processed. >> Thus use the corresponding function "devm_kcalloc". > I have trouble parsing that sentences. This looks like the typical > approach of native german

[PATCH v5 07/11] drm/sun4i: Add compatible string for V3s display engine

2017-04-23 Thread Icenowy Zheng
Allwinner V3s features the new "Display Engine 2.0", which can now also be driven with our subdrivers in sun4i-drm. Add the compatible string for in sun4i_drv.c, in order to make the display engine and its components probed. Signed-off-by: Icenowy Zheng ---

[PATCH v5 03/11] dt-bindings: add bindings for DE2 on V3s SoC

2017-04-23 Thread Icenowy Zheng
Allwinner V3s SoC have a display engine which have a different pipeline with older SoCs. Add document for it (new compatibles and the new "mixer" part). Signed-off-by: Icenowy Zheng Acked-by: Rob Herring --- Changes in v4: - Removed the refactor at TCON

[PATCH v5 08/11] drm/sun4i: tcon: add support for V3s TCON

2017-04-23 Thread Icenowy Zheng
Allwinner V3s SoC features a TCON without channel 1. Add support for it. Signed-off-by: Icenowy Zheng --- drivers/gpu/drm/sun4i/sun4i_drv.c | 3 ++- drivers/gpu/drm/sun4i/sun4i_tcon.c | 5 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git

[PATCH v5 00/11] Initial Allwinner Display Engine 2.0 Support

2017-04-23 Thread Icenowy Zheng
This patchset is the initial patchset for Allwinner DE2 support. It contains the support of clocks in DE2 and the mixers in DE2. The SoC used to develop this patchset is V3s, as V3s is the simplest one of the SoCs that have DE2. (Allwinner V3s features only one mixer, although its clock control

[PATCH v5 01/11] dt-bindings: add binding for the Allwinner DE2 CCU

2017-04-23 Thread Icenowy Zheng
Allwinner "Display Engine 2.0" contains some clock controls in it. In order to add them as clock drivers, we need a device tree binding. Add the binding here. Also add the device tree binding headers. Signed-off-by: Icenowy Zheng --- Changes in v5: - Moved dt-binding headers

[PATCH v5 02/11] clk: sunxi-ng: add support for DE2 CCU

2017-04-23 Thread Icenowy Zheng
The "Display Engine 2.0" in Allwinner newer SoCs contains a clock management unit for its subunits, like the DE CCU in A80. Add a sunxi-ng style driver for it. Signed-off-by: Icenowy Zheng --- Changes in v5: - Removed dt-bindings headers (they're now in patch 1). Changes in v4:

Re: [v3,7/7] powerpc: kprobes: remove duplicate saving of msr

2017-04-23 Thread Michael Ellerman
On Wed, 2017-04-19 at 12:51:06 UTC, "Naveen N. Rao" wrote: > set_current_kprobe() already saves regs->msr into kprobe_saved_msr. Remove > the redundant save. > > Signed-off-by: Naveen N. Rao > Reviewed-by: Masami Hiramatsu Applied to

Re: [PATCH 1/3] [media] si2157: get chip id during probing

2017-04-23 Thread Antti Palosaari
On 03/16/2017 12:22 AM, Andreas Kemnade wrote: If the si2157 is behind a e.g. si2168, the si2157 will at least in some situations not be readable after the si268 got the command 0101. It still accepts commands but the answer is just ff. So read the chip id before that so the information is

Re: [PATCH v1 1/8] lib/uuid: Introduce uuid_{be|le}_cmp_p{p}() helpers

2017-04-23 Thread Andy Shevchenko
On Sun, Apr 23, 2017 at 1:29 PM, Winkler, Tomas wrote: >> New helpers take pointers to uuid_{be|le} as parameters. >> >> When using them on a raw data we don't need to do an ugly dereference and, >> in some cases, a type casting. > I think this going overboard, the _pp

RE: [PATCH 1/1] tipc: check return value of nlmsg_new

2017-04-23 Thread Jon Maloy
Acknowledged. Thank you for doing this job. ///jon > -Original Message- > From: Pan Bian [mailto:bianpan2...@163.com] > Sent: Sunday, April 23, 2017 03:09 AM > To: Jon Maloy ; Ying Xue > ; David S. Miller > Cc:

Re: [PATCH v2] kbuild: Add better clang cross build support

2017-04-23 Thread Masahiro Yamada
2017-04-22 3:20 GMT+09:00 Matthias Kaehlcke : > Add cross target to CC if using clang. Also add custom gcc toolchain > path for fallback gcc tools. > > Clang will fallback to using things like ld, as, and libgcc if > (respectively) one of the llvm linkers isn't available, the

Re: [PATCH v3 3/7] kprobes: validate the symbol name length

2017-04-23 Thread Naveen N. Rao
Excerpts from Masami Hiramatsu's message of April 21, 2017 19:12: On Wed, 19 Apr 2017 16:38:22 + "Naveen N. Rao" wrote: Excerpts from Masami Hiramatsu's message of April 19, 2017 20:07: > On Wed, 19 Apr 2017 18:21:02 +0530 > "Naveen N. Rao"

[PATCH 1/1] m5602_s5k83a: check return value of kthread_create

2017-04-23 Thread Pan Bian
From: Pan Bian Function kthread_create() returns an ERR_PTR on error. However, in function s5k83a_start(), its return value is used without validation. This may result in a bad memory access bug. This patch fixes the bug. Signed-off-by: Pan Bian ---

[PATCH v3 04/15] staging: ccree: add IV generation support

2017-04-23 Thread Gilad Ben-Yossef
Add CryptoCell IV hardware generation support. This patch adds the needed support to drive the HW but does not expose the ability via the kernel crypto API yet. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/Makefile | 2 +-

[PATCH v3 07/15] staging: ccree: add TODO list

2017-04-23 Thread Gilad Ben-Yossef
Add TODO list for moving out of staging tree for ccree crypto driver Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/TODO | 30 ++ 1 file changed, 30 insertions(+) create mode 100644 drivers/staging/ccree/TODO diff --git

[PATCH v3 00/15] staging: ccree: add Arm TrustZone CryptoCell REE driver

2017-04-23 Thread Gilad Ben-Yossef
Arm TrustZone CryptoCell 700 is a family of cryptographic hardware accelerators. It is supported by a long lived series of out of tree drivers, which I am now in the process of unifying and upstreaming. This is the first drop, supporting the new CryptoCell 712 REE. The code still needs some

[PATCH v3 08/15] staging: ccree: add DT bindings for Arm CryptoCell

2017-04-23 Thread Gilad Ben-Yossef
This adds DT bindings for the Arm TrustZone CryptoCell cryptographic accelerator IP. Signed-off-by: Gilad Ben-Yossef --- .../devicetree/bindings/crypto/arm-cryptocell.txt | 27 ++ 1 file changed, 27 insertions(+) create mode 100644

[PATCH 1/1] staging: comedi: addi_apci_3xxx: check return value

2017-04-23 Thread Pan Bian
From: Pan Bian Function pci_ioremap_bar() will return a NULL pointer if there is no enough memory. However, in function apci3xxx_auto_attach(), the return value of function pci_ioremap_bar() is not validated. This may result in NULL dereference in following access to

Re: [PATCH 1/2] dmaengine: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

2017-04-23 Thread Tobias Jakobi
Hello Markus, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 22 Apr 2017 23:00:23 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the

[PATCH 1/1] char: xillybus: check return value

2017-04-23 Thread Pan Bian
From: Pan Bian Function of_address_to_resource() tries to translate device tree address and return as resource. If the translation fails, it will return a negative errno. However, function xilly_drv_probe() does not validate its return value, which may result in a bad memory

Question on the five-level page table support patches

2017-04-23 Thread John Paul Adrian Glaubitz
Hi Kirill! I recently read the LWN article on your and your colleagues work to add five-level page table support for x86 to the Linux kernel [1] and I got your email address from the last patch of the series. Since this extends the address space beyond 48-bits, as you may know, it will cause

Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

2017-04-23 Thread SF Markus Elfring
>> WARNING: Prefer devm_kcalloc over devm_kzalloc with multiply > For example. Also I just noticed some previous comment by Krzysztof that > pointed that out already. > > My suggestion: One sentence describing that the current situation is. Why do you find the sentence for the multiplication

[PATCH 1/1] usb: hub: check return value

2017-04-23 Thread Pan Bian
From: Pan Bian Function usb_autopm_get_interface() will return a negative errno on failure, and function usb_autopm_put_interface() should not be called if it fails. However, in function usb_remove_device(), the return value of function usb_autopm_get_interface() is not

[tip:timers/urgent] nohz: Fix again collision between tick and other hrtimers

2017-04-23 Thread tip-bot for Frederic Weisbecker
Commit-ID: d58bd60c773d8b16c19c4b9533bceee3761eb804 Gitweb: http://git.kernel.org/tip/d58bd60c773d8b16c19c4b9533bceee3761eb804 Author: Frederic Weisbecker AuthorDate: Fri, 21 Apr 2017 16:00:54 +0200 Committer: Thomas Gleixner CommitDate: Sun, 23

[tip:timers/urgent] tick: Make sure tick timer is active when bypassing reprogramming

2017-04-23 Thread tip-bot for Frederic Weisbecker
Commit-ID: 22aa2ad45fd8a6ef56eb60038fc0ac7059c0a986 Gitweb: http://git.kernel.org/tip/22aa2ad45fd8a6ef56eb60038fc0ac7059c0a986 Author: Frederic Weisbecker AuthorDate: Fri, 21 Apr 2017 16:00:55 +0200 Committer: Thomas Gleixner CommitDate: Sun, 23

Re: [tpmdd-devel] [backport v4.9] tpm_tis: use default timeout value if chip reports it as zero

2017-04-23 Thread Jarkko Sakkinen
On Wed, Apr 19, 2017 at 05:38:07PM +0200, Greg KH wrote: > On Wed, Apr 19, 2017 at 06:29:08PM +0300, Jarkko Sakkinen wrote: > > On Sun, Apr 16, 2017 at 09:14:29PM +0200, Paul Menzel wrote: > > > Dear Greg, > > > > > > > > > On 2017-04-15 22:50, Greg KH wrote: > > > > On Sat, Apr 15, 2017 at

Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

2017-04-23 Thread SF Markus Elfring
>> Its implementation of the check “ALLOC_WITH_MULTIPLY” considers only an other >> search pattern so far. >> >> * Do you find it worthwhile to add a prefix like “devm_” to the used >> regular expression? >> >> * Would like to improve any related scripts for the semantic patch language >>

[PATCH 1/1] [media] cx25840: fix unchecked return values

2017-04-23 Thread Pan Bian
From: Pan Bian In functions cx25840_initialize(), cx231xx_initialize(), and cx23885_initialize(), the return value of create_singlethread_workqueue() is used without validation. This may result in NULL dereference and cause kernel crash. This patch fixes it. Signed-off-by:

[PATCH 1/1] PCI: check return value of pci_find_ext_capability

2017-04-23 Thread Pan Bian
From: Pan Bian Function pci_find_ext_capability() will returns 0 on failure, and its return value should be checked before it is used. However, in function pcie_port_enable_msix(), its return value is not checked. This patch adds the check. Signed-off-by: Pan Bian

Re: [patch 0/6] hwmon/coretemp: Hotplug fixes, cleanups and state machine conversion

2017-04-23 Thread Thomas Gleixner
On Sat, 15 Apr 2017, Tommi Rantala wrote: > 2017-04-14 20:35 GMT+03:00 Thomas Gleixner : > > On Wed, 12 Apr 2017, Thomas Gleixner wrote: > >> > >> Can you please try the following: > >> > >> # for STATE in freezer devices platform processors core; do \ > >> echo $STATE; \ >

RE: Performance of low-cpu utilisation benchmark regressed severely since 4.6

2017-04-23 Thread Doug Smythies
On 2017.04.22 14:08 Rafael wrote: > On Friday, April 21, 2017 11:29:06 PM Doug Smythies wrote: >> On 2017.04.20 18:18 Rafael wrote: >>> On Thursday, April 20, 2017 07:55:57 AM Doug Smythies wrote: On 2017.04.19 01:16 Mel Gorman wrote: > On Fri, Apr 14, 2017 at 04:01:40PM -0700, Doug

[PATCH v3 06/15] staging: ccree: add FIPS support

2017-04-23 Thread Gilad Ben-Yossef
Add FIPS mode support to CryptoCell driver Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/Kconfig |9 + drivers/staging/ccree/Makefile |1 + drivers/staging/ccree/ssi_aead.c|6 + drivers/staging/ccree/ssi_cipher.c |

[PATCH] Revert "x86/mm/gup: Switch GUP to the generic get_user_page_fast() implementation"

2017-04-23 Thread Ingo Molnar
* Dan Williams wrote: > > I can't find the issue either. > > > > Is it something reproducible without hardware? In KVM? > > You can do it in KVM, just boot with the memmap=ss!nn parameter to > simulate pmem. In this case I'm booting with memmap=4G!8G, you should >

Re: [RFC][PATCH] proc: invalidate the deleting or deleted proc dentry

2017-04-23 Thread Hou Tao
Hi, any comment ? On 2017/4/13 21:49, Hou Tao wrote: > After the invocation of remove_proc_entry() for a proc fs directory, > if the related dentry had been held by some processes (eg., by chdir), > the lookup afterwards will still return the old proc_dir_entry. The > new created proc fs files

tango_nand: is logic right in error cases? (was Re: fsl_ifc_nand: are blank pages protected by ECC?)

2017-04-23 Thread Pavel Machek
Hi! > > Maybe I figured it out. Unfortunately, it is only compile tested. Does > > it look approximately right? > > Yep that's definitely better. Just one thing missing (see below), > otherwise it looks good. I'm copying from tango_nand, therefore I had to check tango_nand, too. static int

RE: [PATCH v1 1/8] lib/uuid: Introduce uuid_{be|le}_cmp_p{p}() helpers

2017-04-23 Thread Winkler, Tomas
> New helpers take pointers to uuid_{be|le} as parameters. > > When using them on a raw data we don't need to do an ugly dereference and, > in some cases, a type casting. > > Cc: Andrew Morton > Cc: Arnd Bergmann > Cc: Liam Girdwood

[PATCH 1/1] staging: wilc1000: fix unchecked return value

2017-04-23 Thread Pan Bian
From: Pan Bian Function dev_alloc_skb() will return a NULL pointer if there is no enough memory. However, in function WILC_WFI_mon_xmit(), its return value is used without validation. This may result in a bad memory access bug. This patch fixes the bug. Signed-off-by: Pan

Re: [v4,1/6] powerpc: ftrace: minor cleanup

2017-04-23 Thread Michael Ellerman
On Wed, 2017-04-19 at 12:52:23 UTC, "Naveen N. Rao" wrote: > Move the stack setup and teardown code to the ftrace_graph_caller(). > This way, we don't incur the cost of setting it up unless function graph > is enabled for this function. > > Also, remove the extraneous LR restore code after the

[PATCH 1/1] mfd: intel_soc_pmic_core: fix unchecked return value

2017-04-23 Thread Pan Bian
From: Pan Bian unction devm_regmap_init_i2c() returns an ERR_PTR on errors, and its return value should be checked before it is dereferenced. However, in function intel_soc_pmic_i2c_probe(), the return value of function devm_regmap_init_i2c() is used without validation. This

[PATCH] hwmon: tmp103: use SIMPLE_DEV_PM_OPS helper macro

2017-04-23 Thread Rahul Bedarkar
Replace ifdefs with SIMPLE_DEV_PM_OPS helper macro. Signed-off-by: Rahul Bedarkar --- drivers/hwmon/tmp103.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/hwmon/tmp103.c b/drivers/hwmon/tmp103.c index d0bb28b..7f85b14

[PATCH 0/2] Lattice MachXO2 Passive SPI FPGA Manager support

2017-04-23 Thread Paolo Pisati
Hi all, this series adds support for the Lattice MachXO2 FPGA chip, programmed over Slave SPI. Tested on my raspberry pi3 + bugblat's pif2 fpga hat. Paolo Pisati (2): dt: bindings: fpga: add lattice machxo2 slave spi binding description fpga: lattice machxo2: Add Lattice MachXO2 support

[PATCH 1/2] dt: bindings: fpga: add lattice machxo2 slave spi binding description

2017-04-23 Thread Paolo Pisati
Add dt binding documentation details for Lattice MachXO2 FPGA configuration over Slave SPI interface. Signed-off-by: Paolo Pisati --- .../bindings/fpga/lattice-machxo2-spi.txt | 29 ++ 1 file changed, 29 insertions(+) create mode 100644

[PATCH 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

2017-04-23 Thread Paolo Pisati
Add support for the Lattice MachXO2 FPGA chip in Slave SPI configuration. Signed-off-by: Paolo Pisati --- drivers/fpga/Kconfig | 7 ++ drivers/fpga/Makefile | 1 + drivers/fpga/machxo2-spi.c | 199 + 3 files changed,

[tip:smp/hotplug 42/44] include/linux/jump_label.h:260:20: error: inlining failed in call to always_inline 'static_key_disable_cpuslocked.constprop.99': recursive inlining

2017-04-23 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git smp/hotplug head: 8b836972c33553d3ff70954af090debfc9dc84c6 commit: 924726b2b5e5000dfb8eb6032651baed1b1bdc6c [42/44] perf: Cure hotplug lock ordering issues config: x86_64-randconfig-n0-0423 (attached as .config) compiler:

[PATCH v3 05/15] staging: ccree: add AEAD support

2017-04-23 Thread Gilad Ben-Yossef
Add CryptoCell AEAD support Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/Kconfig |1 + drivers/staging/ccree/Makefile |2 +- drivers/staging/ccree/cc_crypto_ctx.h | 21 + drivers/staging/ccree/ssi_aead.c | 2826

[PATCH v2] mmc: sdio: Fix sdio wait busy implement limitation

2017-04-23 Thread Jiajie Hao
The host may issue an I/O abort by writing to the CCCR at any time during I/O read operation via CMD52. And host may need suspend transcation during write busy stage in SDIO suspend/resume scenario. >From other side, a card may accept CMD52 during data transfer phase. Previous implement would

[PATCH 1/1] wan: pc300too: abort path on failure

2017-04-23 Thread Pan Bian
From: Pan Bian In function pc300_pci_init_one(), on the ioremap error path, function pc300_pci_remove_one() is called to free the allocated memory. However, the path is not terminated, and the freed memory will be used later, resulting in use-after-free bugs. This path fixes

[PATCH v5 05/11] drm/sun4i: abstract a engine type

2017-04-23 Thread Icenowy Zheng
As we are going to add support for the Allwinner DE2 engine in sun4i-drm driver, we will finally have two types of display engines -- the DE1 backend and the DE2 mixer. They both do some display blending and feed graphics data to TCON, so I choose to call them both "engine" here. Abstract the

[PATCH v5 09/11] ARM: dts: sun8i: add DE2 nodes for V3s SoC

2017-04-23 Thread Icenowy Zheng
Allwinner V3s SoC features a "Display Engine 2.0" with only one TCON which have RGB LCD output. Add device nodes for it as well as the TCON. Signed-off-by: Icenowy Zheng --- arch/arm/boot/dts/sun8i-v3s.dtsi | 87 1 file changed, 87

[PATCH v5 11/11] [DO NOT MERGE] ARM: dts: sun8i: enable LCD panel of Lichee Pi Zero

2017-04-23 Thread Icenowy Zheng
A 480x272 QiaoDian QD43003C0-40-7LED panel is available from Lichee Pi. This commit connects this panel to Lichee Pi Zero. Lichee Pi also provides a 800x480 panel without accurate model number, so do not merge this patch. It will finally come as device tree overlay. Signed-off-by: Icenowy Zheng

[PATCH v5 10/11] ARM: dts: sun8i: add pinmux for LCD pins of V3s SoC

2017-04-23 Thread Icenowy Zheng
Allwinner V3s SoC features a set of pins that have functionality of RGB LCD, the pins are at different pin ban than other SoCs. Add pinctrl node for them. Signed-off-by: Icenowy Zheng --- arch/arm/boot/dts/sun8i-v3s.dtsi | 9 + 1 file changed, 9 insertions(+) diff

Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

2017-04-23 Thread Tobias Jakobi
SF Markus Elfring wrote: >>> * A multiplication for the size determination of a memory allocation >>> indicated that an array data structure should be processed. >>> Thus use the corresponding function "devm_kcalloc". >> I have trouble parsing that sentences. This looks like the typical >>

[GIT pull] irq fix for 4.11

2017-04-23 Thread Thomas Gleixner
Linus, please pull the latest irq-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq-urgent-for-linus The (hopefully) final fix for the irq affinity spreading logic. Thanks, tglx --> Keith Busch (1):

[PATCH 1/1] [media] cobalt: fix unchecked return values

2017-04-23 Thread Pan Bian
From: Pan Bian Function pci_find_ext_capability() may return 0, which is an invalid address. In function cobalt_pcie_status_show(), its return value is used without validation. This patch adds checks to validate the return address. Signed-off-by: Pan Bian

Re: s3c24xx: Use devm_kcalloc() in s3c24xx_dma_probe()

2017-04-23 Thread Tobias Jakobi
SF Markus Elfring wrote: >>> WARNING: Prefer devm_kcalloc over devm_kzalloc with multiply >> For example. Also I just noticed some previous comment by Krzysztof that >> pointed that out already. >> >> My suggestion: One sentence describing that the current situation is. > > Why do you find the

Re: [PATCH 1/3] [media] si2157: get chip id during probing

2017-04-23 Thread Andreas Kemnade
On Sun, 23 Apr 2017 15:19:21 +0300 Antti Palosaari wrote: > On 03/16/2017 12:22 AM, Andreas Kemnade wrote: > > If the si2157 is behind a e.g. si2168, the si2157 will > > at least in some situations not be readable after the si268 > > got the command 0101. It still accepts commands

Re: [PATCH -mm -v3] mm, swap: Sort swap entries before free

2017-04-23 Thread Huang, Ying
Tim Chen writes: > On Fri, 2017-04-21 at 20:29 +0800, Huang, Ying wrote: >> "Huang, Ying" writes: >> >> > >> > Minchan Kim writes: >> > >> > > >> > > On Wed, Apr 19, 2017 at 04:14:43PM +0800, Huang, Ying wrote: >> > > >

[PATCH 1/1] cfg80211: add return value validation

2017-04-23 Thread Pan Bian
From: Pan Bian Function create_singlethread_workqueue() will return a NULL pointer if there is no enough memory, and its return value should be validated before using. However, in function rndis_wlan_bind(), its return value is not checked. This may cause NULL dereference

[PATCH] powercap/intel_rapl: Add support for Gemini Lake

2017-04-23 Thread David E. Box
From: "Box, David E" Gemini Lake RAPL support is similar to Goldmont. Signed-off-by: David E. Box --- drivers/powercap/intel_rapl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/powercap/intel_rapl.c

Re: [PATCH] drm/etnaviv: add thermal dependency

2017-04-23 Thread Eduardo Valentin
On Wed, Apr 19, 2017 at 08:11:16PM +0200, Arnd Bergmann wrote: > When CONFIG_THERMAL is enabled as a loadable module, and etnaviv is > built-in, we get a link error: > > drivers/gpu/drm/etnaviv/etnaviv_gpu.o: In function `etnaviv_gpu_bind': > etnaviv_gpu.c:(.text.etnaviv_gpu_bind+0x34): undefined

Re: [PATCH] usb: core: Warn if an URB's transfer_buffer is on stack

2017-04-23 Thread Florian Fainelli
On 04/23/2017 09:01 AM, Alan Stern wrote: > On Sun, 23 Apr 2017, Greg Kroah-Hartman wrote: > >> On Sat, Apr 22, 2017 at 05:31:27PM -0400, Alan Stern wrote: >>> On Sat, 22 Apr 2017, Florian Fainelli wrote: >>> We see a large number of fixes to several drivers to remove the usage of

[PATCH 1/1] drivers:net:ethernet:adi:bfin_mac: Use FIELD_SIZEOF defined kernel macro

2017-04-23 Thread Karim Eshapa
Use FIELD_SIZEOF defined kernel macro kernel.h Signed-off-by: Karim Eshapa --- drivers/net/ethernet/adi/bfin_mac.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/adi/bfin_mac.c

  1   2   3   4   5   6   7   >