Re: [PATCH] netfilter: xt_osf: Add missing permission checks

2017-12-06 Thread Pablo Neira Ayuso
On Tue, Dec 05, 2017 at 03:42:41PM -0800, Kevin Cernekee wrote: > The capability check in nfnetlink_rcv() verifies that the caller > has CAP_NET_ADMIN in the namespace that "owns" the netlink socket. > However, xt_osf_fingers is shared by all net namespaces on the > system. An unprivileged user ca

Re: [PATCH 0/2] mm: introduce MAP_FIXED_SAFE

2017-12-06 Thread John Hubbard
On 12/05/2017 11:35 PM, Florian Weimer wrote: > On 12/06/2017 08:33 AM, John Hubbard wrote: >> In that case, maybe: >> >> MAP_EXACT >> >> ? ...because that's the characteristic behavior. > > Is that true?  mmap still silently rounding up the length to the page size, I > assume, so even that

Re: [PATCH] bfa: fix access to bfad_im_port_s

2017-12-06 Thread Johannes Thumshirn
James Bottomley writes: > On Tue, 2017-11-28 at 16:26 +0100, Johannes Thumshirn wrote: >> Commit 'cd21c605b2cf ("scsi: fc: provide fc_bsg_to_shost() helper")' >> changed access to bfa's 'struct bfad_im_port_s' by using shost_priv() >> instead of shost->hostdata[0]. >> >> This lead to crashes like

Re: [PATCH] list_lru: Prefetch neighboring list entries before acquiring lock

2017-12-06 Thread Michal Hocko
On Tue 05-12-17 15:56:18, Andrew Morton wrote: > On Tue, 5 Dec 2017 15:49:48 +0100 Michal Hocko wrote: [...] > > It also seems that there is no general agreement in the patch. Andrew, > > do you plan to keep it? > > It's in wait-and-see mode. OK, I will remove m32r from my compile test battery.

Re: [PATCH 1/2] KVM: x86: fix APIC page invalidation

2017-12-06 Thread Fabian Grünbichler
On Thu, Nov 30, 2017 at 07:05:45PM +0100, Radim Krčmář wrote: > Implementation of the unpinned APIC page didn't update the VMCS address > cache when invalidation was done through range mmu notifiers. > This became a problem when the page notifier was removed. > > Re-introduce the arch-specific hel

Re: [PATCH v3 2/6] iommu/vt-d: Add Intel IOMMU debugfs to show context internals

2017-12-06 Thread Lu Baolu
Hi, On 12/06/2017 11:43 AM, Sohil Mehta wrote: > From: Gayatri Kammela > > IOMMU internals states such as root and context can be exported to the > userspace. > > Example of such dump in Kabylake: > > root@OTC-KBLH-01:~# cat > /sys/kernel/debug/intel_iommu/dmar_translation_struct > > IOMMU dmar2:

Re: [PATCH net-next v3 4/4] net: fec: add phy_reset_after_clk_enable() support

2017-12-06 Thread Richard Leitner
Hi Andy, On 12/06/2017 02:50 AM, Andy Duan wrote: > From: Richard Leitner Sent: Tuesday, December 05, 2017 9:26 > PM >> Some PHYs (for example the SMSC LAN8710/LAN8720) doesn't allow turning >> the refclk on and off again during operation (according to their datasheet). >> Nonetheless exactly th

Re: [PATCH PTI] Fixup "x86/entry/64: Use a per-CPU trampoline stack for IDT entries"

2017-12-06 Thread Juergen Gross
On 06/12/17 07:00, Andy Lutomirski wrote: > Add to commit message: > > Using a trampoline stack would obnoxious for Xen PV because Xen PV > enters entry_SYSCALL_64_after_hwframe on the stack indicated by sp0. > This could be fixed, but I think it's nice to ensure the entry code > can still work wi

Re: [PATCH v3 3/6] iommu/vt-d: Add Intel IOMMU debugfs to show extended context internals

2017-12-06 Thread Lu Baolu
Hi, On 12/06/2017 11:43 AM, Sohil Mehta wrote: > From: Gayatri Kammela > > Debugfs extension to dump internals such as extended context table > entries for each IOMMU to the userspace. > > root@OTC-KBLH-01:~# cat > /sys/kernel/debug/intel_iommu/dmar_translation_struct > > IOMMU dmar1: Extended Ro

Re: [PATCH v3 3/6] iommu/vt-d: Add Intel IOMMU debugfs to show extended context internals

2017-12-06 Thread Lu Baolu
Hi, On 12/06/2017 11:43 AM, Sohil Mehta wrote: > From: Gayatri Kammela > > Debugfs extension to dump internals such as extended context table > entries for each IOMMU to the userspace. > > root@OTC-KBLH-01:~# cat > /sys/kernel/debug/intel_iommu/dmar_translation_struct > > IOMMU dmar1: Extended Ro

Re: Multiple oom_reaper BUGs: unmap_page_range racing with exit_mmap

2017-12-06 Thread Michal Hocko
On Tue 05-12-17 18:43:48, David Rientjes wrote: > Hi, > > I'd like to understand the synchronization between the oom_reaper's > unmap_page_range() and exit_mmap(). The latter does not hold > mm->mmap_sem: it's supposed to be the last thread operating on the mm > before it is destroyed. > > If

Re: [PATCH V11 4/5] vsprintf: add printk specifier %px

2017-12-06 Thread Geert Uytterhoeven
Hi Linus, On Wed, Dec 6, 2017 at 2:59 AM, Linus Torvalds wrote: > On Tue, Dec 5, 2017 at 5:36 PM, Sergey Senozhatsky > wrote: >> I see some %p-s being used in _supposedly_ important output, >> like arch/x86/mm/fault.c >> >> show_fault_oops(struct pt_regs *regs, unsigned long error_code, >>

[PATCH v5 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

2017-12-06 Thread Nickey Yang
From: Brian Norris Bridge drivers/helpers shouldn't be clobbering the drvdata, since a parent driver might need to own this. Instead, let's return our 'dw_mipi_dsi' object and have callers pass that back to us for removal. Signed-off-by: Brian Norris Signed-off-by: Nickey Yang Link:https://pat

[PATCH v5 0/3] Update ROCKCHIP DSI driver that uses dw-mipi-dsi bridge

2017-12-06 Thread Nickey Yang
We now have a generic dw-mipi-dsi bridge driver.So we send this patchs to moving rockchip dw-mipi-dsi driver to that in order to add new features(dual mipi support). Update ROCKCHIP DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. ChangeLog: v2: add err_p

[PATCH v5 2/3] dt-bindings: display: rockchip: update DSI controller

2017-12-06 Thread Nickey Yang
This patch update describe panel/port links, including unit addresses in documentation of device tree bindings for the rockchip DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Nickey Yang Reviewed-by: Brian Norris --- Changes v5: - add review tag ...

[PATCH v5 3/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

2017-12-06 Thread Nickey Yang
Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. Signed-off-by: Nickey Yang Signed-off-by: Brian Norris Reviewed-by: Brian Norris Reviewed-by: Sean Paul --- Changes: v2: add err_pllref, remove unnecessary encoder.enable & disable

Re: [RFC PATCH 2/5] perf jevents: add support for arch recommended events

2017-12-06 Thread John Garry
On 05/12/2017 17:27, Andi Kleen wrote: On Wed, Dec 06, 2017 at 12:13:16AM +0800, John Garry wrote: For some architectures (like arm64), there are architecture- defined recommended events. Vendors may not be obliged to follow the recommendation and may implement their own pmu event for a specific

Re: [PATCH v2 5/5] rtc: add mxc driver for i.MX53 SRTC

2017-12-06 Thread Sascha Hauer
On Tue, Dec 05, 2017 at 03:06:46PM +0100, linux-kernel-...@beckhoff.com wrote: > From: Patrick Bruenn > > Neither rtc-imxdi, rtc-mxc nor rtc-snvs are compatible with i.MX53. > > This is driver enables support for the low power domain SRTC features: > - 32-bit MSB of non-rollover time counter > -

RE: [PATCH net-next v3 4/4] net: fec: add phy_reset_after_clk_enable() support

2017-12-06 Thread Andy Duan
From: Richard Leitner Sent: Wednesday, December 06, 2017 4:12 PM >To: Andy Duan ; Richard Leitner ; >robh...@kernel.org; mark.rutl...@arm.com; and...@lunn.ch; >f.faine...@gmail.com; frowand.l...@gmail.com >Cc: da...@davemloft.net; geert+rene...@glider.be; >sergei.shtyl...@cogentembedded.com; bar.

Re: [PATCH v4 72/73] xfs: Convert mru cache to XArray

2017-12-06 Thread Dave Chinner
On Tue, Dec 05, 2017 at 08:45:49PM -0800, Matthew Wilcox wrote: > On Wed, Dec 06, 2017 at 02:14:56PM +1100, Dave Chinner wrote: > > > The other conversions use the normal API instead of the advanced API, so > > > all of this gets hidden away. For example, the inode cache does this: > > > > Ah, OK

Re: [PATCH V11 4/5] vsprintf: add printk specifier %px

2017-12-06 Thread Sergey Senozhatsky
On (12/06/17 09:32), Geert Uytterhoeven wrote: [..] > >> show_fault_oops(struct pt_regs *regs, unsigned long error_code, > >> unsigned long address) > >> ... > >> printk(KERN_CONT " at %p\n", (void *) address); > >> printk(KERN_ALERT "IP: %pS\n", (void *)regs->ip); >

Re: [PATCH V11 3/5] printk: hash addresses printed with %p

2017-12-06 Thread Geert Uytterhoeven
Hi Linus, On Wed, Dec 6, 2017 at 12:33 AM, Linus Torvalds wrote: > On Tue, Dec 5, 2017 at 2:57 PM, Geert Uytterhoeven > wrote: >> Lowest 3 is good enough for all natural types, up to long long. >> We may still receive complaints from people who care about seeing if >> a pointer is cacheline-ali

Re: Multiple oom_reaper BUGs: unmap_page_range racing with exit_mmap

2017-12-06 Thread Michal Hocko
On Wed 06-12-17 12:28:53, Tetsuo Handa wrote: > David Rientjes wrote: > > On Tue, 5 Dec 2017, David Rientjes wrote: > > > > > One way to solve the issue is to have two mm flags: one to indicate the > > > mm > > > is entering unmap_vmas(): set the flag, do down_write(&mm->mmap_sem); > > > up_wri

[PATCH v3 0/2] iio: hx711: add buffered trigger support

2017-12-06 Thread Andreas Klinger
changes in v3: thanks to the review of Jonathan, some issues were fixed: - locking in hx711_reset_read() - data positioning in trigger handler changes in v2: - in Kconfig it's needed to select IIO_BUFFER and IIO_TRIGGERED_BUFFER to compile cleanly with buffered triggers This small patch series

[PATCH v3 1/2] iio: hx711: add triggered buffer support

2017-12-06 Thread Andreas Klinger
Add buffer to device data struct and add trigger function Data format is quite simple: voltage - channel 0 32 Bit voltage - channel 1 32 Bit timestamp 64 Bit Using both channels at the same time is working quite slow because of changing the channel which needs a

[PATCH v3 2/2] iio: hx711: fix bug in reset functionality

2017-12-06 Thread Andreas Klinger
Return value in hx711_reset() should indicate status of dout otherwise the calling function is reporting an error as false positive If there are two reads too close to each other, then the second one will never succeed. This happens especially when using buffered mode with both channels enabled.

Re: [PATCH] staging: lustre: Fix sparse, using plain integer as NULL pointer in lov_object_fiemap()

2017-12-06 Thread gre...@linuxfoundation.org
On Mon, Dec 04, 2017 at 12:44:32PM +0200, Andrii Vladyka wrote: > Change 0 to NULL in lov_object_fiemap() in order to fix warning produced by > sparse > > Signed-off-by: Andrii Vladyka > Signed-off-by: Andreas Dilger > --- > > diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c > b/dri

Re: [PATCH 0/2] mm: introduce MAP_FIXED_SAFE

2017-12-06 Thread Florian Weimer
On 12/06/2017 09:06 AM, John Hubbard wrote: On 12/05/2017 11:35 PM, Florian Weimer wrote: On 12/06/2017 08:33 AM, John Hubbard wrote: In that case, maybe: MAP_EXACT ? ...because that's the characteristic behavior. Is that true?  mmap still silently rounding up the length to the page s

Re: [PATCH v4 3/5] remoteproc: Pass type of shutdown to subdev remove

2017-12-06 Thread Arnaud Pouliquen
Hello, I saw your new version but i 'm answering to this one to continue discussion. On 12/05/2017 06:17 PM, Bjorn Andersson wrote: > On Tue 05 Dec 02:54 PST 2017, Arnaud Pouliquen wrote: > >> >> >> On 12/05/2017 07:46 AM, Bjorn Andersson wrote: >>> On Fri 01 Dec 06:50 PST 2017, Arnaud Pouliquen

Re: [PATCH v2 1/4] sched/fair: always used unsigned long for utilization

2017-12-06 Thread Vincent Guittot
On 5 December 2017 at 18:10, Patrick Bellasi wrote: > Utilization and capacity are tracked as unsigned long, however some > functions using them return an int which is ultimately assigned back to > unsigned long variables. > > Since there is not scope on using a different and signed type, this > c

Re: [question] handle the page table RAS error

2017-12-06 Thread gengdongjiu
On 2017/12/6 0:57, Andi Kleen wrote: > x86 doesn't handle it. > > There are lots of memory types that are not handled by MCE recovery > because it is just too difficult. In general MCE recovery focuses on > memory types that use up significant percent of total memory. Page tables > are normally

Re: [PATCH v2 0/4] arm64: defconfig: enable additional led triggers

2017-12-06 Thread Amit Kucheria
(Adding Arnd) Now that the merge window rush has abated, can you please apply this trivial series? On Mon, Nov 6, 2017 at 12:38 PM, Amit Kucheria wrote: > This patchset enables the kernel panic and disk-activity trigger for LEDs > and then enables the panic trigger for three 96Boards - DB410c, H

Re: linux-next: build failure after merge of the mfd tree

2017-12-06 Thread Lee Jones
On Wed, 06 Dec 2017, Stephen Rothwell wrote: > Hi Lee, > > On Mon, 4 Dec 2017 09:39:53 + Lee Jones wrote: > > > > > I added the following fix patch: > > > > > > From: Stephen Rothwell > > > Date: Mon, 4 Dec 2017 14:10:34 +1100 > > > Subject: [PATCH] misc: rtsx: fix symbol clashes > > > >

Re: [PATCH v2 5/5] rtc: add mxc driver for i.MX53 SRTC

2017-12-06 Thread Alexandre Belloni
On 06/12/2017 at 09:36:18 +0100, Sascha Hauer wrote: > > +/* > > + * This function updates the RTC alarm registers and then clears all the > > + * interrupt status bits. > > + * The caller should hold the pdata->lock > > + * > > + * @param alrm the new alarm value to be updated in the RTC

Re: Multiple oom_reaper BUGs: unmap_page_range racing with exit_mmap

2017-12-06 Thread Michal Hocko
On Tue 05-12-17 23:48:21, David Rientjes wrote: [...] > I think this argues to do MMF_REAPING-style behavior at the beginning of > exit_mmap() and avoid reaping all together once we have reached that > point. There are no more users of the mm and we are in the process of > tearing it down, I'm

Re: [PATCH] staging: pi433: Fixes issue with bit shift in rf69_get_modulation

2017-12-06 Thread Greg KH
On Wed, Nov 08, 2017 at 07:13:56PM +0200, Marcus Wolf wrote: > Fixes issue with bit shift in rf69_get_modulation What "issue"? > > Signed-off-by: Marcus Wolf > --- > drivers/staging/pi433/rf69.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/pi433/

Re: [question] handle the page table RAS error(Avoid kernel panic when killing an application)

2017-12-06 Thread gengdongjiu
change the mail subject and resend the mail On 2017/12/6 16:56, gengdongjiu wrote: > > On 2017/12/6 0:57, Andi Kleen wrote: > x86 doesn't handle it. > > There are lots of memory types that are not handled by MCE recovery > because it is just too difficult. In general MCE recovery focuses on > me

Re: [PATCH] aio: Add memcg accounting of user used data

2017-12-06 Thread Michal Hocko
On Tue 05-12-17 19:02:00, Kirill Tkhai wrote: > On 05.12.2017 18:43, Michal Hocko wrote: > > On Tue 05-12-17 18:34:59, Kirill Tkhai wrote: > >> On 05.12.2017 18:15, Michal Hocko wrote: > >>> On Tue 05-12-17 13:00:54, Kirill Tkhai wrote: > Currently, number of available aio requests may be > >>

Re: [PATCH v2 06/11] staging: pi433: Split rf69_set_crc_enabled into two functions

2017-12-06 Thread Marcus Wolf
Am 06.12.2017 um 00:08 schrieb Simon Sandström: Splits rf69_set_crc_enabled(dev, enabled) into rf69_enable_crc(dev) and rf69_disable_crc(dev). Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 22 -- drivers/staging/pi433/rf69.c | 18 ++--

RE: [PATCH] [linux][master][v1] misc: Add Xilinx ZYNQMP VCU logicoreIP init driver

2017-12-06 Thread Dhaval Rajeshbhai Shah
> -Original Message- > From: 'Greg KH' [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, December 05, 2017 11:56 PM > To: Dhaval Rajeshbhai Shah > Cc: a...@arndb.de; linux-kernel@vger.kernel.org; michal.si...@xilinx.com; > Hyun Kwon > Subject: Re: [PATCH] [linux][master][v1] misc: Ad

Re: [PATCH 0/2] mm: introduce MAP_FIXED_SAFE

2017-12-06 Thread Michal Hocko
On Wed 06-12-17 08:33:37, Rasmus Villemoes wrote: > On 2017-12-06 05:50, Michael Ellerman wrote: > > Michal Hocko writes: > > > >> On Wed 29-11-17 14:25:36, Kees Cook wrote: > >> It is safe in a sense it doesn't perform any address space dangerous > >> operations. mmap is _inherently_ about the a

[PATCH v6 0/3] Update ROCKCHIP DSI driver that uses dw-mipi-dsi bridge

2017-12-06 Thread Nickey Yang
We now have a generic dw-mipi-dsi bridge driver.So we send this patchs to moving rockchip dw-mipi-dsi driver to that in order to add new features(dual mipi support). Update ROCKCHIP DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. ChangeLog: v2: add err_p

[PATCH v6 2/3] dt-bindings: display: rockchip: update DSI controller

2017-12-06 Thread Nickey Yang
This patch update describe panel/port links, including unit addresses in documentation of device tree bindings for the rockchip DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Nickey Yang Reviewed-by: Brian Norris --- .../display/rockchip/dw_mipi_dsi_roc

[PATCH v6 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

2017-12-06 Thread Nickey Yang
From: Brian Norris Bridge drivers/helpers shouldn't be clobbering the drvdata, since a parent driver might need to own this. Instead, let's return our 'dw_mipi_dsi' object and have callers pass that back to us for removal. Signed-off-by: Brian Norris Signed-off-by: Nickey Yang Link:https://pat

[PATCH v6 3/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

2017-12-06 Thread Nickey Yang
Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. Signed-off-by: Nickey Yang Signed-off-by: Brian Norris Reviewed-by: Brian Norris Reviewed-by: Sean Paul --- change: v2: add err_pllref, remove unnecessary encoder.enable & disable c

[PATCH] usb: core: Add "quirks" parameter for usbcore

2017-12-06 Thread Kai-Heng Feng
Trying quirks in usbcore needs to rebuild the driver or the entire kernel if it's builtin. It can save a lot of time if usbcore has similar ability like "usbhid.quirks=" and "usb-storage.quirks=". Rename the original quirk detection function to "static" as we introduce this new "dynamic" function.

Re: [PATCH 1/2] usbip: Delete an error message for a failed memory allocation in two functions

2017-12-06 Thread SF Markus Elfring
>> Omit an extra message for a memory allocation failure in these functions. >> >> This issue was detected by using the Coccinelle software. > > Please include the problem Do you find the wording “WARNING: Possible unnecessary 'out of memory' message” from the script “checkpatch.pl” more reasonab

Re: [PATCH v2 08/11] staging: pi433: Remove enum data_mode

2017-12-06 Thread Marcus Wolf
Am 06.12.2017 um 00:08 schrieb Simon Sandström: Call rf69_set_data_mode with DATAMODUL_MODE value directly. Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/rf69.c | 15 ++- drivers/staging/pi433/rf69.h | 2 +- dri

Re: [PATCH] drm/fb-helper: Fix potential NULL pointer dereference

2017-12-06 Thread Daniel Vetter
On Tue, Dec 05, 2017 at 11:46:28AM -0600, Gustavo A. R. Silva wrote: > fb_helper is being dereferenced before it is null checked, > hence there is a potential null pointer dereference. > > Fix this by moving the pointer dereference after fb_helper > has been null checked. > > This issue was detec

Re: [PATCH] usb: core: Add "quirks" parameter for usbcore

2017-12-06 Thread Greg KH
On Wed, Dec 06, 2017 at 05:09:32PM +0800, Kai-Heng Feng wrote: > +/* Works only for digits and letters, but small and fast */ > +#define TOLOWER(x) ((x) | 0x20) What is wrong with the in-kernel version of tolower()? thanks, greg k-h

Re: [PATCH] [linux][master][v1] misc: Add Xilinx ZYNQMP VCU logicoreIP init driver

2017-12-06 Thread 'Greg KH'
On Wed, Dec 06, 2017 at 09:05:51AM +, Dhaval Rajeshbhai Shah wrote: > > Then you need to explain this a lot better, posting a random driver for > > submission that is expected to be used by another one isn't ok. > > Post the whole patch series please, we do not add infrastructure to the > > ker

Re: [RFC 19/19] s390/facilities: enable AP facilities needed by guest

2017-12-06 Thread Pierre Morel
On 05/12/2017 16:01, Tony Krowiak wrote: On 12/05/2017 09:04 AM, Cornelia Huck wrote: On Tue, 5 Dec 2017 08:52:57 +0100 Harald Freudenberger wrote: On 12/02/2017 02:30 AM, Tony Krowiak wrote: I agree with your suggestion that defining a new CPU model feature is probably the best way to resol

Re: [PATCH 1/1] mtd: nand: brcmnand: Zero bitflip is not an error

2017-12-06 Thread Boris Brezillon
On Mon, 20 Nov 2017 11:26:26 +0800 Albert Hsieh wrote: > A negative return value of brcmstb_nand_verify_erased_page() indicates a > real bitflip error of an erased page, and other return values (>= 0) show > the corrected bitflip number. Zero return value means no bitflip, but the > current drive

Re: [kernel-hardening][PATCH v3 3/3] arm: mm: dump: add checking for writable and executable pages

2017-12-06 Thread Jinbum Park
2017-12-06 8:51 GMT+09:00 Laura Abbott : > On 12/04/2017 06:27 AM, Jinbum Park wrote: >> >> Page mappings with full RWX permissions are a security risk. >> x86, arm64 has an option to walk the page tables >> and dump any bad pages. >> >> (1404d6f13e47 >> ("arm64: dump: Add checking for writable and

Re: [PATCH] ptr_ring: add barriers

2017-12-06 Thread George Cherian
Hi Michael, On 12/06/2017 12:59 AM, Michael S. Tsirkin wrote: Users of ptr_ring expect that it's safe to give the data structure a pointer and have it be available to consumers, but that actually requires an smb_wmb or a stronger barrier. This is not the exact situation we are seeing. Let me t

Re: [PATCH 1/2] drm/nouveau/bar/gf100: fix hang when calling ->fini() before ->init()

2017-12-06 Thread Guillaume Tucker
On 05/12/17 18:32, Ben Skeggs wrote: On Wed, Dec 6, 2017 at 12:30 AM, Jon Hunter wrote: On 04/12/17 18:37, Guillaume Tucker wrote: If the firmware fails to load then ->fini() will be called before the device has been initialised, causing the kernel to hang while trying to write to a register

Re: [PATCH v2] w1: driver for serial linkUSB, linkOEM, LINK devices

2017-12-06 Thread Greg KH
On Sun, Nov 12, 2017 at 10:04:47PM +0100, Hans-Frieder Vogt wrote: > Hi, > > attached is the revised version of a driver that supports the serial OneWire > masters from iButtonLink(TM) in the w1 kernel driver. In order to be usable > it needs an updated userland tool (patch included in documenta

Re: [PATCH v3 2/4] kaslr: calculate the memory region in immovable node

2017-12-06 Thread Baoquan He
On 12/05/17 at 11:40am, Kees Cook wrote: > On Tue, Dec 5, 2017 at 12:51 AM, Chao Fan wrote: > > If there is no immovable memory region specified, go on the old code. > > There are several conditons: > > 1. CONFIG_MEMORY_HOTPLUG is not specified to y. > > 2. immovable_mem= is not specified. > > > >

Re: [PATCH 1/2] mm: introduce MAP_FIXED_SAFE

2017-12-06 Thread Michal Hocko
On Wed 06-12-17 16:15:24, Michael Ellerman wrote: > Hi Michal, > > Some comments below. > > Michal Hocko writes: > > > From: Michal Hocko > > > > MAP_FIXED is used quite often to enforce mapping at the particular > > range. The main problem of this flag is, however, that it is inherently > > d

Re: [PATCH] usb: core: Add "quirks" parameter for usbcore

2017-12-06 Thread Kai Heng Feng
> On 6 Dec 2017, at 5:13 PM, Greg KH wrote: > > On Wed, Dec 06, 2017 at 05:09:32PM +0800, Kai-Heng Feng wrote: >> +/* Works only for digits and letters, but small and fast */ >> +#define TOLOWER(x) ((x) | 0x20) > > What is wrong with the in-kernel version of tolower()? Nothing’s wrong with the

[PATCH v2 1/2] KVM: MMU: Fix infinite loop when there is no available mmu page

2017-12-06 Thread Wanpeng Li
From: Wanpeng Li The below test case can cause infinite loop in kvm when ept=0. #include #include #include #include #include #include #include long r[5]; int main() { r[2] = open("/dev/kvm", O_RDONLY); r[3] = ioctl(r[2], KVM_CREATE_

RE: [PATCH v2 5/5] rtc: add mxc driver for i.MX53 SRTC

2017-12-06 Thread Patrick Brünn
>From: Alexandre Belloni [mailto:alexandre.bell...@free-electrons.com] >Sent: Mittwoch, 6. Dezember 2017 09:58 >On 06/12/2017 at 09:36:18 +0100, Sascha Hauer wrote: >> > +/* >> > + * This function updates the RTC alarm registers and then clears all the >> > + * interrupt status bits. >> > + * The c

[PATCH v2 2/2] KVM: X86: Reduce the overhead when lapic_timer_advance is disabled

2017-12-06 Thread Wanpeng Li
From: Wanpeng Li When I run ebizzy in a 32 vCPUs guest on a 32 pCPUs Xeon box, I can observe ~8000 kvm_wait_lapic_expire CurAvg/s through kvm_stat tool even if the advance tscdeadline hrtimer expiration is disabled. Each call to wait_lapic_expire() will consume ~70 cycles when a timer fires since

RE: [PATCH] xen-netback: Fix logging message with spurious period after newline

2017-12-06 Thread Paul Durrant
> -Original Message- > From: Joe Perches [mailto:j...@perches.com] > Sent: 06 December 2017 06:40 > To: Wei Liu ; Paul Durrant > Cc: xen-de...@lists.xenproject.org; net...@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: [PATCH] xen-netback: Fix logging message with spurious per

RE: [PATCH v3 08/21] fpga: add Intel FPGA DFL PCIe device

2017-12-06 Thread David Laight
From: Alan Tull > Sent: 04 December 2017 19:47 > > On Mon, Nov 27, 2017 at 9:15 PM, Wu Hao wrote: > > On Mon, Nov 27, 2017 at 10:28:04AM +, David Laight wrote: > >> From: Wu Hao > >> > Sent: 27 November 2017 06:42 > >> > From: Zhang Yi > >> > > >> > The Intel FPGA device appears as a PCIe de

[PATCH] staging: lustre: Fix sparse, using plain integer as NULL pointer in lov_object_fiemap()

2017-12-06 Thread Andrii
Change 0 to NULL in lov_object_fiemap() in order to fix warning produced by sparse Signed-off-by: Andrii Vladyka Signed-off-by: Andreas Dilger diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c b/drivers/staging/lustre/lustre/lov/lov_object.c index 105b707..897cf2c 100644 --- a/driv

RE: [PATCH v3 08/21] fpga: add Intel FPGA DFL PCIe device

2017-12-06 Thread David Laight
From: Wu Hao > Sent: 05 December 2017 03:34 ... > > I don't see anything Intel specific here. This could all be named dfl-* > > The maybe some device specific things, e.g Intel FPGA devices supported by > this > driver always have FME DFL at the beginning on the BAR0 for PF device. Since when h

Re: GemniLake laptops goes power off directly after performing suspend

2017-12-06 Thread Chris Chiu
On Wed, Dec 6, 2017 at 5:56 AM, Rafael J. Wysocki wrote: > On Tuesday, December 5, 2017 5:19:03 PM CET Chris Chiu wrote: >> On Tue, Dec 5, 2017 at 11:01 PM, Rafael J. Wysocki wrote: >> > On Tue, Dec 5, 2017 at 11:32 AM, Chris Chiu wrote: >> >> Hi, >> >> I have 2 GemniLake laptops from ASUS,

Re: [PATCH v3 1/4] kaslr: add immovable_mem=nn[KMG]@ss[KMG] to specify extracting memory

2017-12-06 Thread Baoquan He
Hi Chao, Yes, now the code looks much better than the last version. On 12/05/17 at 04:51pm, Chao Fan wrote: > In current code, kaslr may choose the memory region in movable > nodes to extract kernel, which will make the nodes can't be hot-removed. > To solve it, we can specify the memory region i

Re: x86 TLB flushing: INVPCID vs. deferred CR3 write

2017-12-06 Thread Peter Zijlstra
On Tue, Dec 05, 2017 at 05:27:31PM -0800, Dave Hansen wrote: > tl;dr: Kernels with pagetable isolation using INVPCID compile kernels > 0.58% faster than using the deferred CR3 write. This tends to say that > we should leave things as-is and keep using INVPCID, but it's far from > definitive. Much

RE: [PATCH] [linux][master][v1] misc: Add Xilinx ZYNQMP VCU logicoreIP init driver

2017-12-06 Thread Dhaval Rajeshbhai Shah
> -Original Message- > From: 'Greg KH' [mailto:gre...@linuxfoundation.org] > Sent: Wednesday, December 06, 2017 1:16 AM > To: Dhaval Rajeshbhai Shah > Cc: a...@arndb.de; linux-kernel@vger.kernel.org; michal.si...@xilinx.com; > Hyun Kwon > Subject: Re: [PATCH] [linux][master][v1] misc: A

Re: [PATCH v3 4/6] sched/rt: fast switch to maximum frequency when RT tasks are scheduled

2017-12-06 Thread Vincent Guittot
Hi Patrick, On 30 November 2017 at 12:47, Patrick Bellasi wrote: > Currently schedutil updates are triggered for the RT class using a single > call place, which is part of the rt::update_curr_rt() used in: > > - dequeue_task_rt: > but it does not make sense to set the schedutil's SCHED_CPUFREQ_

Re: [PATCH v2 06/11] staging: pi433: Split rf69_set_crc_enabled into two functions

2017-12-06 Thread Dan Carpenter
On Wed, Dec 06, 2017 at 11:05:22AM +0200, Marcus Wolf wrote: > > > Am 06.12.2017 um 00:08 schrieb Simon Sandström: > > Splits rf69_set_crc_enabled(dev, enabled) into > > rf69_enable_crc(dev) and rf69_disable_crc(dev). > > > > Signed-off-by: Simon Sandström > > --- > > drivers/staging/pi433/pi

Re: [PATCH v4] pata_pdc2027x: Fix pdc_adjust_pll() to return the error value

2017-12-06 Thread Sergei Shtylyov
Hello! On 12/5/2017 9:50 PM, Arvind Yadav wrote: This change is to ensure that function pdc_adjust_pll() returns the error value to avoid the unnecessary error check for pdc_hardware_init() in pdc2027x_reinit_one(). Signed-off-by: Arvind Yadav --- changes in v2 : Make function

Re: [alsa-devel] [PATCH v4 09/15] soundwire: Add slave status handling

2017-12-06 Thread Vinod Koul
On Sun, Dec 03, 2017 at 09:52:48PM -0600, Pierre-Louis Bossart wrote: > On 12/3/17 9:21 PM, Vinod Koul wrote: > >On Sun, Dec 03, 2017 at 09:11:39PM -0600, Pierre-Louis Bossart wrote: > >>On 12/3/17 11:11 AM, Vinod Koul wrote: > >>>On Fri, Dec 01, 2017 at 05:52:03PM -0600, Pierre-Louis Bossart wrote

Re: [PATCH v2 09/11] staging: pi433: Combine all rf69_set_amplifier_x()

2017-12-06 Thread Marcus Wolf
Am 06.12.2017 um 00:08 schrieb Simon Sandström: Replaces the functions rf69_set_amplifier_1, _2, _3 with two functions: rf69_enable_amplifier(dev, amp_mask) and rf69_disable_amplifier(dev, amp_mask). Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 6 +++--- drivers/s

Re: [PATCH v2] pata_pdc2027x: Fix coding sytle errors

2017-12-06 Thread Sergei Shtylyov
On 12/5/2017 9:26 PM, Arvind Yadav wrote: Fix these checkpatch.pl errors: Fix checkpatch.pl error: Why repeat it twice? ERROR: space prohibited before open square bracket '['. ERROR: space prohibited after that '~' (ctx:WxW) + mask &= ~ (1 << (6 + ATA_SHIFT_UDMA)); ERROR:

Re: [PATCH] eeprom: at24: Change nvmem stride to 1

2017-12-06 Thread Srinivas Kandagatla
On 04/12/17 17:44, Bartosz Golaszewski wrote: at24->nvmem_config.priv = at24; - at24->nvmem_config.stride = 4; + at24->nvmem_config.stride = 1; at24->nvmem_config.word_size = 1; at24->nvmem_config.size = chip.byte_len; -- 2.7.4 I can't find any document

RE: [PATCH v3 08/21] fpga: add Intel FPGA DFL PCIe device

2017-12-06 Thread David Laight
From: Wu Hao > Sent: 06 December 2017 05:30 ... > > Regarding file names, it seems like the files added to drivers/fpga > > could be uniformly named dfl-*.[ch]. Some are fpga-dfl-*.[ch] while > > other are currently dfl-*.[ch] currently. They don't even want to do into a drivers/fgpa directory. M

Re: [kernel-hardening][PATCH v3 1/3] arm: mm: dump: make page table dumping reusable

2017-12-06 Thread Jinbum Park
>> +#ifndef __ASM_PTDUMP_H >> +#define __ASM_PTDUMP_H >> + >> +#ifdef CONFIG_ARM_PTDUMP_CORE > > Is this #ifdef needed? I think this file is only included in dump.c > and ptdump_debugfs.c, both of which are only built when > CONFIG_ARM_PTDUMP_CORE is defined. Looking at next patch in this patch-se

[Bug fix] octeon-i2c driver improvement [1/2]

2017-12-06 Thread Zhang, Sean C. (NSB - CN/Hangzhou)
Hi Jan and David, For octeon-i2c driver, there only has bus recovery for octeon TWSI low level control mode, no recovery for high level control mode, attached patch is used to extend the recovery step from octeon_i2c_start() to octeon_i2c_xfer() for some case octeon TWSI high level control mode

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

2017-12-06 Thread Marcus Wolf
Am 06.12.2017 um 00:08 schrieb Simon Sandström: Renames the enum optionOnOff and its values optionOn, optionOff to enum option_on_off and OPTION_ON, OPTION_OFF. Fixes checkpatch.pl warnings: "Avoid CamelCase: , , ". Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 34 +

Re: Save and Restore Generic Interrupt Controller for System Sleep on ARM

2017-12-06 Thread Marc Zyngier
On Thu, Nov 30 2017 at 5:21:20 pm GMT, "dbasehore ." wrote: > On Thu, Nov 30, 2017 at 1:44 AM, Marc Zyngier wrote: >> On Wed, Nov 29 2017 at 2:49:18 pm GMT, "dbasehore ." >> wrote: >>> There was some work in ARM Trusted Firmware to support saving and >>> restoring the Generic Interrupt Control

[Bug fix] octeon-i2c driver improvement [2/2]

2017-12-06 Thread Zhang, Sean C. (NSB - CN/Hangzhou)
Hi Jan and David, For octeon-i2c driver, there has duplicated interrupt disable in octeon_i2c_isr(), octeon_i2c_hlc_wait() and octeon_i2c_wait(), since octeon_i2c_hlc_wait() and octeon_i2c_wait() has pair of interrupt enable and disable, so the interrupt disable in octeon_i2c_isr() is not necessa

Re: [PATCH 1/2] KVM: x86: fix APIC page invalidation

2017-12-06 Thread 王金浦
2017-12-06 3:32 GMT+01:00 Wanpeng Li : > 2017-12-01 2:05 GMT+08:00 Radim Krčmář : >> Implementation of the unpinned APIC page didn't update the VMCS address >> cache when invalidation was done through range mmu notifiers. >> This became a problem when the page notifier was removed. >> >> Re-introdu

[GIT PULL 0/3] EFI fixes for v4.15

2017-12-06 Thread Ard Biesheuvel
The following changes since commit ae64f9bd1d3621b5e60d7363bc20afb46aede215: Linux 4.15-rc2 (2017-12-03 11:01:47 -0500) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git efi-urgent for you to fetch changes up to bfe89df500c99e29fbd0fd6f18e396f

[PATCH 3/3] efi: add comment to avoid future expanding of sysfs systab

2017-12-06 Thread Ard Biesheuvel
From: Dave Young /sys/firmware/efi/systab shows several different values, it breaks sysfs one file one value design. But since there are already userspace tools depend on it eg. kexec-tools so add code comment to alert future expanding of this file. Signed-off-by: Dave Young Reviewed-by: Greg

[PATCH 1/3] efi: move some sysfs files to be read-only by root

2017-12-06 Thread Ard Biesheuvel
From: Greg Kroah-Hartman Thanks to the scripts/leaking_addresses.pl script, it was found that some EFI values should not be readable by non-root users. So make them root-only, and to do that, add a __ATTR_RO_MODE() macro to make this easier, and use it in other places at the same time. Reported

[PATCH 2/3] efi/esrt: use memunmap rather kfree to free the remapping

2017-12-06 Thread Ard Biesheuvel
From: Pan Bian The remapping result of memremap should be freed with memunmap, not kfree. Signed-off-by: Pan Bian Cc: Matt Fleming Cc: Signed-off-by: Ard Biesheuvel --- drivers/firmware/efi/esrt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/efi/esrt.

[PATCH v3 0/3] iio: temperataure: MLX90632

2017-12-06 Thread Crt Mori
Hi everybody, With the sensor now available to broad public, it is time to also share the driver with the community. MLX90632 is just 3x3mm in size, but with factory calibration offers instant usage in every project. Driver currently provides basic functionality, but I might add some more fancy f

Re: [PATCH] firmware: qcom: scm: Fix incorrect of_node_put call in scm_init

2017-12-06 Thread Loys Ollivier
Please discard this patch. The if statement becoming a one liner, the curly brackets should be removed. I will send a v2. On 05/12/2017 16:52, Loys Ollivier wrote: > When using other platform architectures, in the init of the qcom_scm > driver, of_node_put is called on /firmware if no qcom dt is f

[PATCH v3 3/3] lib: Add strongly typed 64bit int_sqrt

2017-12-06 Thread Crt Mori
There is no option to perform 64bit integer sqrt on 32bit platform. Added stronger typed int_sqrt64 enables the 64bit calculations to be performed on 32bit platforms. Although int_sqrt() is a rough approximation, the same algorithm is used in int_sqrt64() as good enough on 32bit platform. Signed-o

[PATCH] ptr_ring: Add barriers to fix NULL-pointer exception

2017-12-06 Thread George Cherian
While running a multiple VM testscase with each VM running iperf traffic between others the following kernel NULL pointer exception was seen. Race appears when the tun driver instance of one VM calls skb_array_produce (from tun_net_xmit) and the the destined VM's skb_array_consume (from tun_ring_r

Re: [PATCH 1/2] KVM: x86: fix APIC page invalidation

2017-12-06 Thread Paolo Bonzini
On 06/12/2017 10:50, 王金浦 wrote: > 2017-12-06 3:32 GMT+01:00 Wanpeng Li : >> 2017-12-01 2:05 GMT+08:00 Radim Krčmář : >>> Implementation of the unpinned APIC page didn't update the VMCS address >>> cache when invalidation was done through range mmu notifiers. >>> This became a problem when the page

Re: [PATCH] aio: Add memcg accounting of user used data

2017-12-06 Thread Kirill Tkhai
On 06.12.2017 12:05, Michal Hocko wrote: > On Tue 05-12-17 19:02:00, Kirill Tkhai wrote: >> On 05.12.2017 18:43, Michal Hocko wrote: >>> On Tue 05-12-17 18:34:59, Kirill Tkhai wrote: On 05.12.2017 18:15, Michal Hocko wrote: > On Tue 05-12-17 13:00:54, Kirill Tkhai wrote: >> Currently,

Re: [Nouveau] [PATCH] drm/nouveau/mmu: fix odd_ptr_err.cocci warnings

2017-12-06 Thread Karol Herbst
Reviewed-by: Karol Herbst On Thu, Nov 30, 2017 at 8:53 PM, Christoph Böhmwalder wrote: > The kbuild test bot complained about a new coccinelle warning nearby, > which sparked a discussion about the assignment to 'memory' inside of > the conditional expression. See Link below for the original po

Re: [PATCH] staging: pi433: Fixes issue with bit shift in rf69_get_modulation

2017-12-06 Thread Marcus Wolf
Am 06.12.2017 um 11:02 schrieb Greg KH: On Wed, Nov 08, 2017 at 07:13:56PM +0200, Marcus Wolf wrote: Fixes issue with bit shift in rf69_get_modulation What "issue"? Signed-off-by: Marcus Wolf --- drivers/staging/pi433/rf69.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

Re: [PATCH v2] mmap.2: MAP_FIXED updated documentation

2017-12-06 Thread Cyril Hrubis
Hi! > (It does seem unfortunate that the man page cannot help the programmer > actually write correct code here. He or she is forced to read the kernel > implementation, in order to figure out the true alignment rules. I was > hoping we could avoid that.) It would be nice if we had this informatio

Re: [PATCH 1/2] mm: introduce MAP_FIXED_SAFE

2017-12-06 Thread Michal Hocko
On Wed 06-12-17 10:27:24, Michal Hocko wrote: > On Wed 06-12-17 16:15:24, Michael Ellerman wrote: [...] > > So I think I proved above that all the arches that are using 0x8 are > > also using mman-common.h, and vice-versa. > > > > So you can put this in mman-common.h can't your? > > Yes it se

Re: [PATCH v3 2/4] kaslr: calculate the memory region in immovable node

2017-12-06 Thread Chao Fan
On Wed, Dec 06, 2017 at 05:28:00PM +0800, Baoquan He wrote: >On 12/05/17 at 11:40am, Kees Cook wrote: >> On Tue, Dec 5, 2017 at 12:51 AM, Chao Fan wrote: >> > If there is no immovable memory region specified, go on the old code. >> > There are several conditons: >> > 1. CONFIG_MEMORY_HOTPLUG is no

  1   2   3   4   5   6   7   8   9   10   >