[PATCH v2 0/8] tpm: factor out tpm1 code into tpm1-cmd.c

2018-03-10 Thread Tomas Winkler
Move TPM1 implementation from tpm-interface.c to tpm1-cmd.c similarly to tpm2-cmd.c, as well as move TPM2 open code flows into new functions to tpm2-cmd.c The functions in tpm-interface.c should now be in form: int tpm_func(struct tpm_chip *chip) { if (chip->flags & TPM_CHIP_FLAG_TPM2)

[PATCH v2 3/8] tpm: factor out tpm1_get_random into tpm1-cmd.c

2018-03-10 Thread Tomas Winkler
Factor out get random implementation from tpm-interface.c into tpm1_get_random function in tpm1-cmd.c. No functional changes. Signed-off-by: Tomas Winkler --- drivers/char/tpm/tpm-interface.c | 56 drivers/char/tpm/tpm.h

[PATCH v2 7/8] tpm: Move pcr extend to tpm2-cmd.c

2018-03-10 Thread Tomas Winkler
Add tpm2_pcr_extend function to tpm2-cmd.c with signature required by tpm-interface.c. It wraps the original open code implementation. The original original tpm2_pcr_extend function is renamed and made static, called only from new tpm2_pcr_extend. Signed-off-by: Tomas Winkler

[PATCH 2/2] seq_file: account everything

2018-03-10 Thread Alexey Dobriyan
All it takes to open a file and read 1 byte from it. seq_file will be allocated along with any private allocations, and more importantly seq file buffer which is 1 page by default. Signed-off-by: Alexey Dobriyan --- fs/seq_file.c |8 1 file changed, 4

Re: [PATCH v5 02/11] xfs, dax: introduce xfs_dax_aops

2018-03-10 Thread Christoph Hellwig
> +int dax_set_page_dirty(struct page *page) > +{ > + /* > + * Unlike __set_page_dirty_no_writeback that handles dirty page > + * tracking in the page object, dax does all dirty tracking in > + * the inode address_space in response to mkwrite faults. In the > + * dax case

Re: [PATCH v5 11/11] xfs, dax: introduce xfs_break_dax_layouts()

2018-03-10 Thread Christoph Hellwig
> +static int xfs_wait_dax_page( > + atomic_t*count, > + unsigned intmode) > +{ Normal XFS style would be: static int xfs_wait_dax_page( atomic_t*count, unsigned intmode) { > + struct page

[PATCH v2] Staging: iio: adis16209: Move adis16209 driver out of staging

2018-03-10 Thread Shreeya Patel
Move the adis16209 driver out of staging directory and merge to the mainline IIO subsystem. Signed-off-by: Shreeya Patel --- Changes in v2 -Re-send the patch after having some cleanups in the file included in this patch. drivers/iio/accel/Kconfig |

[PATCH v2] scripts/kconfig: cleanup symbol handling code

2018-03-10 Thread Joey Pabalinas
Many of the variable names in scripts/kconfig/symbol.c are far too terse to the point of not at all identifying _what_ they are actually used for (`p` and `l` as a couple examples), and overall there is a large amount of code that could use some cleaning up. Give more explicit names to these

[PATCH] staging: speakup: Add unicode support to the speakup_dummy driver

2018-03-10 Thread Samuel Thibault
This extends spk_io_ops with a synth_out_unicode which takes a u16 character instead of just a byte, and extends spk_ttyio to implement it to emit utf-8. spk_do_catch_up_unicode can then be introduced to benefit from synth_out_unicode, and speakup_dummy made to use spk_do_catch_up_unicode instead

[PATCH] ARM: dts: uniphier: use proper SPDX-License-Identifier style

2018-03-10 Thread Masahiro Yamada
According to Documentation/process/license-rules.rst, move the SPDX License Identifier to the very top of the file. I used C++ comment style not only for the SPDX line but for the entire block because this seems Linus' preference [1]. I also dropped the parentheses to follow the examples in that

arch/h8300/include/asm/byteorder.h:5:0: warning: "__BIG_ENDIAN" redefined

2018-03-10 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: cdb06e9d8f520c969676e7d6778cffe5894f079f commit: 101110f6271ce956a049250c907bc960030577f8 Kbuild: always define endianess in kconfig.h date: 2 weeks ago config: h8300-h8300h-sim_defconfig (attached as

Re: [PATCH] device_handler: remove VLAs

2018-03-10 Thread Stephen Kitt
Hi Bart, On Fri, 9 Mar 2018 22:48:10 +, Bart Van Assche wrote: > On Fri, 2018-03-09 at 23:32 +0100, Stephen Kitt wrote: > > In preparation to enabling -Wvla, remove VLAs and replace them with > > fixed-length arrays instead. > > > > scsi_dh_{alua,emc,rdac} use

Re: [PATCH] EDAC, sb_edac: Remove VLA usage

2018-03-10 Thread Borislav Petkov
On Fri, Mar 09, 2018 at 09:02:18PM -0600, Gustavo A. R. Silva wrote: > In preparation to enabling -Wvla, remove VLA and replace it > with a fixed-length array instead. > > Fixed as part of the directive to remove all VLAs from > the kernel: https://lkml.org/lkml/2018/3/7/621 > > Signed-off-by:

[PATCH v3 09/20] firmware: move firmware loader into its own directory

2018-03-10 Thread Luis R. Rodriguez
This will make it much easier to manage as we manage to keep trimming componnents down into their own files to more easily manage and maintain this codebase. Suggested-by: Kees Cook Signed-off-by: Luis R. Rodriguez --- MAINTAINERS

[PATCH v3 20/20] mt7601u: use request_firmware_cache() to address cache on reboot

2018-03-10 Thread Luis R. Rodriguez
request_firmware_cache() will ensure the firmware is available on resume from suspend if on reboot the device retains the firmware. This optimization is in place given otherwise on reboot we have to reload the firmware, the opmization saves us about max 1s, minimum 10ms. Cantabile has reported

[PATCH v3 19/20] firmware: add request_firmware_cache() to help with cache on reboot

2018-03-10 Thread Luis R. Rodriguez
Some devices have an optimization in place to enable the firmware to be retaineed during a system reboot, so after reboot the device can skip requesting and loading the firmware. This can save up to 1s in load time. The mt7601u 802.11 device happens to be such a device. When these devices retain

[PATCH v3 13/20] test_firmware: test three firmware kernel configs using a proc knob

2018-03-10 Thread Luis R. Rodriguez
Since we now have knobs to twiddle what used to be set on kernel configurations we can build one base kernel configuration and modify behaviour to mimic such kernel configurations to test them. Provided you build a kernel with: CONFIG_TEST_FIRMWARE=y CONFIG_FW_LOADER=y

[PATCH v3 18/20] firmware: ensure the firmware cache is not used on incompatible calls

2018-03-10 Thread Luis R. Rodriguez
request_firmware_into_buf() explicitly disables the firmware cache, meanwhile the firmware cache cannot be used when request_firmware_nowait() is used without the uevent. Enforce a sanity check for this to avoid future issues undocumented behaviours should misuses of the firmware cache happen

[PATCH v3 12/20] test_firmware: expand on library with shared helpers

2018-03-10 Thread Luis R. Rodriguez
This expands our library with as many things we could find which both scripts we use share. Signed-off-by: Luis R. Rodriguez --- tools/testing/selftests/firmware/fw_fallback.sh | 31 +++--- tools/testing/selftests/firmware/fw_filesystem.sh | 41 +++---

[PATCH] input/touchscreen: atmel_mxt_ts: Add Caroline Chromebook platform data.

2018-03-10 Thread Vittorio Gambaletta (VittGam)
This patch adds the correct platform data information for the Caroline Chromebook, so that the mouse button does not get stuck in pressed state after the first click. The Samus button keymap and platform data definition are the correct ones for Caroline, so they have been reused here.

Re: [PATCH] firmware: add a function to load optional firmware v2

2018-03-10 Thread Luis R. Rodriguez
First, thanks for your patch! On Fri, Mar 9, 2018 at 3:09 PM, Andres Rodriguez wrote: > Currently the firmware loader only exposes one silent path for querying > optional firmware, and that is request_firmware_direct(). This function > also disables the usermodehelper

Re: [PATCH 04/12] staging: iio: tsl2x7x: add common function for writing to the control register

2018-03-10 Thread Jonathan Cameron
On Sat, 3 Mar 2018 20:49:34 -0500 Brian Masney wrote: > There were four places where the same chunk of code was used to write > to the control register. This patch creates a common function > tsl2x7x_write_control_reg() to reduce duplicate code. > > The function

Re: [PATCH v4 3/3 update] mm/free_pcppages_bulk: prefetch buddy while not holding lock

2018-03-10 Thread Aaron Lu
On Fri, Mar 09, 2018 at 01:58:32PM -0800, Andrew Morton wrote: > > > > When a page is freed back to the global pool, its buddy will be checked > > to see if it's possible to do a merge. This requires accessing buddy's > > page structure and that access could take a long time if it's cache cold. >

Re: [PATCH 09/12] staging: iio: tsl2x7x: add missing error checks

2018-03-10 Thread Jonathan Cameron
On Sat, 3 Mar 2018 20:49:39 -0500 Brian Masney wrote: > The functions in_illuminance0_calibrate_store() and > in_illuminance0_lux_table_store() did not have complete error handling > in place. This patch adds the missing error handling. > > Signed-off-by: Brian Masney

Re: [PATCH 4.14 1/4] powerpc/mm/slice: Remove intermediate bitmap copy

2018-03-10 Thread Greg Kroah-Hartman
On Sat, Mar 10, 2018 at 08:27:54AM +0100, christophe leroy wrote: > > > Le 10/03/2018 à 01:10, Greg Kroah-Hartman a écrit : > > On Fri, Mar 09, 2018 at 04:48:59PM +0100, Christophe Leroy wrote: > > > Upstream 326691ad4f179e6edc7eb1271e618dd673e4736d > > > > There is no such git commit id in

Re: [PATCH 10/12] staging: iio: tsl2x7x: make logging consistent and correct newlines

2018-03-10 Thread Jonathan Cameron
On Sat, 3 Mar 2018 20:49:40 -0500 Brian Masney wrote: > This patch updates all of the logging commands so that they are > consistent with the other messages, includes __func__ in the message, > and all of the messages include newlines. > > This patch also removes some

Re: [PATCH] rbd: Remove VLA usage

2018-03-10 Thread Kees Cook
On Fri, Mar 9, 2018 at 9:14 PM, Kyle Spiers wrote: > From 4198ebe2e8058ff676d8e2f993d8806d6ca29c11 Mon Sep 17 00:00:00 2001 > From: Kyle Spiers > Date: Fri, 9 Mar 2018 12:34:15 -0800 > Subject: [PATCH] rbd: Remove VLA usage > > As part of the effort to remove VLAs

Re: [PATCH] vgacon: fix function prototypes

2018-03-10 Thread Kees Cook
On Fri, Mar 9, 2018 at 10:40 PM, Joao Moreira wrote: > It is possible to indirectly invoke functions with prototypes that do not > match those of the respectively used function pointers by using void types. > Despite widely used as a feature for relaxing function invocation,

[PATCH v3] kconfig: make unmet dependency warnings readable

2018-03-10 Thread Masahiro Yamada
Currently, the unmet dependency warnings end up with endlessly long expressions, most of which are false positives. Here is test code to demonstrate how it currently works. [Test Case] config DEP1 def_bool y config DEP2 bool "DEP2" config A bool "A"

[PATCH] tpm: allow TCPA log area to be empty

2018-03-10 Thread Jarkko Sakkinen
TCPA log are can be empty when the TPM is disabled. This commit changes the behavior of tpm_read_log_acpi() to return successfully in this case. Cc: sta...@vger.kernel.org Fixes: 55a82ab3181b ("[PATCH] tpm: add bios measurement log") Signed-off-by: Jarkko Sakkinen

Re: [PATCH] x86/microcode/AMD: check microcode file sanity before loading it

2018-03-10 Thread Maciej S. Szmigiero
On 10.03.2018 01:34, Maciej S. Szmigiero wrote: > Currently, it is very easy to make the AMD microcode update driver crash > or spin on a malformed microcode file since it does very little > consistency checking on data loaded from such file. > > This commit introduces various checks, mostly on

Re: KASAN: use-after-free Read in sctp_association_free (2)

2018-03-10 Thread Xin Long
On Sat, Mar 10, 2018 at 9:13 PM, Neil Horman wrote: > On Sat, Mar 10, 2018 at 03:58:04PM +0800, Xin Long wrote: >> On Sat, Mar 10, 2018 at 6:08 AM, Neil Horman wrote: >> > On Fri, Mar 09, 2018 at 12:59:06PM -0800, syzbot wrote: >> >> Hello, >> >> >>

Re: [PATCH v3] kernel.h: Skip single-eval logic on literals in min()/max()

2018-03-10 Thread Linus Torvalds
On Sat, Mar 10, 2018 at 7:33 AM, Kees Cook wrote: > > Alright, I'm giving up on fixing max(). I'll go back to STACK_MAX() or > some other name for the simple macro. Bleh. Oh, and I'm starting to see the real problem. It's not that our current "min/max()" are broiken. It's

Re: [PATCH] x86/microcode/AMD: check microcode file sanity before loading it

2018-03-10 Thread Borislav Petkov
On Sat, Mar 10, 2018 at 05:16:40PM +0100, Maciej S. Szmigiero wrote: > To make sure that it is clear what this patch is about: I know what you're trying to do but it seems you don't want to listen. So let me try one last time to clear your confusion. > It *isn't* about verifying the actual

Re: KASAN: use-after-free Read in sctp_association_free (2)

2018-03-10 Thread Neil Horman
On Sat, Mar 10, 2018 at 03:58:04PM +0800, Xin Long wrote: > On Sat, Mar 10, 2018 at 6:08 AM, Neil Horman wrote: > > On Fri, Mar 09, 2018 at 12:59:06PM -0800, syzbot wrote: > >> Hello, > >> > >> syzbot hit the following crash on net-next commit > >>

Re: [PATCH 0/8] Move most GPIO documentation to driver-api/gpio/ and ReST

2018-03-10 Thread Jonathan Neuschäfer
On Sat, Mar 10, 2018 at 12:50:46PM +0100, Linus Walleij wrote: > On Fri, Mar 9, 2018 at 12:40 AM, Jonathan Neuschäfer > wrote: > > > The aim of this patchset is to move the GPIO subsystem's documentation > > under Documentation/driver-api/gpio/ such that it is picked up by

[PATCH v3 00/20] firmware: development for v4.17

2018-03-10 Thread Luis R. Rodriguez
Greg, Here's a respin of what I have queued up for v4.17 for the firmware API. It combines the cleanup I've been working on and the addition of the new API call request_firmware_cache() for fixing a corner case suspend issue on some type of cards with an optimization in place where the firmware

[PATCH v3 08/20] firmware: split firmware fallback functionality into its own file

2018-03-10 Thread Luis R. Rodriguez
The firmware fallback code is optional. Split that code out to help distinguish the fallback functionlity from othere core firmware loader features. This should make it easier to maintain and review code changes. The reason for keeping the configuration onto a table which is built-in if you

[PATCH v3 05/20] firmware: simplify CONFIG_FW_LOADER_USER_HELPER_FALLBACK further

2018-03-10 Thread Luis R. Rodriguez
All CONFIG_FW_LOADER_USER_HELPER_FALLBACK really is, is just a bool, initailized at build time. Define it as such. This simplifies the logic even further, removing now all explicit #ifdefs around the code. Acked-by: Kees Cook Signed-off-by: Luis R. Rodriguez

Re: [PATCH v2 2/2] riscv/atomic: Strengthen implementations with fences

2018-03-10 Thread Andrea Parri
On Fri, Mar 09, 2018 at 04:21:37PM -0800, Daniel Lustig wrote: > On 3/9/2018 2:57 PM, Palmer Dabbelt wrote: > > On Fri, 09 Mar 2018 13:30:08 PST (-0800), parri.and...@gmail.com wrote: > >> On Fri, Mar 09, 2018 at 10:54:27AM -0800, Palmer Dabbelt wrote: > >>> On Fri, 09 Mar 2018 10:36:44 PST

Re: [RFC 0/1] Loading optional firmware

2018-03-10 Thread Luis R. Rodriguez
On Fri, Mar 9, 2018 at 2:12 PM, Andres Rodriguez wrote: > Hi Everyone, > > Wanted to inquire your opinions about the following matter. > > We are experiencing some end user confusion regarding the following messages > being printed to dmesg: > > [0.571324] amdgpu

Re: [PATCH 03/12] staging: iio: tsl2x7x: add common function for reading chip status

2018-03-10 Thread Jonathan Cameron
On Sat, 3 Mar 2018 20:49:33 -0500 Brian Masney wrote: > There were three places where the same chunk of code was used to read > the chip status. This patch creates a common function > tsl2x7x_read_status() to reduce duplicate code. This patch also corrects >

Re: [PATCH 06/12] staging: iio: tsl2x7x: correctly return errors in tsl2x7x_get_prox()

2018-03-10 Thread Jonathan Cameron
On Sat, 3 Mar 2018 20:49:36 -0500 Brian Masney wrote: > Not all errors that occurred in tsl2x7x_get_prox() were correctly > reported in the return value. This patch changes the error handling > so that errors are now returned properly. > > Note that the ret variable is

Re: [PATCH 07/12] staging: iio: tsl2x7x: correct 'Avoid CamelCase' warning from checkpatch

2018-03-10 Thread Jonathan Cameron
On Sat, 3 Mar 2018 20:49:37 -0500 Brian Masney wrote: > The statP and calP variables triggered an 'Avoid CamelCase' warning > from checkpatch.pl. This patch renames these variables to stat and cal > to fix this warning. > > Signed-off-by: Brian Masney

Re: [PATCH] firmware: add a function to load optional firmware v2

2018-03-10 Thread Luis R. Rodriguez
On Sat, Mar 10, 2018 at 6:35 AM, Luis R. Rodriguez wrote: > You also I take it have users in > mind? I'd like to see at least one user of the API or this fixing a > reported issue. Ie, if users have reported this as issues incorrectly, > referring to those incorrect posts as

Re: [PATCH 12/12] staging: iio: tsl2x7x: make proximity sensor function correctly

2018-03-10 Thread Jonathan Cameron
On Sat, 3 Mar 2018 20:49:42 -0500 Brian Masney wrote: > The bits for setting up the proximity diode were not setup correctly and > this was causing the proximity sensor to not function correctly. This > patch sets up the correct bit mask in tsl2x7x_chip_on() based on what

Re: [PATCH v5 0/2] add support for Socionext SynQuacer I2C controller

2018-03-10 Thread Ard Biesheuvel
On 2 March 2018 at 08:31, Ard Biesheuvel wrote: > Add a binding and a driver for the I2C IP found in the Socionext SynQuacer > SoC, which is essentially a rebranded version of the Fujitsu F_I2C controller. > > I think this is good to go now. Wolfram? > Ping? > v5: > -

[PATCH 3/5 V3] tpm2: add longer timeouts for creation commands.

2018-03-10 Thread Tomas Winkler
TPM2_CC_Create(0x153) and TPM2_CC_CreatePrimary (0x131) involve generation of crypto keys which can be a computationally intensive task. The timeout is set to 3min. Rather than increasing default timeout a new constant is added, to not stall for too long on regular commands failures.

Re: [PATCH v2] kconfig: make unmet dependency warnings readable

2018-03-10 Thread Masahiro Yamada
Petr, Eugeniu, 2018-03-10 9:07 GMT+09:00 Eugeniu Rosca : > > It looks like expr_get_leftmost_symbol() has no more callers left and > could be removed with this patch? Thanks, I will send v3 with fixes pointed out. -- Best Regards Masahiro Yamada

Re: [PATCH 4.14 0/9] 4.14.26-stable review

2018-03-10 Thread Guenter Roeck
On 03/09/2018 04:19 PM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.14.26 release. There are 9 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: [PATCH v11 8/8] perf: ARM DynamIQ Shared Unit PMU support

2018-03-10 Thread Mark Rutland
On Fri, Mar 09, 2018 at 02:49:00PM -0800, Saravana Kannan wrote: > > > > Looking at the code, I didn't see any specific handling of cluster > > > > power collapse. AFAIK, the HW counters do not retain config (what event > > > > they are counting) or value (the current count) across power collapse.

Re: [PATCH 4.9 00/65] 4.9.87-stable review

2018-03-10 Thread Guenter Roeck
On 03/09/2018 04:18 PM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.9.87 release. There are 65 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: [PATCH 3.18 00/21] 3.18.99-stable review

2018-03-10 Thread Guenter Roeck
On 03/09/2018 04:18 PM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 3.18.99 release. There are 21 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: [PATCH 4.15 00/11] 4.15.9-stable review

2018-03-10 Thread Guenter Roeck
On 03/09/2018 04:19 PM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.15.9 release. There are 11 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: [PATCH v2] Staging: iio: adis16209: Move adis16209 driver out of staging

2018-03-10 Thread Jonathan Cameron
On Sat, 10 Mar 2018 15:50:23 +0530 Shreeya Patel wrote: > Move the adis16209 driver out of staging directory and merge to the > mainline IIO subsystem. > > Signed-off-by: Shreeya Patel As this has a clear dependency on the previous

[GIT PULL rcu/next] RCU commits for 4.17

2018-03-10 Thread Paul E. McKenney
Hello, Ingo! This pull request contains the following changes: 1. Miscellaneous fixes, perhaps most notably removing obsolete code whose only purpose in life was to gather information for the now-removed RCU debugfs facility. Other notable changes include removing

Re: Simplifying our RCU models

2018-03-10 Thread Paul E. McKenney
On Fri, Mar 09, 2018 at 05:48:55PM +0800, Lai Jiangshan wrote: > On Tue, Mar 6, 2018 at 12:14 AM, Paul E. McKenney > wrote: > > On Mon, Mar 05, 2018 at 08:33:20AM -0600, Eric W. Biederman wrote: > >> > >> Moving this discussion to a public list as discussing how to

Re: [PATCH v3] kernel.h: Skip single-eval logic on literals in min()/max()

2018-03-10 Thread Linus Torvalds
On Fri, Mar 9, 2018 at 11:03 PM, Miguel Ojeda wrote: > > Just compiled 4.9.0 and it seems to work -- so that would be the > minimum required. > > Sigh... > > Some enterprise distros are either already shipping gcc >= 5 or will > probably be shipping it soon (e.g.

Re: [PATCH v3] kernel.h: Skip single-eval logic on literals in min()/max()

2018-03-10 Thread Linus Torvalds
On Sat, Mar 10, 2018 at 7:33 AM, Kees Cook wrote: > > And sparse freaks out too: > >drivers/net/ethernet/via/via-velocity.c:97:26: sparse: incorrect > type in initializer (different address spaces) @@expected void > *addr @@got struct mac_regs [noderef]

Re: [PATCH 1/2] hwmon: (ucd9000) Add gpio chip interface

2018-03-10 Thread Guenter Roeck
On 03/09/2018 11:19 AM, Eddie James wrote: From: Christopher Bostic Add a struct gpio_chip and define some methods so that this device's I/O can be accessed via /sys/class/gpio. Signed-off-by: Christopher Bostic Signed-off-by: Andrew

Re: Bug: Microblaze stopped booting after 0fa1c579349fdd90173381712ad78aa99c09d38b

2018-03-10 Thread Michal Simek
On 9.3.2018 20:05, Rob Herring wrote: > On Fri, Mar 9, 2018 at 6:51 AM, Alvaro G. M. wrote: >> Hi, >> >> I've found via git bisect that 0fa1c579349fdd90173381712ad78aa99c09d38b >> makes microblaze unbootable. >> >> I'm sorry I can't provide any console output, as nothing

Re: 4.16-rc3 fails to resume on MacBookPro10,1 -

2018-03-10 Thread Pavel Machek
Hi! > > Ok, I've just tested linux-next, and it works ok for me on thinkpad > > x60. (But that's probably rather different configuration from the > > macbook). > > > > Unfortunately, I could not deduce anything useful from the > > backtraces. Andrew, could you try v4.15 with KPTI disabled ? > > >

[PATCH] arm64: dts: uniphier: use proper SPDX-License-Identifier style

2018-03-10 Thread Masahiro Yamada
According to Documentation/process/license-rules.rst, move the SPDX License Identifier to the very top of the file. I used C++ comment style not only for the SPDX line but for the entire block because this seems Linus' preference [1]. I also dropped the parentheses to follow the examples in that

Re: [PATCH] x86/microcode/AMD: check microcode file sanity before loading it

2018-03-10 Thread Maciej S. Szmigiero
On 10.03.2018 14:12, Borislav Petkov wrote: > On Sat, Mar 10, 2018 at 01:26:00PM +0100, Maciej S. Szmigiero wrote: >> Without them, it is easy to crash the driver when just playing with >> microcode files > > You're not supposed to play with the microcode files. If you do and > something breaks,

Re: [PATCH] scsi: resolve COMMAND_SIZE at compile time

2018-03-10 Thread Stephen Kitt
Hi Bart, On Fri, 9 Mar 2018 22:47:12 +, Bart Van Assche wrote: > On Fri, 2018-03-09 at 23:33 +0100, Stephen Kitt wrote: > > +/* > > + * SCSI command sizes are as follows, in bytes, for fixed size commands, > > per > > + * group: 6, 10, 10, 12, 16, 12, 10, 10. The top

Re: [RFC PATCH -tip 0/9] kprobes: Cleanup jprobe implementation

2018-03-10 Thread Masami Hiramatsu
On Fri, 9 Mar 2018 18:54:02 -0500 Steven Rostedt wrote: > On Fri, 9 Mar 2018 21:35:17 +0900 > Masami Hiramatsu wrote: > > > Hello, > > > > Since we decided to remove jprobe from kernel last year, > > its APIs are disabled and we worked on moving

Re: [PATCH 0/3] module: process aliasing when debugging

2018-03-10 Thread Luis R. Rodriguez
*Poke* Luis On Wed, Nov 29, 2017 at 6:36 PM, Luis R. Rodriguez wrote: > Debugging ineractions with userspace can often be a bit of pain, specially > when trying to figure out who is at fault for an issue. Having the kernel > process aliases when debugging can help us much

[PATCH v3 06/20] firmware: use helpers for setting up a temporary cache timeout

2018-03-10 Thread Luis R. Rodriguez
We only use the timeout for the firmware fallback mechanism except for trying to set the timeout during the cache setup for resume/suspend. For those cases, setting the timeout should be a no-op, so just reflect this in code by adding helpers for it. This change introduces no functional changes.

[PATCH v3 07/20] firmware: move loading timeout under struct firmware_fallback_config

2018-03-10 Thread Luis R. Rodriguez
The timeout is a fallback construct, so we can just stuff the timeout configuration under struct firmware_fallback_config. While at it, add a few helpers which vets the use of getting or setting the timeout as an int. The main use of the timeout is to set a timeout for completion, and that is

[PATCH v3 01/20] test_firmware: add simple firmware firmware test library

2018-03-10 Thread Luis R. Rodriguez
We'll expland on this later, for now just add basic module checker. While at it, move this all to use /bin/bash as we'll have much more flexibility with it. Signed-off-by: Luis R. Rodriguez --- tools/testing/selftests/firmware/fw_fallback.sh | 7 ++--

[PATCH v3 04/20] firmware: enable to split firmware_class into separate target files

2018-03-10 Thread Luis R. Rodriguez
The firmware loader code has grown quite a bit over the years. The practice of stuffing everything we need into one file makes the code hard to follow. In order to split the firmware loader code into different components we must pick a module name and a first object target file. We must keep the

Re: [PATCH 02/12] staging: iio: tsl2x7x: add common function for clearing interrupts

2018-03-10 Thread Jonathan Cameron
On Sat, 3 Mar 2018 20:49:32 -0500 Brian Masney wrote: > There were three places where the same chunk of code was used to clear > interrupts. This patch creates a common function > tsl2x7x_clear_interrupts() to reduce duplicate code. > > Signed-off-by: Brian Masney

Re: [PATCH 05/12] staging: iio: tsl2x7x: convert mutex_trylock() to mutex_lock()

2018-03-10 Thread Jonathan Cameron
On Sat, 3 Mar 2018 20:49:35 -0500 Brian Masney wrote: > The driver uses mutex_lock() and mutex_trylock() in several places. > Convert the mutex_trylock() to mutex_lock() for consistency with other > IIO light drivers in mainline. > > Signed-off-by: Brian Masney

Re: [PATCH 4.15 00/11] 4.15.9-stable review

2018-03-10 Thread Greg Kroah-Hartman
On Fri, Mar 09, 2018 at 10:10:02PM -0700, Shuah Khan wrote: > On 03/09/2018 05:19 PM, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.15.9 release. > > There are 11 patches in this series, all will be posted as a response > > to this one. If anyone has any

Re: [PATCH 11/12] staging: iio: tsl2x7x: remove unnecessary sysfs attribute

2018-03-10 Thread Jonathan Cameron
On Sat, 3 Mar 2018 20:49:41 -0500 Brian Masney wrote: > The tsl2771 and tmd2771 devices create the > in_proximity0_calibscale_available sysfs attribute. These two particular > devices do not support changing the proximity gain value on the > chip so this patch removes

Re: [PATCH 4.14 1/4] powerpc/mm/slice: Remove intermediate bitmap copy

2018-03-10 Thread christophe leroy
Le 10/03/2018 à 15:52, Greg Kroah-Hartman a écrit : On Sat, Mar 10, 2018 at 08:27:54AM +0100, christophe leroy wrote: Le 10/03/2018 à 01:10, Greg Kroah-Hartman a écrit : On Fri, Mar 09, 2018 at 04:48:59PM +0100, Christophe Leroy wrote: Upstream 326691ad4f179e6edc7eb1271e618dd673e4736d

Re: [PATCH 2/2] iio: potentiometer: mcp4018: driver for Microchip digital potentiometers

2018-03-10 Thread Jonathan Cameron
On Thu, 8 Mar 2018 20:58:30 +0100 Peter Rosin wrote: > Add support for Microchip digital potentiometers and rheostats > MCP4017, MCP4018, MCP4019 > > They all have one wiper with 128 steps and come in 5, 10, 50 and 100 kOhm > variations. > > Datasheet:

Re: [PATCH 1/4] staging:iio:ad2s1210: Remove end of line with '['

2018-03-10 Thread Jonathan Cameron
On Fri, 9 Mar 2018 20:45:50 -0300 Rodrigo Siqueira wrote: > This patch fixes the checkpatch.pl check: > > iio/resolver/ad2s1210.c:202: CHECK: Lines should not end with a '[' > > Signed-off-by: Rodrigo Siqueira Applied to the togreg

Re: [PATCH 2/2] hwmon: (ucd9000) Add debugfs attributes to provide mfr_status

2018-03-10 Thread Guenter Roeck
On 03/09/2018 11:19 AM, Eddie James wrote: From: Christopher Bostic Expose the gpiN_fault fields of mfr_status as individual debugfs attributes. This provides a way for users to be easily notified of gpi faults. Also provide the whole mfr_status register in debugfs.

Re: [PATCH v3 3/5] tpm: migrate tpm2_probe() to use struct tpm_buf

2018-03-10 Thread Jarkko Sakkinen
On Thu, 2018-03-08 at 13:47 -0800, J Freyensee wrote: > Looks better :-). > > > Acked-by: Jay Freyensee Thank you. /Jarkko

Re: [PATCH] net/9p: avoid -ERESTARTSYS leak to userspace

2018-03-10 Thread Greg Kurz
Hi Andrew, Thank you very much for taking care of this. Please find my answers to your remarks below. On Fri, 9 Mar 2018 14:12:52 -0800 Andrew Morton wrote: > On Fri, 09 Mar 2018 21:41:38 +0100 Greg Kurz wrote: > > > If it was interrupted by a

Re: [PATCH] x86/microcode/AMD: check microcode file sanity before loading it

2018-03-10 Thread Borislav Petkov
On Sat, Mar 10, 2018 at 01:26:00PM +0100, Maciej S. Szmigiero wrote: > Without them, it is easy to crash the driver when just playing with > microcode files You're not supposed to play with the microcode files. If you do and something breaks, you get to keep the pieces. If the official microcode

Re: [PATCH v4] cpuset: Enable cpuset controller in default hierarchy

2018-03-10 Thread Peter Zijlstra
On Fri, Mar 09, 2018 at 06:06:29PM -0500, Waiman Long wrote: > So you are talking about sched_relax_domain_level and That one I wouldn't be sad to see the back of. > sched_load_balance. This one, that's critical. And this is the perfect time to try and fix the whole isolcpus issue. The primary

[GIT PULL] Kbuild fixes for v4.16-rc5

2018-03-10 Thread Masahiro Yamada
Hi Linus, Please pull more Kbuild fixes for v4.16. The following changes since commit 661e50bc853209e41a5c14a290ca4decc43cbfd1: Linux 4.16-rc4 (2018-03-04 14:54:11 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git

Re: [PATCH v2 1/4] dt-bindings: mfd: Add Gateworks System Controller bindings

2018-03-10 Thread Fabio Estevam
Hi Tim, On Mon, Mar 5, 2018 at 7:02 PM, Tim Harvey wrote: > + > + hwmon@1 { /* A1: Input Voltage */ > + type = <1>; > + reg = <0x02>; Unit address (@1) does not match the 'reg' value. If

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

2018-03-10 Thread Luis R. Rodriguez
On Fri, Mar 09, 2018 at 06:34:18PM -0800, Alexei Starovoitov wrote: > On 3/9/18 11:38 AM, Linus Torvalds wrote: > > On Fri, Mar 9, 2018 at 11:12 AM, Linus Torvalds > > wrote: > > > > > > How are you going to handle five processes doing the same setup > > >

[PATCH v3 17/20] test_firmware: modify custom fallback tests to use unique files

2018-03-10 Thread Luis R. Rodriguez
Users of the custom firmware fallback interface is are not supposed to use the firmware cache interface, this can happen if for instance the one of the APIs which use the firmware cache is used first with one firmware file and then the request_firmware_nowait(uevent=false) API is used with the

[PATCH v3 15/20] firmware: fix checking for return values for fw_add_devm_name()

2018-03-10 Thread Luis R. Rodriguez
Currently fw_add_devm_name() returns 1 if the firmware cache was already set. This makes it complicated for us to check for correctness. It is actually non-fatal if the firmware cache is already setup, so just return 0, and simplify the checkers. fw_add_devm_name() adds device's name onto the

[PATCH v3 14/20] rename: _request_firmware_load() fw_load_sysfs_fallback()

2018-03-10 Thread Luis R. Rodriguez
This reflects much clearer what is being done. While at it, kdoc'ify it. Signed-off-by: Luis R. Rodriguez --- Documentation/driver-api/firmware/fallback-mechanisms.rst | 2 +- drivers/base/firmware_loader/fallback.c | 13 ++--- 2 files changed, 11

[PATCH v3 11/20] firmware: enable to force disable the fallback mechanism at run time

2018-03-10 Thread Luis R. Rodriguez
You currently need four different kernel builds to test the firmware API fully. By adding a proc knob to force disable the fallback mechanism completely we are able to reduce the amount of kernels you need built to test the firmware API down to two. Acked-by: Kees Cook

[PATCH v3 10/20] firmware: enable run time change of forcing fallback loader

2018-03-10 Thread Luis R. Rodriguez
Currently one requires to test four kernel configurations to test the firmware API completely: 0) CONFIG_FW_LOADER=y 1) o CONFIG_FW_LOADER=y o CONFIG_FW_LOADER_USER_HELPER=y 2) o CONFIG_FW_LOADER=y o CONFIG_FW_LOADER_USER_HELPER=y o CONFIG_FW_LOADER_USER_HELPER_FALLBACK=y 3) When

[PATCH v3 16/20] firmware: add helper to check to see if fw cache is setup

2018-03-10 Thread Luis R. Rodriguez
Add a helper to check if the firmware cache is already setup for a device. This will be used later. Signed-off-by: Luis R. Rodriguez --- drivers/base/firmware_loader/main.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git

[PATCH v3 02/20] test_firmware: enable custom fallback testing on limited kernel configs

2018-03-10 Thread Luis R. Rodriguez
When a kernel is not built with: CONFIG_HAS_FW_LOADER_USER_HELPER_FALLBACK=y We don't currently enable testing fw_fallback.sh. For kernels that still enable the fallback mechanism, its possible to use the async request firmware API call request_firmware_nowait() using the custom interface to use

[PATCH v3 03/20] test_firmware: replace syfs fallback check with kconfig_has helper

2018-03-10 Thread Luis R. Rodriguez
Now that we have a kconfig checker just use that instead of relying on testing a sysfs directory being present, since our requirements are spelled out. Acked-by: Kees Cook Signed-off-by: Luis R. Rodriguez ---

Re: [PATCH 01/12] staging: iio: tsl2x7x: remove power functions from tsl2X7X_platform_data

2018-03-10 Thread Jonathan Cameron
On Sat, 3 Mar 2018 20:49:31 -0500 Brian Masney wrote: > The tsl2X7X_platform_data structure contains the platform_power, > power_on, and power_off function pointers. These power management > functions should not be in the platform data. These functions were > likely used

Re: [PATCH 08/12] staging: iio: tsl2x7x: add error handling to tsl2x7x_prox_cal()

2018-03-10 Thread Jonathan Cameron
On Sat, 3 Mar 2018 20:49:38 -0500 Brian Masney wrote: > tsl2x7x_prox_cal() did not have any error checks. This patch adds > the missing error handling and ensures that any errors are reported to > user space via in_proximity0_calibrate_store(). > > Signed-off-by: Brian

Re: [PATCH] iio: potentiometer: ds1803: Remove VLA usage

2018-03-10 Thread Jonathan Cameron
On Fri, 9 Mar 2018 16:35:10 +0530 Himanshu Jha wrote: > On Thu, Mar 08, 2018 at 11:39:15AM -0800, Kees Cook wrote: > > On Thu, Mar 8, 2018 at 10:45 AM, Himanshu Jha > > wrote: > > > In preparation to enabling -Wvla, remove VLA usage

Re: [PATCH 10/11] Staging: iio: accel: Add comments about units in data read function

2018-03-10 Thread Jonathan Cameron
On Thu, 8 Mar 2018 12:58:19 +0530 Himanshu Jha wrote: > On Wed, Mar 07, 2018 at 08:50:30PM +, Jonathan Cameron wrote: > > On Mon, 5 Mar 2018 13:19:29 +0530 > > Himanshu Jha wrote: > > > > > Clarify the conversion and formation of

Re: [PATCH v2 1/3] staging:iio:meter: Replaces IIO_DEV_ATTR_CH_OFF by IIO_DEVICE_ATTR

2018-03-10 Thread Jonathan Cameron
On Thu, 8 Mar 2018 21:37:33 -0300 Rodrigo Siqueira wrote: > On 03/07, Jonathan Cameron wrote: > > On Tue, 6 Mar 2018 21:43:47 -0300 > > Rodrigo Siqueira wrote: > > > > > The macro IIO_DEV_ATTR_CH_OFF is a wrapper for

Re: [PATCH v3] kernel.h: Skip single-eval logic on literals in min()/max()

2018-03-10 Thread Kees Cook
On Fri, Mar 9, 2018 at 10:10 PM, Miguel Ojeda wrote: > On Sat, Mar 10, 2018 at 4:11 AM, Randy Dunlap wrote: >> On 03/09/2018 04:07 PM, Andrew Morton wrote: >>> On Fri, 9 Mar 2018 12:05:36 -0800 Kees Cook wrote: >>>

  1   2   3   4   >