Re: [PATCH v6] drivers/staging: Gasket driver framework + Apex driver

2018-06-29 Thread kbuild test robot
Hi Simon, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.18-rc2 next-20180629] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

Re: [PATCH v4 2/2] eeprom: at24: Add support for address-width property

2018-06-29 Thread Andy Shevchenko
On Fri, 2018-06-29 at 15:21 +0800, alanx.chi...@intel.com wrote: > From: Alan Chiang > > Provide a flexible way to determine the addressing bits of eeprom. > Pass the addressing bits to driver through address-width property. > Reviewed-by: Andy Shevchenko > Signed-off-by: Alan Chiang >

Re: [PATCH 00/17] thermal: enable/check sensor after its setup is finished

2018-06-29 Thread Bartlomiej Zolnierkiewicz
On Tuesday, April 10, 2018 02:41:54 PM Bartlomiej Zolnierkiewicz wrote: > Hi, > > [devm]_thermal_zone_of_sensor_register() is used to register > thermal sensor by thermal drivers using DeviceTree. Besides > registering sensor this function also immediately enables it > (using ->set_mode method)

[PATCH] ACPI/PPTT: use ACPI ID whenever ACPI_PPTT_ACPI_PROCESSOR_ID_VALID is set

2018-06-29 Thread Sudeep Holla
Currently we use the ACPI processor ID only for the leaf/processor nodes as the specification states it must match the value of ACPI processor ID field in the processor’s entry in the MADT. However, if a PPTT structure represents processors group, it match a processor container UID in the

Re: [PATCH 2/2] perf test shell: make perf inet_pton test more portable

2018-06-29 Thread Kim Phillips
On Thu, 28 Jun 2018 22:36:36 +0200 Michael Petlan wrote: > On Thu, 21 Jun 2018, Arnaldo Carvalho de Melo wrote: > > Em Thu, Jun 21, 2018 at 11:19:15AM -0300, Arnaldo Carvalho de Melo escreveu: > >> Em Wed, Jun 20, 2018 at 07:45:46PM -0500, Kim Phillips escreveu: > >>> On Wed, 20 Jun 2018

Re: [PATCH v2 1/4] x86/split_lock: Enumerate #AC exception for split locked access feature

2018-06-29 Thread Thomas Gleixner
On Fri, 29 Jun 2018, Dave Hansen wrote: > On 06/29/2018 07:33 AM, Fenghua Yu wrote: > > +/* Detect feature of #AC for split lock by probing bit 29 in MSR_TEST_CTL. > > */ > > +void detect_ac_split_lock(void) > > +{ > > + u64 val, orig_val; > > + int ret; > > + > > + /* Attempt to read the

Re: [PATCH v3 3/5] KVM: x86: hyperv: use get_vcpu_by_vpidx() in kvm_hv_flush_tlb()

2018-06-29 Thread Roman Kagan
On Fri, Jun 29, 2018 at 05:21:47PM +0200, Vitaly Kuznetsov wrote: > Roman Kagan writes: > > > On Fri, Jun 29, 2018 at 04:14:53PM +0200, Vitaly Kuznetsov wrote: > >> VP_INDEX almost always matches VCPU id and get_vcpu_by_vpidx() is fast, > >> use it instead of traversing full vCPU list every

Re: [PATCH v2 3/4] x86/split_lock: Handle #AC exception for split lock

2018-06-29 Thread Dave Hansen
> +/* > + * #AC handler for split lock is called by generic #AC handler. > + * > + * On split lock in kernel, warn and disable #AC for split lock on current > CPU. > + * > + * On split lock in user process, send SIGBUS in the generic #AC handler. > + */ Don't comment the function, comment the

Re: [PATCH v2 4/4] x86/split_lock: Disable #AC for split locked accesses

2018-06-29 Thread Dave Hansen
On 06/29/2018 07:33 AM, Fenghua Yu wrote: > + ac_split_lock_off [X86] > + Disable #AC exception for split locked accesses. > + By default, this feature is enabled in kernel. FWIW, I detest the "ac_" nomenclature this patch spreads around. It's

Re: [PATCH v2 1/4] x86/split_lock: Enumerate #AC exception for split locked access feature

2018-06-29 Thread Dave Hansen
On 06/29/2018 09:23 AM, Thomas Gleixner wrote: > And pretty please, can we either stick that stuff into cpu/intel.c or if it > really needs a separate file avoid that horrible test_ctl.c file name? Fenghua, I also asked for this earlier. It would be really awesome if you could go through and

RE: [PATCH v2 3/4] x86/split_lock: Handle #AC exception for split lock

2018-06-29 Thread Luck, Tony
>> +WARN_ONCE(1, "A split lock issue is detected. Please FIX it\n"); > > But, warning here is also not super useful. Shouldn't we be dumping out > the info in 'regs' instead of the current context? We don't care about > the state in the #AC handler, we care about 'regs'. Maybe:

Re: [PATCH] arc/Kconfig: include mm/Kconfig inside "ARC system configuration"

2018-06-29 Thread Randy Dunlap
On 06/29/2018 06:42 AM, Mike Rapoport wrote: > Otherwise mm configuration options show up in the top level menu. > > Signed-off-by: Mike Rapoport Hi Mike, In which config tool does this matter? For xconfig, it seems to me that this patch hides the MM menu, whereas before this patch, the MM

Re: [PATCH v2 2/4] x86/split_lock: Align x86_capability to unsigned long to avoid split locked access

2018-06-29 Thread Thomas Gleixner
On Fri, 29 Jun 2018, Dave Hansen wrote: > On 06/29/2018 07:33 AM, Fenghua Yu wrote: > > --- a/arch/x86/include/asm/processor.h > > +++ b/arch/x86/include/asm/processor.h > > @@ -105,7 +105,8 @@ struct cpuinfo_x86 { > > __u32 extended_cpuid_level; > > /* Maximum supported

Re: [PATCH 2/7] x86,tlb: leave lazy TLB mode at page table free time

2018-06-29 Thread Dave Hansen
On 06/29/2018 07:29 AM, Rik van Riel wrote: > The latter problem can be prevented in two ways. The first is to > always send a TLB shootdown IPI to CPUs in lazy TLB mode, while > the second one is to only send the TLB shootdown at page table > freeing time. I've read this a few times, and I keep

RE: [PATCH v2] platform/x86: intel-hid: Add support for Device Specific Methods

2018-06-29 Thread Mario.Limonciello
> -Original Message- > From: Srinivas Pandruvada [mailto:srinivas.pandruv...@linux.intel.com] > Sent: Thursday, June 28, 2018 1:19 PM > To: alex.h...@canonical.com; dvh...@infradead.org; a...@infradead.org > Cc: platform-driver-...@vger.kernel.org; linux-kernel@vger.kernel.org; >

Re: [PATCH v2] uart: fix race between uart_put_char() and uart_shutdown()

2018-06-29 Thread Tycho Andersen
On Fri, Jun 29, 2018 at 04:24:46AM -0600, Tycho Andersen wrote: > v2: switch to locking uport->lock on allocation/deallocation instead of > locking the per-port mutex in uart_put_char. Note that since > uport->lock is a spin lock, we have to switch the allocation to > GFP_ATOMIC.

Re: [RFC v2 PATCH 2/2] mm: mmap: zap pages with read mmap_sem for large mapping

2018-06-29 Thread Yang Shi
On 6/29/18 4:34 AM, Michal Hocko wrote: On Thu 28-06-18 12:10:10, Yang Shi wrote: On 6/28/18 4:51 AM, Michal Hocko wrote: On Wed 27-06-18 10:23:39, Yang Shi wrote: On 6/27/18 12:24 AM, Michal Hocko wrote: On Tue 26-06-18 18:03:34, Yang Shi wrote: On 6/26/18 12:43 AM, Peter Zijlstra

Re: [PATCH v3 3/5] KVM: x86: hyperv: use get_vcpu_by_vpidx() in kvm_hv_flush_tlb()

2018-06-29 Thread Vitaly Kuznetsov
Roman Kagan writes: > On Fri, Jun 29, 2018 at 05:21:47PM +0200, Vitaly Kuznetsov wrote: >> Roman Kagan writes: >> >> > On Fri, Jun 29, 2018 at 04:14:53PM +0200, Vitaly Kuznetsov wrote: >> >> VP_INDEX almost always matches VCPU id and get_vcpu_by_vpidx() is fast, >> >> use it instead of

Re: [PATCH v2] kvm, mm: account shadow page tables to kmemcg

2018-06-29 Thread Shakeel Butt
On Fri, Jun 29, 2018 at 7:55 AM Michal Hocko wrote: > > On Fri 29-06-18 16:40:23, Paolo Bonzini wrote: > > On 29/06/2018 16:30, Michal Hocko wrote: > > > I am not familiar wtih kvm to judge but if we are going to account this > > > memory we will probably want to let oom_badness know how much

[PATCH v2] kernel/memremap, kasan: Make ZONE_DEVICE with work with KASAN

2018-06-29 Thread Andrey Ryabinin
KASAN learns about hot added memory via the memory hotplug notifier. The devm_memremap_pages() intentionally skips calling memory hotplug notifiers. So KASAN doesn't know anything about new memory added by devm_memremap_pages(). This causes to crash when KASAN tries to access non-existent shadow

Re: [PATCH] arm64: acpi: reenumerate topology ids

2018-06-29 Thread Jeremy Linton
Hi, On 06/29/2018 10:46 AM, Andrew Jones wrote: On Fri, Jun 29, 2018 at 02:29:34PM +0100, Sudeep Holla wrote: If it matters a lot, vendors must use UID for consistency. Since OS doesn't use those IDs for any particular reason, OS must not care. That depends. If you look at how

Re: [RFC v2 PATCH 2/2] mm: mmap: zap pages with read mmap_sem for large mapping

2018-06-29 Thread Yang Shi
On 6/29/18 4:39 AM, Michal Hocko wrote: On Thu 28-06-18 17:59:25, Yang Shi wrote: On 6/28/18 12:10 PM, Yang Shi wrote: On 6/28/18 4:51 AM, Michal Hocko wrote: On Wed 27-06-18 10:23:39, Yang Shi wrote: On 6/27/18 12:24 AM, Michal Hocko wrote: On Tue 26-06-18 18:03:34, Yang Shi wrote:

Re: [PATCH 3/7] x86,mm: restructure switch_mm_irqs_off

2018-06-29 Thread Dave Hansen
On 06/29/2018 07:29 AM, Rik van Riel wrote: > Move some code that will be needed for the lazy -> !lazy state > transition when a lazy TLB CPU has gotten out of date. > > No functional changes, since the if (real_prev == next) branch > always returns. The lower indentation looks nice. Acked-by:

Re: [PATCH v3 3/5] KVM: x86: hyperv: use get_vcpu_by_vpidx() in kvm_hv_flush_tlb()

2018-06-29 Thread Roman Kagan
On Fri, Jun 29, 2018 at 07:26:36PM +0300, Roman Kagan wrote: > On Fri, Jun 29, 2018 at 05:21:47PM +0200, Vitaly Kuznetsov wrote: > > Roman Kagan writes: > > > > > On Fri, Jun 29, 2018 at 04:14:53PM +0200, Vitaly Kuznetsov wrote: > > >> VP_INDEX almost always matches VCPU id and

Re: [PATCH v2 3/4] RISC-V: Add definiion of extract symbol's index and type for 32-bit

2018-06-29 Thread Zong Li
Christoph Hellwig 於 2018年6月29日 週五 下午3:12寫道: > > On Mon, Jun 25, 2018 at 04:49:39PM +0800, Zong Li wrote: > > Use generic marco to get the index and type of symbol. > > Why do we even need this in a uapi header? Shouldn't ELF_RISCV_R_SYM > and ELF_RISCV_R_TYPE move to module.c? In that case we

Re: [PATCH 2/7] x86,tlb: leave lazy TLB mode at page table free time

2018-06-29 Thread Rik van Riel
On Fri, 2018-06-29 at 09:39 -0700, Dave Hansen wrote: > On 06/29/2018 07:29 AM, Rik van Riel wrote: > > The latter problem can be prevented in two ways. The first is to > > always send a TLB shootdown IPI to CPUs in lazy TLB mode, while > > the second one is to only send the TLB shootdown at page

Re: [RFC PATCH for 4.18 1/2] rseq: validate rseq_cs fields are < TASK_SIZE

2018-06-29 Thread Linus Torvalds
On Fri, Jun 29, 2018 at 9:07 AM Mathieu Desnoyers wrote: > > This code is not invoked from syscalls, but rather on return from > interrupt/trap after a preemption. But when we register the rseq, we could easily check that the top bits of the IP is clear, no? Sure, user space can change it after

Re: [PATCH v9 1/6] arm: arm64: introduce CONFIG_HAVE_MEMBLOCK_PFN_VALID

2018-06-29 Thread Pavel Tatashin
On Thu, Jun 28, 2018 at 10:30 PM Jia He wrote: > > Make CONFIG_HAVE_MEMBLOCK_PFN_VALID a new config option so it can move > memblock_next_valid_pfn to generic code file. All the latter optimizations > are based on this config. > > The memblock initialization time on arm/arm64 can benefit from

Re: [PATCH V2 3/4] clk: imx6sx: remove clks_init_on array

2018-06-29 Thread Stephen Boyd
Quoting Anson Huang (2018-06-03 18:06:45) > Clock framework will enable those clocks registered > with CLK_IS_CRITICAL flag, so no need to have > clks_init_on array during clock initialization now. > > ARM clock is busy divider type which has the > CLK_IS_CRITICAL flag set by default when

Re: [PATCH V2 1/2] clk: imx6ul: add GPIO clock gates

2018-06-29 Thread Stephen Boyd
Quoting Anson Huang (2018-06-02 18:44:04) > i.MX6UL has GPIO clock gates in CCM CCGR, > add them into clock tree for clock management. > > Signed-off-by: Anson Huang > --- Applied to clk-next

Re: [PATCH V2 1/4] clk: imx6q: remove clks_init_on array

2018-06-29 Thread Stephen Boyd
Quoting Anson Huang (2018-06-03 18:06:43) > Clock framework will enable those clocks registered > with CLK_IS_CRITICAL flag, so no need to have > clks_init_on array during clock initialization now. > > ARM clock is busy divider type which has the > CLK_IS_CRITICAL flag set by default when

[PATCH] mm/fadvise: Fix signed overflow UBSAN complaint

2018-06-29 Thread Andrey Ryabinin
Signed integer overflow is undefined according to the C standard. The overflow in ksys_fadvise64_64() is deliberate, but since it is signed overflow, UBSAN complains: UBSAN: Undefined behaviour in mm/fadvise.c:76:10 signed integer overflow: 4 + 9223372036854775805 cannot be

[PATCH v1 3/6] x86/tsc: Add missed header to tsc_msr.c

2018-06-29 Thread Andy Shevchenko
Add a missed header otherwise compiler warns about missed prototype: CC arch/x86/kernel/tsc_msr.o arch/x86/kernel/tsc_msr.c:73:15: warning: no previous prototype for ‘cpu_khz_from_msr’ [-Wmissing-prototypes] unsigned long cpu_khz_from_msr(void) ^~~~

[PATCH v1 2/6] x86/tsc: Convert to use x86_match_cpu() and INTEL_CPU_FAM6()

2018-06-29 Thread Andy Shevchenko
Move the code to use recently introduced INTEL_CPU_FAM6() macro and drop custom version of x86_match_cpu() function. No functional change intended. Signed-off-by: Andy Shevchenko --- arch/x86/kernel/tsc_msr.c | 83 --- 1 file changed, 42 insertions(+), 41

Re: config files and how to have persistent Linux kernel Driver/File System configuration info saved

2018-06-29 Thread Steve French
On Thu, Jun 28, 2018 at 11:44 PM Dave Chinner wrote: > > On Thu, Jun 28, 2018 at 06:24:59PM -0500, Steve French wrote: > > On Thu, Jun 28, 2018 at 6:21 PM ronnie sahlberg > > wrote: > > > > > > On Fri, Jun 29, 2018 at 8:58 AM, Theodore Y. Ts'o via samba-technical > > > wrote: > > > > On Thu,

Re: [PATCH] arm64: Clear the stack

2018-06-29 Thread Kees Cook
On Fri, Jun 29, 2018 at 1:22 PM, Laura Abbott wrote: > On 06/29/2018 01:19 PM, Kees Cook wrote: >> >> On Fri, Jun 29, 2018 at 12:05 PM, Laura Abbott wrote: >>> >>> Implementation of stackleak based heavily on the x86 version >>> >>> Signed-off-by: Laura Abbott >>> [...] >>> +#define

[PATCH v2] stop_machine: Disable preemption when waking two stopper threads

2018-06-29 Thread Isaac J. Manjarres
When cpu_stop_queue_two_works() begins to wake the stopper threads, it does so without preemption disabled, which leads to the following race condition: The source CPU calls cpu_stop_queue_two_works(), with cpu1 as the source CPU, and cpu2 as the destination CPU. When adding the stopper threads

[PATCH v6 21/21] s390: doc: detailed specifications for AP virtualization

2018-06-29 Thread Tony Krowiak
This patch provides documentation describing the AP architecture and design concepts behind the virtualization of AP devices. It also includes an example of how to configure AP devices for exclusive use of KVM guests. Signed-off-by: Tony Krowiak --- Documentation/s390/vfio-ap.txt | 575

[PATCH v6 13/21] s390: vfio-ap: sysfs interface to view matrix mdev matrix

2018-06-29 Thread Tony Krowiak
Provides a sysfs interface to view the AP matrix configured for the mediated matrix device. The relevant sysfs structures are: /sys/devices/vfio_ap ... [matrix] .. [mdev_supported_types] . [vfio_ap-passthrough] [devices] ...[$uuid] .. matrix

[PATCH v6 16/21] s390: vfio-ap: sysfs interface to view guest matrix

2018-06-29 Thread Tony Krowiak
From: Tony Krowiak Provides a sysfs interface to view the AP matrix configured for the guest that is using the mdev matrix device. The relevant sysfs structures are: /sys/devices/vfio_ap ... [matrix] .. [mdev_supported_types] . [vfio_ap-passthrough] [devices]

Re: [PATCH v2 2/4] x86/split_lock: Align x86_capability to unsigned long to avoid split locked access

2018-06-29 Thread Fenghua Yu
On Fri, Jun 29, 2018 at 01:48:45PM -0700, Dave Hansen wrote: > On 06/29/2018 01:38 PM, Fenghua Yu wrote: > > How to handle data that is used in generic code which can be used on > > non-Intel platform? For exmple, if I do this change for struct efi in > > include/linux/efi.h because set_bit() sets

[PATCH v6 03/21] s390/zcrypt: Show load of cards and queues in sysfs

2018-06-29 Thread Tony Krowiak
From: Harald Freudenberger Show the current load value of cards and queues in sysfs. The load value for each card and queue is maintained by the zcrypt device driver for dispatching and load balancing requests over the available devices. This patch provides the load value to userspace via a new

[PATCH v6 05/21] KVM: s390: CPU model support for AP virtualization

2018-06-29 Thread Tony Krowiak
Introduces a new CPU model feature and two CPU model facilities to support AP virtualization for KVM guests. CPU model feature: The KVM_S390_VM_CPU_FEAT_AP feature indicates that AP instructions are available on the guest. This feature will be enabled by the kernel only if the AP instructions

Re: [PATCH v3 0/4] Add devicetree functionality to w1 busses and ds2760

2018-06-29 Thread Daniel Mack
On Friday, June 29, 2018 07:31 PM, Daniel Mack wrote: This patch set contains four small patches that bring devicetree functionality to w1 bus masters and slaves in general. As an example, the DS2760 driver is made aware of devicetree nodes as an example. Other drivers can easily be ported

Re: [PATCH v5 4/4] mm/sparse: Optimize memmap allocation during sparse_init()

2018-06-29 Thread Pavel Tatashin
> > + * increase 'nr_consumed_maps' whether its allocation of memmap > > + * or usemap failed or not, so that after we handle the i-th > > + * memory section, can get memmap and usemap of (i+1)-th section > > + * correctly. */ > > This makes no sense to me. Why are we

Re: [PATCH v12 09/11] x86/tsc: prepare for early sched_clock

2018-06-29 Thread Andy Shevchenko
On Fri, 2018-06-29 at 17:30 +0300, Andy Shevchenko wrote: > On Thu, 2018-06-28 at 12:43 +0200, Thomas Gleixner wrote: > > On Thu, 28 Jun 2018, Thomas Gleixner wrote: > > > > Taking above into consideration, I think we may just remove the legacy > code from mfld.c and mrfld.c and see what happen.

Re: [PATCH] tpm: require to compile as part of the kernel

2018-06-29 Thread Jason Gunthorpe
On Fri, Jun 29, 2018 at 08:43:28PM +0300, Jarkko Sakkinen wrote: > On Fri, Jun 29, 2018 at 09:31:41AM -0600, Jason Gunthorpe wrote: > > On Fri, Jun 29, 2018 at 06:10:02PM +0300, Jarkko Sakkinen wrote: > > > Do not allow to compile TPM core as a module. TPM defines a root of > > > trust for

[PATCH 2/3] staging: rtl8192u Remove redundant #include directive

2018-06-29 Thread John Whitmore
The file includes the file rtl819x_HT.h, which has already been included by the previously included file ieee80211.h Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] clk: imx6: fix video_27m parent for IMX6QDL_CLK_CKO1_SEL

2018-06-29 Thread Stephen Boyd
Quoting Philipp Puschmann (2018-06-08 03:19:24) > q/dl datasheets list the 5th selection value for ck01_sel as > video_27M_clk_root. > > By replacing the dummy value we then can set IMX6QDL_CLK_VIDEO_27M > as parent for IMX6QDL_CLK_CKO1_SEL. > > Signed-off-by: Philipp Puschmann > --- Applied

[PATCH] video: fbdev: fsl-diu-fb: Remove VLA usage

2018-06-29 Thread Kees Cook
In the quest to remove all stack VLA usage from the kernel[1], this moves the buffer off the stack (since it could be as much as 1024 bytes), and uses a new area in the cursor data structure. Additionally adds missed documentation and removes redundant assignments. [1]

[PATCH v1 6/6] x86/platform/intel-mid: Remove per platform code

2018-06-29 Thread Andy Shevchenko
After custom TSC calibration gone, there is no more reason to have custom platform code for each of Intel MID. Thus, remove it for good. Signed-off-by: Andy Shevchenko --- arch/x86/include/asm/intel-mid.h | 29 arch/x86/platform/intel-mid/Makefile | 2 +-

[PATCH v1 5/6] x86/platform/intel-mid: Remove custom TSC calibration

2018-06-29 Thread Andy Shevchenko
Since the commit 7da7c1561366 ("x86, tsc: Add static (MSR) TSC calibration on Intel Atom SoCs") introduced a common way for all Intel MID chips to get their TSC frequency via MSRs, there is no need to keep a duplication in each of Intel MID platform code. Thus, remove the custom calibration

[PATCH v1 0/6] x86/tsc: Clean up legacy code for Intel MID

2018-06-29 Thread Andy Shevchenko
As Thomas noticed there is unusual initialization is going on on Intel MID platforms when TSC is being calibrated. It appears that we have tsc_msr.c to support Intel MID in a more generic way. So, this patch series removes legacy calibration code and does accompanying clean ups. Has been tested

[PATCH v1 1/6] x86/cpu: Introduce INTEL_CPU_FAM*() helper macros

2018-06-29 Thread Andy Shevchenko
These macros are often used by drivers and we have already a lot of duplication as ICPU() macro across the drivers. Provide a generic x86 macro for users. Note, as Ingo Molnar pointed out this has a hidden issue when a driver needs to preserve const qualifier. Though, it would be addressed

[PATCHv3 0/4] nvme trace updates

2018-06-29 Thread Keith Busch
This patch series is based on/inspired by Johannes Thumshirn that improves the nvme trace events. The first one from Sagi is saving the nvme_ctrl in the driver request data so we can reference it in other places, both for this series and future developments. The others are adding and simplifying

[PATCHv3 2/4] nvme: use hw qid in trace events

2018-06-29 Thread Keith Busch
We can not match a command to its completion based on the command id alone. We need the submitting queue identifier to pair with the completion, so this patch adds that to the trace buffer. This patch is also collapsing the admin and IO submission traces into a single one so we don't need to

[PATCHv3 4/4] nvme: add disk name to trace events

2018-06-29 Thread Keith Busch
This will print the disk name to the nvme event trace for io requests so a user can better distinguish traffic to different disks. This can be used to create disk based filters. For example, to see only nvme0n2 traffic: echo "disk == \"nvme0n2\"" > /sys/kernel/debug/tracing/events/nvme/filter

Re: [PATCH] mmc: core: cd_label must be last entry of mmc_gpio struct

2018-06-29 Thread Fabio Estevam
Hi Anson, On Thu, Jun 28, 2018 at 10:35 PM, Anson Huang wrote: > commit bfd694d5e21c ("mmc: core: Add tunable delay > before detecting card after card is inserted") adds > "u32 cd_debounce_delay_ms" to the last of mmc_gpio > struct and cause "char cd_label[0]" NOT work as string > pointer of

[PATCHv3 3/4] nvme: add controller name to trace events

2018-06-29 Thread Keith Busch
This appends the controller instance to the nvme trace buffer to distinguish which controller is dispatching and completing a command. Signed-off-by: Keith Busch --- drivers/nvme/host/trace.h | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git

Re: [PATCH] mm: make DEFERRED_STRUCT_PAGE_INIT explicitly depend on SPARSEMEM

2018-06-29 Thread Randy Dunlap
On 06/29/2018 06:35 AM, Mike Rapoport wrote: > The deferred memory initialization relies on section definitions, e.g > PAGES_PER_SECTION, that are only available when CONFIG_SPARSEMEM=y on most > architectures. > > Initially DEFERRED_STRUCT_PAGE_INIT depended on explicit >

Re: [PATCH] lib/string.c: fix a typo in comment: 'iff' -->'if'

2018-06-29 Thread Andy Shevchenko
On Fri, Jun 29, 2018 at 6:30 PM, David Laight wrote: > From: YueHaibing >> Sent: 29 June 2018 04:45 >> >> On 2018/6/29 11:35, Randy Dunlap wrote: >> > On 06/28/2018 08:33 PM, YueHaibing wrote: >> >> Signed-off-by: YueHaibing >> >> --- >> >> lib/string.c | 2 +- >> >> 1 file changed, 1

Re: [PATCHv3 2/4] nvme: use hw qid in trace events

2018-06-29 Thread Keith Busch
On Fri, Jun 29, 2018 at 01:59:58PM -0600, Keith Busch wrote: > + TP_printk("qid=%d, cmdid=%u, nsid=%u, flags=0x%x, meta=0x%llx, > cmd=(%s %s)", > + __entry->qid, __entry->nsid, __entry->cid, Ugh, the nsid and cid are swapped here, and carried through to the end of the

Re: [RFC PATCH for 4.18 1/2] rseq: validate rseq_cs fields are < TASK_SIZE

2018-06-29 Thread Andy Lutomirski
On Fri, Jun 29, 2018 at 12:48 PM, Mathieu Desnoyers wrote: > There are two aspects I'm concerned about here: > > 1) security: we don't want 32-bit user-space to feed a 64-bit value over 4GB >as abort_ip that may end up causing OOPSes on architectures that would >lack proper validation of

Re: [PATCH/RFC] mm: do not drop unused pages when userfaultd is running

2018-06-29 Thread Mike Rapoport
On Fri, Jun 29, 2018 at 08:51:23AM +0200, Christian Borntraeger wrote: > > > On 06/28/2018 02:39 PM, Christian Borntraeger wrote: > > KVM guests on s390 can notify the host of unused pages. This can result > > in pte_unused callbacks to be true for KVM guest memory. > > > > If a page is unused

[PATCH v6 14/21] s390: vfio-ap: implement mediated device open callback

2018-06-29 Thread Tony Krowiak
Implements the open callback on the mediated matrix device. The function registers a group notifier to receive notification of the VFIO_GROUP_NOTIFY_SET_KVM event. When notified, the vfio_ap device driver will get access to the guest's kvm structure. The open callback must ensure that only one

[PATCH v6 08/21] s390: vfio-ap: register matrix device with VFIO mdev framework

2018-06-29 Thread Tony Krowiak
Registers the matrix device created by the VFIO AP device driver with the VFIO mediated device framework. Registering the matrix device will create the sysfs structures needed to create mediated matrix devices each of which will be used to configure the AP matrix for a guest and connect it to the

Re: [PATCH] arm64: acpi: reenumerate topology ids

2018-06-29 Thread Andrew Jones
On Fri, Jun 29, 2018 at 11:48:15AM -0500, Jeremy Linton wrote: > Just to be clear, there isn't anything (AFAIK) in the ACPI specification > which dictates what values should comprise the various ACPI id's. They are > assumed only to be machine readable, which is why it seems some > implementations

Re: [PATCH v9 2/6] mm: page_alloc: remain memblock_next_valid_pfn() on arm/arm64

2018-06-29 Thread Pavel Tatashin
On Thu, Jun 28, 2018 at 10:30 PM Jia He wrote: > > Commit b92df1de5d28 ("mm: page_alloc: skip over regions of invalid pfns > where possible") optimized the loop in memmap_init_zone(). But it causes > possible panic bug. So Daniel Vacek reverted it later. > > But as suggested by Daniel Vacek, it

[GIT PULL] arm64 fixes for 4.18-rc3

2018-06-29 Thread Catalin Marinas
Hi Linus, Please pull the arm64 fixes below. Thanks. The following changes since commit 7daf201d7fe8334e2d2364d4e8ed3394ec9af819: Linux 4.18-rc2 (2018-06-24 20:54:29 +0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux tags/arm64-fixes

[PATCH v2 1/4] perf test shell: Replace '|&' with '2>&1 |' to work with more shells

2018-06-29 Thread Kim Phillips
Since we do not specify bash (and/or zsh) as a requirement, use the standard error redirection that is more widely supported. BEFORE: $ sudo ./perf test -v 62 62: Check open filename arg using perf trace + vfs_getname: --- start --- test child forked, pid 27305

[PATCH v2 2/4] perf test shell: make perf inet_pton test more portable

2018-06-29 Thread Kim Phillips
Debian based systems such as Ubuntu have dash as their default shell. Even if the normal or root user's shell is bash, certain scripts still call /bin/sh, which points to dash, so we fix this perf test by rewriting it in a more portable way. BEFORE: $ sudo ./perf test -v 64 64: probe libc's

[PATCH v2 3/4] perf llvm-utils: remove bashism from kernel include fetch script

2018-06-29 Thread Kim Phillips
Like system(), popen() calls /bin/sh, which may/may not be bash. Script when run on dash and encounters the line, yields: exit: Illegal number: -1 checkbashisms report on script content: possible bashism (exit|return with negative status code): exit -1 Remove the bashism and use the more

[PATCH v2 4/4] perf test shell: prevent temporary editor files from being considered test scripts

2018-06-29 Thread Kim Phillips
Allows a perf shell test developer to concurrently edit and run their test scripts, avoiding perf test attempts to execute their editor temporary files, such as seen here: $ sudo taskset -c 0 ./perf test - -F 63 63: 0VIM 8.0 : --- start ---

[PATCH 3/3] staging: rtl8192u: Prune the rtl819x_HT.h file of unused definitions.

2018-06-29 Thread John Whitmore
There are two files named "rtl819x_HT.h" $ find . -name rtl819x_HT.h -print ./drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h ./drivers/staging/rtl8192e/rtl819x_HT.h The two files are very similar but differ slightly. Unsed definitions have been removed from

[PATCH 1/3] staging: rtl8192u: Use __func__ instead of hardcoded string - Style

2018-06-29 Thread John Whitmore
Chnaged logging statements to use %s and __func__ instead of hard coding the function name in a string. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

staging: rtl8192u: RFC - harmonisation of rtl819x_HT.h ?

2018-06-29 Thread John Whitmore
This patch set includes two fairly trivial patches but the third patch is possibly controversial. There are two files called rtl819x_HT.h $ find -name rtl819x_HT.h -print ./drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h ./drivers/staging/rtl8192e/rtl819x_HT.h The two files are very similar but

Re: [PATCH] tpm: require to compile as part of the kernel

2018-06-29 Thread Jason Gunthorpe
On Fri, Jun 29, 2018 at 08:47:43PM +0300, Jarkko Sakkinen wrote: > On Fri, Jun 29, 2018 at 09:31:41AM -0600, Jason Gunthorpe wrote: > > > -#if defined(CONFIG_TCG_TPM) || defined(CONFIG_TCG_TPM_MODULE) > > > - > > > +#if defined(CONFIG_TCG_TPM) > > > > Huh. This new version is certainly right > >

Re: [PATCH] ACPI/PPTT: use ACPI ID whenever ACPI_PPTT_ACPI_PROCESSOR_ID_VALID is set

2018-06-29 Thread Jeremy Linton
Hi, On 06/29/2018 11:17 AM, Sudeep Holla wrote: Currently we use the ACPI processor ID only for the leaf/processor nodes as the specification states it must match the value of ACPI processor ID field in the processor’s entry in the MADT. However, if a PPTT structure represents processors

Re: [RFC PATCH] sched/deadline: sched_getattr() returns absolute dl-task information

2018-06-29 Thread Joel Fernandes
On Fri, Jun 29, 2018 at 02:09:47PM +0200, Alessio Balsini wrote: > If the task calls sched_getattr() with SCHED_GETATTR_FLAGS_DL_ABSOLUTE > flag set, the returned runtime and deadline parameters are, accordingly, > the remaining runtime and the absolute deadline. > > To return consistent data,

[PATCH] firmware: raspberrypi: Remove VLA usage

2018-06-29 Thread Kees Cook
In the quest to remove all stack VLA usage from the kernel[1], this removes the VLA in favor of a maximum size and adds a sanity check. Existing callers of the firmware interface never need more than 24 bytes (struct gpio_set_config). This chooses 32 just to stay ahead of future growth. [1]

Re: [PATCH V2 2/4] clk: imx6sl: remove clks_init_on array

2018-06-29 Thread Stephen Boyd
Quoting Anson Huang (2018-06-03 18:06:44) > Clock framework will enable those clocks registered > with CLK_IS_CRITICAL flag, so no need to have > clks_init_on array during clock initialization now. > > ARM clock is busy divider type which has the > CLK_IS_CRITICAL flag set by default when

Re: [PATCH V2 4/4] clk: imx6ul: remove clks_init_on array

2018-06-29 Thread Stephen Boyd
Quoting Anson Huang (2018-06-03 18:06:46) > Clock framework will enable those clocks registered > with CLK_IS_CRITICAL flag, so no need to have > clks_init_on array during clock initialization now. > > ARM clock is busy divider type which has the > CLK_IS_CRITICAL flag set by default when

Re: [PATCH v2 1/4] perf test shell: Replace '|&' with '2>&1 |' to work with more shells

2018-06-29 Thread Arnaldo Carvalho de Melo
Em Fri, Jun 29, 2018 at 12:46:33PM -0500, Kim Phillips escreveu: > Since we do not specify bash (and/or zsh) as a requirement, use the > standard error redirection that is more widely supported. Thanks, applied the 4 patches, - Arnaldo

[PATCH] staging: rtl8188eu: remove unnecessary parentheses

2018-06-29 Thread Michael Straube
Remove unnecessary parentheses as reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 22 ++-- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c

Re: [PATCH] memcg, oom: move out_of_memory back to the charge path

2018-06-29 Thread Greg Thelen
Michal Hocko wrote: > On Thu 28-06-18 16:19:07, Greg Thelen wrote: >> Michal Hocko wrote: > [...] >> > + if (mem_cgroup_out_of_memory(memcg, mask, order)) >> > + return OOM_SUCCESS; >> > + >> > + WARN(1,"Memory cgroup charge failed because of no reclaimable memory! " >> > +

[PATCH] arm64: Clear the stack

2018-06-29 Thread Laura Abbott
Implementation of stackleak based heavily on the x86 version Signed-off-by: Laura Abbott --- Changes since last time: - Minor name change in entry.S - Converted to use the generic interfaces so there's minimal additions. - Added the fast syscall path. - Addition of on_thread_stack and

[PATCH] ext4: Check superblock mapped prior to committing

2018-06-29 Thread Jon Derrick
This patch attempts to close a hole leading to a BUG seen with hot removals during writes [1]. A block device (NVME namespace in this test case) is formatted to EXT4 without partitions. It's mounted and write I/O is run to a file, then the device is hot removed from the slot. The superblock

[PATCHv3 1/4] nvme: cache struct nvme_ctrl reference to struct nvme_request

2018-06-29 Thread Keith Busch
From: Sagi Grimberg We will need to reference the controller in the setup and completion time for tracing and future traffic based keep alive support. Reviewed-by: Johannes Thumshirn Signed-off-by: Sagi Grimberg --- drivers/nvme/host/fc.c | 1 + drivers/nvme/host/nvme.h | 1 +

Re: [PATCH] security: CONFIG_HARDENED_USERCOPY does not need to select BUG

2018-06-29 Thread Kees Cook
On Fri, Jun 29, 2018 at 1:04 PM, Kamal Mostafa wrote: > Allows for CONFIG_HARDENED_USERCOPY without CONFIG_BUG. > > Signed-off-by: Kamal Mostafa > --- > security/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/security/Kconfig b/security/Kconfig > index c430206..7667774 100644 >

[PATCH v1 1/2] PCI: Document patch submission hints

2018-06-29 Thread Bjorn Helgaas
From: Bjorn Helgaas Add hints about how to write PCI patches and changelogs. Signed-off-by: Bjorn Helgaas --- Documentation/PCI/00-INDEX |2 Documentation/PCI/submitting-patches.txt | 153 ++ 2 files changed, 155 insertions(+) create mode

Re: [PATCH] arc/Kconfig: include mm/Kconfig inside "ARC system configuration"

2018-06-29 Thread Mike Rapoport
On Fri, Jun 29, 2018 at 01:28:59PM -0700, Randy Dunlap wrote: > On 06/29/2018 12:28 PM, Mike Rapoport wrote: > > Hi Randy, > > > > On Fri, Jun 29, 2018 at 09:34:55AM -0700, Randy Dunlap wrote: > >> On 06/29/2018 06:42 AM, Mike Rapoport wrote: > >>> Otherwise mm configuration options show up in

[RFC PATCH v1 1/2] interconnect: qcom: Add sdm845 interconnect provider driver

2018-06-29 Thread David Dai
Introduce Qualcomm SDM845 specific provider driver using the interconnect framework. Change-Id: I716b39068b4a211b8203b2a52d3037a5b84594ea Signed-off-by: David Dai --- .../bindings/interconnect/qcom-sdm845.txt | 22 + drivers/interconnect/qcom/Kconfig | 8 +

[RFC PATCH v1 2/2] arm64: dts: sdm845: Add interconnect provider DT nodes

2018-06-29 Thread David Dai
Add RSC(Resource State Coordinator) provider dictating network-on-chip interconnect bus performance found on SDM845-based platforms. Change-Id: I58f0bfc3ed484d7b45064dceb94dcfda507e9333 Signed-off-by: David Dai --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 5 + 1 file changed, 5 insertions(+)

[RFC PATCH v1 0/2] Add QCOM SDM845 interconnect provider driver

2018-06-29 Thread David Dai
Hi, This patch series adds a driver and DT binding using the interconnect (ICC) framework [1] to describe the Qualcomm SDM845 platform's topology of its interconnected buses and internal aggregation nodes known as Bus Clock Managers(BCM). The SDM845 ICC provider driver would aggregate and satisfy

Re: [PATCH v2 1/3] arm64: dts: actions: Enable clock controller for S700

2018-06-29 Thread Andreas Färber
Am 29.06.2018 um 19:36 schrieb Stephen Boyd: > Quoting Saravanan Sekar (2018-06-28 12:18:03) >> diff --git a/arch/arm64/boot/dts/actions/s700-cubieboard7.dts >> b/arch/arm64/boot/dts/actions/s700-cubieboard7.dts >> index ef79d7905f44..28f3f4a0f7f0 100644 >> ---

Re: [PATCH v2 0/3] Add clock driver for Actions S700 SoC

2018-06-29 Thread Stephen Boyd
Quoting Saravanan Sekar (2018-06-28 12:18:02) > Changelog v2: > Fixed 0 day compilation warning > Modified existing dts Actions S900 clock bindings common to Actions > Soc family > > This patchset adds clock support for Actions Semi OWL series S700 SoC > with relevant clock bindings and device

Re: [PATCH] tpm: require to compile as part of the kernel

2018-06-29 Thread Jarkko Sakkinen
On Fri, Jun 29, 2018 at 09:31:41AM -0600, Jason Gunthorpe wrote: > > -#if defined(CONFIG_TCG_TPM) || defined(CONFIG_TCG_TPM_MODULE) > > - > > +#if defined(CONFIG_TCG_TPM) > > Huh. This new version is certainly right Hmm... If the option is kept as tristate, shouldn't this be actually: #if

Re: [PATCH v2 3/4] x86/split_lock: Handle #AC exception for split lock

2018-06-29 Thread Dave Hansen
On 06/29/2018 10:39 AM, Fenghua Yu wrote: > On Fri, Jun 29, 2018 at 10:29:08AM -0700, Dave Hansen wrote: >> On 06/29/2018 10:16 AM, Fenghua Yu wrote: >>> On Fri, Jun 29, 2018 at 09:33:54AM -0700, Luck, Tony wrote: >> +WARN_ONCE(1, "A split lock issue is detected. Please FIX it\n");

Re: [PATCH 1/2] iio: light: Add support for vishay vcnl4035

2018-06-29 Thread Jonathan Cameron
On Thu, 28 Jun 2018 14:30:20 +0200 Parthiban Nallathambi wrote: > Add support for VCNL4035, which is capable of Ambient light > sensing (ALS) and proximity function. This patch adds support > only for ALS function > > Signed-off-by: Parthiban Nallathambi Hi, Looks fairly clean in general,

Re: [PATCH v3 0/8] gnss: add new GNSS subsystem

2018-06-29 Thread Greg Kroah-Hartman
On Fri, Jun 29, 2018 at 11:46:07AM +0200, Pavel Machek wrote: > > > > Finally, note that documentation (including kerneldoc) remains to be > > > written, but hopefully this will not hinder review given that the > > > current interfaces are fairly self-describing. > > > > This all looks great.

  1   2   3   4   5   6   7   8   9   10   >