Re: [PATCH 24/32] vfs: syscall: Add fsopen() to prepare for superblock creation [ver #9]

2018-07-12 Thread Greg KH
On Thu, Jul 12, 2018 at 06:20:24PM +0100, Al Viro wrote: > On Thu, Jul 12, 2018 at 07:15:05PM +0200, Greg KH wrote: > > On Tue, Jul 10, 2018 at 11:44:09PM +0100, David Howells wrote: > > > Provide an fsopen() system call that starts the process of preparing to > > > create a superblock that will

Re: [PATCH v4] uart: fix race between uart_put_char() and uart_shutdown()

2018-07-12 Thread Tycho Andersen
On Thu, Jul 12, 2018 at 05:40:15PM +0200, Greg Kroah-Hartman wrote: > On Thu, Jul 12, 2018 at 09:08:22AM -0600, Tycho Andersen wrote: > > On Thu, Jul 12, 2018 at 05:04:38PM +0200, Greg Kroah-Hartman wrote: > > > On Wed, Jul 11, 2018 at 10:07:44AM -0600, Tycho Andersen wrote: > > > > + if

[PATCH 2/2] timekeeping: Update multiplier when NTP frequency is set directly

2018-07-12 Thread John Stultz
From: Miroslav Lichvar When the NTP frequency is set directly from userspace using the ADJ_FREQUENCY or ADJ_TICK timex mode, immediately update the timekeeper's multiplier instead of waiting for the next tick. This removes a hidden non-deterministic delay in setting of the frequency and allows

[PATCH 1/2] selftest: timers: Tweak raw_skew to SKIP when ADJ_OFFSET/other clock adjustments are in progress

2018-07-12 Thread John Stultz
In the past we've warned when ADJ_OFFSET was in progress, usually caused by ntpd or some other time adjusting daemon running in non steady sate, which can cause the skew calculations to be incorrect. Thus, this patch checks to see if the clock was being adjusted when we fail so that we don't

Re: [PATCH v4 11/14] treewide: Prepare to remove VLA usage for AHASH_REQUEST_ON_STACK

2018-07-12 Thread Kees Cook
On Thu, Jul 12, 2018 at 9:02 AM, Arnd Bergmann wrote: > On Wed, Jul 11, 2018 at 10:36 PM, Kees Cook wrote: >> Several uses of AHASH_REQUEST_ON_STACK() will trigger FRAME_WARN warnings >> (when less than 2048) once the VLA is no longer hidden from the check: >> >>

[GIT PULL][PATCH 0/2] Few timekeeping items for 4.19

2018-07-12 Thread John Stultz
Hey Thomas, I had a few other items in my stack here, but you've already queued them in -tip, so here's what I have left. Let me know if you have any objections or feedback for change. thanks -john Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Miroslav Lichvar Cc: Richard Cochran Cc: Prarit

Re: [RESEND PATCH] mmc: tegra: enable ddr_signaling for MMC_TIMING_MMC_DDR52

2018-07-12 Thread Marcel Ziswiler
On Thu, 2018-07-12 at 19:38 +0200, Tamás Szűcs wrote: > This fixes sampling errors with eMMC modules using DDR52 when host > capabilities > via setting NVQUIRK_ENABLE_DDR50 and NVQUIRK_ENABLE_SDHCI_SPEC_300 > are enabled. > > Signed-off-by: Tamás Szűcs > --- > drivers/mmc/host/sdhci-tegra.c | 2

Re: [PATCH v2] tools/memory-model: Add extra ordering for locks and remove it for ordinary release/acquire

2018-07-12 Thread Alan Stern
On Thu, 12 Jul 2018, Andrea Parri wrote: > > It seems reasonable to ask people to learn that locks have stronger > > ordering guarantees than RMW atomics do. Maybe not the greatest > > situation in the world, but one I think we could live with. > > Yeah, this was one of my main objections.

Re: [PATCH 6/6] coresight: etm-perf: Add support for ETR backend

2018-07-12 Thread Mathieu Poirier
Hi Suzuki, On Wed, Jul 11, 2018 at 03:16:39PM +0100, Suzuki K Poulose wrote: > Add support for using TMC-ETR as backend for ETM perf tracing. > We use software double buffering at the moment. i.e, the TMC-ETR > uses a separate buffer than the perf ring buffer. The data is > copied to the perf

Re: [PATCH 24/32] vfs: syscall: Add fsopen() to prepare for superblock creation [ver #9]

2018-07-12 Thread David Howells
Linus Torvalds wrote: > The unix semantics are that credentials are checked at open time. Sigh. The problem is that there's more than one actual "open" involved. fd = fsopen("ext4");<--- #1 whatever_interface(fd, "s /dev/sda1");

Re: [PATCH 24/32] vfs: syscall: Add fsopen() to prepare for superblock creation [ver #9]

2018-07-12 Thread Linus Torvalds
On Thu, Jul 12, 2018 at 2:26 PM David Howells wrote: > > The problem is that there's more than one actual "open" involved. No. The problem is "write()". This is not about open, about fsopen, or about anything at all. This is about the fact that "write()" by definition can happen in a different

Re: [PATCH v3 1/2] leds: core: Introduce generic pattern interface

2018-07-12 Thread Jacek Anaszewski
Hi Baolin, On 07/12/2018 02:24 PM, Baolin Wang wrote: Hi Jacek, On 12 July 2018 at 05:10, Jacek Anaszewski wrote: Hi Baolin. On 07/11/2018 01:02 PM, Baolin Wang wrote: Hi Jacek and Pavel, On 29 June 2018 at 13:03, Baolin Wang wrote: From: Bjorn Andersson Some LED controllers have

Re: [PATCH] rtc: test: make array pdev static

2018-07-12 Thread Alexandre Belloni
On 24/06/2018 11:38:03+0100, Colin King wrote: > From: Colin Ian King > > The array pdev is local to the source and does not need to be in > global scope, so make it static. > > Cleans up sparse warning: > symbol 'pdev' was not declared. Should it be static? > > Signed-off-by: Colin Ian King

Re: [PATCH 24/32] vfs: syscall: Add fsopen() to prepare for superblock creation [ver #9]

2018-07-12 Thread Al Viro
On Thu, Jul 12, 2018 at 11:30:32AM -0700, Andy Lutomirski wrote: Andi, Greg - alt.tasteless is over -> that way. And for fsck sake, fix your MUA. Lines are obscenely long... > How do you mount configfs in the first place? And how do you use this in a > mount namespace without a private

Re: [PATCH 24/32] vfs: syscall: Add fsopen() to prepare for superblock creation [ver #9]

2018-07-12 Thread Al Viro
On Thu, Jul 12, 2018 at 07:34:26PM +0100, Al Viro wrote: > On Thu, Jul 12, 2018 at 11:30:32AM -0700, Andy Lutomirski wrote: > > Andi, Apologies for misspelling - finger macros strike ;-/

[tip:timers/core] hrtimer: Improve kernel message printing

2018-07-12 Thread tip-bot for Geert Uytterhoeven
Commit-ID: 7a6e55375d5c584c7c11cfdcaa8ad9d6cccb419d Gitweb: https://git.kernel.org/tip/7a6e55375d5c584c7c11cfdcaa8ad9d6cccb419d Author: Geert Uytterhoeven AuthorDate: Thu, 12 Jul 2018 16:41:18 +0200 Committer: Thomas Gleixner CommitDate: Thu, 12 Jul 2018 21:29:30 +0200 hrtimer:

[PATCH 3/4] staging: gasket: fix multi line comments style

2018-07-12 Thread Felix Siegel
This patch fixes checkpatch.pl warnings: WARNING: Block comments should align the * on each line Signed-off-by: Felix Siegel --- drivers/staging/gasket/gasket_core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gasket/gasket_core.c

[PATCH 2/4] staging: gasket: Move open-curly brace to match kernel code style

2018-07-12 Thread Felix Siegel
Move open open-curly brace to the next line following function definition to match the kernel's coding style Signed-off-by: Felix Siegel --- drivers/staging/gasket/gasket_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/gasket/gasket_core.c

Re: [PATCH 1/4] staging: gasket: add SPDX-License-Identifier tag

2018-07-12 Thread Greg Kroah-Hartman
On Thu, Jul 12, 2018 at 09:27:12PM +0200, Felix Siegel wrote: > Use GPL-2.0 based on the license text in each of the files. > Remove license "boiler-plate". > > Signed-off-by: Felix Siegel I sent this same patch 1 1/2 days ago :) sorry, greg k-h

[PATCH] x86: vdso: Fix leaky vdso link with CC=clang

2018-07-12 Thread Alistair Strachan
The vdso{32,64}.so can fail to link with CC=clang when clang tries to find a suitable GCC toolchain to link these libraries with. /usr/bin/ld: arch/x86/entry/vdso/vclock_gettime.o: access beyond end of merged section (782) This happens because the host environment leaked into the cross

Re: [PATCH v9 4/7] tracepoint: Make rcuidle tracepoint callers use SRCU

2018-07-12 Thread Joel Fernandes
On Thu, Jul 12, 2018 at 1:15 PM, Steven Rostedt wrote: > On Thu, 12 Jul 2018 12:17:01 -0700 >> So then, we should use the regular variant for this additional check you're >> suggesting. > > OK, I thought we had a rcu_dereference_notrace() that did checks and > thought that this followed suit, but

Re: [PATCH 1/4] staging: gasket: add SPDX-License-Identifier tag

2018-07-12 Thread Felix Siegel
On Thu, 12 Jul 2018 21:42:49 +0200 Greg Kroah-Hartman wrote: > On Thu, Jul 12, 2018 at 09:27:12PM +0200, Felix Siegel wrote: > > Use GPL-2.0 based on the license text in each of the files. > > Remove license "boiler-plate". > > > > Signed-off-by: Felix Siegel > > I sent this same patch 1 1/2

Re: [PATCH 24/32] vfs: syscall: Add fsopen() to prepare for superblock creation [ver #9]

2018-07-12 Thread Linus Torvalds
On Thu, Jul 12, 2018 at 1:34 PM Linus Torvalds wrote: > > This is the whole "write() is only for data". If you ever have > credentials mattering at write time, you're doing something wrong. > > Really really. > > Don't do it. .. and I'd like to repeat: we *have* done things wrong. But that's

Re: [PATCH 1/2] lib: Add module for testing preemptoff/irqsoff latency tracers

2018-07-12 Thread Steven Rostedt
On Tue, 10 Jul 2018 23:35:39 -0700 Joel Fernandes wrote: > > Co-developed-by: Erick Reyes A co-developer needs to add their signed off by. To specify that Erick is a co-author, you could do: [ Erick is a co-developer of this commit ] Signed-off-by: Add Erick's SOB here. > Cc: Andy

[patch -mm] mm, oom: remove oom_lock from exit_mmap

2018-07-12 Thread David Rientjes
oom_lock isn't needed for __oom_reap_task_mm(). If MMF_UNSTABLE is already set for the mm, we can simply back out immediately since oom reaping is already in progress (or done). Signed-off-by: David Rientjes --- mm/mmap.c | 2 -- mm/oom_kill.c | 6 -- 2 files changed, 4

Re: [v2,3/3] i2c: at91: added slave mode support

2018-07-12 Thread Wolfram Sang
On Tue, Jul 10, 2018 at 10:42:57AM +0200, Ludovic Desroches wrote: > On Mon, Jul 09, 2018 at 05:51:36PM +0200, Wolfram Sang wrote: > > > > > Sorry for having not catched it. If I remember well, it was the only > > > issue I had while testing the slave support. > > > > > > > > > > > BTW maybe I

Re: [PATCH 24/32] vfs: syscall: Add fsopen() to prepare for superblock creation [ver #9]

2018-07-12 Thread Andy Lutomirski
> On Jul 12, 2018, at 9:58 AM, Al Viro wrote: > >> On Thu, Jul 12, 2018 at 09:23:22AM -0700, Andy Lutomirski wrote: >> >> As a straw man, I suggest: >> >> fsconfigure(contextfd, ADD_BLOCKDEV, dfd, path, flags); >> >> fsconfigure(contextfd, ADD_OPTION, 0, “foo=bar”, flags); > > Bollocks.

[PATCH 2/2] selftest/ftrace: Move kprobe selftest function to separate compile unit

2018-07-12 Thread Francis Deslauriers
Move selftest function to its own compile unit so it can be compiled with the ftrace cflags (CC_FLAGS_FTRACE) allowing it to be probed during the ftrace startup tests. Signed-off-by: Francis Deslauriers Acked-by: Masami Hiramatsu --- kernel/trace/Makefile| 5 +

[PATCH 0/2] tracing: kprobes: Prohibit probing on notrace functions

2018-07-12 Thread Francis Deslauriers
Kprobe code has a mecanism protecting against triggering kprobe during the handling of an event. If a kprobe is placed between the kprobe handling entry point and the activation of this protection, the user can cause an infinite kprobe recursion leading to a kernel crash. To avoid this, prevent

Re: [PATCH 24/32] vfs: syscall: Add fsopen() to prepare for superblock creation [ver #9]

2018-07-12 Thread Linus Torvalds
On Thu, Jul 12, 2018 at 10:44 AM Al Viro wrote: > > Separating type name from everything else makes a lot of sense I do not dispute that at all. But you can specify the type name in the "commit" phase, it doesn't have to be at "fsopen" time. In fact, doing so would _force_ a certain

[tip:x86/cache] x86/intel_rdt: Fix possible circular lock dependency

2018-07-12 Thread tip-bot for Reinette Chatre
Commit-ID: 2989360d9c6669d8ae64edc933088e640481b48b Gitweb: https://git.kernel.org/tip/2989360d9c6669d8ae64edc933088e640481b48b Author: Reinette Chatre AuthorDate: Wed, 11 Jul 2018 13:06:07 -0700 Committer: Thomas Gleixner CommitDate: Thu, 12 Jul 2018 21:33:43 +0200 x86/intel_rdt: Fix

[tip:timers/core] ktime: Provide typesafe ktime_to_ns()

2018-07-12 Thread tip-bot for Eric Dumazet
Commit-ID: a8802d97e73346bc81609df9dfba7d3306f40d87 Gitweb: https://git.kernel.org/tip/a8802d97e73346bc81609df9dfba7d3306f40d87 Author: Eric Dumazet AuthorDate: Wed, 11 Jul 2018 11:16:41 -0700 Committer: Thomas Gleixner CommitDate: Thu, 12 Jul 2018 21:35:28 +0200 ktime: Provide

Re: [PATCH 4/4] staging: gasket: Use __func__ instead of hardcoded string - Style

2018-07-12 Thread Greg Kroah-Hartman
On Thu, Jul 12, 2018 at 09:27:15PM +0200, Felix Siegel wrote: > Changed logging statements to use %s and __func__ instead of hard coding > the function name in a string. > > Signed-off-by: Felix Siegel > --- > drivers/staging/gasket/apex_driver.c | 15 --- >

Re: [PATCH v2] tools/memory-model: Add extra ordering for locks and remove it for ordinary release/acquire

2018-07-12 Thread Andrea Parri
On Thu, Jul 12, 2018 at 11:10:58AM -0700, Linus Torvalds wrote: > On Thu, Jul 12, 2018 at 11:05 AM Peter Zijlstra wrote: > > > > The locking pattern is fairly simple and shows where RCpc comes apart > > from expectation real nice. > > So who does RCpc right now for the unlock-lock sequence?

Need Immediate Funds for project funding/Loan/finance. Get it Now @ just 2.75% !!!

2018-07-12 Thread Coutts & Co
Coutts & Co Ltd 440 Strand, London, WC2R 0QS Website: https://www.coutts.com Telephone:+4420 3389 7785 & +4420 7753 1000 Fax:+44 872 110 3479 OUR REF: Coutts/UK/2018/LOANAPP YOUR REF:LOANAPPT/Coutts/JULY/2018 TO WHOM IT MAY CONCERN We give out both Local/International Loan starting from 2.75%*

Re: [PATCH 09/10] psi: cgroup support

2018-07-12 Thread Tejun Heo
On Thu, Jul 12, 2018 at 01:29:41PM -0400, Johannes Weiner wrote: > On a system that executes multiple cgrouped jobs and independent > workloads, we don't just care about the health of the overall system, > but also that of individual jobs, so that we can ensure individual job > health, fairness

Re: [PATCH 03/39] x86/entry/32: Load task stack from x86_tss.sp1 in SYSENTER handler

2018-07-12 Thread Andy Lutomirski
> On Jul 11, 2018, at 4:29 AM, Joerg Roedel wrote: > > From: Joerg Roedel > We want x86_tss.sp0 point to the entry stack later to use > it as a trampoline stack for other kernel entry points > besides SYSENTER. Makes sense: sp0 will be the entry stack. But: > > >/* Offset from the

[PATCH] of: overlay: update phandle cache on overlay apply and remove

2018-07-12 Thread frowand . list
From: Frank Rowand A comment in the review of the patch adding the phandle cache said that the cache would have to be updated when modules are applied and removed. This patch implements the cache updates. Fixes: 0b3ce78e90fc ("of: cache phandle nodes to reduce cost of

Re: [PATCH 24/32] vfs: syscall: Add fsopen() to prepare for superblock creation [ver #9]

2018-07-12 Thread David Howells
Andy Lutomirski wrote: > fsconfigure(contextfd, ADD_BLOCKDEV, dfd, path, flags); > > fsconfigure(contextfd, ADD_OPTION, 0, “foo=bar”, flags); That seems okayish. I'm not sure we need the flags, but I do want to allow for binary data in an option. So perhaps something like: int

Re: [PATCH 1/2] lib: Add module for testing preemptoff/irqsoff latency tracers

2018-07-12 Thread Joel Fernandes
On Thu, Jul 12, 2018 at 05:22:32PM -0400, Steven Rostedt wrote: > On Tue, 10 Jul 2018 23:35:39 -0700 > Joel Fernandes wrote: > > > > > Co-developed-by: Erick Reyes > > A co-developer needs to add their signed off by. To specify that Erick > is a co-author, you could do: > > [ Erick is a

Re: [PATCH v9 1/5] clocksource/drivers/timer-mediatek: Add system timer bindings

2018-07-12 Thread Rob Herring
On Tue, Jul 10, 2018 at 9:02 AM Daniel Lezcano wrote: > > > Rob ? Are you fine with this change ? Yes, I added my R-by on Fri. Rob

Re: [PATCH v9 4/7] tracepoint: Make rcuidle tracepoint callers use SRCU

2018-07-12 Thread Joel Fernandes
On Thu, Jul 12, 2018 at 09:35:12AM -0400, Steven Rostedt wrote: > On Wed, 11 Jul 2018 21:28:25 -0700 > Joel Fernandes wrote: > > > On Wed, Jul 11, 2018 at 11:21:20PM -0400, Steven Rostedt wrote: > > > On Wed, 11 Jul 2018 13:52:49 -0700 > > > Joel Fernandes wrote: > > > > > > > > #define

Re: [PATCH] rtc: m48t59: remove redundant pointer 'name'

2018-07-12 Thread Alexandre Belloni
On 11/07/2018 09:33:12+0100, Colin King wrote: > From: Colin Ian King > > Pointer 'name' is being assigned but is never used hence it is redundant > and can be removed. > > Cleans up clang warning: > warning: variable 'name' set but not used [-Wunused-but-set-variable] > > Signed-off-by: Colin

Re: waitqueue lockdep annotation V3

2018-07-12 Thread Davidlohr Bueso
On Thu, 14 Dec 2017, Christoph Hellwig wrote: Hi all, this series adds a strategic lockdep_assert_held to __wake_up_common to ensure callers really do hold the wait_queue_head lock when calling the unlocked wake_up variants. It turns out epoll did not do this for a fairly common path (hit all

[PATCH 4/4] staging: gasket: Use __func__ instead of hardcoded string - Style

2018-07-12 Thread Felix Siegel
Changed logging statements to use %s and __func__ instead of hard coding the function name in a string. Signed-off-by: Felix Siegel --- drivers/staging/gasket/apex_driver.c | 15 --- drivers/staging/gasket/gasket_core.c | 11 ++-

Re: [PATCH 3/4] staging: gasket: fix multi line comments style

2018-07-12 Thread Greg Kroah-Hartman
On Thu, Jul 12, 2018 at 09:27:14PM +0200, Felix Siegel wrote: > This patch fixes checkpatch.pl warnings: > > WARNING: Block comments should align the * on each line > Signed-off-by: Felix Siegel So close, I need a blank line before the signed-of-by line :( I'll go edit it by hand, but be more

Re: [PATCH] pinctrl: msm: Pass along set_wake failures

2018-07-12 Thread Lina Iyer
On Thu, Jul 12 2018 at 10:31 -0600, Evan Green wrote: On Tue, Jul 10, 2018 at 1:38 PM Lina Iyer wrote: On Tue, Jul 10 2018 at 12:53 -0600, Evan Green wrote: >On Mon, Jul 9, 2018 at 10:27 AM Bjorn Andersson > wrote: >Our understanding is the downstream kernel had an interrupt hierarchy >of GIC

Re: [PATCH 0/3] ata: ahci_platform: minor fixes

2018-07-12 Thread Tejun Heo
On Thu, Jul 12, 2018 at 11:41:28AM +, Corentin Labbe wrote: > Hello > > This patchset fixes some minor problem found when working on supporting > allwinner R40 AHCI. > > Regards > > Corentin Labbe (3): > ata: ahci_platform: correct parameter documentation for > ahci_platform_shutdown

Re: [PATCH v2] tools/memory-model: Add extra ordering for locks and remove it for ordinary release/acquire

2018-07-12 Thread Andrea Parri
On Thu, Jul 12, 2018 at 04:43:46PM -0400, Alan Stern wrote: > On Thu, 12 Jul 2018, Andrea Parri wrote: > > > > It seems reasonable to ask people to learn that locks have stronger > > > ordering guarantees than RMW atomics do. Maybe not the greatest > > > situation in the world, but one I think

[PATCH v2 2/2] pinctrl: nuvoton: add NPCM7xx pinctrl and GPIO driver

2018-07-12 Thread Tomer Maimon
Add Nuvoton BMC NPCM750/730/715/705 Pinmux and GPIO controller driver. Signed-off-by: Tomer Maimon --- drivers/pinctrl/Kconfig |1 + drivers/pinctrl/Makefile |1 + drivers/pinctrl/nuvoton/Kconfig | 12 + drivers/pinctrl/nuvoton/Makefile

[PATCH v2 1/2] dt-binding: pinctrl: Add NPCM7xx pinctrl and GPIO documentation

2018-07-12 Thread Tomer Maimon
Added device tree binding documentation for Nuvoton BMC NPCM750/730/715/705 pinmux and GPIO controller. Signed-off-by: Tomer Maimon --- .../bindings/pinctrl/nuvoton,npcm7xx-pinctrl.txt | 216 + 1 file changed, 216 insertions(+) create mode 100644

[PATCH v2 0/2] pinctrl: nuvoton: add driver for NPCM7xx

2018-07-12 Thread Tomer Maimon
This patch set adds pinmux and GPIO controller for the Nuvoton NPCM750/730/715/705 Baseboard Management Controller (BMC). The Nuvoton BMC NPCM750/730/715/705 Pinmux functions accessible only for pin groups and pinconf parameters available only for individual pins. The Nuvoton BMC

[PATCH 1/2] tracing: kprobes: Prohibit probing on notrace functions

2018-07-12 Thread Francis Deslauriers
From: Masami Hiramatsu Prohibit kprobe-events probing on notrace function. Since probing on the notrace function can cause recursive event call. In most case those are just skipped, but in some case it falls into infinite recursive call. Signed-off-by: Masami Hiramatsu Tested-by: Francis

Re: [PATCH v2] tools/memory-model: Add extra ordering for locks and remove it for ordinary release/acquire

2018-07-12 Thread Peter Zijlstra
On Thu, Jul 12, 2018 at 10:28:38AM -0700, Paul E. McKenney wrote: > Look for the uses of raw_spin_lock_irq_rcu_node() and friends in > kernel/rcu and include/linux/*rcu*, along with the explanation in > Documentation/RCU/Design/Memory-Ordering/Tree-RCU-Memory-Ordering.html > > I must confess that

Re: [PATCH v4] uart: fix race between uart_put_char() and uart_shutdown()

2018-07-12 Thread Greg Kroah-Hartman
On Thu, Jul 12, 2018 at 12:18:46PM -0600, Tycho Andersen wrote: > On Thu, Jul 12, 2018 at 05:40:15PM +0200, Greg Kroah-Hartman wrote: > > On Thu, Jul 12, 2018 at 09:08:22AM -0600, Tycho Andersen wrote: > > > On Thu, Jul 12, 2018 at 05:04:38PM +0200, Greg Kroah-Hartman wrote: > > > > On Wed, Jul

Re: [PATCH 4/5] iio:adxl372: Add sampling frequency support

2018-07-12 Thread Andy Shevchenko
On Thu, Jul 12, 2018 at 6:36 PM, Stefan Popa wrote: > This patch adds the option for the user to select the sampling frequency. > Also, the user can read the available frequencies and read the currently > set frequency via the read_raw function. The frequency can be set via the > write_raw

Re: [PATCH 4/5] iio:adxl372: Add sampling frequency support

2018-07-12 Thread Lars-Peter Clausen
On 07/12/2018 08:25 PM, Andy Shevchenko wrote: > On Thu, Jul 12, 2018 at 6:36 PM, Stefan Popa wrote: >> This patch adds the option for the user to select the sampling frequency. >> Also, the user can read the available frequencies and read the currently >> set frequency via the read_raw function.

[PATCH 06/12] ipc: drop ipc_lock()

2018-07-12 Thread Manfred Spraul
From: Davidlohr Bueso ipc/util.c contains multiple functions to get the ipc object pointer given an id number. There are two sets of function: One set verifies the sequence counter part of the id number, other functions do not check the sequence counter. The standard for function names in

[PATCH 08/12] lib/rhashtable: guarantee initial hashtable allocation

2018-07-12 Thread Manfred Spraul
From: Davidlohr Bueso rhashtable_init() may fail due to -ENOMEM, thus making the entire api unusable. This patch removes this scenario, however unlikely. In order to guarantee memory allocation, this patch always ends up doing GFP_KERNEL|__GFP_NOFAIL for both the tbl as well as

[PATCH 07/12] lib/rhashtable: simplify bucket_table_alloc()

2018-07-12 Thread Manfred Spraul
From: Davidlohr Bueso As of commit ce91f6ee5b3b ("mm: kvmalloc does not fallback to vmalloc for incompatible gfp flags") we can simplify the caller and trust kvzalloc() to just do the right thing. For the case of the GFP_ATOMIC context, we can drop the __GFP_NORETRY flag for obvious reasons, and

[PATCH 01/12] ipc: ipc: compute kern_ipc_perm.id under the ipc lock.

2018-07-12 Thread Manfred Spraul
ipc_addid() initializes kern_ipc_perm.id after having called ipc_idr_alloc(). Thus a parallel semctl() or msgctl() that uses e.g. MSG_STAT may use this unitialized value as the return code. The patch moves all accesses to kern_ipc_perm.id under the spin_lock(). The issues is related to the

[PATCH 03/12] ipc/util.c: Use ipc_rcu_putref() for failues in ipc_addid()

2018-07-12 Thread Manfred Spraul
ipc_addid() is impossible to use: - for certain failures, the caller must not use ipc_rcu_putref(), because the reference counter is not yet initialized. - for other failures, the caller must use ipc_rcu_putref(), because parallel operations could be ongoing already. The patch cleans that up,

[PATCH 05/12] ipc/util.c: correct comment in ipc_obtain_object_check

2018-07-12 Thread Manfred Spraul
The comment that explains ipc_obtain_object_check is wrong: The function checks the sequence number, not the reference counter. Note that checking the reference counter would be meaningless: The reference counter is decreased without holding any locks, thus an object with

[PATCH 04/12] ipc: Rename ipcctl_pre_down_nolock().

2018-07-12 Thread Manfred Spraul
Both the comment and the name of ipcctl_pre_down_nolock() are misleading: The function must be called while holdling the rw semaphore. Therefore the patch renames the function to ipcctl_obtain_check(): This name matches the other names used in util.c: - "obtain" function look up a pointer in the

Re: [PATCH 24/32] vfs: syscall: Add fsopen() to prepare for superblock creation [ver #9]

2018-07-12 Thread Linus Torvalds
On Thu, Jul 12, 2018 at 1:23 PM David Howells wrote: > > It's all very well to say "use file->f_creds". The problem is this has to be > handed down all the way through the filesystem and down into the block layer > as appropriate to anywhere there's an LSM call, a CAP_* check or a pathwalk - >

Re: [GIT PULL][PATCH 0/2] Few timekeeping items for 4.19

2018-07-12 Thread John Stultz
On Thu, Jul 12, 2018 at 1:26 PM, Thomas Gleixner wrote: > On Thu, 12 Jul 2018, John Stultz wrote: > >> I had a few other items in my stack here, but you've already >> queued them in -tip, so here's what I have left. > > Did I miss you replying on them that you picked them up? Normally when I >

Re: [PATCH v4 0/3] uio: fix potential crash bug

2018-07-12 Thread Hamish Martin
Hi Xiubo, Tested-by: Hamish Martin I see these were already merged into Linus' tree but I wanted to let you know that I tested v4.18-rc4 (which contains these three patches) and the issue which led to my original series is still fixed and this patch series of yours has caused no regression

Re: [PATCH 02/39] x86/entry/32: Rename TSS_sysenter_sp0 to TSS_entry_stack

2018-07-12 Thread Andy Lutomirski
> On Jul 11, 2018, at 4:29 AM, Joerg Roedel wrote: > > From: Joerg Roedel > > The stack address doesn't need to be stored in tss.sp0 if > we switch manually like on sysenter. Rename the offset so > that it still makes sense when we change its location. > > We will also use this stack for

Re: [PATCH 01/39] x86/asm-offsets: Move TSS_sp0 and TSS_sp1 to asm-offsets.c

2018-07-12 Thread Andy Lutomirski
> On Jul 11, 2018, at 4:29 AM, Joerg Roedel wrote: > > From: Joerg Roedel > > These offsets will be used in 32 bit assembly code as well, > so make them available for all of x86 code. Reviewed-by: Andy Lutomirski > > Signed-off-by: Joerg Roedel > --- > arch/x86/kernel/asm-offsets.c|

Re: [PATCH 3/4] staging: gasket: fix multi line comments style

2018-07-12 Thread Felix Siegel
On Thu, 12 Jul 2018 21:53:54 +0200 Greg Kroah-Hartman wrote: > On Thu, Jul 12, 2018 at 09:27:14PM +0200, Felix Siegel wrote: > > This patch fixes checkpatch.pl warnings: > > > > WARNING: Block comments should align the * on each line > > Signed-off-by: Felix Siegel > > So close, I need a

Re: [PATCH 07/39] x86/entry/32: Enter the kernel via trampoline stack

2018-07-12 Thread Andy Lutomirski
> On Jul 11, 2018, at 4:29 AM, Joerg Roedel wrote: > > From: Joerg Roedel > > Use the entry-stack as a trampoline to enter the kernel. The > entry-stack is already in the cpu_entry_area and will be > mapped to userspace when PTI is enabled. > > Signed-off-by: Joerg Roedel > --- >

Re: [PATCH v3 05/12] kconfig: make syncconfig update .config regardless of sym_change_count

2018-07-12 Thread Dirk Gouders
Dirk Gouders writes: > Masahiro Yamada writes: > >> 2018-07-09 20:39 GMT+09:00 Dirk Gouders : >>> Dirk Gouders writes: >>> Dirk Gouders writes: > Masahiro Yamada writes: > >> syncconfig updates the .config only when sym_change_count > 0, i.e. >> any change in config

[PATCH 2/2] parport: ieee1284: mark expected switch fall-throughs

2018-07-12 Thread Sudip Mukherjee
From: "Gustavo A. R. Silva" In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva Signed-off-by: Sudip Mukherjee --- drivers/parport/ieee1284.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH 1/2] parport: sunbpp: fix error return code

2018-07-12 Thread Sudip Mukherjee
From: Julia Lawall Return an error code on failure. Change leading spaces to tab on the first if. Problem found using Coccinelle. Signed-off-by: Julia Lawall Signed-off-by: Sudip Mukherjee --- drivers/parport/parport_sunbpp.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-)

Re: [PATCH 1/2] tracing: kprobes: Prohibit probing on notrace functions

2018-07-12 Thread Steven Rostedt
On Thu, 12 Jul 2018 13:54:12 -0400 Francis Deslauriers wrote: > From: Masami Hiramatsu > > Prohibit kprobe-events probing on notrace function. > Since probing on the notrace function can cause recursive > event call. In most case those are just skipped, but > in some case it falls into

Re: [PATCH] i2c: aspeed: Improve driver to support multi-master use cases stably

2018-07-12 Thread Jae Hyun Yoo
On 7/12/2018 2:33 AM, Brendan Higgins wrote: On Wed, Jun 27, 2018 at 10:55 AM Jae Hyun Yoo wrote: +/* Timeout for bus busy checking */ +#define BUS_BUSY_CHECK_TIMEOUT 25 /* 250ms */ +#define BUS_BUSY_CHECK_INTERVAL1 /* 10ms

Re: [PATCH 24/32] vfs: syscall: Add fsopen() to prepare for superblock creation [ver #9]

2018-07-12 Thread Andy Lutomirski
> On Jul 12, 2018, at 11:03 AM, Greg KH wrote: > >> On Thu, Jul 12, 2018 at 06:20:24PM +0100, Al Viro wrote: >>> On Thu, Jul 12, 2018 at 07:15:05PM +0200, Greg KH wrote: On Tue, Jul 10, 2018 at 11:44:09PM +0100, David Howells wrote: Provide an fsopen() system call that starts the

Re: [PATCH v4] uart: fix race between uart_put_char() and uart_shutdown()

2018-07-12 Thread Tycho Andersen
On Thu, Jul 12, 2018 at 08:25:45PM +0200, Greg Kroah-Hartman wrote: > On Thu, Jul 12, 2018 at 12:18:46PM -0600, Tycho Andersen wrote: > > On Thu, Jul 12, 2018 at 05:40:15PM +0200, Greg Kroah-Hartman wrote: > > > On Thu, Jul 12, 2018 at 09:08:22AM -0600, Tycho Andersen wrote: > > > > On Thu, Jul

Re: [PATCH 0/4] rtc: omap: fixes and clean ups

2018-07-12 Thread Alexandre Belloni
On 04/07/2018 11:05:54+0200, Johan Hovold wrote: > Here are a couple of fixes for issues discovered through inspection > along with some clean ups. > > Johan > > > Johan Hovold (4): > rtc: omap: fix potential crash on power off > rtc: omap: fix resource leak in registration error path >

[PATCH 10/12] ipc: simplify ipc initialization

2018-07-12 Thread Manfred Spraul
From: Davidlohr Bueso Now that we know that rhashtable_init() will not fail, we can get rid of a lot of the unnecessary cleanup paths when the call errored out. Signed-off-by: Davidlohr Bueso (variable name added to util.h to resolve checkpatch warning) Signed-off-by: Manfred Spraul ---

[PATCH 11/12] ipc/util.c: Further variable name cleanups

2018-07-12 Thread Manfred Spraul
The varable names got a mess, thus standardize them again: id: user space id. Called semid, shmid, msgid if the type is known. Most functions use "id" already. idx: "index" for the idr lookup Right now, some functions use lid, ipc_addid() already uses idx as the variable name. seq:

[PATCH 09/12] ipc: get rid of ids->tables_initialized hack

2018-07-12 Thread Manfred Spraul
From: Davidlohr Bueso In sysvipc we have an ids->tables_initialized regarding the rhashtable, introduced in: commit 0cfb6aee70bd ("ipc: optimize semget/shmget/msgget for lots of keys") It's there, specifically, to prevent nil pointer dereferences, from using an uninitialized api. Considering

[PATCH 12/12] ipc/util.c: update return value of ipc_getref from int to bool

2018-07-12 Thread Manfred Spraul
ipc_getref has still a return value of type "int", matching the atomic_t interface of atomic_inc_not_zero()/atomic_add_unless(). ipc_getref now uses refcount_inc_not_zero, which has a return value of type "bool". Therefore: Update the return code to avoid implicit conversions. Signed-off-by:

[PATCH 0/12 V3] ipc: cleanups & bugfixes, rhashtable update

2018-07-12 Thread Manfred Spraul
Hi, I have added all all review findings and rediffed the patches - patch #1-#6: Fix syzcall findings & further race cleanups patch #1 has an updated subject/comment patch #2 contains the squashed result of Dmitrys change and my own updates. patch #6 is replaced

[PATCH 02/12] ipc: reorganize initialization of kern_ipc_perm.seq

2018-07-12 Thread Manfred Spraul
ipc_addid() initializes kern_ipc_perm.seq after having called idr_alloc() (within ipc_idr_alloc()). Thus a parallel semop() or msgrcv() that uses ipc_obtain_object_check() may see an uninitialized value. The patch moves the initialization of kern_ipc_perm.seq before the calls of idr_alloc().

Re: [PATCH 24/32] vfs: syscall: Add fsopen() to prepare for superblock creation [ver #9]

2018-07-12 Thread Greg KH
On Thu, Jul 12, 2018 at 11:30:32AM -0700, Andy Lutomirski wrote: > > > On Jul 12, 2018, at 11:03 AM, Greg KH wrote: > > > >> On Thu, Jul 12, 2018 at 06:20:24PM +0100, Al Viro wrote: > >>> On Thu, Jul 12, 2018 at 07:15:05PM +0200, Greg KH wrote: > On Tue, Jul 10, 2018 at 11:44:09PM +0100,

Re: [PATCH] ata: Guard ata_scsi_dump_cdb() by ATA_VERBOSE_DEBUG

2018-07-12 Thread Tejun Heo
On Thu, Jul 12, 2018 at 06:29:44PM +0200, Paul Menzel wrote: > Date: Sun, 8 Jul 2018 09:11:34 +0200 > > Defining `ATA_DEBUG` nothing can be really seen, as the log is spammed > with CDB messages. > > Therefore, guard the print by `ATA_VERBOSE_DEBUG`. > > Signed-off-by: Paul Menzel Applied to

Re: [PATCH] ata: Only output sg element mapped number in verbose debug

2018-07-12 Thread Tejun Heo
On Thu, Jul 12, 2018 at 06:31:03PM +0200, Paul Menzel wrote: > Date: Sun, 8 Jul 2018 09:18:21 +0200 > > Defining `ATA_DEBUG` there are a lof of messages like below in the log. > > [ 16.345472] ata_sg_setup: 1 sg elements mapped > > As that is too verbose, only output these messages in

Re: [GIT PULL][PATCH 0/2] Few timekeeping items for 4.19

2018-07-12 Thread Thomas Gleixner
John, On Thu, 12 Jul 2018, John Stultz wrote: > I had a few other items in my stack here, but you've already > queued them in -tip, so here's what I have left. Did I miss you replying on them that you picked them up? Normally when I see that you or Daniel picked something up I happily move

Re: [PATCH v9 4/7] tracepoint: Make rcuidle tracepoint callers use SRCU

2018-07-12 Thread Steven Rostedt
On Thu, 12 Jul 2018 13:29:32 -0700 Joel Fernandes wrote: > Also the kselftest patches were acked and can be taken independently, > I had reposted them as a separate 2 patch series with some minor > changes based on your suggestions. Could you check them? > Yep, I saw them. I was going to wait

[PATCH v5 3/5] mm/sparse: move buffer init/fini to the common place

2018-07-12 Thread Pavel Tatashin
Now, that both variants of sparse memory use the same buffers to populate memory map, we can move sparse_buffer_init()/sparse_buffer_fini() to the common place. Signed-off-by: Pavel Tatashin --- include/linux/mm.h | 3 --- mm/sparse-vmemmap.c | 2 -- mm/sparse.c | 14 +++---

Re: [PATCH] x86: vdso: Fix leaky vdso link with CC=clang

2018-07-12 Thread Alistair Strachan
On Thu, Jul 12, 2018 at 1:25 PM H. Peter Anvin wrote: > On 07/12/18 13:10, Alistair Strachan wrote: > > The vdso{32,64}.so can fail to link with CC=clang when clang tries to > > find a suitable GCC toolchain to link these libraries with. > > > > /usr/bin/ld: arch/x86/entry/vdso/vclock_gettime.o:

[PATCH v5 5/5] mm/sparse: delete old sprase_init and enable new one

2018-07-12 Thread Pavel Tatashin
Rename new_sparse_init() to sparse_init() which enables it. Delete old sparse_init() and all the code that became obsolete with. Signed-off-by: Pavel Tatashin --- include/linux/mm.h | 6 -- mm/Kconfig | 4 - mm/sparse-vmemmap.c | 21 - mm/sparse.c | 217

[PATCH v5 2/5] mm/sparse: use the new sparse buffer functions in non-vmemmap

2018-07-12 Thread Pavel Tatashin
non-vmemmap sparse also allocated large contiguous chunk of memory, and if fails falls back to smaller allocations. Use the same functions to allocate buffer as the vmemmap-sparse Signed-off-by: Pavel Tatashin --- mm/sparse.c | 41 ++--- 1 file changed, 14

[PATCH v5 0/5] sparse_init rewrite

2018-07-12 Thread Pavel Tatashin
Changelog: v5 - v4 - Fixed the issue that was reported on ppc64 when CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER is removed - Consolidated the new buffer allocation between vmemmap and non-vmemmap variants of sparse layout. - Removed all review-by comments,

Re: [PATCH v2] tools/memory-model: Add extra ordering for locks and remove it for ordinary release/acquire

2018-07-12 Thread Andrea Parri
On Thu, Jul 12, 2018 at 11:13:48PM +0200, Andrea Parri wrote: > On Thu, Jul 12, 2018 at 04:43:46PM -0400, Alan Stern wrote: > > On Thu, 12 Jul 2018, Andrea Parri wrote: > > > > > > It seems reasonable to ask people to learn that locks have stronger > > > > ordering guarantees than RMW atomics do.

Re: [PATCH v2 4/6] arm: dts: add support for Laird WB50N cpu module and DVK

2018-07-12 Thread Alexandre Belloni
Hi, I've now applied the whole series after fixing two small whitespace issues. On 15/06/2018 14:40:53+0100, Ben Whitten wrote: > +_clk { > + atmel,clk-output-range = <0 13200>; > +}; > + But this is not actually allowed by the hardware (well, it is but it will lead to issues) and will

[PATCH 2/2] staging: bcm2835-audio: Don't leak workqueue if open fails

2018-07-12 Thread Tuomas Tynkkynen
Currently, if bcm2835_audio_open() fails partway, the allocated workqueue is leaked. Avoid that. While at it, propagate the return value of bcm2835_audio_open_connection() on failure instead of returning -1. Signed-off-by: Tuomas Tynkkynen ---

[PATCH 1/2] staging: bcm2835-audio: Check if workqueue allocation failed

2018-07-12 Thread Tuomas Tynkkynen
Currently, if allocating a workqueue fails, the driver will probe successfully but it will silently do nothing, which is rather silly. So instead bail out with -ENOMEM in bcm2835_audio_open() if alloc_workqueue() fails, and remove the now pointless checks for a NULL workqueue. While at it, get

[PATCH v5 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-07-12 Thread Taniya Das
The CPUfreq HW present in some QCOM chipsets offloads the steps necessary for changing the frequency of CPUs. The driver implements the cpufreq driver interface for this hardware engine. Signed-off-by: Saravana Kannan Signed-off-by: Taniya Das --- drivers/cpufreq/Kconfig.arm | 10 ++

  1   2   3   4   5   6   7   >