Re: [PATCH v5 4/4] x86/boot/KASLR: Limit kaslr to choosing the immovable memory

2018-08-27 Thread Chao Fan
On Mon, Aug 27, 2018 at 01:56:07PM +0800, Baoquan He wrote: >On 08/07/18 at 02:50pm, Chao Fan wrote: >> If 'CONFIG_MEMORY_HOTREMOVE' specified and the account of immovable >If CONFIG_MEMORY_HOTREMOVE is enabled, >> memory regions is not zero. Calculate the intersection between memory >> regions

Re: [PATCH v5 4/4] x86/boot/KASLR: Limit kaslr to choosing the immovable memory

2018-08-27 Thread Baoquan He
On 08/27/18 at 02:28pm, Chao Fan wrote: > >Is it possible to take num_immovable_mem definition out from #ifdef > >CONFIG_MEMORY_HOTREMOVE block and check it here like below? This way, > >one level of indentation can be reduced in the for loop, and code is > >more readable. > > > > I think there

Re: [PATCH v5 4/4] x86/boot/KASLR: Limit kaslr to choosing the immovable memory

2018-08-27 Thread Baoquan He
On 08/27/18 at 01:56pm, Baoquan He wrote: > On 08/07/18 at 02:50pm, Chao Fan wrote: > > If 'CONFIG_MEMORY_HOTREMOVE' specified and the account of immovable > If CONFIG_MEMORY_HOTREMOVE is enabled, > > memory regions is not zero. Calculate the intersection between memory > > regions from e820/efi

Re: [PATCH V6 5/9] mmc: sdhci: Add 32-bit block count support for v4 mode

2018-08-27 Thread Adrian Hunter
On 24/08/18 12:20, Chunyan Zhang wrote: > Host Controller Version 4.10 re-defines SDMA System Address register > as 32-bit Block Count for v4 mode, and SDMA uses ADMA System > Address register (05Fh-058h) instead if v4 mode is enabled. Also > when using 32-bit block count, 16-bit block count

Re: [PATCH] checkpatch: remove GCC_BINARY_CONSTANT warning

2018-08-27 Thread Joe Perches
On Mon, 2018-08-27 at 06:59 +, Christophe Leroy wrote: > This warning was there to avoid the use of 0bxxx values > as they are not supported by gcc prior to v4.3 > > Since commit cafa0010cd51f ("Raise the minimum required gcc > version to 4.6"), it's not an issue anymore and using > such

Re: [PATCH] ARM: dts: imx7s-warp: enable i2c3 device support

2018-08-27 Thread Shawn Guo
On Fri, Aug 17, 2018 at 11:23:17PM +0200, Pierre-Jean Texier wrote: > The WaRP7 has one mikroBUS socket on the back to plug click boards. > This patch allows to interact with some of these > i2c modules (EEPROM, RTC and so on). > > Signed-off-by: Pierre-Jean Texier Applied, thanks.

Re: [PATCH v4 3/3] mmc: sdhci-of-dwcmshc: solve 128MB DMA boundary limitation

2018-08-27 Thread Jisheng Zhang
On Thu, 23 Aug 2018 14:51:26 +0300 Adrian Hunter wrote: > On 23/08/18 13:09, Jisheng Zhang wrote: > > When using DMA, if the DMA addr spans 128MB boundary, we have to split > > the DMA transfer into two so that each one doesn't exceed the boundary. > > > > Signed-off-by: Jisheng Zhang > > --- >

Re: [PATCH] floppy: Do not copy a kernel pointer to user memory in FDGETPRM ioctl

2018-08-27 Thread Kees Cook
On Tue, May 29, 2018 at 6:27 AM, Andy Whitcroft wrote: > On Wed, Mar 07, 2018 at 04:02:45PM -0800, Brian Belleville wrote: >> The final field of a floppy_struct is the field "name", which is a >> pointer to a string in kernel memory. The kernel pointer should not be >> copied to user memory. The

Re: [PATCH] ARM: dts: imx6ul: Add DTS for ConnectCore 6UL SBC Pro

2018-08-27 Thread Shawn Guo
On Wed, Aug 22, 2018 at 01:18:39PM +0200, Alex Gonzalez wrote: > The ConnectCore 6UL Single Board Computer (SBC) Pro contains the > ConnectCore 6UL System-On-Module. > > Its hardware specifications are: > > * 256MB DDR3 memory > * On module 256MB NAND flash > * Dual 10/100 Ethernet > * USB Host

[PATCH 0/3] swap: Code refactoring for some swap free related functions

2018-08-27 Thread Huang Ying
To improve the code readability. Some swap free related functions are refactored. This patchset is based on 8/23 HEAD of mmotm tree. Best Regards, Huang, Ying

[PATCH 1/3] swap: Use __try_to_reclaim_swap() in free_swap_and_cache()

2018-08-27 Thread Huang Ying
The code path to reclaim the swap entry in free_swap_and_cache() is almost same as that of __try_to_reclaim_swap(). The largest difference is just coding style. So the support to the additional requirement of free_swap_and_cache() is added into __try_to_reclaim_swap(). free_swap_and_cache() is

Re: [PATCH 3/4] mm/tlb, x86/mm: Support invalidating TLB caches for RCU_TABLE_FREE

2018-08-27 Thread Peter Zijlstra
On Mon, Aug 27, 2018 at 06:09:50PM +1000, Benjamin Herrenschmidt wrote: > Sadly our architecture requires a precise match between the page size > specified in the tlbie instruction and the entry in the TLB or it won't > be flushed. Argh.. OK I see. That is rather unfortunate and does seem to

[PATCH 2/2] clk: pmc-atom: use devm_kstrdup_const()

2018-08-27 Thread Bartosz Golaszewski
Use devm_kstrdup_const() in the pmc-atom driver. This mostly serves as an example of how to use this new routine to shrink driver code. While we're at it: replace a call to kcalloc() with devm_kcalloc(). Signed-off-by: Bartosz Golaszewski --- drivers/clk/x86/clk-pmc-atom.c | 19

[tip:x86/urgent] x86/Kconfig: Fix trivial typo

2018-08-27 Thread tip-bot for Nikolas Nyby
Commit-ID: e3a5dc08715abba646324fd8456282bd77798e9c Gitweb: https://git.kernel.org/tip/e3a5dc08715abba646324fd8456282bd77798e9c Author: Nikolas Nyby AuthorDate: Sat, 25 Aug 2018 19:10:54 -0400 Committer: Thomas Gleixner CommitDate: Mon, 27 Aug 2018 10:29:14 +0200 x86/Kconfig: Fix

[tip:x86/urgent] x86/speculation/l1tf: Increase l1tf memory limit for Nehalem+

2018-08-27 Thread tip-bot for Andi Kleen
Commit-ID: cc51e5428ea54f575d49cfcede1d4cb3a72b4ec4 Gitweb: https://git.kernel.org/tip/cc51e5428ea54f575d49cfcede1d4cb3a72b4ec4 Author: Andi Kleen AuthorDate: Fri, 24 Aug 2018 10:03:50 -0700 Committer: Thomas Gleixner CommitDate: Mon, 27 Aug 2018 10:29:14 +0200 x86/speculation/l1tf:

Re: [PATCH 3/4] mm/tlb, x86/mm: Support invalidating TLB caches for RCU_TABLE_FREE

2018-08-27 Thread Nicholas Piggin
On Mon, 27 Aug 2018 10:20:45 +0200 Peter Zijlstra wrote: > On Mon, Aug 27, 2018 at 06:09:50PM +1000, Benjamin Herrenschmidt wrote: > > > Sadly our architecture requires a precise match between the page size > > specified in the tlbie instruction and the entry in the TLB or it won't > > be

Re: [PATCH v2 1/2]: perf util: map data buffer for preserving collected data

2018-08-27 Thread Alexey Budankov
Hi Jiri, On 27.08.2018 11:28, Jiri Olsa wrote: > On Thu, Aug 23, 2018 at 07:42:09PM +0300, Alexey Budankov wrote: >> >> The data buffer and accompanying AIO control block are allocated at >> perf_mmap object and the mapped data buffer size is equal to >> the kernel one. >> >> The buffer is then

[RESEND PATCH v3 2/3] platform: move the early platform device support to arch/sh

2018-08-27 Thread Bartosz Golaszewski
From: Bartosz Golaszewski SuperH is the only user of the current implementation of early platform device support. We want to introduce a more robust approach to early probing. As the first step - move all the current early platform code to arch/sh. In order not to export internal drivers/base

[RESEND PATCH v3 1/3] clocksource: timer-ti-dm: remove the early platform driver registration

2018-08-27 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This driver is no longer used as an early platform driver. Remove the registration macro. Signed-off-by: Bartosz Golaszewski Acked-by: Arnd Bergmann Acked-by: Daniel Lezcano --- drivers/clocksource/timer-ti-dm.c | 1 - 1 file changed, 1 deletion(-) diff --git

[RESEND PATCH v3 3/3] sh: add the sh_ prefix to early platform symbols

2018-08-27 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Old early platform device support is now sh-specific. Before moving on to implementing new early platform framework based on real platform devices, prefix all early platform symbols with 'sh_'. Signed-off-by: Bartosz Golaszewski --- arch/sh/drivers/platform_early.c

[RESEND PATCH v3 0/3] sh: make early_platform code SuperH-specific

2018-08-27 Thread Bartosz Golaszewski
I recently started a discussion about the need for a proper early device probing mechanism[1]. One that would be based on real platform drivers and support both platform data and device tree. While we're far from reaching any consensus on the implementation, Arnd suggested that I start off by

Re: [PATCH v5 4/4] x86/boot/KASLR: Limit kaslr to choosing the immovable memory

2018-08-27 Thread Chao Fan
On Mon, Aug 27, 2018 at 02:28:54PM +0800, Chao Fan wrote: >On Mon, Aug 27, 2018 at 01:56:07PM +0800, Baoquan He wrote: >>On 08/07/18 at 02:50pm, Chao Fan wrote: [...] >> >>Is it possible to take num_immovable_mem definition out from #ifdef >>CONFIG_MEMORY_HOTREMOVE block and check it here like

[PATCH v2] mtd: rawnand: denali: do not pass zero maxchips to nand_scan()

2018-08-27 Thread Masahiro Yamada
Commit 49aa76b16676 ("mtd: rawnand: do not execute nand_scan_ident() if maxchips is zero") gave a new meaning for calling nand_scan_ident() with maxchips=0. It is a special usage for some drivers such as docg4, but actually the Denali driver may pass maxchips=0 to nand_scan() when the driver is

[PATCH 1/2] devres: provide devm_kstrdup_const()

2018-08-27 Thread Bartosz Golaszewski
Provide a resource managed version of kstrdup_const(). This variant internally calls devm_kstrdup() on pointers that are outside of .rodata section. Also provide a corresponding version of devm_kfree(). Signed-off-by: Bartosz Golaszewski --- include/linux/device.h | 2 ++ mm/util.c

Re: [PATCH v5 3/5] iommu/io-pgtable-arm: add support for non-strict mode

2018-08-27 Thread Leizhen (ThunderTown)
On 2018/8/23 1:52, Robin Murphy wrote: > On 15/08/18 02:28, Zhen Lei wrote: >> To support the non-strict mode, now we only tlbi and sync for the strict >> mode. But for the non-leaf case, always follow strict mode. >> >> Signed-off-by: Zhen Lei >> --- >> drivers/iommu/io-pgtable-arm.c | 20

[PATCH v2 1/9] of: add helper to lookup compatible child node

2018-08-27 Thread Johan Hovold
Add of_get_compatible_child() helper that can be used to lookup compatible child nodes. Several drivers currently use of_find_compatible_node() to lookup child nodes while failing to notice that the of_find_ functions search the entire tree depth-first (from a given start node) and therefore can

[PATCH v2 5/9] mtd: nand: atmel: fix OF child-node lookup

2018-08-27 Thread Johan Hovold
Use the new of_get_compatible_child() helper to lookup the nfc child node instead of using of_find_compatible_node(), which searches the entire tree from a given start node and thus can return an unrelated (i.e. non-child) node. This also addresses a potential use-after-free (e.g. after probe

[PATCH v2 4/9] mmc: meson-mx-sdio: fix OF child-node lookup

2018-08-27 Thread Johan Hovold
Use the new of_get_compatible_child() helper to lookup the slot child node instead of using of_find_compatible_node(), which searches the entire tree from a given start node and thus can return an unrelated (i.e. non-child) node. This also addresses a potential use-after-free (e.g. after probe

Re: [PATCH v2 2/2]: perf record: enable asynchronous trace writing

2018-08-27 Thread Jiri Olsa
On Thu, Aug 23, 2018 at 07:47:01PM +0300, Alexey Budankov wrote: SNIP > diff --git a/tools/perf/util/mmap.c b/tools/perf/util/mmap.c > index e71d46cb01cc..c8b921c88a5d 100644 > --- a/tools/perf/util/mmap.c > +++ b/tools/perf/util/mmap.c > @@ -292,11 +292,11 @@ int perf_mmap__read_init(struct

[tip:x86/urgent] x86/spectre: Add missing family 6 check to microcode check

2018-08-27 Thread tip-bot for Andi Kleen
Commit-ID: 1ab534e85c93945f7862378d8c8adcf408205b19 Gitweb: https://git.kernel.org/tip/1ab534e85c93945f7862378d8c8adcf408205b19 Author: Andi Kleen AuthorDate: Fri, 24 Aug 2018 10:03:51 -0700 Committer: Thomas Gleixner CommitDate: Mon, 27 Aug 2018 10:29:14 +0200 x86/spectre: Add

[PATCH V5 2/3] dt-bindings: input: Add document bindings for DA7280

2018-08-27 Thread Roy Im
Add device tree binding information for DA7280 haptic driver. Example bindings for DA7280 are added. Signed-off-by: Roy Im --- v5: Updated descriptions and fixed errors. v4: Fixed commit message, properties. v3: Fixed subject format. v2: No changes

Re: [PATCH] drivers/thermal/tegra: fix a doule free devce node

2018-08-27 Thread Daniel Lezcano
On 17/08/2018 04:25, zhong jiang wrote: > On 2018/8/14 14:39, Daniel Lezcano wrote: >> On 09/08/2018 15:40, zhong jiang wrote: >>> Device node iterators will get the return node. Meawhile, It is >>> also put the previous device node. An explicit put will cause >>> a double put. >> What about: >>

[PATCH V5 0/3] da7280: haptic driver submission

2018-08-27 Thread Roy Im
This patch adds support for the Dialog DA7280 Haptic driver IC. In this patch set the following is provided: [PATCH V2 1/3] MAINTAINERS file update for DA7280 [PATCH V2 2/3] DA7280 DT Binding [PATCH V2 3/3] DA7280 Driver This patch applies against linux-next and v4.18 Thank you, Roy Im, Dialog

[PATCH V5 1/3] MAINTAINERS: da7280 updates to the Dialog Semiconductor search terms

2018-08-27 Thread Roy Im
This patch adds the da7280 bindings doc and driver to the Dialog Semiconductor support list. Signed-off-by: Roy Im --- v5: No changes. v4: No changes. v3: No changes. v2: No changes. MAINTAINERS |2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [PATCH 1/2] devres: provide devm_kstrdup_const()

2018-08-27 Thread Joe Perches
On Mon, 2018-08-27 at 10:21 +0200, Bartosz Golaszewski wrote: > Provide a resource managed version of kstrdup_const(). This variant > internally calls devm_kstrdup() on pointers that are outside of > .rodata section. Also provide a corresponding version of devm_kfree(). [] > diff --git a/mm/util.c

Re: [PATCH] irqchip/gic-v3-its: add allocation max order limitation for lpi_id_bits

2018-08-27 Thread Marc Zyngier
On Mon, 27 Aug 2018 02:41:04 +0100, Jia He wrote: > > Hi Marc > Thanks for the comments > > On 8/27/2018 3:01 AM, Marc Zyngier Wrote: > > [I'm travelling, so expect some major delays in responding to email] > > > > Hi Jia, > > > > On Sun, 26 Aug 2018 10:00:51 +0100, > > Jia He wrote: > >> >

Re: [PATCH] serial: mvebu-uart: Fix reporting of effective CSIZE to userspace

2018-08-27 Thread Jan Kiszka
On 2018-08-26 19:49, Jan Kiszka wrote: > From: Jan Kiszka > > Apparently, this driver (or the hardware) does not support character > length settings. It's apparently running in 8-bit mode, but it makes > userspace believe it's in 5-bit mode. That makes tcsetattr with CS8 > incorrectly fail,

Re: [PATCH] percpu_counter: Remove debug_object_free call twice

2018-08-27 Thread Kohli, Gaurav
Hi , Sorry for very late reminder, just wanted to know is below understanding of code is wrong? Regards Gaurav On 4/17/2018 11:59 AM, Kohli, Gaurav wrote: On 4/17/2018 3:18 AM, Tejun Heo wrote: On Fri, Apr 13, 2018 at 03:05:03PM +0530, Gaurav Kohli wrote: During percpu_counter destroy,

[PATCH 2/3] swap: call free_swap_slot() in __swap_entry_free()

2018-08-27 Thread Huang Ying
This is a code cleanup patch without functionality change. Originally, when __swap_entry_free() is called, and its return value is 0, free_swap_slot() will always be called to free the swap entry to the per-CPU pool. So move the call to free_swap_slot() to __swap_entry_free() to simplify the

[PATCH 3/3] swap: Clear si->swap_map[] in swap_free_cluster()

2018-08-27 Thread Huang Ying
si->swap_map[] of the swap entries in cluster needs to be cleared during freeing. Previously, this is done in the caller of swap_free_cluster(). This may cause code duplication (one user now, will add more users later) and lock/unlock cluster unnecessarily. In this patch, the clearing code is

[PATCH RESEND] mips: switch to NO_BOOTMEM

2018-08-27 Thread Mike Rapoport
MIPS already has memblock support and all the memory is already registered with it. This patch replaces bootmem memory reservations with memblock ones and removes the bootmem initialization. Signed-off-by: Mike Rapoport --- arch/mips/Kconfig | 1 +

Re: TLB flushes on fixmap changes

2018-08-27 Thread Masami Hiramatsu
On Sun, 26 Aug 2018 20:26:09 -0700 Nadav Amit wrote: > at 8:03 PM, Masami Hiramatsu wrote: > > > On Sun, 26 Aug 2018 11:09:58 +0200 > > Peter Zijlstra wrote: > > > >> On Sat, Aug 25, 2018 at 09:21:22PM -0700, Andy Lutomirski wrote: > >>> I just re-read text_poke(). It's, um, horrible. Not

Re: [PATCH 3/4] mm/tlb, x86/mm: Support invalidating TLB caches for RCU_TABLE_FREE

2018-08-27 Thread Nicholas Piggin
On Mon, 27 Aug 2018 09:47:01 +0200 Peter Zijlstra wrote: > On Mon, Aug 27, 2018 at 03:00:08PM +1000, Nicholas Piggin wrote: > > On Fri, 24 Aug 2018 13:39:53 +0200 > > Peter Zijlstra wrote: > > > On Fri, Aug 24, 2018 at 01:32:14PM +0200, Peter Zijlstra wrote: > > > > > Hurm.. look at

Re: [PATCH] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB

2018-08-27 Thread Boris Brezillon
On Sat, 18 Aug 2018 17:14:23 +0800 Liu Xiang wrote: > If the size of spi-nor flash is larger than 16MB, the read_opcode > is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will > return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can > cause read operation fail. > >

Re: [PATCH] x86/microcode: allow non-root reading of microcode version and processor flags

2018-08-27 Thread Jacek Tomaka
On Mon, Aug 27, 2018 at 3:52 PM, Borislav Petkov wrote: > Your From: is Jacek Tomaka and your SOB is different. > Which one should I use? Please use my SOB: Jacek Tomaka > (Having a single email address for both is easier...) Sorry about the trouble. Regards. Jacek Tomaka

[PATCH v2 7/9] net: stmmac: dwmac-sun8i: fix OF child-node lookup

2018-08-27 Thread Johan Hovold
Use the new of_get_compatible_child() helper to lookup the mdio-internal child node instead of using of_find_compatible_node(), which searches the entire tree from a given start node and thus can return an unrelated (i.e. non-child) node. This also addresses a potential use-after-free (e.g. after

[PATCH v2 3/9] drm/msm: fix OF child-node lookup

2018-08-27 Thread Johan Hovold
Use the new of_get_compatible_child() helper to lookup the legacy pwrlevels child node instead of using of_find_compatible_node(), which searches the entire tree from a given start node and thus can return an unrelated (i.e. non-child) node. This also addresses a potential use-after-free (e.g.

[PATCH v2 8/9] NFC: nfcmrvl_uart: fix OF child-node lookup

2018-08-27 Thread Johan Hovold
Use the new of_get_compatible_child() helper to lookup the nfc child node instead of using of_find_compatible_node(), which searches the entire tree from a given start node and thus can return an unrelated (i.e. non-child) node. This also addresses a potential use-after-free (e.g. after probe

[PATCH v5 0/3] solve SDHCI DWC MSHC 128MB DMA boundary limitation

2018-08-27 Thread Jisheng Zhang
When using DMA, if the DMA addr spans 128MB boundary, we have to split the DMA transfer into two so that each one doesn't exceed the boundary. patch1 adds adma_table_cnt to struct sdhci_host so that driver can control the ADMA table count. patch2 introduces adma_write_desc() hook to struct

[PATCH v2 9/9] power: supply: twl4030-charger: fix OF sibling-node lookup

2018-08-27 Thread Johan Hovold
Use the new of_get_compatible_child() helper to lookup the usb sibling node instead of using of_find_compatible_node(), which searches the entire tree from a given start node and thus can return an unrelated (non-sibling) node. This also addresses a potential use-after-free (e.g. after probe

[PATCH v2 2/9] drm/mediatek: fix OF sibling-node lookup

2018-08-27 Thread Johan Hovold
Use the new of_get_compatible_child() helper to lookup the sibling instead of using of_find_compatible_node(), which searches the entire tree from a given start node and thus can return an unrelated (i.e. non-sibling) node. This also addresses a potential use-after-free (e.g. after probe

[PATCH v2 6/9] net: bcmgenet: fix OF child-node lookup

2018-08-27 Thread Johan Hovold
Use the new of_get_compatible_child() helper to lookup the mdio child node instead of using of_find_compatible_node(), which searches the entire tree from a given start node and thus can return an unrelated (i.e. non-child) node. This also addresses a potential use-after-free (e.g. after probe

[PATCH v2 0/9] of: fix compatible-child-node lookups

2018-08-27 Thread Johan Hovold
Several drivers currently use of_find_compatible_node() to lookup child nodes while failing to notice that the of_find_ functions search the entire tree depth-first (from a given start node) and therefore can match unrelated nodes. The fact that these functions also drop a reference to the node

Re: [GIT pull] timer updates for 4.19

2018-08-27 Thread Thomas Gleixner
On Mon, 27 Aug 2018, Arnd Bergmann wrote: > Only a handful of syscalls actually require that complexity, most of them > need only two entry points either way (32-bit time, and 64-bit time), the > question is what we call them. I have a mild preference for the second > version after the discussion

Re: [PATCH v2 1/2]: perf util: map data buffer for preserving collected data

2018-08-27 Thread Jiri Olsa
On Thu, Aug 23, 2018 at 07:42:09PM +0300, Alexey Budankov wrote: SNIP > diff --git a/tools/perf/util/mmap.c b/tools/perf/util/mmap.c > index fc832676a798..e71d46cb01cc 100644 > --- a/tools/perf/util/mmap.c > +++ b/tools/perf/util/mmap.c > @@ -155,6 +155,10 @@ void __weak

Re: [PATCH v9 12/22] s390: vfio-ap: sysfs interfaces to configure control domains

2018-08-27 Thread Cornelia Huck
On Thu, 23 Aug 2018 10:16:59 -0400 Tony Krowiak wrote: > On 08/23/2018 06:25 AM, Cornelia Huck wrote: > > On Wed, 22 Aug 2018 15:16:19 -0400 > > Tony Krowiak wrote: > > > >> One of the things I suggested in a private conversation with Christian > >> earlier > >> today was to provide an

Re: [PATCH 3/4] mm/tlb, x86/mm: Support invalidating TLB caches for RCU_TABLE_FREE

2018-08-27 Thread Benjamin Herrenschmidt
On Mon, 2018-08-27 at 18:04 +1000, Nicholas Piggin wrote: > > Yes.. I see that. tlb_remove_check_page_size_change() really is a rather > > ugly thing, it can cause loads of TLB flushes. Do you really _have_ to > > do that? The way ARM and x86 work is that using INVLPG in a 4K stride is > > still

Re: [PATCH v2 5/9] mtd: nand: atmel: fix OF child-node lookup

2018-08-27 Thread Boris Brezillon
On Mon, 27 Aug 2018 10:44:14 +0200 Johan Hovold wrote: > On Mon, Aug 27, 2018 at 10:28:20AM +0200, Boris Brezillon wrote: > > Hi Johan > > > > On Mon, 27 Aug 2018 10:21:49 +0200 > > Johan Hovold wrote: > > > > > Use the new of_get_compatible_child() helper to lookup the nfc child > > > node

removig ia64, was: Re: [PATCH 3/4] mm/tlb, x86/mm: Support invalidating TLB caches for RCU_TABLE_FREE

2018-08-27 Thread Christoph Hellwig
On Mon, Aug 27, 2018 at 09:47:01AM +0200, Peter Zijlstra wrote: > sh is trivial, arm seems doable, with a bit of luck we can do 'rm -rf > arch/ia64' leaving us with s390. Is removing ia64 a serious plan? It is the cause for a fair share of oddities in dma lang, and I did not have much luck

Re: [PATCH] Properly interpret indirect call in perf annotate.

2018-08-27 Thread Martin Liška
On 08/23/2018 04:12 PM, Arnaldo Carvalho de Melo wrote: > Em Thu, Aug 23, 2018 at 02:29:34PM +0200, Martin Liška escreveu: >> The patch changes interpretation of: >> callq *0x8(%rbx) >> >> from: >> 0.26 │ → callq *8 >> to: >> 0.26 │ → callq *0x8(%rbx) >> >> in this can an address is

[PATCH] perf/x86/intel: Export mem events only if there's PEBs support

2018-08-27 Thread Jiri Olsa
Memory events depends on PEBs support and access to LDLAT msr, but we display them in /sys/devices/cpu/events even if the cpu does not provide those, like for KVM guests. That brings the false assumption that those events should be available, while they fail event to open. Separating the mem-*

Re: [PATCH] ALSA: hdspm: fix spelling mistake "Initializeing" -> "Initializing"

2018-08-27 Thread Takashi Iwai
On Mon, 27 Aug 2018 00:09:52 +0200, Colin King wrote: > > From: Colin Ian King > > Trivial fix to spelling mistake in dev_dbg message and also remove > extraneous white space and repeated question marks. > > Signed-off-by: Colin Ian King Applied, thanks. Takashi

Urgent,

2018-08-27 Thread Juliet Muhammad
i have been trying to contact you

Re: [PATCH 1/3] ARM: dts: imx: Switch Engicam boards to use SPDX identifier

2018-08-27 Thread Shawn Guo
On Tue, Aug 07, 2018 at 12:38:36PM +0530, Jagan Teki wrote: > Adopt the SPDX license identifier headers to ease license compliance > management. > > Also added Engicam Copyright on missing files. > > Signed-off-by: Jagan Teki Applied all, thanks.

Re: [PATCH v3 3/3] arm: dts: ls1021a: Enable I2C DMA support

2018-08-27 Thread Shawn Guo
On Thu, Aug 09, 2018 at 02:32:07PM +0200, Esben Haabendal wrote: > From: Esben Haabendal > > Gives substantial performance improvement for transfers larger than 16 > bytes (DMA_THRESHOLD). Smaller transfers are unaffected. > > Signed-off-by: Esben Haabendal Applied, thanks.

Re: [PATCH V6 8/9] mmc: sdhci-sprd: Add Spreadtrum's initial host controller

2018-08-27 Thread Adrian Hunter
On 24/08/18 12:20, Chunyan Zhang wrote: > From: Chunyan Zhang > > This patch adds the initial support of Secure Digital Host Controller > Interface compliant controller found in some latest Spreadtrum chipsets. > This patch has been tested on the version of SPRD-R11 controller. > > R11 is a

[PATCH V5 3/3] Input: new da7280 haptic driver

2018-08-27 Thread Roy Im
Adds support for the Dialog DA7280 LRA/ERM Haptic Driver with multiple mode and integrated waveform memory and wideband support. It communicates via an I2C bus to the device. Signed-off-by: Roy Im --- v5: Fixed errors in Kconfig file. v4: Updated code as dt-bindings are changed. v3: No

Re: [PATCH v2 2/2]: perf record: enable asynchronous trace writing

2018-08-27 Thread Jiri Olsa
On Thu, Aug 23, 2018 at 07:47:01PM +0300, Alexey Budankov wrote: SNIP > > static volatile int done; > @@ -528,13 +530,85 @@ static struct perf_event_header finished_round_event = { > .type = PERF_RECORD_FINISHED_ROUND, > }; > > +static int record__mmap_read_sync(int trace_fd, struct

Re: [PATCH v2 5/9] mtd: nand: atmel: fix OF child-node lookup

2018-08-27 Thread Johan Hovold
On Mon, Aug 27, 2018 at 10:28:20AM +0200, Boris Brezillon wrote: > Hi Johan > > On Mon, 27 Aug 2018 10:21:49 +0200 > Johan Hovold wrote: > > > Use the new of_get_compatible_child() helper to lookup the nfc child > > node instead of using of_find_compatible_node(), which searches the > > entire

Re: [PATCH 3/4] mm/tlb, x86/mm: Support invalidating TLB caches for RCU_TABLE_FREE

2018-08-27 Thread Nicholas Piggin
On Mon, 27 Aug 2018 18:09:50 +1000 Benjamin Herrenschmidt wrote: > On Mon, 2018-08-27 at 18:04 +1000, Nicholas Piggin wrote: > > > Yes.. I see that. tlb_remove_check_page_size_change() really is a rather > > > ugly thing, it can cause loads of TLB flushes. Do you really _have_ to > > > do that?

Re: [PATCH 1/2] devres: provide devm_kstrdup_const()

2018-08-27 Thread Bartosz Golaszewski
2018-08-27 10:42 GMT+02:00 Joe Perches : > On Mon, 2018-08-27 at 10:21 +0200, Bartosz Golaszewski wrote: >> Provide a resource managed version of kstrdup_const(). This variant >> internally calls devm_kstrdup() on pointers that are outside of >> .rodata section. Also provide a corresponding

[PATCH 5/5] perf/hw_breakpoint: Simplify breakpoint enable in perf_event_modify_breakpoint

2018-08-27 Thread Jiri Olsa
We can safely enable the breakpoint back for both the fail and success paths by checking only the bp->attr.disabled, which either holds the new 'requested' disabled state or the original breakpoint state. Suggested-by: Oleg Nesterov Acked-by: Oleg Nesterov Link:

[PATCH 2/5] perf/hw_breakpoint: Modify breakpoint even if the new attr has disabled set

2018-08-27 Thread Jiri Olsa
We need to change the breakpoint even if the attr with new fields has disabled set to true. Current code prevents following user code to change the breakpoint address: ptrace(PTRACE_POKEUSER, child, offsetof(struct user, u_debugreg[0]), addr_1) ptrace(PTRACE_POKEUSER, child, offsetof(struct

[PATCHv4 0/5] perf/hw_breakpoint: Fix breakpoint modify

2018-08-27 Thread Jiri Olsa
hi, Milind reported that modify_user_hw_breakpoint wouldn't allow the breakpoint changing if the new attr had 'disabled' set to true. I found a case where it actualy prevents ptrace user interface to change the breakpoint. It's described in patch 1 as perf test, patch 2 is the breakpoint code

[PATCH 3/5] perf/hw_breakpoint: Remove superfluous bp->attr.disabled = 0

2018-08-27 Thread Jiri Olsa
Once the breakpoint was succesfully modified, the attr->disabled value is in bp->attr.disabled. So there's no reason to set it again, removing that. Acked-by: Oleg Nesterov Acked-by: Frederic Weisbecker Link: http://lkml.kernel.org/n/tip-v5oaellzsmyszv3rfucux...@git.kernel.org Signed-off-by:

[PATCH 1/5] perf tests: Add breakpoint modify tests

2018-08-27 Thread Jiri Olsa
Adding to tests that aims on kernel breakpoint modification bugs. First test creates HW breakpoint, tries to change it and checks it was properly changed. It aims on kernel issue that prevents HW breakpoint to be changed via ptrace interface. The first test forks, the child sets itself as ptrace

[PATCH 4/5] perf/hw_breakpoint: Enable breakpoint in modify_user_hw_breakpoint

2018-08-27 Thread Jiri Olsa
Currently we enable the breakpoint back only if the breakpoint modification was successful. If it fails we can leave the breakpoint in disabled state with attr->disabled == 0. We can safely enable the breakpoint back for both the fail and success paths by checking the bp->attr.disabled, which

Re: [PATCH v2 2/2]: perf record: enable asynchronous trace writing

2018-08-27 Thread Alexey Budankov
Hi, On 27.08.2018 11:34, Jiri Olsa wrote: > On Thu, Aug 23, 2018 at 07:47:01PM +0300, Alexey Budankov wrote: > > SNIP > >> diff --git a/tools/perf/util/mmap.c b/tools/perf/util/mmap.c >> index e71d46cb01cc..c8b921c88a5d 100644 >> --- a/tools/perf/util/mmap.c >> +++ b/tools/perf/util/mmap.c >>

Re: [PATCH v5 4/4] x86/boot/KASLR: Limit kaslr to choosing the immovable memory

2018-08-27 Thread Baoquan He
On 08/27/18 at 01:35pm, Baoquan He wrote: > Is it possible to take num_immovable_mem out from the #ifdef > CONFIG_MEMORY_HOTREMOVE region so that you can check it earlier to see > if the old way need be taken? This way, we can reduce one level of > indentation in the for loop. Just personal

Re: [PATCH] soc: ti: pm33xx: Enable DS0 for the platforms on which it is functional

2018-08-27 Thread Johan Hovold
On Wed, Aug 22, 2018 at 07:22:20AM -0700, Tony Lindgren wrote: > * J, KEERTHY [180822 11:11]: > > On 8/22/2018 2:13 PM, Johan Hovold wrote: > > > Yes, and a blacklist would make much more sense for something like this > > > if where talking about specific boards. > > > > Black list is easier

Re: [PATCH v5 5/5] iommu/arm-smmu-v3: add bootup option "iommu.non_strict"

2018-08-27 Thread Leizhen (ThunderTown)
On 2018/8/23 1:02, Robin Murphy wrote: > On 15/08/18 02:28, Zhen Lei wrote: >> Add a bootup option to make the system manager can choose which mode to >> be used. The default mode is strict. >> >> Signed-off-by: Zhen Lei >> --- >> Documentation/admin-guide/kernel-parameters.txt | 13

Re: [PATCH v2] mtd: rawnand: denali: do not pass zero maxchips to nand_scan()

2018-08-27 Thread Boris Brezillon
On Mon, 27 Aug 2018 16:01:41 +0900 Masahiro Yamada wrote: > Commit 49aa76b16676 ("mtd: rawnand: do not execute nand_scan_ident() > if maxchips is zero") gave a new meaning for calling nand_scan_ident() > with maxchips=0. > > It is a special usage for some drivers such as docg4, but actually >

Re: [PATCH] x86/microcode: allow non-root reading of microcode version and processor flags

2018-08-27 Thread Borislav Petkov
On Mon, Aug 27, 2018 at 01:01:41PM +0800, Jacek Tomaka wrote: > Not sure if you are leaning towards removing microcode/version interface > altogether or you are writing your thoughts to justify merging this patch. The latter. We cannot *ever* remove sysfs files. Never. -- Regards/Gruss,

Re: [PATCH 3/4] mm/tlb, x86/mm: Support invalidating TLB caches for RCU_TABLE_FREE

2018-08-27 Thread Peter Zijlstra
On Mon, Aug 27, 2018 at 03:00:08PM +1000, Nicholas Piggin wrote: > On Fri, 24 Aug 2018 13:39:53 +0200 > Peter Zijlstra wrote: > > On Fri, Aug 24, 2018 at 01:32:14PM +0200, Peter Zijlstra wrote: > > > Hurm.. look at commit: > > > > > > e77b0852b551 ("mm/mmu_gather: track page size with mmu

Re: [PATCH v2 5/9] mtd: nand: atmel: fix OF child-node lookup

2018-08-27 Thread Boris Brezillon
Hi Johan On Mon, 27 Aug 2018 10:21:49 +0200 Johan Hovold wrote: > Use the new of_get_compatible_child() helper to lookup the nfc child > node instead of using of_find_compatible_node(), which searches the > entire tree from a given start node and thus can return an unrelated > (i.e. non-child)

[PATCH v5 3/3] mmc: sdhci-of-dwcmshc: solve 128MB DMA boundary limitation

2018-08-27 Thread Jisheng Zhang
When using DMA, if the DMA addr spans 128MB boundary, we have to split the DMA transfer into two so that each one doesn't exceed the boundary. Signed-off-by: Jisheng Zhang --- drivers/mmc/host/sdhci-of-dwcmshc.c | 41 + 1 file changed, 41 insertions(+) diff --git

Re: [PATCH v2 1/2]: perf util: map data buffer for preserving collected data

2018-08-27 Thread Jiri Olsa
On Thu, Aug 23, 2018 at 07:42:09PM +0300, Alexey Budankov wrote: > > The data buffer and accompanying AIO control block are allocated at > perf_mmap object and the mapped data buffer size is equal to > the kernel one. > > The buffer is then used to preserve profiling data ready for dumping >

[PATCH 1/1] Preventive patch in the pin control subsystem to handle NULL check.

2018-08-27 Thread Srikanth K H
If the pin descriptor requested for the physical pin fails then the descriptor is dereferenced without checking for its validity which may lead to crash, hence added preventive code to check for NULL and accordingly dereference. Signed-off-by: Srikanth K H --- drivers/pinctrl/pinconf.c | 5

Re: [PATCH v2 2/2]: perf record: enable asynchronous trace writing

2018-08-27 Thread Jiri Olsa
On Thu, Aug 23, 2018 at 07:47:01PM +0300, Alexey Budankov wrote: SNIP > static int record__mmap_read_evlist(struct record *rec, struct perf_evlist > *evlist, > bool overwrite) > { > u64 bytes_written = rec->bytes_written; > - int i; > - int rc =

[PATCHv2] kmemleak: Add option to print warnings to dmesg

2018-08-27 Thread Vincent Whitchurch
Currently, kmemleak only prints the number of suspected leaks to dmesg but requires the user to read a debugfs file to get the actual stack traces of the objects' allocation points. Add an option to print the full object information to dmesg too. This allows easier integration of kmemleak into

Re: [PATCH v2 1/2] dt-bindings: PCI: meson: add DT bindings for Amlogic Meson PCIe controller

2018-08-27 Thread Hanjie Lin
On 2018/8/24 16:22, Jerome Brunet wrote: > On Fri, 2018-08-24 at 15:36 +0800, Hanjie Lin wrote: >> From: Yue Wang >> >> The Amlogic Meson PCIe host controller is based on the Synopsys DesignWare >> PCI core. This patch adds documentation for the DT bindings in Meson PCIe >> controller. >> >>

Re: [PATCH v2 1/2]: perf util: map data buffer for preserving collected data

2018-08-27 Thread Alexey Budankov
Hi, On 27.08.2018 11:33, Jiri Olsa wrote: > On Thu, Aug 23, 2018 at 07:42:09PM +0300, Alexey Budankov wrote: > > SNIP > >> diff --git a/tools/perf/util/mmap.c b/tools/perf/util/mmap.c >> index fc832676a798..e71d46cb01cc 100644 >> --- a/tools/perf/util/mmap.c >> +++ b/tools/perf/util/mmap.c >>

[PATCH] checkpatch: remove GCC_BINARY_CONSTANT warning

2018-08-27 Thread Christophe Leroy
This warning was there to avoid the use of 0bxxx values as they are not supported by gcc prior to v4.3 Since commit cafa0010cd51f ("Raise the minimum required gcc version to 4.6"), it's not an issue anymore and using such values can increase readability of code. Signed-off-by: Christophe Leroy

Re: [ANNOUNCE] 4.4.148-rt165

2018-08-27 Thread Daniel Wagner
Hi, > Known issues: > > - 'stress-ng --ptrace 4' is able to trigger a latency spike of > several ms. Usually around 2 - 3ms on two different x86_64 boxes I can > test on. 4.9-rt seems to have the same problem. 4.14-rt and 4.16-rt > work just fine. Still debugging the issue. I have a

Re: [PATCH v2] mtd: rawnand: denali: do not pass zero maxchips to nand_scan()

2018-08-27 Thread Miquel Raynal
Hi Masahiro, Masahiro Yamada wrote on Mon, 27 Aug 2018 16:01:41 +0900: > Commit 49aa76b16676 ("mtd: rawnand: do not execute nand_scan_ident() > if maxchips is zero") gave a new meaning for calling nand_scan_ident() > with maxchips=0. > > It is a special usage for some drivers such as docg4,

Re: [PATCH v2] ARM: dts: imx6qdl-wandboard: Add stdout-path

2018-08-27 Thread Shawn Guo
On Tue, Aug 21, 2018 at 12:07:18AM +0300, Tuomas Tynkkynen wrote: > Setting a stdout-path in the .dtb is convenient because then the user > gets a serial console on the RS-232 connector without any extra effort > of figuring out the relevant 'console=' boot parameter. > > Reviewed-by: Fabio

Re: [PATCH v2 2/3] xfs: Prevent multiple wakeups of the same log space waiter

2018-08-27 Thread Christoph Hellwig
On Mon, Aug 27, 2018 at 10:21:34AM +1000, Dave Chinner wrote: > tl; dr: Once you pass a certain point, ramdisks can be *much* slower > than SSDs on journal intensive workloads like AIM7. Hence it would be > useful to see if you have the same problems on, say, high > performance nvme SSDs. Note

Re: [PATCH] mtd: rawnand: atmel: use struct_size() in devm_kzalloc()

2018-08-27 Thread Boris Brezillon
Hi Gustavo, On Thu, 23 Aug 2018 20:09:38 -0500 "Gustavo A. R. Silva" wrote: > One of the more common cases of allocation size calculations is finding > the size of a structure that has a zero-sized array at the end, along > with memory for some number of elements for that array. For example: >

Re: [PATCH v6 1/2] mm: migration: fix migration of huge PMD shared pages

2018-08-27 Thread Michal Hocko
On Fri 24-08-18 11:08:24, Mike Kravetz wrote: > On 08/24/2018 01:41 AM, Michal Hocko wrote: > > On Thu 23-08-18 13:59:16, Mike Kravetz wrote: > > > > Acked-by: Michal Hocko > > > > One nit below. > > > > [...] > >> diff --git a/mm/hugetlb.c b/mm/hugetlb.c > >> index 3103099f64fd..a73c5728e961

Re: [PATCH V6 5/9] mmc: sdhci: Add 32-bit block count support for v4 mode

2018-08-27 Thread Chunyan Zhang
On 27 August 2018 at 15:07, Adrian Hunter wrote: > On 24/08/18 12:20, Chunyan Zhang wrote: >> Host Controller Version 4.10 re-defines SDMA System Address register >> as 32-bit Block Count for v4 mode, and SDMA uses ADMA System >> Address register (05Fh-058h) instead if v4 mode is enabled. Also >>

  1   2   3   4   5   6   7   8   9   10   >