Re: [PATCH v2] kobject: to use pr_warn replace KERN_WARNING

2018-11-06 Thread Rafael J. Wysocki
On Tue, Nov 6, 2018 at 8:58 AM Joe Perches wrote: > > On Tue, 2018-11-06 at 08:49 +0100, Rafael J. Wysocki wrote: > > On Tue, Nov 6, 2018 at 3:42 AM Bo YU wrote: > > > Fix warning form checkpatch, use pr_warn replace KERN_WARNING > > > > > > Signed-off-by: Bo YU > > > > First off, IMO, you shoul

Re: [PATCH v2 01/17] thermal: add thermal_zone_set_mode() helper

2018-11-06 Thread Zhang Rui
On 三, 2018-10-17 at 17:52 +0200, Bartlomiej Zolnierkiewicz wrote: > In order to remove the code duplication and prepare for further > changes: > > * Add thermal_zone_set_mode() helper. Then update core code and >   drivers to use it. > > There should be no functional changes caused by this patch.

Re: [PATCH] fls: Change parameter to unsigned int

2018-11-06 Thread Geert Uytterhoeven
On Mon, Nov 5, 2018 at 11:11 PM Matthew Wilcox wrote: > When testing in userspace, UBSAN pointed out that shifting into the sign > bit is undefined behaviour. It doesn't really make sense to ask for the > highest set bit of a negative value, so just turn the argument type into > an unsigned int.

Re: [PATCH] lib/raid6: Fix arm64 test build

2018-11-06 Thread Ard Biesheuvel
(+ Catalin, Will) On 6 November 2018 at 01:14, Jeremy Linton wrote: > The lib/raid6/test fails to build the neon objects > on arm64 because the correct machine type is 'aarch64'. > > Once this is correctly enabled, the neon recovery objects > need to be added to the build. > > Signed-off-by: Jere

Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-11-06 Thread Konstantin Khlebnikov
On 06.11.2018 8:38, Arun KS wrote: Any comments? Looks good. Except unclear motivation behind this change. This should be in comment of one of patch. Reviewed-by: Konstantin Khlebnikov Regards, Arun On 2018-10-26 16:30, Arun KS wrote: This series convert totalram_pages, totalhigh_pages a

Re: [PATCH v3 6/7] x86/alternatives: use temporary mm for text poking

2018-11-06 Thread Peter Zijlstra
On Mon, Nov 05, 2018 at 06:04:42PM +, Nadav Amit wrote: > From: Peter Zijlstra > Sent: November 5, 2018 at 1:30:41 PM GMT > > To: Nadav Amit > > Cc: Ingo Molnar , linux-kernel@vger.kernel.org, > > x...@kernel.org, H. Peter Anvin , Thomas Gleixner > > , Borislav Petkov , Dave Hansen > > , An

Re: kstrdup_quotable_cmdline and gfp flags

2018-11-06 Thread Michal Hocko
On Mon 05-11-18 22:32:07, Rasmus Villemoes wrote: > kstrdup_quotable_cmdline takes gfp flags and passes those on to > kstrdup_quotable, but before that it has done a kmalloc(PAGE_SIZE) with > a hard-coded GFP_KERNEL. There is one caller of kstrdup_quotable_cmdline > which passes GFP_ATOMIC, and the

Re: perf script doesn't dump a normal call trace

2018-11-06 Thread Xin Long
On Mon, Nov 5, 2018 at 5:49 PM Jiri Olsa wrote: > > On Mon, Nov 05, 2018 at 03:20:15PM +0900, Xin Long wrote: > > SNIP > > > > > > [root@ibm-x3650m4-02 perf]# ./perf probe 'consume_skb' > > > > > [root@ibm-x3650m4-02 perf]# ./perf record -g -e probe:consume_skb* > > > > > -aR ^C > > > > > > > > >

Re: [PATCH 1/2] firmware: add nowarn variant of request_firmware_nowait()

2018-11-06 Thread kbuild test robot
Hi Lucas, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.20-rc1 next-20181106] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH v2] mm: Create the new vm_fault_t type

2018-11-06 Thread Mike Rapoport
On Tue, Nov 06, 2018 at 01:19:34PM +0530, Souptick Joarder wrote: > Page fault handlers are supposed to return VM_FAULT codes, > but some drivers/file systems mistakenly return error > numbers. Now that all drivers/file systems have been converted > to use the vm_fault_t return type, change the typ

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-06 Thread Michal Hocko
On Tue 06-11-18 08:22:16, Baoquan He wrote: > On 11/05/18 at 06:10pm, Michal Hocko wrote: > > On Mon 05-11-18 22:23:08, Baoquan He wrote: > > > On 11/05/18 at 01:38pm, Michal Hocko wrote: > > > > On Mon 05-11-18 18:25:20, Baoquan He wrote: > > > > > Hi Michal, > > > > > > > > > > On 11/05/18 at 10

Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-11-06 Thread Arun KS
On 2018-11-06 13:47, Konstantin Khlebnikov wrote: On 06.11.2018 8:38, Arun KS wrote: Any comments? Looks good. Except unclear motivation behind this change. This should be in comment of one of patch. totalram_pages, zone->managed_pages and totalhigh_pages are sometimes modified outside mana

Re: [PATCH v2] mm: Create the new vm_fault_t type

2018-11-06 Thread Souptick Joarder
On Tue, Nov 6, 2018 at 1:56 PM Mike Rapoport wrote: > > On Tue, Nov 06, 2018 at 01:19:34PM +0530, Souptick Joarder wrote: > > Page fault handlers are supposed to return VM_FAULT codes, > > but some drivers/file systems mistakenly return error > > numbers. Now that all drivers/file systems have bee

Re: [PATCH] MAINTAINERS: add maintainer for C-SKY drivers

2018-11-06 Thread Daniel Lezcano
On 06/11/2018 08:45, Guo Ren wrote: > There are two intc drivers and two clocksource drivers, also include > related dt-bindings' documentations. > > Signed-off-by: Guo Ren Acked-by: Daniel Lezcano > --- > MAINTAINERS | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/MAINTAINERS

Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-11-06 Thread Konstantin Khlebnikov
On 06.11.2018 11:30, Arun KS wrote: On 2018-11-06 13:47, Konstantin Khlebnikov wrote: On 06.11.2018 8:38, Arun KS wrote: Any comments? Looks good. Except unclear motivation behind this change. This should be in comment of one of patch. totalram_pages, zone->managed_pages and totalhigh_pa

Re: [PATCH 3/3] lockdep: Use line-buffered printk() for lockdep messages.

2018-11-06 Thread Petr Mladek
On Fri 2018-11-02 14:36:29, Peter Zijlstra wrote: > On Fri, Nov 02, 2018 at 10:31:57PM +0900, Tetsuo Handa wrote: > > syzbot is sometimes getting mixed output like below due to concurrent > > printk(). Mitigate such output by using line-buffered printk() API. > > > > RCU used illegally from idle

Re: [PATCH] arch/arm64 : fix error in dump_backtrace

2018-11-06 Thread Mark Rutland
On Tue, Nov 06, 2018 at 03:19:35PM +0800, Zhaoyang Huang wrote: > From: Zhaoyang Huang > > In some cases, the instruction of "bl foo1" will be the last one of the > foo2[1], which will cause the lr be the first instruction of the adjacent > foo3[2]. Hence, the backtrace will show the weird result

Re: PEBS level 2/3 breaks dwarf unwinding! [WAS: Re: Broken dwarf unwinding - wrong stack pointer register value?]

2018-11-06 Thread Jiri Olsa
On Mon, Nov 05, 2018 at 04:10:37PM -0800, Andi Kleen wrote: > > > > - PMU triggers interrupt and PEBS stores RIP etc. > > > > - code continous to execute, possibly changing the stack > > > > > > I dont think the code continues to execute.. the stack is ok > > > > Are you sure about this? I mean,

Re: [PATCH] slab.h: Avoid using & for logical and of booleans

2018-11-06 Thread Vlastimil Babka
On 11/5/18 9:40 PM, Bart Van Assche wrote: > This patch suppresses the following sparse warning: > > ./include/linux/slab.h:332:43: warning: dubious: x & !y > > Fixes: 1291523f2c1d ("mm, slab/slub: introduce kmalloc-reclaimable caches") > Cc: Vlastimil Babka > Cc: Mel Gorman > Cc: Christoph Lam

Re: [RFC PATCH v2 1/1] pipe: busy wait for pipe

2018-11-06 Thread Mel Gorman
On Mon, Nov 05, 2018 at 03:40:40PM -0800, Subhra Mazumdar wrote: > > On 11/5/18 2:08 AM, Mel Gorman wrote: > > Adding Al Viro as per get_maintainers.pl. > > > > On Tue, Sep 25, 2018 at 04:32:40PM -0700, subhra mazumdar wrote: > > > Introduce pipe_ll_usec field for pipes that indicates the amount

[RFC PATCH v3 08/13] genirq/msi: Add support for allocating single MSI for a device

2018-11-06 Thread Lokesh Vutla
Previously all MSIs for a device are allocated in one go by calling msi_domain_alloc_irq() from a bus layer. This might not be the case when a device is trying to allocate interrupts dynamically based on a request to it. So introduce msi_domain_alloc/free_irq() apis to allocate a single msi. prepa

[RFC PATCH v3 10/13] soc: ti: Add MSI domain support for K3 Interrupt Aggregator

2018-11-06 Thread Lokesh Vutla
With the system coprocessor managing the range allocation of the inputs to Interrupt Aggregator, it is difficult to represent the device IRQs from DT. The suggestion is to use MSI in such cases where devices wants to allocate and group interrupts dynamically. Create a MSI domain bus layer that al

[PATCH v3 00/13] Add support for TISCI irqchip drivers

2018-11-06 Thread Lokesh Vutla
TISCI abstracts the handling of IRQ routes where interrupt sources are not directly connected to host interrupt controller. This series adds support for: - TISCI commands needed for IRQ configuration - Interrupt Router(INTR) and Interrupt Aggregator(INTA) drivers More information on TISCI IRQ mana

[PATCH v3 04/13] firmware: ti_sci: Add RM mapping table for am654

2018-11-06 Thread Lokesh Vutla
From: Peter Ujfalusi Add the resource mapping table for AM654 SoC as defined in http://downloads.ti.com/tisci/esd/latest/5_soc_doc/am6x/resasg_types.html Introduce a new compatible for AM654 "ti,am654-sci" for using this resource map table. Reviewed-by: Rob Herring Signed-off-by: Peter Ujfalusi

[RFC PATCH v3 13/13] soc: ti: am6: Enable interrupt controller drivers

2018-11-06 Thread Lokesh Vutla
Select all the TISCI dependent interrupt controller drivers for AM6 SoC. Suggested-by: Marc Zyngier Signed-off-by: Lokesh Vutla --- Changes since v2: - None drivers/soc/ti/Kconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/soc/ti/Kconfig b/drivers/soc/ti/Kconfig index 76404

[PATCH v3 01/13] firmware: ti_sci: Add support to get TISCI handle using of_phandle

2018-11-06 Thread Lokesh Vutla
From: Grygorii Strashko TISCI has been updated to have support for Resource management(likes interrupts etc..). And there can be multiple device instances of a resource type in a SoC. So every driver corresponding to a resource type should get a TISCI handle so that it can make TISCI calls. And e

[PATCH v3 02/13] firmware: ti_sci: Add support for RM core ops

2018-11-06 Thread Lokesh Vutla
TISCI provides support for getting the resources(IRQ, RING etc..) assigned to a specific device. These resources can be handled by the client and in turn sends TISCI cmd to configure the resources. It is very important that client should keep track on usage of these resources. Add support for TIS

[PATCH v3 03/13] firmware: ti_sci: Add support for IRQ management

2018-11-06 Thread Lokesh Vutla
TISCI abstracts the handling of IRQ routes where interrupt sources are not directly connected to interrupt controller. Add support for the set of TISCI commands for requesting and releasing IRQs. Signed-off-by: Lokesh Vutla --- Changes since v3: - None drivers/firmware/ti_sci.c | 4

[PATCH v3 06/13] dt-bindings: irqchip: Introduce TISCI Interrupt router bindings

2018-11-06 Thread Lokesh Vutla
Add the DT binding documentation for Interrupt router driver. Signed-off-by: Lokesh Vutla --- Changes since v2: - Dropped interrupt-parent from reqired properties description - Updated the interrupt cells to 4. .../interrupt-controller/ti,sci-intr.txt | 84 +++ MAINTAINERS

[RFC PATCH v3 12/13] irqchip: ti-sci-inta: Add support for Interrupt Aggregator driver

2018-11-06 Thread Lokesh Vutla
Texas Instruments' K3 generation SoCs has an IP Interrupt Aggregator which is an interrupt controller that does the following: - Converts events to interrupts that can be understood by an interrupt router. - Allows for multiplexing of events to interrupts. Configuration of the interrupt aggregat

[PATCH v3 07/13] irqchip: ti-sci-intr: Add support for Interrupt Router driver

2018-11-06 Thread Lokesh Vutla
Texas Instruments' K3 generation SoCs has an IP Interrupt Router that does allows for multiplexing of input interrupts to host interrupt controller. Interrupt Router inputs are either from a peripheral or from an Interrupt Aggregator which is another interrupt controller. Configuration of the inte

[PATCH v3 05/13] firmware: ti_sci: Add helper apis to manage resources

2018-11-06 Thread Lokesh Vutla
Each resource with in the device can be uniquely identified by a type and subtype as defined by TISCI. Since this is generic across the devices, resource allocation also can be made generic instead of each client driver handling the resource. So add helper apis to manage the resource. Signed-off-b

[RFC PATCH v3 11/13] dt-bindings: irqchip: Introduce TISCI Interrupt Aggregator bindings

2018-11-06 Thread Lokesh Vutla
Add the DT binding documentation for Interrupt Aggregator driver. Signed-off-by: Lokesh Vutla --- Changes since v2: - None .../interrupt-controller/ti,sci-inta.txt | 74 +++ MAINTAINERS | 1 + 2 files changed, 75 insertions(+) create mode

[RFC PATCH v3 09/13] genirq/msi: Add support for .msi_unprepare callback

2018-11-06 Thread Lokesh Vutla
Add an optional callback .msi_unprepare to struct msi_domain_ops. This is used to clear any effect that is done by .msi_prepare callback. Signed-off-by: Lokesh Vutla --- Changes since v2: - New patch include/linux/msi.h | 3 +++ kernel/irq/msi.c| 10 ++ 2 files changed, 13 insertio

Re: [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic

2018-11-06 Thread Arun KS
On 2018-11-06 14:07, Konstantin Khlebnikov wrote: On 06.11.2018 11:30, Arun KS wrote: On 2018-11-06 13:47, Konstantin Khlebnikov wrote: On 06.11.2018 8:38, Arun KS wrote: Any comments? Looks good. Except unclear motivation behind this change. This should be in comment of one of patch. tota

Re: [PATCH 3/4] of/property: Introduce of_fwnode_name()

2018-11-06 Thread Heikki Krogerus
On Mon, Nov 05, 2018 at 12:50:02PM -0600, Rob Herring wrote: > On Mon, Nov 5, 2018 at 3:17 AM Heikki Krogerus > wrote: > > > > Instead of always being forced to read the "name" property > > in fwnode_name() with of_nodes, implementing the fwnode > > operation meant for getting the node name. > > >

[PATCH] rtc: pcf2127: fix a kmemleak caused in pcf2127_i2c_gather_write

2018-11-06 Thread Xulin Sun
pcf2127_i2c_gather_write() allocates memory as local variable for i2c_master_send(), after finishing the master transfer, the allocated memory should be freed. The kmemleak is reported: unreferenced object 0x80231e7dba80 (size 64): comm "hwclock", pid 27762, jiffies 4296880075 (age 356.944s)

Re: [RFC PATCH v4 01/13] ktask: add documentation

2018-11-06 Thread Peter Zijlstra
On Mon, Nov 05, 2018 at 11:55:46AM -0500, Daniel Jordan wrote: > +Concept > +=== > + > +ktask is built on unbound workqueues to take advantage of the thread > management > +facilities it provides: creation, destruction, flushing, priority setting, > and > +NUMA affinity. > + > +A little termi

[PATCH v15 0/3]: perf: reduce data loss when profiling highly parallel CPU bound workloads

2018-11-06 Thread Alexey Budankov
Currently in record mode the tool implements trace writing serially. The algorithm loops over mapped per-cpu data buffers and stores ready data chunks into a trace file using write() system call. At some circumstances the kernel may lack free space in a buffer because the other buffer's half

Re: [PATCH] mm, slab: remove unnecessary unlikely()

2018-11-06 Thread Vlastimil Babka
On 11/6/18 6:38 AM, Dmitry Vyukov wrote: > On Mon, Nov 5, 2018 at 11:18 AM, Vlastimil Babka wrote: >> +CC Dmitry >> >> On 11/4/18 1:50 PM, Yangtao Li wrote: >>> WARN_ON() already contains an unlikely(), so it's not necessary to use >>> unlikely. >>> >>> Signed-off-by: Yangtao Li >> >> Acked-by: V

Re: [PATCH] arch/arm64 : fix error in dump_backtrace

2018-11-06 Thread Daniel Thompson
On Tue, Nov 06, 2018 at 08:39:01AM +, Mark Rutland wrote: > On Tue, Nov 06, 2018 at 03:19:35PM +0800, Zhaoyang Huang wrote: > > From: Zhaoyang Huang > > > > In some cases, the instruction of "bl foo1" will be the last one of the > > foo2[1], which will cause the lr be the first instruction of

Re: [PATCH v2] mm: Create the new vm_fault_t type

2018-11-06 Thread Mike Rapoport
On Tue, Nov 06, 2018 at 02:04:54PM +0530, Souptick Joarder wrote: > On Tue, Nov 6, 2018 at 1:56 PM Mike Rapoport wrote: > > > > On Tue, Nov 06, 2018 at 01:19:34PM +0530, Souptick Joarder wrote: > > > Page fault handlers are supposed to return VM_FAULT codes, > > > but some drivers/file systems mis

[PATCH v15 1/3]: perf util: map data buffer for preserving collected data

2018-11-06 Thread Alexey Budankov
The map->data buffer is used to preserve map->base profiling data for writing to disk. AIO map->cblock is used to queue corresponding map->data buffer for asynchronous writing. Signed-off-by: Alexey Budankov --- Changes in v15: - implemented libaio feature check and defined HAVE_AIO_SUPPORT

Re: [REGRESSION] OCTEON MMC driver failure with v4.19

2018-11-06 Thread Aaro Koskinen
Hi, On Tue, Nov 06, 2018 at 07:27:24AM +0100, Christoph Hellwig wrote: > On Tue, Nov 06, 2018 at 12:06:32AM +0200, Aaro Koskinen wrote: > > With the below change, the MMC card probe seems to with v4.19. But it > > feels a bit hackish, don't you think... Is there some obvious simple > > fix that I'

[PATCH v15 2/3]: perf record: enable asynchronous trace writing

2018-11-06 Thread Alexey Budankov
Trace file offset is read once before mmaps iterating loop and written back after all performance data enqueued for aio writing. Trace file offset is incremented linearly after every successful aio write operation. record__aio_sync() blocks till completion of started AIO operation and then pr

Re: [PATCH 3/3] lockdep: Use line-buffered printk() for lockdep messages.

2018-11-06 Thread Sergey Senozhatsky
On (11/06/18 09:38), Petr Mladek wrote: > > If you would want to avoid buffering, you could set the number > of buffers to zero. Then it would always fallback to > the direct printk(). This printk-fallback makes me wonder if 'cont' really can ever go away. We would totally break cont printk-s tha

Re: [PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree to avoid resource leak

2018-11-06 Thread Daniel Lezcano
Hi Anson, On 06/11/2018 02:38, Anson Huang wrote: > Hi, Daniel > > Best Regards! > Anson Huang > >> -Original Message- >> From: Daniel Lezcano [mailto:daniel.lezc...@linaro.org] >> Sent: 2018年11月5日 21:35 >> To: Anson Huang ; t...@linutronix.de; >> linux-kernel@vger.kernel.org >> Cc: dl

Re: [PATCH v2] bit_spinlock: introduce smp_cond_load_relaxed

2018-11-06 Thread Peter Zijlstra
On Mon, Nov 05, 2018 at 10:49:21PM +, Will Deacon wrote: > diff --git a/include/asm-generic/bitops/lock.h > b/include/asm-generic/bitops/lock.h > index 3ae021368f48..9de8d3544630 100644 > --- a/include/asm-generic/bitops/lock.h > +++ b/include/asm-generic/bitops/lock.h > @@ -6,6 +6,15 @@ > #i

[PATCH v15 3/3]: perf record: extend trace writing to multi AIO

2018-11-06 Thread Alexey Budankov
Multi AIO trace writing allows caching more kernel data into userspace memory postponing trace writing for the sake of overall profiling data thruput increase. It could be seen as kernel data buffer extension into userspace memory. With aio option value different from 0, default value is 1, t

Re: [PATCH v6 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-11-06 Thread Liang Yang
On 2018/11/5 23:53, Boris Brezillon wrote: On Fri, 2 Nov 2018 00:42:21 +0800 Jianxin Pan wrote: +#define NFC_REG_CMD0x00 +#define NFC_CMD_DRD(0x8 << 14) +#define NFC_CMD_IDLE (0xc << 14) +#define NFC_CMD_DWR(0x4 << 14) +#define NFC_CMD_CLE

[char-misc-next 1/3] mei: hbm: drop BUG() from the hbm handler

2018-11-06 Thread Tomas Winkler
Drop BUG() from the hbm handler in order not to crash the whole kernel on faulty firmware implementation. Instead of it, just return an error resulting into link reset. There is no any known issue of faulty firmware in this matter, the change is just to ease the development. Signed-off-by: Tomas W

[char-misc-next 3/3] mei: expedite ioctl return on the notify set operation error

2018-11-06 Thread Tomas Winkler
From: Alexander Usyskin The notify set operation ioctl will wait till timeout is expired even in case when the FW returned an error. Check the status field of the client object in wait_event_timeout() to determine if the caller can return earlier. Signed-off-by: Alexander Usyskin Signed-off-by:

RE: [PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree to avoid resource leak

2018-11-06 Thread Anson Huang
Hi, Daniel Best Regards! Anson Huang > -Original Message- > From: Daniel Lezcano [mailto:daniel.lezc...@linaro.org] > Sent: 2018年11月6日 17:06 > To: Anson Huang ; t...@linutronix.de; > linux-kernel@vger.kernel.org > Cc: dl-linux-imx > Subject: Re: [PATCH V2 2/2] clocksource: imx-gpt: add n

[PATCH] fuse: Put leaked request on error path of fuse_retrieve()

2018-11-06 Thread Kirill Tkhai
fuse_request_send_notify_reply() may fail, and this case it remains leaked (fuse_retrieve_end(), which is called on error path, does not do that). Also, fc->num_waiting, will never be decremented, and fuse_wait_aborted() will never finish. So, put the request patently. Signed-off-by: Kirill Tkhai

[char-misc-next 2/3] mei: flush queues by the host client only

2018-11-06 Thread Tomas Winkler
From: Alexander Usyskin During queues flush, the me client in most cases is already unlinked hence the me client id is unavailable. The host client structure pointer is enough for identification. The function mei_cl_cmp_id() is dropped as it has no more usage. Signed-off-by: Alexander Usyskin S

[PATCH] fuse: Remove stale comment in end_requests()

2018-11-06 Thread Kirill Tkhai
Function end_requests() does not take fc->lock. Signed-off-by: Kirill Tkhai --- fs/fuse/dev.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c index 6fe330cc9709..fb2530ed84b3 100644 --- a/fs/fuse/dev.c +++ b/fs/fuse/dev.c @@ -2103,11 +210

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-06 Thread Baoquan He
On 11/06/18 at 09:28am, Michal Hocko wrote: > > > > > > It failed. Paste the log and patch diff here, please help check if > > > > > > I made > > > > > > any mistake on manual code change. The log is at bottom. > > > > > > > > > > The retry patch is obviously still racy, it just makes the race wi

[PATCH] ARM: dts: imx6sl: vddpu is NOT an always-on regulator

2018-11-06 Thread Anson Huang
Remove "regulator-always-on" property for vddpu regulator since it can be OFF when GPU power domain is OFF. Signed-off-by: Anson Huang --- arch/arm/boot/dts/imx6sl.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi index 9bbc5b0.

[PATCH] ARM: dts: imx6sll: remove unused property in gpc node

2018-11-06 Thread Anson Huang
The "fsl,mf-mix-wakeup-irq" is ONLY used as a temporary solution in NXP's internal tree for Mega/Fast Mix off feature after suspend, upstream kernel does NOT need it, remove it. Signed-off-by: Anson Huang --- arch/arm/boot/dts/imx6sll.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/

Re: [PATCH 1/3] coresight: etb10: Add support for CLAIM tag

2018-11-06 Thread Suzuki K Poulose
Hi Mathieu, On 05/11/2018 22:26, Mathieu Poirier wrote: Following in the footstep of what was done for other CoreSight devices, add CLAIM tag support to ETB10 in order to synchronise access to the HW between the kernel and an external agent. Thanks for spotting this. Somehow I missed the etb1

Re: [RFC PATCH v4 00/13] ktask: multithread CPU-intensive kernel work

2018-11-06 Thread Michal Hocko
On Mon 05-11-18 17:29:55, Daniel Jordan wrote: > On Mon, Nov 05, 2018 at 06:29:31PM +0100, Michal Hocko wrote: > > On Mon 05-11-18 11:55:45, Daniel Jordan wrote: > > > Michal, you mentioned that ktask should be sensitive to CPU > > > utilization[1]. > > > ktask threads now run at the lowest priori

Re: [PATCH] fuse: Put leaked request on error path of fuse_retrieve()

2018-11-06 Thread Miklos Szeredi
On Tue, Nov 6, 2018 at 10:13 AM, Kirill Tkhai wrote: > fuse_request_send_notify_reply() may fail, and this case > it remains leaked (fuse_retrieve_end(), which is called > on error path, does not do that). Also, fc->num_waiting, > will never be decremented, and fuse_wait_aborted() will > never fin

Re: [PATCH v10 5/6] arm64: zynqmp: Add DDRC node

2018-11-06 Thread Borislav Petkov
On Tue, Nov 06, 2018 at 07:46:55AM +0100, Michal Simek wrote: > I think Boris should take also this one (dt binding doc change) because > it is aligned with changes in the driver. > https://lkml.kernel.org/r/1538667328-9465-7-git-send-email-manish.nar...@xilinx.com Ok, done. -- Regards/Gruss,

Re: [PATCH v4 1/2] staging: iio: ad7780: update voltage on read

2018-11-06 Thread Ardelean, Alexandru
On Mon, 2018-11-05 at 17:14 -0200, Renato Lui Geh wrote: > The ad7780 driver previously did not read the correct device output, as > it read an outdated value set at initialization. It now updates its > voltage on read. > Looks good from my side. Alex > Signed-off-by: Renato Lui Geh > --- > Ch

Re: [PATCH v4 2/2] staging: iio: ad7780: remove unnecessary stashed voltage value

2018-11-06 Thread Ardelean, Alexandru
On Mon, 2018-11-05 at 17:16 -0200, Renato Lui Geh wrote: > This patch removes the unnecessary field int_vref_mv in ad7780_state > referring to the device's voltage. > Looks good from my side. Alex > Signed-off-by: Renato Lui Geh > --- > Changes in v3: > - removed unnecessary int_vref_mv

Re: [PATCH] fuse: Put leaked request on error path of fuse_retrieve()

2018-11-06 Thread Kirill Tkhai
On 06.11.2018 12:23, Miklos Szeredi wrote: > On Tue, Nov 6, 2018 at 10:13 AM, Kirill Tkhai wrote: >> fuse_request_send_notify_reply() may fail, and this case >> it remains leaked (fuse_retrieve_end(), which is called >> on error path, does not do that). Also, fc->num_waiting, >> will never be decr

Re: [PATCH 2/3] coresight: etf: Release CLAIM tag after disabling the HW

2018-11-06 Thread Suzuki K Poulose
On 05/11/2018 22:26, Mathieu Poirier wrote: This patch rectifies the sequence of events in function tmc_etb_disable_hw() by disabling the HW first and then releasing the CLAIM tag. Otherwise we could be corrupting the configuration done by an external agent that would have claimed the device

Re: [PATCH v6 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-11-06 Thread Boris Brezillon
On Tue, 6 Nov 2018 17:08:00 +0800 Liang Yang wrote: > On 2018/11/5 23:53, Boris Brezillon wrote: > > On Fri, 2 Nov 2018 00:42:21 +0800 > > Jianxin Pan wrote: > > > >> +#define NFC_REG_CMD 0x00 > >> +#define NFC_CMD_DRD (0x8 << 14) > >> +#define NFC_CMD_IDLE

[PATCH 0/6] fuse: Interrupt-related optimizations and improvements

2018-11-06 Thread Kirill Tkhai
This patchset consists of several parts. Patches [1-2] optimize likely case of request_end(), and make this function to take fiq->waitq.lock only, when it is really needed. This improves performance of this function completes. Patch 3 makes request_end() to call wake_up() only for not background r

[PATCH 1/6] fuse: Kill fasync only if interrupt is queued in queue_interrupt()

2018-11-06 Thread Kirill Tkhai
We should sent signal only in case of interrupt is really queued. Not a real problem, but this makes the code clearer and intuitive. Signed-off-by: Kirill Tkhai --- fs/fuse/dev.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c index fb253

[PATCH 4/6] fuse: Check for FR_SENT bit in fuse_dev_do_write()

2018-11-06 Thread Kirill Tkhai
It's not possible to have answer to a request, before the request is actually sent. Add sanity check for that. Signed-off-by: Kirill Tkhai --- fs/fuse/dev.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c index 739968ee8b0c..c603f1ebf0fd 10064

[PATCH 2/6] fuse: Optimize request_end() by not taking fiq->waitq.lock

2018-11-06 Thread Kirill Tkhai
We take global fiq->waitq.lock every time, when we are in this function, but interrupted requests are just small subset of all requests. This patch optimizes request_end() and makes it to take the lock when it's really needed. queue_interrupt() needs small change for that. After req is linked to i

[PATCH 6/6] fuse: Verify userspace asks to requeue interrupt that we really sent

2018-11-06 Thread Kirill Tkhai
When queue_interrupt() is called from fuse_dev_do_write(), it came from userspace directly. Userspace may pass any request id, even the request's we have not interrupted (or even background's request). This patch adds sanity check to make kernel safe against that. The problem is real interrupt may

[PATCH 3/6] fuse: Wake up req->waitq of only not background requests in request_end()

2018-11-06 Thread Kirill Tkhai
Currently, we wait on req->waitq in request_wait_answer() function only, and it's never used for background requests. Since wake_up() is not a light-weight macros, instead of this, it unfolds in really called function, which makes locking operations taking some cpu cycles, let's avoid its call for

[PATCH 5/6] fuse: Do some refactoring in fuse_dev_do_write()

2018-11-06 Thread Kirill Tkhai
This is needed for next patch. Signed-off-by: Kirill Tkhai --- fs/fuse/dev.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c index c603f1ebf0fd..315d395d5c02 100644 --- a/fs/fuse/dev.c +++ b/fs/fuse/dev.c @@ -1955,18 +1955,14 @@ st

Re: [PATCH] fuse: Put leaked request on error path of fuse_retrieve()

2018-11-06 Thread Miklos Szeredi
On Tue, Nov 6, 2018 at 10:25 AM, Kirill Tkhai wrote: > On 06.11.2018 12:23, Miklos Szeredi wrote: >> On Tue, Nov 6, 2018 at 10:13 AM, Kirill Tkhai wrote: >>> fuse_request_send_notify_reply() may fail, and this case >>> it remains leaked (fuse_retrieve_end(), which is called >>> on error path, doe

Re: [PATCH] fuse: Put leaked request on error path of fuse_retrieve()

2018-11-06 Thread Kirill Tkhai
On 06.11.2018 12:33, Miklos Szeredi wrote: > On Tue, Nov 6, 2018 at 10:25 AM, Kirill Tkhai wrote: >> On 06.11.2018 12:23, Miklos Szeredi wrote: >>> On Tue, Nov 6, 2018 at 10:13 AM, Kirill Tkhai wrote: fuse_request_send_notify_reply() may fail, and this case it remains leaked (fuse_retri

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-06 Thread Baoquan He
On 11/06/18 at 05:16pm, Baoquan He wrote: > On 11/06/18 at 09:28am, Michal Hocko wrote: > > > > > > > It failed. Paste the log and patch diff here, please help check > > > > > > > if I made > > > > > > > any mistake on manual code change. The log is at bottom. > > > > > > > > > > > > The retry pa

[PATCH 2/6] fuse: Add fuse_inode argument to fuse_prepare_release()

2018-11-06 Thread Kirill Tkhai
Here is preparation for next patches, which introduce new fuse_inode::lock for protection fuse_file::write_entry linked into fuse_inode::write_files. This patch just passes new argument to the function. Signed-off-by: Kirill Tkhai --- fs/fuse/cuse.c |3 ++- fs/fuse/dir.c|6 --

[PATCH 1/6] fuse: Change argument of fuse_flush_writepages()

2018-11-06 Thread Kirill Tkhai
Next patches introduce fuse_inode::lock, which will be used in __releases() and __acquires() instead of fc->lock. This patch makes this function to use argument fuse_inode instead of inode as preparation for that. Signed-off-by: Kirill Tkhai --- fs/fuse/dir.c|2 +- fs/fuse/file.c |

[PATCH 0/6] fuse: Further reducing contention of fc->lock

2018-11-06 Thread Kirill Tkhai
There was introduced fc->bg_lock to reduce the contention, and this patchset continues this efforts. This patchset introduces per fuse_inode lock to protect inode metadata, synchronization with background writes, etc. All of the above is related to a single inode, and there is no a reason, that in

[PATCH 4/6] fuse: Implement fuse_attr_version_inc()

2018-11-06 Thread Kirill Tkhai
For cleanup purpose archive repeating pattern: spin_lock(&fc->lock); fi->attr_version = ++fc->attr_version; spin_unlock(&fc->lock); into separate function. Signed-off-by: Kirill Tkhai --- fs/fuse/dir.c|8 ++-- fs/fuse/file.c | 16 fs/fus

[PATCH 6/6] fuse: Protect fuse_file::reserved_req via corresponding fuse_inode::lock

2018-11-06 Thread Kirill Tkhai
This is rather natural action after previous patches, and it just decreases load of fc->lock. Signed-off-by: Kirill Tkhai --- fs/fuse/dev.c| 10 ++ fs/fuse/fuse_i.h |5 - 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c index 3bf

Re: [PATCH v2] arm64/module: use plt section indices for relocations

2018-11-06 Thread Miroslav Benes
On Mon, 5 Nov 2018, Will Deacon wrote: > On Mon, Nov 05, 2018 at 07:53:23PM +0100, Jessica Yu wrote: > > Instead of saving a pointer to the .plt and .init.plt sections to apply > > plt-based relocations, save and use their section indices instead. > > > > The mod->arch.{core,init}.plt pointers we

[PATCH 3/6] fuse: Introduce fuse_inode::lock to protect write related fields and statistics

2018-11-06 Thread Kirill Tkhai
To minimize contention of fuse_conn::lock, this patch introduces a new spinlock for protection fuse_inode metadata: fuse_inode:: writectr writepages write_files queued_writes

[PATCH 5/6] fuse: Protect fuse_inode::nlookup with fuse_inode::lock

2018-11-06 Thread Kirill Tkhai
This continues previous patch and introduces the same protection for nlookup field. It goes as separate patch since it's separate logic change (sadly, but it looks impossible to split previous patch more then in this way). Signed-off-by: Kirill Tkhai --- fs/fuse/dir.c |4 ++-- fs/fuse/in

Re: [RFC PATCH 2/2] memcg: do not report racy no-eligible OOM tasks

2018-11-06 Thread Tetsuo Handa
>From dc0d9ec3205a28680dcf2213c0ffe8820e8b5913 Mon Sep 17 00:00:00 2001 From: Tetsuo Handa Date: Tue, 6 Nov 2018 12:27:36 +0900 Subject: [PATCH] memcg: killed threads should not invoke memcg OOM killer It is possible that a single process group memcg easily swamps the log with no-eligible OOM vic

Re: [PATCH] slab.h: Avoid using & for logical and of booleans

2018-11-06 Thread William Kucharski
> On Nov 5, 2018, at 14:13, Andrew Morton wrote: > >> On Mon, 5 Nov 2018 12:40:00 -0800 Bart Van Assche >> wrote: >> -return type_dma + (is_reclaimable & !is_dma) * KMALLOC_RECLAIM; >> +return type_dma + is_reclaimable * !is_dma * KMALLOC_RECLAIM; >> } >> >> /* > > I suppose so. >

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-06 Thread Michal Hocko
On Tue 06-11-18 17:16:24, Baoquan He wrote: [...] > Not sure if there are any scenario or use cases to cover those newly added > checking other movable zone checking. Surely, I have no objection to > adding them. But the two patches are separate issues, they have no > dependency on each other. Yes

Re: [PATCH] mm/thp: Correctly differentiate between mapped THP and PMD migration entry

2018-11-06 Thread Anshuman Khandual
On 11/06/2018 06:05 AM, Will Deacon wrote: > On Fri, Nov 02, 2018 at 11:45:00AM +0530, Anshuman Khandual wrote: >> On 10/17/2018 07:39 AM, Andrea Arcangeli wrote: >>> What we need to do during split is an invalidate of the huge TLB. >>> There's no pmd_trans_splitting anymore, so we only clear th

Re: [PATCH 4.14 069/143] ARM: tegra: Fix ULPI regression on Tegra20

2018-11-06 Thread Marcel Ziswiler
On Tue, 2018-11-06 at 01:31 -0500, Sasha Levin wrote: > On Mon, Nov 05, 2018 at 02:05:49PM +, Marcel Ziswiler wrote: > > On Fri, 2018-11-02 at 22:02 -0400, Sasha Levin wrote: > > > On Fri, Nov 02, 2018 at 07:56:57PM +, Sudip Mukherjee wrote: > > > > Hi Greg, > > > > > > > > On Fri, Nov 2,

Re: [PATCH v3 0/5] nds32 FPU port

2018-11-06 Thread Greentime Hu
Hi Vincent, Vincent Chen 於 2018年11月1日 週四 下午3:17寫道: > > This patch set contains basic components for supporting the nds32 FPU, > such as exception handlers and context switch for FPU registers. By > default, the lazy FPU scheme is supported and the user can configure it > via CONFIG_LZAY_FPU. In

[PATCH] mm, memory_hotplug: check zone_movable in has_unmovable_pages

2018-11-06 Thread Michal Hocko
From: Michal Hocko Page state checks are racy. Under a heavy memory workload (e.g. stress -m 200 -t 2h) it is quite easy to hit a race window when the page is allocated but its state is not fully populated yet. A debugging patch to dump the struct page state shows : [ 476.575516] has_unmovable_p

Re: [PATCH 3/3] lockdep: Use line-buffered printk() for lockdep messages.

2018-11-06 Thread Tetsuo Handa
On 2018/11/06 17:38, Petr Mladek wrote: > If you would want to avoid buffering, you could set the number > of buffers to zero. Then it would always fallback to > the direct printk(). 1 lock held by swapper/1/0: #0: ( rcu_read_lock ){} , at: trace_call_bpf+0xf8/0x640 kernel/trace

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-06 Thread Baoquan He
On 11/06/18 at 10:51am, Michal Hocko wrote: > > I just tested the movable zone checking yesterday, will add your > > previous check back, then test again. I believe the result will be > > positive. Will udpate once done. > > THere is no need to retest with that patch for your movable node setup.

Re: [PATCH v6 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-11-06 Thread Liang Yang
On 2018/11/6 17:28, Boris Brezillon wrote: On Tue, 6 Nov 2018 17:08:00 +0800 Liang Yang wrote: On 2018/11/5 23:53, Boris Brezillon wrote: On Fri, 2 Nov 2018 00:42:21 +0800 Jianxin Pan wrote: + +static inline u8 meson_nfc_read_byte(struct mtd_info *mtd) +{ + struct nand_chip *na

[RFC][PATCH] tree-wide: Remove __inline__ and __inline usage

2018-11-06 Thread Peter Zijlstra
Hi Linus, A proposed GCC asm extention: https://gcc.gnu.org/ml/gcc-patches/2018-10/msg01931.html allows adding the "inline" keyword to 'asm ("")' statements. The problem is that we're possibly redefining "inline" to "inline __attribute__((__always_inline__))" which makes the proposed: asm v

Re: [PATCH v10 0/6] EDAC: Enhancements to Synopsys EDAC driver

2018-11-06 Thread Borislav Petkov
On Thu, Oct 25, 2018 at 11:36:55AM +0530, Manish Narani wrote: > Change in v10: > - Moved the checking for ce_cnt and ue_cnt before the readl() call > - Aligned arguments on the opening brace in setup_irq() > > Manish Narani (6): > edac: synopsys: Add error handling for NULL in probe

Re: [LKP] [tools/bpf] f6f3bac08f: stderr.failed_to_prepare_for_bpf

2018-11-06 Thread Li Zhijian
On 11/6/2018 9:47 AM, Yonghong Song wrote: I cannot reproduce in my local fc28 system with the attached steps. The netlink_dumper.c file, could you confirm whether the following header files are missing form you rhel-7.2 host? #include #include I suspect you probably miss linux/tc_act/tc_b

Re: sama5d: using the ebi interface from another driver

2018-11-06 Thread Alexander Dahl
Hei hei, Am Freitag, 2. November 2018, 14:35:26 CET schrieb Jean-Michel Hautbois: > Then, after looking into deeper details in the datasheet I understand > it is connected through EBI and it sounds not so easy :D. Did you read docs on that? You'll find the binding docs here: Documentation/device

  1   2   3   4   5   6   7   8   >