[PATCH] ARM: fix __get_user_check() in case uaccess_* calls are not inlined

2019-09-30 Thread Masahiro Yamada
KernelCI reports that bcm2835_defconfig is no longer booting since commit ac7c3e4ff401 ("compiler: enable CONFIG_OPTIMIZE_INLINING forcibly"): https://lkml.org/lkml/2019/9/26/825 I also received a regression report from Nicolas Saenz Julienne: https://lkml.org/lkml/2019/9/27/263 This

Re: [PATCH] fs: affs: fix a memory leak in affs_remount

2019-09-30 Thread Markus Elfring
* Please avoid typos in the commit message. * I would prefer an other wording for the change description. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=97f9a3c4eee55b0178b518ae7114a6a53372913d#n151 > But this is not

Re: [PATCH] compiler: enable CONFIG_OPTIMIZE_INLINING forcibly

2019-09-30 Thread Masahiro Yamada
Hi. On Fri, Sep 27, 2019 at 7:58 PM Nicolas Saenz Julienne wrote: > > On Fri, 2019-08-30 at 12:43 +0900, Masahiro Yamada wrote: > > Commit 9012d011660e ("compiler: allow all arches to enable > > CONFIG_OPTIMIZE_INLINING") allowed all architectures to enable > > this option. A couple of build

Re: x86/random: Speculation to the rescue

2019-09-30 Thread Borislav Petkov
On Sun, Sep 29, 2019 at 07:59:19PM -0700, Linus Torvalds wrote: > All my smoke testing looked fine - I disabled trusting the CPU, I > increased the required entropy a lot, and to actually trigger the > lockup issue without the broken user space, I made /dev/urandom do > that "wait for entropy"

Re: [PATCH 4.19 33/63] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

2019-09-30 Thread Pavel Machek
> From: Vadim Sukhomlinov > > commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 upstream > > TPM 2.0 Shutdown involve sending TPM2_Shutdown to TPM chip and disabling > future TPM operations. TPM 1.2 behavior was different, future TPM > operations weren't disabled, causing rare issues. This patch

[PATCH V10 0/2] mailbox: arm: introduce smc triggered mailbox

2019-09-30 Thread Peng Fan
From: Peng Fan V10: - Add R-b tag from Andre, Rob and Florian - Two minor fixes - Drop "passed from consumers" in patch 1/2 per Andre's comments - Drop interrupts.h in patch 2/2 per Andre's comments V9: - Add Florian's R-b tag in patch 1/2 - Mark arm,func-id as a required property per

[PATCH V10 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox

2019-09-30 Thread Peng Fan
From: Peng Fan The ARM SMC/HVC mailbox binding describes a firmware interface to trigger actions in software layers running in the EL2 or EL3 exception levels. The term "ARM" here relates to the SMC instruction as part of the ARM instruction set, not as a standard endorsed by ARM Ltd.

[PATCH V10 2/2] mailbox: introduce ARM SMC based mailbox

2019-09-30 Thread Peng Fan
From: Peng Fan This mailbox driver implements a mailbox which signals transmitted data via an ARM smc (secure monitor call) instruction. The mailbox receiver is implemented in firmware and can synchronously return data when it returns execution to the non-secure world again. An asynchronous

[PATCH v6 1/1] memory_hotplug: Add a bounds check to __add_pages

2019-09-30 Thread Alastair D'Silva
From: Alastair D'Silva On PowerPC, the address ranges allocated to OpenCAPI LPC memory are allocated from firmware. These address ranges may be higher than what older kernels permit, as we increased the maximum permissable address in commit 4ffe713b7587 ("powerpc/mm: Increase the max addressable

[PATCH v6 0/1] Add bounds check for Hotplugged memory

2019-09-30 Thread Alastair D'Silva
From: Alastair D'Silva This series adds bounds checks for hotplugged memory, ensuring that it is within the physically addressable range (for platforms that define MAX_(POSSIBLE_)PHYSMEM_BITS. This allows for early failure, rather than attempting to access bogus section numbers. Changelog:

Re: [PATCH] spi: gpio: prevent memory leak in spi_gpio_probe

2019-09-30 Thread Markus Elfring
* Please avoid typos in the commit message. * I would prefer an other wording for the change description. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=97f9a3c4eee55b0178b518ae7114a6a53372913d#n151 Regards, Markus

Re: [PATCH] iwlwifi: dbg_ini: fix memory leak in alloc_sgtable

2019-09-30 Thread Luca Coelho
On Thu, 2019-09-12 at 23:23 -0500, Navid Emamdoost wrote: > In alloc_sgtable if alloc_page fails, the alocated table should be > released. > > Signed-off-by: Navid Emamdoost > --- > drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 1 + > 1 file changed, 1 insertion(+) Thanks, Navid! I have

Re: [PATCH] mm/page_alloc: fix a crash in free_pages_prepare()

2019-09-30 Thread Christian Borntraeger
On 28.09.19 11:06, David Hildenbrand wrote: > On 28.09.19 00:17, Alexander Duyck wrote: >> On Fri, Sep 27, 2019 at 2:59 PM Andrew Morton >> wrote: >>> >>> On Fri, 27 Sep 2019 17:28:06 -0400 Qian Cai wrote: >>> > > So I think you've moved the arch_free_page() to be after the final

[RFC PATCH] Don't copy mark from encapsulated packet when routing VXLAN

2019-09-30 Thread Jethro Beekman
When using rule-based routing to send traffic via VXLAN, a routing loop may occur. Say you have the following routing setup: ip rule add from all fwmark 0x2/0x2 lookup 2 ip route add table 2 default via 10.244.2.0 dev vxlan1 onlink The intention is to route packets with mark 2 through VXLAN, and

Re: [PATCH] mm/page_alloc: fix a crash in free_pages_prepare()

2019-09-30 Thread Christian Borntraeger
On 27.09.19 23:59, Andrew Morton wrote: > On Fri, 27 Sep 2019 17:28:06 -0400 Qian Cai wrote: > >>> >>> So I think you've moved the arch_free_page() to be after the final >>> thing which can access page contents, yes? If so, we should have a >>> comment in free_pages_prepare() to attmept to

Re: [PATCH] iwlwifi: dvm: excessive if in rs_bt_update_lq()

2019-09-30 Thread Luciano Coelho
On Wed, 2019-09-25 at 23:49 +0300, Denis Efremov wrote: > There is no need to check 'priv->bt_ant_couple_ok' twice in > rs_bt_update_lq(). The second check is always true. Thus, the > expression can be simplified. > > Signed-off-by: Denis Efremov > --- >

[PATCH v2 1/1] i2c: iproc: Add i2c repeated start capability

2019-09-30 Thread Rayagonda Kokatanur
From: Lori Hikichi Enable handling of i2c repeated start. The current code handles a multi msg i2c transfer as separate i2c bus transactions. This change will now handle this case using the i2c repeated start protocol. The number of msgs in a transfer is limited to two, and must be a write

Re: [PATCH v2 1/1] i2c: iproc: Add i2c repeated start capability

2019-09-30 Thread Rayagonda Kokatanur
On Sat, Sep 28, 2019 at 11:53 PM Wolfram Sang wrote: > > On Thu, Sep 26, 2019 at 10:10:08AM +0530, Rayagonda Kokatanur wrote: > > From: Lori Hikichi > > > > Enable handling of i2c repeated start. The current code > > handles a multi msg i2c transfer as separate i2c bus > > transactions. This

Re: [PATCH] usb: dwc3: pci: prevent memory leak in dwc3_pci_probe

2019-09-30 Thread Markus Elfring
> … This commit replaces return with the goto. How do you think about to omit the wording “This commit” from your change descriptions?

Re: [PATCH] iwlwifi: fix memory leaks in iwl_pcie_ctxt_info_gen3_init

2019-09-30 Thread Luca Coelho
On Fri, 2019-09-27 at 15:56 -0500, Navid Emamdoost wrote: > In iwl_pcie_ctxt_info_gen3_init there are cases that the allocated dma > memory is leaked in case of error. > DMA memories prph_scratch, prph_info, and ctxt_info_gen3 are allocated > and initialized to be later assigned to trans_pcie. But

BUG: unable to handle kernel NULL pointer dereference in xsk_poll

2019-09-30 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:a3c0e7b1 Merge tag 'libnvdimm-fixes-5.4-rc1' of git://git... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=14f0543560 kernel config: https://syzkaller.appspot.com/x/.config?x=6ffbfa7e4a36190f

Re: [PATCH RT 5/8] sched/deadline: Reclaim cpuset bandwidth in .migrate_task_rq()

2019-09-30 Thread Juri Lelli
On 27/09/19 11:40, Scott Wood wrote: > On Fri, 2019-09-27 at 10:11 +0200, Juri Lelli wrote: > > Hi Scott, > > > > On 27/07/19 00:56, Scott Wood wrote: > > > With the changes to migrate disabling, ->set_cpus_allowed() no longer > > > gets deferred until migrate_enable(). To avoid releasing the

Re: [PATCH] tools: libbpf: Add bpf_object__open_buffer_xattr

2019-09-30 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Fri, Sep 27, 2019 at 6:11 AM KP Singh wrote: >> >> From: KP Singh >> >> Introduce struct bpf_object_open_buffer_attr and an API function, >> bpf_object__open_xattr, as the existing API, bpf_object__open_buffer, >> doesn't provide a way to specify neither the

Re: [PATCH 4.19 53/63] f2fs: fix to do sanity check on segment bitmap of LFS curseg

2019-09-30 Thread Pavel Machek
Hi! > + for (blkofs += 1; blkofs < sbi->blocks_per_seg; blkofs++) { > + if (!f2fs_test_bit(blkofs, se->cur_valid_map)) > + continue; > +out: > + f2fs_msg(sbi->sb, KERN_ERR, > + "Current

Re: [PATCH] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-09-30 Thread Leonard Crestez
On 2019-09-27 4:20 AM, Anson Huang wrote: >> On 2019-09-26 1:06 PM, Marco Felsch wrote: >>> On 19-09-26 08:03, Anson Huang wrote: > On 19-09-25 18:07, Anson Huang wrote: >> The SCU firmware does NOT always have return value stored in >> message header's function element even the API

Re: [Patch v4 6/8] media: i2c: ov2659: Add powerdown/reset gpio handling

2019-09-30 Thread Sakari Ailus
Hi Benoit, On Fri, Sep 27, 2019 at 01:47:20PM -0500, Benoit Parrot wrote: > On some board it is possible that the sensor 'powerdown' and or 'reset' > pin might be controlled by gpio instead of being tied. > > To implement we add pm_runtime support which will handle the power > up/down sequence

Re: [PATCH 4.19 53/63] f2fs: fix to do sanity check on segment bitmap of LFS curseg

2019-09-30 Thread Chao Yu
Hello, On 2019/9/30 15:21, Pavel Machek wrote: > Hi! > > >> +for (blkofs += 1; blkofs < sbi->blocks_per_seg; blkofs++) { >> +if (!f2fs_test_bit(blkofs, se->cur_valid_map)) >> +continue; >> +out: >> +

RE: [PATCH] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-09-30 Thread Anson Huang
Hi, Leonard > On 2019-09-27 4:20 AM, Anson Huang wrote: > >> On 2019-09-26 1:06 PM, Marco Felsch wrote: > >>> On 19-09-26 08:03, Anson Huang wrote: > > On 19-09-25 18:07, Anson Huang wrote: > >> The SCU firmware does NOT always have return value stored in > >> message header's

Re: [PATCH] iio: adc: imx25-gcq: Variable could be uninitialized if regmap_read() fails

2019-09-30 Thread Marco Felsch
Hi Yizhuo, thanks for your patch. On 19-09-27 17:28, Yizhuo wrote: > In function mx25_gcq_irq(), local variable "stats" could > be uninitialized if function regmap_read() returns -EINVAL. > However, this value is used in if statement, which is > potentially unsafe. The same case applied to the

[PATCH 1/1] xen-netfront: do not use ~0U as error return value for xennet_fill_frags()

2019-09-30 Thread Dongli Zhang
xennet_fill_frags() uses ~0U as return value when the sk_buff is not able to cache extra fragments. This is incorrect because the return type of xennet_fill_frags() is RING_IDX and 0x is an expected value for ring buffer index. In the situation when the rsp_cons is approaching 0x,

Re: [PATCH v3 04/10] sched/fair: rework load_balance

2019-09-30 Thread Vincent Guittot
On Mon, 30 Sep 2019 at 03:13, Rik van Riel wrote: > > On Thu, 2019-09-19 at 09:33 +0200, Vincent Guittot wrote: > > > > Also the load balance decisions have been consolidated in the 3 > > functions > > below after removing the few bypasses and hacks of the current code: > > -

Re: [PATCH] mm/page_alloc: fix a crash in free_pages_prepare()

2019-09-30 Thread Heiko Carstens
On Fri, Sep 27, 2019 at 05:15:08PM -0400, Qian Cai wrote: > On Fri, 2019-09-27 at 13:48 -0700, Andrew Morton wrote: > > On Fri, 27 Sep 2019 15:47:03 -0400 Qian Cai wrote: > > > --- a/mm/page_alloc.c > > > +++ b/mm/page_alloc.c > > > @@ -1175,11 +1175,11 @@ static __always_inline bool > > >

Re: [PATCH v8 2/7] nfc: pn532: Add uart phy docs and rename it

2019-09-30 Thread Lars Poeschel
On Fri, Sep 27, 2019 at 10:52:09AM -0500, Rob Herring wrote: > On Thu, Sep 19, 2019 at 11:16:39AM +0200, Lars Poeschel wrote: > > This adds documentation about the uart phy to the pn532 binding doc. As > > the filename "pn533-i2c.txt" is not appropriate any more, rename it to > > the more general

Re: [PATCH] xfs: Fix tail rounding in xfs_alloc_file_space()

2019-09-30 Thread Christoph Hellwig
On Thu, Sep 26, 2019 at 04:22:38PM +0200, Max Reitz wrote: > To ensure that all blocks touched by the range [offset, offset + count) > are allocated, we need to calculate the block count from the difference > of the range end (rounded up) and the range start (rounded down). > > Before this patch,

Re: [PATCH v1] powerpc/pseries: CMM: Drop page array

2019-09-30 Thread David Hildenbrand
On 27.09.19 23:06, Michael Ellerman wrote: > > > On 27 September 2019 9:19:49 pm AEST, David Hildenbrand > wrote: >> On 25.09.19 09:37, David Hildenbrand wrote: >>> On 10.09.19 18:39, David Hildenbrand wrote: We can simply store the pages in a list (page->lru), no need for a separate

Re: [PATCH v5 0/3] mfd: mc13xxx: Fixes and enhancements for NXP's mc34708

2019-09-30 Thread Lukasz Majewski
Dear Lee, > This patch set provides several enhancements to mc13xxx MFD family > of devices by introducing mc34708 as a separate device. > > This IC has dedicated pen detection feature, which allows better > touchscreen experience. > > This is the fifth version of this code (v5). > Discussion

Re: BUG: unable to handle kernel NULL pointer dereference in xsk_poll

2019-09-30 Thread Magnus Karlsson
On Mon, Sep 30, 2019 at 9:17 AM syzbot wrote: > > Hello, > > syzbot found the following crash on: Thank you Mr Syzcaller. I am on it. /Magnus > HEAD commit:a3c0e7b1 Merge tag 'libnvdimm-fixes-5.4-rc1' of git://git... > git tree: upstream > console output:

RE: [PATCH] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-09-30 Thread Anson Huang
Hi, Leonard > > On 2019-09-27 4:20 AM, Anson Huang wrote: > > >> On 2019-09-26 1:06 PM, Marco Felsch wrote: > > >>> On 19-09-26 08:03, Anson Huang wrote: > > > On 19-09-25 18:07, Anson Huang wrote: > > >> The SCU firmware does NOT always have return value stored in > > >> message

Re: [PATCH 1/1] xen-netfront: do not use ~0U as error return value for xennet_fill_frags()

2019-09-30 Thread Jürgen Groß
On 30.09.19 09:44, Dongli Zhang wrote: xennet_fill_frags() uses ~0U as return value when the sk_buff is not able to cache extra fragments. This is incorrect because the return type of xennet_fill_frags() is RING_IDX and 0x is an expected value for ring buffer index. In the situation

Re: [PATCH] rtc: Add support for century bits to m41t62 (rv4162) RTC devices

2019-09-30 Thread Lukasz Majewski
Hi Alessandro, Alexandre, > This change adds support for 'century bits' on 4162 family of RTC > devices (from ST or microcrystal), which allow storing time beyond > year 2099. > > For rv4162 century bits - CB1[7]:CB0[6] are stored in reg6 - 0x6 > (MONTH): CB1 CB0 > 00 (year 2000 -

Re: [PATCH] ARM: fix __get_user_check() in case uaccess_* calls are not inlined

2019-09-30 Thread Arnd Bergmann
On Mon, Sep 30, 2019 at 8:01 AM Masahiro Yamada wrote: > > KernelCI reports that bcm2835_defconfig is no longer booting since > commit ac7c3e4ff401 ("compiler: enable CONFIG_OPTIMIZE_INLINING > forcibly"): > > https://lkml.org/lkml/2019/9/26/825 > > I also received a regression report from

Re: [GIT PULL 1/2] arm64: dts: exynos: Pull for v5.4

2019-09-30 Thread Krzysztof Kozlowski
On Sun, Sep 29, 2019 at 10:51:34AM -0700, Olof Johansson wrote: > Hi, > > On Thu, Sep 12, 2019 at 08:32:47AM +0200, Krzysztof Kozlowski wrote: > > On Wed, 11 Sep 2019 at 23:07, Arnd Bergmann wrote: > > > > > > On Wed, Sep 11, 2019 at 8:36 PM Krzysztof Kozlowski > > > wrote: > > > > > > > > Hi,

Re: [PATCH v5 08/14] ARM: tegra: Make outer_disable() open-coded

2019-09-30 Thread Thierry Reding
On Sun, Sep 29, 2019 at 08:59:46PM +0300, Dmitry Osipenko wrote: > The outer_disable() of Tegra's suspend code is open-coded now since > that helper produces spurious warning message about secondary CPUs being > online. The secondaries are actually halted by the cpuidle driver on > entering into

[PATCH] HID: core: add usage_page_preceding flag for hid_concatenate_usage_page()

2019-09-30 Thread Candle Sun
From: Candle Sun Upstream commit 58e75155009c ("HID: core: move Usage Page concatenation to Main item") adds support for Usage Page item following Usage items (such as keyboards manufactured by Primax). Usage Page concatenation in Main item works well for following report descriptor patterns:

[RFC] Makefiles in scripts dir needs to move one place

2019-09-30 Thread Bhaskar Chowdhury
Hey Greg , Absolute trivialities, but might break few scripts, but make things clean.. We have so many *Makefile.* cluttering in the top level scripts dir. Can we please move those in one place, means create a dir and put all of them in it. And call those in the scripts with that dir

[PATCH v3] i2c: at91: Send bus clear command if SCL or SDA is down

2019-09-30 Thread Codrin Ciubotariu
After a transfer timeout, some faulty I2C slave devices might hold down the SCL or the SDA pins. We can generate a bus clear command, hoping that the slave might release the pins. Signed-off-by: Codrin Ciubotariu Acked-by: Ludovic Desroches --- Changes in v3: - fixed kbuild warning; Changes

Re: [PATCH v2 0/6] media: cedrus: h264: Support multi-slice frames

2019-09-30 Thread Hans Verkuil
On 9/29/19 10:00 PM, Jernej Skrabec wrote: > This series adds support for decoding multi-slice H264 frames along with > support for V4L2_DEC_CMD_FLUSH and V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF. > > Code was tested by modified ffmpeg, which can be found here: > https://github.com/jernejsk/FFmpeg,

Re: [PATCH v2 6/6] media: cedrus: Add support for holding capture buffer

2019-09-30 Thread Hans Verkuil
On 9/29/19 10:00 PM, Jernej Skrabec wrote: > When frame contains multiple slices and driver works in slice mode, it's > more efficient to hold capture buffer in queue until all slices of a > same frame are decoded. > > Add support for that to Cedrus driver by exposing and implementing >

Re: [PATCH] ARM: fix __get_user_check() in case uaccess_* calls are not inlined

2019-09-30 Thread Nicolas Saenz Julienne
On Mon, 2019-09-30 at 14:59 +0900, Masahiro Yamada wrote: > KernelCI reports that bcm2835_defconfig is no longer booting since > commit ac7c3e4ff401 ("compiler: enable CONFIG_OPTIMIZE_INLINING > forcibly"): > > https://lkml.org/lkml/2019/9/26/825 > > I also received a regression report from

Re: [PATCH] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-09-30 Thread Marco Felsch
Hi Anson, Leonard, On 19-09-30 07:42, Anson Huang wrote: > Hi, Leonard > > > On 2019-09-27 4:20 AM, Anson Huang wrote: > > >> On 2019-09-26 1:06 PM, Marco Felsch wrote: > > >>> On 19-09-26 08:03, Anson Huang wrote: > > > On 19-09-25 18:07, Anson Huang wrote: > > >> The SCU firmware does

Re: [PATCH v4 1/8] dt-bindings: timer: Convert Exynos MCT bindings to json-schema

2019-09-30 Thread Krzysztof Kozlowski
On Fri, Sep 27, 2019 at 12:07:01PM -0500, Rob Herring wrote: > On Mon, Sep 23, 2019 at 06:14:04PM +0200, Krzysztof Kozlowski wrote: > > Convert Samsung Exynos Soc Multi Core Timer bindings to DT schema format > > using json-schema. > > > > Signed-off-by: Krzysztof Kozlowski > > > > --- > > > >

Re: [PATCH] watchdog: meson: Fix the wrong value of left time

2019-09-30 Thread Neil Armstrong
On 29/09/2019 12:53, Xingyu Chen wrote: > The left time value is wrong when we get it by sysfs. The left time value > should be equal to preset timeout value minus elapsed time value. According > to the Meson-GXB/GXL datasheets which can be found at [0], the timeout value > is saved to BIT[0-15]

Re: [PATCH v6 3/7] arm64: dts: amlogic: g12: add temperature sensor

2019-09-30 Thread Neil Armstrong
On 27/09/2019 20:43, Guillaume La Roque wrote: > Add cpu and ddr temperature sensors for G12 Socs > > Reviewed-by: Martin Blumenstingl > Tested-by: Christian Hewitt > Tested-by: Kevin Hilman > Signed-off-by: Guillaume La Roque > --- > .../boot/dts/amlogic/meson-g12-common.dtsi| 20

Re: [PATCH v6 4/7] arm64: dts: meson: g12: Add minimal thermal zone

2019-09-30 Thread Neil Armstrong
On 27/09/2019 20:43, Guillaume La Roque wrote: > Add minimal thermal zone for two temperature sensor > One is located close to the DDR and the other one is > located close to the PLLs (between the CPU and GPU) > > Acked-by: Martin Blumenstingl > Tested-by: Christian Hewitt > Tested-by: Kevin

[PATCH v2 net 3/9] net: stmmac: selftests: Always use max DMA size in Jumbo Test

2019-09-30 Thread Jose Abreu
Although some XGMAC setups support frames larger than DMA size, some of them may not. As we can't know before-hand which ones support let's use the maximum DMA buffer size in the Jumbo Tests. User can always reconfigure the MTU to achieve larger frames. Fixes: 427849e8c37f ("net: stmmac:

[PATCH v2 net 4/9] net: stmmac: dwmac4: Always update the MAC Hash Filter

2019-09-30 Thread Jose Abreu
We need to always update the MAC Hash Filter so that previous entries are invalidated. Found out while running stmmac selftests. Fixes: b8ef7020d6e5 ("net: stmmac: add support for hash table size 128/256 in dwmac4") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue

[PATCH v2 net 8/9] net: stmmac: xgmac: Fix RSS not writing all Keys to HW

2019-09-30 Thread Jose Abreu
The sizeof(cfg->key) is != ARRAY_SIZE(cfg->key). Fix it. This warning is triggered when running with cc flag -Wsizeof-array-div. Reported-by: kbuild test robot Reported-by: Nick Desaulniers Reported-by: Nathan Chancellor Fixes: 76067459c686 ("net: stmmac: Implement RSS and enable it in XGMAC

Re: [PATCH v6 5/7] arm64: dts: amlogic: g12a: add cooling properties

2019-09-30 Thread Neil Armstrong
On 27/09/2019 20:43, Guillaume La Roque wrote: > Add missing #colling-cells field for G12A SoC > Add cooling-map for passive and hot trip point > > Tested-by: Christian Hewitt > Tested-by: Kevin Hilman > Signed-off-by: Guillaume La Roque > --- > arch/arm64/boot/dts/amlogic/meson-g12a.dtsi |

[PATCH v2 net 2/9] net: stmmac: xgmac: Detect Hash Table size dinamically

2019-09-30 Thread Jose Abreu
Since commit b8ef7020d6e5 ("net: stmmac: add support for hash table size 128/256 in dwmac4"), we can detect the Hash Table dinamically. Let's implement this feature in XGMAC cores and fix possible setups that don't support the maximum size for Hash Table. Signed-off-by: Jose Abreu --- Cc:

Re: [PATCH v6 6/7] arm64: dts: amlogic: g12b: add cooling properties

2019-09-30 Thread Neil Armstrong
On 27/09/2019 20:43, Guillaume La Roque wrote: > Add missing #colling-cells field for G12B SoC > Add cooling-map for passive and hot trip point > > Tested-by: Christian Hewitt > Tested-by: Kevin Hilman > Signed-off-by: Guillaume La Roque > --- > arch/arm64/boot/dts/amlogic/meson-g12b.dtsi |

[PATCH v2 net 9/9] net: stmmac: xgmac: Fix RSS writing wrong keys

2019-09-30 Thread Jose Abreu
Commit b6b6cc9acd7b, changed the call to dwxgmac2_rss_write_reg() passing it the variable cfg->key[i]. As key is an u8 but we write 32 bits at a time we need to cast it into an u32 so that the correct key values are written. Notice that the for loop already takes this into account so we don't try

[PATCH v2 net 0/9] net: stmmac: Fixes for -net

2019-09-30 Thread Jose Abreu
Misc fixes for -net tree. More info in commit logs. v2 is just a rebase of v1 against -net and we added a new patch (09/09) to fix RSS feature. --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller" Cc: Maxime Coquelin Cc: net...@vger.kernel.org Cc:

[PATCH v2 net 6/9] net: stmmac: Do not stop PHY if WoL is enabled

2019-09-30 Thread Jose Abreu
If WoL is enabled we can't really stop the PHY, otherwise we will not receive the WoL packet. Fix this by telling phylink that only the MAC is down and only stop the PHY if WoL is not enabled. Fixes: 74371272f97f ("net: stmmac: Convert to phylink and remove phylib logic") Signed-off-by: Jose

[PATCH v2 net 1/9] net: stmmac: xgmac: Not all Unicast addresses may be available

2019-09-30 Thread Jose Abreu
Some setups may not have all Unicast addresses filters available. Let's check this before trying to setup filters. Fixes: 0efedbf11f07 ("net: stmmac: xgmac: Fix XGMAC selftests") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller"

Re: [PATCH 00/11] of: dma-ranges fixes and improvements

2019-09-30 Thread Christoph Hellwig
On Sun, Sep 29, 2019 at 01:16:20PM +0200, Arnd Bergmann wrote: > On a semi-related note, Thierry asked about one aspect of the dma-ranges > property recently, which is the behavior of dma_set_mask() and related > functions when a driver sets a mask that is larger than the memory > area in the

[PATCH v2 net 7/9] net: stmmac: xgmac: Disable the Timestamp interrupt by default

2019-09-30 Thread Jose Abreu
We don't use it anyway as XGMAC only supports polling for timestamp (in current SW implementation). This greatly reduces the system load by reducing the number of interrupts. Fixes: 2142754f8b9c ("net: stmmac: Add MAC related callbacks for XGMAC2") Signed-off-by: Jose Abreu --- Cc: Giuseppe

[PATCH v2 net 5/9] net: stmmac: Correctly take timestamp for PTPv2

2019-09-30 Thread Jose Abreu
The case for PTPV2_EVENT requires event packets to be captured so add this setting to the list of enabled captures. Fixes: 891434b18ec0 ("stmmac: add IEEE PTPv1 and PTPv2 support.") Signed-off-by: Jose Abreu --- Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Jose Abreu Cc: "David S. Miller"

Re: [PATCH v6 1/1] memory_hotplug: Add a bounds check to __add_pages

2019-09-30 Thread kbuild test robot
to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Alastair-D-Silva/Add-bounds-check-for-Hotplugged-memory/20190930-143107 config: i386-randconfig-g004-201939 (attached as .config) compiler: gcc-7 (Debian 7.4.0

Re: [PATCH] virt: vbox: fix memory leak in hgcm_call_preprocess_linaddr

2019-09-30 Thread Hans de Goede
Hi, On 30-09-2019 04:22, Navid Emamdoost wrote: It is a neat fix now, thank you. Can you submit a new version of your patch with the fix I proposed please ? Regards, Hans On Sat, Sep 28, 2019 at 4:54 AM Hans de Goede wrote: Hi, On 28-09-2019 01:04, Navid Emamdoost wrote: In

Re: [PATCH] media: uvcvideo: Use streaming DMA APIs to transfer buffers

2019-09-30 Thread Christoph Hellwig
On Sat, Sep 28, 2019 at 11:33:16AM +0800, Nicolas Boichat wrote: > > +static gfp_t uvc_alloc_gfp_flags(struct device *dev) > > +{ > > + u64 mask = dma_get_mask(dev); > > + > > + if (dev->bus_dma_mask) > > + mask &= dev->bus_dma_mask; > > + > > + if (mask <

Re: [PATCH v5 00/14] Consolidate and improve NVIDIA Tegra CPUIDLE driver(s)

2019-09-30 Thread Thierry Reding
On Sun, Sep 29, 2019 at 08:59:38PM +0300, Dmitry Osipenko wrote: > Hello, > > This series does the following: > > 1. Unifies Tegra20/30/114 drivers into a single driver and moves it out > into common drivers/cpuidle/ directory. > > 2. Enables CPU cluster power-down idling state on

Re: [PATCH] ARM: fix __get_user_check() in case uaccess_* calls are not inlined

2019-09-30 Thread Masahiro Yamada
Hi Arnd, On Mon, Sep 30, 2019 at 4:57 PM Arnd Bergmann wrote: > > On Mon, Sep 30, 2019 at 8:01 AM Masahiro Yamada > wrote: > > > > KernelCI reports that bcm2835_defconfig is no longer booting since > > commit ac7c3e4ff401 ("compiler: enable CONFIG_OPTIMIZE_INLINING > > forcibly"): > > > >

Re: [PATCH 1/3] ARM: dts: add Netronix E60K02 board common file

2019-09-30 Thread Marco Felsch
Hi Andreas, On 19-09-27 21:08, Andreas Kemnade wrote: > Hi Marco, > > On Fri, 27 Sep 2019 11:47:21 +0200 > Marco Felsch wrote: > > > Hi Andreas, > > > > thanks for the patch. > > > thanks for the quick review. Most of your comments are clear. > > [...] > > > + wifi_pwrseq: wifi_pwrseq { > >

Re: [PATCH v2] PCI: mobiveil: Fix csr_read/write build issue

2019-09-30 Thread Andrew Murray
On Sun, Sep 29, 2019 at 09:35:05AM +0800, Kefeng Wang wrote: > The riscv has csr_read/write macro, see arch/riscv/include/asm/csr.h, > the same function naming will cause build error, using such generic names > in a driver is bad, rename csr_[read,write][l,] to mobiveil_csr_read/write > to fix it.

RE: [PATCH] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-09-30 Thread Anson Huang
Hi, Marco > On 19-09-30 07:42, Anson Huang wrote: > > Hi, Leonard > > > > > On 2019-09-27 4:20 AM, Anson Huang wrote: > > > >> On 2019-09-26 1:06 PM, Marco Felsch wrote: > > > >>> On 19-09-26 08:03, Anson Huang wrote: > > > > On 19-09-25 18:07, Anson Huang wrote: > > > >> The SCU firmware

Re: [Patch 07/16] media: ti-vpe: vpe: fix a v4l2-compliance failure causing a kernel panic

2019-09-30 Thread Hans Verkuil
On 9/27/19 8:36 PM, Benoit Parrot wrote: > v4l2-compliance fails with this message: > >warn: v4l2-test-formats.cpp(717): \ > TRY_FMT cannot handle an invalid pixelformat. >test VIDIOC_TRY_FMT: FAIL > > This causes the following kernel panic: > > Unable to handle kernel paging

Re: [PATCH 1/1] blk-mq: Inline status checkers

2019-09-30 Thread Christoph Hellwig
On Mon, Sep 30, 2019 at 11:25:49AM +0300, Pavel Begunkov (Silence) wrote: > From: Pavel Begunkov > > blk_mq_request_completed() and blk_mq_request_started() are > short, inline it. > > Signed-off-by: Pavel Begunkov > --- > block/blk-mq.c | 12 > block/blk-mq.h |

Re: [PATCH] scsi: core: Log SCSI command age with errors

2019-09-30 Thread Martin Wilck
On Fri, 2019-09-27 at 13:45 -0400, Laurence Oberman wrote: > > Hi Martin > > Agreed about log extraction, but turning that on with a busy workload > in a production environment is not practical. We cant do it with > systems with 1000's of luns and 1000's of IOPS/sec. > Also second resolution is

Re: Lease semantic proposal

2019-09-30 Thread Dave Chinner
On Wed, Sep 25, 2019 at 04:46:03PM -0700, Ira Weiny wrote: > On Tue, Sep 24, 2019 at 08:26:20AM +1000, Dave Chinner wrote: > > Hence, AFIACT, the above definition of a F_RDLCK|F_LAYOUT lease > > doesn't appear to be compatible with the semantics required by > > existing users of layout leases. >

Re: [PATCH v2 3/8] KVM: VMX: Consolidate to_vmx() usage in RFLAGS accessors

2019-09-30 Thread Vitaly Kuznetsov
Sean Christopherson writes: > Capture struct vcpu_vmx in a local variable to improve the readability > of vmx_{g,s}et_rflags(). > > No functional change intended. > > Signed-off-by: Sean Christopherson > --- > arch/x86/kvm/vmx/vmx.c | 20 +++- > 1 file changed, 11

Re: [PATCH v10 08/12] pwm: mediatek: Add MT7629 compatible string

2019-09-30 Thread Sam Shih
Hi, On Fri, 2019-09-27 at 13:28 +0200, Thierry Reding wrote: > On Wed, Sep 25, 2019 at 10:32:33PM +0800, Sam Shih wrote: > > This adds pwm support for MT7629, and separate mt7629 compatible string > > from mt7622 > > > > Signed-off-by: Sam Shih > > --- > > drivers/pwm/pwm-mediatek.c | 6 ++

Re: [PATCH 00/11] of: dma-ranges fixes and improvements

2019-09-30 Thread Thierry Reding
On Mon, Sep 30, 2019 at 01:20:55AM -0700, Christoph Hellwig wrote: > On Sun, Sep 29, 2019 at 01:16:20PM +0200, Arnd Bergmann wrote: > > On a semi-related note, Thierry asked about one aspect of the dma-ranges > > property recently, which is the behavior of dma_set_mask() and related > > functions

Re: [PATCH] kasan: fix the missing underflow in memmove and memcpy with CONFIG_KASAN_GENERIC=y

2019-09-30 Thread Marc Gonzalez
On 30/09/2019 06:36, Walter Wu wrote: > bool check_memory_region(unsigned long addr, size_t size, bool write, > unsigned long ret_ip) > { > + if (long(size) < 0) { > + kasan_report_invalid_size(src, dest, len, _RET_IP_); > +

Re: [PATCH v2 4/8] KVM: VMX: Optimize vmx_set_rflags() for unrestricted guest

2019-09-30 Thread Vitaly Kuznetsov
Sean Christopherson writes: > Rework vmx_set_rflags() to avoid the extra code need to handle emulation > of real mode and invalid state when unrestricted guest is disabled. The > primary reason for doing so is to avoid the call to vmx_get_rflags(), > which will incur a VMREAD when RFLAGS is not

Re: [PATCH] tools: bpf: Use !building_out_of_srctree to determine srctree

2019-09-30 Thread Daniel Borkmann
On Thu, Sep 26, 2019 at 07:13:44PM -0600, Shuah Khan wrote: > make TARGETS=bpf kselftest fails with: > > Makefile:127: tools/build/Makefile.include: No such file or directory > > When the bpf tool make is invoked from tools Makefile, srctree is > cleared and the current logic check for srctree

[PATCH v5 0/2] at24: convert the binding document to yaml

2019-09-30 Thread Bartosz Golaszewski
From: Bartosz Golaszewski The first patch converts the at24 DT binding to yaml. The second adds a new compatible special case that's being used undocumented currently. v1 -> v2: - modified the compatible property: we now list all possible combinations and non-standard types with appropriate

[PATCH v5 2/2] dt-bindings: at24: add new compatible

2019-09-30 Thread Bartosz Golaszewski
From: Bartosz Golaszewski arch/arm/boot/dts/at91-dvk_som60.dt.yaml uses the compatible string 'giantec,gt24c32a' for an at24 EEPROM with a fallback to 'atmel,24c32'. Add this model as a special case to the binding document. Reported-by: Rob Herring Signed-off-by: Bartosz Golaszewski ---

[PATCH v5 1/2] dt-bindings: at24: convert the binding document to yaml

2019-09-30 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Convert the binding document for at24 EEPROMs from txt to yaml. The compatible property uses a regex pattern to address all the possible combinations of "vendor,model" strings. Signed-off-by: Bartosz Golaszewski [robh: rework compatible schema, fix missing allOf for

Re: [PATCH] perf: rework memory accounting in perf_mmap()

2019-09-30 Thread Peter Zijlstra
On Wed, Sep 04, 2019 at 02:46:18PM -0700, Song Liu wrote: > perf_mmap() always increases user->locked_vm. As a result, "extra" could > grow bigger than "user_extra", which doesn't make sense. Here is an > example case: > > Note: Assume "user_lock_limit" is very small. > | # of perf_mmap calls

Re: [Patch 16/16] media: ti-vpe: vpe: don't rely on colorspace member for conversion

2019-09-30 Thread Hans Verkuil
On 9/27/19 8:36 PM, Benoit Parrot wrote: > Up to now VPE was relying on the colorspace value of struct v4l2_format > as an indication to perform color space conversion from YUV to RGB or > not. > > Instead we should used the source/destination fourcc codes as a more > reliable indication to

Re: [PATCH] scsi: core: Log SCSI command age with errors

2019-09-30 Thread Milan P. Gandhi
On 9/30/19 2:12 PM, Martin Wilck wrote: > On Fri, 2019-09-27 at 13:45 -0400, Laurence Oberman wrote: >> >> Hi Martin >> >> Agreed about log extraction, but turning that on with a busy workload >> in a production environment is not practical. We cant do it with >> systems with 1000's of luns and

[PATCH] NFS: Fix O_DIRECT read problem when another write is going on

2019-09-30 Thread Su Yanjun
In xfstests generic/465 tests failed. Because O_DIRECT r/w use async rpc calls, when r/w rpc calls are running concurrently we may read partial data which is wrong. For example as follows. user buffer /\ ||| rpc0 rpc1 When rpc0 runs it encounters eof so return 0, then another

Re: [PATCH v2 5/8] KVM: x86: Add WARNs to detect out-of-bounds register indices

2019-09-30 Thread Vitaly Kuznetsov
Sean Christopherson writes: > Add WARN_ON_ONCE() checks in kvm_register_{read,write}() to detect reg > values that would cause KVM to overflow vcpu->arch.regs. Change the reg > param to an 'int' to make it clear that the reg index is unverified. > Hm, on multiple occasions I was thinking "an

Re: [PATCH 00/11] of: dma-ranges fixes and improvements

2019-09-30 Thread Nicolas Saenz Julienne
On Thu, 2019-09-26 at 19:24 -0500, Rob Herring wrote: > This series fixes several issues related to 'dma-ranges'. Primarily, > 'dma-ranges' in a PCI bridge node does correctly set dma masks for PCI > devices not described in the DT. A common case needing dma-ranges is a > 32-bit PCIe bridge on a

Re: [PATCH v2 6/8] KVM: x86: Fold 'enum kvm_ex_reg' definitions into 'enum kvm_reg'

2019-09-30 Thread Vitaly Kuznetsov
Sean Christopherson writes: > Now that indexing into arch.regs is either protected by WARN_ON_ONCE or > done with hardcoded enums, combine all definitions for registers that > are tracked by regs_avail and regs_dirty into 'enum kvm_reg'. Having a > single enum type will simplify additional

Re: [PATCH] perf symbols: Don't split kernel symbols when using kallsyms

2019-09-30 Thread Jiri Olsa
On Sun, Sep 29, 2019 at 08:34:25PM +0800, Wei Li wrote: > If there is ovelapping of vmlinux addresses with modules on a system, > the kernel symbols will be split to unique DSOs([kernel].N) when using > /proc/kallsyms, introduced by commit 2e538c4a1847 ("perf tools: Improve > kernel/modules symbol

[PATCH v1] net: phy: at803x: add ar9331 support

2019-09-30 Thread Oleksij Rempel
Mostly this hardware can work with generic PHY driver, but this change is needed to provided interrupt handling support. Tested with dsa ar9331-switch driver. Signed-off-by: Oleksij Rempel --- drivers/net/phy/at803x.c | 14 ++ 1 file changed, 14 insertions(+) diff --git

arch/mips/include/asm/octeon/cvmx-ipd.h:330:27: error: storage size of 'pip_sft_rst' isn't known

2019-09-30 Thread kbuild test robot
Hi Matthew, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 97f9a3c4eee55b0178b518ae7114a6a53372913d commit: 171a9bae68c72f2d1260c3825203760856e6793b staging/octeon: Allow test build on !MIPS date: 9 weeks ago

Re: [PATCH v2 7/8] KVM: x86: Add helpers to test/mark reg availability and dirtiness

2019-09-30 Thread Vitaly Kuznetsov
Sean Christopherson writes: > Add helpers to prettify code that tests and/or marks whether or not a > register is available and/or dirty. > > Suggested-by: Vitaly Kuznetsov > Signed-off-by: Sean Christopherson > --- > arch/x86/kvm/kvm_cache_regs.h | 45 +-- >

[PATCH v1] net: ag71xx: fix mdio subnode support

2019-09-30 Thread Oleksij Rempel
The driver was working with fixed phy without any noticeable issues. This bug was uncovered by introducing dsa ar9331-switch driver. Signed-off-by: Oleksij Rempel --- drivers/net/ethernet/atheros/ag71xx.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

  1   2   3   4   5   6   7   8   >