Re: [PATCH v3] afs: Fix memory leak in afs_put_sysnames()

2020-06-02 Thread Markus Elfring
> Cc: # v4.17+ Are capital letters tolerated for this special email address? Regards, Markus

Re: [PATCH v2] 9p/xen: increase XEN_9PFS_RING_ORDER

2020-06-02 Thread Dominique Martinet
Stefano Stabellini wrote on Mon, Jun 01, 2020: > > LGTM, I'll try to find some time to test this by the end of next week or > > will trust you if I can't make it -- ping me around June 1st if I don't > > reply again until then... > > Ping :-) I actually did think about this patch this weekend! .

Re: [PATCH] iio: Kconfig: at91_adc: add COMPILE_TEST dependency to driver

2020-06-02 Thread Ludovic Desroches
On Sun, May 31, 2020 at 03:40:17PM +0100, Jonathan Cameron wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, 25 May 2020 13:27:44 +0300 > Alexandru Ardelean wrote: > > > Since changes can come from all sort of places, it may make

Re: [PATCH v2 2/2] vhost: convert get_user_pages() --> pin_user_pages()

2020-06-02 Thread Pankaj Gupta
> This code was using get_user_pages*(), in approximately a "Case 5" > scenario (accessing the data within a page), using the categorization > from [1]. That means that it's time to convert the get_user_pages*() + > put_page() calls to pin_user_pages*() + unpin_user_pages() calls. > > There is

Re: [PATCH] driver core: platform: expose numa_node to users in sysfs

2020-06-02 Thread Greg KH
On Tue, Jun 02, 2020 at 05:09:57AM +, Song Bao Hua (Barry Song) wrote: > > > > > > Platform devices are NUMA? That's crazy, and feels like a total abuse > > > of platform devices and drivers that really should belong on a "real" > > > bus. > > > > I am not sure if it is an abuse of platform

Re: [PATCH v2] blkdev: Replace blksize_bits() with ilog2()

2020-06-02 Thread Greg KH
On Tue, Jun 02, 2020 at 07:51:52AM +0200, Christoph Hellwig wrote: > On Mon, Jun 01, 2020 at 10:44:26AM +0200, Greg KH wrote: > > But does this code path actually show up anywhere that is actually > > measurable as mattering? > > > > If so, please show that benchmark results. > > I think the

[PATCH -next] IB/hfi1: Use free_netdev() in hfi1_netdev_free()

2020-06-02 Thread YueHaibing
dummy_netdev shold be freed by free_netdev() instead of kfree(). Also remove unneeded variable 'priv' Fixes: 4730f4a6c6b2 ("IB/hfi1: Activate the dummy netdev") Signed-off-by: YueHaibing --- drivers/infiniband/hw/hfi1/netdev_rx.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff

RE: [PATCH] driver core: platform: expose numa_node to users in sysfs

2020-06-02 Thread Song Bao Hua (Barry Song)
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, June 2, 2020 6:11 PM > To: Song Bao Hua (Barry Song) > Cc: raf...@kernel.org; io...@lists.linux-foundation.org; > linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org; Linuxarm > ;

[PATCH 1/1] blk-mq: get ctx in order to handle BLK_MQ_S_INACTIVE in blk_mq_get_tag()

2020-06-02 Thread Dongli Zhang
When scheduler is set, we hit below page fault when we offline cpu. [ 1061.007725] BUG: kernel NULL pointer dereference, address: 0040 [ 1061.008710] #PF: supervisor read access in kernel mode [ 1061.009492] #PF: error_code(0x) - not-present page [ 1061.010241] PGD 0 P4D 0 [

RE: [PATCH] exfat: optimize dir-cache

2020-06-02 Thread Namjae Jeon
> > Optimize directory access based on exfat_entry_set_cache. > > - Hold bh instead of copied d-entry. > > - Modify bh->data directly instead of the copied d-entry. > > - Write back the retained bh instead of rescanning the d-entry-set. > > And > > - Remove unused cache related definitions. >

Re: [PATCH v4 1/7] mtd: spi-nor: sfdp: get octal mode maximum speed from BFPT

2020-06-02 Thread masonccyang
Hi Pratyush, > > Subject > > Re: [PATCH v4 1/7] mtd: spi-nor: sfdp: get octal mode maximum speed from BFPT > > On 29/05/20 03:36PM, Mason Yang wrote: > > Get maximum operation speed of device in octal mode from > > BFPT 20th DWORD. > > I don't like the idea of getting the maximum operation

Re: [GIT PULL] EFI changes for v5.8

2020-06-02 Thread Ard Biesheuvel
On Tue, 2 Jun 2020 at 01:02, Linus Torvalds wrote: > > On Mon, Jun 1, 2020 at 1:38 PM Linus Torvalds > wrote: > > > > Ok, I'll try to remember, but I probably won't. So it would be lovely > > to be reminded when I get the arm pull. > > Well, the arm pull already came in, and mentioned it, and it

[PATCH 1/3] ARM: dts: imx: Change sdhci node name on i.MX27/i.MX31 SoCs

2020-06-02 Thread Anson Huang
Change i.MX27/i.MX31 node name from sdhci to mmc to be compliant with yaml schema, it requires the nodename to be "mmc". Signed-off-by: Anson Huang --- arch/arm/boot/dts/imx27.dtsi | 6 +++--- arch/arm/boot/dts/imx31.dtsi | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 3/3] ARM: dts: imx: Change usdhc node name on i.MX6/i.MX7 SoCs

2020-06-02 Thread Anson Huang
Change i.MX6/i.MX7 SoCs usdhc node name from usdhc to mmc to be compliant with yaml schema, it requires the nodename to be "mmc". Signed-off-by: Anson Huang --- arch/arm/boot/dts/imx6qdl.dtsi | 8 arch/arm/boot/dts/imx6sl.dtsi | 8 arch/arm/boot/dts/imx6sx.dtsi | 8

[PATCH 2/3] ARM: dts: imx: Change esdhc node name on i.MX2/i.MX3/i.MX5 SoCs

2020-06-02 Thread Anson Huang
Change i.MX2/i.MX3/i.MX5 SoCs esdhc node name from esdhc to mmc to be compliant with yaml schema, it requires the nodename to be "mmc". Signed-off-by: Anson Huang --- arch/arm/boot/dts/imx25.dtsi | 4 ++-- arch/arm/boot/dts/imx35.dtsi | 6 +++--- arch/arm/boot/dts/imx50.dtsi | 8

Re: [RFC][PATCH] usb: typec: tcpci_rt1711h: Try to avoid screaming irq causing boot hangs

2020-06-02 Thread Jun Li
Hi, John Stultz 于2020年6月2日周二 上午4:39写道: > > On Sat, May 30, 2020 at 3:30 AM Jun Li wrote: > > > > Hi John, > > > > John Stultz 于2020年5月30日周六 下午12:02写道: > > > > > > I've recently (since 5.7-rc1) started noticing very rare hangs > > > pretty early in bootup on my HiKey960 board. > > > > > > They

Re: [PATCH v4 7/7] mtd: spi-nor: macronix: Add Octal 8D-8D-8D supports for Macronix mx25uw51245g

2020-06-02 Thread masonccyang
Hi Pratyush, > Subject > > Re: [PATCH v4 7/7] mtd: spi-nor: macronix: Add Octal 8D-8D-8D supports for > Macronix mx25uw51245g > > On 29/05/20 03:36PM, Mason Yang wrote: > > Macronix mx25uw51245g is a SPI NOR that supports 1-1-1/8-8-8 mode. > > > > Correct the dummy cycles to device for

Re: [PATCH 1/1] blk-mq: get ctx in order to handle BLK_MQ_S_INACTIVE in blk_mq_get_tag()

2020-06-02 Thread Ming Lei
On Mon, Jun 01, 2020 at 11:17:49PM -0700, Dongli Zhang wrote: > When scheduler is set, we hit below page fault when we offline cpu. > > [ 1061.007725] BUG: kernel NULL pointer dereference, address: 0040 > [ 1061.008710] #PF: supervisor read access in kernel mode > [ 1061.009492] #PF:

[PATCH] net: genetlink: Fix memleak in genl_family_rcv_msg_dumpit()

2020-06-02 Thread YueHaibing
dumpit info is freed by cb->done now (genl_lock_done()/ genl_parallel_done()), however if any error occurs before cb->done is called, info and attrs will leak. unreferenced object 0x888119904840 (size 32): comm "syz-executor.0", pid 857, jiffies 4295306979 (age 18.692s) hex dump (first 32

Re: [PATCH 5.6 000/177] 5.6.16-rc1 review

2020-06-02 Thread Naresh Kamboju
On Mon, 1 Jun 2020 at 23:43, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.6.16 release. > There are 177 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > >

Re: [PATCH 4/6] vhost_vdpa: support doorbell mapping via mmap

2020-06-02 Thread Jason Wang
On 2020/6/2 下午12:56, Michael S. Tsirkin wrote: On Tue, Jun 02, 2020 at 03:22:49AM +0800, kbuild test robot wrote: Hi Jason, I love your patch! Yet something to improve: [auto build test ERROR on vhost/linux-next] [also build test ERROR on linus/master v5.7 next-20200529] [if your patch is

Re: [PATCH 5.4 000/142] 5.4.44-rc1 review

2020-06-02 Thread Naresh Kamboju
On Mon, 1 Jun 2020 at 23:36, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.4.44 release. > There are 142 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > >

Re: [PATCH] i2c: sh_mobile: Fix compilation warning

2020-06-02 Thread Wolfram Sang
> Almost after an year, wondering on how you reached this patch now :) Another developer sent the same patch. And last time I was unsure if I liked the new code better (for reasons I can't recall anymore); this time it was clear to me. signature.asc Description: PGP signature

[PATCH] seg6: Fix slab-out-of-bounds in fl6_update_dst()

2020-06-02 Thread YueHaibing
When update flowi6 daddr in fl6_update_dst() for srcrt, the used index of segments should be segments_left minus one per RFC8754 (section 4.3.1.1) S15 S16. Otherwise it may results in an out-of-bounds read. Reported-by: syzbot+e8c028b62439eac42...@syzkaller.appspotmail.com Fixes: 0cb7498f234e

Re: [PATCH v5 4/5] cpufreq: qcom: Update the bandwidth levels on frequency change

2020-06-02 Thread Sibi Sankar
On 2020-06-01 16:31, Viresh Kumar wrote: On 29-05-20, 17:00, Sibi Sankar wrote: > > +static int qcom_cpufreq_update_opp(struct device *cpu_dev, > > +unsigned long freq_khz, > > +unsigned long volt) > > +{ > > + unsigned long

RE: [PATCH] driver core: platform: expose numa_node to users in sysfs

2020-06-02 Thread Song Bao Hua (Barry Song)
> > > > On Tue, Jun 02, 2020 at 05:09:57AM +, Song Bao Hua (Barry Song) > wrote: > > > > > > > > > > Platform devices are NUMA? That's crazy, and feels like a total > > > > > abuse of platform devices and drivers that really should belong > > > > > on a > > "real" > > > > > bus. > > > > > > >

Re: [PATCH 1/6] vhost: allow device that does not depend on vhost worker

2020-06-02 Thread Jason Wang
On 2020/6/2 下午1:01, Michael S. Tsirkin wrote: On Fri, May 29, 2020 at 04:02:58PM +0800, Jason Wang wrote: diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index d450e16c5c25..70105e045768 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.c @@ -166,11 +166,16 @@ static int

[PATCH v3 2/3] crypto: virtio: Fix use-after-free in virtio_crypto_skcipher_finalize_req()

2020-06-02 Thread Longpeng(Mike)
The system'll crash when the users insmod crypto/tcrypto.ko with mode=155 ( testing "authenc(hmac(sha1),cbc(aes))" ). It's caused by reuse the memory of request structure. In crypto_authenc_init_tfm(), the reqsize is set to: [PART 1] sizeof(authenc_request_ctx) + [PART 2] ictx->reqoff +

[PATCH v3 0/3] crypto: virtio: Fix three issues

2020-06-02 Thread Longpeng(Mike)
Patch 1 & 2: fix two crash issues, Link: https://lkml.org/lkml/2020/1/23/205 Patch 3: fix another functional issue Changes since v2: - put another bugfix together Changes since v1: - remove some redundant checks [Jason] - normalize the commit message [Markus] Cc: Gonglei Cc: Herbert Xu Cc:

Re: [PATCH v6 0/5] Micron SLC NAND filling block

2020-06-02 Thread Miquel Raynal
Hello Bean Huo wrote on Mon, 01 Jun 2020 23:10:43 +0200: > Hi Richard > would you please help us confirm below question?? > > Thanks, > Bean > > On Thu, 2020-05-28 at 16:14 +0200, Bean Huo wrote: > > hi, Richard > > > > > > On Mon, 2020-05-25 at 14:18 +0200, Bean Huo wrote: > > > After

[PATCH v3 3/3] crypto: virtio: Fix dest length calculation in __virtio_crypto_skcipher_do_req()

2020-06-02 Thread Longpeng(Mike)
The src/dst length is not aligned with AES_BLOCK_SIZE(which is 16) in some testcases in tcrypto.ko. For example, the src/dst length of one of cts(cbc(aes))'s testcase is 17, the crypto_virtio driver will set @src_data_len=16 but @dst_data_len=17 in this case and get a wrong at then end. SRC:

[PATCH v3 1/3] crypto: virtio: Fix src/dst scatterlist calculation in __virtio_crypto_skcipher_do_req()

2020-06-02 Thread Longpeng(Mike)
The system will crash when the users insmod crypto/tcrypt.ko with mode=38 ( testing "cts(cbc(aes))" ). Usually the next entry of one sg will be @sg@ + 1, but if this sg element is part of a chained scatterlist, it could jump to the start of a new scatterlist array. Fix it by sg_next() on

Re: iommu: Improve exception handling in iommu_group_alloc()

2020-06-02 Thread Markus Elfring
>> Do you disagree to the application of the Linux coding style then >> for the recommended exception handling? > > No, that's not what I mean. My point is the exception handling in this > patch is simple and no need to add 'goto' statement which does not help > to improve readability. Do we come

Re: [PATCH net-next] mlx5: Restore err assignment in mlx5_mdev_init

2020-06-02 Thread Leon Romanovsky
On Mon, Jun 01, 2020 at 09:07:48PM -0700, Nathan Chancellor wrote: > On Sun, May 31, 2020 at 12:58:10PM +0300, Leon Romanovsky wrote: > > On Fri, May 29, 2020 at 10:54:48PM -0700, Nathan Chancellor wrote: > > > Clang warns: > > > > > > drivers/net/ethernet/mellanox/mlx5/core/main.c:1278:6:

Re: [PATCH 5/6] vdpa: introduce virtio pci driver

2020-06-02 Thread Jason Wang
On 2020/6/2 下午1:08, Michael S. Tsirkin wrote: On Fri, May 29, 2020 at 04:03:02PM +0800, Jason Wang wrote: +static void vp_vdpa_set_vq_ready(struct vdpa_device *vdpa, +u16 qid, bool ready) +{ + struct vp_vdpa *vp_vdpa = vdpa_to_vp(vdpa); + +

Re: [PATCH v4 00/15] virtio-mem: paravirtualized memory

2020-06-02 Thread David Hildenbrand
On 07.05.20 16:01, David Hildenbrand wrote: > This series is based on v5.7-rc4. The patches are located at: > https://github.com/davidhildenbrand/linux.git virtio-mem-v4 > > This is basically a resend of v3 [1], now based on v5.7-rc4 and restested. > One patch was reshuffled and two ACKs I

RE: [PATCH v1] PCI: dwc: convert to devm_platform_ioremap_resource_byname()

2020-06-02 Thread Gustavo Pimentel
On Thu, May 28, 2020 at 17:15:10, Dejin Zheng wrote: > Use devm_platform_ioremap_resource_byname() to simplify codes. > it contains platform_get_resource_byname() and devm_ioremap_resource(). > > Signed-off-by: Dejin Zheng > --- > drivers/pci/controller/dwc/pci-dra7xx.c | 11

Re: [PATCH 5/6] vdpa: introduce virtio pci driver

2020-06-02 Thread Jason Wang
On 2020/6/2 下午1:09, Michael S. Tsirkin wrote: On Fri, May 29, 2020 at 04:03:02PM +0800, Jason Wang wrote: Note that since virtio specification does not support get/restore virtqueue state. So we can not use this driver for VM. This can be addressed by extending the virtio specification.

RE: [PATCH 2/4] firmware: imx: add resource management api

2020-06-02 Thread Aisheng Dong
> From: Peng Fan > Sent: Tuesday, June 2, 2020 1:24 PM > > > Subject: RE: [PATCH 2/4] firmware: imx: add resource management api > > > > > From: Peng Fan > > > Sent: Thursday, April 23, 2020 3:00 PM > > > > > > Add resource management API, when we have multiple partition running > > > together,

RE: Bug in your kernel since version 5.2

2020-06-02 Thread 吳昊澄 Ricky
Hi Philip, We can't reproduce this problem on general platform on our side, it works well on our platforms that we have, but we don’t have NUC7PJYH platform to check this. This patch (bede03a579b3b4a036003c4862cc1baa4ddc351f) should not affect rts5229, we didn’t do anything on rts5229 Ricky

Re: [PATCH v4 1/4] KEYS: trusted: Add generic trusted keys framework

2020-06-02 Thread Jarkko Sakkinen
On Mon, Jun 01, 2020 at 02:41:55PM +0530, Sumit Garg wrote: > > This, I think is wrong. You should have a compile time flag for TPM e.g. > > CONFIG_TRUSTED_TPM, not this dynamic mess. > > > > The whole idea to have it dynamic was to have a common trusted keys > module which could support both TPM

Re: [PATCH v2 1/4] iio: chemical: scd30: add core driver

2020-06-02 Thread Tomasz Duszynski
On Mon, Jun 01, 2020 at 02:41:20PM +0100, Jonathan Cameron wrote: > ... > > > > > > > + > > > > > > + return ret; > > > > > > +} > > > > > > + > > > > > > +int scd30_probe(struct device *dev, int irq, const char *name, > > > > > > void *priv, > > > > > > + scd30_command_t command) > >

Re: [PATCH] iommu/vt-d: Don't apply gfx quirks to untrusted devices

2020-06-02 Thread Lu Baolu
On 2020/6/2 13:45, Rajat Jain wrote: Currently, an external malicious PCI device can masquerade the VID:PID of faulty gfx devices, and thus apply iommu quirks to effectively disable the IOMMU restrictions for itself. Thus we need to ensure that the device we are applying quirks to, is indeed an

Re: [PATCH v4 1/4] KEYS: trusted: Add generic trusted keys framework

2020-06-02 Thread Jarkko Sakkinen
On Mon, Jun 01, 2020 at 02:20:26PM +0530, Sumit Garg wrote: > On Mon, 1 Jun 2020 at 07:30, Jarkko Sakkinen > wrote: > > > > On Wed, May 06, 2020 at 03:10:14PM +0530, Sumit Garg wrote: > > > Current trusted keys framework is tightly coupled to use TPM device as > > > an underlying implementation

Re: [PATCHv1 00/19] Improve SBS battery support

2020-06-02 Thread Marek Szyprowski
Hi Sebastian, On 01.06.2020 19:05, Sebastian Reichel wrote: > On Mon, Jun 01, 2020 at 12:40:27PM +0200, Marek Szyprowski wrote: >> On 13.05.2020 20:55, Sebastian Reichel wrote: >>> This patchset improves support for SBS compliant batteries. Due to >>> the changes, the battery now exposes 32 power

[PATCH] lightnvm: pblk: Fix kobject memleak

2020-06-02 Thread Wang Hai
Currently the error return path from kobject_init_and_add() is not followed by a call to kobject_put() - which means we are leaking the kobject. Fix it by adding a call to kobject_put() in the error path of kobject_init_and_add(). Fixes: a4bd217b4326 ("lightnvm: physical block device (pblk)

linux-next: manual merge of the hyperv tree with the kvm tree

2020-06-02 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the hyperv tree got a conflict in: arch/x86/include/asm/hyperv-tlfs.h between commit: 22ad0026d097 ("x86/hyper-v: Add synthetic debugger definitions") from the kvm tree and commit: c55a844f46f9 ("x86/hyperv: Split hyperv-tlfs.h into arch dependent

Re: [PATCH] ipv4: nexthop: Fix deadcode issue by performing a proper NULL check

2020-06-02 Thread Nikolay Aleksandrov
On 01/06/2020 21:06, David Miller wrote: > From: patrickeigens...@gmail.com > Date: Mon, 1 Jun 2020 13:12:01 +0200 > >> From: Patrick Eigensatz >> >> After allocating the spare nexthop group it should be tested for kzalloc() >> returning NULL, instead the already used nexthop group (which

Re: [PATCH 1/1] s390/pci: Log new handle in clp_disable_fh()

2020-06-02 Thread Niklas Schnelle
Hi Petr, sorry for not reacting sooner, I was on holiday, saw your message but figured it wasn't super critical. Thanks for finding this issue and thank you Pierre and Vasily for stepping in. Best, Niklas Schnelle On 5/28/20 11:08 AM, Petr Tesarik wrote: > Hi all, > > just a gentle ping. > >

[ANNOUNCE] 4.4.225-rt198

2020-06-02 Thread Daniel Wagner
Hello RT-list! I'm pleased to announce the 4.4.225-rt198 stable release. This release is just an update to the new stable 4.4.215 version and no RT specific changes have been made. Known issues: sigwaittest with hackbench as workload is able to trigger a crash on x86_64, the same as

RE: [PATCH 2/4] firmware: imx: add resource management api

2020-06-02 Thread Aisheng Dong
> From: Peng Fan > Sent: Tuesday, June 2, 2020 12:51 PM > > > > > From: Peng Fan > > > Sent: Monday, June 1, 2020 8:40 PM > > > > > > > > > From: Peng Fan > > > > > Sent: Friday, April 24, 2020 9:12 AM > > > > > > > > > > > > > From: Peng Fan > > > > > > > Sent: Thursday, April 23, 2020 6:57

Re: linux-next: Fixes tag needs some work in the net-next tree

2020-06-02 Thread Ayush Sawal
Hi Stephen & David, On 6/2/2020 4:42 AM, Stephen Rothwell wrote: Hi all, In commit 055be6865dea ("Crypto/chcr: Fixes a coccinile check error") Fixes tag Fixes: 567be3a5d227 ("crypto: has these problem(s): - Subject has leading but no trailing parentheses - Subject has leading

Re: [PATCH 2/2] coresight: tmc: Add shutdown callback for TMC ETR/ETF

2020-06-02 Thread Sai Prakash Ranjan
Hi Mathieu, Thanks for taking your time for review. On 2020-06-02 02:58, Mathieu Poirier wrote: Hi Sai, On top of the comments already privided by Mike, I have the following: On Mon, Jun 01, 2020 at 01:32:26PM +0530, Sai Prakash Ranjan wrote: Implement a shutdown callback to ensure ETR/ETF

Re: [GIT PULL] x86/mm changes for v5.8

2020-06-02 Thread Ingo Molnar
* Balbir Singh wrote: > > At a _minimum_, SMT being enabled should disable this kind of crazy > > pseudo-security entirely, since it is completely pointless in that > > situation. Scheduling simply isn't a synchronization point with SMT > > on, so saying "sure, I'll flush the L1 at context

Re: [PATCH 4.14 00/77] 4.14.183-rc1 review

2020-06-02 Thread Naresh Kamboju
On Mon, 1 Jun 2020 at 23:30, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.14.183 release. > There are 77 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > >

linux-next: build failure after merge of the hyperv tree

2020-06-02 Thread Stephen Rothwell
Hi all, After merging the hyperv tree, today's linux-next build (x86_64 allmodconfig) failed like this: arch/x86/kvm/hyperv.c: In function 'kvm_vcpu_ioctl_get_hv_cpuid': arch/x86/kvm/hyperv.c:2020:16: error: 'HV_X64_DEBUGGING' undeclared (first use in this function); did you mean

Re: [PATCH 2/2] objtool: Add support for relocations without addends

2020-06-02 Thread Julien Thierry
Hi Matt, On 5/29/20 10:01 PM, Matt Helsley wrote: Currently objtool only collects information about relocations with addends. In recordmcount, which we are about to merge into objtool, some supported architectures do not use rela relocations. Signed-off-by: Matt Helsley ---

Re: [PATCH] ipv4: nexthop: Fix deadcode issue by performing a proper NULL check

2020-06-02 Thread Nikolay Aleksandrov
On 02/06/2020 10:23, Nikolay Aleksandrov wrote: > On 01/06/2020 21:06, David Miller wrote: >> From: patrickeigens...@gmail.com >> Date: Mon, 1 Jun 2020 13:12:01 +0200 >> >>> From: Patrick Eigensatz >>> >>> After allocating the spare nexthop group it should be tested for kzalloc() >>> returning

Re: [PATCH] block/bio-integrity: don't free 'buf' if bio_integrity_add_page() failed

2020-06-02 Thread Ming Lei
On Mon, Jun 01, 2020 at 08:38:56PM +0800, yu kuai wrote: > commit e7bf90e5afe3 ("block/bio-integrity: fix a memory leak bug") add a > kree() for 'buf' if bio_integrity_add_page() return '0'. However, the > object will be freed in bio_integrity_free() since 'bio->bi_opf' and > 'bio->bi_integrity'

Re: [PATCH v1] PCI: controller: Remove duplicate error message

2020-06-02 Thread Chocron, Jonathan
On Wed, 2020-05-27 at 21:20 +0800, Dejin Zheng wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you can confirm the sender > and know the content is safe. > > > > On Tue, May 26, 2020 at 06:22:56PM +, Chocron, Jonathan

Re: [PATCH 4.19 00/95] 4.19.126-rc1 review

2020-06-02 Thread Naresh Kamboju
On Mon, 1 Jun 2020 at 23:33, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.19.126 release. > There are 95 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > >

Re: [PATCH v2] check: Add 10bit/slave i2c reg flags support

2020-06-02 Thread Wolfram Sang
> Easier to just duplicate the define here which Joel's patches do. Well, seems this case is closed then. Thanks everyone! signature.asc Description: PGP signature

Re: [PATCH v6 0/5] Micron SLC NAND filling block

2020-06-02 Thread Boris Brezillon
Hi Bean, On Mon, 01 Jun 2020 23:10:43 +0200 Bean Huo wrote: > Hi Richard > would you please help us confirm below question?? Miquel suggested an approach that would allow us to deal with both JFFS2 and UBI/UBIFS without having any FS/wear-leveling specific code at the NAND level, but you

RE: [PATCH 2/4] firmware: imx: add resource management api

2020-06-02 Thread Peng Fan
> Subject: RE: [PATCH 2/4] firmware: imx: add resource management api > > > From: Peng Fan > > Sent: Tuesday, June 2, 2020 12:51 PM > > > > > > > From: Peng Fan > > > > Sent: Monday, June 1, 2020 8:40 PM > > > > > > > > > > > From: Peng Fan > > > > > > Sent: Friday, April 24, 2020 9:12 AM > >

Re: [PATCH v2 3/3] iio: remove iio_triggered_buffer_postenable()/iio_triggered_buffer_predisable()

2020-06-02 Thread Ardelean, Alexandru
On Sun, 2020-05-31 at 16:40 +0100, Jonathan Cameron wrote: > On Mon, 25 May 2020 14:38:55 +0300 > Alexandru Ardelean wrote: > > > From: Lars-Peter Clausen > > > > This patch should be squashed into the first one, as the first one is > > breaking the build (intentionally) to make the IIO core

Re: [PATCH 1/1] blk-mq: get ctx in order to handle BLK_MQ_S_INACTIVE in blk_mq_get_tag()

2020-06-02 Thread Daniel Wagner
On Mon, Jun 01, 2020 at 11:17:49PM -0700, Dongli Zhang wrote: > When scheduler is set, we hit below page fault when we offline cpu. > > [ 1061.007725] BUG: kernel NULL pointer dereference, address: 0040 > [ 1061.008710] #PF: supervisor read access in kernel mode > [ 1061.009492] #PF:

Re: [PATCH v4 08/10] PCI: qcom: Add ipq8064 rev2 variant and set tx term offset

2020-06-02 Thread Stanimir Varbanov
Hi, On 5/14/20 11:07 PM, Ansuel Smith wrote: > Add tx term offset support to pcie qcom driver need in some revision of > the ipq806x SoC. Ipq8064 have tx term offset set to 7. Ipq8064-v2 revision > and ipq8065 have the tx term offset set to 0. > > Signed-off-by: Sham Muthayyan > Signed-off-by:

Re: [PATCH v2 01/12] iio: imu: inv_icm42600: add core of new inv_icm42600 driver

2020-06-02 Thread Jean-Baptiste Maneyrol
Hi Jonathan, I've given my review tag for the const change of iio_device_get_drvdata(). Would be perfect to have this cleaned up for the v3. For vddio regulator you are missing something. In all suspend callbacks (system and runtime) I am calling directly regulator_disable to shut vddio off at

Re: [PATCH v2] iommu: Improve exception handling in iommu_group_alloc()

2020-06-02 Thread Markus Elfring
> Improve the exception handling to free the resources correctly when > failed to allocate an iommu group. I propose to avoid the specification of duplicate function calls. Will it become helpful to add a few jump targets?

Re: [PATCH v3 2/2] checks: Improve i2c reg property checking

2020-06-02 Thread Serge Semin
On Thu, May 28, 2020 at 06:26:50PM +0930, Joel Stanley wrote: > The i2c bindings in the kernel tree describe support for 10 bit > addressing, which must be indicated with the I2C_TEN_BIT_ADDRESS flag. > When this is set the address can be up to 10 bits. When it is not set > the address is a

Re: [v4,1/1] hwmon: (nct7904) Add watchdog function

2020-06-02 Thread Geert Uytterhoeven
Hi Yuechao, On Tue, Mar 31, 2020 at 7:30 AM wrote: > From: Yuechao Zhao > > implement watchdong functionality into the "hwmon/nct7904.c" > > Signed-off-by: Yuechao Zhao Thanks for your patch, which is now commit 77849a552d142ef5 ("hwmon: (nct7904) Add watchdog function"). > ---

Re: [PATCH] block/bio-integrity: don't free 'buf' if bio_integrity_add_page() failed

2020-06-02 Thread Bob Liu
On 6/1/20 8:38 PM, yu kuai wrote: > commit e7bf90e5afe3 ("block/bio-integrity: fix a memory leak bug") add a > kree() for 'buf' if bio_integrity_add_page() return '0'. However, the > object will be freed in bio_integrity_free() since 'bio->bi_opf' and > 'bio->bi_integrity' was set previousy in

Re: [PATCH v2 net-next 00/10] net: ocelot: VCAP IS1 and ES0 support

2020-06-02 Thread Vladimir Oltean
Hi Xiaoliang, On Tue, 2 Jun 2020 at 08:25, Xiaoliang Yang wrote: > > This series patches adds support for VCAP IS1 and ES0 module, each VCAP > correspond to a flow chain to offload. > > VCAP IS1 supports FLOW_ACTION_VLAN_MANGLE action to filter MAC, IP, > VLAN, protocol, and TCP/UDP ports keys

Re: [PATCH 1/1] blk-mq: get ctx in order to handle BLK_MQ_S_INACTIVE in blk_mq_get_tag()

2020-06-02 Thread Bob Liu
On 6/2/20 2:17 PM, Dongli Zhang wrote: > When scheduler is set, we hit below page fault when we offline cpu. > > [ 1061.007725] BUG: kernel NULL pointer dereference, address: 0040 > [ 1061.008710] #PF: supervisor read access in kernel mode > [ 1061.009492] #PF: error_code(0x) -

[PATCH] tcp: fix TCP socks unreleased in BBR mode

2020-06-02 Thread kerneljasonxing
From: Jason Xing TCP socks cannot be released because of the sock_hold() increasing the sk_refcnt in the manner of tcp_internal_pacing() when RTO happens. Therefore, this situation could increase the slab memory and then trigger the OOM if the machine has beening running for a long time. This

[PATCH net-next v2] af-packet: new flag to indicate all csums are good

2020-06-02 Thread Victor Julien
Introduce a new flag (TP_STATUS_CSUM_UNNECESSARY) to indicate that the driver has completely validated the checksums in the packet. The TP_STATUS_CSUM_UNNECESSARY flag differs from TP_STATUS_CSUM_VALID in that the new flag will only be set if all the layers are valid, while TP_STATUS_CSUM_VALID

Re: [RFC PATCH v5 1/6] dt-bindings: exynos-bus: Add documentation for interconnect properties

2020-06-02 Thread Krzysztof Kozlowski
On Fri, May 29, 2020 at 06:31:55PM +0200, Sylwester Nawrocki wrote: > Add documentation for new optional properties in the exynos bus nodes: > samsung,interconnect-parent, #interconnect-cells. > These properties allow to specify the SoC interconnect structure which > then allows the interconnect

[PATCH v4 1/2] clk: rockchip: rk3288: Handle clock tree for rk3288w

2020-06-02 Thread Mylène Josserand
The revision rk3288w has a different clock tree about "hclk_vio" clock, according to the BSP kernel code. This patch handles this difference by detecting which device-tree we are using. If it is a "rockchip,rk3288-cru", let's register the clock tree as it was before. If the device-tree node is

[PATCH v4 2/2] dt-bindings: clocks: rk3288: add rk3288w compatible

2020-06-02 Thread Mylène Josserand
Add the possible compatible "rockchip,rk3288w-cru" that handles the difference between the rk3288 and the new revision rk3288w. This compatible will be added by bootloaders. Signed-off-by: Mylène Josserand --- .../devicetree/bindings/clock/rockchip,rk3288-cru.txt | 8 +++- 1 file

[PATCH v4 0/2] ARM: Add Rockchip rk3288w support

2020-06-02 Thread Mylène Josserand
Hello everyone, Context --- Here is my V4 of my patches that add the support for the Rockchip RK3288w which is a revision of the RK3288. It is mostly the same SOC except for, at least, one clock tree which is different. This difference is only known by looking at the BSP kernel [1].

Re: [PATCH net] net: mvpp2: Enable autoneg bypass for 1000BaseX/2500BaseX ports

2020-06-02 Thread Thomas Bogendoerfer
On Fri, 29 May 2020 18:33:40 +0200 Andrew Lunn wrote: > > > By propagated, you mean if the external link is down, the link between > > > the switch and node 1 will also be forced down, at the SERDES level? > > > > yes > > > > > And if external ports are down, the nodes cannot talk to each

Re: [PATCH] serial: 8250_port: Fix imprecise external abort for mctrl if inactive

2020-06-02 Thread Johan Hovold
On Mon, Jun 01, 2020 at 05:18:13PM -0700, Tony Lindgren wrote: > We can get an imprecise external abort on uart_shutdown() at > serial8250_do_set_mctrl() if the UART is autoidled. > > We don't want to add PM runtime calls to serial8250_do_set_mctrl() > beyond checking the usage count as it gets

Re: [PATCH net-next v2] af-packet: new flag to indicate all csums are good

2020-06-02 Thread Victor Julien
Need to learn how to properly do git sendpatch, apologies if i'm not following proper procedures. This v2 fixes up the doc. The output is now tested with rst2pdf and looks good. Added in a trivial related doc fixup. I wasn't completely sure if I was supposed to use tabs or spaces in rst, so did

[PATCH v6 1/2] dt-bindings: rng: add bindings for sec-rng

2020-06-02 Thread Neal Liu
Add bindings for ARM TrustZone based Security Random Number Generator. Signed-off-by: Neal Liu --- Documentation/devicetree/bindings/rng/sec-rng.yaml | 53 1 file changed, 53 insertions(+) create mode 100644 Documentation/devicetree/bindings/rng/sec-rng.yaml diff --git

Security Random Number Generator support

2020-06-02 Thread Neal Liu
These patch series introduce a security random number generator which provides a generic interface to get hardware rnd from Secure state. The Secure state can be Arm Trusted Firmware(ATF), Trusted Execution Environment(TEE), or even EL2 hypervisor. Patch #1..2 adds sec-rng kernel driver for

[PATCH v6 2/2] hwrng: add sec-rng driver

2020-06-02 Thread Neal Liu
For security awareness SoCs on ARMv8 with TrustZone enabled, peripherals like entropy sources is not accessible from normal world (linux) and rather accessible from secure world (HYP/ATF/TEE) only. This driver aims to provide a generic interface to Arm Trusted Firmware or Hypervisor rng service.

Re: [PATCHv2] perf stat: Ensure group is defined on top of the same cpu mask

2020-06-02 Thread Jiri Olsa
On Tue, Jun 02, 2020 at 11:47:19AM +0900, Namhyung Kim wrote: > On Tue, Jun 2, 2020 at 1:21 AM Ian Rogers wrote: > > > > On Mon, Jun 1, 2020 at 1:20 AM Jiri Olsa wrote: > > > > > > Jin Yao reported the issue (and posted first versions of this change) > > > with groups being defined over events

[GIT PULL] platform-drivers-x86 for 5.8-1

2020-06-02 Thread Andy Shevchenko
Hi Linus, Rather big pile of patches for PDx86 for v5.8. It includes three merges, one is cross MFD-USB-PDx86, another is DriverCore-PDx86, and the last one is established merge practice of Intel Speed Select tooling. Nevertheless, no conflicts found during test merge with most recent contents

Re: [PATCH 00/10] spi: Adding support for Microchip Sparx5 SoC

2020-06-02 Thread Lars Povlsen
Serge Semin writes: > Hello Lars, > > On Wed, May 13, 2020 at 04:00:21PM +0200, Lars Povlsen wrote: >> This is an add-on series to the main SoC Sparx5 series >> (Message-ID: <20200513125532.24585-1-lars.povl...@microchip.com>). >> >> The series add support for Sparx5 on top of the existing >>

Re: tegra124-jetson-tk1: sata doesnt work since 5.2

2020-06-02 Thread LABBE Corentin
On Mon, Jun 01, 2020 at 05:30:37PM +0300, Dmitry Osipenko wrote: > 31.05.2020 22:31, LABBE Corentin пишет: > > On Thu, Mar 19, 2020 at 08:44:01AM +0100, LABBE Corentin wrote: > >> Hello > >> > >> sata doesnt work on tegra124-jetson-tk1 on next and master and at least > >> since 5.2 (but 5.1

Re: [RFC PATCH v5 2/6] interconnect: Add generic interconnect driver for Exynos SoCs

2020-06-02 Thread Krzysztof Kozlowski
On Fri, May 29, 2020 at 06:31:56PM +0200, Sylwester Nawrocki wrote: > This patch adds a generic interconnect driver for Exynos SoCs in order > to provide interconnect functionality for each "samsung,exynos-bus" > compatible device. > > The SoC topology is a graph (or more specifically, a tree)

Re: [PATCH 00/10] spi: Adding support for Microchip Sparx5 SoC

2020-06-02 Thread Serge Semin
On Tue, Jun 02, 2020 at 10:18:28AM +0200, Lars Povlsen wrote: > > Serge Semin writes: > > > Hello Lars, > > > > On Wed, May 13, 2020 at 04:00:21PM +0200, Lars Povlsen wrote: > >> This is an add-on series to the main SoC Sparx5 series > >> (Message-ID:

arch/x86/ia32/ia32_signal.c:350:9: sparse: sparse: cast removes address space '' of expression

2020-06-02 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162 commit: 57d563c8292569f2849569853e846bf740df5032 x86: ia32_setup_rt_frame(): consolidate uaccess areas date: 10 weeks ago :: branch date: 9 hours ago ::

[PATCH] spi: sprd: switch the sequence of setting WDG_LOAD_LOW and _HIGH

2020-06-02 Thread Chunyan Zhang
From: Lingling Xu The watchdog counter consists of WDG_LOAD_LOW and WDG_LOAD_HIGH, which would be loaded to watchdog counter once writing WDG_LOAD_LOW. Fixes: ac1775012058 ("spi: sprd: Add the support of restarting the system") Signed-off-by: Lingling Xu Signed-off-by: Chunyan Zhang ---

Re: [PATCH v2 2/6] mfd: add support for the Khadas System control Microcontroller

2020-06-02 Thread Neil Armstrong
On 20/05/2020 11:01, Lee Jones wrote: > On Tue, 12 May 2020, Neil Armstrong wrote: > >> This Microcontroller is present on the Khadas VIM1, VIM2, VIM3 and Edge >> boards. >> >> It has multiple boot control features like password check, power-on >> options, power-off control and system FAN control

Re: [PATCH v2 3/6] thermal: add support for the MCU controlled FAN on Khadas boards

2020-06-02 Thread Neil Armstrong
On 15/05/2020 08:41, Amit Kucheria wrote: > On Tue, May 12, 2020 at 6:56 PM Neil Armstrong > wrote: >> >> The new Khadas VIM2 and VIM3 boards controls the cooling fan via the >> on-board microcontroller. >> >> This implements the FAN control as thermal devices and as cell of the Khadas >> MCU

Re: [PATCH] shmem, memcg: enable memcg aware shrinker

2020-06-02 Thread Kirill Tkhai
On 02.06.2020 00:48, Greg Thelen wrote: > Kirill Tkhai wrote: > >> Hi, Greg, >> >> good finding. See comments below. >> >> On 01.06.2020 06:22, Greg Thelen wrote: >>> Since v4.19 commit b0dedc49a2da ("mm/vmscan.c: iterate only over charged >>> shrinkers during memcg shrink_slab()") a memcg aware

Re: [PATCH v3 2/2] checks: Improve i2c reg property checking

2020-06-02 Thread Andy Shevchenko
On Tue, Jun 2, 2020 at 11:03 AM Serge Semin wrote: > On Thu, May 28, 2020 at 06:26:50PM +0930, Joel Stanley wrote: ... > > +#define I2C_TEN_BIT_ADDRESS (1 << 31) > > As Andy neatly pointed out here: > https://lore.kernel.org/lkml/20200527133656.gv1634...@smile.fi.intel.com/ > (1 << 31) is UB.

Re: [PATCH v10] mfd: mt6360: add pmic mt6360 driver

2020-06-02 Thread Lee Jones
On Tue, 02 Jun 2020, Gene Chen wrote: > From: Gene Chen > > Add MFD driver for mt6360 pmic chip include Battery Charger/ > USB_PD/Flash, LED/RGB and LED/LDO/Buck > > Signed-off-by: Gene Chen > Signed-off-by: Lee Jones I did not sign this off. > --- > drivers/mfd/Kconfig| 12 ++ >

Re: [PATCH v2 4/6] nvmem: add support for the Khadas MCU Programmable User Memory

2020-06-02 Thread Neil Armstrong
On 15/05/2020 12:55, Srinivas Kandagatla wrote: > > > On 13/05/2020 13:33, Neil Armstrong wrote: >> On 13/05/2020 12:34, Srinivas Kandagatla wrote: >>> >>> >>> On 12/05/2020 14:26, Neil Armstrong wrote: The new Khadas VIM2, VIM3 and Edge boards embeds an on-board microcontroller

  1   2   3   4   5   6   7   8   9   10   >