Re: [PATCH] [v2] Input: Add "Share" button to Microsoft Xbox One controller.

2021-04-10 Thread Chris Ye
>From the product information site https://www.xbox.com/en-US/accessories/controllers/xbox-wireless-controller this button is referred as "Share button": "Stay on target with textured grip and a hybrid D-pad. Seamlessly capture and share content with a dedicated Share button. Quickly pair with,

[PATCH v1 4/8] scsi: megaraid: clean up for open/close brace

2021-04-10 Thread Luo Jiaxing
There are few kinds of error about open/close brace is reported by checkpatch.pl: ERROR: open brace '{' following function definitions go on the next line int megasas_sync_pd_seq_num(struct megasas_instance *instance, bool pend) { ERROR: else should follow close brace '}' + } + else

[PATCH v1 6/8] scsi: megaraid: clean up for code indent

2021-04-10 Thread Luo Jiaxing
Following error is reported by checkpatch.pl ERROR: code indent should use tabs where possible +^I^Iunsigned long arg)$ So fix them all. Signed-off-by: Luo Jiaxing --- drivers/scsi/megaraid/mega_common.h | 2 +- drivers/scsi/megaraid/megaraid_mm.c | 2 +-

[PATCH v1 2/8] scsi: megaraid_sas: use parentheses to enclose macros with complex values

2021-04-10 Thread Luo Jiaxing
checkpatch.pl report several error below: ERROR: Macros with complex values should be enclosed in parentheses +#define SCP2LUN(scp) (u32)(scp)->device->lun // to LUN ERROR: Macros with complex values should be enclosed in parentheses +#define SCP2ADAPTER(scp) (adapter_t

[PATCH -next] staging: comedi: tests: ni_routes_test: Remove unused variable 'olddevroutes'

2021-04-10 Thread Qiheng Lin
GCC reports the following warning with W=1: drivers/staging/comedi/drivers/tests/ni_routes_test.c:215:45: warning: variable 'olddevroutes' set but not used [-Wunused-but-set-variable] 215 | const struct ni_device_routes *devroutes, *olddevroutes; |

Re: [PATCH] mm/frontswap: fix frontswap_register_ops() race with swapon and swapoff

2021-04-10 Thread Miaohe Lin
Hi: On 2021/4/5 18:20, Miaohe Lin wrote: > frontswap_register_ops can race with swapon. Consider the following scene: Any comment or suggestion? Or is this race window too theoretical to fix? Thanks. > > CPU1 CPU2 > >

Re: [Outreachy kernel] [Resend Patch 0/3] staging: rtl8723bs: Patchset for rtl8723bs

2021-04-10 Thread Greg KH
On Fri, Apr 09, 2021 at 06:39:31PM +0200, Fabio M. De Francesco wrote: > This patch series removes camelcase, changes the type and use of a > variable, and correct misspelled words. > > Patch 1/3: staging: rtl8723bs: Remove camelcase in several files I've again, dropped all patches from you

Re: [PATCH v7 clocksource] Do not mark clocks unstable due to delays for v5.13

2021-04-10 Thread Thomas Gleixner
On Fri, Apr 02 2021 at 15:48, Paul E. McKenney wrote: > Hello! > > If there is a sufficient delay between reading the watchdog clock and the > clock under test, the clock under test will be marked unstable through no > fault of its own. This series checks for this, doing limited retries > to get

Re: [Outreachy kernel] [Patch 0/3]

2021-04-10 Thread Julia Lawall
On Sat, 10 Apr 2021, Greg KH wrote: > On Sat, Apr 10, 2021 at 09:57:00AM +0200, Fabio M. De Francesco wrote: > > On Saturday, April 10, 2021 9:29:29 AM CEST Greg KH wrote: > > > On Fri, Apr 09, 2021 at 06:29:59PM +0200, Fabio M. De Francesco wrote: > > > > This patch series removes camelcases,

[PATCH] Documentation: dev-tools: Add Testing Overview

2021-04-10 Thread David Gow
The kernel now has a number of testing and debugging tools, and we've seen a bit of confusion about what the differences between them are. Add a basic documentation outlining the testing tools, when to use each, and how they interact. This is a pretty quick overview rather than the idealised

Re: [Outreachy kernel] [PATCH 1/3] staging: rtl8192e: replace comparison to NULL by boolean

2021-04-10 Thread Julia Lawall
On Sat, 10 Apr 2021, Mitali Borkar wrote: > Replaced comparison to NULL by boolean expressions > (here used boolean negations). This improves readability of code. > Reported by checkpatch. > > Signed-off-by: Mitali Borkar > --- > drivers/staging/rtl8192e/rtl819x_HTProc.c | 10 +- > 1

Re: [PATCH] ARM: pxa: mainstone: avoid -Woverride-init warning

2021-04-10 Thread Robert Jarzmik
Arnd Bergmann writes: > From: Arnd Bergmann > > On Tue, 23 Mar 2021 14:08:27 +0100, Arnd Bergmann wrote: >> The default initializer at the start of the array causes a warning >> when building with W=1: >> >> In file included from arch/arm/mach-pxa/mainstone.c:47: >>

Re: Bogus struct page layout on 32-bit

2021-04-10 Thread Ilias Apalodimas
+CC Grygorii for the cpsw part as Ivan's email is not valid anymore Thanks for catching this. Interesting indeed... On Sat, 10 Apr 2021 at 09:22, Jesper Dangaard Brouer wrote: > > On Sat, 10 Apr 2021 03:43:13 +0100 > Matthew Wilcox wrote: > > > On Sat, Apr 10, 2021 at 06:45:35AM +0800, kernel

Re: [PATCH v1] pata_ipx4xx_cf: Fix unsigned comparison with less than zero

2021-04-10 Thread Sergei Shtylyov
On 10.04.2021 2:42, angkery wrote: From: Junlin Yang The return from the call to platform_get_irq() is int, it can be a negative error code, however this is being assigned to an unsigned int variable 'irq', so making 'irq' an int, and change the position to keep the code format. Fixes

Re: [PATCH v1 1/1] gpiolib: Read "gpio-line-names" from a firmware node

2021-04-10 Thread Bartosz Golaszewski
On Sat, Apr 10, 2021 at 2:46 AM Marek Vasut wrote: > > On 3/15/21 6:04 PM, Andy Shevchenko wrote: > > On Mon, Mar 15, 2021 at 6:49 PM Bartosz Golaszewski > > wrote: > >> > >> On Mon, Mar 15, 2021 at 3:34 PM Andy Shevchenko > >> wrote: > >>> > >>> On Mon, Mar 15, 2021 at 03:04:37PM +0100,

[PATCH] kconfig: nconf: fix core dump when searching in empty menu

2021-04-10 Thread Masahiro Yamada
The following code in get_mext_match(): index = (index + items_num) % items_num; ... makes the program crash when items_num is zero (that is, the menu is empty). A menu can be empty when all the options in it are hidden by unmet 'depends on'. For example, menu "This menu will be empty"

Re: [Outreachy kernel] [Patch 0/3]

2021-04-10 Thread Greg KH
On Fri, Apr 09, 2021 at 06:29:59PM +0200, Fabio M. De Francesco wrote: > This patch series removes camelcases, changes the type and use of a > variable, and correct misspelled words. > > Patch 1/3: staging: rtl8723bs: Remove camelcase in several files > >

Re: [Outreachy kernel] [Patch 0/3]

2021-04-10 Thread Fabio M. De Francesco
On Saturday, April 10, 2021 9:29:29 AM CEST Greg KH wrote: > On Fri, Apr 09, 2021 at 06:29:59PM +0200, Fabio M. De Francesco wrote: > > This patch series removes camelcases, changes the type and use of a > > variable, and correct misspelled words. > > > > Patch 1/3: staging: rtl8723bs: Remove

Re: [PATCH v7 clocksource 5/5] clocksource: Do pairwise clock-desynchronization checking

2021-04-10 Thread Thomas Gleixner
On Fri, Apr 02 2021 at 15:49, paulmck wrote: > From: "Paul E. McKenney" > > Although smp_call_function() has the advantage of simplicity, using > it to check for cross-CPU clock desynchronization means that any CPU > being slow reduces the sensitivity of the checking across all CPUs. > And it is

Re: Bogus struct page layout on 32-bit

2021-04-10 Thread Jesper Dangaard Brouer
On Sat, 10 Apr 2021 03:43:13 +0100 Matthew Wilcox wrote: > On Sat, Apr 10, 2021 at 06:45:35AM +0800, kernel test robot wrote: > > >> include/linux/mm_types.h:274:1: error: static_assert failed due to > > >> requirement '__builtin_offsetof(struct page, lru) == > > >> __builtin_offsetof(struct

Re: [PATCH 5.10 00/41] 5.10.29-rc1 review

2021-04-10 Thread Naresh Kamboju
On Fri, 9 Apr 2021 at 15:30, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.10.29 release. > There are 41 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > >

Re: [PATCH v7 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-10 Thread Thomas Gleixner
On Fri, Apr 02 2021 at 15:49, paulmck wrote: > > +static void clocksource_verify_percpu_wq(struct work_struct *unused) > +{ > + int cpu; > + struct clocksource *cs; > + int64_t cs_nsec; > + u64 csnow_begin; > + u64 csnow_end; > + u64 delta; Please use reverse fir tree

Re: [PATCH v3 1/2] dw-xdata-pcie: Fix documentation build warns and update outdated info

2021-04-10 Thread Greg Kroah-Hartman
On Wed, Apr 07, 2021 at 10:31:48PM +0200, Gustavo Pimentel wrote: > Fixes documentation build warnings related to indentation and text > formatting, such as: > > Documentation/misc-devices/dw-xdata-pcie.rst:20: WARNING: Unexpected > indentation. > Documentation/misc-devices/dw-xdata-pcie.rst:24:

[PATCH stable] gpiolib: Read "gpio-line-names" from a firmware node

2021-04-10 Thread Bartosz Golaszewski
From: Andy Shevchenko On STM32MP1, the GPIO banks are subnodes of pin-controller@50002000, see arch/arm/boot/dts/stm32mp151.dtsi. The driver for pin-controller@50002000 is in drivers/pinctrl/stm32/pinctrl-stm32.c and iterates over all of its DT subnodes when registering each GPIO bank gpiochip.

Re: [PATCH v2] platform/x86: add Gigabyte WMI temperature driver

2021-04-10 Thread Guenter Roeck
On 4/8/21 9:07 AM, Hans de Goede wrote: > Hi Guenter, > > On 4/8/21 5:08 PM, Guenter Roeck wrote: >> On Mon, Apr 05, 2021 at 10:48:10PM +0200, Thomas Weißschuh wrote: >>> Changes since v1: >>> * Incorporate feedback from Barnabás Pőcze >>> * Use a WMI driver instead of a platform driver >>> *

Re: [PATCH v2] platform/x86: add Gigabyte WMI temperature driver

2021-04-10 Thread Guenter Roeck
On 4/8/21 11:02 PM, Thomas Weißschuh wrote: > On Do, 2021-04-08T08:00-0700, Guenter Roeck wrote: >> On 4/8/21 2:36 AM, Hans de Goede wrote: >>> On 4/7/21 9:43 PM, Thomas Weißschuh wrote: On Mi, 2021-04-07T17:54+0200, Hans de Goede wrote: >>> Jean, Guenter, >>> >>> Thomas has been working on a

[PATCH] kconfig: change sym_change_count into a boolean flag

2021-04-10 Thread Masahiro Yamada
sym_change_count has no good reason to be 'int' type. sym_set_change_count() compares the old and new values after casting both of them to (bool). I do not see any practical diffrence between sym_set_change_count(1) and sym_add_change_count(1). Use the boolean flag, 'conf_changed'.

Re: [PATCH -next] char: xilinx_hwicap: use DEFINE_MUTEX() for mutex lock

2021-04-10 Thread Greg Kroah-Hartman
On Fri, Apr 09, 2021 at 05:51:36PM +0800, Ye Bin wrote: > mutex lock can be initialized automatically with DEFINE_MUTEX() > rather than explicitly calling mutex_init(). > > Reported-by: Hulk Robot > Signed-off-by: Ye Bin > --- > drivers/char/xilinx_hwicap/xilinx_hwicap.c | 3 +-- > 1 file

Re: [PATCH 4.19 00/18] 4.19.186-rc1 review

2021-04-10 Thread Naresh Kamboju
On Fri, 9 Apr 2021 at 15:27, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.19.186 release. > There are 18 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > >

Re: [PATCH -next] i2c: omap: fix PM reference leak in omap_i2c_probe()

2021-04-10 Thread Vignesh Raghavendra
Hi. On 4/8/21 6:26 PM, Li Huafei wrote: > pm_runtime_get_sync will increment pm usage counter even it failed. > Forgetting to putting operation will result in reference leak here. Fix > it by replacing it with pm_runtime_resume_and_get to keep usage counter > balanced. > > Reported-by: Hulk

Re: [PATCH v2] kconfig: nconf: stop endless search-up loops

2021-04-10 Thread Mihai Moldovan
* On 4/10/21 7:47 AM, Masahiro Yamada wrote: > On Sun, Mar 28, 2021 at 6:52 PM Mihai Moldovan wrote: >> + if ((index == -1) && (index == match_start)) >> + return -1; > > We know 'index' is -1 in the second comparison. > So, you can also write like this: > >

[PATCH v2 3/5] mm/hugeltb: clarify (chg - freed) won't go negative in hugetlb_unreserve_pages()

2021-04-10 Thread Miaohe Lin
The resv_map could be NULL since this routine can be called in the evict inode path for all hugetlbfs inodes and we will have chg = 0 in this case. But (chg - freed) won't go negative as Mike pointed out: "If resv_map is NULL, then no hugetlb pages can be allocated/associated with the file.

[PATCH v2 5/5] mm/hugetlb: remove unused variable pseudo_vma in remove_inode_hugepages()

2021-04-10 Thread Miaohe Lin
The local variable pseudo_vma is not used anymore. Signed-off-by: Miaohe Lin --- fs/hugetlbfs/inode.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c index d81f52b87bd7..a2a42335e8fd 100644 --- a/fs/hugetlbfs/inode.c +++ b/fs/hugetlbfs/inode.c

[PATCH v2 0/5] Cleanup and fixup for hugetlb

2021-04-10 Thread Miaohe Lin
Hi all, This series contains cleanups to remove redundant VM_BUG_ON() and simplify the return code. Also this handles the error case in hugetlb_fix_reserve_counts() correctly. More details can be found in the respective changelogs. Thanks! v1->v2: collect Reviewed-by tag remove the

[PATCH v2 1/5] mm/hugeltb: remove redundant VM_BUG_ON() in region_add()

2021-04-10 Thread Miaohe Lin
The same VM_BUG_ON() check is already done in the callee. Remove this extra one to simplify the code slightly. Reviewed-by: Mike Kravetz Signed-off-by: Miaohe Lin --- mm/hugetlb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index c22111f3da20..a03a50b7c410

[PATCH v2 4/5] mm/hugeltb: handle the error case in hugetlb_fix_reserve_counts()

2021-04-10 Thread Miaohe Lin
A rare out of memory error would prevent removal of the reserve map region for a page. hugetlb_fix_reserve_counts() handles this rare case to avoid dangling with incorrect counts. Unfortunately, hugepage_subpool_get_pages and hugetlb_acct_memory could possibly fail too. We should correctly handle

[PATCH v2 2/5] mm/hugeltb: simplify the return code of __vma_reservation_common()

2021-04-10 Thread Miaohe Lin
It's guaranteed that the vma is associated with a resv_map, i.e. either VM_MAYSHARE or HPAGE_RESV_OWNER, when the code reaches here or we would have returned via !resv check above. So it's unneeded to check whether HPAGE_RESV_OWNER is set here. Simplify the return code to make it more clear.

[PATCH] preempt/dynamic: fix typo in macro conditional statement

2021-04-10 Thread Zhouyi Zhou
commit 40607ee97e4e ("preempt/dynamic: Provide irqentry_exit_cond_resched() static call") tried to provide irqentry_exit_cond_resched() static call in irqentry_exit, but has a typo in macro conditional statement. This patch fix this typo. Signed-off-by: Zhouyi Zhou --- kernel/entry/common.c |

Re: [PATCH 1/2] dt-bindings: soc: qcom: Add bindings for Qualcomm Memshare service

2021-04-10 Thread Nikita Travkin
Hi, sorry for a late reply but I couldn't answer earlier. 30.03.2021 19:40, Rob Herring пишет: > On Fri, Mar 19, 2021 at 10:23:20PM +0500, nikitos...@gmail.com wrote: >> From: Nikita Travkin >> >> Add DT bindings for memshare: QMI service that allocates >> memory per remote processor request. >>

Re: [Outreachy kernel] [Patch 0/3]

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 09:57:00AM +0200, Fabio M. De Francesco wrote: > On Saturday, April 10, 2021 9:29:29 AM CEST Greg KH wrote: > > On Fri, Apr 09, 2021 at 06:29:59PM +0200, Fabio M. De Francesco wrote: > > > This patch series removes camelcases, changes the type and use of a > > > variable,

Re: [PATCH 2/2] iommu/amd: Remove performance counter pre-initialization test

2021-04-10 Thread David Coe
Well, well! This is a promising start to the weekend. Thank you both, Suravee and Paul. Results for AMD Ryzen 4 2400G running Ubuntu 21.04β kernel 5.11.0-13 and Windows 10 2H2 under KVM $ sudo dmesg | grep IOMMU [0.557725] pci :00:00.2: AMD-Vi: IOMMU performance counters supported

Re: [PATCH 04/12] ARM: pxa: stargate2: Constify the software node

2021-04-10 Thread Robert Jarzmik
Wolfram Sang writes: > On Mon, Mar 29, 2021 at 01:50:39PM +0300, Heikki Krogerus wrote: >> Additional device properties are always just a part of a >> software fwnode. If the device properties are constant, the >> software node can also be constant. >> >> Signed-off-by: Heikki Krogerus >> Cc:

Re: [PATCH v3] powerpc/traps: Enhance readability for trap types

2021-04-10 Thread Xiongwei Song
> On Apr 10, 2021, at 12:14 AM, Christophe Leroy > wrote: > > > > Le 08/04/2021 à 16:07, Xiongwei Song a écrit : >> From: Xiongwei Song >> Create a new header named traps.h, define macros to list ppc interrupt >> types in traps.h, replace the reference of the trap hex values with these >>

Re: [PATCH 0/6] staging: rtl8192e: cleanup patchset for style issues

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 07:04:23AM +0530, Mitali Borkar wrote: > This patches fix the cleanup style issues. > > Mitali Borkar (6): > staging: rtl8192e: add spaces around binary operators > staging: rtl8192e: remove unnecessary blank line before brace > staging: rtl8192e: remove unncessary

Re: [PATCH] pata_ipx4xx_cf: Fix unsigned comparison with less than zero

2021-04-10 Thread Sergei Shtylyov
On 10.04.2021 2:38, angkery wrote: On Fri, 9 Apr 2021 20:02:56 +0300 Sergei Shtylyov wrote: On 4/9/21 7:49 PM, Sergei Shtylyov wrote: From: Junlin Yang The return from the call to platform_get_irq() is int, it can be a negative error code, however this is being assigned to an unsigned int

Re: [PATCH] perf session: Dump PERF_RECORD_TIME_CONV event

2021-04-10 Thread Adrian Hunter
On 10/04/21 6:19 am, Leo Yan wrote: > Now perf tool uses the common stub function process_event_op2_stub() for > dumping TIME_CONV event, thus it doesn't output the clock parameters > contained in the event. > > This patch adds the callback function for dumping the hardware clock > parameters in

Re: [PATCH v2] of: property: fw_devlink: do not link ".*,nr-gpios"

2021-04-10 Thread Greg Kroah-Hartman
On Tue, Apr 06, 2021 at 06:24:21PM -0700, Saravana Kannan wrote: > On Tue, Apr 6, 2021 at 6:10 PM Rob Herring wrote: > > > > On Tue, Apr 6, 2021 at 7:46 PM Saravana Kannan wrote: > > > > > > On Tue, Apr 6, 2021 at 5:34 PM Rob Herring wrote: > > > > > > > > On Tue, Apr 06, 2021 at 04:09:10PM

Re: [PATCH v17 2/2] ufs: sysfs: Resume the proper scsi device

2021-04-10 Thread Adrian Hunter
On 8/04/21 5:49 pm, Asutosh Das wrote: > Resumes the actual scsi device the unit descriptor of which > is being accessed instead of the hba alone. > > Reviewed-by: Can Guo > Signed-off-by: Asutosh Das > --- > drivers/scsi/ufs/ufs-sysfs.c | 30 +- > 1 file changed,

[PATCH v1 7/8] scsi: megaraid: clean up for trailing statements

2021-04-10 Thread Luo Jiaxing
Following error is reported by checkpatch.pl: ERROR: trailing statements should be on next line + if (iterator++ == adapno) break; So fix them. Signed-off-by: Luo Jiaxing --- drivers/scsi/megaraid/megaraid_mbox.c | 30 --

[PATCH v1 3/8] scsi: megaraid: clean up for blank lines

2021-04-10 Thread Luo Jiaxing
There are some blank line alerts when running checkpatch.pl, so fix them together here. Signed-off-by: Luo Jiaxing --- drivers/scsi/megaraid/mbox_defs.h| 1 - drivers/scsi/megaraid/megaraid_ioctl.h | 4 --- drivers/scsi/megaraid/megaraid_mm.h | 1 -

[PATCH v1 1/8] scsi: megaraid: clean up for white space

2021-04-10 Thread Luo Jiaxing
Several kinds of error about white space is reported when running checkpatch.pl: ERROR: space required after that ',' (ctx:VxV) + "commands to complete\n",i,outstanding); ERROR: trailing whitespace +^I^I^Idma_pool_free(pool->handle, kioc->buf_vaddr, $ ERROR: need

[PATCH v1 5/8] scsi: megaraid: clean up for "foo * bar"

2021-04-10 Thread Luo Jiaxing
Following error is reported by checkpatch.pl: "foo * bar" should be "foo *bar" + struct megasas_iocpacket __user * user_ioc, The format of the pointer variable must be "foo *bar", so fix them. Signed-off-by: Luo Jiaxing --- drivers/scsi/megaraid/megaraid_ioctl.h| 4

[PATCH v1 0/8] scsi: megaraid: some misc clean up patches

2021-04-10 Thread Luo Jiaxing
There are several kinds of error are reported by checkpatch.pl. So fix them together. Luo Jiaxing (8): scsi: megaraid: clean up for white space scsi: megaraid_sas: use parentheses to enclose macros with complex values scsi: megaraid: clean up for blank lines scsi: megaraid: clean up

[PATCH v1 8/8] scsi: megaraid: clean up for static variable initialise to 0

2021-04-10 Thread Luo Jiaxing
Following error is reported by checkpatch.pl: ERROR: do not initialise statics to 0 +static int megaraid_expose_unconf_disks = 0; So fix them. Signed-off-by: Luo Jiaxing --- drivers/scsi/megaraid/megaraid_mbox.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 5.4 00/23] 5.4.111-rc1 review

2021-04-10 Thread Naresh Kamboju
On Fri, 9 Apr 2021 at 15:29, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.4.111 release. > There are 23 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > >

Re: [PATCH] mm/memory_hotplug: Make unpopulated zones PCP structures unreachable during hot remove

2021-04-10 Thread Michal Hocko
On Fri 09-04-21 16:12:59, Mel Gorman wrote: [...] > If anything, the minimal "fix" is to simply delete IRQ disable/enable on > the grounds that IRQs protect nothing and assume the existing hotplug > paths guarantees the PCP cannot be used after zone_pcp_enable(). That > should be the case already

Re: [PATCH] hrtimer: avoid retrigger_next_event IPI

2021-04-10 Thread Thomas Gleixner
On Fri, Apr 09 2021 at 13:51, Marcelo Tosatti wrote: > On Fri, Apr 09, 2021 at 04:15:13PM +0200, Thomas Gleixner wrote: >> On Wed, Apr 07 2021 at 10:53, Marcelo Tosatti wrote: >> ---> fail because that newly started timer is on the old offset. > > CPU0

Re: [PATCH v3] powerpc/traps: Enhance readability for trap types

2021-04-10 Thread Xiongwei Song
> On Apr 10, 2021, at 8:04 AM, Michael Ellerman wrote: > > Christophe Leroy writes: >> Le 08/04/2021 à 16:07, Xiongwei Song a écrit : >>> From: Xiongwei Song >>> >>> Create a new header named traps.h, define macros to list ppc interrupt >>> types in traps.h, replace the reference of the

Re: [PATCH v2 1/1] efi/dev-path-parser: Switch to use for_each_acpi_dev_match()

2021-04-10 Thread Ard Biesheuvel
On Sun, 4 Apr 2021 at 20:12, Andy Shevchenko wrote: > > Switch to use for_each_acpi_dev_match() instead of home grown analogue. > No functional change intended. > > Signed-off-by: Andy Shevchenko > --- > v2: fixed refcounting > (example from which I took the v1 approach has been broken, fix

Re: [PATCH v1 00/14] Multigenerational LRU

2021-04-10 Thread Yu Zhao
On Tue, Mar 16, 2021 at 02:14:43PM -0700, Dave Hansen wrote: > On 3/16/21 1:30 PM, Yu Zhao wrote: > > On Tue, Mar 16, 2021 at 07:50:23AM -0700, Dave Hansen wrote: > >> I think it would also be very worthwhile to include some research in > >> this series about why the kernel moved away from page

Re: [Outreachy kernel] [PATCH v7 1/3] staging: rtl8723bs: Remove camelcase in several files

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 11:22:29AM +0200, Fabio M. De Francesco wrote: > Remove camelcase in bFwCurrentInPSMode, a variable used by code > of several subdirectories/files of the driver. Issue detected by > checkpatch.pl. Delete the unnecessary "b" (that stands for "byte") from > the beginning of

Re: [Outreachy kernel] [PATCH 4/4] staging: rtl8723bs: Change the type and use of a variable

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 11:22:32AM +0200, Fabio M. De Francesco wrote: > Change the type of fw_current_in_ps_mode from u8 to bool, because > it is used everywhere as a bool and, accordingly, it should be > declared as a bool. Shorten the controlling > expression of an 'if' statement. > >

[PATCH 2/3] crypto: hisilicon/hpre - use the correct variable type

2021-04-10 Thread Hui Tang
The return value of 'le32_to_cpu' is unsigned, so change the variable type from 'int' to 'unsigned int'. Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/hpre/hpre_crypto.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/hisilicon/hpre/hpre_crypto.c

[PATCH 0/3] crypto: hisilicon/hpre - add debug log

2021-04-10 Thread Hui Tang
This patchset adds the debug log and cleanup code style. Hui Tang (3): crypto: hisilicon/hpre - delete the rudundant space after return crypto: hisilicon/hpre - use the correct variable type crypto: hisilicon/hpre - add debug log drivers/crypto/hisilicon/hpre/hpre_crypto.c | 11

[PATCH 1/3] crypto: hisilicon/hpre - delete the rudundant space after return

2021-04-10 Thread Hui Tang
There are two spaces after return, just keep one. Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/hpre/hpre_crypto.c | 2 +- drivers/crypto/hisilicon/hpre/hpre_main.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/hisilicon/hpre/hpre_crypto.c

[PATCH 3/3] crypto: hisilicon/hpre - add debug log

2021-04-10 Thread Hui Tang
When the received sqe is abnormal, the error message in the sqe written back by the hardware is printed to help to analyze the abnormal causes. Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/hpre/hpre_crypto.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

Re: [Outreachy kernel] [PATCH 4/4] staging: rtl8723bs: Change the type and use of a variable

2021-04-10 Thread Fabio M. De Francesco
On Saturday, April 10, 2021 1:03:34 PM CEST Greg KH wrote: > On Sat, Apr 10, 2021 at 12:58:06PM +0200, Fabio M. De Francesco wrote: > > On Saturday, April 10, 2021 12:31:27 PM CEST Greg KH wrote: > > > On Sat, Apr 10, 2021 at 11:56:48AM +0200, Fabio M. De Francesco wrote: > > > > On Saturday,

Re: [RESEND PATCH] MAINTAINERS: update thermal CPU cooling section

2021-04-10 Thread Javi Merino
On Fri, Apr 02, 2021 at 12:53:08PM +0200, Daniel Lezcano wrote: > On 02/04/2021 12:25, Lukasz Luba wrote: > > Hi Viresh, Daniel > > > > On 2/18/21 4:18 AM, Viresh Kumar wrote: > >> On 17-02-21, 11:59, Lukasz Luba wrote: > >>> Update maintainers responsible for CPU cooling on Arm side. > >>> > >>>

Re: [PATCH V4 1/2] drm/vkms: Refactor vkms_composer_worker() to prep for virtual_hw mode

2021-04-10 Thread Melissa Wen
On 04/05, Sumera Priyadarsini wrote: > Add two new functions vkms_composer_common() and vkms_crtc_composer(). > The actual plane composition work has been moved to the helper function, > vkms_composer_common() which is called by both vkms_composer_worker() > and vkms_crtc_composer().

Re: [Outreachy kernel] [PATCH 4/4] staging: rtl8723bs: Change the type and use of a variable

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 01:23:21PM +0200, Fabio M. De Francesco wrote: > On Saturday, April 10, 2021 1:03:34 PM CEST Greg KH wrote: > > On Sat, Apr 10, 2021 at 12:58:06PM +0200, Fabio M. De Francesco wrote: > > > On Saturday, April 10, 2021 12:31:27 PM CEST Greg KH wrote: > > > > On Sat, Apr 10,

Re: Linux 5.11.13

2021-04-10 Thread Greg Kroah-Hartman
diff --git a/Documentation/arm64/silicon-errata.rst b/Documentation/arm64/silicon-errata.rst index 719510247292..d410a47ffa57 100644 --- a/Documentation/arm64/silicon-errata.rst +++ b/Documentation/arm64/silicon-errata.rst @@ -130,6 +130,9 @@ stable kernels. | Marvell| ARM-MMU-500 |

Linux 5.11.13

2021-04-10 Thread Greg Kroah-Hartman
I'm announcing the release of the 5.11.13 kernel. All users of the 5.11 kernel series must upgrade. The updated 5.11.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.11.y and can be browsed at the normal kernel.org git web

Re: Linux 5.10.29

2021-04-10 Thread Greg Kroah-Hartman
diff --git a/Makefile b/Makefile index cb76f64abb6d..1d4a50ebe3b7 100644 --- a/Makefile +++ b/Makefile @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 VERSION = 5 PATCHLEVEL = 10 -SUBLEVEL = 28 +SUBLEVEL = 29 EXTRAVERSION = NAME = Dare mighty things @@ -1083,6 +1083,17 @@ ifdef

Re: Linux 5.4.111

2021-04-10 Thread Greg Kroah-Hartman
diff --git a/Makefile b/Makefile index b028b5ead5f7..25680098f51b 100644 --- a/Makefile +++ b/Makefile @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 VERSION = 5 PATCHLEVEL = 4 -SUBLEVEL = 110 +SUBLEVEL = 111 EXTRAVERSION = NAME = Kleptomaniac Octopus diff --git

Linux 5.4.111

2021-04-10 Thread Greg Kroah-Hartman
I'm announcing the release of the 5.4.111 kernel. All users of the 5.4 kernel series must upgrade. The updated 5.4.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.4.y and can be browsed at the normal kernel.org git web browser:

Linux 5.10.29

2021-04-10 Thread Greg Kroah-Hartman
I'm announcing the release of the 5.10.29 kernel. All users of the 5.10 kernel series must upgrade. The updated 5.10.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.10.y and can be browsed at the normal kernel.org git web

RE: static_branch/jump_label vs branch merging

2021-04-10 Thread David Laight
From: David Malcolm > Sent: 09 April 2021 14:49 ... > With the caveat that my knowledge of GCC's middle-end is mostly about > implementing warnings, rather than optimization, I did some > experimentation, with gcc trunk on x86_64 FWIW. > > Given: > > int __attribute__((pure)) foo(void); > > int

[PATCH v2] staging: rtl8192e: fixed pointer error by adding '*'

2021-04-10 Thread Mitali Borkar
Fixed Comparison to NULL can be written as '!...' by replacing it with simpler form i.e. boolean expression. This makes code more readable alternative. Reported by checkpatch. Signed-off-by: Mitali Borkar --- Changes from v1:- added pointer to the function, which was missed during fixing v1.

Re: [PATCH v14 08/13] dma-iommu: Implement NESTED_MSI cookie

2021-04-10 Thread Auger Eric
Hi Zenghui, On 4/7/21 9:39 AM, Zenghui Yu wrote: > Hi Eric, > > On 2021/2/24 4:56, Eric Auger wrote: >> Up to now, when the type was UNMANAGED, we used to >> allocate IOVA pages within a reserved IOVA MSI range. >> >> If both the host and the guest are exposed with SMMUs, each >> would allocate

[PATCH v5 16/16] arm64: dts: mediatek: Get rid of mediatek,larb for MM nodes

2021-04-10 Thread Yong Wu
After adding device_link between the IOMMU consumer and smi, the mediatek,larb is unnecessary now. CC: Matthias Brugger Signed-off-by: Yong Wu Reviewed-by: Evan Green --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 16 arch/arm64/boot/dts/mediatek/mt8183.dtsi | 5 - 2

[PATCH v5 00/16] Clean up "mediatek,larb"

2021-04-10 Thread Yong Wu
MediaTek IOMMU block diagram always like below: M4U | smi-common | - | | ... | | larb1 larb2 | | vdec venc All the consumer connect with smi-larb, then connect with smi-common. When the consumer works, it

[PATCH v5 01/16] dt-binding: mediatek: Get rid of mediatek,larb for multimedia HW

2021-04-10 Thread Yong Wu
After adding device_link between the consumer with the smi-larbs, if the consumer call its owner pm_runtime_get(_sync), the pm_runtime_get(_sync) of smi-larb and smi-common will be called automatically. Thus, the consumer don't need the property. And IOMMU also know which larb this consumer

[PATCH v5 12/16] media: mtk-vcodec: Use pm_runtime_resume_and_get for PM get_sync

2021-04-10 Thread Yong Wu
pm_runtime_get_sync will increment pm usage counter even it failed. This patch use pm_runtime_resume_and_get instead of pm_runtime_get_sync to keep usage counter balanced. Signed-off-by: Yong Wu --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 5 +++-- 1 file changed, 3

Re: [PATCH v2] kconfig: nconf: stop endless search-up loops

2021-04-10 Thread Masahiro Yamada
On Sat, Apr 10, 2021 at 4:00 PM Mihai Moldovan wrote: > > * On 4/10/21 7:47 AM, Masahiro Yamada wrote: > > On Sun, Mar 28, 2021 at 6:52 PM Mihai Moldovan wrote: > >> + if ((index == -1) && (index == match_start)) > >> + return -1; > > > > We know 'index' is -1

Re: [PATCH v4] powerpc/traps: Enhance readability for trap types

2021-04-10 Thread Xiongwei Song
> On Apr 10, 2021, at 8:35 AM, Nicholas Piggin wrote: > > Thanks for working on this, I think it's a nice cleanup and helps > non-powerpc people understand the code a bit better. > My pleasure. > Excerpts from Xiongwei Song's message of April 10, 2021 12:28 am: >> From: Xiongwei Song >>

Re: [PATCH 4.9 00/13] 4.9.266-rc1 review

2021-04-10 Thread Naresh Kamboju
On Fri, 9 Apr 2021 at 15:26, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.9.266 release. > There are 13 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > >

Re: [PATCH 4.4 00/20] 4.4.266-rc1 review

2021-04-10 Thread Naresh Kamboju
On Fri, 9 Apr 2021 at 15:25, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.4.266 release. > There are 20 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > >

Re: [PATCH v3] powerpc/traps: Enhance readability for trap types

2021-04-10 Thread Christophe Leroy
Le 10/04/2021 à 02:04, Michael Ellerman a écrit : Christophe Leroy writes: Le 08/04/2021 à 16:07, Xiongwei Song a écrit : From: Xiongwei Song Create a new header named traps.h, define macros to list ppc interrupt types in traps.h, replace the reference of the trap hex values with these

Cant resume from sleep on 5.12-rcx regression?

2021-04-10 Thread Malte Deiseroth
Hey guys. I think, maybe I found a regression in 5.12. TLDK: Screen stays black after resume from sleep on kernel 5.12-rcx but not on 5.11.12 I compiler a 5.11.12 and a 5.12-rc6 Kernel on my  Ubuntu 20.10 T480 Laptop. With the 5.11.12 kernel I can safely boot and put the laptop into sleep

Re: [PATCH] mm/frontswap: fix frontswap_register_ops() race with swapon and swapoff

2021-04-10 Thread Yu Zhao
On Sat, Apr 10, 2021 at 1:30 AM Miaohe Lin wrote: > > Hi: > On 2021/4/5 18:20, Miaohe Lin wrote: > > frontswap_register_ops can race with swapon. Consider the following scene: > > Any comment or suggestion? Or is this race window too theoretical to fix? > Thanks. Let me run a stress test and get

Re: [PATCH] mm/frontswap: fix frontswap_register_ops() race with swapon and swapoff

2021-04-10 Thread Miaohe Lin
On 2021/4/10 18:42, Yu Zhao wrote: > On Sat, Apr 10, 2021 at 1:30 AM Miaohe Lin wrote: >> >> Hi: >> On 2021/4/5 18:20, Miaohe Lin wrote: >>> frontswap_register_ops can race with swapon. Consider the following scene: >> >> Any comment or suggestion? Or is this race window too theoretical to fix?

Re: [PATCH] net: core: sk_buff: zero-fill skb->data in __alloc_skb function

2021-04-10 Thread Eric Dumazet
On Sat, Apr 10, 2021 at 12:12 PM Eric Dumazet wrote: > > On Sat, Apr 10, 2021 at 11:51 AM Phillip Potter wrote: > > > > Zero-fill skb->data in __alloc_skb function of net/core/skbuff.c, > > up to start of struct skb_shared_info bytes. Fixes a KMSAN-found > > uninit-value bug reported by syzbot

Re: [PATCH v2] of: property: fw_devlink: do not link ".*,nr-gpios"

2021-04-10 Thread Greg Kroah-Hartman
On Fri, Apr 09, 2021 at 12:36:36PM -0700, Saravana Kannan wrote: > On Fri, Apr 9, 2021 at 12:26 PM Rob Herring wrote: > > > > On Wed, Apr 7, 2021 at 3:45 PM Ilya Lipnitskiy > > wrote: > > > > > > On Tue, Apr 6, 2021 at 6:24 PM Saravana Kannan > > > wrote: > > > > > > > > On Tue, Apr 6, 2021 at

Re: [Outreachy kernel] [PATCH] staging: rtl8192e: replace comparison to NULL by bool

2021-04-10 Thread Julia Lawall
On Sat, 10 Apr 2021, Mitali Borkar wrote: > Fixed Comparison to NULL can be written as '!...' by replacing it with > simpler form i.e boolean expression. This makes code more readable > alternative. > Reported by checkpatch. > > Signed-off-by: Mitali Borkar > --- >

Re: [PATCH stable] gpiolib: Read "gpio-line-names" from a firmware node

2021-04-10 Thread Greg Kroah-Hartman
On Sat, Apr 10, 2021 at 11:09:19AM +0200, Bartosz Golaszewski wrote: > From: Andy Shevchenko > > On STM32MP1, the GPIO banks are subnodes of pin-controller@50002000, > see arch/arm/boot/dts/stm32mp151.dtsi. The driver for > pin-controller@50002000 is in drivers/pinctrl/stm32/pinctrl-stm32.c >

[GIT PULL] Driver core fix for 5.12-rc7

2021-04-10 Thread Greg KH
The following changes since commit e49d033bddf5b565044e2abe4241353959bc9120: Linux 5.12-rc6 (2021-04-04 14:15:36 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git tags/driver-core-5.12-rc7 for you to fetch changes up to

Good Day

2021-04-10 Thread Mrs.chantal lawrence
HELLO I am Mrs. Chantal Lawrence. I am sending this brief letter to solicit your partnership to transfer a sum of 12 Million Dollars into your reliable account as my business partner. However, it's my urgent need for foreign partner that made me to contact you for this transaction. Further

Re: [Outreachy kernel] [PATCH v2] staging: rtl8192e: fixed pointer error by adding '*'

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 03:23:35PM +0200, Julia Lawall wrote: > > > On Sat, 10 Apr 2021, Mitali Borkar wrote: > > > Fixed Comparison to NULL can be written as '!...' by replacing it with > > simpler form i.e. boolean expression. This makes code more readable > > alternative. > > Reported by

Re: [Outreachy kernel] [PATCH v2 2/2] staging: media: zoran: remove and add comments; align code

2021-04-10 Thread Julia Lawall
> Mam, my new patch is ready but I am not sure how to send, the v1/2 is > not on top, I have not made changes in it because it was not required. Now, > how to > send these two mails as a patchset, since in between these two git > commits, I have another commits too. Suppose you have relevant

[PATCH] crypto: crc32-generic - Use SPDX-License-Identifier

2021-04-10 Thread Christophe JAILLET
Use SPDX-License-Identifier: GPL-2.0-only, instead of hand writing it. This also removes a reference to http://www.xyratex.com which seems to be down. Signed-off-by: Christophe JAILLET --- crypto/crc32_generic.c | 24 +--- 1 file changed, 1 insertion(+), 23 deletions(-)

  1   2   3   4   5   >