Re: [PATCH v5] hrtimer: avoid retrigger_next_event IPI

2021-04-17 Thread Thomas Gleixner
On Fri, Apr 16 2021 at 13:13, Peter Xu wrote: > On Fri, Apr 16, 2021 at 01:00:23PM -0300, Marcelo Tosatti wrote: >> >> +#define CLOCK_SET_BASES ((1U << HRTIMER_BASE_REALTIME) |\ >> + (1U << HRTIMER_BASE_REALTIME_SOFT) | \ >> + (1U <<

Re: [PATCH v5] hrtimer: avoid retrigger_next_event IPI

2021-04-17 Thread Thomas Gleixner
On Sat, Apr 17 2021 at 18:24, Thomas Gleixner wrote: > On Fri, Apr 16 2021 at 13:13, Peter Xu wrote: >> On Fri, Apr 16, 2021 at 01:00:23PM -0300, Marcelo Tosatti wrote: >>> >>> +#define CLOCK_SET_BASES ((1U << HRTIMER_BASE_REALTIME) | \ >>> +(1U <<

Re: [PATCH v4 1/3] riscv: Move kernel mapping outside of linear mapping

2021-04-17 Thread Alex Ghiti
Hi Guenter, Le 4/16/21 à 2:51 PM, Guenter Roeck a écrit : On Fri, Apr 09, 2021 at 02:14:58AM -0400, Alexandre Ghiti wrote: This is a preparatory patch for relocatable kernel and sv48 support. The kernel used to be linked at PAGE_OFFSET address therefore we could use the linear mapping for the

Re: [PATCH RESEND][next] rtl8xxxu: Fix fall-through warnings for Clang

2021-04-17 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix > multiple warnings by replacing /* fall through */ comments with > the new pseudo-keyword macro fallthrough; instead of letting the > code fall through to the next case. > > Notice that Clang doesn't

[PATCH 1/4] staging: rtl8188eu: change bLeisurePs' type to bool

2021-04-17 Thread Martin Kaiser
bLeisurePs is used as a boolean variable. Change its type from u8 to bool. Signed-off-by: Martin Kaiser --- drivers/staging/rtl8188eu/include/rtw_pwrctrl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h

[PATCH 3/4] staging: rtl8188eu: cmdThread is a task_struct

2021-04-17 Thread Martin Kaiser
cmdThread is the return value of kthread_run, i.e. a struct task_struct. Signed-off-by: Martin Kaiser --- drivers/staging/rtl8188eu/include/drv_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/include/drv_types.h

[PATCH 4/4] staging: rtl8188eu: remove unused function parameters

2021-04-17 Thread Martin Kaiser
The Enable and Linked parameters of _BeaconFunctionEnable are not used. Remove them. Signed-off-by: Martin Kaiser --- drivers/staging/rtl8188eu/hal/usb_halinit.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c

Re: [PATCH 1/2] mm: Fix struct page layout on 32-bit systems

2021-04-17 Thread Ilias Apalodimas
Hi Matthew, On Sat, Apr 17, 2021 at 03:45:22AM +0100, Matthew Wilcox wrote: > > Replacement patch to fix compiler warning. > > From: "Matthew Wilcox (Oracle)" > Date: Fri, 16 Apr 2021 16:34:55 -0400 > Subject: [PATCH 1/2] mm: Fix struct page layout on 32-bit systems > To: bro...@redhat.com >

Re: [PATCH RESEND][next] rtl8xxxu: Fix fall-through warnings for Clang

2021-04-17 Thread Jes Sorensen
On 4/17/21 1:52 PM, Kalle Valo wrote: > "Gustavo A. R. Silva" wrote: > >> In preparation to enable -Wimplicit-fallthrough for Clang, fix >> multiple warnings by replacing /* fall through */ comments with >> the new pseudo-keyword macro fallthrough; instead of letting the >> code fall through to

Re: [PATCH] x86/uaccess: small optimization in unsafe_copy_to_user()

2021-04-17 Thread Eric Dumazet
On Sat, Apr 17, 2021 at 6:03 PM Linus Torvalds wrote: > > On Fri, Apr 16, 2021 at 12:24 PM Eric Dumazet wrote: > > > > From: Eric Dumazet > > > > We have to loop only to copy u64 values. > > After this first loop, we copy at most one u32, one u16 and one byte. > > As Al mentioned, at least in

Re: [PATCH] arm64: dts: marvell: armada-37xx: Set linux,pci-domain to zero

2021-04-17 Thread Pali Rohár
On Saturday 17 April 2021 17:19:38 Andrew Lunn wrote: > > Currently this code is implemented in pci_bus_find_domain_nr() function. > > IIRC domain number is 16bit integer, so plain bitmap would consume 8 kB > > of memory. I'm not sure if it is fine or some other tree-based structure > > for

PPC_FPU, ALTIVEC: enable_kernel_fp, put_vr, get_vr

2021-04-17 Thread Randy Dunlap
Hi, kernel test robot reports: >> drivers/cpufreq/pmac32-cpufreq.c:262:2: error: implicit declaration of >> function 'enable_kernel_fp' [-Werror,-Wimplicit-function-declaration] enable_kernel_fp(); ^ when # CONFIG_PPC_FPU is not set CONFIG_ALTIVEC=y I see at least one

Re: [PATCH] x86/uaccess: small optimization in unsafe_copy_to_user()

2021-04-17 Thread Linus Torvalds
On Sat, Apr 17, 2021 at 1:35 PM Al Viro wrote: > > No, wait - we have non-NULL buf->prev_reclen, so we'll hit > with buf->error completely ignored. Nevermind. Yeah, I'm pretty sure I even tested that -EINTR case at one point. Of course, it could easily have gotten broken again, so that's not a

[gustavoars-linux:testing/warray-bounds] BUILD SUCCESS WITH WARNING 5730745615064f614a7bb0d15b5915c785fcb3c5

2021-04-17 Thread kernel test robot
-short-unsigned-int-at-offset |-- i386-randconfig-c021-20210417 | |-- arch-x86-include-asm-string_32.h:warning:__builtin_memcpy-offset-from-the-object-at-buf-is-out-of-the-bounds-of-referenced-subobject-key-with-type-u8-aka-unsigned-char-at-offset | `-- arch-x86-include-asm-string_32.h:warning

Re: [PATCH] qtnfmac: remove meaningless labels

2021-04-17 Thread Kalle Valo
samirweng1979 wrote: > From: wengjianfeng > > some function's label meaningless, the return statement follows > the goto statement, so just remove it. > > Signed-off-by: wengjianfeng > Reviewed-by: Sergey Matyukevich Patch applied to wireless-drivers-next.git, thanks. a221d0afbf39

Re: [PATCH] riscv: Protect kernel linear mapping only if CONFIG_STRICT_KERNEL_RWX is set

2021-04-17 Thread Alex Ghiti
Le 4/16/21 à 12:33 PM, Palmer Dabbelt a écrit : On Fri, 16 Apr 2021 03:47:19 PDT (-0700), a...@ghiti.fr wrote: Hi Anup, Le 4/16/21 à 6:41 AM, Anup Patel a écrit : On Thu, Apr 15, 2021 at 4:34 PM Alexandre Ghiti wrote: If CONFIG_STRICT_KERNEL_RWX is not set, we cannot set different

Re: [PATCH] cw1200: Remove unused function pointer typedef wsm_*

2021-04-17 Thread Kalle Valo
Chen Lin wrote: > From: Chen Lin > > Remove the 'wsm_*' typedef as it is not used. > > Signed-off-by: Chen Lin Patch applied to wireless-drivers-next.git, thanks. 9dc5fdc8c4f8 cw1200: Remove unused function pointer typedef wsm_* --

Re: [PATCH] mwifiex: don't print SSID to logs

2021-04-17 Thread Kalle Valo
Brian Norris wrote: > There are a few reasons not to dump SSIDs as-is in kernel logs: > > 1) they're not guaranteed to be any particular text encoding (UTF-8, >ASCII, ...) in general > 2) it's somewhat redundant; the BSSID should be enough to uniquely >identify the AP/STA to which we're

Re: rtlwifi/rtl8192cu AP mode broken with PS STA

2021-04-17 Thread Maciej S. Szmigiero
On 08.04.2021 21:04, Maciej S. Szmigiero wrote: On 08.04.2021 06:42, Pkshih wrote: -Original Message- From: Maciej S. Szmigiero [mailto:m...@maciej.szmigiero.name] Sent: Thursday, April 08, 2021 4:53 AM To: Larry Finger; Pkshih Cc: linux-wirel...@vger.kernel.org; net...@vger.kernel.org;

Re: [PATCH 3/3] gpio: zynq: Check return value of irq_get_irq_data

2021-04-17 Thread Deepak R Varma
On Fri, Apr 09, 2021 at 07:38:06PM +0530, Srinivas Neeli wrote: > In two different instances the return value of "irq_get_irq_data" > API was neither captured nor checked. > Fixed it by capturing the return value and then checking for any error. > > Addresses-Coverity: "returned_null" >

Re: [PATCH v9 1/8] pwm: pca9685: Switch to atomic API

2021-04-17 Thread Uwe Kleine-König
On Thu, Apr 15, 2021 at 02:14:48PM +0200, Clemens Gruber wrote: > The switch to the atomic API goes hand in hand with a few fixes to > previously experienced issues: > - The duty cycle is no longer lost after disable/enable (previously the > OFF registers were cleared in disable and the user was

RE: [PATCH 1/2] mm: Fix struct page layout on 32-bit systems

2021-04-17 Thread David Laight
From: Matthew Wilcox > Sent: 17 April 2021 03:45 > > Replacement patch to fix compiler warning. ... > static inline dma_addr_t page_pool_get_dma_addr(struct page *page) > { > - return page->dma_addr; > + dma_addr_t ret = page->dma_addr[0]; > + if (sizeof(dma_addr_t) >

Re: [PATCH 2/2] mm: Indicate pfmemalloc pages in compound_head

2021-04-17 Thread Matthew Wilcox
On Sat, Apr 17, 2021 at 09:13:45PM +, David Laight wrote: > > struct {/* page_pool used by netstack */ > > - /** > > -* @dma_addr: might require a 64-bit value on > > -* 32-bit architectures. > > -

Re: [PATCH] block: fix io hung by block throttle

2021-04-17 Thread Junxiao Bi
On 4/17/21 3:10 AM, Hillf Danton wrote: --- a/block/blk-rq-qos.c +++ b/block/blk-rq-qos.c @@ -260,19 +260,17 @@ void rq_qos_wait(struct rq_wait *rqw, void *private_data, .cb = acquire_inflight_cb, .private_data = private_data, }; - bool has_sleeper;

Re: [PATCH 1/2] mm: Fix struct page layout on 32-bit systems

2021-04-17 Thread Matthew Wilcox
On Sat, Apr 17, 2021 at 09:18:57PM +, David Laight wrote: > Ugly as well. Thank you for expressing your opinion. Again.

Re: [PATCH] Fix set apic mode from x2apic enabled bit patch

2021-04-17 Thread Thomas Gleixner
Mike! On Sun, Apr 18 2021 at 00:39, Thomas Gleixner wrote: > If you can't come up with something sensible anytime soon before the > merge window opens then I'm simply going to revert 41e2da9b5e67 and you > can try again for the next cycle. so I just figured out that Boris wasted his time once

Re: [PATCH 05/15] x86: Implement function_nocfi

2021-04-17 Thread Andy Lutomirski
On Fri, Apr 16, 2021 at 4:40 PM Kees Cook wrote: > > > 1. I defined a function in asm. I want to tell clang that this > > function is defined in asm, and for clang to behave accordingly: > > > > .globl func > > func: > > ; do stuff > > > > later: > > > > extern void func(void) [something

[git pull] drm/vmwgfx fixes for 5.12-rc8

2021-04-17 Thread Dave Airlie
Hi Linus, Back from holidays and this was in the cracks (Zack forgot to cc Daniel/lists), I've just piled it onto drm fixes. It contains two regression fixes for vmwgfx, one due to a refactor which meant locks were being used before initialisation, and the other in fixing up some warnings from

Re: [PATCH v3 3/4] perf-stat: introduce config stat.bpf-counter-events

2021-04-17 Thread Namhyung Kim
Hi Song, On Sat, Apr 17, 2021 at 7:13 AM Song Liu wrote: > > Currently, to use BPF to aggregate perf event counters, the user uses > --bpf-counters option. Enable "use bpf by default" events with a config > option, stat.bpf-counter-events. Events with name in the option will use > BPF. > > This

fs/f2fs/gc.c:29:12: warning: stack frame size of 2080 bytes in function 'gc_thread_func'

2021-04-17 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 9cdbf6467424045617cd6e79dcaad06bb8efa31c commit: cdf8a76fda4ae3b53c5a09e5a8c79e27b7b65d68 ubsan: move cc-option tests into Kconfig date: 4 months ago config: powerpc-randconfig-r011-20210417 (attached

Re: [PATCH] rtlwifi: Few mundane typo fixes

2021-04-17 Thread Kalle Valo
Bhaskar Chowdhury wrote: > s/resovle/resolve/ > s/broadcase/broadcast/ > s/sytem/system/ > > Signed-off-by: Bhaskar Chowdhury > Acked-by: Randy Dunlap Patch applied to wireless-drivers-next.git, thanks. 2377b1c49d48 rtlwifi: Few mundane typo fixes --

Re: [PATCH] rtlwifi: remove redundant assignment to variable err

2021-04-17 Thread Kalle Valo
Colin King wrote: > From: Colin Ian King > > Variable err is assigned -ENODEV followed by an error return path > via label error_out that does not access the variable and returns > with the -ENODEV error return code. The assignment to err is > redundant and can be removed. > >

Re: [PATCH] rtlwifi: Simplify locking of a skb list accesses

2021-04-17 Thread Kalle Valo
Christophe JAILLET wrote: > The 'c2hcmd_lock' spinlock is only used to protect some __skb_queue_tail() > and __skb_dequeue() calls. > Use the lock provided in the skb itself and call skb_queue_tail() and > skb_dequeue(). These functions already include the correct locking. > > Signed-off-by:

Re: [PATCH v2] qtnfmac: remove meaningless goto statement and labels

2021-04-17 Thread Kalle Valo
samirweng1979 wrote: > From: wengjianfeng > > some function's label meaningless, the label statement follows > the goto statement, no other statements, so just remove it. > > Reported-by: kernel test robot > Signed-off-by: wengjianfeng Patch applied to wireless-drivers-next.git, thanks.

Re: [PATCH] drm/msm: always parse interconnects

2021-04-17 Thread Rob Clark
On Sat, Apr 17, 2021 at 9:21 AM Caleb Connolly wrote: > > The WARN_ON in dpu_runtime_resume() fires constantly on non-SC7180 > platforms. As SDM845 now has interconnects hooked up we should always > try and parse them. > > Fixes: 627dc55c273d ("drm/msm/disp/dpu1: icc path needs to be set before

Re: [PATCH RESEND][next] rtl8xxxu: Fix fall-through warnings for Clang

2021-04-17 Thread Gustavo A. R. Silva
On 4/17/21 13:29, Jes Sorensen wrote: > On 3/10/21 3:59 PM, Kees Cook wrote: >> On Wed, Mar 10, 2021 at 02:51:24PM -0500, Jes Sorensen wrote: >>> On 3/10/21 2:45 PM, Kees Cook wrote: On Wed, Mar 10, 2021 at 02:31:57PM -0500, Jes Sorensen wrote: > On 3/10/21 2:14 PM, Kees Cook wrote:

Re: [PATCH 04/13] Kbuild: Rust support

2021-04-17 Thread Masahiro Yamada
On Thu, Apr 15, 2021 at 9:43 AM Miguel Ojeda wrote: > > On Thu, Apr 15, 2021 at 1:19 AM Nick Desaulniers > wrote: > > > > Rather than check the origin (yikes, are we intentionally avoiding env > > vars?), can this simply be > > ifneq ($(CLIPPY),) > > KBUILD_CLIPPY := $(CLIPPY) > > endif > > >

[ANNOUNCE] 5.4.109-rt56

2021-04-17 Thread Tom Zanussi
Hello RT Folks! I'm pleased to announce the 5.4.109-rt56 stable release. You can get this release via the git tree at: git://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt.git branch: v5.4-rt Head SHA1: a84a83ce44cafc96cb9cf419378a713dcdea00ac Or to build 5.4.109-rt56

Re: [PATCHv3] Introduced new tracing mode KCOV_MODE_UNIQUE.

2021-04-17 Thread Andrey Konovalov
On Fri, Apr 16, 2021 at 10:42 AM Dmitry Vyukov wrote: > > On Sat, Mar 27, 2021 at 3:56 PM Andrey Konovalov wrote: > > > > On Fri, Mar 26, 2021 at 9:52 PM Alexander Lochmann > > wrote: > > > > > > > Hi Alexander, > > > > > It simply stores the executed PCs. > > > The execution order is

Re: [PATCH] x86/uaccess: small optimization in unsafe_copy_to_user()

2021-04-17 Thread Linus Torvalds
On Sat, Apr 17, 2021 at 12:44 PM Eric Dumazet wrote: > > I thought put_cmsg() callers were from the kernel, with no possibility > for user to abuse this interface trying to push GB of data. My point is that "I thought" is not good enough for the unsafe interfaces. It needs to be "I can see that

Re: [PATCH 1/3] i2c: mediatek: Fix send master code at more than 1MHz

2021-04-17 Thread Wolfram Sang
On Sat, Apr 17, 2021 at 02:46:50PM +0800, Qii Wang wrote: > There are some omissions in the previous patch about replacing > I2C_MAX_FAST_MODE__FREQ with I2C_MAX_FAST_MODE_PLUS_FREQ and > need to fix it. > > Fixes: b44658e755b5("i2c: mediatek: Send i2c master code at more than 1MHz") >

Re: [PATCH 2/3] i2c: mediatek: Fix wrong dma sync flag

2021-04-17 Thread Wolfram Sang
On Sat, Apr 17, 2021 at 02:46:51PM +0800, Qii Wang wrote: > The right flag is apdma_sync when apdma remove hand-shake signel. > > Signed-off-by: Qii Wang Added: Fixes: 05f6f7271a38 ("i2c: mediatek: Fix apdma and i2c hand-shake timeout") and applied to for-next, thanks! signature.asc

Re: [PATCH 1/2] mm: Fix struct page layout on 32-bit systems

2021-04-17 Thread Matthew Wilcox
On Sat, Apr 17, 2021 at 09:32:06PM +0300, Ilias Apalodimas wrote: > > +static inline void page_pool_set_dma_addr(struct page *page, dma_addr_t > > addr) > > +{ > > + page->dma_addr[0] = addr; > > + if (sizeof(dma_addr_t) > sizeof(unsigned long)) > > + page->dma_addr[1] = addr >> 16

Re: [PATCH 00/13] [RFC] Rust support

2021-04-17 Thread Richard Weinberger
On Thu, Apr 15, 2021 at 2:41 AM wrote: > Regarding compilers, we support Clang-built kernels as well as > `LLVM=1` builds where possible (i.e. as long as supported by > the ClangBuiltLinux project). We also maintain some configurations > of GCC-built kernels working, but they are not intended to

Re: [PATCH v4 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM support

2021-04-17 Thread Uwe Kleine-König
Hello Nobuhiro, On Fri, Apr 16, 2021 at 09:15:23PM +0900, Nobuhiro Iwamatsu wrote: > > > > For me the critical (and only) difference between "off" and > > > > "duty cycle = 0" is that when a new configuration is to be applied. In > > > > the "off" state a new period can (and should) start

fs/f2fs/gc.c:622:12: warning: stack frame size of 3328 bytes in function 'get_victim_by_default'

2021-04-17 Thread kernel test robot
months ago config: powerpc-randconfig-r011-20210417 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project f549176ad976caa3e19edd036df9a7e12770af7c) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin

Re: [PATCH] x86/uaccess: small optimization in unsafe_copy_to_user()

2021-04-17 Thread Linus Torvalds
On Fri, Apr 16, 2021 at 12:24 PM Eric Dumazet wrote: > > From: Eric Dumazet > > We have to loop only to copy u64 values. > After this first loop, we copy at most one u32, one u16 and one byte. As Al mentioned, at least in trivial cases the compiler understands that the subsequent loops can only

Re: [PATCH] x86/uaccess: small optimization in unsafe_copy_to_user()

2021-04-17 Thread Linus Torvalds
On Sat, Apr 17, 2021 at 9:03 AM Linus Torvalds wrote: > > Really. The "unsafe" user accesses are named that way very explicitly, > and for a very very good reason: the safety needs to be guaranteed and > obvious within the context of those accesses. Not within some "oh, > nobody will ever call

[PULL REQUEST] i2c for 5.12

2021-04-17 Thread Wolfram Sang
Linus, here is one more driver bugfix for I2C. Please pull. Thanks, Wolfram The following changes since commit d434405aaab7d0ebc516b68a8fc4100922d7f5ef: Linux 5.12-rc7 (2021-04-11 15:16:13 -0700) are available in the Git repository at:

Re: [PATCH] qtnfmac: Fix possible buffer overflow in qtnf_event_handle_external_auth

2021-04-17 Thread Kalle Valo
Lee Gibson wrote: > Function qtnf_event_handle_external_auth calls memcpy without > checking the length. > A user could control that length and trigger a buffer overflow. > Fix by checking the length is within the maximum allowed size. > > Signed-off-by: Lee Gibson Please use clamp_val()

Re: [PATCH] cw1200: Remove unused function pointer typedef cw1200_wsm_handler

2021-04-17 Thread Kalle Valo
Chen Lin wrote: > From: Chen Lin > > Remove the 'cw1200_wsm_handler' typedef as it is not used. > > Signed-off-by: Chen Lin Patch applied to wireless-drivers-next.git, thanks. 1c22233a745e cw1200: Remove unused function pointer typedef cw1200_wsm_handler --

Re: [PATCH net-next] rtlwifi: rtl8192de: Use DEFINE_SPINLOCK() for spinlock

2021-04-17 Thread Kalle Valo
Huang Guobin wrote: > From: Guobin Huang > > spinlock can be initialized automatically with DEFINE_SPINLOCK() > rather than explicitly calling spin_lock_init(). > > Reported-by: Hulk Robot > Signed-off-by: Guobin Huang Patch applied to wireless-drivers-next.git, thanks. e9642be26a37

Re: [PATCH] rtl8xxxu: Simplify locking of a skb list accesses

2021-04-17 Thread Kalle Valo
Christophe JAILLET wrote: > The 'c2hcmd_lock' spinlock is only used to protect some __skb_queue_tail() > and __skb_dequeue() calls. > Use the lock provided in the skb itself and call skb_queue_tail() and > skb_dequeue(). These functions already include the correct locking. > > Signed-off-by:

Re: [PATCH net-next] wlcore: fix overlapping snprintf arguments in debugfs

2021-04-17 Thread Kalle Valo
Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc complains about undefined behavior in calling snprintf() > with the same buffer as input and output: > > drivers/net/wireless/ti/wl18xx/debugfs.c: In function > 'diversity_num_of_packets_per_ant_read': >

Re: [PATCH net-next] airo: work around stack usage warning

2021-04-17 Thread Kalle Valo
Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc-11 with KASAN on 32-bit arm produces a warning about a function > that needs a lot of stack space: > > drivers/net/wireless/cisco/airo.c: In function 'setup_card.constprop': > drivers/net/wireless/cisco/airo.c:3960:1: error: the frame size of

Re: [PATCH] x86/uaccess: small optimization in unsafe_copy_to_user()

2021-04-17 Thread Al Viro
On Sat, Apr 17, 2021 at 09:27:04AM -0700, Linus Torvalds wrote: > On Sat, Apr 17, 2021 at 9:08 AM Linus Torvalds > wrote: > > > > Side note: I'm, looking at the readdir cases that I wrote, and I have > > to just say that is broken too. So "stones and glass houses" etc, and > > I'll have to fix

Re: [PULL REQUEST] i2c for 5.12

2021-04-17 Thread pr-tracker-bot
The pull request you sent on Sat, 17 Apr 2021 19:18:16 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-current has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/194cf4825638256e9afe1d360831aa5379b3517a Thank you! -- Deet-doot-dot, I am a

RE: [PATCH 2/2] mm: Indicate pfmemalloc pages in compound_head

2021-04-17 Thread David Laight
From: Matthew Wilcox (Oracle) > Sent: 17 April 2021 00:07 > > The net page_pool wants to use a magic value to identify page pool pages. > The best place to put it is in the first word where it can be clearly a > non-pointer value. That means shifting dma_addr up to alias with ->index, > which

Re: [PATCH v8 clocksource 2/5] clocksource: Retry clock read if long delays detected

2021-04-17 Thread Paul E. McKenney
On Sat, Apr 17, 2021 at 02:24:23PM +0200, Thomas Gleixner wrote: > On Tue, Apr 13 2021 at 21:35, Paul E. McKenney wrote: > > #define WATCHDOG_INTERVAL (HZ >> 1) > > #define WATCHDOG_THRESHOLD (NSEC_PER_SEC >> 4) > > +#define WATCHDOG_MAX_SKEW (NSEC_PER_SEC >> 6) > > That's ~15ms which is a tad

Re: [PATCH v8 clocksource 2/5] clocksource: Retry clock read if long delays detected

2021-04-17 Thread Paul E. McKenney
On Sun, Apr 18, 2021 at 01:15:26AM +0200, Thomas Gleixner wrote: > On Sat, Apr 17 2021 at 15:54, Paul E. McKenney wrote: > > On Sat, Apr 17, 2021 at 02:24:23PM +0200, Thomas Gleixner wrote: > >> I so wish we could just delete all of this horror instead of making it > >> more horrible. > > > >

[PATCH] drm/msm: always parse interconnects

2021-04-17 Thread Caleb Connolly
The WARN_ON in dpu_runtime_resume() fires constantly on non-SC7180 platforms. As SDM845 now has interconnects hooked up we should always try and parse them. Fixes: 627dc55c273d ("drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume") Signed-off-by: Caleb Connolly ---

Re: [PATCH] rtlwifi: remove rtl_get_tid_h

2021-04-17 Thread Kalle Valo
Christophe JAILLET wrote: > 'rtl_get_tid_h()' is the same as 'ieee80211_get_tid()'. > So this function can be removed to save a line of code. > > Signed-off-by: Christophe JAILLET Patch applied to wireless-drivers-next.git, thanks. 987e9bcdd0b7 rtlwifi: remove rtl_get_tid_h --

Re: [PATCH RESEND][next] rtl8xxxu: Fix fall-through warnings for Clang

2021-04-17 Thread Jes Sorensen
On 3/10/21 3:59 PM, Kees Cook wrote: > On Wed, Mar 10, 2021 at 02:51:24PM -0500, Jes Sorensen wrote: >> On 3/10/21 2:45 PM, Kees Cook wrote: >>> On Wed, Mar 10, 2021 at 02:31:57PM -0500, Jes Sorensen wrote: On 3/10/21 2:14 PM, Kees Cook wrote: > Hm, this conversation looks like a

Re: [PATCH] media: atomisp: silence "dubious: !x | !y" warning

2021-04-17 Thread Mauro Carvalho Chehab
Em Sat, 17 Apr 2021 21:06:27 +0530 Ashish Kalra escreveu: > Upon running sparse, "warning: dubious: !x | !y" is brought to notice > for this file. Logical and bitwise OR are basically the same in this > context so it doesn't cause a runtime bug. But let's change it to > logical OR to make it

I wait for your response.

2021-04-17 Thread Agata Arnoldo
Dear Beloved, How are you doing, hope all is well? Please I am verifying if your email is still working, I have sent you several messages, but could not get any reply from you, would you get back to me? I have an important message for you. Please write me through my private email for more

Re: [PATCH v9 7/8] pwm: pca9685: Restrict period change for enabled PWMs

2021-04-17 Thread Uwe Kleine-König
On Thu, Apr 15, 2021 at 02:14:54PM +0200, Clemens Gruber wrote: > Previously, the last used PWM channel could change the global prescale > setting, even if other channels are already in use. > > Fix it by only allowing the first enabled PWM to change the global > chip-wide prescale setting. If

Re: [PATCH v9 8/8] pwm: pca9685: Add error messages for failed regmap calls

2021-04-17 Thread Uwe Kleine-König
On Thu, Apr 15, 2021 at 02:14:55PM +0200, Clemens Gruber wrote: > Regmap operations can fail if the underlying subsystem is not working > properly (e.g. hogged I2C bus, etc.) > As this is useful information for the user, print an error message if it > happens. > Let probe fail if the first

Re: [PATCH 3/3] i2c: mediatek: Use scl_int_delay_ns to compensate clock-stretching

2021-04-17 Thread Wolfram Sang
On Sat, Apr 17, 2021 at 02:46:52PM +0800, Qii Wang wrote: > The parameters of tSU,STA/tHD,STA/tSU,STOP maybe out of spec due > to device clock-stretch or circuit loss, we could get a suitable > scl_int_delay_ns from i2c_timings to compensate these parameters > to meet the spec via EXT_CONF

Re: [PATCH -next] PCI: remove unused variable rdev

2021-04-17 Thread Chaitanya Kulkarni
On 4/17/21 04:44, Bixuan Cui wrote: > Fix the build warning: > > drivers/pci/quirks.c: In function ‘quirk_amd_nvme_fixup’: > drivers/pci/quirks.c:312:18: warning: unused variable ‘rdev’ > [-Wunused-variable] > struct pci_dev *rdev; > ^~~~ > > Fixes: 9597624ef606 ('nvme: put

Re: [PATCH] x86/uaccess: small optimization in unsafe_copy_to_user()

2021-04-17 Thread Al Viro
On Sat, Apr 17, 2021 at 08:30:42PM +, Al Viro wrote: > and that thing is still there. However, it does *NOT* do what it might > appear to be doing; it ends up with getdents() returning -EINVAL instead. > What we need is > buf->error = -EINTR; > in addition to that

Re: [PATCH] Fix set apic mode from x2apic enabled bit patch

2021-04-17 Thread Thomas Gleixner
Mike! On Thu, Apr 15 2021 at 17:06, Mike Travis wrote: I'm slowly getting tired of the fact that every patch coming from you fails to comply with the minimal requirements of the documented procedures. $subject: [PATCH] Fix set apic mode from x2apic enabled bit patch Documentation clearly

Re: build failure of malta_qemu_32r6_defconfig

2021-04-17 Thread Sudip Mukherjee
Hi Thomas, On Fri, Apr 9, 2021 at 1:17 PM Thomas Bogendoerfer wrote: > > On Thu, Apr 08, 2021 at 09:42:11AM +0800, YunQiang Su wrote: > > Sudip Mukherjee 于2021年4月8日周四 上午2:26写道: > > > > > > Hi Thomas, > > > > > > I was building v5.10.28 with malta_qemu_32r6_defconfig and noticed that > > > it

Re: [PATCH v8 clocksource 2/5] clocksource: Retry clock read if long delays detected

2021-04-17 Thread Thomas Gleixner
On Sat, Apr 17 2021 at 15:54, Paul E. McKenney wrote: > On Sat, Apr 17, 2021 at 02:24:23PM +0200, Thomas Gleixner wrote: >> I so wish we could just delete all of this horror instead of making it >> more horrible. > > Revisit deleting it in five years if there are no issues, whatever > "issue"

Re: [PATCH v8 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-17 Thread Paul E. McKenney
On Sat, Apr 17, 2021 at 02:28:22PM +0200, Thomas Gleixner wrote: > On Tue, Apr 13 2021 at 21:36, Paul E. McKenney wrote: > > diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c > > index 1fc0962c89c0..97eeaf164296 100644 > > --- a/arch/x86/kernel/kvmclock.c > > +++

GOOD

2021-04-17 Thread Alexander Holmes
How are you today? This is MoneyGram International Inc. we are contacting you concerning your winning fund $1.500, 000.00 USD; your e-mail won $1.500, 000.00 dollars through Internet contest, and lottery bonus under MoneyGram International Inc. Worldwide. The lottery bonus is contesting once in a

Re: [PATCH] x86/uaccess: small optimization in unsafe_copy_to_user()

2021-04-17 Thread Linus Torvalds
On Sat, Apr 17, 2021 at 9:08 AM Linus Torvalds wrote: > > Side note: I'm, looking at the readdir cases that I wrote, and I have > to just say that is broken too. So "stones and glass houses" etc, and > I'll have to fix that too. In particular, the very very old OLD_READDIR interface that only

[PATCH v5] dma-buf: Add DmaBufTotal counter in meminfo

2021-04-17 Thread Peter Enderborg
This adds a total used dma-buf memory. Details can be found in debugfs, however it is not for everyone and not always available. dma-buf are indirect allocated by userspace. So with this value we can monitor and detect userspace applications that have problems. Signed-off-by: Peter Enderborg ---

Re: [PATCH v8 1/8] pwm: pca9685: Switch to atomic API

2021-04-17 Thread Clemens Gruber
Hi, On Sat, Apr 17, 2021 at 05:37:28PM +0200, Uwe Kleine-König wrote: > On Mon, Apr 12, 2021 at 03:27:38PM +0200, Clemens Gruber wrote: > > The switch to the atomic API goes hand in hand with a few fixes to > > previously experienced issues: > > - The duty cycle is no longer lost after

Re: [GIT PULL] libnvdimm fixes for v5.12-rc8 / final

2021-04-17 Thread pr-tracker-bot
The pull request you sent on Fri, 16 Apr 2021 20:25:28 -0700: > git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm > tags/libnvdimm-fixes-for-5.12-rc8 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/bdfd99e6d6bd690b47bd1d45dad218bf08be1dde Thank you! --

Re: [GIT PULL] cxl fixes for v5.12-rc8 / final

2021-04-17 Thread pr-tracker-bot
The pull request you sent on Fri, 16 Apr 2021 20:10:09 -0700: > git://git.kernel.org/pub/scm/linux/kernel/git/cxl/cxl > tags/cxl-fixes-for-5.12-rc8 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/7c22677407243d63df3aee1bb2f6d9aa12c01a24 Thank you! -- Deet-doot-dot,

Re: [GIT PULL] Networking for 5.12-rc8

2021-04-17 Thread pr-tracker-bot
The pull request you sent on Fri, 16 Apr 2021 22:07:03 -0700: > git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git tags/net-5.12-rc8 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/88a5af943985fb43b4c9472b5abd9c0b9705533d Thank you! -- Deet-doot-dot, I am

[PATCH] riscv: Fix 32b kernel caused by 64b kernel mapping moving outside linear mapping

2021-04-17 Thread Alexandre Ghiti
Fix multiple leftovers when moving the kernel mapping outside the linear mapping for 64b kernel that left the 32b kernel unusable. Fixes: 4b67f48da707 ("riscv: Move kernel mapping outside of linear mapping") Signed-off-by: Alexandre Ghiti --- arch/riscv/include/asm/page.h| 9 +

Re: [PATCH] rtlwifi: rtl8188ee: remove redundant assignment of variable rtlpriv->btcoexist.reg_bt_sco

2021-04-17 Thread Kalle Valo
Yang Li wrote: > Assigning value "3" to "rtlpriv->btcoexist.reg_bt_sco" here, but that > stored value is overwritten before it can be used. > > Coverity reports this problem as > CWE563: A value assigned to a variable is never used. > drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c: >

Re: [PATCH 1/1] mm: Fix struct page layout on 32-bit systems

2021-04-17 Thread Arnd Bergmann
On Sat, Apr 17, 2021 at 3:58 PM Matthew Wilcox wrote: > I wouldn't like to make that assumption. I've come across IOMMUs (maybe > on parisc? powerpc?) that like to encode fun information in the top > few bits. So we could get it down to 52 bits, but I don't think we can > get all the way down

Re: [PATCH] mwifiex: Remove unneeded variable: "ret"

2021-04-17 Thread Kalle Valo
zuoqil...@163.com wrote: > From: zuoqilin > > Remove unneeded variable: "ret" > > Signed-off-by: zuoqilin Patch applied to wireless-drivers-next.git, thanks. c81852a48e13 mwifiex: Remove unneeded variable: "ret" --

Re: [PATCH net-next 4/5] libertas: avoid -Wempty-body warning

2021-04-17 Thread Kalle Valo
Arnd Bergmann wrote: > From: Arnd Bergmann > > Building without mesh supports shows a couple of warnings with > 'make W=1': > > drivers/net/wireless/marvell/libertas/main.c: In function 'lbs_start_card': > drivers/net/wireless/marvell/libertas/main.c:1068:37: error: suggest braces > around

[PATCH 2/4] staging: rtl8188eu: remove constant variable and dead code

2021-04-17 Thread Martin Kaiser
g_wifi_on is always true. Remove the variable and the code that would be run only if g_wifi_on was false. Signed-off-by: Martin Kaiser --- drivers/staging/rtl8188eu/os_dep/rtw_android.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git

Re: [PATCH 2/4] staging: rtl8188eu: remove constant variable and dead code

2021-04-17 Thread kernel test robot
Hi Martin, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Martin-Kaiser/staging-rtl8188eu-change-bLeisurePs-type-to-bool/20210418-020200 base:

Re: [PATCH v9 2/8] pwm: pca9685: Support hardware readout

2021-04-17 Thread Uwe Kleine-König
Hello, On Thu, Apr 15, 2021 at 02:14:49PM +0200, Clemens Gruber wrote: > Implement .get_state to read-out the current hardware state. > > The hardware readout may return slightly different values than those > that were set in apply due to the limited range of possible prescale and > counter

[PATCH] capabilities: require CAP_SETFCAP to map uid 0 (v3.2)

2021-04-17 Thread Serge E. Hallyn
A process running as uid 0 but without cap_setfcap currently can simply unshare a new user namespace with uid 0 mapped to 0. While this task will not have new capabilities against the parent namespace, there is a loophole due to the way namespaced file capabilities work. File capabilities valid

Re: [PATCH] x86/uaccess: small optimization in unsafe_copy_to_user()

2021-04-17 Thread Al Viro
[tytso Cc'd] On Sat, Apr 17, 2021 at 06:09:44PM +, Al Viro wrote: > > Al - fairly trivial patch applied, comments? > > Should be fine... FWIW, I've a patch in the same area, making those suckers > return bool. Seeing that they are only ever called via dir_emit(), > dir_emit_dot() > and

RE: [PATCH] media: atomisp: silence "dubious: !x | !y" warning

2021-04-17 Thread David Laight
From: Mauro Carvalho Chehab > Sent: 17 April 2021 19:56 > > Em Sat, 17 Apr 2021 21:06:27 +0530 > Ashish Kalra escreveu: > > > Upon running sparse, "warning: dubious: !x | !y" is brought to notice > > for this file. Logical and bitwise OR are basically the same in this > > context so it doesn't

drivers/md/dm-log-writes.c:452:12: warning: stack frame size of 1184 bytes in function 'log_writes_kthread'

2021-04-17 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 194cf4825638256e9afe1d360831aa5379b3517a commit: 309dca309fc39a9e3c31b916393b74bd174fd74e block: store a block_device pointer in struct bio date: 3 months ago config: powerpc64-randconfig-r032-20210418

Re: [PATCH v8 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-17 Thread Paul E. McKenney
On Sat, Apr 17, 2021 at 02:47:18PM +0200, Thomas Gleixner wrote: > On Tue, Apr 13 2021 at 21:36, Paul E. McKenney wrote: > > Bah, hit send too quick. > > > + cpumask_clear(_ahead); > > + cpumask_clear(_behind); > > + preempt_disable(); > > Daft. Would migrate_disable() be better? Yes,

[PATCH v2 3/3] rtc: rtc_update_irq_enable: rework UIE emulation

2021-04-17 Thread Alexandre Belloni
Now that the core is aware of whether alarms are available, it is possible to decide whether UIE emulation is required before actually trying to set the alarm. This greatly simplifies rtc_update_irq_enable because there is now only one error value to track and is not relying on the return value

Re: mmu.c:undefined reference to `patch__hash_page_A0'

2021-04-17 Thread Randy Dunlap
HI-- I no longer see this build error. However: On 2/27/21 2:24 AM, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 3fb6d0e00efc958d01c2f109c8453033a2d96796 > commit: 259149cf7c3c6195e6199e045ca988c31d081cab powerpc/32s:

Re: [PATCH] x86/uaccess: small optimization in unsafe_copy_to_user()

2021-04-17 Thread Al Viro
On Sat, Apr 17, 2021 at 03:11:49PM -0700, Linus Torvalds wrote: > On Sat, Apr 17, 2021 at 1:35 PM Al Viro wrote: > > > > No, wait - we have non-NULL buf->prev_reclen, so we'll hit > > with buf->error completely ignored. Nevermind. > > Yeah, I'm pretty sure I even tested that -EINTR case at one

Re: [PATCH] media: atomisp: silence "dubious: !x | !y" warning

2021-04-17 Thread Ashish Kalra
On Sat, Apr 17, 2021 at 09:31:32PM +, David Laight wrote: > From: Mauro Carvalho Chehab > > Sent: 17 April 2021 19:56 > > > > Em Sat, 17 Apr 2021 21:06:27 +0530 > > Ashish Kalra escreveu: > > > > > Upon running sparse, "warning: dubious: !x | !y" is brought to notice > > > for this file.

Re: PROBLEM: DoS Attack on Fragment Cache

2021-04-17 Thread Matt Corallo
See-also "[PATCH] Reduce IP_FRAG_TIME fragment-reassembly timeout to 1s, from 30s" (and the two resends of it) - given the size of the default cache (4MB) and the time that it takes before we flush the cache (30 seconds) you only need about 1Mbps of fragments to hit this issue. While DoS attacks

Re: [PATCH V2 5/9] platform/x86: intel_pmc_core: Get LPM requirements for Tiger Lake

2021-04-17 Thread David E. Box
On Sat, 2021-04-17 at 11:00 +0200, Hans de Goede wrote: > Hi, > > On 4/17/21 5:12 AM, David E. Box wrote: > > From: Gayatri Kammela > > > > Platforms that support low power modes (LPM) such as Tiger Lake > > maintain > > requirements for each sub-state that a readable in the PMC. > > However,

  1   2   3   4   >