Re: [PATCH 3/3] libnvdimm/pmem: Provide pmem_dax_clear_poison for dax operation

2021-11-04 Thread Jane Chu
On 11/4/2021 10:55 AM, Christoph Hellwig wrote: > On Tue, Sep 14, 2021 at 05:31:32PM -0600, Jane Chu wrote: >> +static int pmem_dax_clear_poison(struct dax_device *dax_dev, pgoff_t pgoff, >> +size_t nr_pages) >> +{ >> +unsigned int len = PFN_PHYS(nr_pages);

Re: [PATCH 2/3] dax: introduce dax_clear_poison to dax pwrite operation

2021-11-04 Thread Christoph Hellwig
On Tue, Sep 14, 2021 at 05:31:30PM -0600, Jane Chu wrote: > + if ((map_len == -EIO) && (iov_iter_rw(iter) == WRITE)) { No need for the inner braces. > + if (dax_clear_poison(dax_dev, pgoff, PHYS_PFN(size)) == > 0) Overly long line. Otherwise looks good, but it

Re: [PATCH 1/3] dax: introduce dax_operation dax_clear_poison

2021-11-04 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH 3/3] libnvdimm/pmem: Provide pmem_dax_clear_poison for dax operation

2021-11-04 Thread Christoph Hellwig
On Tue, Sep 14, 2021 at 05:31:32PM -0600, Jane Chu wrote: > +static int pmem_dax_clear_poison(struct dax_device *dax_dev, pgoff_t pgoff, > + size_t nr_pages) > +{ > + unsigned int len = PFN_PHYS(nr_pages); > + sector_t sector = PFN_PHYS(pgoff) >>