Signed-off-by signature.
Thanks,
--
Ahmed S. Darwish
http://darwish.07.googlepages.com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
.
+ */
+ if (np-ignore_phy (ecmd-autoneg == AUTONEG_ENABLE ||
A trivial comment actually, Is there a point to write multi-line comments
in two different formats ?
Thanks,
--
Ahmed S. Darwish
http://darwish-07.blogspot.com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
Hi list,
Comment in release_task() claims that group leader's parent process
is signalled only if it desires so, which is not true.
Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED]
---
To save your time, here's the contradictory code which don't appear in
the patch (appears after its last
[Johannes please use replay-to-all to notify all readers]
On 2007-03-17 9:45:36 Johannes Weiner wrote:
On Sat, Mar 17, 2007 at 08:21:32AM +0200, Ahmed S. Darwish wrote:
Comment in release_task() claims that group leader's parent process
is signalled only if it desires so, which is not true
commenting out both lines which led to a non functional init,
Also setting them to __USER_DS made init start but stopped issuing the error:
`Panic: Segment violation at 0x8049798 - Sleeping for 30 seconds'
--
Ahmed S. Darwish
http://darwish.07.googlepages.com
-
To unsubscribe from this list: send
meant setting them to __KERNEL_DS.
Thanks,
--
Ahmed S. Darwish
http://darwish.07.googlepages.com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
On Mon, Mar 19, 2007 at 07:23:25AM -0400, linux-os (Dick Johnson) wrote:
On Sun, 18 Mar 2007, Ahmed S. Darwish wrote:
Hi list,
Reading the kernel threads initialization code I see:
int kernel_thread(...) {
struct pt_regs regs;
memset(regs, 0, sizeof(regs
address handling. Now net_device.dev_addr is kept
consistent
[Remaing patch]
Patch can't be applied or even read cause your mailer has mistakenly wrapped
its lines.
Regards,
--
Ahmed S. Darwish
http://darwish.07.googlepages.com
-
To unsubscribe from this list: send the line unsubscribe
Hi,
An irqaction structure won't be added to the IRQ line irqaction list if they
don't agree wrt the IRQF_PERCPU flag. Only check and set this flag in IRQ
descriptor `status' field when the first irqaction is added to the line list.
Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED]
---
Patch
:
*
+ * Brian Braunstein [EMAIL PROTECTED] 2007/03/23
+ *Fixed hw address handling. Now net_device.dev_addr is kept
consistent
Your mailer still wrap the long lines mistakenly as it did in the first
version of the patch.
Regards,
--
Ahmed S. Darwish
http://darwish.07.googlepages.com
mutt mail reader (not a feature, it displays other
mails long lines without wrapping), sorry.
--
Ahmed S. Darwish
http://darwish.07.googlepages.com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
.
Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED]
---
Patch over 2.6.21-rc5.
Maybe just a better description (with the same patch below):
An irqaction structure won't be added to an IRQ descriptor irqaction list
if it don't agree with other irqactions on the IRQF_PERCPU flag. Don't
check
drivers/video/i810/*
Any more probably responsible files?
Thanks,
--
Ahmed S. Darwish
http://darwish.07.googlepages.com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo
and tell him/her: hey, I have
a patch or two, they simply don't understand that ;).
Second, I think it's very hard to make a considerable project in the kernel
without doing some little patches here and there at first. Google for kernel
newbies and kernel janitors.
Regards,
--
Ahmed S. Darwish
http
not a revolution. You can't be responsible for a good
project directly, just take your way from a janitor to a subsystem maintaner :).
Ofcourse, unless you have an old experience in other OSs (espcifically Unix
ones).
Regards,
--
Ahmed S. Darwish
http://darwish.07.googlepages.com
-
To unsubscribe
bug, you need to CC the linux kernel
networking mailing list. If it's a kobject bug, you need to CC its maintainer
(Greg) and so on.
Regards,
--
Ahmed S. Darwish
HomePage: http://darwish.07.googlepages.com
Blog: http://darwish-07.blogspot.com
-
To unsubscribe from this list: send the line
) {
+ objectstr[*label_len] = '\0';
+ *label_len = 0;
+ }
Same applies here.
/ jakob
Good spots, thanks a lot for the review.
Regards,
--
Ahmed S. Darwish
Homepage: http://darwish.07.googlepages.com
Blog: http://darwish-07
-space utility
that sends the rules to the kernel in a predefined strict format.
You can find how the whole story in the smackv11 announcement here:
http://article.gmane.org/gmane.linux.kernel.lsm/4463
Regards,
--
Ahmed S. Darwish
Homepage: http://darwish.07.googlepages.com
Blog: http://darwish-07
was passed a non-cipso label.
Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED]
---
smackv8-omit-noncipso-in-seq-start.patch
diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c
index 55ba2dc..b061cd0 100644
--- a/security/smack/smackfs.c
+++ b/security/smack/smackfs.c
@@ -297,14 +297,22
now if you agree on this.
Regards,
--
Ahmed S. Darwish
HomePage: http://darwish.07.googlepages.com
Blog: http://darwish-07.blogspot.com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
On 10/28/07, Al Viro [EMAIL PROTECTED] wrote:
On Sat, Oct 27, 2007 at 11:01:12AM +0200, Ahmed S. Darwish wrote:
The problem here (As discussed in private mails) is that the for loop
assumes that the beginning of given user-space buffer is the beginning
of a rule. This leads to situations
we don't do a write operation
depending on that read, right ?.
--
Ahmed S. Darwish
Homepage: http://darwish.07.googlepages.com
Blog: http://darwish-07.blogspot.com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo
Hi!,
[Casey, sending patches in public to get an early review]
Omit non-cipso labels in cipso_seq_start().
Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED]
---
stopping seq_show() if smk_cipso = NULL only fixes the bug
symptom. We'll issue a BUG() in that case cause it signals a
serious
Hi,
Utilizing Al's concers about using smack_cipso_count without locking,
here's a patch that remove smack_cipso_count and uses simple list
traversing in read() without any counting mechanism.
CC: Al Viro [EMAIL PROTECTED]
Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED]
---
Please apply
in such hard coditions?
Regards,
--
Ahmed S. Darwish
HomePage: http://darwish.07.googlepages.com
Blog: http://darwish-07.blogspot.com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org
}security(). Cheating
from SELinux post_create_socket(), it does the same. Casey, Thoughts ?
Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED]
---
diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
index 1c11e42..eb04278 100644
--- a/security/smack/smack_lsm.c
+++ b/security/smack
Hi!,
Appropriately handle sockets with sk = NULL. This is usually the socket
case when starting kernel nfsd.
Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED]
Acked-by: Casey Schaufler [EMAIL PROTECTED]
Tested-by: Joerg Platte [EMAIL PROTECTED]
--
diff --git a/security/smack/smack_lsm.c b
* %p) ?.
Best regards,
--
Ahmed S. Darwish
HomePage: http://darwish.07.googlepages.com
Blog: http://darwish-07.blogspot.com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo
such deprecated macros. I hope this series won't introduce
build errors.
Patches can be applied cleanly on v2.6.23-rc8.
==
Get rid of the deprecated SA_* IRQ flags.
Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED]
---
diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
index 5523f19
Hi Ralf,
A patch to stop using deprecated IRQ flags. The new IRQF_* macros are used
instead.
Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED]
---
diff --git a/arch/mips/pci/ops-pmcmsp.c b/arch/mips/pci/ops-pmcmsp.c
index 09fa007..a86a189 100644
--- a/arch/mips/pci/ops-pmcmsp.c
+++ b/arch/mips
Hi Matthew,
A patch to stop using deprecated IRQ flags in ncr53c8xx documentaion. The new
IRQF_* macros are used instead.
Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED]
---
diff --git a/Documentation/scsi/ChangeLog.ncr53c8xx
b/Documentation/scsi/ChangeLog.ncr53c8xx
index 7d03e9d..a9f721a
.
Thanks,
== (Description for Logs)
Introduce can_add_irqaction_on_allocated_irq and warn_about_irqaction_mismatch
methods to support setup_irq() code modularity.
Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED]
---
manage.c | 92
Introduce irq_desc_match_fist_irqaction() to support setup_irq()
code modularity.
Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED]
---
Any ideas for a better method name ?
manage.c | 89 ---
1 file changed, 51 insertions(+), 38
[ 226.331090] ===
And So on for every task.
Thanks,
--
Ahmed S. Darwish
HomePage: http://darwish.07.googlepages.com
Blog: http://darwish-07.blogspot.com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More
, This is not an Oops at all. Really sorry.
/me wondering about my look now posting a normal message as an Ooops a day
before the stable release :(.
--
Ahmed S. Darwish
HomePage: http://darwish.07.googlepages.com
Blog: http://darwish-07.blogspot.com
-
To unsubscribe from this list: send the line
On Sun, Oct 07, 2007 at 01:12:38AM +0400, Alexey Dobriyan wrote:
On Sat, Oct 06, 2007 at 10:14:06PM +0200, Ahmed S. Darwish wrote:
Pressing sysRq+T always produce an Oops for every running system task (94
Oopses, that's a record ;)).
uh-oh. For every sleeping task, I think.
The bug
from function definition and from the innocent EXPORT_SYMBOL
macro (It makes the method available to kernel modules).
Regards,
--
Ahmed S. Darwish
HomePage: http://darwish.07.googlepages.com
Blog: http://darwish-07.blogspot.com
-
To unsubscribe from this list: send the line unsubscribe linux
and char c[] = msg is
that the first is a non-const pointer to a const char array while the second
is a modifiable char array ?
If so, what's the point of the patch ?
Thanks,
--
Ahmed S. Darwish
HomePage: http://darwish.07.googlepages.com
Blog: http://darwish-07.blogspot.com
-
To unsubscribe
, size_t size);
As an extension to the POSIX.1 standard, Linux (libc4, libc5, glibc) getcwd()
allocates the buffer dynamically using malloc() if buf is NULL on call.
Shouldn't srctree be free()ed in case getenv(SRCTREE) failed ?
Regards,
--
Ahmed S. Darwish
HomePage: http://darwish.07
:
http://lkml.org/lkml/2007/9/24/394
--
Ahmed S. Darwish
HomePage: http://darwish.07.googlepages.com
Blog: http://darwish-07.blogspot.com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
On Tue, Oct 09, 2007 at 08:55:00AM -0700, Randy Dunlap wrote:
On Tue, 9 Oct 2007 15:03:15 +0200 Ahmed S. Darwish wrote:
Hi Rob,
On Tue, Oct 09, 2007 at 01:25:18AM -0500, Rob Landley wrote:
[...]
FILE * infile;
+
+ srctree = getenv(SRCTREE);
+ if (!srctree) srctree
On Tue, Oct 09, 2007 at 10:24:03AM -0700, Randy Dunlap wrote:
Ahmed S. Darwish wrote:
On Tue, Oct 09, 2007 at 08:55:00AM -0700, Randy Dunlap wrote:
On Tue, 9 Oct 2007 15:03:15 +0200 Ahmed S. Darwish wrote:
Hi Rob,
On Tue, Oct 09, 2007 at 01:25:18AM -0500, Rob Landley wrote:
[...]
FILE
On Tue, Oct 09, 2007 at 08:33:59PM +0200, Philipp Matthias Hahn wrote:
Hello!
On Tue, Oct 09, 2007 at 02:40:35PM +0200, Ahmed S. Darwish wrote:
On Tue, Oct 09, 2007 at 01:55:42AM +0400, Dmitri Vorobiev wrote:
The patch below contains a small code clean-up for the NTFS driver: all
On Fri, Oct 12, 2007 at 01:29:31PM -0400, Dmitry Torokhov wrote:
Hi Ahmed,
Hi :),
On 10/12/07, Ahmed S. Darwish [EMAIL PROTECTED] wrote:
On Fri, Oct 12, 2007 at 03:38:47PM +0800, Bryan Wu wrote:
Signed-off-by: Bryan Wu [EMAIL PROTECTED]
---
Hi Bryan,
Why creating module's
;
+
+ client = kmalloc(sizeof(struct i2c_client), GFP_KERNEL);
+ if (!client)
+ return -ENOMEM;
+ memset(client, 0, sizeof(struct i2c_client));
kzalloc.
Regards,
--
Ahmed S. Darwish
HomePage: http://darwish.07.googlepages.com
Blog: http://darwish-07.blogspot.com
-
To unsubscribe from
] Error 2
make[1]: *** [drivers/mmc] Error 2
make: *** [drivers] Error 2
You can fix it using this patch: http://lkml.org/lkml/2007/10/12/380
Or the patch titled: mmc-fix-compile-without-led-triggers.patch
Regards,
--
Ahmed S. Darwish
HomePage: http://darwish.07.googlepages.com
Blog: http
-196.218.207.18.tedata.net: ICMP
parameter problem - octet 20, length 48
Best Regards,
--
Ahmed S. Darwish
HomePage: http://darwish.07.googlepages.com
Blog: http://darwish-07.blogspot.com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL
,
--
Ahmed S. Darwish
HomePage: http://darwish.07.googlepages.com
Blog: http://darwish-07.blogspot.com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ
On Tue, Oct 16, 2007 at 02:08:04PM +0800, Bryan Wu wrote:
On 10/16/07, Ahmed S. Darwish [EMAIL PROTECTED] wrote:
On Mon, Oct 15, 2007 at 11:48:17AM -0400, Dmitry Torokhov wrote:
Hi Bryan,
On 10/15/07, Bryan Wu [EMAIL PROTECTED] wrote:
+
+static int ad7142_thread(void *nothing
wireless-tools 28
--
Ahmed S. Darwish
.config.gz
Description: Binary data
that the starting sequence is
--
Ahmed S. Darwish
http://darwish-07.blogspot.com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
*
+ sizeof(struct ipw2100_rx_packet),
+ GFP_KERNEL);
if (!priv-rx_buffers) {
IPW_DEBUG_INFO(can't allocate rx packet buffer table\n);
--
Ahmed S. Darwish
http://darwish-07.blogspot.com
-
To unsubscribe from
);
if (!o_ltp)
goto free_mem_out;
memset(o_ltp, 0, sizeof(struct ktermios));
--
Ahmed S. Darwish
http://darwish-07.blogspot.com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
On Fri, Jan 05, 2007 at 01:56:09AM -0500, Robert P. J. Day wrote:
On Fri, 5 Jan 2007, Ahmed S. Darwish wrote:
Remove unnecessary kmalloc casts in drivers/char/tty_io.c
rather than remove these casts a file or two at a time, why not just
do them all at once and submit a single patch
On Fri, Jan 05, 2007 at 09:10:01AM +0100, Rolf Eike Beer wrote:
Ahmed S. Darwish wrote:
Remove unnecessary kmalloc casts in drivers/char/tty_io.c
Signed-off-by: Ahmed Darwish [EMAIL PROTECTED]
if (!*ltp_loc) {
-ltp = (struct ktermios *) kmalloc(sizeof(struct ktermios
), GFP_NOFS);
if (key.name == 0) {
DT_PUTPAGE(smp);
rc = -ENOMEM;
--
Ahmed S. Darwish
http://darwish-07.blogspot.com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
of the complete thing avoiding two rather trivial
patches touching the same line twice.
Eike
OK. In progress
--
Ahmed S. Darwish
http://darwish-07.blogspot.com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo
. Alan Cox. ?. Sorry, Alan alone is ambiguous.
--
Ahmed S. Darwish
http://darwish-07.blogspot.com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
(void *), GFP_KERNEL);
+ p = kzalloc(driver-num * 3 * sizeof(void *), GFP_KERNEL);
if (!p)
return -ENOMEM;
- memset(p, 0, driver-num * 3 * sizeof(void *));
}
if (!driver-major) {
--
Ahmed S. Darwish
http://darwish
++;
- ret = 1;
+ return 1;
}
spin_unlock_irqrestore(tty_ldisc_lock, flags);
- return ret;
+ return 0;
}
Very sorry, Didn't mention the spin_unlock_irqrestore().
Here's the modified patch without this hunk.
Signed-off-by: Ahmed S. Darwish
diff
On Fri, Jan 05, 2007 at 09:10:01AM +0100, rday wrote:
Ahmed S. Darwish wrote:
Remove unnecessary kmalloc casts in drivers/char/tty_io.c
Signed-off-by: Ahmed Darwish [EMAIL PROTECTED]
rday
p.s. just FYI, i have a patch that does most of this, but i was going
to hold off submitting
,
__FILE__, __LINE__);
}
- memset(brd-channels[i], 0, sizeof(struct jsm_channel));
}
}
--
Ahmed S. Darwish
http://darwish-07.blogspot.com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
,
+GFP_ATOMIC);
if (NewStatusBuffer == NULL)
{
DAC960_Warning(Unable to expand Combined Status Buffer - Truncating\n,
--
Ahmed S. Darwish
http://darwish-07.blogspot.com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL
);
+ ret_buf = kzalloc(sizeof (struct cifsTconInfo),
+ GFP_KERNEL);
if (ret_buf) {
write_lock(GlobalSMBSeslock);
atomic_inc(tconInfoAllocCount);
--
Ahmed S. Darwish
http://darwish-07.blogspot.com
-
To unsubscribe from this list: send the line
;
- memset(dev, 0, sizeof (struct net_device));
}
dev-priv = privptr;
--
Ahmed S. Darwish
http://darwish-07.blogspot.com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org
., __FUNCTION__);
--
Ahmed S. Darwish
http://darwish-07.blogspot.com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
-collection);
kfree(device);
return NULL;
--
Ahmed S. Darwish
http://darwish-07.blogspot.com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org
, and *before* you start the actual patch,
you can add superfluous text, like asking about who the maintainer is,
so that informal dialogue like that doesn't become part of the
permanent patch record.
rday
Thanks for all the good notes ..
--
Ahmed S. Darwish
http://darwish-07.blogspot.com
On Sat, Jan 06, 2007 at 09:46:30AM -0800, Randy Dunlap wrote:
On Sat, 6 Jan 2007 15:17:25 +0200 Ahmed S. Darwish wrote:
Hi all,
I'm not able to find the DAC960 block driver maintainer. If someones knows
please reply :).
It's orphaned. Andrew can decide to merge this, or one
On Mon, Jan 08, 2007 at 11:12:28AM +0800, Li Yang-r58472 wrote:
From: Ahmed S. Darwish [mailto:[EMAIL PROTECTED]
Hi,
A kmalloc casting cleanup patch.
Signed-off-by: Ahmed Darwish [EMAIL PROTECTED]
[..]
- (u32) (kmalloc((u32) (length + align
On Mon, Jan 08, 2007 at 11:12:28AM +0800, Li Yang-r58472 wrote:
NACK about the 2 clean-ups above. Cast from pointer to integer is
required here.
Hi, here's the modified patch.
A patch to switch kmalloc to kzalloc and clean some redundant kmalloc
casts.
Signed-off-by: Ahmed S. Darwish
On Mon, Jan 08, 2007 at 01:10:19PM +0100, Rolf Eike Beer wrote:
Ahmed S. Darwish wrote:
Hi all,
This is a patch to remove the unneeded k[mzc]alloc casts in the whole
Signed-off-by: Ahmed Darwish
diff --git a/arch/cris/arch-v32/mm/intmem.c
b/arch/cris/arch-v32/mm/intmem.c index
Substitue intel_rng magic PCI IDs values used in the IDs table
with the macros defined in pci_ids.h
Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED]
---
I've used a small script to generate this patch then manually tried to
make sure it's (hopefully) correct.
#!/bin/bash
INTEL_RNG_FILE
On Mon, Jan 15, 2007 at 06:31:01AM +1100, Dave Airlie wrote:
On 1/15/07, Arjan van de Ven [EMAIL PROTECTED] wrote:
On Sun, 2007-01-14 at 19:24 +0200, Ahmed S. Darwish wrote:
Substitue intel_rng magic PCI IDs values used in the IDs table
with the macros defined in pci_ids.h
Hi,
hmm
On Sun, Jan 14, 2007 at 09:37:21AM -0800, Arjan van de Ven wrote:
On Sun, 2007-01-14 at 19:24 +0200, Ahmed S. Darwish wrote:
Substitue intel_rng magic PCI IDs values used in the IDs table
with the macros defined in pci_ids.h
Hi,
hmm this is actually the opposite direction than most
On Sun, Jan 14, 2007 at 04:29:48PM -0800, Greg KH wrote:
On Sun, Jan 14, 2007 at 07:24:21PM +0200, Ahmed S. Darwish wrote:
Substitue intel_rng magic PCI IDs values used in the IDs table
with the macros defined in pci_ids.h
Why not use the PCI_DEVICE() macro too? It should make the lines
-off-by: Ahmed S. Darwish [EMAIL PROTECTED]
---
I've used a script to generate that patch, then checked the results manually
to make sure that it's (hopefully) correct.
#!/bin/bash
INTEL_RNG_FILE=drivers/char/hw_random/intel-rng.c
TMP_FILE=$(mktemp)
# File to hold Magic PCI deviceIDs
On Sun, Jan 14, 2007 at 04:29:48PM -0800, Greg KH wrote:
On Sun, Jan 14, 2007 at 07:24:21PM +0200, Ahmed S. Darwish wrote:
Substitue intel_rng magic PCI IDs values used in the IDs table
with the macros defined in pci_ids.h
Why not use the PCI_DEVICE() macro too? It should make the lines
Use ARRAY_SIZE macro in pvrusb2-hdw.c file
Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED]
---
diff --git a/drivers/media/video/pvrusb2/pvrusb2-hdw.c
b/drivers/media/video/pvrusb2/pvrusb2-hdw.c
index d200496..f66f7c6 100644
--- a/drivers/media/video/pvrusb2/pvrusb2-hdw.c
+++ b/drivers/media
Use ARRAY_SIZE macro in pvrusb2-std.c file
Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED]
---
diff --git a/drivers/media/video/pvrusb2/pvrusb2-std.c
b/drivers/media/video/pvrusb2/pvrusb2-std.c
index f95c598..677f126 100644
--- a/drivers/media/video/pvrusb2/pvrusb2-std.c
+++ b/drivers/media
Use ARRAY_SIZE macro in miscellaneous pvrusb2 files found
Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED]
---
This patch ofcourse don't include previous patches in the set. I've just
included the remaining modifications in one patch/mail cause every file
touched here has only one or two lines
Hi all,
A cleanup series for the pvrusb2 code to use the ARRAY_SIZE macro. Since
The size of the patch is big, I've splitted it to 4 pieces according to
the files they touch.
PATCH 1/4: Use ARRAY_SIZE in pvrusb2-encoder.c
Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED]
---
diff --git
Hi all,
Patch uses the ARRAY_SIZE macro defined in kernel.h instead of
reemplementing it.
Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED]
---
bt8xx/dvb-bt8xx.c |2 +-
frontends/cx24110.c |4 ++--
frontends/cx24123.c |6 +++---
3 files changed, 6 insertions(+), 6 deletions(-)
diff
Hi all,
A trivial patch to use ARRAY_SIZE macro defined in kernel.h instead
of reimplementing it.
Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED]
---
capi.c|4 ++--
capidrv.c |4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/isdn/capi/capi.c b/drivers
On Tue, Jan 16, 2007 at 03:36:16AM -0500, Robert P. J. Day wrote:
On Tue, 16 Jan 2007, Ahmed S. Darwish wrote:
Use ARRAY_SIZE macro in pvrusb2-hdw.c file
Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED]
... snip ...
i'm not sure it's worth submitting multiple patches to convert
On Tue, Jan 16, 2007 at 10:16:33AM -0800, Randy Dunlap wrote:
On Tue, 16 Jan 2007 03:36:16 -0500 (EST) Robert P. J. Day wrote:
On Tue, 16 Jan 2007, Ahmed S. Darwish wrote:
Use ARRAY_SIZE macro in pvrusb2-hdw.c file
Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED]
... snip
the /APIchanges in the Kernel Janitors TODO list
http://kernelnewbies.org/KernelJanitors/Todo
Also: Documentation/stable_api_nonsense.txt
--
Ahmed S. Darwish
http://darwish-07.blogspot.com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL
/SubmittingPatches
$KERNEL_TREE/Documentation/CodingStyle
--
Ahmed S. Darwish
http://darwish-07.blogspot.com
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ
, size, _PAGE_PCD | _PAGE_PWT);
if (!p)
return p;
Thanks,
[*]: latest pull calls set_memory_uc() which also sets the _PWT flag.
--
Ahmed S. Darwish
Homepage: http://darwish.07.googlepages.com
Blog: http://darwish-07.blogspot.com
--
To unsubscribe from this list: send
On Thu, Feb 07, 2008 at 12:59:23AM +0100, Ingo Molnar wrote:
* Ahmed S. Darwish [EMAIL PROTECTED] wrote:
Hi all,
Beginning from commit 4138cc3418f5, ioremap_nocache() sets the _PAGE_PWT
flag.
Lguest doesn't accept a guest pte with a _PWT flag and reports a bad
page table
that mean ?
Thanks in advance
--
Ahmed S. Darwish
Homepage: http://darwish.07.googlepages.com
Blog: http://darwish-07.blogspot.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
Hi Andreas,
On Fri, Feb 15, 2008, Andreas Schwab wrote:
Ahmed S. Darwish [EMAIL PROTECTED] writes:
I don't understand how the `fn' argument reached the child thread
in the %ebx register. It's said in the comment that `fn' will be
popped to child 'in the ebx frobbing below'. But what does
On Sat, Feb 16, 2008 at 12:28:11AM +0100, Andreas Schwab wrote:
Ahmed S. Darwish [EMAIL PROTECTED] writes:
Hi Andreas,
On Fri, Feb 15, 2008, Andreas Schwab wrote:
Ahmed S. Darwish [EMAIL PROTECTED] writes:
I don't understand how the `fn' argument reached the child thread
Hi all,
Remove redundant irq_desc[NR_IRQS] element initialization in
init_ISA_irqs(). irq_desc[NR_IRQS] is already statically
initialized with the same values in kernel/irq/handle.c .
Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED]
---
i8259_32.c | 26 ++
1 file
Hi all,
Avoid duplicating __tasklet_schedule() and __tasklet_hi_schedule()
code in tasklet_action() and tasklet_hi_action() respectively.
Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED]
---
This also saves a few bytes of image space:
textdata bss dec hex filename
3632
On Tue, Feb 19, 2008 at 04:52:52PM +0100, Ingo Molnar wrote:
* Ahmed S. Darwish [EMAIL PROTECTED] wrote:
- local_irq_disable();
- t-next = __get_cpu_var(tasklet_vec).list;
- __get_cpu_var(tasklet_vec).list = t;
- __raise_softirq_irqoff
On Wed, Feb 20, 2008 at 11:41:13AM +0100, Ingo Molnar wrote:
* Ahmed S. Darwish [EMAIL PROTECTED] wrote:
- local_irq_disable();
- t-next = __get_cpu_var(tasklet_vec).list;
- __get_cpu_var(tasklet_vec).list = t
On Wed, Feb 20, 2008 at 03:20:52PM +0100, Dmitry Adamushko wrote:
On 20/02/2008, Ahmed S. Darwish [EMAIL PROTECTED] wrote:
On Wed, Feb 20, 2008 at 11:41:13AM +0100, Ingo Molnar wrote:
* Ahmed S. Darwish [EMAIL PROTECTED] wrote:
- local_irq_disable
] lguest: fix pgdir pmd index cacluation
Remove an error in index calculation which leads to removing
a not existing shadow page table (leading to a Null dereference).
Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED]
---
diff --git a/arch/x86/lguest/boot.c b/arch/x86/lguest/boot.c
index 5afdde4
On Sun, Feb 24, 2008 at 05:18:14PM +0100, Ingo Molnar wrote:
* Ahmed S. Darwish [EMAIL PROTECTED] wrote:
I am not sure why the division over four existed in the first place.
It seems bogus, maybe the Xen patch just made the problem appear ?
i think so - nice detective work and nice
1 - 100 of 850 matches
Mail list logo
