[PATCH] staging/gdm72xx: coding style fixes gdm_qos.c

Fix checkpatch.pl warnings: WARNING: Prefer pr_debug(... to printk(KERN_DEBUG, ... WARNING: Prefer pr_warn(... to printk(KERN_WARNING, ... WARNING: Prefer pr_err(... to printk(KERN_ERR, ... Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/staging/gdm72xx/gdm_qos.c |6

[PATCH] staging: sbe-2t3e3: fix error handling in t3e3_init_channel()

t3e3_init_channel() incorrectly handles errors in several places: it returns zero and does not deallocate all required resources. The patch fixes that places. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers

[PATCH] extcon: arizona: unlock mutex on error path in arizona_micdet()

If regmap_read() failed, arizona_micdet() returns IRQ_NONE leaving info-lock mutex locked as opposed to all other return paths. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/extcon/extcon-arizona.c |1 + 1

[PATCH] jffs2: Make handling of erase_completion_lock consistent in jffs2_do_reserve_space()

Users of jffs2_do_reserve_space() expect they still held erase_completion_lock after call to it. But there is a path where jffs2_do_reserve_space() leaves erase_completion_lock unlocked. The patch fixes it. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey

[PATCH] e1000e: fix mismatch in mutex lock-unlock in e1000_reset_hw_82571()

by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/net/ethernet/intel/e1000e/82571.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/e1000e/82571.c b/drivers/net/ethernet/intel

[PATCH] ext4: unregister extents status shrinker if mount failed

If ext4_fill_super() failed after extents status shrinker has been registered, the shrinker is left in a global list while the memory, it sits in, is already freed. Oops is not so bad scenario after that. Found by Linux File System Verification project (linuxtesting.org). Signed-off-by: Alexey

[PATCH] staging: dgrp: implement error handling in dgrp_create_class_sysfs_files()

There is no any error handling in dgrp_create_class_sysfs_files(). The patch adds code to check return values and propagate them to dgrp_init_module(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/staging

Re: [PATCH] hfs: add error checking for hfs_find_init()

Hi Vyacheslav, On 03/30/2013 03:35 PM, Vyacheslav Dubeyko wrote: Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- fs/hfs/catalog.c | 12 +--- fs/hfs/dir.c |8 ++-- fs/hfs/extent.c | 48

[PATCH] tty: mxser: fix cycle termination condition in mxser_probe() and mxser_module_init()

There is a bug in resources deallocation code in mxser_probe() and mxser_module_init(). As soon as variable 'i' is unsigned int, cycle termination condition i = 0 is always true. The patch fixes the issue. Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/tty/mxser.c |8

[PATCH 1/2] hfsplus: add error propagation to __hfsplus_ext_write_extent()

__hfsplus_ext_write_extent() suppresses errors coming from hfs_brec_find(). The patch implements error code propagation. Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- fs/hfsplus/extents.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git

[PATCH 2/2] hfsplus: add printk to log allocation failure in hfs_find_init()

Add printk to log allocation failure in hfs_find_init(), so that there is a sign in dmesg when the error condition is triggered. (per Hin-Tak Leung request) Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- fs/hfsplus/bfind.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion

Re: [patch] tty: mxser: forever loops on error

Hi Dan, Thank you for the patch. We are also trying to fix the issue: https://lkml.org/lkml/2013/2/19/29 https://lkml.org/lkml/2013/4/8/55 and the fix is finally in Greg's tty git tree since yesterday: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git (tty-linus branch). Best

[PATCH 1/2] hfs: add error checking for hfs_find_init()

Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- fs/hfs/catalog.c | 12 +--- fs/hfs/dir.c |8 ++-- fs/hfs/extent.c | 48 +--- fs/hfs/hfs_fs.h |2 +- fs/hfs/inode.c | 11

[PATCH 2/2] hfsplus: add error propagation to __hfsplus_ext_write_extent()

__hfsplus_ext_write_extent() suppresses errors coming from hfs_brec_find(). The patch implements error code propagation. Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- fs/hfsplus/extents.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git

[PATCH] [media] cx88: Fix unsafe locking in suspend-resume

and cx8802_irq. That means a deadlock is possible if an interrupt happens while suspend or resume owns the lock. The patch replaces spin_lock/spin_unlock with spin_lock_irqsave/spin_unlock_irqrestore. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov

[PATCH] hfs: add error checking for hfs_find_init()

Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- fs/hfs/catalog.c | 12 +--- fs/hfs/dir.c |8 ++-- fs/hfs/extent.c | 48 +--- fs/hfs/hfs_fs.h |2 +- fs/hfs/inode.c | 11

[PATCH] usb: cdc-acm: fix error handling in acm_probe()

acm_probe() ignores errors in tty_port_register_device() and leaves intfdata pointing to freed memory on alloc_fail7 error path. The patch fixes the both issues. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers

[PATCH] SUNRPC/cache: add module_put() on error path in cache_open()

If kmalloc() fails in cache_open(), module cd-owner left locked. The patch adds module_put(cd-owner) on this path. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- net/sunrpc/cache.c |4 +++- 1 file changed, 3

[PATCH] usb/core/devio.c: Don't use GFP_KERNEL while we cannot reset a storage device

between usb_lock_device() and usb_unlock_device(). Replace by GFP_NOIO. The patch fixes the same issue in usb/core/devio.c. All the allocations fixed are under usb_lock_device() from usbdev_do_ioctl(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov

[PATCH 2/2] pcmcia: synclink_cs: cleanup checkpatch warnings

ERROR: open brace '{' following struct go on the same line ERROR: space required after that ',' ERROR: space prohibited after that open parenthesis '(' WARNING: please, no spaces at the start of a line WARNING: please, no space before tabs Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru

[PATCH] stmmac: don't return zero on failure path in stmmac_pci_probe()

If stmmac_dvr_probe() fails in stmmac_pci_probe(), it breaks off initialization, deallocates all resources, but returns zero. The patch adds -ENODEV as return value in this case. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi

[PATCH] drbd: add module_put() on error path in drbd_proc_open()

If single_open() fails in drbd_proc_open(), module refcount is left incremented. The patch adds module_put() on the error path. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/block/drbd/drbd_proc.c | 10

[PATCH] mwifiex: don't return zero on failure paths in mwifiex_pcie_init()

If pci_iomap() fails in mwifiex_pcie_init(), it breaks off initialization, deallocates all resources, but returns zero. The patch adds -EIO as return value in this case. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru

[PATCH] mwl8k: don't return zero on failure paths in mwl8k_probe[_hw]()

). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/net/wireless/mwl8k.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/mwl8k.c b/drivers/net/wireless/mwl8k.c index f221b95..018f442 100644 --- a/drivers/net/wireless/mwl8k.c +++ b/drivers/net

[PATCH] iwlegacy: don't return zero on failure paths in il4965_pci_probe()

If hardware is not ready, il4965_pci_probe() breaks off initialization, deallocates all resources, but returns zero. The patch adds -EIO as return value in this case. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru

[PATCH] tty: mxser: improve error handling in mxser_probe() and mxser_module_init()

free_irq() from mxser_release_ISA_res() to mxser_board_remove(), since it makes mxser_release_ISA_res() a counterpart for mxser_get_ISA_conf(), while free_irq() is relevant to both ISA and PCI boards. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov

[PATCH v2] tty: mxser: improve error handling in mxser_probe() and mxser_module_init()

free_irq() from mxser_release_ISA_res() to mxser_board_remove(), since it makes mxser_release_ISA_res() a counterpart for mxser_get_ISA_conf(), while free_irq() is relevant to both ISA and PCI boards. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov

[PATCH] [media] stv090x: do not unlock unheld mutex in stv090x_sleep()

goto err and goto err_gateoff before mutex_lock(state-internal-demod_lock) lead to unlock of unheld mutex in stv090x_sleep(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/media/dvb-frontends/stv090x.c | 22

Re: [PATCH] [media] stv090x: do not unlock unheld mutex in stv090x_sleep()

On 02/20/2013 10:58 AM, Manu Abraham wrote: Hi, On Wed, Feb 20, 2013 at 12:28 AM, Alexey Khoroshilov khoroshi...@ispras.ru wrote: goto err and goto err_gateoff before mutex_lock(state-internal-demod_lock) lead to unlock of unheld mutex in stv090x_sleep(). Out of curiosity, what happens when

[PATCH] [SCSI] scsi_dh_hp_sw: return -ENOMEM if kzalloc() failed

If kzalloc() failed, hp_sw_bus_attach() breaks off initialization, but returns zero. The patch adds -ENOMEM as return value in this case. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/scsi/device_handler

[PATCH] USB: omninet: fix potential tty NULL dereference

Add check for return value of tty_port_tty_get, since it can return NULL after port hangup that may happen anytime. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/usb/serial/omninet.c |8 +--- 1 file

[PATCH] pcmcia: synclink_cs: fix potential tty NULL dereference

tty_port_tty_get() can return NULL after port hangup that may happen anytime. The patch adds checks that tty_port_tty_get() returns nonNULL around places where tty is actually used. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi

[PATCH v2] pcmcia: synclink_cs: fix potential tty NULL dereference

handling updated according Alan Cox feedback. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/char/pcmcia/synclink_cs.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git

[PATCH v2] [SCSI] mpt2sas: fix double mutex lock in NON_BLOCKING state

-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/scsi/mpt2sas/mpt2sas_ctl.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt2sas/mpt2sas_ctl.c b/drivers/scsi/mpt2sas/mpt2sas_ctl.c index 49bdd2d..d29ea56 100644 --- a/drivers/scsi/mpt2sas

[PATCH] virtio: console: fix error handling in init() function

If register_virtio_driver() fails, virtio-ports class is not destroyed. The patch adds error handling of register_virtio_driver(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/char/virtio_console.c | 12

[PATCH] ppdev: ppdev_init: do not return zero in case of failure

). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/char/ppdev.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/char/ppdev.c b/drivers/char/ppdev.c index 3fcf80f..d0d824e 100644 --- a/drivers/char/ppdev.c +++ b/drivers/char/ppdev.c @@ -783,7 +783,8

[PATCH] staging: bcm: fix error handling in bcm_init()

bcm_init() does not have proper error handling of usb_register(). The patch implements one. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/staging/bcm/InterfaceInit.c | 12 +++- 1 file changed, 11

[PATCH v2] staging: bcm: fix error handling in bcm_init()

bcm_init() does not have proper error handling of usb_register(). The patch implements one. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/staging/bcm/InterfaceInit.c | 10 +- 1 file changed, 9

[PATCH] staging: bcm: use pr_info and pr_err rather than printk

Convert printk(KERN_INFO to pr_info( and printk(KERN_ERR to pr_err(. Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/staging/bcm/InterfaceInit.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers

[PATCH] HID: hidraw: improve error handling in hidraw_init()

-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/hid/hidraw.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c index 36fa77b..15e6660 100644 --- a/drivers/hid/hidraw.c +++ b/drivers/hid/hidraw.c @@ -549,21

[PATCH] [media] ddbridge: fix error handling in module_init_ddbridge()

If pci_register_driver() failed, resources allocated in ddb_class_create() are leaked. The patch fixes it. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/media/dvb/ddbridge/ddbridge-core.c |6 +- 1 file

[PATCH] [media] ddbridge: fix error handling in module_init_ddbridge()

If pci_register_driver() failed, resources allocated in ddb_class_create() are leaked. The patch fixes it as well as it replaces -1 with correct error code in ddb_class_create(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi

[PATCH] drm/edid: Fix potential memory leak in edid_load()

Do not leak memory by updating pointer with potentially NULL realloc return value. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/gpu/drm/drm_edid_load.c |8 +--- 1 file changed, 5 insertions(+), 3

[PATCH] iio/adjd_s311: Fix potential memory leak in adjd_s311_update_scan_mode()

Do not leak memory by updating pointer with potentially NULL realloc return value. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/iio/light/adjd_s311.c | 14 ++ 1 file changed, 10 insertions(+), 4

[PATCH] USB: whci-hcd: Fix potential memory leak in qset_add_urb_sg()

(linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/usb/host/whci/qset.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/whci/qset.c b/drivers/usb/host/whci/qset.c index 76083ae..dc31c42 100644 --- a/drivers/usb

Re: [PATCH] iio/adjd_s311: Fix potential memory leak in adjd_s311_update_scan_mode()

, there is no need preserve the data in the buffer as krealloc does That is fine. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/iio/light/adjd_s311.c | 14 ++ 1 file changed, 10 insertions(+), 4

[PATCH v2] iio/adjd_s311: Fix potential memory leak in adjd_s311_update_scan_mode()

Do not leak memory by updating pointer with potentially NULL realloc return value. There is no need to preserve data in the buffer, so replace krealloc() by kfree()-kmalloc() pair. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi

[PATCH] net/core: Fix potential memory leak in dev_set_alias()

Do not leak memory by updating pointer with potentially NULL realloc return value. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- net/core/dev.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff

[PATCH] wusb: Fix potential memory leak in wusb_dev_sec_add()

Do not leak memory by updating pointer with potentially NULL realloc return value. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/usb/wusbcore/security.c |7 --- 1 file changed, 4 insertions(+), 3

[PATCH] can/softing: Fix potential memory leak in softing_load_fw()

Do not leak memory by updating pointer with potentially NULL realloc return value. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/net/can/softing/softing_fw.c |7 --- 1 file changed, 4 insertions(+), 3

[PATCH] rndis_wlan: Fix potential memory leak in update_pmkid()

Do not leak memory by updating pointer with potentially NULL realloc return value. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/net/wireless/rndis_wlan.c |6 -- 1 file changed, 4 insertions(+), 2

[PATCH] exofs: check for allocation failure in uri_store()

There is no memory allocation failure check in uri_store(). That can lead to NULL pointer dereference. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- fs/exofs/sys.c |7 ++- 1 file changed, 6 insertions(+), 1

[PATCH] bio: Fix potential memory leak in bio_find_or_create_slab()

Do not leak memory by updating pointer with potentially NULL realloc return value. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- fs/bio.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git

[RESEND PATCH] [SCSI] mpt2sas: fix double mutex lock in NON_BLOCKING state

If state is NON_BLOCKING and mutex_trylock is succeed, the control flow goes to mutex_lock_interruptible() that is a deadlock. Found by Linux Driver Verification project (linuxtesting.org). Acked-by: Nandigama, Nagalakshmi nagalakshmi.nandig...@lsi.com Signed-off-by: Alexey Khoroshilov khoroshi

[PATCH] uwb: fix uwb_dev_unlock() missed at an error path in uwb_rc_cmd_async()

There is the only path in uwb_rc_cmd_async() where rc-uwb_dev is left unlocked. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/uwb/reset.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/uwb

[PATCH] mei: fix mismatch in mutex unlock-lock in mei_amthif_read()

-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/misc/mei/amthif.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/misc/mei/amthif.c b/drivers/misc/mei/amthif.c index 18794ae..e40ffd9 100644 --- a/drivers/misc/mei/amthif.c +++ b/drivers/misc/mei

[PATCH] p54pci: don't return zero on failure path in p54p_probe()

If pci_set_dma_mask() or pci_set_consistent_dma_mask() fails in p54p_probe(), it breaks off initialization, deallocates all resources, but returns zero. The patch implements proper error code propagation. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey

Re: [PATCH] p54pci: don't return zero on failure path in p54p_probe()

On 01/02/2013 01:45 AM, Christian Lamparter wrote: On Tuesday 01 January 2013 22:11:01 Alexey Khoroshilov wrote: If pci_set_dma_mask() or pci_set_consistent_dma_mask() fails in p54p_probe(), it breaks off initialization, deallocates all resources, but returns zero. The patch implements proper

[PATCH v2] p54pci: don't return zero on failure paths in p54p_probe()

Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru Acked-by: Christian Lamparter chunk...@googlemail.com --- drivers/net/wireless/p54/p54pci.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/p54

[PATCH] staging: ced1401: fix GFP_KERNEL in spinlock context

Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/staging/ced1401/ced_ioc.c | 18 +- drivers/staging/ced1401/usb1401.c | 10 -- drivers/staging/ced1401/usb1401.h |2 +- 3 files changed, 14 insertions(+), 16 deletions

[PATCH] hostap: do not return positive number on failure path in prism2_open()

prism2_open() as an .ndo_open handler should not return positive numbers in case of failure, but it does return 1 in a couple of places. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshil...@ispras.ru --- drivers/net/wireless/hostap

Re: [PATCH] hostap: do not return positive number on failure path in prism2_open()

Please ignore this mail, there is a misprint in signed-off line. I will resend the patch. On 08/05/2013 07:02 AM, Alexey Khoroshilov wrote: prism2_open() as an .ndo_open handler should not return positive numbers in case of failure, but it does return 1 in a couple of places. Found by Linux

[PATCH] hostap: do not return positive number on failure path in prism2_open()

prism2_open() as an .ndo_open handler should not return positive numbers in case of failure, but it does return 1 in a couple of places. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/net/wireless/hostap

Re: [PATCH] hostap: do not return positive number on failure path in prism2_open()

On 08/05/2013 07:33 AM, Joe Perches wrote: On Mon, 2013-08-05 at 07:18 +0400, Alexey Khoroshilov wrote: prism2_open() as an .ndo_open handler should not return positive numbers in case of failure, but it does return 1 in a couple of places. Found by Linux Driver Verification project

[PATCH] [media] gspca: fix dev_open() error path

If v4l2_fh_open() fails in dev_open(), gspca_dev-module left locked. The patch adds module_put(gspca_dev-module) on this path. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/media/usb/gspca/gspca.c | 6 +- 1

Re: [PATCH] usb: gadget: mv_u3d_core: fix violation of locking discipline in mv_u3d_ep_disable()

Hi Felipe, On 07/25/2013 09:30 PM, Felipe Balbi wrote: On Wed, Jul 24, 2013 at 12:20:17AM +0400, Alexey Khoroshilov wrote: mv_u3d_nuke() expects to be calles with ep-u3d-lock held, because mv_u3d_done() does. But mv_u3d_ep_disable() calls it without lock that can lead to unpleasant

[PATCH] libceph: fix deadlock in ceph_build_auth()

() calling it. ceph_auth_build_hello() is left with untouched semantics as a wrapper around ceph_build_hello_auth_request(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- net/ceph/auth.c | 17 + 1 file changed, 13

Re: [PATCH] usb: gadget: mv_u3d_core: fix violation of locking discipline in mv_u3d_ep_disable()

On 07/29/2013 04:52 PM, Felipe Balbi wrote: Hi, On Fri, Jul 26, 2013 at 07:26:05PM +0400, Alexey Khoroshilov wrote: On 07/25/2013 09:30 PM, Felipe Balbi wrote: On Wed, Jul 24, 2013 at 12:20:17AM +0400, Alexey Khoroshilov wrote: mv_u3d_nuke() expects to be calles with ep-u3d-lock held

[PATCH] via-ircc: don't return zero if via_ircc_open() failed

Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/net/irda/via-ircc.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/irda/via-ircc.c b/drivers/net/irda/via-ircc.c index 51f2bc3..2dcc60f 100644

[PATCH] [media] dvb_demux: fix deadlock in dmx_section_feed_release_filter()

Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/media/dvb-core/dvb_demux.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/dvb-core/dvb_demux.c b/drivers/media/dvb-core/dvb_demux.c index

[PATCH] [media] dvb-usb: fix error handling in ttusb_dec_probe()

done with GFP_KERNEL; - refactors ttusb_dec_boot_dsp() in an equivalent way except for returning 0 instead of 1 if ttusb_dec_boot_dsp() succeed in (!mode) branch. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers

[PATCH] [media] go7007: fix return 0 for unsupported devices in go7007_usb_probe()

probe() should not return 0 for unsupported devices, but go7007_usb_probe() does. The patch fixes it to return -ENODEV. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/staging/media/go7007/go7007-usb.c | 4

[PATCH] can: usb_8dev: fix urb leak on failure path in usb_8dev_start()

If usb_8dev_start() fails to submit urb, it unanchors the urb but forgets to free it. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/net/can/usb/usb_8dev.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH] net/irda/mcs7780: fix memory leaks in mcs_net_open()

-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/net/irda/mcs7780.c | 40 +++- 1 file changed, 23 insertions(+), 17 deletions(-) diff --git a/drivers/net/irda/mcs7780.c b/drivers/net/irda/mcs7780.c index f07c340..3f138ca 100644 --- a/drivers/net/irda/mcs7780.c

[PATCH] usb: gadget: amd5536udc: unconditionally use GFP_ATOMIC in udc_queue()

As far as prep_dma() is called with spinlock held, we have to pass GFP_ATOMIC regardless of gfp argument. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/usb/gadget/amd5536udc.c | 4 ++-- 1 file changed, 2

[PATCH] libertas_usb: fix leak at failure path in if_usb_probe()

Error handling code in if_usb_probe() misses usb_put_dev(udev). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/net/wireless/libertas/if_usb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net

[PATCH] p54usb: fix leak at failure path in p54u_load_firmware()

If request_firmware_nowait() fails in p54u_load_firmware(), p54u_load_firmware_cb is not called and no one decrements usb_dev refcnt. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/net/wireless/p54/p54usb.c | 1

[PATCH] USB: wusbcore: fix usb_dev leaks

Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/usb/wusbcore/cbaf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/wusbcore/cbaf.c b/drivers/usb/wusbcore/cbaf.c index 7f78f30..4035004 100644 --- a/drivers/usb/wusbcore

[PATCH] jffs2: make jffs2_do_read_inode_internal() consistent regarding f-sem handling

Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- fs/jffs2/readinode.c | 46 ++ 1 file changed, 22 insertions(+), 24 deletions(-) diff --git a/fs/jffs2/readinode.c b/fs/jffs2/readinode.c index ae81b01e6fd7

[PATCH] cxusb: fix mismatch in mutex lock-unlock in cxusb_i2c_xfer()

There are several failure paths in cxusb_i2c_xfer(), where d-i2c_mutex is left held. The patch fixes them. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/media/usb/dvb-usb/cxusb.c | 19 --- 1

[PATCH] staging: gdm724x: fix leak at failure path in gdm_usb_probe()

by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/staging/gdm724x/gdm_usb.c | 40 +-- 1 file changed, 17 insertions(+), 23 deletions(-) diff --git a/drivers/staging/gdm724x/gdm_usb.c b

[PATCH] [media] adv7180: free an interrupt on failure paths in init_device()

There is request_irq() in init_device(), but the interrupt is not removed on failure paths. The patch adds proper error handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/media/i2c/adv7180.c | 18

[PATCH 1/3] staging: dgap: remove unneeded status variables

time. Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/staging/dgap/dgap_driver.c | 105 - 1 file changed, 46 insertions(+), 59 deletions(-) diff --git a/drivers/staging/dgap/dgap_driver.c b/drivers/staging/dgap/dgap_driver.c index

[PATCH 2/3] staging: dgap: implement proper error handling in dgap_start()

dgap_start() ignored errors in class_create() and device_create(). The patch implements proper error handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/staging/dgap/dgap_driver.c | 42

[PATCH 3/3] staging: dgap: fix error handling in dgap_init_module()

No need to call pci_unregister_driver() if pci_register_driver() failed. Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/staging/dgap/dgap_driver.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/staging/dgap/dgap_driver.c b/drivers

[PATCH] drm/vmwgfx: avoid null pointer dereference at failure paths

vmw_takedown_otable_base() and vmw_mob_unbind() check for potential vmw_fifo_reserve() failure and print error message, but then immediately dereference NULL pointer. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru

[PATCH] connector: remove duplicated code in cn_call_callback()

There were a couple of patches fixing the same bug that results in duplicated err = 0; assignment. The patch removes one of them. Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/connector/connector.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/connector

[PATCH 1/3] staging: dgap: remove unneeded status variables

time. Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/staging/dgap/dgap.c | 97 - 1 file changed, 42 insertions(+), 55 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index cbce457..5271856 100644

[PATCH 3/3] staging: dgap: fix error handling in dgap_init_module()

No need to call pci_unregister_driver() if pci_register_driver() failed. Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/staging/dgap/dgap.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap

[PATCH 2/3] staging: dgap: implement proper error handling in dgap_start()

dgap_start() ignored errors in class_create() and device_create(). The patch implements proper error handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/staging/dgap/dgap.c | 22 -- 1

[PATCH] p54usb: fix leaks at failure path in p54u_probe()

If p54u_load_firmware() fails, p54u_probe() does not deallocate already allocated resources. The patch adds proper failure handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/net/wireless/p54/p54usb.c | 4

[PATCH 2/2] staging: dgap: implement proper error handling in dgap_start()

dgap_start() ignored errors in class_create() and device_create(). The patch implements proper error handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/staging/dgap/dgap.c | 18 +- 1 file

[PATCH 1/2] staging: dgap: remove unneeded status variables

time. Also dgap_downld device was removed, while device_destroy(MKDEV(DIGI_DGAP_MAJOR, 1)) is still in dgap_cleanup_module(). The patch removes it by the way. Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/staging/dgap/dgap.c | 81

Re: [PATCH] p54usb: fix leaks at failure path in p54u_probe()

On 09.03.2014 02:44, Krishna Chaitanya wrote: On Sat, Mar 8, 2014 at 2:41 AM, Alexey Khoroshilov khoroshi...@ispras.ru wrote: If p54u_load_firmware() fails, p54u_probe() does not deallocate already allocated resources. The patch adds proper failure handling. Found by Linux Driver

[PATCH] staging: wlan-ng: fix leaks on failure paths in prism2sta_probe_usb()

. hfa384x_destroy() is just noop in init state. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/staging/wlan-ng/prism2usb.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wlan

[PATCH] NFC: pn533: Fix device leak

pn533_probe() calls usb_get_dev(), but there is no usb_put_dev() in pn533_disconnect(). The patch adds one. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/nfc/pn533.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH] [media] wl128x: do not call copy_to_user() while holding spinlocks

by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/media/radio/wl128x/fmdrv_common.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/drivers/media/radio/wl128x/fmdrv_common.c b

[PATCH] staging: ft1000: fix memory leak on error path in ft1000_probe()

by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/staging/ft1000/ft1000-usb/ft1000_usb.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_usb.c b

[PATCH] [media] ttusb-budget: fix memory leak in ttusb_probe()

If something goes wrong starting from i2c_add_adapter(), ttusb-iso_urb[] and ttusb itself are not deallocated. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c | 2 ++ 1

[PATCH] [media] usbvision-video: fix memory leak of alt_max_pkt_size

there. It calls usbvision_release() if allocation of usbvision-alt_max_pkt_size fails as soon as usbvision_release() is safe to work with incompletely initialized usbvision structure. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru

  1   2   3   4   5   6   7   8   9   >