This is a patch to the quatech_daqp_cs.c file that fixes by using
unsigned int instead of unsigned, following warning found by checkpatch.
* WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Signed-off-by: Amit Ghadge <amitg@gmail.com>
---
drivers/staging/comedi/d
before tabs
* please, no spaces at the start of a line
* line over 80 characters
ERROR :
* code indent should use tabs where possible
* space prohibited after that open parenthesis '('
Signed-off-by: Amit Ghadge <amitg@gmail.com>
---
Changes v2 :
- Added space between the "/
On Tue, May 17, 2016 at 02:01:52PM -0400, David Miller wrote:
>
> Whenever you have to make changes to a patch within a series, you must always
> resubmit the entire series, not just the one that need changes.
You want say submit patch with version series v1, v2 or patches series?
If that is
before tabs
* please, no spaces at the start of a line
* line over 80 characters
ERROR :
* code indent should use tabs where possible
* space prohibited after that open parenthesis '('
Signed-off-by: Amit Ghadge <amitg@gmail.com>
---
Changes v2 :
- Added space between the "/
op-posting.
> Q: What is the most annoying thing in e-mail?
>
> A: No.
> Q: Should I include quotations after my reply?
>
> http://daringfireball.net/2007/07/on_top
Thanks for this valuable information.
>
> On Tue, May 17, 2016 at 09:31:56AM +0530, Amit Ghadge wrote:
&
Fixed a warning issue to use 'unsigned int'.
Signed-off-by: Amit Ghadge <amitg@gmail.com>
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
b/drivers/staging/
ing message.
On Mon, May 16, 2016 at 11:19:05AM -0700, Greg KH wrote:
> On Mon, May 16, 2016 at 11:04:31PM +0530, Amit Ghadge wrote:
> > Fixed a warning issue to use 'unsigned int'.
> >
>
> build warning? I don't see that anywhere in the build output.
>
> Please be specific.
Hello Greg KH,
I make patch same like other, I'm new and I nerver see changelog in other
patches.
Where to add changelog? I followed you are tutorial.
Thanks,
Amit Ghadge
On Mon, May 16, 2016 at 08:34:55PM -0700, Greg KH wrote:
>
> A: No.
> Q: Should I include quotations after
before tabs
* WARNING: please, no spaces at the start of a line
* WARNING: line over 80 characters
* ERROR: space prohibited after that open parenthesis '('
Signed-off-by: Amit Ghadge <amitg@gmail.com>
---
drivers/net/Space.c | 21 ++---
1 file changed, 10 insertions(
Signed-off-by: Amit Ghadge <amitg@gmail.com>
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
index e9e4313..8
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
WARNING: Block comments use * on subsequent lines
Signed-off-by: Amit Ghadge <amitg@gmail.com>
---
drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +--
1 file changed, 26 insertions(
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
WARNING: Block comments use * on subsequent lines
Signed-off-by: Amit Ghadge <amitg@gmail.com>
---
drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +--
1 file changed, 26 insertions(
Fixes checkpatch warning:
WARNING: Block comments use * on subsequent lines
Replace (1<<7) by BIT(7) in the file ni_670x.c to get rid
of checkpatch.pl "CHECK" output "Prefer using the BIT macro".
Replace Avoid CamelCase range_0_20mA to range_0_20ma.
Signed-
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
WARNING: Block comments use * on subsequent lines
Signed-off-by: Amit Ghadge <amitg@gmail.com>
---
drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +--
1 file changed, 26 insertions(
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
WARNING: Block comments use * on subsequent lines
Signed-off-by: Amit Ghadge <amitg@gmail.com>
---
drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +--
1 file changed, 26 insertions(
ace CamelCase range_0_20mA to range_0_20ma.
Signed-off-by: Amit Ghadge <amitg@gmail.com>
---
drivers/staging/comedi/drivers/ni_670x.c | 66
drivers/staging/comedi/drivers/pcl726.c | 2 +-
2 files changed, 33 insertions(+), 35 deletions(-)
diff --git
On Mon, Sep 5, 2016 at 7:02 PM, Ian Abbott <abbo...@mev.co.uk> wrote:
> On 03/09/16 21:11, Amit Ghadge wrote:
>>
>> Fixes checkpatch warning:
>> WARNING: Block comments use * on subsequent lines
>>
>> Replace (1<<7) by BIT(7) in the file ni_670x.c
On Mon, Sep 5, 2016 at 6:45 PM, Ian Abbott <abbo...@mev.co.uk> wrote:
> On 03/09/16 21:11, Amit Ghadge wrote:
>>
>> This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
>>
>> WARNING: Block comments use * on subsequent lines
>>
>> Si
Fixes checkpatch warning in das08_cs.c file:
WARNING: Block comments use * on subsequent lines
Signed-off-by: Amit Ghadge <amitg@gmail.com>
---
drivers/staging/comedi/drivers/das08_cs.c | 70 +++
1 file changed, 35 insertions(+), 35 deletions(-)
diff
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
WARNING: Block comments use * on subsequent lines
Signed-off-by: Amit Ghadge <amitg@gmail.com>
---
drivers/staging/comedi/comedidev.h| 8 ++---
drivers/staging/comedi/drivers/ni_daq_dio24.
; help improve the system]
> [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for
> convenience) to record what (public, well-known) commit your patch series was
> built on]
> [Check https://git-scm.com/docs/git-format-patch for more information]
>
> url:
>
On Sun, Sep 4, 2016 at 2:30 PM, Amit Ghadge <amitg@gmail.com> wrote:
> This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
>
> WARNING: Block comments use * on subsequent lines
>
> Signed-off-by: Amit Ghadge <amitg@gmail.com>
> ---
> d
On Sun, Sep 4, 2016 at 3:12 PM, Giedrius Statkevičius
<giedrius.statkevic...@gmail.com> wrote:
> On Sun, Sep 4, 2016 at 12:08 PM, Amit Ghadge <amitg@gmail.com> wrote:
>> This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
>> WARNING: Block comment
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
WARNING: Block comments use * on subsequent lines
Signed-off-by: Amit Ghadge <amitg@gmail.com>
---
drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +--
1 file changed, 26 insertions(
I will be send individual patches.
I was try,
make M=drivers/staging/comedi/
No issue generated, Is there have any other option to test these changes?
Amit G
On Sun, Sep 4, 2016 at 2:05 PM, Greg KH <gre...@linuxfoundation.org> wrote:
> On Sun, Sep 04, 2016 at 01:41:03AM +0530, Am
Clean some all functions to return NULL on failure.
Used !x instead of x==NULL.
Signed-off-by: Amit Ghadge <amitg@gmail.com>
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/s
Some functions return NULL on failure, used !x instead of x==NULL.
Signed-off-by: Amit Ghadge <amitg@gmail.com>
---
drivers/usb/storage/alauda.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/storage/alauda.c b/drivers/usb/storage/al
Some functions return NULL on failure, used !x instead of x==NULL.
Signed-off-by: Amit Ghadge <amitg@gmail.com>
---
drivers/usb/atm/cxacru.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/atm/cxacru.c b/drivers/usb/atm/cxacru.c
index 0
On Mon, Sep 5, 2016 at 6:45 PM, Ian Abbott wrote:
> On 03/09/16 21:11, Amit Ghadge wrote:
>>
>> This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
>>
>> WARNING: Block comments use * on subsequent lines
>>
>> Signed-off-by: Amit Ghadge
&g
On Mon, Sep 5, 2016 at 7:02 PM, Ian Abbott wrote:
> On 03/09/16 21:11, Amit Ghadge wrote:
>>
>> Fixes checkpatch warning:
>> WARNING: Block comments use * on subsequent lines
>>
>> Replace (1<<7) by BIT(7) in the file ni_670x.c to get rid
>> of check
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
WARNING: Block comments use * on subsequent lines
Signed-off-by: Amit Ghadge
---
drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +--
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
WARNING: Block comments use * on subsequent lines
Signed-off-by: Amit Ghadge
---
drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +--
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git
Fixes checkpatch warning:
WARNING: Block comments use * on subsequent lines
Replace (1<<7) by BIT(7) in the file ni_670x.c to get rid
of checkpatch.pl "CHECK" output "Prefer using the BIT macro".
Replace Avoid CamelCase range_0_20mA to range_0_20ma.
Signed-off-by:
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
WARNING: Block comments use * on subsequent lines
Signed-off-by: Amit Ghadge
---
drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +--
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git
ace CamelCase range_0_20mA to range_0_20ma.
Signed-off-by: Amit Ghadge
---
drivers/staging/comedi/drivers/ni_670x.c | 66
drivers/staging/comedi/drivers/pcl726.c | 2 +-
2 files changed, 33 insertions(+), 35 deletions(-)
diff --git a/drivers/staging/comedi/dr
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
WARNING: Block comments use * on subsequent lines
Signed-off-by: Amit Ghadge
---
drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +--
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
WARNING: Block comments use * on subsequent lines
Signed-off-by: Amit Ghadge
---
drivers/staging/comedi/comedidev.h| 8 ++---
drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +--
2
On Sun, Sep 4, 2016 at 2:30 PM, Amit Ghadge wrote:
> This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
>
> WARNING: Block comments use * on subsequent lines
>
> Signed-off-by: Amit Ghadge
> ---
> drivers/staging/comedi/comedidev.h| 8 ++-
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
WARNING: Block comments use * on subsequent lines
Signed-off-by: Amit Ghadge
---
drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +--
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git
On Sun, Sep 4, 2016 at 3:12 PM, Giedrius Statkevičius
wrote:
> On Sun, Sep 4, 2016 at 12:08 PM, Amit Ghadge wrote:
>> This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
>> WARNING: Block comments use * on subsequent lines
>>
>> Signed-off-by: Amit Gha
I will be send individual patches.
I was try,
make M=drivers/staging/comedi/
No issue generated, Is there have any other option to test these changes?
Amit G
On Sun, Sep 4, 2016 at 2:05 PM, Greg KH wrote:
> On Sun, Sep 04, 2016 at 01:41:03AM +0530, Amit Ghadge wrote:
>> Fixes c
]
> [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for
> convenience) to record what (public, well-known) commit your patch series was
> built on]
> [Check https://git-scm.com/docs/git-format-patch for more information]
>
> url:
> https://gith
Fixes checkpatch warning in das08_cs.c file:
WARNING: Block comments use * on subsequent lines
Signed-off-by: Amit Ghadge
---
drivers/staging/comedi/drivers/das08_cs.c | 70 +++
1 file changed, 35 insertions(+), 35 deletions(-)
diff --git a/drivers/staging/comedi
Clean some all functions to return NULL on failure.
Used !x instead of x==NULL.
Signed-off-by: Amit Ghadge
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep
Some functions return NULL on failure, used !x instead of x==NULL.
Signed-off-by: Amit Ghadge
---
drivers/usb/atm/cxacru.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/atm/cxacru.c b/drivers/usb/atm/cxacru.c
index 0a866e9..95a4737 100644
Some functions return NULL on failure, used !x instead of x==NULL.
Signed-off-by: Amit Ghadge
---
drivers/usb/storage/alauda.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/storage/alauda.c b/drivers/usb/storage/alauda.c
index 1d8b03c..8f25bc8
Signed-off-by: Amit Ghadge
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
index e9e4313..802f51e 100644
--- a/drivers
Fixed a warning issue to use 'unsigned int'.
Signed-off-by: Amit Ghadge
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
before tabs
* WARNING: please, no spaces at the start of a line
* WARNING: line over 80 characters
* ERROR: space prohibited after that open parenthesis '('
Signed-off-by: Amit Ghadge
---
drivers/net/Space.c | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git
ing message.
On Mon, May 16, 2016 at 11:19:05AM -0700, Greg KH wrote:
> On Mon, May 16, 2016 at 11:04:31PM +0530, Amit Ghadge wrote:
> > Fixed a warning issue to use 'unsigned int'.
> >
>
> build warning? I don't see that anywhere in the build output.
>
> Please be specific.
Hello Greg KH,
I make patch same like other, I'm new and I nerver see changelog in other
patches.
Where to add changelog? I followed you are tutorial.
Thanks,
Amit Ghadge
On Mon, May 16, 2016 at 08:34:55PM -0700, Greg KH wrote:
>
> A: No.
> Q: Should I include quotations after
This is a patch to the quatech_daqp_cs.c file that fixes by using
unsigned int instead of unsigned, following warning found by checkpatch.
* WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Signed-off-by: Amit Ghadge
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
1 file
before tabs
* please, no spaces at the start of a line
* line over 80 characters
ERROR :
* code indent should use tabs where possible
* space prohibited after that open parenthesis '('
Signed-off-by: Amit Ghadge
---
Changes v2 :
- Added space between the "/*" and "ISA&quo
On Tue, May 17, 2016 at 02:01:52PM -0400, David Miller wrote:
>
> Whenever you have to make changes to a patch within a series, you must always
> resubmit the entire series, not just the one that need changes.
You want say submit patch with version series v1, v2 or patches series?
If that is
before tabs
* please, no spaces at the start of a line
* line over 80 characters
ERROR :
* code indent should use tabs where possible
* space prohibited after that open parenthesis '('
Signed-off-by: Amit Ghadge
---
Changes v2 :
- Added space between the "/*" and "ISA&quo
op-posting.
> Q: What is the most annoying thing in e-mail?
>
> A: No.
> Q: Should I include quotations after my reply?
>
> http://daringfireball.net/2007/07/on_top
Thanks for this valuable information.
>
> On Tue, May 17, 2016 at 09:31:56AM +0530, Amit Ghadge wrote:
&
56 matches
Mail list logo
