[PATCH 0/8 v2] acpi-cpufreq: Move modern AMD cpufreq support to acpi-cpufreq

2012-09-04 Thread Andre Przywara
Hi, now the second, revised version of the patch set. I now tested loading both drivers after each other in several combinations, after two bug fixes this now works as expected. I added a patch to move messages from powernow-k8 after the initialization phase, so it remains silent if driver loading

[PATCH 5/8 v2] ACPI: Add fixups for AMD P-state figures

2012-09-04 Thread Andre Przywara
From: Matthew Garrett Some AMD systems may round the frequencies in ACPI tables to 100MHz boundaries. We can obtain the real frequencies from MSRs, so add a quirk to fix these frequencies up on AMD systems. Signed-off-by: Matthew Garrett Signed-off-by: Andre Przywara --- arch/x86/include/asm

[PATCH 3/8 v2] cpufreq: Add warning message to powernow-k8

2012-09-04 Thread Andre Przywara
cpufreq modules are often loaded from init scripts that assume that all recent AMD systems will use powernow-k8. To inform the user of the change of support and ease the transition to acpi-cpufreq, emit a warning message. Signed-off-by: Andre Przywara --- drivers/cpufreq/Kconfig.x86 | 3

[PATCH 2/8 v2] acpi-cpufreq: Add quirk to disable _PSD usage on all AMD CPUs

2012-09-04 Thread Andre Przywara
. Signed-off-by: Andre Przywara --- drivers/cpufreq/acpi-cpufreq.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c index 067a61f..70e7173 100644 --- a/drivers/cpufreq/acpi-cpufreq.c +++ b/drivers/cpufreq/acpi-cpufreq.c

[PATCH 8/8 v2] cpufreq: Remove support for hardware P-state chips from powernow-k8

2012-09-04 Thread Andre Przywara
cpufreq support after the transition. Signed-off-by: Matthew Garrett Signed-off-by: Andre Przywara --- drivers/cpufreq/Makefile | 2 +- drivers/cpufreq/powernow-k8.c | 392 +++--- drivers/cpufreq/powernow-k8.h | 32 3 files changed, 29 insertions

[PATCH 7/8 v2] acpi-cpufreq: Add compatibility for legacy AMD cpb sysfs knob

2012-09-04 Thread Andre Przywara
fig switch I'd like to consider this feature obsolete. Lets keep it around for some kernel versions and then phase it out. Signed-off-by: Andre Przywara --- drivers/cpufreq/Kconfig.x86| 12 +++ drivers/cpufreq/acpi-cpufreq.c | 46 -- 2 fi

[PATCH 6/8 v2] acpi-cpufreq: Add support for disabling dynamic overclocking

2012-09-04 Thread Andre Przywara
tionale and the usage. A following patch will re-introduce the cpb knob for compatibility reasons on AMD CPUs. Per-CPU boost switching is possible, but not trivial and is thus postponed to a later patch series. Signed-off-by: Andre Przywara --- Documentation/ABI/testing/sysfs-devices-system-cpu | 11 +

[PATCH 1/8 v2] acpi-cpufreq: Add support for modern AMD CPUs

2012-09-04 Thread Andre Przywara
control to acpi-cpufreq. Signed-off-by: Matthew Garrett Signed-off-by: Andre Przywara --- arch/x86/include/asm/msr-index.h | 2 ++ drivers/cpufreq/Kconfig.x86 | 3 ++- drivers/cpufreq/acpi-cpufreq.c | 43 ++-- 3 files changed, 41 insertions(+), 7 deletions

[PATCH 4/8 v2] powernow-k8: delay info messages until initialization has succeeded

2012-09-04 Thread Andre Przywara
not succeed. Signed-off-by: Andre Przywara --- drivers/cpufreq/powernow-k8.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c index 16c7fb6..8ff0621 100644 --- a/drivers/cpufreq/powernow-k8

[PATCH] x86/amd: disable way access filter on affected CPUs

2012-10-24 Thread Andre Przywara
The WAF may hurt the performance of some workloads, caused by aliasing issues in the L1 cache. Disable it on the affected CPUs. Signed-off-by: Andre Przywara --- arch/x86/kernel/cpu/amd.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86

Re: [PATCH] x86/amd: disable way access filter on affected CPUs

2012-10-24 Thread Andre Przywara
On 10/24/2012 12:46 PM, Ingo Molnar wrote: * Andre Przywara wrote: The WAF may hurt the performance of some workloads, caused by aliasing issues in the L1 cache. Disable it on the affected CPUs. Signed-off-by: Andre Przywara --- arch/x86/kernel/cpu/amd.c | 14 ++ 1 file

Changed email address

2012-10-31 Thread Andre Przywara
Hi guys, in case there are any inquiries regarding code of mine (e.g. triggered by git annotate or commit messages), feel free to contact me via my private address: o...@andrep.de My AMD email address is no longer valid. Regards, André Przywara -- To unsubscribe from this list: send the line "u

[PATCH] x86/amd: disable way access filter on affected CPUs

2012-10-31 Thread Andre Przywara
From: Andre Przywara The Way Access Filter in recent AMD CPUs may hurt the performance of some workloads, caused by aliasing issues in the L1 cache. This patch disables it on the affected CPUs. The issue is similar to that one of last year: http://lkml.indiana.edu/hypermail/linux/kernel/1107.3

[PATCH 0/8] acpi-cpufreq: Move modern AMD cpufreq support to acpi-cpufreq

2012-07-26 Thread Andre Przywara
been mostly reworked and documentation for it has been added. Also there was a need for (yet another) BIOS quirk on AMD desktop boards. Signed-off-by: Andre Przywara -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.

[PATCH 2/8] acpi-cpufreq: Add quirk to disable _PSD usage on all AMD CPUs

2012-07-26 Thread Andre Przywara
. Signed-off-by: Andre Przywara --- drivers/cpufreq/acpi-cpufreq.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c index 067a61f..ea949b8 100644 --- a/drivers/cpufreq/acpi-cpufreq.c +++ b/drivers/cpufreq

[PATCH 4/8] ACPI: Add fixups for AMD P-state figures

2012-07-26 Thread Andre Przywara
From: Matthew Garrett Some AMD systems may round the frequencies in ACPI tables to 100MHz boundaries. We can obtain the real frequencies from MSRs, so add a quirk to fix these frequencies up on AMD systems. Signed-off-by: Matthew Garrett Signed-off-by: Andre Przywara --- arch/x86/include/asm

[PATCH 3/8] cpufreq: Add compatibility hack to powernow-k8

2012-07-26 Thread Andre Przywara
cpufreq support after the transition. Signed-off-by: Matthew Garrett Signed-off-by: Andre Przywara --- drivers/cpufreq/powernow-k8.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c index c0e8164..6e35ed2

[PATCH 5/8] acpi-cpufreq: Add support for disabling dynamic overclocking

2012-07-26 Thread Andre Przywara
will re-introduce the cpb knob for compatibility reasons on AMD CPUs. Per-CPU boost switching is possible, but not trivial and is thus postponed to a later patch series. Signed-off-by: Andre Przywara --- drivers/cpufreq/acpi-cpufreq.c | 177 1 files chan

[PATCH 1/8] acpi-cpufreq: Add support for modern AMD CPUs

2012-07-26 Thread Andre Przywara
control to acpi-cpufreq. Signed-off-by: Matthew Garrett Signed-off-by: Andre Przywara --- arch/x86/include/asm/msr-index.h |2 + drivers/cpufreq/acpi-cpufreq.c | 43 - 2 files changed, 39 insertions(+), 6 deletions(-) diff --git a/arch/x86/include/asm/msr

[PATCH 8/8] Documentation: Add documentation for boost control switch

2012-07-26 Thread Andre Przywara
The new acpi-cpufreq driver supports a system global control switch to disable the frequency boosting feature of some (x86) CPUs. Provide documentation about the rationale and the usage. Signed-off-by: Andre Przywara --- Documentation/ABI/testing/sysfs-devices-system-cpu | 12

[PATCH 7/8] cpufreq: Remove support for hardware P-state chips from powernow-k8

2012-07-26 Thread Andre Przywara
From: Matthew Garrett These chips are now supported by acpi-cpufreq, so we can delete all the code handling them. Signed-off-by: Matthew Garrett Signed-off-by: Andre Przywara --- drivers/cpufreq/Makefile |2 +- drivers/cpufreq/powernow-k8.c | 385

[PATCH 6/8] acpi-cpufreq: Add compatibility for legacy AMD cpb sysfs knob

2012-07-26 Thread Andre Przywara
fig switch I'd like to consider this feature obsolete. Lets keep it around for some kernel versions and then phase it out. Signed-off-by: Andre Przywara --- drivers/cpufreq/Kconfig.x86| 12 ++ drivers/cpufreq/acpi-cpufreq.c | 46 ++- 2 fi

Re: [PATCH 0/8 v2] acpi-cpufreq: Move modern AMD cpufreq support to acpi-cpufreq

2012-09-05 Thread Andre Przywara
On 09/05/2012 04:25 PM, Thomas Renninger wrote: On Wednesday, September 05, 2012 03:46:22 PM Rafael J. Wysocki wrote: On Tuesday, September 04, 2012, Andre Przywara wrote: Hi, I have applied the whole series to the linux-next branch of the linux-pm.git Thanks! tree, but I'm quite u

Re: linux-next: Tree for Sept 6 (does not boot on AMD64)

2012-09-06 Thread Andre Przywara
ufreq. So a dependency on the old driver does not help. Are there still any problems with this patchset? Or are you only wondering about the new config switch? Thanks for testing! Andre. -- Andre Przywara AMD-Operating System Research Center (OSRC), Dresden, Germany -- To unsubscribe

[PATCH] x86/perf: Fix virtualization sanity check

2012-10-09 Thread Andre Przywara
] ---[ end trace a7919e7f17c0a725 ]--- The new code will change every of the 16 low bits read from the register and tries to write and read-back that modified number from the MSR. Signed-off-by: Andre Przywara --- arch/x86/kernel/cpu/perf_event.c | 10 ++ 1 file changed, 6 insertions(+), 4

[PATCH] x86/perf: Fix virtualization sanity check

2012-10-09 Thread Andre Przywara
] ---[ end trace a7919e7f17c0a725 ]--- The new code will change every of the 16 low bits read from the register and tries to write and read-back that modified number from the MSR. Signed-off-by: Andre Przywara --- arch/x86/kernel/cpu/perf_event.c | 10 ++ 1 file changed, 6 insertions(+), 4

Re: [PATCH] x86/perf: Fix virtualization sanity check

2012-10-09 Thread Andre Przywara
On 10/09/2012 05:51 PM, Konrad Rzeszutek Wilk wrote: On Tue, Oct 09, 2012 at 05:38:34PM +0200, Andre Przywara wrote: In check_hw_exists() we try to detect non-emulated MSR accesses by writing an arbitrary value into one of the PMU registers and check if it's value after a readout is stil

Re: [PATCH 7/8] cpufreq: Remove support for hardware P-state chips from powernow-k8

2012-08-22 Thread Andre Przywara
On 08/22/2012 03:00 AM, Thomas Renninger wrote: On Monday 20 August 2012 22:49:16 Rafael J. Wysocki wrote: On Monday, August 20, 2012, Andre Przywara wrote: On 08/05/2012 11:33 PM, Rafael J. Wysocki wrote: On Thursday, July 26, 2012, Andre Przywara wrote: ... If you insist, I can keep the

Re: [PATCH 2/8 v2] acpi-cpufreq: Add quirk to disable _PSD usage on all AMD CPUs

2012-09-17 Thread Andre Przywara
On 09/15/2012 01:20 PM, Konrad Rzeszutek Wilk wrote: On Sep 4, 2012 4:26 AM, "Andre Przywara" mailto:andre.przyw...@amd.com>> wrote: > > To workaround some Windows specific behavior, the ACPI _PSD table > on AMD desktop boards advertises all cores as dependent, mea

Re: [PATCH 2/2] cpu: intel, amd: mask cleared cpuid features

2012-07-24 Thread Andre Przywara
base)? Remember, this is Linux: If you want to shoot yourself in the foot, we will not prevent you. Regards, Andre. -- Andre Przywara AMD-Operating System Research Center (OSRC), Dresden, Germany -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in th

Re: [PATCH 2/2] cpu: intel, amd: mask cleared cpuid features

2012-07-24 Thread Andre Przywara
to make this bullet-proof, preferably through the container functionality. I see that you do already massive sysfs filtering and also /proc/ filtering, so this maybe an option? This approach does not need any kernel support (except for the /proc/cpuinfo filtering). Does this address the issues you hav

Re: [PATCH 2/2] cpu: intel, amd: mask cleared cpuid features

2012-07-25 Thread Andre Przywara
write the same reply yesterday, but followed the hint in Alan's previous mail: # mount --bind /dev/shm/faked_cpuinfo /somepath/proc/cpuinfo I checked it, it works even with chroots and is not visible from within. Regards, Andre. -- Andre Przywara AMD-Operating System Research Center

Re: [PATCH 2/2] cpu: intel, amd: mask cleared cpuid features

2012-07-25 Thread Andre Przywara
On 07/25/2012 01:02 PM, Vladimir Davydov wrote: On 07/25/2012 02:58 PM, Andre Przywara wrote: On 07/25/2012 12:31 PM, Vladimir Davydov wrote: On 07/24/2012 04:44 PM, Alan Cox wrote: This approach does not need any kernel support (except for the /proc/cpuinfo filtering). Does this address the

Re: [PATCH 7/8] cpufreq: Remove support for hardware P-state chips from powernow-k8

2012-08-20 Thread Andre Przywara
On 08/05/2012 11:33 PM, Rafael J. Wysocki wrote: On Thursday, July 26, 2012, Andre Przywara wrote: From: Matthew Garrett These chips are now supported by acpi-cpufreq, so we can delete all the code handling them. Signed-off-by: Matthew Garrett Signed-off-by: Andre Przywara Would it be

Re: [PATCH v2 1/5] ethernet: add sun8i-emac driver

2016-07-29 Thread Andre Przywara
Hi, On 25/07/16 20:54, Maxime Ripard wrote: > On Wed, Jul 20, 2016 at 10:03:16AM +0200, LABBE Corentin wrote: >> This patch add support for sun8i-emac ethernet MAC hardware. >> It could be found in Allwinner H3/A83T/A64 SoCs. >> >> It supports 10/100/1000 Mbit/s speed with half/full duplex. >> It

Re: [PATCH 00/13] arm64: Allwinner A64 support based on sunxi-ng

2016-08-01 Thread Andre Przywara
Hi Jean-Francois, On 01/08/16 09:30, Jean-Francois Moine wrote: > On Mon, 1 Aug 2016 02:43:06 +0100 > André Przywara wrote: > >> As this became quite a long read, here a TL;DR: >> - We consider using an SCPI based clock system for the A64, alongside >> allwinner,simple-gates and fixed clocks. We

Re: SBSA UART bug report and questions

2016-08-01 Thread Andre Przywara
Hi Drew, (CC:ing Dave) On 01/08/16 13:50, Andrew Jones wrote: > > Hi Andre, > > I have a couple questions and a bug report regarding the SBSA UART. > > When AArch64 Linux is boot with QEMU and UEFI (AAVMF) we can enable > the use of ACPI. When we do that the PL011 model QEMU provides is > expo

Re: [PATCH v3 2/9] arm64: Use consistent naming for errata handling

2016-09-07 Thread Andre Przywara
s instead of _errata. Yes, this makes sense. Acked-by: Andre Przywara Thanks! Andre. > Cc: Mark Rutland > Cc: Andre Przywara > Cc: Catalin Marinas > Signed-off-by: Suzuki K Poulose > --- > arch/arm64/include/asm/cpufeature.h | 4 ++-- > arch/arm64/kernel/cpu_errata

Re: [PATCH v3 8/9] arm64: Refactor sysinstr exception handling

2016-09-07 Thread Andre Przywara
che maintenance instructions trapping still works as expected. Acked-by: Andre Przywara Cheers, Andre. > > Cc: Andre Przywara > Cc: Mark Rutland > Cc: Will Deacon > Cc: Catalin Marinas > Signed-off-by: Suzuki K Poulose > ---

Re: [PATCH 12/13] arm64: dts: add Allwinner A64 SoC .dtsi

2016-09-08 Thread Andre Przywara
Hi Maxime, On 26/07/16 21:30, Maxime Ripard wrote: > From: Andre Przywara > > The Allwinner A64 SoC is a low-cost chip with 4 ARM Cortex-A53 cores > and the typical tablet / TV box peripherals. > The SoC is based on the (32-bit) Allwinner H3 chip, sharing most of > the p

[PATCH v4 2/7] DT: clk: sunxi: add binding doc for the multi-bus-gates clock

2016-08-08 Thread Andre Przywara
each parent clock used. This allows to specify any kind of relation efficiently and also keeps the very same kernel driver for all SoCs at the same time. Signed-off-by: Andre Przywara Acked-by: Rob Herring --- Documentation/devicetree/bindings/clock/sunxi.txt | 7 +++ 1 file changed, 7

[PATCH v4 0/7] arm64: Allwinner A64 support

2016-08-08 Thread Andre Przywara
DT node - use fixed-clocks for basic PLL clocks - use clock names based on manual (periph0 & friends) - move clocks out of their own subnode into a separate file - add .dts for BananaPi-M64 (thanks to Nora Lee for a sample board) Andre Przywara (7): arm64: sunxi: Kconfig: add essential pinctrl

[PATCH v4 4/7] of: add vendor prefix for Pine64

2016-08-08 Thread Andre Przywara
Signed-off-by: Andre Przywara Acked-by: Rob Herring --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index 1992aa9..492f92c

[PATCH v4 5/7] arm64: dts: add Allwinner A64 SoC .dtsi

2016-08-08 Thread Andre Przywara
4GB (including all the supported DRAM), so we use 32-bit address and size cells. This has the nice feature of us being able to reuse the DT for 32-bit kernels as well. This .dtsi lists the hardware that we support so far. Signed-off-by: Andre Przywara --- Hi, I dropped Rob's previous AC

[PATCH v4 7/7] arm64: dts: add BananaPi M64 support

2016-08-08 Thread Andre Przywara
The BananaPi M64 is a single board computer with an Allwinner A64 SoC. In addition to the usual suspects it contains Gigabit Ethernet, 2GB RAM, an eMMC and a WiFi chip (which are not yet supported by this patch). Signed-off-by: Andre Przywara --- arch/arm64/boot/dts/allwinner/Makefile

[PATCH v4 3/7] clk: sunxi: add generic multi-parent bus clock gates driver

2016-08-08 Thread Andre Przywara
adding a new driver or function for every new SoC. Signed-off-by: Andre Przywara Acked-by: Jean-Francois Moine --- drivers/clk/sunxi/Makefile | 1 + drivers/clk/sunxi/clk-multi-gates.c | 105 2 files changed, 106 insertions(+) create mode 100644

[PATCH v4 1/7] arm64: sunxi: Kconfig: add essential pinctrl driver

2016-08-08 Thread Andre Przywara
in the original pinctrl driver patch, but got removed to avoid the dependency on the Kconfig patch [1]. Also add the general PINCTRL symbol, which isn't selected automatically for the same reason. Reported-by: Jeroen Dekien Signed-off-by: Andre Przywara [1]: http://lists.infradead.org/piperm

[PATCH v4 6/7] arm64: dts: add Pine64 support

2016-08-08 Thread Andre Przywara
n DTSI and include directly the pine64 DTS] Signed-off-by: Andre Przywara --- arch/arm64/boot/dts/Makefile | 1 + arch/arm64/boot/dts/allwinner/Makefile | 5 ++ .../boot/dts/allwinner/sun50i-a64-pine64-plus.dts | 48 ++ .../arm64/boot/dts/allwinner/

Re: [PATCH v3 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967

2017-08-16 Thread Andre Przywara
Hi Philipp, sorry for the delay, I was on holidays. Thanks for putting together the series, this looks very good to me. One comment below... On 16/08/17 10:46, Philipp Zabel wrote: > Split reusable parts out of the sunxi driver, to add a driver for simple > reset controllers with reset lines tha

Re: [PATCH v3 3/5] reset: stm32: use the reset-simple driver

2017-08-16 Thread Andre Przywara
Hi, On 16/08/17 13:52, Eugeniy Paltsev wrote: > Hi Philipp, > > On Wed, 2017-08-16 at 11:46 +0200, Philipp Zabel wrote: >> The reset-simple driver can be used without changes. >> >> Signed-off-by: Philipp Zabel >> [snip] >> >> --- a/drivers/reset/reset-simple.c >> +++ b/drivers/reset/reset-simpl

Re: [PATCH v3 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967

2017-08-16 Thread Andre Przywara
Hi, On 16/08/17 16:11, Philipp Zabel wrote: > On Wed, 2017-08-16 at 14:12 +0200, Andreas Färber wrote: >> Hi Andre, >> >> Am 16.08.2017 um 13:30 schrieb Andre Przywara: >>> On 16/08/17 10:46, Philipp Zabel wrote: >>>> +/** >>>> + * struct res

Re: [PATCH v3 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967

2017-08-16 Thread Andre Przywara
Hi, On 16/08/17 17:41, Andreas Färber wrote: > Am 16.08.2017 um 17:11 schrieb Philipp Zabel: >> On Wed, 2017-08-16 at 14:12 +0200, Andreas Färber wrote: >>> Am 16.08.2017 um 13:30 schrieb Andre Przywara: >>>> On 16/08/17 10:46, Philipp Zabel wrote: >>>>&g

Re: [PATCH v3 3/5] reset: stm32: use the reset-simple driver

2017-08-17 Thread Andre Przywara
Hi, On 16/08/17 21:55, Alexandru Gagniuc wrote: > > > On 08/16/2017 01:52 PM, Andreas Färber wrote: >> Am 16.08.2017 um 22:50 schrieb Alexandru Gagniuc: >>> On 08/16/2017 02:46 AM, Philipp Zabel wrote: The reset-simple driver can be used without changes. Signed-off-by: Philipp Zab

Re: [PATCH v2 0/3] mailbox: arm: introduce smc triggered mailbox

2017-08-17 Thread Andre Przywara
Hi, (sorry for the delay, cleaning up my inbox after holidays) On 01/08/17 11:50, Alexander Graf wrote: > Hi Andre, > > On 24.07.17 01:23, Andre Przywara wrote: >> This is a reworked version of my previous post. It addresses Jassi's >> comments on the driver and als

Re: [linux-sunxi] [PATCH 1/3] arm64: allwinner: a64: Add initial Orangepi Win/WinPlus support

2017-05-26 Thread Andre Przywara
Hi, On 26/05/17 04:54, Chen-Yu Tsai wrote: > On Fri, May 26, 2017 at 6:30 AM, André Przywara > wrote: >> On 25/05/17 20:26, Jagan Teki wrote: >>> From: Jagan Teki >>> >>> Orangepi Win/WinPlus is an open-source single-board computer >>> using the Allwinner A64 SOC. >>> >>> A64 Orangepi Win/WinPl

Re: [PATCH v4 3/5] reset: socfpga: use the reset-simple driver

2017-10-18 Thread Andre Przywara
Hi, On 17/10/17 14:03, Philipp Zabel wrote: > Add reset line status readback, inverted status support, and socfpga > device tree quirks to the simple reset driver, and use it to replace > the socfpga driver. > > Signed-off-by: Philipp Zabel > --- > Changes since v3: > - Rebased onto reset/next

Re: [PATCH v4 3/5] reset: socfpga: use the reset-simple driver

2017-10-18 Thread Andre Przywara
Hi, On 18/10/17 14:50, Philipp Zabel wrote: > On Wed, 2017-10-18 at 14:00 +0100, Andre Przywara wrote: >> Hi, > > Thank you for the review. > >> On 17/10/17 14:03, Philipp Zabel wrote: >>> Add reset line status readback, inverted status support, and socfpga >

[PATCH] serial: atmel: fix compiler warning on address cast

2015-10-05 Thread Andre Przywara
ize [-Wint-to-pointer-cast] if ((void *)port->mapbase != ser->iomem_base) ^ Fix that by using the cast on the right hand side instead, as similar code already does in other drivers. Signed-off-by: Andre Przywara --- drivers/tty/serial/atmel_serial.c | 2 +- 1 file changed, 1 insertio

[PATCH 2/4] arm64: dts: Foundation model: increate GICC region to allow EOImode=1

2015-10-13 Thread Andre Przywara
Recent commits made the GIC driver use EOImode=1 for all GICs that advertise the proper GICC region size. To let the model benefit from the blessings of that mode, increase the GICC region to its actual size of 8K. Signed-off-by: Andre Przywara --- arch/arm64/boot/dts/arm/foundation-v8.dts | 2

[PATCH 3/4] arm64: dts: split Foundation model dts to put the GIC separately

2015-10-13 Thread Andre Przywara
.dts. Signed-off-by: Andre Przywara --- arch/arm64/boot/dts/arm/foundation-v8.dts | 223 + .../arm/{foundation-v8.dts => foundation-v8.dtsi} | 12 -- 2 files changed, 2 insertions(+), 233 deletions(-) copy arch/arm64/boot/dts/arm/{foundation-v8.dts => foundat

[PATCH 4/4] arm64: dts: add .dts for GICv3 Foundation model

2015-10-13 Thread Andre Przywara
Foundation model to run with a GICv3. Signed-off-by: Andre Przywara --- arch/arm64/boot/dts/arm/Makefile| 2 +- arch/arm64/boot/dts/arm/foundation-v8-gicv3.dts | 30 + 2 files changed, 31 insertions(+), 1 deletion(-) create mode 100644 arch/arm64/boot

[PATCH 0/4] add support for GICv3 on the Foundation model

2015-10-13 Thread Andre Przywara
/foundation-model.php Andre Przywara (4): arm64: dts: prepare foundation-v8.dts to cope with GICv3 arm64: dts: Foundation model: increate GICC region to allow EOImode=1 arm64: dts: split Foundation model dts to put the GIC separately arm64: dts: add .dts for GICv3 Foundation model arch/arm64

[PATCH 1/4] arm64: dts: prepare foundation-v8.dts to cope with GICv3

2015-10-13 Thread Andre Przywara
To prepare the ARM foundation model to support GICv3, we adjust the #address-cells property of the current GICv2 node to be compatible with the two cells required for GICv3 later. Signed-off-by: Andre Przywara --- arch/arm64/boot/dts/arm/foundation-v8.dts | 88 +++ 1

Re: [PATCH 4/4] arm64: dts: add .dts for GICv3 Foundation model

2015-10-13 Thread Andre Przywara
Hi Marc, On 13/10/15 11:44, Marc Zyngier wrote: > On 13/10/15 10:37, Andre Przywara wrote: >> The ARMv8 Foundation model sports a command line parameter to use >> a GICv3 emulation instead of the default GICv2 interrupt controller. >> Add a new .dts file which reuses most

Re: [PATCH] EDAC: Add AMD Seattle SoC EDAC

2015-10-21 Thread Andre Przywara
Hi, On 21/10/15 10:35, Borislav Petkov wrote: > On Wed, Oct 21, 2015 at 09:55:43AM +0800, Hanjun Guo wrote: >> So I think the meaning of those error register is the same, but the way >> of handle it may different from SoCs, for single bit error: >> >> - SoC may trigger a interrupt; >> - SoC may

Re: [PATCH v2] EDAC: Add ARM64 EDAC

2015-10-21 Thread Andre Przywara
On 21/10/15 21:41, Brijesh Singh wrote: > Add support for Cortex A57 and A53 EDAC driver. Hi Brijesh, thanks for the quick update! Some comments below. > > Signed-off-by: Brijesh Singh > CC: robh...@kernel.org > CC: pawel.m...@arm.com > CC: mark.rutl...@arm.com > CC: ijc+devicet...@hellion.org

Re: [PATCH v2] EDAC: Add ARM64 EDAC

2015-10-23 Thread Andre Przywara
On 23/10/15 02:41, Hanjun Guo wrote: > Hi Brijesh, > > On 2015/10/22 22:46, Brijesh Singh wrote: >> Hi Andre, >> >> On 10/21/2015 06:52 PM, Andre Przywara wrote: >>> On 21/10/15 21:41, Brijesh Singh wrote: >>>> Add support for Cortex A57 and A53 EDA

Re: [PATCH] sparc(64)/iommu: fixup iommu_tbl_range_alloc() types

2015-10-05 Thread Andre Przywara
Hi David, On 21/09/15 18:17, Andre Przywara wrote: > With DMA_ERROR_CODE now being dma_addr_t in most architectures, it > turned out that iommu_tbl_range_alloc (defined in lib/iommu-common.c) > is actually using a wrong return type. > This was easily fixed in a previous patch, but n

Re: [PATCH] pinctrl: use non-devm kmalloc versions for free functions

2017-05-11 Thread Andre Przywara
Hi Linus, On 11/05/17 15:01, Linus Walleij wrote: > On Thu, May 4, 2017 at 1:57 AM, Andre Przywara wrote: > >> When a pinctrl driver gets interrupted during its probe process >> (returning -EPROBE_DEFER), the devres system cleans up all allocated >> resources. Duri

Re: [linux-sunxi] [PATCH 1/7] pinctrl: sunxi: add support for pin controllers without bus gate

2018-01-11 Thread Andre Przywara
Hi, On 06/01/18 04:23, Icenowy Zheng wrote: > The Allwinner H6 pin controllers (both the main one and the CPUs one) > have no bus gate clocks. > > Add support for this kind of pin controllers. > > Signed-off-by: Icenowy Zheng > --- > drivers/pinctrl/sunxi/pinctrl-sunxi.c | 30 +

Re: [linux-sunxi] [PATCH 1/7] pinctrl: sunxi: add support for pin controllers without bus gate

2018-01-11 Thread Andre Przywara
Hi, On 11/01/18 10:14, Chen-Yu Tsai wrote: > On Thu, Jan 11, 2018 at 6:08 PM, Andre Przywara > wrote: >> Hi, >> >> On 06/01/18 04:23, Icenowy Zheng wrote: >>> The Allwinner H6 pin controllers (both the main one and the CPUs one) >>> have no bus gate cl

Re: [linux-sunxi] [PATCH 1/7] pinctrl: sunxi: add support for pin controllers without bus gate

2018-01-11 Thread Andre Przywara
Hi, On 11/01/18 10:15, Icenowy Zheng wrote: > > > 于 2018年1月11日 GMT+08:00 下午6:08:19, Andre Przywara 写到: >> Hi, >> >> On 06/01/18 04:23, Icenowy Zheng wrote: >>> The Allwinner H6 pin controllers (both the main one and the CPUs one) >>> have no bus g

Re: [linux-sunxi] [PATCH 1/7] pinctrl: sunxi: add support for pin controllers without bus gate

2018-01-11 Thread Andre Przywara
Hi, On 11/01/18 10:41, Maxime Ripard wrote: > On Thu, Jan 11, 2018 at 10:23:52AM +0000, Andre Przywara wrote: >> Hi, >> >> On 11/01/18 10:14, Chen-Yu Tsai wrote: >>> On Thu, Jan 11, 2018 at 6:08 PM, Andre Przywara >>> wrote: >>>> Hi, >>

Re: [linux-sunxi] [PATCH 1/7] pinctrl: sunxi: add support for pin controllers without bus gate

2018-01-11 Thread Andre Przywara
Hi, another take to avoid this patch at all, I just remembered this from an IRC discussion before: On 06/01/18 04:23, Icenowy Zheng wrote: > The Allwinner H6 pin controllers (both the main one and the CPUs one) > have no bus gate clocks. I don't think this is true. The pin controller *needs* an

Re: [PATCHv2 5/5] arm64: allwinner: a64: Add support for TERES-I laptop

2018-03-20 Thread Andre Przywara
Hi, On 20/03/18 14:13, Maxime Ripard wrote: > On Mon, Mar 19, 2018 at 04:27:36PM +0100, Harald Geyer wrote: >>> together with all the patches but the >>> PWM (so I had to drop the backlight node as well). >>> >>> Please coordinate with Andre about who should send the PWM support. >> >> Seems the p

Re: arm64 + ARM64_64K_PAGES=y

2018-11-12 Thread Andre Przywara
On Fri, 9 Nov 2018 13:15:47 -0600 Grygorii Strashko wrote: Hi, > On 11/8/18 12:14 PM, Grygorii Strashko wrote: > > > > > > On 11/8/18 6:00 AM, Sebastian Andrzej Siewior wrote: > >> On 2018-11-06 15:34:55 [-0600], Grygorii Strashko wrote: > >>> Hi All, > >> Hi, > >> > >>> Do anybody tri

[PATCH] fs/nfs: fix new compiler warning about boolean in switch

2015-04-23 Thread Andre Przywara
auth_probe) { ^ This code was obviously using switch to make use of the fall-through semantics (without the usual comment, though). Rewrite that code using if statements to avoid the warning and make the code a bit more readable on the way. Signed-off-by: Andre Przywara --- fs/nfs/nfs4pro

[PATCH] arm: cmpxchg: update macro to prevent compiler warning

2015-06-17 Thread Andre Przywara
_typeof__(*(ptr)))__cmpxchg_mb((ptr), \ ^ kernel/acct.c:174:2: note: in expansion of macro 'cmpxchg' cmpxchg(&acct->ns->bacct, pin, NULL); ^ Rearrange the macro along the lines of a similar patch for arm64 60010e508111 ("arm64: cmpxchg: update macros to prevent warnings&quo

Re: [linux-sunxi] Re: [PATCH v3 6/7] arm64: allwinner: h6: add the basical Allwinner H6 DTSI file

2018-02-28 Thread Andre Przywara
Hi, On 26/02/18 15:54, Samuel Holland wrote: > On 02/26/18 03:26, Maxime Ripard wrote: >> On Fri, Feb 23, 2018 at 11:22:06PM +0800, Icenowy Zheng wrote: > + psci { > + compatible = "arm,psci-0.2"; > + method = "smc"; > + }; Is it needed? The bootloader sho

Re: [PATCH 2/3] mailbox: Avoid NULL dereference in mbox_chan_received_data

2018-02-28 Thread Andre Przywara
Hi, On 28/02/18 02:27, Samuel Holland wrote: > If a reception IRQ is pending when a mailbox channel is shut down (for > example, if the controller uses threaded interrupts), it is possible for > mbox_chan_received_data to be called while chan->cl is NULL. > > This was found while developing a mai

Re: [PATCH 1/3] dt-bindings: Add a binding for the sunxi message box

2018-02-28 Thread Andre Przywara
Hi Samuel, thank you very much for writing and posting this! On 28/02/18 08:28, Maxime Ripard wrote: > Hi, > > On Tue, Feb 27, 2018 at 08:27:12PM -0600, Samuel Holland wrote: >> This mailbox hardware is present in several Allwinner sun8i and sun50i >> SoCs. Add a device tree binding for it. >> >

Re: [PATCH 3/3] mailbox: sunxi-msgbox: Add a new mailbox driver

2018-03-01 Thread Andre Przywara
Hi, On 01/03/18 10:32, Maxime Ripard wrote: > On Wed, Feb 28, 2018 at 11:19:11AM -0600, Samuel Holland wrote: >> Hi, >> >> On 02/28/18 02:32, Maxime Ripard wrote: >>> On Tue, Feb 27, 2018 at 08:27:14PM -0600, Samuel Holland wrote: + /* + * The failure path should not disable the clock

Re: [linux-sunxi] [PATCH 1/3] mmc: sunxi: add support for the MMC controller on H6

2018-04-26 Thread Andre Przywara
Hi, On 26/04/18 15:07, Icenowy Zheng wrote: > The new Allwinner H6 SoC have 3 MMC controllers. The first and second > ones are similar to the ones on A64, but the third one adds EMCE > (Embedded Crypto Engine) support which does hardware transparent crypto > on the eMMC. > > As we still do not ha

Re: [linux-sunxi] [PATCH 2/3] arm64: allwinner: h6: add device tree nodes for MMC controllers

2018-04-26 Thread Andre Przywara
Hi, On 26/04/18 15:07, Icenowy Zheng wrote: > The Allwinner H6 SoC have 3 MMC controllers. > > Add device tree nodes for them. > > Signed-off-by: Icenowy Zheng > --- > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 56 > > 1 file changed, 56 insertions(+) > > dif

Re: [linux-sunxi] [PATCH 3/3] arm64: allwinner: h6: enable MMC0/2 on Pine H64

2018-04-26 Thread Andre Przywara
Hi, On 26/04/18 15:07, Icenowy Zheng wrote: > The Pine H64 board have a MicroSD slot connected to MMC0 controller of > the H6 SoC and a eMMC slot connected to MMC2. > > Enable them in the device tree. > > Signed-off-by: Icenowy Zheng > --- > .../boot/dts/allwinner/sun50i-h6-pine-h64.dts |

Re: [linux-sunxi] [PATCH 2/3] arm64: allwinner: h6: add device tree nodes for MMC controllers

2018-04-27 Thread Andre Przywara
Hi, On 27/04/18 09:36, Icenowy Zheng wrote: > > > 于 2018年4月27日 GMT+08:00 上午12:45:38, Andre Przywara 写到: >> Hi, >> >> On 26/04/18 15:07, Icenowy Zheng wrote: >>> The Allwinner H6 SoC have 3 MMC controllers. >>> >>> Add device tre

Re: [linux-sunxi] [PATCH 1/3] mmc: sunxi: add support for the MMC controller on H6

2018-04-27 Thread Andre Przywara
Hi, On 27/04/18 09:38, Icenowy Zheng wrote: > > > 于 2018年4月27日 GMT+08:00 上午12:45:24, Andre Przywara 写到: >> Hi, >> >> On 26/04/18 15:07, Icenowy Zheng wrote: >>> The new Allwinner H6 SoC have 3 MMC controllers. The first and second >>> ones are simil

Re: [linux-sunxi] [PATCH 3/3] arm64: allwinner: h6: enable MMC0/2 on Pine H64

2018-04-30 Thread Andre Przywara
Hi Icenowy, On 27/04/18 08:12, Icenowy Zheng wrote: > > > 于 2018年4月27日 GMT+08:00 上午12:46:26, Andre Przywara 写到: >> Hi, >> >> On 26/04/18 15:07, Icenowy Zheng wrote: >>> The Pine H64 board have a MicroSD slot connected to MMC0 controller >> of >&g

Re: [linux-sunxi] [PATCH 3/3] arm64: allwinner: h6: enable MMC0/2 on Pine H64

2018-04-30 Thread Andre Przywara
Hi, On 30/04/18 10:51, Icenowy Zheng wrote: > > > 于 2018年4月30日 GMT+08:00 下午5:47:35, Andre Przywara 写到: >> Hi Icenowy, >> >> On 27/04/18 08:12, Icenowy Zheng wrote: >>> >>> >>> 于 2018年4月27日 GMT+08:00 上午12:46:26, Andre Przywara >> 写

Re: [linux-sunxi] [PATCH 3/3] arm64: allwinner: h6: enable MMC0/2 on Pine H64

2018-05-02 Thread Andre Przywara
Hi, On 01/05/18 16:52, Chen-Yu Tsai wrote: > On Mon, Apr 30, 2018 at 6:44 PM, Andre Przywara > wrote: >> Hi, >> >> On 30/04/18 10:51, Icenowy Zheng wrote: >>> >>> >>> 于 2018年4月30日 GMT+08:00 下午5:47:35, Andre Przywara >>> 写到: >&

Re: [linux-sunxi] [PATCH 3/3] arm64: allwinner: h6: enable MMC0/2 on Pine H64

2018-05-02 Thread Andre Przywara
Hi, On 02/05/18 10:36, Maxime Ripard wrote: > On Mon, Apr 30, 2018 at 10:47:35AM +0100, Andre Przywara wrote: >>>> I am just asking because I want to avoid running into the same problem >>>> as with the A64 before: that future DTs become incompatible with older >>

Re: [PATCH v5 01/10] arm64: Provide a command line to disable spectre_v2 mitigation

2019-02-28 Thread Andre Przywara
Hi, On 2/26/19 7:05 PM, Jeremy Linton wrote: There are various reasons, including bencmarking, to disable spectrev2 mitigation on a machine. Provide a command-line to do so. Signed-off-by: Jeremy Linton Reviewed-by: Andre Przywara Cheers, Andre. Cc: Jonathan Corbet Cc: linux

Re: [PATCH v5 02/10] arm64: add sysfs vulnerability show for spectre v1

2019-02-28 Thread Andre Przywara
cpu_show_spectre_v1(struct device *dev, struct device_attribute *attr, + char *buf) w/s issue, but it's not critical: Reviewed-by: Andre Przywara Cheers, Andre +{ + return sprintf(buf, "Mitigation: __user pointer sanitization\n"); +}

Re: [PATCH v5 04/10] arm64: Advertise mitigation of Spectre-v2, or lack thereof

2019-02-28 Thread Andre Przywara
es of that patch into this and move it earlier] Signed-off-by: Jeremy Linton Indeed a whitelist is much better. Reviewed-by: Andre Przywara Cheers, Andre. --- arch/arm64/kernel/cpu_errata.c | 108 + 1 file changed, 56 insertions(+), 52 deletions(-) diff --

Re: [PATCH v5 05/10] arm64: Use firmware to detect CPUs that are not affected by Spectre-v2

2019-02-28 Thread Andre Przywara
s use this information to our benefit. Yes, that matches the firmware interface description. Signed-off-by: Marc Zyngier Signed-off-by: Jeremy Linton Reviewed-by: Andre Przywara Cheers, Andre. --- arch/arm64/kernel/cpu_errata.c | 32 +++- 1 file change

Re: [PATCH v5 06/10] arm64: Always enable spectrev2 vulnerability detection

2019-02-28 Thread Andre Przywara
); + extra empty line Apart from that picky and unimportant nit it looks alright and compiles with and without CONFIG_HARDEN_BRANCH_PREDICTOR being defined. Reviewed-by: Andre Przywara Cheers, Andre. #ifdef CONFIG_KVM_INDIRECT_VECTORS extern char __smccc_workaround_1_smc_start

Re: [PATCH v5 07/10] arm64: add sysfs vulnerability show for spectre v2

2019-02-28 Thread Andre Przywara
_t cpu_show_spectre_v1(struct device *dev, struct device_attribute *attr, { return sprintf(buf, "Mitigation: __user pointer sanitization\n"); } + +ssize_t cpu_show_spectre_v2(struct device *dev, struct device_attribute *attr, + char *buf) w/s issue Anyway: R

Re: [PATCH v5 08/10] arm64: Always enable ssb vulnerability detection

2019-02-28 Thread Andre Przywara
arm64_set_ssbd_mitigation(bool state) +{ + pr_info_once("SSBD, disabled by kernel configuration\n"); Is there a stray comma or is the continuation of some previous printout? Regardless of that it looks good and compiles with both CONFIG_ARM64_SSBD defined or not: Reviewed

Re: [PATCH v5 09/10] arm64: add sysfs vulnerability show for speculative store bypass

2019-02-28 Thread Andre Przywara
Hi, On 2/26/19 7:05 PM, Jeremy Linton wrote: Return status based on ssbd_state and the arm64 SSBS feature. If the mitigation is disabled, or the firmware isn't responding then return the expected machine state based on a new blacklist of known vulnerable cores. Signed-off-by: Jeremy Linton ---

Re: [PATCH v5 10/10] arm64: enable generic CPU vulnerabilites support

2019-02-28 Thread Andre Przywara
Hi, On 2/26/19 7:05 PM, Jeremy Linton wrote: From: Mian Yousaf Kaukab Enable CPU vulnerabilty show functions for spectre_v1, spectre_v2, meltdown and store-bypass. Signed-off-by: Mian Yousaf Kaukab Signed-off-by: Jeremy Linton Reviewed-by: Andre Przywara Thanks, Andre. --- arch

  1   2   3   4   5   6   7   >