[PATCH] pkt_sched: sch_qfq: remove redundant -if- control statement

2015-06-15 Thread Andrea Parri
The control !hlist_unhashed() in qfq_destroy_agg() is unnecessary because already performed in hlist_del_init(), so remove it. Signed-off-by: Andrea Parri parri.and...@gmail.com --- net/sched/sch_qfq.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/sched/sch_qfq.c b

[PATCH RESEND] pkt_sched: sch_qfq: remove redundant -if- control statement

2015-06-16 Thread Andrea Parri
The control !hlist_unhashed() in qfq_destroy_agg() is unnecessary because already performed in hlist_del_init(), so remove it. Signed-off-by: Andrea Parri parri.and...@gmail.com --- net/sched/sch_qfq.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/sched/sch_qfq.c b

[PATCH] Documentation/scheduler/sched-deadline.txt: fix schedtool's time-units

2015-05-25 Thread Andrea Parri
Use the proper time-units for schedtool's reservation parameters. Signed-off-by: Andrea Parri parri.and...@gmail.com --- Documentation/scheduler/sched-deadline.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/scheduler/sched-deadline.txt b/Documentation

[PATCH trivial] time/timer.c: coding style fix

2015-05-26 Thread Andrea Parri
Put the opening brace last on the line in switch statement. Signed-off-by: Andrea Parri parri.and...@gmail.com --- kernel/time/timer.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/time/timer.c b/kernel/time/timer.c index 2ece3aa..19e61f2 100644 --- a/kernel/time

[PATCH 1/2] sched/deadline: fix comment in push_dl_tasks

2015-08-05 Thread Andrea Parri
The comment is misleading; fix it by adapting a comment from push_rt_tasks. Signed-off-by: Andrea Parri parri.and...@gmail.com --- kernel/sched/deadline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index 0a17af35..7c17001

[PATCH 2/2] sched/deadline: fix comment in enqueue_task_dl

2015-08-05 Thread Andrea Parri
The flag dl_boosted is set by comparing *absolute* deadlines (c.f., rt_mutex_setprio). Signed-off-by: Andrea Parri parri.and...@gmail.com --- kernel/sched/deadline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index

[PATCH] pkt_sched: sch_qfq: remove unused member of struct qfq_sched

2015-07-13 Thread Andrea Parri
The member (u32) num_active_agg of struct qfq_sched has been unused since its introduction in 462dbc9101acd38e92eda93c0726857517a24bbd pkt_sched: QFQ Plus: fair-queueing service at DRR cost and (AFAICT) there is no active plan to use it; this removes the member. Signed-off-by: Andrea Parri

[PATCH] events/uprobes: move smp_read_barrier_depends() where needed

2016-06-09 Thread Andrea Parri
There is no need to use the barrier if there is no dereference/ memory access; move it where needed (currently, affecting only Alpha). While touching this, also make the reads _ONCE(). Signed-off-by: Andrea Parri <parri.and...@gmail.com> --- kernel/events/uprobes.c | 9 + 1 file c

Re: [PATCH v3] locking/pvqspinlock: Relax cmpxchg's to improve performance on some archs

2017-02-19 Thread Andrea Parri
On Fri, Feb 17, 2017 at 03:43:40PM -0500, Waiman Long wrote: > All the locking related cmpxchg's in the following functions are > replaced with the _acquire variants: > - pv_queued_spin_steal_lock() > - trylock_clear_pending() > > This change should help performance on architectures that use

Re: Question about DEC Alpha memory ordering

2017-02-14 Thread Andrea Parri
On Mon, Feb 13, 2017 at 01:24:36PM -0800, Paul E. McKenney wrote: > On Mon, Feb 13, 2017 at 04:06:21PM -0500, Alan Stern wrote: > > On Mon, 13 Feb 2017, Paul E. McKenney wrote: > > > > > On Mon, Feb 13, 2017 at 08:14:23PM +0100, Tobias Klausmann wrote: > > > > Hi! > > > > > > > > On Mon, 13 Feb

Re: Question about DEC Alpha memory ordering

2017-02-14 Thread Andrea Parri
On Wed, Feb 15, 2017 at 08:26:46AM +1300, Michael Cree wrote: > On Tue, Feb 14, 2017 at 12:35:58PM +0100, Andrea Parri wrote: > > On Mon, Feb 13, 2017 at 01:24:36PM -0800, Paul E. McKenney wrote: > > > >

Re: [PATCH] osq_lock: fix osq_lock queue corruption

2017-08-09 Thread Andrea Parri
= nodenext->prev = prev //unqueue-C > + * > + * Here 'node->prev' and 'next->prev' are the same variable and we need > + * to ensure these stores happen in-order to avoid corrupting the list. > + */ The interested pattern/behavior remains somehow

Re: [PATCH] rwsem: fix missed wakeup due to reordering of load

2017-08-10 Thread Andrea Parri
On Thu, Jul 27, 2017 at 11:48:53AM -0400, Waiman Long wrote: > On 07/26/2017 04:17 PM, Prateek Sood wrote: > > If a spinner is present, there is a chance that the load of > > rwsem_has_spinner() in rwsem_wake() can be reordered with > > respect to decrement of rwsem count in __up_write() leading >

Re: [GIT PULL rcu/next] RCU commits for 4.13

2017-06-19 Thread Andrea Parri
On Wed, Jun 14, 2017 at 01:23:29PM -0700, Paul E. McKenney wrote: > On Wed, Jun 14, 2017 at 04:33:22PM +0200, Andrea Parri wrote: > > On Tue, Jun 13, 2017 at 09:33:17PM -0700, Paul E. McKenney wrote: > > > On Wed, Jun 14, 2017 at 04:54:04AM +0200, Andrea Parri wrote: > >

Re: [PATCH tip/core/rcu 20/88] atomics: Add header comment so spin_unlock_wait()

2017-06-10 Thread Andrea Parri
On Thu, May 25, 2017 at 02:58:53PM -0700, Paul E. McKenney wrote: > There is material describing the ordering guarantees provided by > spin_unlock_wait(), but it is not necessarily easy to find. This commit > therefore adds a docbook header comment to this function informally > describing its

Re: [GIT PULL rcu/next] RCU commits for 4.13

2017-06-13 Thread Andrea Parri
On Mon, Jun 12, 2017 at 02:37:55PM -0700, Paul E. McKenney wrote: > Hello, Ingo, > > This pull request is unusual in being a single linear set of commits, > as opposed to my usual topic branches. This is due to the many > large-footprint changes, which means that reasonable topic branches >

Re: [GIT PULL rcu/next] RCU commits for 4.13

2017-06-14 Thread Andrea Parri
On Tue, Jun 13, 2017 at 09:33:17PM -0700, Paul E. McKenney wrote: > On Wed, Jun 14, 2017 at 04:54:04AM +0200, Andrea Parri wrote: > > On Mon, Jun 12, 2017 at 02:37:55PM -0700, Paul E. McKenney wrote: > > > Hello, Ingo, > > > > > > This pull request is

Re: [PATCH v2] membarrier: Document scheduler barrier requirements

2017-09-19 Thread Andrea Parri
On Tue, Sep 19, 2017 at 03:56:31PM -0400, Mathieu Desnoyers wrote: > Document the membarrier requirement on having a full memory barrier in > __schedule() after coming from user-space, before storing to rq->curr. > It is provided by smp_mb__before_spinlock() in __schedule(). It is

Re: [PATCH] rwsem: fix missed wakeup due to reordering of load

2017-09-19 Thread Andrea Parri
would result > in rwsem_try_write_lock() failing to acquire rwsem and spinning > writer going to sleep in rwsem_down_write_failed(). > > The smp_rmb() will make sure that the spinner state is > consulted after sem->count is updated in up_write context. > > Signed

Re: [PATCH] rwsem: fix missed wakeup due to reordering of load

2017-09-20 Thread Andrea Parri
On Wed, Sep 20, 2017 at 07:52:54AM -0700, Davidlohr Bueso wrote: > On Thu, 07 Sep 2017, Prateek Sood wrote: > > /* > >+* __rwsem_down_write_failed_common(sem) > >+* rwsem_optimistic_spin(sem) > >+* osq_unlock(sem->osq) > >+* ... > >+*

Re: [PATCH v4 11/13] xen/pvcalls: implement poll command

2017-09-19 Thread Andrea Parri
Hi Stefano, On Fri, Sep 15, 2017 at 04:00:38PM -0700, Stefano Stabellini wrote: > For active sockets, check the indexes and use the inflight_conn_req > waitqueue to wait. > > For passive sockets if an accept is outstanding > (PVCALLS_FLAG_ACCEPT_INFLIGHT), check if it has been answered by

Re: [PATCH] membarrier: Document scheduler barrier requirements

2017-09-18 Thread Andrea Parri
On Mon, Sep 18, 2017 at 02:01:22PM -0400, Mathieu Desnoyers wrote: > Document the membarrier requirement on having a full memory barrier in > __schedule() after coming from user-space, before storing to rq->curr. > It is provided by smp_mb__before_spinlock() in __schedule(). > > Document that

Re: [PATCH tip/core/rcu 1/9] rcu: Provide GP ordering in face of migrations and delays

2017-10-09 Thread Andrea Parri
On Mon, Oct 09, 2017 at 10:16:37AM +0200, Peter Zijlstra wrote: > On Sat, Oct 07, 2017 at 11:28:57AM -0700, Paul E. McKenney wrote: > > But if you are saying that it would be good to have wait_for_completion() > > and complete() directly modeled at some point, no argument. In addition, > > I hope

Re: Linux-kernel examples for LKMM recipes

2017-10-12 Thread Andrea Parri
Hi Paul, On Wed, Oct 11, 2017 at 03:32:30PM -0700, Paul E. McKenney wrote: > Hello! > > At Linux Plumbers Conference, we got requests for a recipes document, > and a further request to point to actual code in the Linux kernel. > I have pulled together some examples for various litmus-test

Re: [PATCH] blk-mq: Start to fix memory ordering...

2017-09-06 Thread Andrea Parri
requeue. > > If I got anything wrong, feel free to educate me by adding comments to > clarify things ;-) > > Cc: Alan Stern <st...@rowland.harvard.edu> > Cc: Will Deacon <will.dea...@arm.com> > Cc: Ming Lei <tom.leim...@gmail.com> > Cc: Jens Axboe <ax.

Re: [PATCH] swait: add missing barrier to swake_up

2017-09-01 Thread Andrea Parri
On Fri, Sep 01, 2017 at 04:14:50PM +1000, Nicholas Piggin wrote: > swake_up and swake_up_all test the swaitqueue outside the lock, > but they are missing the barrier that would ensure visibility > of a previous store that sets the wakeup condition with the > load that tests the swaitqueue. This

Re: [RFC PATCH 1/2] arm64: mm: Use READ_ONCE/WRITE_ONCE when accessing page tables

2017-10-05 Thread Andrea Parri
Hi Will, none of my comments below represent objections to this patch, but let me remark: On Thu, Oct 05, 2017 at 05:31:54PM +0100, Will Deacon wrote: > Hi Paul, > > On Tue, Oct 03, 2017 at 12:11:10PM -0700, Paul E. McKenney wrote: > > On Fri, Sep 29, 2017 at 05:33:49PM +0100, Will Deacon

Re: [PATCH tip/core/rcu 1/3] membarrier: Provide register expedited private command

2017-10-05 Thread Andrea Parri
On Thu, Oct 05, 2017 at 04:02:06PM +, Mathieu Desnoyers wrote: > - On Oct 5, 2017, at 8:12 AM, Peter Zijlstra pet...@infradead.org wrote: > > > On Wed, Oct 04, 2017 at 02:37:53PM -0700, Paul E. McKenney wrote: > >> diff --git a/arch/powerpc/kernel/membarrier.c > >>

Re: [PATCH tip/core/rcu 1/3] membarrier: Provide register expedited private command

2017-10-07 Thread Andrea Parri
On Fri, Oct 06, 2017 at 10:32:19AM +0200, Peter Zijlstra wrote: > > AFAIU the scheduler rq->lock is held while preemption is disabled. > > synchronize_sched() is used here to ensure that all pre-existing > > preempt-off critical sections have completed. > > > > So saying that we use

[Question] drivers/infiniband: on smp_read_barrier_depends() usages

2017-10-11 Thread Andrea Parri
Dear IB supporters, I was reviewing current usages of smp_read_barrier_depends() https://marc.info/?l=linux-kernel=150723193717856=2 when I stubled over drivers/infiniband/: I've found 19 instances of this barrier here, but their intent is unclear to me and I'm wondering if you could clarify

Re: Memory-ordering recipes

2017-10-17 Thread Andrea Parri
On Tue, Oct 17, 2017 at 02:01:37PM -0700, Paul E. McKenney wrote: > On Sun, Sep 17, 2017 at 04:05:09PM -0700, Paul E. McKenney wrote: > > Hello! > > > > The topic of memory-ordering recipes came up at the Linux Plumbers > > Conference microconference on Friday, so I thought that I should

Re: [PATCH] refcount: provide same memory ordering guarantees as in atomic_t

2017-11-15 Thread Andrea Parri
On Wed, Nov 15, 2017 at 09:03:07PM +0100, Peter Zijlstra wrote: > On Wed, Nov 15, 2017 at 02:15:19PM -0500, Alan Stern wrote: > > On Wed, 15 Nov 2017, Will Deacon wrote: > > > > > On Thu, Nov 02, 2017 at 04:21:56PM -0400, Alan Stern wrote: > > > > I was trying to think of something completely

Re: Prototype patch for Linux-kernel memory model

2017-11-20 Thread Andrea Parri
> > A second tool is klitmus7, which converts litmus tests to > > > > > > loadable > > > > > > kernel modules for direct testing. As with herd7, the klitmus7 > > > > > > code is freely available from > > >

Re: [PATCH] refcount: provide same memory ordering guarantees as in atomic_t

2017-11-16 Thread Andrea Parri
On Thu, Nov 16, 2017 at 09:58:04AM +0100, Peter Zijlstra wrote: > On Wed, Nov 15, 2017 at 10:01:11PM +0100, Andrea Parri wrote: > > > > And in specific things like: > > > > > > 135e8c9250dd5 > > > ecf7d01c229d1 > > > > > > wh

Re: [PATCH] refcount: provide same memory ordering guarantees as in atomic_t

2017-11-02 Thread Andrea Parri
On Thu, Nov 02, 2017 at 01:08:52PM -0400, Alan Stern wrote: > On Thu, 2 Nov 2017, Peter Zijlstra wrote: > > > On Thu, Nov 02, 2017 at 11:40:35AM -0400, Alan Stern wrote: > > > On Thu, 2 Nov 2017, Peter Zijlstra wrote: > > > > > > > > Lock functions such as refcount_dec_and_lock() & > > > > >

Re: [patches] Re: [GIT PULL] RISC-V Cleanups and ABI Fixes for 4.15-rc2

2017-12-08 Thread Andrea Parri
On Thu, Dec 07, 2017 at 12:59:35PM -0800, Palmer Dabbelt wrote: > On Sat, 02 Dec 2017 19:20:02 PST (-0800), parri.and...@gmail.com wrote: > >On Fri, Dec 01, 2017 at 01:39:12PM -0800, Palmer Dabbelt wrote: > >> RISC-V: Remove smb_mb__{before,after}_spinlock() > > > >I wonder whether you really

Re: [GIT PULL] RISC-V Cleanups and ABI Fixes for 4.15-rc2

2017-12-02 Thread Andrea Parri
Hi Palmer, On Fri, Dec 01, 2017 at 01:39:12PM -0800, Palmer Dabbelt wrote: > The following changes since commit 4fbd8d194f06c8a3fd2af1ce560ddb31f7ec8323: > > Linux 4.15-rc1 (2017-11-26 16:01:47 -0800) > > are available in the git repository at: > >

Re: [PATCH] refcount_t: documentation for memory ordering differences

2017-12-02 Thread Andrea Parri
On Fri, Dec 01, 2017 at 12:34:23PM -0800, Randy Dunlap wrote: > On 11/29/2017 04:36 AM, Elena Reshetova wrote: > > Some functions from refcount_t API provide different > > memory ordering guarantees that their atomic counterparts. > > This adds a document outlining these differences. > > > >

Re: [PATCH] refcount_t: documentation for memory ordering differences

2017-12-02 Thread Andrea Parri
On Sun, Dec 03, 2017 at 07:20:03AM +0100, Andrea Parri wrote: > On Fri, Dec 01, 2017 at 12:34:23PM -0800, Randy Dunlap wrote: > > On 11/29/2017 04:36 AM, Elena Reshetova wrote: > > > Some functions from refcount_t API provide different > > > memory ordering g

[PATCH] Documentation: refcount-vs-atomic: Update reference to LKMM doc.

2018-05-04 Thread Andrea Parri
The LKMM project has moved to 'tools/memory-model/'. Signed-off-by: Andrea Parri <andrea.pa...@amarulasolutions.com> --- Documentation/core-api/refcount-vs-atomic.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/core-api/refcount-vs-atomic.

Re: [PATCH] Documentation: refcount-vs-atomic: Update reference to LKMM doc.

2018-05-04 Thread Andrea Parri
On Fri, May 04, 2018 at 02:13:59PM -0700, Kees Cook wrote: > On Fri, May 4, 2018 at 2:11 PM, Andrea Parri > <andrea.pa...@amarulasolutions.com> wrote: > > The LKMM project has moved to 'tools/memory-model/'. > > > > Signed-off-by: Andrea Parri <

[RFC PATCH v3 0/6] Documentation/features: Provide and apply 'features-refresh.sh'

2018-05-07 Thread Andrea Parri
(suggested by Ingo Molnar) - add patches 4-6/6 (suggested by Ingo Molnar) Andrea Parri (6): Documentation/features: Add script that refreshes the arch support status files in place Documentation/features: Refresh the arch support status files in place Documentation/features/core: Add arch

[RFC PATCH v3 3/6] Documentation/features/core: Add arch support status files for 'cBPF-JIT' and 'eBPF-JIT'

2018-05-07 Thread Andrea Parri
Commit 606b5908e split 'HAVE_BPF_JIT' into cBPF and eBPF variant. Adds arch support status files for the new variants, and removes the status file corresponding to 'HAVE_BPT_JIT'. The new status matrices were auto-generated using the script 'features-refresh.sh'. Signed-off-by: Andrea Parri

[RFC PATCH v3 4/6] Documentation/features/locking: Use '!RWSEM_GENERIC_SPINLOCK' as Kconfig for 'rwsem-optimized'

2018-05-07 Thread Andrea Parri
by using the script 'features-refresh.sh'. Suggested-by: Ingo Molnar <mi...@kernel.org> Signed-off-by: Andrea Parri <andrea.pa...@amarulasolutions.com> Cc: Ingo Molnar <mi...@kernel.org> Cc: Jonathan Corbet <cor...@lwn.net> Cc: Andrew Morton <a...@linux-foundation.org&g

Re: [PATCH] locking/atomics: Simplify the op definitions in atomic.h some more

2018-05-07 Thread Andrea Parri
On Sun, May 06, 2018 at 04:57:27PM +0200, Ingo Molnar wrote: > > * Andrea Parri <andrea.pa...@amarulasolutions.com> wrote: > > > Hi Ingo, > > > > > From 5affbf7e91901143f84f1b2ca64f4afe70e210fd Mon Sep 17 00:00:00 2001 > > > From: Ingo Molnar <mi.

[RFC PATCH v3 1/6] Documentation/features: Add script that refreshes the arch support status files in place

2018-05-07 Thread Andrea Parri
t all easy to keep sync and to extend." [1] http://lkml.kernel.org/r/20180328122211.GA25420@andrea Suggested-by: Ingo Molnar <mi...@kernel.org> Signed-off-by: Andrea Parri <andrea.pa...@amarulasolutions.com> Cc: Ingo Molnar <mi...@kernel.org> Cc: Jonathan Corbet <co

[RFC PATCH v3 2/6] Documentation/features: Refresh the arch support status files in place

2018-05-07 Thread Andrea Parri
Now that the script 'features-refresh.sh' is available, uses this script to refresh all the arch-support.txt files in place. Signed-off-by: Andrea Parri <andrea.pa...@amarulasolutions.com> Cc: Ingo Molnar <mi...@kernel.org> Cc: Jonathan Corbet <cor...@lwn.net> Cc: Andrew

[RFC PATCH v3 5/6] Documentation/features/lib: Remove arch support status file for 'strncasecmp'

2018-05-07 Thread Andrea Parri
Suggested-by: Ingo Molnar <mi...@kernel.org> Signed-off-by: Andrea Parri <andrea.pa...@amarulasolutions.com> Cc: Ingo Molnar <mi...@kernel.org> Cc: Jonathan Corbet <cor...@lwn.net> Cc: Andrew Morton <a...@linux-foundation.org> --- .../features/lib/strncase

[RFC PATCH v3 6/6] Documentation/features/vm: Remove arch support status file for 'pte_special'

2018-05-07 Thread Andrea Parri
Suggested-by: Ingo Molnar <mi...@kernel.org> Signed-off-by: Andrea Parri <andrea.pa...@amarulasolutions.com> Cc: Ingo Molnar <mi...@kernel.org> Cc: Jonathan Corbet <cor...@lwn.net> Cc: Andrew Morton <a...@linux-foundation.org> --- .../features/vm/pte_speci

Re: [PATCH 07/18] docs: core-api: add circular-buffers documentation

2018-05-07 Thread Andrea Parri
On Mon, May 07, 2018 at 06:35:43AM -0300, Mauro Carvalho Chehab wrote: > The circular-buffers.txt is already in ReST format. So, move it to the > core-api guide, where it belongs. > > Signed-off-by: Mauro Carvalho Chehab > --- > Documentation/00-INDEX

Re: [PATCH 05/18] docs: core-api: add cachetlb documentation

2018-05-07 Thread Andrea Parri
On Mon, May 07, 2018 at 06:35:41AM -0300, Mauro Carvalho Chehab wrote: > The cachetlb.txt is already in ReST format. So, move it to the > core-api guide, where it belongs. > > Signed-off-by: Mauro Carvalho Chehab > --- > Documentation/00-INDEX

[PATCH] certificate handling: Update references to the documentation

2018-05-07 Thread Andrea Parri
Commit 94e980cc45f2b2 ("Documentation/module-signing.txt: convert to ReST markup") converted the .txt doc. to ReST markup, but it did not update the references to the doc. (including in MAINTAINERS). Signed-off-by: Andrea Parri <andrea.pa...@amarulasolutions.com> --- MAINTAINERS

Re: [PATCH 05/18] docs: core-api: add cachetlb documentation

2018-05-08 Thread Andrea Parri
On Tue, May 08, 2018 at 03:28:51PM -0300, Mauro Carvalho Chehab wrote: > Em Tue, 8 May 2018 15:05:07 -0300 > Mauro Carvalho Chehab escreveu: > > > Em Tue, 08 May 2018 17:40:56 +0300 > > Jani Nikula escreveu: [...] > > > Side note,

Re: [PATCH v9 1/2] arch/*: Add CONFIG_ARCH_HAVE_CMPXCHG64

2018-05-15 Thread Andrea Parri
Hi Bart, On Mon, May 14, 2018 at 11:46:33AM -0700, Bart Van Assche wrote: [...] > diff --git a/Documentation/features/locking/cmpxchg64/arch-support.txt > b/Documentation/features/locking/cmpxchg64/arch-support.txt > new file mode 100644 > index ..65b3290ce5d5 > --- /dev/null > +++

Re: linux-next: manual merge of the akpm-current tree with the jc_docs tree

2018-05-09 Thread Andrea Parri
Really Cc-ing Ingo: On Wed, May 09, 2018 at 03:28:24PM +0200, Andrea Parri wrote: > On Wed, May 09, 2018 at 08:25:26PM +1000, Stephen Rothwell wrote: > > Hi all, > > > > Today's linux-next merge of the akpm-current tree got a conflict in: > > > > Documenta

Re: linux-next: manual merge of the akpm-current tree with the jc_docs tree

2018-05-09 Thread Andrea Parri
On Wed, May 09, 2018 at 08:25:26PM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the akpm-current tree got a conflict in: > > Documentation/features/vm/pte_special/arch-support.txt > > between commit: > > 2bef69a385b4 ("Documentation/features/vm: Remove arch

Re: [PATCH v2 08/11] docs: refcount-vs-atomic.rst: prefix url with https

2018-05-09 Thread Andrea Parri
Hi Mauro, On Wed, May 09, 2018 at 10:18:51AM -0300, Mauro Carvalho Chehab wrote: > There's a github URL there, but it is not prefixed by https. > Add a prefix, to avoid false-positives with: > ./scripts/documentation-file-ref-check > > As a side effect, Sphinx should also generate a

Re: linux-next: manual merge of the akpm-current tree with the jc_docs tree

2018-05-09 Thread Andrea Parri
On Wed, May 09, 2018 at 11:11:36AM -0600, Jonathan Corbet wrote: > On Wed, 9 May 2018 18:53:28 +0200 > Andrea Parri <andrea.pa...@amarulasolutions.com> wrote: > > > > Now that I look a little closer, I think the real issue is that the > > > "features" d

Re: linux-next: manual merge of the akpm-current tree with the jc_docs tree

2018-05-09 Thread Andrea Parri
On Wed, May 09, 2018 at 08:59:20AM -0600, Jonathan Corbet wrote: > On Wed, 9 May 2018 15:28:24 +0200 > Andrea Parri <andrea.pa...@amarulasolutions.com> wrote: > > > > BTW, it would be nice if the the question "Why was this file removed?" was > > > ans

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

2018-05-10 Thread Andrea Parri
On Wed, May 09, 2018 at 08:45:18AM -0600, Jonathan Corbet wrote: > On Wed, 9 May 2018 10:41:20 +0200 > Peter Zijlstra wrote: > > > > This is easily done by using "::" instead of just ":". > > > > And I'll voice my objection once again. This makes a regular comment > >

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

2018-05-10 Thread Andrea Parri
On Thu, May 10, 2018 at 07:15:59AM -0600, Jonathan Corbet wrote: > On Thu, 10 May 2018 14:23:35 +0200 > Andrea Parri <andrea.pa...@amarulasolutions.com> wrote: > > > only > > remember that other people (including some developers running into the > > "dis

Re: [PATCH 05/18] docs: core-api: add cachetlb documentation

2018-05-08 Thread Andrea Parri
Hi Jani, On Tue, May 08, 2018 at 05:40:56PM +0300, Jani Nikula wrote: > On Mon, 07 May 2018, Andrea Parri <andrea.pa...@amarulasolutions.com> wrote: > > On Mon, May 07, 2018 at 06:35:41AM -0300, Mauro Carvalho Chehab wrote: > >> The cachetlb.txt is already

Re: [PATCH 05/18] docs: core-api: add cachetlb documentation

2018-05-08 Thread Andrea Parri
On Tue, May 08, 2018 at 06:02:42PM +0200, Andrea Parri wrote: > Hi Jani, > > On Tue, May 08, 2018 at 05:40:56PM +0300, Jani Nikula wrote: > > On Mon, 07 May 2018, Andrea Parri <andrea.pa...@amarulasolutions.com> wrote: > > > On Mon, May 07, 2018 at 06:35:41AM -030

Re: [PATCH 05/18] docs: core-api: add cachetlb documentation

2018-05-08 Thread Andrea Parri
On Tue, May 08, 2018 at 10:04:08AM -0600, Jonathan Corbet wrote: > On Mon, 7 May 2018 06:35:41 -0300 > Mauro Carvalho Chehab wrote: > > > The cachetlb.txt is already in ReST format. So, move it to the > > core-api guide, where it belongs. > > > > Signed-off-by:

Re: [PATCH] locking/atomics: Simplify the op definitions in atomic.h some more

2018-05-06 Thread Andrea Parri
Hi Ingo, > From 5affbf7e91901143f84f1b2ca64f4afe70e210fd Mon Sep 17 00:00:00 2001 > From: Ingo Molnar > Date: Sat, 5 May 2018 10:23:23 +0200 > Subject: [PATCH] locking/atomics: Simplify the op definitions in atomic.h > some more > > Before: > > #ifndef

Re: [PATCH] locking/atomics: Combine the atomic_andnot() and atomic64_andnot() API definitions

2018-05-06 Thread Andrea Parri
Hi Ingo, > From f5efafa83af8c46b9e81b010b46caeeadb450179 Mon Sep 17 00:00:00 2001 > From: Ingo Molnar > Date: Sat, 5 May 2018 10:46:41 +0200 > Subject: [PATCH] locking/atomics: Combine the atomic_andnot() and > atomic64_andnot() API definitions > > The atomic_andnot() and

Re: write_lock_irq(_lock)

2018-05-24 Thread Andrea Parri
> Yeah, lemme put some details here: > > So we have three cases: > > Case #1 (from Will) > > P0: P1: P2: > > spin_lock() read_lock() > write_lock() > read_lock()

Re: [PATCH 6/9] asm-generic/bitops/atomic.h: Rewrite using atomic_fetch_*

2018-05-24 Thread Andrea Parri
Hi Mark, > As an aside, If I complete the autogeneration stuff, it'll be possible > to generate those. I split out the necessary barriers in [1], but I > still have a lot of other preparatory cleanup to do. I do grasp the rationale behind that naming:

Re: [PATCH 0/2] mm->owner to mm->memcg fixes

2018-05-24 Thread Andrea Parri
On Thu, May 24, 2018 at 02:16:35PM -0700, Andrew Morton wrote: > On Thu, 24 May 2018 13:10:02 +0200 Michal Hocko wrote: > > > I would really prefer and appreciate a repost with all the fixes folded > > in. > > [1/2] > > From: "Eric W. Biederman" >

Re: [PATCH V5] powercap/drivers/idle_injection: Add an idle injection framework

2018-06-06 Thread Andrea Parri
Hi Daniel, Viresh, On Wed, Jun 06, 2018 at 04:15:28PM +0530, Viresh Kumar wrote: > On 06-06-18, 12:22, Daniel Lezcano wrote: > > (mb() are done in the atomic operations AFAICT). To do my bit, not all atomic ops do/imply memory barriers; e.g., [from Documentation/atomic_t.txt] - non-RMW

Re: [PATCH v4 1/3] compiler-gcc.h: add gnu_inline to all inline declarations

2018-06-08 Thread Andrea Parri
On Fri, Jun 08, 2018 at 12:04:36PM +0200, Sedat Dilek wrote: > On Fri, Jun 8, 2018 at 9:59 AM, Arnd Bergmann wrote: > > On Thu, Jun 7, 2018 at 10:49 PM, Nick Desaulniers > > wrote: > >> Functions marked extern inline do not emit an externally visible > >> function when the gnu89 C standard is

Re: [PATCH RFC tools/memory-model] Add litmus-test naming scheme

2018-05-29 Thread Andrea Parri
cycle) > > deviate from the corresponding 'norm7' results; e.g., > > > > $ norm7 -bell linux-kernel.bell FenceWmbdWW Once Rfe Once FenceRmbdRR > > Once Fre Once | sed -e 's/:.*//g' > > MP+fencewmbonceonce+fencermbonceonce > > > > while we use 'MP+

[PATCH] tools/memory-model: Rename litmus tests to comply to norm7

2018-05-29 Thread Andrea Parri
norm7 produces the 'normalized' name of a litmus test, when the test can be generated from a single cycle that passes through each process exactly once. The commit renames such tests in order to comply to the naming scheme implemented by this tool. Signed-off-by: Andrea Parri Cc: Alan Stern Cc

Re: [PATCH RFC tools/memory-model] Add litmus-test naming scheme

2018-05-29 Thread Andrea Parri
[...] > > Right, thanks. Ah, maybe we should strive to meet the 80-chars bound > > by splitting the command with "\"? > > We could, but combined with your later request for indentation, we end > up with something like this: > > $ norm7 -bell linux-kernel.bell \ > Rfi Once

Re: [PATCH RFC tools/memory-model] Add litmus-test naming scheme

2018-05-28 Thread Andrea Parri
On Fri, May 25, 2018 at 12:10:20PM -0700, Paul E. McKenney wrote: > This commit documents the scheme used to generate the names for the > litmus tests. > > Signed-off-by: Paul E. McKenney > --- > README | 136 >

Re: [PATCHv2 03/11] atomics: simplify cmpxchg() instrumentation

2018-06-25 Thread Andrea Parri
On Mon, Jun 25, 2018 at 11:59:44AM +0100, Mark Rutland wrote: > Currently we define some fairly verbose wrappers for the cmpxchg() > family so that we can pass a pointer and size into kasan_check_write(). > > The wrapper duplicate the size-switching logic necessary in arch code, > and only work

Re: [PATCH 2/2] tools/memory-model: Add write ordering by release-acquire and by locks

2018-06-25 Thread Andrea Parri
On Fri, Jun 22, 2018 at 07:30:08PM +0100, Will Deacon wrote: > > > I think the second example would preclude us using LDAPR for load-acquire, > I don't think it's a moot point. We want new architectures to implement > acquire/release efficiently, and it's not unlikely that they will have >

Re: [PATCH 2/2] tools/memory-model: Add write ordering by release-acquire and by locks

2018-06-25 Thread Andrea Parri
On Mon, Jun 25, 2018 at 09:32:29AM +0200, Peter Zijlstra wrote: > > I have yet to digest the rest of the discussion, however: > > On Fri, Jun 22, 2018 at 02:09:04PM -0400, Alan Stern wrote: > > The LKMM uses the same CAT code for acquire/release and lock/unlock. > > (In essence, it considers a

Re: [PATCH] MAINTAINERS: Add Daniel Lustig as a LKMM reviewer

2018-06-22 Thread Andrea Parri
an expert in > >this stuff. He requested to be added as a reviewer, which seem sane to Nit: which seems > >me as it'll take a human out of the loop. > > > >CC: Daniel Lustig > >Acked-by: Daniel Lustig > >Signed-off-by: Palmer

[PATCH v2 2/3] locking: Clarify requirements for smp_mb__after_spinlock()

2018-07-02 Thread Andrea Parri
to the barrier to illustrate the requirements and to link them to the idioms which are relied upon at its call sites. Suggested-by: Boqun Feng Signed-off-by: Andrea Parri Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Will Deacon Cc: "Paul E. McKenney" --- Changes since v1: - reworked th

Re: [PATCH 0/2] tools/memory-model: remove ACCESS_ONCE()

2018-07-03 Thread Andrea Parri
> > 1) Merge the file touched by that patch into (the recently created): > > > > Documentation/atomic_t.txt > > > > (FWIW, queued in my TODO list). > > Some consolidation of documentation would be good. ;-) > > Thoughts from others? > > > 2) Add the entry: > > > > F:

Re: [PATCH] refcount: always allow checked forms

2018-07-03 Thread Andrea Parri
Hi Mark, a typo below: > /** > - * refcount_inc - increment a refcount > + * refcount_inc_checked - increment a refcount > * @r: the refcount to increment > * > * Similar to atomic_inc(), but will saturate at UINT_MAX and WARN. > @@ -148,14 +146,14 @@

Re: [PATCH 4/4] exit: Lockless iteration over task list in mm_update_next_owner()

2018-04-26 Thread Andrea Parri
On Thu, Apr 26, 2018 at 04:52:39PM +0300, Kirill Tkhai wrote: > On 26.04.2018 15:35, Andrea Parri wrote: [...] > > > > Mmh, it's possible that I am misunderstanding this statement but it does > > not seem quite correct to me; a counter-example would be provided by the >

Re: [PATCH v1] kthread/smpboot: Serialize kthread parking against wakeup

2018-04-26 Thread Andrea Parri
On Thu, Apr 26, 2018 at 10:41:31AM +0200, Peter Zijlstra wrote: [...] > +/* > + * Special states are those that do not use the normal wait-loop pattern. See > + * the comment with set_special_state(). > + */ > +#define is_special_state(state) \ > + ((state) == TASK_DEAD ||

Re: [PATCH] locking/qspinlock: Ensure node is initialised before updating prev->next

2018-01-31 Thread Andrea Parri
On Wed, Jan 31, 2018 at 01:38:59PM +0100, Peter Zijlstra wrote: > On Wed, Jan 31, 2018 at 12:20:46PM +, Will Deacon wrote: > > diff --git a/kernel/locking/qspinlock.c b/kernel/locking/qspinlock.c > > index 294294c71ba4..1ebbc366a31d 100644 > > --- a/kernel/locking/qspinlock.c > > +++

[PATCH 1/2] tools/memory-model: clarify the origin/scope of the tool name

2018-02-01 Thread Andrea Parri
tools/memory-model/, the term "memory-model" is used as shorthand for "memory consistency model" by calling out this convention in tools/memory-model/README. Stick to the full name in sources' headers and for the subsystem name. Suggested-by: Ingo Molnar <mi...@kernel.org

[PATCH 2/2] MAINTAINERS: add the Memory Consistency Model subsystem

2018-02-01 Thread Andrea Parri
Integrate (and then remove) tools/memory-model/MAINTAINERS into the main MAINTAINERS file. This way get_maintainer.pl can give a "right answer" for tools/memory-model/. Suggested-by: Ingo Molnar <mi...@kernel.org> Signed-off-by: Andrea Parri <parri.and...@gmail.co

Re: [PATCH 1/2] tools/memory-model: clarify the origin/scope of the tool name

2018-02-02 Thread Andrea Parri
On Fri, Feb 02, 2018 at 03:19:22PM -0800, Paul E. McKenney wrote: > On Fri, Feb 02, 2018 at 11:44:21AM +0100, Andrea Parri wrote: > > On Thu, Feb 01, 2018 at 03:09:41PM -0800, Paul E. McKenney wrote: > > > On Thu, Feb 01, 2018 at 10:26:50AM -0500, Alan Stern wrote: > >

Re: [PATCH 2/2] MAINTAINERS: list file memory-barriers.txt within the LKMM entry

2018-02-02 Thread Andrea Parri
On Fri, Feb 02, 2018 at 03:51:02PM -0800, Paul E. McKenney wrote: > On Fri, Feb 02, 2018 at 10:13:42AM +0100, Andrea Parri wrote: > > Now that a formal specification of the LKMM has become available to > > the developer, some concern about how to track changes to the model &

Re: [PATCH 2/2] MAINTAINERS: add the Memory Consistency Model subsystem

2018-02-01 Thread Andrea Parri
On Thu, Feb 01, 2018 at 01:44:01PM +, Will Deacon wrote: > On Thu, Feb 01, 2018 at 01:04:26PM +0100, Andrea Parri wrote: > > Integrate (and then remove) tools/memory-model/MAINTAINERS into the > > main MAINTAINERS file. This way get_maintainer.pl can give a "right > >

Re: [PATCH 1/2] tools/memory-model: clarify the origin/scope of the tool name

2018-02-02 Thread Andrea Parri
On Thu, Feb 01, 2018 at 03:09:41PM -0800, Paul E. McKenney wrote: > On Thu, Feb 01, 2018 at 10:26:50AM -0500, Alan Stern wrote: > > On Thu, 1 Feb 2018, Andrea Parri wrote: > > > > > Ingo pointed out that: > > > > > > "The "memory m

[PATCH 1/2] Documentation/memory-barriers.txt: cross-reference "tools/memory-model/"

2018-02-02 Thread Andrea Parri
gn". Make sure that the (occasional) reader of memory-barriers.txt will be aware of these developments. [1] https://marc.info/?l=linux-kernel=151687290114799=2 Signed-off-by: Andrea Parri <parri.and...@gmail.com> --- Documentation/memory-barriers.txt | 4 +++- 1 file changed, 3 insertions(+),

[PATCH 2/2] MAINTAINERS: list file memory-barriers.txt within the LKMM entry

2018-02-02 Thread Andrea Parri
(and responsibility!!) of such documentation (here, memory-barriers.txt) to the maintainers of the LKMM themselves. Suggested-by: Will Deacon <will.dea...@arm.com> Signed-off-by: Andrea Parri <parri.and...@gmail.com> --- On top of: https://marc.info/?l=linux-kernel=15174866863204

Re: [PATCH 1/2] tools/memory-model: clarify the origin/scope of the tool name

2018-02-02 Thread Andrea Parri
On Thu, Feb 01, 2018 at 03:09:41PM -0800, Paul E. McKenney wrote: > On Thu, Feb 01, 2018 at 10:26:50AM -0500, Alan Stern wrote: > > On Thu, 1 Feb 2018, Andrea Parri wrote: > > > > > Ingo pointed out that: > > > > > > "The "memory m

Re: [GIT PULL tools] Linux kernel memory model

2018-02-04 Thread Andrea Parri
On Sun, Feb 04, 2018 at 02:17:00AM -0800, Paul E. McKenney wrote: [...] > And here is the updated commit adding comments to the litmus test, > which adds comments for the three litmus tests added above. I have also > marked this commit with "EXP" indicating that it has not yet had time > for

Re: [PATCH 1/2] Documentation/memory-barriers.txt: cross-reference "tools/memory-model/"

2018-02-04 Thread Andrea Parri
as a reply to your message, plus CC: to me. [CCing lists and other people] > > On Fri, Feb 02, 2018 at 17:21:03AM -0800, Paul E. McKenney wrote: > > On Fri, Feb 02, 2018 at 10:12:48AM +0100, Andrea Parri wrote: > >> Recent efforts led to the specification of a memory consist

Re: [PATCH v2 1/3] sched: Stop nohz stats when decayed

2018-02-09 Thread Andrea Parri
On Thu, Feb 08, 2018 at 04:03:41PM +, Will Deacon wrote: > On Thu, Feb 08, 2018 at 04:46:43PM +0100, Peter Zijlstra wrote: > > On Thu, Feb 08, 2018 at 03:30:31PM +, Will Deacon wrote: > > > On Thu, Feb 08, 2018 at 03:00:05PM +0100, Peter Zijlstra wrote: > > > > > > Without this ordering I

Re: [PATCH 1/2] Documentation/memory-barriers.txt: cross-reference "tools/memory-model/"

2018-02-09 Thread Andrea Parri
On Fri, Feb 09, 2018 at 06:29:23AM -0800, Paul E. McKenney wrote: > On Fri, Feb 09, 2018 at 01:50:51PM +0100, Andrea Parri wrote: > > On Fri, Feb 09, 2018 at 04:31:00AM -0800, Paul E. McKenney wrote: > > > On Sun, Feb 04, 2018 at 07:37:08PM +0100, Andrea Parri wrote

Re: [GIT PULL tools] Linux kernel memory model

2018-02-09 Thread Andrea Parri
On Fri, Feb 09, 2018 at 03:29:37AM -0800, Paul E. McKenney wrote: > On Fri, Feb 09, 2018 at 10:11:10AM +0100, Andrea Parri wrote: > > On Thu, Feb 08, 2018 at 09:02:19PM +0100, Peter Zijlstra wrote: > > > On Thu, Feb 08, 2018 at 06:41:06PM +, Patrick Bellasi wrot

Re: [PATCH 1/2] Documentation/memory-barriers.txt: cross-reference "tools/memory-model/"

2018-02-09 Thread Andrea Parri
On Fri, Feb 09, 2018 at 04:31:00AM -0800, Paul E. McKenney wrote: > On Sun, Feb 04, 2018 at 07:37:08PM +0100, Andrea Parri wrote: > > Hi Akira, > > > > On Mon, Feb 05, 2018 at 01:14:10AM +0900, Akira Yokosawa wrote: > > > Hi Paul, > > > CC: Andrea > >

  1   2   3   >